[GitHub] [apisix-dashboard] Caelebs opened a new issue #487: Plugin configuration not available

2020-09-19 Thread GitBox
Caelebs opened a new issue #487: URL: https://github.com/apache/apisix-dashboard/issues/487 #387 # Question - What do you want to know? VM85:1 GET http://10.10.16.249/apisix/admin/plugins **400** (Bad Request) 界面提示“请启用至少一种身份认证类插件” ![image](https://user-images.githubuserconte

[GitHub] [apisix] membphis merged pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
membphis merged pull request #2241: URL: https://github.com/apache/apisix/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feature: `consumer` provides access to a collection of `service` (#2241)

2020-09-19 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new e94a5b3 feature: `consumer` provides access t

[apisix] branch master updated: test: also lint the test helpers (#2252)

2020-09-19 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 8493a60 test: also lint the test helpers (#22

[GitHub] [apisix] membphis merged pull request #2252: test: also lint the test helpers

2020-09-19 Thread GitBox
membphis merged pull request #2252: URL: https://github.com/apache/apisix/pull/2252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #2215: Used TscanCode scan the lua code,it report two code defects

2020-09-19 Thread GitBox
membphis closed issue #2215: URL: https://github.com/apache/apisix/issues/2215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis commented on pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
membphis commented on pull request #2241: URL: https://github.com/apache/apisix/pull/2241#issuecomment-695201614 @Firstsawyou Please confirm that you have fixed all the points requested by the reviewer and leave a message. Especially the part that @moonming asked you to modi

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491395834 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -29,11 +33,12 @@ local schema = { type = "array", items = {type =

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491395601 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.acce

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491396871 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.acce

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491397282 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,665 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create se

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491399770 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create se

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491399667 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create se

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491400928 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +541,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create se

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r491401561 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +83,30 @@ function _M.check_schema(conf) return true end + function _M.acce

[GitHub] [apisix] moonming commented on pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
moonming commented on pull request #2241: URL: https://github.com/apache/apisix/pull/2241#issuecomment-695205097 @Firstsawyou please read Apache code of conduct: https://github.com/apache/apisix/blob/master/CODE_OF_CONDUCT.md. Replying to someone’s review is a kind of respect, which is

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #488: feat: add SSL refactoring

2020-09-19 Thread GitBox
nic-chen opened a new pull request #488: URL: https://github.com/apache/apisix-dashboard/pull/488 Please answer these questions before submitting a pull request - Why submit this pull request? SSL refactoring --

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #486: feat: add consumer CURD refactoring

2020-09-19 Thread GitBox
nic-chen commented on a change in pull request #486: URL: https://github.com/apache/apisix-dashboard/pull/486#discussion_r491408586 ## File path: api/route/base.go ## @@ -37,19 +38,20 @@ func SetUpRouter() *gin.Engine { r := gin.New() store := cookie.NewStore([]

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #486: feat: add consumer CURD refactoring

2020-09-19 Thread GitBox
nic-chen commented on a change in pull request #486: URL: https://github.com/apache/apisix-dashboard/pull/486#discussion_r491411145 ## File path: api/internal/handler/consumer/consumer.go ## @@ -0,0 +1,135 @@ +package consumer + +import ( + "reflect" + "strings" + +

[GitHub] [apisix] Firstsawyou commented on pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on pull request #2241: URL: https://github.com/apache/apisix/pull/2241#issuecomment-695209906 > @Firstsawyou please read Apache code of conduct: https://github.com/apache/apisix/blob/master/CODE_OF_CONDUCT.md. > Replying to someone’s review is a kind of respect, whi

[GitHub] [apisix] Firstsawyou commented on pull request #2241: feature: `consumer` provides access to a collection of `service`

2020-09-19 Thread GitBox
Firstsawyou commented on pull request #2241: URL: https://github.com/apache/apisix/pull/2241#issuecomment-695210405 > @Firstsawyou > > Please confirm that you have fixed all the points requested by the reviewer and leave a message. > > Especially the part that @moonming asked

[GitHub] [apisix] UnderTreeTech closed pull request #1947: feature: add wechat pay signature plugin

2020-09-19 Thread GitBox
UnderTreeTech closed pull request #1947: URL: https://github.com/apache/apisix/pull/1947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix] UnderTreeTech closed issue #1900: request help: signature plugin

2020-09-19 Thread GitBox
UnderTreeTech closed issue #1900: URL: https://github.com/apache/apisix/issues/1900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] UnderTreeTech closed issue #1820: request help: how to get request body and url parameters

2020-09-19 Thread GitBox
UnderTreeTech closed issue #1820: URL: https://github.com/apache/apisix/issues/1820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming commented on issue #1900: request help: signature plugin

2020-09-19 Thread GitBox
moonming commented on issue #1900: URL: https://github.com/apache/apisix/issues/1900#issuecomment-695218756 @UnderTreeTech why close this issue and pr?anything I can help? This is an automated message from the Apache Git Serv

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #489: feat: Upstream health check

2020-09-19 Thread GitBox
liuxiran opened a new pull request #489: URL: https://github.com/apache/apisix-dashboard/pull/489 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream

2020-09-19 Thread GitBox
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695333690 `active.type` is mentioned in the test case [=== TEST 6: invalid route: wrong active.type](https://github.com/apache/apisix/blob/8493a607ce869ab335eac1d0e799ffecff10fb93/t/a

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-19 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695364533 > `active.type` is mentioned in the test case [=== TEST 6: invalid route: wrong active.type](https://github.com/apache/apisix/blob/8493a607ce869ab335eac1d0e799ffecff10fb93/

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #489: feat: Upstream health check

2020-09-19 Thread GitBox
juzhiyuan commented on pull request #489: URL: https://github.com/apache/apisix-dashboard/pull/489#issuecomment-695364582 waiting for https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695333690 This is an au

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #488: feat: add SSL refactoring

2020-09-19 Thread GitBox
juzhiyuan commented on a change in pull request #488: URL: https://github.com/apache/apisix-dashboard/pull/488#discussion_r491588924 ## File path: api/internal/handler/ssl/ssl.go ## @@ -0,0 +1,252 @@ +package ssl + +import ( + "crypto/tls" + "crypto/x509" + "e

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #482: feat: update plugin

2020-09-19 Thread GitBox
juzhiyuan commented on pull request #482: URL: https://github.com/apache/apisix-dashboard/pull/482#issuecomment-695365205 @moonming it seems some PRs' approval check has been closed? This is an automated message from the Apac

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #487: Plugin configuration not available

2020-09-19 Thread GitBox
juzhiyuan commented on issue #487: URL: https://github.com/apache/apisix-dashboard/issues/487#issuecomment-695365378 it seems that this API doesn't work on your side, could you provide more information about how to deploy it? --

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #488: feat: add SSL refactoring

2020-09-19 Thread GitBox
nic-chen commented on a change in pull request #488: URL: https://github.com/apache/apisix-dashboard/pull/488#discussion_r491637228 ## File path: api/internal/handler/ssl/ssl.go ## @@ -0,0 +1,252 @@ +package ssl + +import ( + "crypto/tls" + "crypto/x509" + "en

[GitHub] [apisix-docker] zsq1234 opened a new issue #77: Illegal instruction (core dumped)

2020-09-19 Thread GitBox
zsq1234 opened a new issue #77: URL: https://github.com/apache/apisix-docker/issues/77 Hi~, I have an error I don't know how to deal. my operation: 1. docker run --rm -it apache/apisix:latest /bin/sh 2. apisix version / apisix init then "Illegal instruction (core dumped)"

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #486: feat: add consumer CURD refactoring

2020-09-19 Thread GitBox
juzhiyuan merged pull request #486: URL: https://github.com/apache/apisix-dashboard/pull/486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch refactor updated: feat: add consumer CURD refactoring (#486)

2020-09-19 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/refactor by this push: new 33623e8 feat: add consumer CUR