[GitHub] [apisix] moonming commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
moonming commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502753558 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,221 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribut

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502755951 ## File path: t/plugin/api-breaker.t ## @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502755526 ## File path: doc/zh-cn/plugins/api-breaker.md ## @@ -0,0 +1,107 @@ + + +- [English](../../plugins/api-blocker.md) + +# 目录 + +- [**定义**](#定义) +- [**

[GitHub] [apisix] idbeta opened a new issue #2375: request help: setted a special uri in route,when request it,it return 404

2020-10-09 Thread GitBox
idbeta opened a new issue #2375: URL: https://github.com/apache/apisix/issues/2375 ### Issue description curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' {"uri": "/helloh~E]ftXnj2Hs#r9&Rg:Y/;o-OI,uN7Le!P_J+w.zi4C0aDA3WMqU1T

[GitHub] [apisix-control-plane] gxthrj opened a new issue #28: feat: Minimal runnable version about yaml declarative definition

2020-10-09 Thread GitBox
gxthrj opened a new issue #28: URL: https://github.com/apache/apisix-control-plane/issues/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] moonming commented on issue #547: bug: API后端服务配置域名的bug

2020-10-09 Thread GitBox
moonming commented on issue #547: URL: https://github.com/apache/apisix-dashboard/issues/547#issuecomment-706495851 @tangjun2012 Did you specify the host header of domain name 1 in your client request? If not, you will meet the current situation --

[GitHub] [apisix] membphis commented on issue #2369: bug: Unable to get the latest upstream node list by service discovery

2020-10-09 Thread GitBox
membphis commented on issue #2369: URL: https://github.com/apache/apisix/issues/2369#issuecomment-706495729 @qiujiayu Do you have time to look at this issue? This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] membphis commented on pull request #2368: WIP: add uri fuzzing test

2020-10-09 Thread GitBox
membphis commented on pull request #2368: URL: https://github.com/apache/apisix/pull/2368#issuecomment-706495616 @idbeta code style: https://github.com/apache/apisix/pull/2368/checks?check_run_id=1234621149#step:6:124 You need to write a summary first. Why we need this PR?

[GitHub] [apisix] membphis commented on pull request #2374: chore: rm folder 'logs' in root and replace baidu.com with github.com in test cases

2020-10-09 Thread GitBox
membphis commented on pull request #2374: URL: https://github.com/apache/apisix/pull/2374#issuecomment-706494615 @dabue CI failed, please take a look at it. https://github.com/apache/apisix/pull/2374/checks?check_run_id=1234496186#step:6:51 -

[apisix-dashboard] branch feat-route updated (8dabef4 -> 8af4181)

2020-10-09 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch feat-route in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 8dabef4 feat(Route): update typing add 2e057c0 feat: deleting hosts when hosts is empty add

[GitHub] [apisix] membphis commented on a change in pull request #2340: feature: limit-count use redis cluster

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2340: URL: https://github.com/apache/apisix/pull/2340#discussion_r502743834 ## File path: doc/zh-cn/plugins/limit-count.md ## @@ -26,17 +26,18 @@ ## 参数 -| 名称 | 类型| 必选项 | 默认值 | 有效值

[GitHub] [apisix] dabue opened a new pull request #2374: chore: rm folder 'logs' in root

2020-10-09 Thread GitBox
dabue opened a new pull request #2374: URL: https://github.com/apache/apisix/pull/2374 fix #2370 to remove the logs dir. This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502743561 ## File path: t/plugin/api-breaker.t ## @@ -0,0 +1,219 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502743189 ## File path: doc/plugins/api-breaker.md ## @@ -0,0 +1,106 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) + +# Summary + +- [**Name**](#name) +- [**Attri

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #547: bug: API后端服务配置域名的bug

2020-10-09 Thread GitBox
juzhiyuan commented on issue #547: URL: https://github.com/apache/apisix-dashboard/issues/547#issuecomment-706483513 We should check what is the Request Body sent to API, then check if this issue is related to frontend or backend, this issue would be addressed before 1.6 release. --

[GitHub] [apisix-dashboard] tangjun2012 opened a new issue #547: bug: API后端服务配置域名的bug

2020-10-09 Thread GitBox
tangjun2012 opened a new issue #547: URL: https://github.com/apache/apisix-dashboard/issues/547 ### Issue description 如图,1.5版本中,配置域名的时候,在目标服务器接收到的是ip,而不是域名,如:http://dashboard.apisix.dev/routes/4b84e67a-f874-4554-b3f6-906306116860/edit 即:我有多个域名指向了同一台服务器,对应不同的服务,其中ip=>服务A,域名1=>服务b,域名2=

[GitHub] [apisix] liuhengloveyou commented on issue #2157: request help: apisix 1.3 upgrade apisix 1.5,admin api occur 403

2020-10-09 Thread GitBox
liuhengloveyou commented on issue #2157: URL: https://github.com/apache/apisix/issues/2157#issuecomment-706481050 > @liuhengloveyou please take a look OK This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-control-plane] gxthrj commented on a change in pull request #27: doc: enrich readme

2020-10-09 Thread GitBox
gxthrj commented on a change in pull request #27: URL: https://github.com/apache/apisix-control-plane/pull/27#discussion_r502740724 ## File path: README.md ## @@ -21,25 +21,27 @@ ## What is apisix-control-plane -apisix-control-plane is an implementation of providing a con

[GitHub] [apisix-control-plane] gxthrj commented on a change in pull request #27: doc: enrich readme

2020-10-09 Thread GitBox
gxthrj commented on a change in pull request #27: URL: https://github.com/apache/apisix-control-plane/pull/27#discussion_r502740707 ## File path: README.md ## @@ -17,18 +17,50 @@ # --> -# apisix-control-plane +# APISIX-CONTROL-PLANE -## what is apisix-control-plane? -api

[GitHub] [apisix] gy09535 closed issue #2151: feature: Best practice for jaeger

2020-10-09 Thread GitBox
gy09535 closed issue #2151: URL: https://github.com/apache/apisix/issues/2151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502739912 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502739942 ## File path: doc/plugins/api-breaker.md ## @@ -0,0 +1,102 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) + +# Summary + +- [**Name**](#name) +- [*

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502739718 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502739673 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,212 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] codjust commented on issue #2151: feature: Best practice for jaeger

2020-10-09 Thread GitBox
codjust commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-706474223 > > > After retry I think use zipkin plugin to send v2 span can work, ref: https://www.jaegertracing.io/docs/1.19/getting-started/ > > > > > > good! it can work with jaeger

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502736840 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502736617 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,212 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] spacewander edited a comment on issue #2280: Route traffic through company proxy / firewall

2020-10-09 Thread GitBox
spacewander edited a comment on issue #2280: URL: https://github.com/apache/apisix/issues/2280#issuecomment-706471374 @MrLightSpeed0 > i believe all companies have this implemented. Yes. My company requires a forward proxy to access inner infra. The solution they told me and I h

[GitHub] [apisix] spacewander commented on issue #2280: Route traffic through company proxy / firewall

2020-10-09 Thread GitBox
spacewander commented on issue #2280: URL: https://github.com/apache/apisix/issues/2280#issuecomment-706471374 @MrLightSpeed0 > i believe all companies have this implemented. Yes. My company requires a forward proxy to access inner infra. The solution they told me and I have bee

[GitHub] [apisix] gy09535 commented on issue #2151: feature: Best practice for jaeger

2020-10-09 Thread GitBox
gy09535 commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-706468244 > > After retry I think use zipkin plugin to send v2 span can work, ref: https://www.jaegertracing.io/docs/1.19/getting-started/ > > good! it can work with jaeger tracing? >

[GitHub] [apisix] liuhengloveyou commented on issue #2280: Route traffic through company proxy / firewall

2020-10-09 Thread GitBox
liuhengloveyou commented on issue #2280: URL: https://github.com/apache/apisix/issues/2280#issuecomment-706467734 > Hi Maybe I didnt explain clearly... I dont think the proxy-rewrite will solve the issue. basically, I am calling from inside a company, which has a forward proxy to access ou

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502731996 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,208 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribut

[GitHub] [apisix] membphis edited a comment on pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis edited a comment on pull request #2339: URL: https://github.com/apache/apisix/pull/2339#issuecomment-701144285 @liuhengloveyou please confirm your ENV, all test cases fail :( ```shell $ prove t/plugin/api-breaker.t t/plugin/api-breaker.t .. 1/? # Failed test 'T

[GitHub] [apisix] liuhengloveyou edited a comment on pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou edited a comment on pull request #2339: URL: https://github.com/apache/apisix/pull/2339#issuecomment-701166312 > @liuhengloveyou please confirm your ENV, all test cases fail :( sorry. updated This is an

[GitHub] [apisix] moonming opened a new pull request #2373: doc: add user story about eFactory.

2020-10-09 Thread GitBox
moonming opened a new pull request #2373: URL: https://github.com/apache/apisix/pull/2373 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have yo

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502731483 ## File path: doc/plugins/api-breaker.md ## @@ -0,0 +1,102 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) + +# Summary + +- [**Name**](#name) +- [**Attri

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502731314 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribut

[GitHub] [apisix] tangjun2012 opened a new issue #2372: bug: API后端服务配置域名的bug

2020-10-09 Thread GitBox
tangjun2012 opened a new issue #2372: URL: https://github.com/apache/apisix/issues/2372 ### Issue description 如图,1.5版本中,配置域名的时候,在目标服务器接收到的是ip,而不是域名,如:http://dashboard.apisix.dev/routes/4b84e67a-f874-4554-b3f6-906306116860/edit 即:我有多个域名指向了同一台服务器,对应不同的服务,其中ip=>服务A,域名1=>服务b,域名2=>服务c,当我在

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2340: feature: limit-count use redis cluster

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2340: URL: https://github.com/apache/apisix/pull/2340#discussion_r502730066 ## File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua ## @@ -0,0 +1,139 @@ +-- +-- Licensed to the Apache Software Foundation (ASF)

[apisix] branch membphis-patch-1 updated (b0a54bb -> 5ecf755)

2020-10-09 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch membphis-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from b0a54bb chore: apisix logo add 5ecf755 chore: added link in readme. No new revisions were added b

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502729046 ## File path: doc/plugins/api-breaker.md ## @@ -0,0 +1,102 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) + +# Summary + +- [**Name**](#name) +- [*

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502727976 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502728026 ## File path: doc/plugins/api-blocker.md ## @@ -0,0 +1,102 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) Review comment: updated -

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502727826 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502727531 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix] membphis opened a new pull request #2371: chore: upload apisix logo image

2020-10-09 Thread GitBox
membphis opened a new pull request #2371: URL: https://github.com/apache/apisix/pull/2371 ### What this PR does / why we need it: as title. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added?

[apisix] branch membphis-patch-1 updated: chore: apisix logo

2020-10-09 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch membphis-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/membphis-patch-1 by this push: new b0a54bb chore: apisix log

[apisix] branch membphis-patch-1 created (now 251625d)

2020-10-09 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch membphis-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 251625d bugfix: set random seed for each worker process at `init_worker` phase, only `init` phase is no

[GitHub] [apisix] membphis opened a new issue #2370: chore: remove folder `logs` in root

2020-10-09 Thread GitBox
membphis opened a new issue #2370: URL: https://github.com/apache/apisix/issues/2370 We can delete the "logs" folder from the "root" directory. https://github.com/apache/apisix/tree/master/logs This is an autom

[GitHub] [apisix] tzssangglass commented on issue #1195: feature: support multiple ports like stream listen in http and https listen port.

2020-10-09 Thread GitBox
tzssangglass commented on issue #1195: URL: https://github.com/apache/apisix/issues/1195#issuecomment-706462218 > @tzssangglass no problem. I have assigned this issue to you. If you have any questions, please feel free to talk to me. ok -

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2340: feature: limit-count use redis cluster

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2340: URL: https://github.com/apache/apisix/pull/2340#discussion_r502726892 ## File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua ## @@ -0,0 +1,139 @@ +-- +-- Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2340: feature: limit-count use redis cluster

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2340: URL: https://github.com/apache/apisix/pull/2340#discussion_r502726826 ## File path: rockspec/apisix-master-0.rockspec ## @@ -54,6 +54,7 @@ dependencies = { "skywalking-nginx-lua-plugin = 1.0-0", "base64 = 1.5

[GitHub] [apisix] membphis commented on a change in pull request #2340: feature: limit-count use redis cluster

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2340: URL: https://github.com/apache/apisix/pull/2340#discussion_r502721349 ## File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua ## @@ -0,0 +1,139 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix] membphis commented on issue #1195: feature: support multiple ports like stream listen in http and https listen port.

2020-10-09 Thread GitBox
membphis commented on issue #1195: URL: https://github.com/apache/apisix/issues/1195#issuecomment-706452917 @tzssangglass no problem. I have assigned this issue to you. If you have any questions, please feel free to talk to me. -

[GitHub] [apisix] membphis commented on pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on pull request #2339: URL: https://github.com/apache/apisix/pull/2339#issuecomment-706452466 @liuhengloveyou ![image](https://user-images.githubusercontent.com/6814606/95640793-17487800-0ad1-11eb-9872-d350f63ab1c3.png) --

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502718278 ## File path: doc/plugins/api-breaker.md ## @@ -0,0 +1,102 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) + +# Summary + +- [**Name**](#name) +- [**Attri

[GitHub] [apisix] tzssangglass commented on issue #1195: feature: support multiple ports like stream listen in http and https listen port.

2020-10-09 Thread GitBox
tzssangglass commented on issue #1195: URL: https://github.com/apache/apisix/issues/1195#issuecomment-706298454 I want to solve this issues. This is my first time to participate in apisix. Can I choose @membphis as a mentor. The deadline I gave is October 18. ---

[GitHub] [apisix] MrLightSpeed0 commented on issue #2280: Route traffic through company proxy / firewall

2020-10-09 Thread GitBox
MrLightSpeed0 commented on issue #2280: URL: https://github.com/apache/apisix/issues/2280#issuecomment-706275290 @spacewander and @liuhengloveyou exactly, first to answer your question, the forward proxy (if this term means different to you. I am sorry for the confusion) is a plain http

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502259561 ## File path: apisix/plugins/api-breaker.lua ## @@ -0,0 +1,214 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribut

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2340: feature: limit-count use redis cluster

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2340: URL: https://github.com/apache/apisix/pull/2340#discussion_r502481627 ## File path: doc/plugins/limit-count.md ## @@ -109,6 +110,41 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335

[GitHub] [apisix] membphis commented on pull request #2367: change: refactor router

2020-10-09 Thread GitBox
membphis commented on pull request #2367: URL: https://github.com/apache/apisix/pull/2367#issuecomment-706179659 nice PR ^_^ This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] tokers commented on issue #2361: perf: use `table.isarray` which is can be JIT compiled

2020-10-09 Thread GitBox
tokers commented on issue #2361: URL: https://github.com/apache/apisix/issues/2361#issuecomment-705933840 I have committed a PR to optimize it: https://github.com/apache/apisix/pull/2365 :). This is an automated message from

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #535: feat: refactor apis for existing check and other apis

2020-10-09 Thread GitBox
membphis commented on a change in pull request #535: URL: https://github.com/apache/apisix-dashboard/pull/535#discussion_r502209694 ## File path: api/internal/handler/ssl/ssl.go ## @@ -54,14 +57,16 @@ func (h *Handler) ApplyRoute(r *gin.Engine) { wrapper.InputTy

[GitHub] [apisix-dashboard] ShiningRush commented on issue #537: bug: respond status of api should keep same as `admin api` do

2020-10-09 Thread GitBox
ShiningRush commented on issue #537: URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] liuxiran merged pull request #2345: feat: Add lables for route/consumer/service/ssl objects

2020-10-09 Thread GitBox
liuxiran merged pull request #2345: URL: https://github.com/apache/apisix/pull/2345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] moonming commented on issue #546: [refactor] license issue of refactored `api`

2020-10-09 Thread GitBox
moonming commented on issue #546: URL: https://github.com/apache/apisix-dashboard/issues/546#issuecomment-706176538 ok, I will fix it This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] membphis commented on a change in pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2364: URL: https://github.com/apache/apisix/pull/2364#discussion_r502162916 ## File path: apisix/plugins/kafka-logger.lua ## @@ -32,6 +32,11 @@ local buffers = {} local schema = { type = "object", properties = { +

[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis

2020-10-09 Thread GitBox
nic-chen commented on pull request #535: URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705931099 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix-helm-chart] ziyou434 commented on issue #2: failed to fetch data from etcd

2020-10-09 Thread GitBox
ziyou434 commented on issue #2: URL: https://github.com/apache/apisix-helm-chart/issues/2#issuecomment-706075193 那么是chart的问题还是我的问题呢,我应该如何改进他 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis

2020-10-09 Thread GitBox
moonming commented on pull request #535: URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705999345 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #539: bug: [refactor] test case run failed sometimes

2020-10-09 Thread GitBox
juzhiyuan commented on issue #539: URL: https://github.com/apache/apisix-dashboard/issues/539#issuecomment-705994464 not sure what happened, cc @ShiningRush This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix-dashboard] nic-chen commented on issue #537: bug: respond status of api should keep same as `admin api` do

2020-10-09 Thread GitBox
nic-chen commented on issue #537: URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705945254 As far as I know, some users have already used `http status` in their system, if we do not maintain the original `http status `, they will have to modify the code. M

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #543: feat: refactor consumer

2020-10-09 Thread GitBox
juzhiyuan merged pull request #543: URL: https://github.com/apache/apisix-dashboard/pull/543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] moonming merged pull request #2365: optimize: use table.isarray to check whether table is an array.

2020-10-09 Thread GitBox
moonming merged pull request #2365: URL: https://github.com/apache/apisix/pull/2365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #542: feature: [refactor] embedding static files into Go binaries

2020-10-09 Thread GitBox
juzhiyuan commented on issue #542: URL: https://github.com/apache/apisix-dashboard/issues/542#issuecomment-705993245 @bzp2010 is working on this issue, please let @nic-chen know whenever there have any blocker issues. This

[GitHub] [apisix] moonming commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
moonming commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r502186636 ## File path: doc/plugins/api-blocker.md ## @@ -0,0 +1,102 @@ + + +- [中文](../zh-cn/plugins/api-blocker.md) Review comment: `blocker` or `breaker`?

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #535: feat: refactor apis for existing check and other apis

2020-10-09 Thread GitBox
juzhiyuan commented on pull request #535: URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706039192 Please link this PR in those issues :D This is an automated message from the Apache Git Service. To res

[GitHub] [apisix] nic-chen commented on a change in pull request #2345: feat: Add lables for route/consumer/service/ssl objects

2020-10-09 Thread GitBox
nic-chen commented on a change in pull request #2345: URL: https://github.com/apache/apisix/pull/2345#discussion_r502129503 ## File path: apisix/schema_def.lua ## @@ -555,6 +580,14 @@ _M.ssl = { type = "integer", minimum = 1588262400, -- 2020/5/1 0:0:

[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
membphis commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r501548363 ## File path: conf/config-default-dev.yaml ## @@ -0,0 +1,203 @@ +# Review comment: I do not think we need `conf/config-default-dev.yaml` for CI.

[GitHub] [apisix] membphis commented on issue #2366: bug: gRPC transcoding plugin how to support import other proto file?

2020-10-09 Thread GitBox
membphis commented on issue #2366: URL: https://github.com/apache/apisix/issues/2366#issuecomment-706053507 @nic-chen do you know how to resolve this issue? This is an automated message from the Apache Git Service. To respond

[apisix-dashboard] branch refactor updated: fix: append sort for list and using sync.Map instead of map

2020-10-09 Thread vinci
This is an automated email from the ASF dual-hosted git repository. vinci pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/refactor by this push: new e7c00d2 fix: append sort for list

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #466: bug: a related to route basic-auth consumer should not be deleted

2020-10-09 Thread GitBox
juzhiyuan commented on issue #466: URL: https://github.com/apache/apisix-dashboard/issues/466#issuecomment-705929758 so this issue has been resolved? @ShiningRush This is an automated message from the Apache Git Service. To

[GitHub] [apisix] nic-chen commented on a change in pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.

2020-10-09 Thread GitBox
nic-chen commented on a change in pull request #2364: URL: https://github.com/apache/apisix/pull/2364#discussion_r502171779 ## File path: apisix/plugins/kafka-logger.lua ## @@ -32,6 +32,11 @@ local buffers = {} local schema = { type = "object", properties = { +

[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api

2020-10-09 Thread GitBox
liuhengloveyou commented on a change in pull request #2339: URL: https://github.com/apache/apisix/pull/2339#discussion_r501516429 ## File path: conf/config-default-dev.yaml ## @@ -0,0 +1,203 @@ +# Review comment: How do I resolve the CI error? ## File path: con

[GitHub] [apisix-helm-chart] membphis commented on issue #2: failed to fetch data from etcd

2020-10-09 Thread GitBox
membphis commented on issue #2: URL: https://github.com/apache/apisix-helm-chart/issues/2#issuecomment-706074242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #540: feature: [refactor] support json schema check

2020-10-09 Thread GitBox
juzhiyuan commented on issue #540: URL: https://github.com/apache/apisix-dashboard/issues/540#issuecomment-705994003 May I ask if this issue would be resolved in 1.6? This is an automated message from the Apache Git Service.

[GitHub] [apisix] membphis commented on pull request #2306: 1.fix generation of uuid;

2020-10-09 Thread GitBox
membphis commented on pull request #2306: URL: https://github.com/apache/apisix/pull/2306#issuecomment-706052308 resolve this bug by another PR: https://github.com/apache/apisix/pull/2357 I think we can close this PR. @zlm0125 ---

[GitHub] [apisix] moonming commented on issue #2157: request help: apisix 1.3 upgrade apisix 1.5,admin api occur 403

2020-10-09 Thread GitBox
moonming commented on issue #2157: URL: https://github.com/apache/apisix/issues/2157#issuecomment-706091628 @liuhengloveyou please take a look This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [apisix] moonming merged pull request #2364: feat: add new filed `meta_style`, collect the request information with `original` style.

2020-10-09 Thread GitBox
moonming merged pull request #2364: URL: https://github.com/apache/apisix/pull/2364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming closed issue #2361: perf: use `table.isarray` which is can be JIT compiled

2020-10-09 Thread GitBox
moonming closed issue #2361: URL: https://github.com/apache/apisix/issues/2361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis merged pull request #2357: bugfix: set random seed for each worker process at `init_worker` phase, only `init` phase is not enough.

2020-10-09 Thread GitBox
membphis merged pull request #2357: URL: https://github.com/apache/apisix/pull/2357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] gy09535 commented on issue #2151: feature: Best practice for jaeger

2020-10-09 Thread GitBox
gy09535 commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-706060672 After retry I think use zipkin plugin to send v2 span can work, ref: https://www.jaegertracing.io/docs/1.19/getting-started/ -

[GitHub] [apisix] liuxiran commented on a change in pull request #2345: feat: Add lables for route/consumer/service/ssl objects

2020-10-09 Thread GitBox
liuxiran commented on a change in pull request #2345: URL: https://github.com/apache/apisix/pull/2345#discussion_r502122002 ## File path: t/admin/consumers.t ## @@ -223,3 +223,78 @@ GET /t {"error_msg":"missing consumer name"} --- no_error_log [error] + + + +=== TEST 7: add

[GitHub] [apisix] idbeta commented on pull request #2273: test: add integration test

2020-10-09 Thread GitBox
idbeta commented on pull request #2273: URL: https://github.com/apache/apisix/pull/2273#issuecomment-705995882 There are too many questions about this pr, close it, let me create another pr,thank u all. This is an automated

[GitHub] [apisix] idbeta closed pull request #2273: test: add integration test

2020-10-09 Thread GitBox
idbeta closed pull request #2273: URL: https://github.com/apache/apisix/pull/2273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] imjoey commented on a change in pull request #2345: feat: Add lables for route/consumer/service/ssl objects

2020-10-09 Thread GitBox
imjoey commented on a change in pull request #2345: URL: https://github.com/apache/apisix/pull/2345#discussion_r502123384 ## File path: apisix/schema_def.lua ## @@ -555,6 +580,14 @@ _M.ssl = { type = "integer", minimum = 1588262400, -- 2020/5/1 0:0:0

[GitHub] [apisix-dashboard] nic-chen merged pull request #535: feat: refactor apis for existing check and other apis

2020-10-09 Thread GitBox
nic-chen merged pull request #535: URL: https://github.com/apache/apisix-dashboard/pull/535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #537: bug: respond status of api should keep same as `admin api` do

2020-10-09 Thread GitBox
juzhiyuan commented on issue #537: URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705950739 Please follow the RESTful way, thanks. This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #537: bug: respond status of api should keep same as `admin api` do

2020-10-09 Thread GitBox
ShiningRush edited a comment on issue #537: URL: https://github.com/apache/apisix-dashboard/issues/537#issuecomment-705932393 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] spacewander commented on a change in pull request #2357: bugfix: set random seed for each worker process at `init_worker` phase, only `init` phase is not enough.

2020-10-09 Thread GitBox
spacewander commented on a change in pull request #2357: URL: https://github.com/apache/apisix/pull/2357#discussion_r502190093 ## File path: apisix/init.lua ## @@ -82,6 +75,14 @@ end function _M.http_init_worker() +local seed, err = core.utils.get_seed_from_urandom() +

  1   2   >