juzhiyuan commented on issue #2394:
URL: https://github.com/apache/apisix/issues/2394#issuecomment-706879062
@idbeta Please take a look first, to check if this issue occurred.
This is an automated message from the Apache Git
zh417233956 opened a new issue #2394:
URL: https://github.com/apache/apisix/issues/2394
### Issue description
访问：http://192.168.5.139/apisix/prometheus/metrics，出现：metrics 500 Internal
Server Error
apisix reload 以后正常，几分钟以后，仍然出现：metrics 500 Internal Server Error
### Environment
ShiningRush commented on a change in pull request #551:
URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503026268
##
File path: api/conf/conf.go
##
@@ -54,6 +58,11 @@ func setEnvironment() {
} else {
ENV = env
}
+
+ if
nic-chen commented on issue #546:
URL:
https://github.com/apache/apisix-dashboard/issues/546#issuecomment-706846890
add:
https://github.com/apache/apisix-dashboard/pull/551/files#r503025206
This is an automated message
nic-chen commented on a change in pull request #551:
URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503028962
##
File path: api/build-tools/json.lua
##
@@ -0,0 +1,400 @@
+--
Review comment:
@moonming
It's from https://github.com/rxi/json.lua
moonming commented on a change in pull request #551:
URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503026484
##
File path: api/build-tools/json.lua
##
@@ -0,0 +1,400 @@
+--
Review comment:
@nic-chen where is this file come from?
We need a
juzhiyuan commented on a change in pull request #551:
URL: https://github.com/apache/apisix-dashboard/pull/551#discussion_r503025206
##
File path: api/build-tools/json.lua
##
@@ -0,0 +1,400 @@
+--
Review comment:
Not sure if this file has the license issue, cc
ShiningRush commented on issue #533:
URL:
https://github.com/apache/apisix-dashboard/issues/533#issuecomment-706842433
Got it, plz give a PR when it complete.
This is an automated message from the Apache Git Service.
To
idbeta opened a new issue #2393:
URL: https://github.com/apache/apisix/issues/2393
###description
I tested the route with a very long uri, but it seems not work
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d
ShiningRush commented on pull request #2153:
URL: https://github.com/apache/apisix/pull/2153#issuecomment-706838149
I'm sorry to forget to fix this PR, I will deal with it this week
This is an automated message from the
idbeta commented on issue #2391:
URL: https://github.com/apache/apisix/issues/2391#issuecomment-706837880
I think you can have a look to the docs there:
https://github.com/apache/apisix/blob/master/doc/architecture-design.md
moonming commented on issue #1195:
URL: https://github.com/apache/apisix/issues/1195#issuecomment-706836773
Apache APISIX is now using style 1, I think it should be consistent, this is
also a more common way in yaml
This is
gy09535 commented on issue #2377:
URL: https://github.com/apache/apisix/issues/2377#issuecomment-706832818
> I think if API has been limited, because of the priority, apisix should
not run the zipkin plugin
Thanks, I will confirm it.
liuhengloveyou commented on a change in pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#discussion_r503015456
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -0,0 +1,127 @@
+--
+-- Licensed to the Apache Software Foundation
liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-706829329
> > @liuhengloveyou no test case?
>
> @liuhengloveyou are you kiding me? NO test cases AT ALL!
added
idbeta opened a new issue #2392:
URL: https://github.com/apache/apisix/issues/2392
### Issue description
I have a strange idea about uri, so I tested it, but it didn't work, pls
help me out
```shell
$ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
liuhengloveyou commented on pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#issuecomment-706828797
> @liuhengloveyou no test case?
added
This is an automated message from the Apache Git Service.
To
liuhengloveyou commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r503014458
##
File path: apisix/plugins/api-breaker.lua
##
@@ -0,0 +1,221 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
liuhengloveyou commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r503014346
##
File path: apisix/plugins/api-breaker.lua
##
@@ -0,0 +1,221 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
liuhengloveyou commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r503014395
##
File path: apisix/plugins/api-breaker.lua
##
@@ -0,0 +1,221 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
LY-GO opened a new issue #2391:
URL: https://github.com/apache/apisix/issues/2391
### Issue description
I don't find the structure of project.Where is it? Thanks!
### Environment
* apisix version (cmd: `apisix version`):
* OS:
nic-chen opened a new pull request #551:
URL: https://github.com/apache/apisix-dashboard/pull/551
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
___
tzssangglass commented on issue #1195:
URL: https://github.com/apache/apisix/issues/1195#issuecomment-706808791
I vote to `3`
- downward compatibility
- reduced ambiguity
This is an automated message from the
liuhengloveyou commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r502995712
##
File path: doc/zh-cn/plugins/api-breaker.md
##
@@ -0,0 +1,107 @@
+
+
+- [English](../../plugins/api-blocker.md)
+
+# 目录
+
+- [**定义**](#定义)
+-
membphis commented on issue #1195:
URL: https://github.com/apache/apisix/issues/1195#issuecomment-706806136
support multiple listening ports, there are three styles:
> style 1
```yaml
apisix:
node_listen:
- 9080
- 9081
- 9082
```
> style
liuhengloveyou commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r502995533
##
File path: apisix/plugins/api-breaker.lua
##
@@ -0,0 +1,221 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
RocFang opened a new pull request #2390:
URL: https://github.com/apache/apisix/pull/2390
### What this PR does / why we need it:
1. the result below will always be false ,since etcd_version is nil:
```lua
if (etcd_version == "v3" and not res:find("OK", 1, true)) then
liuhengloveyou commented on a change in pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#discussion_r502994334
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -0,0 +1,127 @@
+--
+-- Licensed to the Apache Software Foundation
liuhengloveyou commented on a change in pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#discussion_r502994177
##
File path: doc/plugins/limit-count.md
##
@@ -39,11 +39,12 @@ Limit request rate by a fixed number of requests in a given
time window.
|
liuhengloveyou commented on a change in pull request #2340:
URL: https://github.com/apache/apisix/pull/2340#discussion_r502993940
##
File path: apisix/plugins/limit-count.lua
##
@@ -70,11 +74,29 @@ local schema = {
type = "string", minLength = 0,
tanjiancheng commented on issue #2366:
URL: https://github.com/apache/apisix/issues/2366#issuecomment-706720499
ok,thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tanjiancheng closed issue #2366:
URL: https://github.com/apache/apisix/issues/2366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tzssangglass commented on issue #1195:
URL: https://github.com/apache/apisix/issues/1195#issuecomment-706711671
now i modified config.yaml as follows
```
apisix:
node_listen:
- 9080
- 9081
- 9082
```
and modified the ngx_tpl related places, as
moonming commented on issue #2388:
URL: https://github.com/apache/apisix/issues/2388#issuecomment-706698686
The master version of apisix only support etcd v3 protocol
This is an automated message from the Apache Git
spacewander commented on issue #2388:
URL: https://github.com/apache/apisix/issues/2388#issuecomment-706692708
Which version of `etcd` and `apisix` you are using?
This is an automated message from the Apache Git Service.
To
spacewander commented on a change in pull request #1979:
URL: https://github.com/apache/apisix/pull/1979#discussion_r502904442
##
File path: .travis/apisix_cli_test.sh
##
@@ -211,8 +211,40 @@ fi
echo "passed: worker_shutdown_timeout in nginx.conf is ok"
+# empty
luoqingming110 opened a new issue #2388:
URL: https://github.com/apache/apisix/issues/2388
### Issue description
### Environment
* apisix version (cmd: `apisix version`):
* OS: k8s
### Minimal test code / Steps to reproduce the issue
1.2020/10/11 11:29:46
spacewander merged pull request #2386:
URL: https://github.com/apache/apisix/pull/2386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b8e4b85 change(hmac-auth): split schema
membphis commented on issue #2381:
URL: https://github.com/apache/apisix/issues/2381#issuecomment-706687620
> allow user to configure plugin attributes from admin
I think we can implement this feature via `plugin-metadata`:
membphis commented on a change in pull request #1979:
URL: https://github.com/apache/apisix/pull/1979#discussion_r502899561
##
File path: .travis/apisix_cli_test.sh
##
@@ -211,6 +211,33 @@ fi
echo "passed: worker_shutdown_timeout in nginx.conf is ok"
+# empty allow_admin
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new abf5674 style: tweak error log in
moonming merged pull request #2387:
URL: https://github.com/apache/apisix/pull/2387
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis commented on pull request #2374:
URL: https://github.com/apache/apisix/pull/2374#issuecomment-706667664
> Maybe we could also update baidu.com to github.com in doc in this PR:
> https://github.com/apache/apisix/blob/master/doc/plugins/wolf-rbac.md
>
membphis edited a comment on issue #2375:
URL: https://github.com/apache/apisix/issues/2375#issuecomment-706667420
a correct test case:
```shell
$ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"uri":
membphis commented on issue #2375:
URL: https://github.com/apache/apisix/issues/2375#issuecomment-706667420
so a right test case should be:
```shell
$ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"uri":
membphis edited a comment on issue #2375:
URL: https://github.com/apache/apisix/issues/2375#issuecomment-706512050
> ```shell
>
http://127.0.0.1:9080/helloh~E]ftXnj2Hs#r9:Y/;o-OI,uN7Le!P_J+w.zi4C0aDA3WMqU1T*KVZ?GmdFlQ5
> ```
it is not a valid URI address, the Admin API should
Yiyiyimu commented on pull request #2374:
URL: https://github.com/apache/apisix/pull/2374#issuecomment-706665493
Maybe we could also update baidu.com to github.com in doc in this PR:
https://github.com/apache/apisix/blob/master/doc/plugins/wolf-rbac.md
Yiyiyimu commented on a change in pull request #1979:
URL: https://github.com/apache/apisix/pull/1979#discussion_r502878260
##
File path: .travis/apisix_cli_test.sh
##
@@ -211,6 +211,33 @@ fi
echo "passed: worker_shutdown_timeout in nginx.conf is ok"
+# empty allow_admin
spacewander opened a new pull request #2387:
URL: https://github.com/apache/apisix/pull/2387
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ]
spacewander commented on issue #799:
URL: https://github.com/apache/apisix/issues/799#issuecomment-706655374
Solved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
spacewander closed issue #799:
URL: https://github.com/apache/apisix/issues/799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander closed issue #993:
URL: https://github.com/apache/apisix/issues/993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander closed issue #860:
URL: https://github.com/apache/apisix/issues/860
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander commented on issue #993:
URL: https://github.com/apache/apisix/issues/993#issuecomment-706655235
We already did it.
This is an automated message from the Apache Git Service.
To respond to the message, please log
spacewander commented on issue #860:
URL: https://github.com/apache/apisix/issues/860#issuecomment-706655281
Solved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
spacewander commented on issue #1132:
URL: https://github.com/apache/apisix/issues/1132#issuecomment-706655088
Now the version can be detected via the Server header. Solved.
This is an automated message from the Apache Git
spacewander closed issue #1132:
URL: https://github.com/apache/apisix/issues/1132
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
58 matches
Mail list logo
