dabue opened a new issue #2457:
URL: https://github.com/apache/apisix/issues/2457
### Issue description
Line 240:
curl -i -X GET http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar
-H 'apikey: superSecretAPIKey'
should be replaced with
curl -i -X GET
"http://127.0.0.1
ShiningRush commented on a change in pull request #561:
URL: https://github.com/apache/apisix-dashboard/pull/561#discussion_r507012891
##
File path: api/internal/core/store/store.go
##
@@ -256,7 +263,7 @@ func (s *GenericStore) Create(ctx context.Context, obj
interface{}) erro
membphis commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-73065
> Do you mean that the current function can directly remove this field?
You haven't added this field yet? I do not find it in the changed files:
https://github.com/apache
membphis closed pull request #2339:
URL: https://github.com/apache/apisix/pull/2339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis commented on pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#issuecomment-70662
continue this job in new PR: https://github.com/apache/apisix/pull/2455
This is an automated message from the Ap
Jaycean commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-711109884
> > the `disable` filed is an injection for every plugin's jsonschema, just
waiting for @membphis's reply :)
>
> we do not need to add this `disable` field in schema.
membphis opened a new pull request #2456:
URL: https://github.com/apache/apisix/pull/2456
### What this PR does / why we need it:
as title
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
nic-chen commented on issue #2412:
URL: https://github.com/apache/apisix/issues/2412#issuecomment-711101072
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
nic-chen closed issue #2412:
URL: https://github.com/apache/apisix/issues/2412
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
membphis opened a new pull request #2455:
URL: https://github.com/apache/apisix/pull/2455
### What this PR does / why we need it:
Users can configure healthy and unhealthy states and the number of
occurrences.
When the unhealthy state is triggered, apisix considers the
membphis commented on pull request #2454:
URL: https://github.com/apache/apisix/pull/2454#issuecomment-711091662
--
nic-chen commented on issue #560:
URL:
https://github.com/apache/apisix-dashboard/issues/560#issuecomment-711088938
It is suggested that you can wait for version 2.0 and upgrade it together.
This is an automated message from
Miss-you opened a new pull request #2454:
URL: https://github.com/apache/apisix/pull/2454
### What this PR does / why we need it:
add picture about Contributor Over Time
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new
Firstsawyou commented on issue #2452:
URL: https://github.com/apache/apisix/issues/2452#issuecomment-711037768
Yes, I am looking for a feasible way to solve.
This is an automated message from the Apache Git Service.
To respon
membphis commented on issue #2445:
URL: https://github.com/apache/apisix/issues/2445#issuecomment-711034132
I think it is good. +1
This is an automated message from the Apache Git Service.
To respond to the message, please lo
membphis edited a comment on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711033622
confirm that is a bug, welcome PR ^_^
we need a better `key` here
This is an automated message from the
membphis commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711033622
confirm that is a bug, welcome PR ^_^
This is an automated message from the Apache Git Service.
To respond to the mes
membphis commented on issue #2453:
URL: https://github.com/apache/apisix/issues/2453#issuecomment-711033344
I got your mind. thx for your explain
This is an automated message from the Apache Git Service.
To respond to the mes
membphis edited a comment on pull request #2397:
URL: https://github.com/apache/apisix/pull/2397#issuecomment-710993762
I think this feature is useful.
When the APISIX instance restarts, we need to exit `sleep` as soon as
possible.
Then the Nginx process can be gracefully shut d
Firstsawyou commented on issue #2453:
URL: https://github.com/apache/apisix/issues/2453#issuecomment-711031644
No, it is the data stored by etcd. For example, `/apisix/routes/1` means
`route` data whose route id is `1`.
This
membphis commented on issue #2450:
URL: https://github.com/apache/apisix/issues/2450#issuecomment-711021281
> i hope that the plugin only limit concurrency,and different users also
continue to request the router when user request the service after first .
What is the difference betwe
membphis commented on issue #2452:
URL: https://github.com/apache/apisix/issues/2452#issuecomment-711020598
it is not easy to record the `upstream` request data :(
This is an automated message from the Apache Git Service.
To
membphis commented on issue #2453:
URL: https://github.com/apache/apisix/issues/2453#issuecomment-711020257
what means the `data plane information`? monitor data?
This is an automated message from the Apache Git Service.
To r
membphis commented on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-711019661
> * metadata
> * consumer
How about this API style?
```
/apisix/admin/schema/plugins/{plugin_name}/metadata
/apisix/admin/schema/plugins/{plugin_name}/consumer
tzssangglass closed pull request #2443:
URL: https://github.com/apache/apisix/pull/2443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
membphis commented on issue #2426:
URL: https://github.com/apache/apisix/issues/2426#issuecomment-711015085
> I think it's a schema defined bug.
> `redirect_uri` should be required according to the error log.
A new PR to fix this bug is better. welcome PR
membphis commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-711012871
> the `disable` filed is an injection for every plugin's jsonschema, just
waiting for @membphis's reply :)
we do not need to add this `disable` field in schema.
---
membphis commented on pull request #2443:
URL: https://github.com/apache/apisix/pull/2443#issuecomment-711011126
@tzssangglass I think your new code is wrong. please check it first.
https://github.com/apache/apisix/pull/2443/checks?check_run_id=1266120426#step:6:373
---
membphis closed issue #2433:
URL: https://github.com/apache/apisix/issues/2433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
membphis commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-711000462
fixed alread
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
membphis commented on pull request #2397:
URL: https://github.com/apache/apisix/pull/2397#issuecomment-710993762
I think this feature is useful.
When the APISIX instance restarts, we need to exit `sleep` as soon as
possible.
Then the Nginx process can be gracefully shut down.
dabue commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-710980509
+1， or add a field version.
88786...@qq.com
From: YuanSheng Wang
Date: 2020-10-16 19:00
To: apache/apisix
CC: Subscribed
Subject: Re: [apache/apisix] f
imjoey commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r506939050
##
File path: t/plugin/request-validation.t
##
@@ -271,46 +231,6 @@ hello1 world
"type": "roundrobin"
lizeming opened a new issue #562:
URL: https://github.com/apache/apisix-dashboard/issues/562
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance i
membphis merged pull request #1979:
URL: https://github.com/apache/apisix/pull/1979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis closed issue #1939:
URL: https://github.com/apache/apisix/issues/1939
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 9e1030e feat: `limit-count` plugin supports limiting requests by
consumer name. (#2421)
add c939262 bugfix:
membphis merged pull request #2421:
URL: https://github.com/apache/apisix/pull/2421
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis commented on pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#issuecomment-710840338
@Jaycean many thx, merged already
This is an automated message from the Apache Git Service.
To respond to the me
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 3bb670b bugfix: set route priority for router `radixtree_host_uri`.
(#2447)
add 9e1030e feat: `limit-count`
membphis closed issue #2423:
URL: https://github.com/apache/apisix/issues/2423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
membphis commented on pull request #2447:
URL: https://github.com/apache/apisix/pull/2447#issuecomment-710836871
@haifeng9414 merged, many thx ^_^
This is an automated message from the Apache Git Service.
To respond to the me
membphis merged pull request #2447:
URL: https://github.com/apache/apisix/pull/2447
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from a92331c feature: add managed fields in json schema for resources,
such as create_time and update_time (#2444)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 6a543a9 feat: use interceptors to protect plugin's route (#2416)
add a92331c feature: add managed fields in
nic-chen merged pull request #2444:
URL: https://github.com/apache/apisix/pull/2444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nic-chen commented on pull request #2444:
URL: https://github.com/apache/apisix/pull/2444#issuecomment-710812564
> @nic-chen I think you'd better add a link to the question in this PR. The
community needs to know which issue is solved.
sure.I have modified the summary。
spacewander merged pull request #2416:
URL: https://github.com/apache/apisix/pull/2416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 90109ca feature: support multiple ports like stream listen in http
and https … (#2409)
add 6a543a9 feat:
spacewander closed issue #1195:
URL: https://github.com/apache/apisix/issues/1195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander merged pull request #2409:
URL: https://github.com/apache/apisix/pull/2409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from d1729c0 feat: In dns parse, when the parameter `resolvers` is empty,
the local dns is used as `resolvers` by d
spacewander commented on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-710785441
I think we should pass the schema type to get the correct schema, since
currently we already have three kinds of schema:
1. metadata
2. consumer
3. route/service
---
Jaycean commented on a change in pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#discussion_r506908450
##
File path: doc/plugins/limit-count.md
##
@@ -37,7 +37,7 @@ Limit request rate by a fixed number of requests in a given
time window.
| -- |
Jaycean commented on a change in pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#discussion_r506908349
##
File path: doc/plugins/limit-count.md
##
@@ -37,7 +37,7 @@ Limit request rate by a fixed number of requests in a given
time window.
| -- |
Firstsawyou commented on a change in pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#discussion_r506907684
##
File path: doc/plugins/limit-count.md
##
@@ -37,7 +37,7 @@ Limit request rate by a fixed number of requests in a given
time window.
|
Firstsawyou commented on a change in pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#discussion_r506906822
##
File path: doc/plugins/limit-count.md
##
@@ -37,7 +37,7 @@ Limit request rate by a fixed number of requests in a given
time window.
|
Firstsawyou opened a new issue #2453:
URL: https://github.com/apache/apisix/issues/2453
### Issue description
When we obtain the data plane information, we need to obtain it through the
`curl` method, and it is more difficult to obtain multiple pieces of data
information (e.g: obtai
juzhiyuan commented on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-710779709
@membphis Please take a look
This is an automated message from the Apache Git Service.
To respond to the message, pl
liuxiran edited a comment on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-710779509
`hmac-auth` define two schemas:
- one is :
https://github.com/apache/apisix/blob/d1729c0af3bc416a88904568b4d2718c99a1982d/apisix/plugins/hmac-auth.lua#L40
- the o
liuxiran commented on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-710779509
`hmac-auth` define two schemas:
- one is :
https://github.com/apache/apisix/blob/d1729c0af3bc416a88904568b4d2718c99a1982d/apisix/plugins/hmac-auth.lua#L40
- the other on
Firstsawyou opened a new issue #2452:
URL: https://github.com/apache/apisix/issues/2452
### Issue description
In the use of `apisix`, we do not have a good tool to obtain the request
data sent to the upstream service, which is very inconvenient for us to
troubleshoot some abnormal p
fukiki opened a new pull request #2451:
URL: https://github.com/apache/apisix/pull/2451
- fix bug #2432
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been ad
juzhiyuan commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710776224
the `disable` filed is an injection for every plugin's jsonschema, just
waiting for @membphis's reply :)
This
LY-GO opened a new issue #2450:
URL: https://github.com/apache/apisix/issues/2450
### Issue description
I had test the plugin of limit-conn.I found the question that the same ip
only request the router by five times when conn is 5 and key is remote_addr,
and i don't request the router
Jaycean commented on a change in pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#discussion_r506883423
##
File path: doc/plugins/limit-count.md
##
@@ -37,7 +37,7 @@ Limit request rate by a fixed number of requests in a given
time window.
| -- |
Jaycean commented on a change in pull request #2421:
URL: https://github.com/apache/apisix/pull/2421#discussion_r506883005
##
File path: doc/zh-cn/plugins/limit-count.md
##
@@ -30,7 +30,7 @@
| -- | --- | | --- |
---
Jaycean edited a comment on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710769509
> > > hi please see here
[apache/apisix-dashboard#495](https://github.com/apache/apisix-dashboard/issues/495)
> >
> >
> > so you means apisix should not return d
Jaycean edited a comment on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710769509
> > > hi please see here
[apache/apisix-dashboard#495](https://github.com/apache/apisix-dashboard/issues/495)
> >
> >
> > so you means apisix should not return d
Jaycean edited a comment on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710769509
> > > hi please see here
[apache/apisix-dashboard#495](https://github.com/apache/apisix-dashboard/issues/495)
> >
> >
> > so you means apisix should not return d
Jaycean edited a comment on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710769509
> > > hi please see here
[apache/apisix-dashboard#495](https://github.com/apache/apisix-dashboard/issues/495)
> >
> >
> > so you means apisix should not return d
Jaycean edited a comment on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710769509
> > > hi please see here
[apache/apisix-dashboard#495](https://github.com/apache/apisix-dashboard/issues/495)
> >
> >
> > so you means apisix should not return d
Jaycean commented on pull request #2440:
URL: https://github.com/apache/apisix/pull/2440#issuecomment-710769509
> > > hi please see here
[apache/apisix-dashboard#495](https://github.com/apache/apisix-dashboard/issues/495)
> >
> >
> > so you means apisix should not return disable
membphis opened a new issue #2449:
URL: https://github.com/apache/apisix/issues/2449
`random stream test in [1, 1]` -> `stream/http subsystem, generate
random value:`
https://github.com/apache/apisix/blob/master/apisix/init.lua#L86
https://github.com/apache/apisix/blob/master/
membphis commented on pull request #2444:
URL: https://github.com/apache/apisix/pull/2444#issuecomment-710767523
@nic-chen I think you'd better add a link to the question in this PR. The
community needs to know which issue is solved.
---
Firstsawyou opened a new issue #2448:
URL: https://github.com/apache/apisix/issues/2448
### Issue description
This part of the code (
https://github.com/apache/apisix/blob/master/apisix/plugins/limit-req.lua#L70-L80)
can be replaced with "`local key = (ctx.var[conf.key] or "") ..
haifeng9414 opened a new pull request #2447:
URL: https://github.com/apache/apisix/pull/2447
Fix: [#2423](https://github.com/apache/apisix/issues/2423).
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
haifeng9414 closed pull request #2446:
URL: https://github.com/apache/apisix/pull/2446
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
78 matches
Mail list logo
