[GitHub] [apisix] membphis commented on a change in pull request #2488: feat: add error-log-logger plugin

2020-10-22 Thread GitBox
membphis commented on a change in pull request #2488: URL: https://github.com/apache/apisix/pull/2488#discussion_r510666517 ## File path: conf/config-default.yaml ## @@ -193,6 +193,7 @@ plugins: # plugin list - proxy-mirror - request-id - hmac-

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #588: feat: embedding static files into Go binaries

2020-10-22 Thread GitBox
membphis commented on a change in pull request #588: URL: https://github.com/apache/apisix-dashboard/pull/588#discussion_r510665235 ## File path: api/main.go ## @@ -14,6 +14,9 @@ * See the License for the specific language governing permissions and * limitations under the L

[GitHub] [apisix] membphis commented on issue #2452: discuss: How apisix records the request data sent to the upstream service

2020-10-22 Thread GitBox
membphis commented on issue #2452: URL: https://github.com/apache/apisix/issues/2452#issuecomment-714970372 > I think we can use the `serverless` plugin to execute some `lua` logic codes at the specified stage to try to achieve it. can you show me an example? ^_^ --

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
membphis commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510662817 ## File path: docs/deploy.zh-CN.md ## @@ -0,0 +1,90 @@ + + +# 手动部署 + +## 克隆项目 + +```sh +$ git clone https://github.com/apache/apisix-dashboard.git

[apisix-dashboard] branch docs-improvment updated (7bb6757 -> 4626a8b)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 7bb6757 feat(doc): update some incompatible cases add 4626a8b feat(docs): added sh flag

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
juzhiyuan commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510659702 ## File path: docs/deploy.zh-CN.md ## @@ -0,0 +1,90 @@ + + +# 手动部署 + +## 克隆项目 + +```sh +$ git clone https://github.com/apache/apisix-dashboard.gi

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
juzhiyuan commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510660457 ## File path: docs/deploy.md ## @@ -0,0 +1,87 @@ + + +# Deploy manually + +## Clone the project + +```sh +$ git clone https://github.com/apache/a

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
juzhiyuan commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510660761 ## File path: docs/develop.md ## @@ -14,14 +15,22 @@ # See the License for the specific language governing permissions and # limitations under

[apisix-dashboard] branch docs-improvment updated (9953fe9 -> 7bb6757)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 9953fe9 feat: update action's name add 7bb6757 feat(doc): update some incompatible cases

[GitHub] [apisix] imjoey edited a comment on issue #2490: discuss: In the request of the `hmac-auth` plugin, remove the request header related to the plugin

2020-10-22 Thread GitBox
imjoey edited a comment on issue #2490: URL: https://github.com/apache/apisix/issues/2490#issuecomment-714950523 > > > X-HMAC-ACCESS-KEY, > > > X-HMAC-SIGNATURE, > > > X-HMAC-ALGORITHM, > > > X-HMAC-SIGNED-HEADERS, > > > Date > > > > > > I think we can remove `X-HMAC-S

[GitHub] [apisix] imjoey commented on issue #2490: discuss: In the request of the `hmac-auth` plugin, remove the request header related to the plugin

2020-10-22 Thread GitBox
imjoey commented on issue #2490: URL: https://github.com/apache/apisix/issues/2490#issuecomment-714950523 > > > X-HMAC-ACCESS-KEY, > > > X-HMAC-SIGNATURE, > > > X-HMAC-ALGORITHM, > > > X-HMAC-SIGNED-HEADERS, > > > Date > > > > > > I think we can remove `X-HMAC-SIGNATUR

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
juzhiyuan commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510659702 ## File path: docs/deploy.zh-CN.md ## @@ -0,0 +1,90 @@ + + +# 手动部署 + +## 克隆项目 + +```sh +$ git clone https://github.com/apache/apisix-dashboard.gi

[GitHub] [apisix] membphis commented on issue #2502: request help: 请问xpisix有白皮书吗?

2020-10-22 Thread GitBox
membphis commented on issue #2502: URL: https://github.com/apache/apisix/issues/2502#issuecomment-714945248 pls use English in public channel This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
ShiningRush commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510658605 ## File path: docs/deploy.md ## @@ -0,0 +1,87 @@ + + +# Deploy manually + +## Clone the project + +```sh +$ git clone https://github.com/apache

[GitHub] [apisix] gewei2000 opened a new issue #2502: request help: 请问xpisix有白皮书吗?

2020-10-22 Thread GitBox
gewei2000 opened a new issue #2502: URL: https://github.com/apache/apisix/issues/2502 ### Issue description request help: 我想看一下apisix的工作原理,和详细的搭建教程,比如apisix的版本和dashboard匹配的版本是哪个,但是没有找到合适的教程,请问xpisix有白皮书吗? This is an a

[GitHub] [apisix-dashboard] membphis commented on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
membphis commented on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714935041 @aogg please use English in the public channel This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
membphis commented on a change in pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592#discussion_r510636131 ## File path: docs/deploy.zh-CN.md ## @@ -0,0 +1,90 @@ + + +# 手动部署 + +## 克隆项目 + +```sh +$ git clone https://github.com/apache/apisix-dashboard.git

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

2020-10-22 Thread GitBox
Firstsawyou commented on a change in pull request #2491: URL: https://github.com/apache/apisix/pull/2491#discussion_r510619897 ## File path: apisix/plugins/hmac-auth.lua ## @@ -343,6 +370,19 @@ local function get_params(ctx) params.date = date or "" params.signed_hea

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #593: Adjust files' folder

2020-10-22 Thread GitBox
juzhiyuan opened a new issue #593: URL: https://github.com/apache/apisix-dashboard/issues/593 1. Root folder 2. Folder contains Frontend's codes 3. Folder contains MangerAPI's codes This is an automated message from the

[apisix-dashboard] branch docs-improvment updated (10b496a -> 9953fe9)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 10b496a feat(docs): remove extra space add 9953fe9 feat: update action's name No new re

[apisix-dashboard] branch docs-improvment updated (11c1985 -> 10b496a)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 11c1985 feat(docs): adjust files folder add 10b496a feat(docs): remove extra space No n

[apisix-dashboard] branch docs-improvment updated (d9dcbdd -> 11c1985)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from d9dcbdd feat(docs): adjust files folder add 11c1985 feat(docs): adjust files folder No

[apisix-dashboard] branch docs-improvment updated (0226869 -> d9dcbdd)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 0226869 feat(docs): remove tip add d9dcbdd feat(docs): adjust files folder No new revis

[apisix-dashboard] branch docs-improvment updated (7dd824a -> 0226869)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 7dd824a feat(docs): update typo add 0226869 feat(docs): remove tip No new revisions wer

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

2020-10-22 Thread GitBox
Firstsawyou commented on a change in pull request #2491: URL: https://github.com/apache/apisix/pull/2491#discussion_r510596853 ## File path: doc/plugins/hmac-auth.md ## @@ -42,6 +42,7 @@ The `consumer` then adds its key to request header to verify its request. | algorithm

[apisix-dashboard] branch docs-improvment updated (aa89c6c -> 46dd512)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from aa89c6c feat: added changelog in Chinese add 56f feat(docs): added License add

[apisix-dashboard] branch docs-improvment updated (46dd512 -> 7dd824a)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 46dd512 feat(docs): update README add 7dd824a feat(docs): update typo No new revisions

[apisix-dashboard] branch docs-improvment updated (79c8065 -> aa89c6c)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 79c8065 feat(docs): added some features add aa89c6c feat: added changelog in Chinese No

[apisix-dashboard] branch docs-improvment updated (79c8065 -> aa89c6c)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 79c8065 feat(docs): added some features add aa89c6c feat: added changelog in Chinese No

[apisix-dashboard] branch docs-improvment updated (e738333 -> 79c8065)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e738333 feat: prettier lint add 2002b9a feat(docs): added USER_GUIDE in Chinese add

[GitHub] [apisix] moonming commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

2020-10-22 Thread GitBox
moonming commented on a change in pull request #2491: URL: https://github.com/apache/apisix/pull/2491#discussion_r510591193 ## File path: doc/plugins/hmac-auth.md ## @@ -42,6 +42,7 @@ The `consumer` then adds its key to request header to verify its request. | algorithm |

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #592: feat: docs improvment

2020-10-22 Thread GitBox
juzhiyuan opened a new pull request #592: URL: https://github.com/apache/apisix-dashboard/pull/592 - [ ] User Guide - [ ] Deploy Steps - [ ] Project Structure - [ ] FAQ This is an automated message from the Apache Gi

[apisix-dashboard] 02/04: feat: update template's typo

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 911deda7915d1dcff9d99dfb7618cb39ac40ede4 Author: juzhiyuan AuthorDate: Fri Oct 23 12:15:31 2020 +0

[apisix-dashboard] branch docs-improvment updated (60eca4a -> e738333)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 60eca4a feat: update action's name new e8b7ab1 feat: remove unused files new 911ded

[apisix-dashboard] 03/04: feat: update PR template

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 1c82ad67fd12587da72f0367bf65bb8ee0f9d9f3 Author: juzhiyuan AuthorDate: Fri Oct 23 12:16:00 2020 +0

[apisix-dashboard] 04/04: feat: prettier lint

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit e7383331125992463f96bb596c0568b413da7d8a Author: juzhiyuan AuthorDate: Fri Oct 23 12:17:01 2020 +0

[apisix-dashboard] 01/04: feat: remove unused files

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit e8b7ab169232fbaed109503fbad9df65dee5a2b3 Author: juzhiyuan AuthorDate: Fri Oct 23 12:15:08 2020 +0

[apisix-dashboard] 02/02: feat: update action's name

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 60eca4afaa74c79bb95190215d9d5559d66d8778 Author: juzhiyuan AuthorDate: Fri Oct 23 12:13:36 2020 +0

[apisix-dashboard] 01/02: feat: update action's name

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit d85900c483ebec2e99ef7be2fbf02e9bd45c245e Author: juzhiyuan AuthorDate: Fri Oct 23 12:12:12 2020 +0

[apisix-dashboard] branch docs-improvment created (now 60eca4a)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-improvment in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 60eca4a feat: update action's name This branch includes the following new commits: new

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #591: fix(Upstream): list item desc not showing

2020-10-22 Thread GitBox
juzhiyuan merged pull request #591: URL: https://github.com/apache/apisix-dashboard/pull/591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: fix: list item desc not showing (#591)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 509577e fix: list item desc not sh

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

2020-10-22 Thread GitBox
Firstsawyou commented on a change in pull request #2491: URL: https://github.com/apache/apisix/pull/2491#discussion_r510576893 ## File path: doc/plugins/hmac-auth.md ## @@ -42,6 +42,7 @@ The `consumer` then adds its key to request header to verify its request. | algorithm

[GitHub] [apisix] tokers commented on issue #2501: [discuss]: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-10-22 Thread GitBox
tokers commented on issue #2501: URL: https://github.com/apache/apisix/issues/2501#issuecomment-714889507 We may resort to the logging or tracing to determine this difference. The way you described is more like a debugging way, maybe it can be expanded to support more demands.

[GitHub] [apisix] Firstsawyou opened a new issue #2501: discuss: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-10-22 Thread GitBox
Firstsawyou opened a new issue #2501: URL: https://github.com/apache/apisix/issues/2501 ### Issue description When our http request gets an error status code `5XX`, for example: 500. How do we know if this status comes from `upstream` or `apisix`. To know the source of the err

[GitHub] [apisix] gxthrj commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

2020-10-22 Thread GitBox
gxthrj commented on a change in pull request #2491: URL: https://github.com/apache/apisix/pull/2491#discussion_r510574841 ## File path: apisix/plugins/hmac-auth.lua ## @@ -343,6 +370,19 @@ local function get_params(ctx) params.date = date or "" params.signed_headers

[GitHub] [apisix] moonming commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

2020-10-22 Thread GitBox
moonming commented on a change in pull request #2491: URL: https://github.com/apache/apisix/pull/2491#discussion_r510570816 ## File path: doc/plugins/hmac-auth.md ## @@ -42,6 +42,7 @@ The `consumer` then adds its key to request header to verify its request. | algorithm |

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #591: fix(Upstream): list item desc not showing

2020-10-22 Thread GitBox
LiteSun opened a new pull request #591: URL: https://github.com/apache/apisix-dashboard/pull/591 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] aogg edited a comment on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
aogg edited a comment on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714869635 failed to fetch cookie value by key: cookie_x_api_key 这句就是报错的,但明明有发 话说你是不是中文的你就直接关闭啊,让能处理bug的帮忙看下啊 -

[GitHub] [apisix-dashboard] aogg commented on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
aogg commented on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714869635 failed to fetch cookie value by key: cookie_x_api_key This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] aogg commented on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
aogg commented on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714869402 master分支有提示的啊,而且上一个提问你还说不稳定 Please Note: This branch is still under development, please DO NOT use this branch currently. > You could have a try on the latest c

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
juzhiyuan commented on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714867514 codes from the master branch don't include MySQL anymore, totally different with codes from the `master-xxx` branch. --

[GitHub] [apisix-dashboard] juzhiyuan closed issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
juzhiyuan closed issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
juzhiyuan edited a comment on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714867514 codes from the master branch don't include MySQL anymore, totally different from codes from the `master-xxx` branch. ---

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
juzhiyuan commented on issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590#issuecomment-714866925 You could have a try on the latest codes from the master branch, nearly stable. This is an automated messa

[apisix-dashboard] branch master updated: chore: deployment update and remove all files related to MySQL (#581)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new bb70b1a chore: deployment update a

[GitHub] [apisix-dashboard] juzhiyuan closed issue #577: Improve Deploy Docs

2020-10-22 Thread GitBox
juzhiyuan closed issue #577: URL: https://github.com/apache/apisix-dashboard/issues/577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] aogg opened a new issue #590: 通过apisix代理到nginx在代理到apisix-dashboard,就报这个错误

2020-10-22 Thread GitBox
aogg opened a new issue #590: URL: https://github.com/apache/apisix-dashboard/issues/590 2020/10/23 02:18:45 [warn] 38#38: *947042 [lua] ctx.lua:82: __index(): failed to fetch cookie value by key: cookie_x_api_key error: nil, client: 14.145.136.241, server: , request: "POST /apisix/admin/u

[GitHub] [apisix-dashboard] juzhiyuan closed issue #576: remove all files related to MySQL

2020-10-22 Thread GitBox
juzhiyuan closed issue #576: URL: https://github.com/apache/apisix-dashboard/issues/576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #581: chore: deployment update and remove all files related to MySQL

2020-10-22 Thread GitBox
juzhiyuan merged pull request #581: URL: https://github.com/apache/apisix-dashboard/pull/581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] gy09535 commented on issue #2377: bug:Use zipkin plugin and limit-req plugin together, zipkin plugin can not work when is limit

2020-10-22 Thread GitBox
gy09535 commented on issue #2377: URL: https://github.com/apache/apisix/issues/2377#issuecomment-714862890 I have change the priority of zipkin plugin, I think maybe we have another problem , can not span the right time of access and rewrite, should we change some code out plugin? --

[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714854919 > > I do another test , the msg is send with no error ,it is success. And we can check it in sls log console. > > can we run it in CI? The test case can run i

[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714854919 > > I do another test , the msg is send with no error ,it is success. And we can check it in sls log console. > > can we run it in CI? The test case can run i

[GitHub] [apisix] gy09535 commented on pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
gy09535 commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714854919 > > I do another test , the msg is send with no error ,it is success. And we can check it in sls log console. > > can we run it in CI? The test case can run in CI.

[GitHub] [apisix] membphis commented on pull request #2395: improve: refactor apisix command line tool

2020-10-22 Thread GitBox
membphis commented on pull request #2395: URL: https://github.com/apache/apisix/pull/2395#issuecomment-714854804 > I was stucked in this weird CI failed problem, it may cost me some time to solve this. Do not worry about this, we will help you ^_^ -

[GitHub] [apisix] dyingbleed commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2020-10-22 Thread GitBox
dyingbleed commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-714840804 Organization: 51tiangou.com Location: Dalian, China Contact: lizhen...@51tiangou.com Scenario: API Gateway 组织:大商天狗 地址:中国 大连 联系方式:lizhen...@51tiangou.com 使用场景:A

[GitHub] [apisix-dashboard] aogg edited a comment on issue #586: 最新master分支构建,路由选择上游后报错

2020-10-22 Thread GitBox
aogg edited a comment on issue #586: URL: https://github.com/apache/apisix-dashboard/issues/586#issuecomment-714627053 master-20201020可用,有多插件,确实是mysql的但没报错 其中syslog这个配置,配置了有什么用的,没看到什么变化是没有对接吧 This is an automated mess

[GitHub] [apisix-dashboard] aogg commented on issue #586: 最新master分支构建,路由选择上游后报错

2020-10-22 Thread GitBox
aogg commented on issue #586: URL: https://github.com/apache/apisix-dashboard/issues/586#issuecomment-714627053 master-20201020可用,有多插件,确实是mysql的但没报错 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] aogg removed a comment on issue #586: 最新master分支构建,路由选择上游后报错

2020-10-22 Thread GitBox
aogg removed a comment on issue #586: URL: https://github.com/apache/apisix-dashboard/issues/586#issuecomment-714530671 > no, that branch is just a backup for 1.5 (MySQL needed), and the master branch aims to deprecate MySQL. 运行起来master-20201020,不需要mysql的(而且也有全部插件列表感觉基本满足现有体验需求),但还是

[apisix-dashboard] branch master updated: fix: check whether it is nil before using the variable (#589)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e133ca7 fix: check whether it is n

[apisix-dashboard] branch master updated: fix: check whether it is nil before using the variable (#589)

2020-10-22 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e133ca7 fix: check whether it is n

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #589: fix: check whether it is nil before using a variable as a object

2020-10-22 Thread GitBox
juzhiyuan merged pull request #589: URL: https://github.com/apache/apisix-dashboard/pull/589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] nic-chen commented on issue #2319: request help: start with k8s to report an error

2020-10-22 Thread GitBox
nic-chen commented on issue #2319: URL: https://github.com/apache/apisix/issues/2319#issuecomment-714571882 @XXMY Have you encountered the same problem? This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] LY-GO commented on pull request #2465: bugfix(limit-conn): always save the data of the limit object, and release it in log phase.

2020-10-22 Thread GitBox
LY-GO commented on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-714567723 > I think the problem is solved. What made the fix won't work is just the way of test (for example, the upstream doesn't hold the connection). I don't understand word "the up

[GitHub] [apisix-dashboard] aogg edited a comment on issue #586: 最新master分支构建,路由选择上游后报错

2020-10-22 Thread GitBox
aogg edited a comment on issue #586: URL: https://github.com/apache/apisix-dashboard/issues/586#issuecomment-714530671 > no, that branch is just a backup for 1.5 (MySQL needed), and the master branch aims to deprecate MySQL. 运行起来master-20201020,不需要mysql的(而且也有全部插件列表感觉基本满足现有体验需求),但还是同

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #589: fix: check whether it is nil before using the variable

2020-10-22 Thread GitBox
nic-chen opened a new pull request #589: URL: https://github.com/apache/apisix-dashboard/pull/589 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance ___

[GitHub] [apisix-dashboard] aogg edited a comment on issue #586: 最新master分支构建,路由选择上游后报错

2020-10-22 Thread GitBox
aogg edited a comment on issue #586: URL: https://github.com/apache/apisix-dashboard/issues/586#issuecomment-714530671 > no, that branch is just a backup for 1.5 (MySQL needed), and the master branch aims to deprecate MySQL. 运行起来master-20201020,不需要mysql的(而且也有全部插件列表感觉基本满足现有体验需求),但还是

[GitHub] [apisix-dashboard] aogg commented on issue #586: 最新master分支构建,路由选择上游后报错

2020-10-22 Thread GitBox
aogg commented on issue #586: URL: https://github.com/apache/apisix-dashboard/issues/586#issuecomment-714530671 > no, that branch is just a backup for 1.5 (MySQL needed), and the master branch aims to deprecate MySQL. 运行起来master-20201020,不需要mysql的,但还是同样的报错,不能选择上游,你们应该重视起来当bug来修复。

[GitHub] [apisix] membphis commented on pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
membphis commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714510075 > I do another test , the msg is send with no error ,it is success. And we can check it in sls log console. can we run it in CI?

[GitHub] [apisix] liuxiran commented on issue #2441: plugin(hmac-auth): update the schema

2020-10-22 Thread GitBox
liuxiran commented on issue #2441: URL: https://github.com/apache/apisix/issues/2441#issuecomment-714507677 > `/apisix/admin/schema/plugins/{plugin_name}?schema_type=consumer_schema` > > to > > `/apisix/admin/schema/plugins/{plugin_name}?schema_type=consumer` > > simpler

[GitHub] [apisix] membphis commented on issue #2441: plugin(hmac-auth): update the schema

2020-10-22 Thread GitBox
membphis commented on issue #2441: URL: https://github.com/apache/apisix/issues/2441#issuecomment-714506729 `/apisix/admin/schema/plugins/{plugin_name}?schema_type=consumer_schema` to `/apisix/admin/schema/plugins/{plugin_name}?schema_type=consumer` simpler ---

[GitHub] [apisix] spacewander commented on pull request #2465: bugfix(limit-conn): always save the data of the limit object, and release it in log phase.

2020-10-22 Thread GitBox
spacewander commented on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-714477649 I think the problem is solved. What made the fix won't work is just the way of test (for example, the upstream doesn't hold the connection).

[GitHub] [apisix] spacewander closed issue #2498: request help: Source code compilation and installation error

2020-10-22 Thread GitBox
spacewander closed issue #2498: URL: https://github.com/apache/apisix/issues/2498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] tokers edited a comment on pull request #2395: improve: refactor apisix command line tool

2020-10-22 Thread GitBox
tokers edited a comment on pull request #2395: URL: https://github.com/apache/apisix/pull/2395#issuecomment-714461021 @membphis I was stucked in this weird CI failed problem, it may cost me some time to solve this. This is a

[GitHub] [apisix] tokers commented on pull request #2395: improve: refactor apisix command line tool

2020-10-22 Thread GitBox
tokers commented on pull request #2395: URL: https://github.com/apache/apisix/pull/2395#issuecomment-714461021 @membphis I'm stucking in this weird CI failed problem, it may cost me some time to solve this. This is an automa

[GitHub] [apisix] spacewander edited a comment on issue #2498: request help: Source code compilation and installation error

2020-10-22 Thread GitBox
spacewander edited a comment on issue #2498: URL: https://github.com/apache/apisix/issues/2498#issuecomment-714450348 The `make install` is only expected to be called by luarocks. It won't install the Lua dependencies since luarocks already handled them. --

[GitHub] [apisix] spacewander commented on issue #2498: request help: Source code compilation and installation error

2020-10-22 Thread GitBox
spacewander commented on issue #2498: URL: https://github.com/apache/apisix/issues/2498#issuecomment-714450348 The `make install` is only for luarocks. It won't install the Lua dependencies since luarocks already handled them. --

[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #588: feat: embedding static files into Go binaries

2020-10-22 Thread GitBox
bzp2010 opened a new pull request #588: URL: https://github.com/apache/apisix-dashboard/pull/588 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] juzhiyuan closed issue #541: feature: [refactor] run Apache APISIX's `admin api` test cases in dashboard

2020-10-22 Thread GitBox
juzhiyuan closed issue #541: URL: https://github.com/apache/apisix-dashboard/issues/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*

2020-10-22 Thread GitBox
LY-GO commented on issue #2477: URL: https://github.com/apache/apisix/issues/2477#issuecomment-714398511 > 1. you need to use a better title. > 2. one issue for one thing: add `service_id` as key to plugin `limit-*`, do you mean this? now i set key in the following way,but service_id

[GitHub] [apisix] ziyou434 opened a new issue #2500: request help: how can I get the log

2020-10-22 Thread GitBox
ziyou434 opened a new issue #2500: URL: https://github.com/apache/apisix/issues/2500 ### Issue description 我在开发一个插件,模仿已有的插件代码使用了core.log.info(),但是我找不到日志打印,conf/logs下没有我想要的日志输出,求教 日志文件在哪 ### Environment * apisix version (cmd: `apisix version`): 1.5 * OS: centos 7

[GitHub] [apisix] gy09535 opened a new pull request #2499: bugfix: fix zipkin plugin error when used with limit count plugin

2020-10-22 Thread GitBox
gy09535 opened a new pull request #2499: URL: https://github.com/apache/apisix/pull/2499 ### What this PR does / why we need it: fix: https://github.com/apache/apisix/issues/2377 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what

[GitHub] [apisix] LY-GO commented on issue #2448: chore: `limit-req` plugin code optimization

2020-10-22 Thread GitBox
LY-GO commented on issue #2448: URL: https://github.com/apache/apisix/issues/2448#issuecomment-714370571 > ### Issue description > This part of the code ( https://github.com/apache/apisix/blob/master/apisix/plugins/limit-req.lua#L70-L80) > can be replaced with "`local key = (ctx.var[c

[GitHub] [apisix] Caelebs opened a new issue #2498: request help: Source code compilation and installation error

2020-10-22 Thread GitBox
Caelebs opened a new issue #2498: URL: https://github.com/apache/apisix/issues/2498 ### Issue description Source code compilation and installation error? The output of the `make deps` stage seems to be normal, console output information as follows ↓ ``` [root@TEST3 apisix]#

[GitHub] [apisix] Firstsawyou commented on issue #2490: discuss: In the request of the `hmac-auth` plugin, remove the request header related to the plugin

2020-10-22 Thread GitBox
Firstsawyou commented on issue #2490: URL: https://github.com/apache/apisix/issues/2490#issuecomment-714360724 Do we need to add a switch option in `schema` to control the deletion of HTTP request headers? This is an automat

[GitHub] [apisix] tzssangglass opened a new pull request #2497: feature: prometheus plugin `apisix_http_status` metric `route` tag Im…

2020-10-22 Thread GitBox
tzssangglass opened a new pull request #2497: URL: https://github.com/apache/apisix/pull/2497 ### What this PR does / why we need it: Prometheus plugin `apisix_http_status` metric `route` tag Improve recognition. Originally, the `/apisix/prometheus/metrics` endpoint only showe

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r510003753 ## File path: apisix/plugins/sls-logger.lua ## @@ -0,0 +1,213 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] juzhiyuan commented on issue #2441: plugin(hmac-auth): update the schema

2020-10-22 Thread GitBox
juzhiyuan commented on issue #2441: URL: https://github.com/apache/apisix/issues/2441#issuecomment-714349134 yep 😁 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r51720 ## File path: apisix/plugins/sls-logger.lua ## @@ -0,0 +1,213 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] gy09535 commented on pull request #2177: feature: support plugin for aliyun log service

2020-10-22 Thread GitBox
gy09535 commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-714343228 > > any update? > > you can rebase your branch first. conflicted fix it. This is an automated messa

  1   2   >