spacewander commented on issue #2640:
URL: https://github.com/apache/apisix/issues/2640#issuecomment-722921945
The adding header is only in the test scaffold.
https://github.com/apache/apisix/blob/3ab580fa7150736735c7dec67f6a3f4d2987b597/t/APISIX.pm#L392
@membphis
Do you
idbeta opened a new issue #709:
URL: https://github.com/apache/apisix-dashboard/issues/709
After deploy manually, when I run
`$api/run.sh &`
it will prompt an error
` panic: couldn't open sink
"/Users/idbeta/1106/apisix-dashboard/output/logs/error.log"
- Please describe your
liuxiran commented on issue #611:
URL:
https://github.com/apache/apisix-dashboard/issues/611#issuecomment-722918036
> > ```
> > 3\. Permission control of the resource. Permission control of resources
depends on user management, I wonder if we have plan to add this moudle.
> > ```
griffenliu commented on issue #2634:
URL: https://github.com/apache/apisix/issues/2634#issuecomment-722917462
> > @membphis
> > Should we use the same `config-default.yaml` for different profiles?
>
> for `config-default.yaml`, only one version. we use the same
jinpy666 commented on issue #708:
URL:
https://github.com/apache/apisix-dashboard/issues/708#issuecomment-722909385
node v10.15.3
npm run start
--
When I upgrade to version node v14.15.0 and use YARN, these errors
disappear, and if NPM builds are not supported, ignore
jinpy666 closed issue #708:
URL: https://github.com/apache/apisix-dashboard/issues/708
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Firstsawyou commented on issue #2640:
URL: https://github.com/apache/apisix/issues/2640#issuecomment-722908395
Agree, for me, it is better to keep only `Server: APISIX/2.0`.
This is an automated message from the Apache Git
Miss-you opened a new pull request #2641:
URL: https://github.com/apache/apisix/pull/2641
### What this PR does / why we need it:
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have
nic-chen closed issue #669:
URL: https://github.com/apache/apisix-dashboard/issues/669
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #669:
URL:
https://github.com/apache/apisix-dashboard/issues/669#issuecomment-722896985
we have got one:
https://github.com/apache/apisix-dashboard/blob/v2.0/.github/workflows/cli_test.yml
tokers opened a new issue #2640:
URL: https://github.com/apache/apisix/issues/2640
### Issue description
I found sometimes there are two `Server` headers in HTTP response:
tokers opened a new pull request #2639:
URL: https://github.com/apache/apisix/pull/2639
# What this PR does / why we need it:
Sometimes expose version is dangerous, which can be utilized by
malicious crackers when there are some security bugs in that version.
###
liuxiran commented on issue #2082:
URL: https://github.com/apache/apisix/issues/2082#issuecomment-722881856
> > Should I transform `request-validation` request?
>
> What's the correct data format for this plugin? cc @liuxiran
yep, request and response transform are also
jinpy666 opened a new issue #708:
URL: https://github.com/apache/apisix-dashboard/issues/708
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance
juzhiyuan opened a new issue #707:
URL: https://github.com/apache/apisix-dashboard/issues/707
Due to some changes from the manager-api, we have to update the deploy with
docker way ASAP, or users couldn't build with it smoothly.
juzhiyuan commented on pull request #2615:
URL: https://github.com/apache/apisix/pull/2615#issuecomment-722810511
Tracking issue https://github.com/apache/apisix/issues/2379
This is an automated message from the Apache Git
juzhiyuan commented on issue #2082:
URL: https://github.com/apache/apisix/issues/2082#issuecomment-722810090
> Should I transform `request-validation` request?
What's the correct data format for this plugin? cc @liuxiran
juzhiyuan commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722809528
We are working on this issue.
This is an automated message from the Apache Git Service.
To respond to the
LiteSun commented on issue #2082:
URL: https://github.com/apache/apisix/issues/2082#issuecomment-722809018
Should I transform `request-validation` request?
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722809044
@ztgoto Just checked and we are fixing the Docs & Deploy with Docker CD,
once this PR[1] is merged, this issue could be marked as resolved.
[1]
LiteSun commented on issue #2082:
URL: https://github.com/apache/apisix/issues/2082#issuecomment-722807175
I try to transform `request-validation` schema as you provided, but it seems
there is an error. @liuxiran
nic-chen closed issue #678:
URL: https://github.com/apache/apisix-dashboard/issues/678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #695:
URL:
https://github.com/apache/apisix-dashboard/issues/695#issuecomment-722801957
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nic-chen closed issue #695:
URL: https://github.com/apache/apisix-dashboard/issues/695
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #678:
URL:
https://github.com/apache/apisix-dashboard/issues/678#issuecomment-722801763
done.
rotate should be done with `access log` feature or after that.
This is an automated message
nic-chen commented on issue #690:
URL:
https://github.com/apache/apisix-dashboard/issues/690#issuecomment-722801086
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nic-chen closed issue #690:
URL: https://github.com/apache/apisix-dashboard/issues/690
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #664:
URL:
https://github.com/apache/apisix-dashboard/issues/664#issuecomment-722800837
fixed in pr #693
This is an automated message from the Apache Git Service.
To respond to the message,
nic-chen closed issue #664:
URL: https://github.com/apache/apisix-dashboard/issues/664
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch v2.0
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from edea177 fix:bug that dirty data exists after updating route and wrong
mod for prod env (#704)
add
moonming commented on a change in pull request #598:
URL: https://github.com/apache/apisix-dashboard/pull/598#discussion_r517168349
##
File path: api/conf/schema.json
##
@@ -1 +1 @@
nic-chen commented on a change in pull request #704:
URL: https://github.com/apache/apisix-dashboard/pull/704#discussion_r518510625
##
File path: api/internal/handler/route/route.go
##
@@ -309,7 +309,7 @@ func (h *Handler) Update(c droplet.Context) (interface{},
error) {
juzhiyuan merged pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
juzhiyuan commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722796795
@ztgoto
1. The error message output when you are building the frontend is ok and
safe to ignore, this is related to node-gyp and we don't need it, but some
juzhiyuan commented on issue #697:
URL:
https://github.com/apache/apisix-dashboard/issues/697#issuecomment-722790923
@idbeta Could you please list where your test cert come from?
- [ ] Self make
- [ ] Aliyun
- [ ] Let's Encrypt
Miss-you commented on issue #2638:
URL: https://github.com/apache/apisix/issues/2638#issuecomment-722790160
> > Because proper rotation of session ticket encryption key is not
implemented in nignx or Apache.
>
>
spacewander commented on issue #2474:
URL: https://github.com/apache/apisix/issues/2474#issuecomment-722786623
I vote adding a new option to add the feature in Prometheus's metric.
Even we provides a separate plugin to count the API calls, we still need a
layer to aggregate them and
spacewander commented on pull request #2615:
URL: https://github.com/apache/apisix/pull/2615#issuecomment-722785519
@HelloBug0
Wait for your English one
This is an automated message from the Apache Git Service.
To
idbeta commented on issue #697:
URL:
https://github.com/apache/apisix-dashboard/issues/697#issuecomment-722783272
@tiger333777 It did not reproduce in my environment, can you provide the
certificate file that can reproduce this problem?
membphis opened a new issue #706:
URL: https://github.com/apache/apisix-dashboard/issues/706
original comment:
https://github.com/apache/apisix-dashboard/pull/704#discussion_r518495522
and we need to fix similar points.
the error message is important and useful for
gy09535 commented on issue #2474:
URL: https://github.com/apache/apisix/issues/2474#issuecomment-722781072
> Do you need a plugin that counts the number of API calls?
>
> if yes, we can implement this feature by a new plugin.
>
> 1. time window.
> 2. Calculation of the
gy09535 edited a comment on issue #2532:
URL: https://github.com/apache/apisix/issues/2532#issuecomment-722777902
> To solve this problem, you can refer to or use this library directly
>
> https://github.com/Kong/lua-resty-dns-client
>
> @gy09535
See it, It is great
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r518496377
##
File path: apisix/plugins/slslog/rfc5424.lua
##
@@ -0,0 +1,107 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
membphis commented on a change in pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#discussion_r518496279
##
File path: api/conf/conf.json
##
@@ -10,6 +10,12 @@
"dag-lib-path": "",
"etcd": {
"endpoints": "127.0.0.1:2379"
+},
+
ztgoto commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722779144
@juzhiyuan
我使用了分支v2.0根目录Dockerfile来构建镜像，虽然镜像成功构建，启动也正常。但构建过程中也有些错误(提示说可以忽略)，最后还是没有web界面(404
page not found) 我并不确定这个是不是由以下错误导致的
启动日志
```
#docker run --network=host
membphis commented on a change in pull request #704:
URL: https://github.com/apache/apisix-dashboard/pull/704#discussion_r518495522
##
File path: api/internal/handler/route/route.go
##
@@ -309,7 +309,7 @@ func (h *Handler) Update(c droplet.Context) (interface{},
error) {
idbeta edited a comment on issue #2635:
URL: https://github.com/apache/apisix/issues/2635#issuecomment-722778660
@zlchanger Has the JWT issue you mentioned in this issue been resolved? Use
the 2.0 version
https://github.com/apache/apisix-dashboard/issues/663
idbeta commented on issue #2635:
URL: https://github.com/apache/apisix/issues/2635#issuecomment-722778660
@zlchanger Has the JWT issue you mentioned in this issue been resolved? Use
the 2.0 version
This is an automated
gy09535 edited a comment on issue #2532:
URL: https://github.com/apache/apisix/issues/2532#issuecomment-722777902
> To solve this problem, you can refer to or use this library directly
>
> https://github.com/Kong/lua-resty-dns-client
>
> @gy09535
See it, It is great.
gy09535 commented on issue #2532:
URL: https://github.com/apache/apisix/issues/2532#issuecomment-722777902
> To solve this problem, you can refer to or use this library directly
>
> https://github.com/Kong/lua-resty-dns-client
>
> @gy09535
See it, It it great.
juzhiyuan merged pull request #2615:
URL: https://github.com/apache/apisix/pull/2615
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 3ab580f docs: node-status.md (#2615)
dickens7 commented on issue #2532:
URL: https://github.com/apache/apisix/issues/2532#issuecomment-722776692
To solve this problem, you can refer to or use this library directly
https://github.com/Kong/lua-resty-dns-client
@gy09535
gy09535 edited a comment on issue #2532:
URL: https://github.com/apache/apisix/issues/2532#issuecomment-722772906
> welcome PR for this feature.
>
> if you need any help, please let us know.
go it, please assign it to me.
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r518486809
##
File path: apisix/plugins/sls-logger.lua
##
@@ -0,0 +1,213 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r518486955
##
File path: apisix/plugins/slslog/rfc5424.lua
##
@@ -0,0 +1,107 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
gy09535 commented on issue #2532:
URL: https://github.com/apache/apisix/issues/2532#issuecomment-722772906
> welcome PR for this feature.
>
> if you need any help, please let us know.
Sure, thanks.
This is an
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r518486955
##
File path: apisix/plugins/slslog/rfc5424.lua
##
@@ -0,0 +1,107 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r518487036
##
File path: apisix/plugins/sls-logger.lua
##
@@ -0,0 +1,213 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r518486809
##
File path: apisix/plugins/sls-logger.lua
##
@@ -0,0 +1,213 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
nic-chen commented on issue #662:
URL:
https://github.com/apache/apisix-dashboard/issues/662#issuecomment-722768356
close according to pr close
This is an automated message from the Apache Git Service.
To respond to the
nic-chen commented on issue #677:
URL:
https://github.com/apache/apisix-dashboard/issues/677#issuecomment-722768539
close according to pr merged.
This is an automated message from the Apache Git Service.
To respond to the
nic-chen closed issue #677:
URL: https://github.com/apache/apisix-dashboard/issues/677
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen closed issue #662:
URL: https://github.com/apache/apisix-dashboard/issues/662
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
juzhiyuan commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722767809
Please note, use the Dockerfile in the root folder (on the v2.0 branch).
https://github.com/apache/apisix-dashboard/blob/v2.0/Dockerfile
juzhiyuan commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722767458
oh @ztgoto , sorry to lead your confused, please use the Dockerfile in the
root folder[1]. As for the Dockerfile under the `/api` folder, @nic-chen
@membphis do we really
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 3c89a43 chore: remove redundant installation of limit-count (#2631)
add 27875e5 feat(jwt-auth): support
spacewander merged pull request #2594:
URL: https://github.com/apache/apisix/pull/2594
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #2355:
URL: https://github.com/apache/apisix/issues/2355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander closed issue #2523:
URL: https://github.com/apache/apisix/issues/2523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on a change in pull request #2596:
URL: https://github.com/apache/apisix/pull/2596#discussion_r518483823
##
File path: apisix/timers.lua
##
@@ -0,0 +1,90 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license
juzhiyuan commented on issue #705:
URL:
https://github.com/apache/apisix-dashboard/issues/705#issuecomment-722765778
> Does this issue duplicate with #697 ? @juzhiyuan @idbeta
hmmm Error message is different.
This is
Firstsawyou commented on a change in pull request #2596:
URL: https://github.com/apache/apisix/pull/2596#discussion_r518483116
##
File path: t/plugin/log-rotate.t
##
@@ -95,11 +95,89 @@ GET /t
ngx.say("done")
}
}
request
-GET /t
---
codecov-io edited a comment on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-721626088
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/689?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
codecov-io edited a comment on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-721626088
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/689?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
LiteSun commented on issue #705:
URL:
https://github.com/apache/apisix-dashboard/issues/705#issuecomment-722756966
Does this issue duplicate with #697 ? @juzhiyuan @idbeta
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch v2.0
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from b4b646b chore: refactor `conf` of `manager api` (#693)
add edea177 fix:bug that dirty data exists
ztgoto commented on issue #702:
URL:
https://github.com/apache/apisix-dashboard/issues/702#issuecomment-722756387
我确实是使用了/api/Dockerfile构建才导致没有web界面.使用根目录下的Dockerfile master分支也能构建成功。
但master /api/Dockerfile 确实存在问题，构建时错误如下
```
Step 13/17 : RUN cd /go/manager-api/build-tools
nic-chen commented on a change in pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#discussion_r518476078
##
File path: api/conf/conf.json
##
@@ -10,6 +10,12 @@
"dag-lib-path": "",
"etcd": {
"endpoints": "127.0.0.1:2379"
+},
+
codecov-io edited a comment on pull request #598:
URL: https://github.com/apache/apisix-dashboard/pull/598#issuecomment-720791397
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/598?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
spacewander commented on issue #2565:
URL: https://github.com/apache/apisix/issues/2565#issuecomment-722755664
@nanamikon
I think we can write them in a literal block, see `literal_block` in
https://learnxinyminutes.com/docs/yaml/. We should take care about the
indentation of Nginx
codecov-io edited a comment on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-721626088
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/689?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
juzhiyuan merged pull request #704:
URL: https://github.com/apache/apisix-dashboard/pull/704
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
spacewander commented on issue #2296:
URL: https://github.com/apache/apisix/issues/2296#issuecomment-722753271
Look like we need to distinguish `plugin attr` (which need to reload to take
effect) and `plugin metadata` (which don't need to reload). And we need to
consider the `plugin attr`
codecov-io edited a comment on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-721626088
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/689?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request base
nic-chen commented on issue #703:
URL:
https://github.com/apache/apisix-dashboard/issues/703#issuecomment-722750672
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
DirtyIndustry closed issue #2602:
URL: https://github.com/apache/apisix/issues/2602
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
DirtyIndustry commented on issue #2602:
URL: https://github.com/apache/apisix/issues/2602#issuecomment-722742897
Ok, i'll give it a try, thanks a lot everyone.
This is an automated message from the Apache Git Service.
To
spacewander commented on issue #2638:
URL: https://github.com/apache/apisix/issues/2638#issuecomment-722741995
> Because proper rotation of session ticket encryption key is not
implemented in nignx or Apache.
https://github.com/mozilla/server-side-tls/issues/135
Look like it
juzhiyuan commented on a change in pull request #2615:
URL: https://github.com/apache/apisix/pull/2615#discussion_r518462839
##
File path: doc/zh-cn/plugins/node-status.md
##
@@ -0,0 +1,142 @@
+
+
+
+
+# 目录
+
+- [**插件简介**](#插件简介)
+- [**插件属性**](#插件属性)
+- [**插件接口**](#接口插件)
+-
nic-chen commented on pull request #704:
URL: https://github.com/apache/apisix-dashboard/pull/704#issuecomment-722738611
>
>
> This PR is connected with issues successfully
nic-chen commented on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-722738292
> > `api/logs/.gitkeep` to `api/logs/placeholder.txe`, more readable.
>
> ping @nic-chen
OK
nic-chen commented on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-722738466
> CI is failed, please fix them first
working on it
This is an automated message from the Apache
membphis commented on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-722736181
CI is failed, please fix them first
This is an automated message from the Apache Git Service.
To
membphis commented on pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#issuecomment-722735995
> `api/logs/.gitkeep` to `api/logs/placeholder.txe`, more readable.
ping @nic-chen
This is an
spacewander commented on a change in pull request #2594:
URL: https://github.com/apache/apisix/pull/2594#discussion_r518460652
##
File path: apisix/plugins/jwt-auth.lua
##
@@ -280,14 +295,9 @@ local function gen_token()
core.log.info("consumer: ",
membphis commented on a change in pull request #689:
URL: https://github.com/apache/apisix-dashboard/pull/689#discussion_r518459947
##
File path: api/conf/conf.json
##
@@ -10,6 +10,12 @@
"dag-lib-path": "",
"etcd": {
"endpoints": "127.0.0.1:2379"
+},
+
spacewander commented on a change in pull request #2596:
URL: https://github.com/apache/apisix/pull/2596#discussion_r518459588
##
File path: t/plugin/log-rotate.t
##
@@ -95,11 +95,89 @@ GET /t
ngx.say("done")
}
}
request
-GET /t
---
membphis commented on issue #2614:
URL: https://github.com/apache/apisix/issues/2614#issuecomment-722733913
missing `make init` or `apisix init` step
This is an automated message from the Apache Git Service.
To respond to
1 - 100 of 209 matches
Mail list logo
