[GitHub] [apisix] moonming commented on issue #2647: bug: The download page link in the release page is invalid

2020-11-06 Thread GitBox
moonming commented on issue #2647: URL: https://github.com/apache/apisix/issues/2647#issuecomment-723401990 will fix in https://github.com/apache/apisix-website/issues/81 This is an automated message from the Apache Git Servi

[GitHub] [apisix-website] moonming opened a new issue #81: move http://apisix.apache.org/docs/downloads/ to http://apisix.apache.org/downloads/

2020-11-06 Thread GitBox
moonming opened a new issue #81: URL: https://github.com/apache/apisix-website/issues/81 The `doc` prefix is not needed, and many historical releases use http://apisix.apache.org/downloads/ This is an automated message from

[GitHub] [apisix] moonming commented on issue #2649: bug: The jwt plugin does not handle the case where `exp` is empty

2020-11-06 Thread GitBox
moonming commented on issue #2649: URL: https://github.com/apache/apisix/issues/2649#issuecomment-723401730 @tzssangglass please take a look This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] moonming opened a new issue #2649: bug: The jwt plugin does not handle the case where `exp` is empty

2020-11-06 Thread GitBox
moonming opened a new issue #2649: URL: https://github.com/apache/apisix/issues/2649 https://github.com/apache/apisix/commit/27875e57901ff1bbb1161bbd55364ecef2990e27#r43958477 This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #716: bug: use dashboard2.0 set jwt-auth, it will return 404 when generate JWT credential

2020-11-06 Thread GitBox
idbeta edited a comment on issue #716: URL: https://github.com/apache/apisix-dashboard/issues/716#issuecomment-723394107 the etcd data after use dashboard2.0 set jwt-auth: ``` /apisix/consumers/test_hj {"id":"test_hj","create_time":1604724760,"update_time":1604724760,"username":"t

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #716: bug: use dashboard2.0 set jwt-auth, it will return 404 when generate JWT credential

2020-11-06 Thread GitBox
idbeta edited a comment on issue #716: URL: https://github.com/apache/apisix-dashboard/issues/716#issuecomment-723394107 the etcd data after use dashboard2.0 set jwt-auth: ``` /apisix/consumers/test_hj {"id":"test_hj","create_time":1604724760,"update_time":1604724760,"username":"t

[GitHub] [apisix-dashboard] idbeta opened a new issue #717: bug: The route created by admin API is missing fields in the dashboard display

2020-11-06 Thread GitBox
idbeta opened a new issue #717: URL: https://github.com/apache/apisix-dashboard/issues/717 - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance improvement - [ ] Other The route created by admin API is mi

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #716: bug: use dashboard2.0 set jwt-auth, it will return 404 when generate JWT credential

2020-11-06 Thread GitBox
idbeta edited a comment on issue #716: URL: https://github.com/apache/apisix-dashboard/issues/716#issuecomment-723394107 the etcd data after use dashboard2.0 set jwt-auth: ``` /apisix/consumers/test_hj {"id":"test_hj","create_time":1604724760,"update_time":1604724760,"username":"t

[GitHub] [apisix-dashboard] idbeta commented on issue #716: bug: use dashboard2.0 set jwt-auth, it will return 404 when generate JWT credential

2020-11-06 Thread GitBox
idbeta commented on issue #716: URL: https://github.com/apache/apisix-dashboard/issues/716#issuecomment-723394107 the etcd data after use dashboard2.0 set jwt-auth: /apisix/consumers/test_hj {"id":"test_hj","create_time":1604724760,"update_time":1604724760,"username":"test_hj","plugi

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #716: bug: use dashboard2.0 set jwt-auth, it will return 404 when generate JWT credential

2020-11-06 Thread GitBox
idbeta edited a comment on issue #716: URL: https://github.com/apache/apisix-dashboard/issues/716#issuecomment-723394107 the etcd data after use dashboard2.0 set jwt-auth: /apisix/consumers/test_hj {"id":"test_hj","create_time":1604724760,"update_time":1604724760,"username":"test_hj"

[GitHub] [apisix-dashboard] nic-chen commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
nic-chen commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723393338 > @nic-chen I think you have told me that, you have found this bug? all right? yes,will fix it soon

[GitHub] [apisix-dashboard] idbeta opened a new issue #716: bug: use dashboard2.0 set jwt-auth, it will return 404 when generate JWT credential

2020-11-06 Thread GitBox
idbeta opened a new issue #716: URL: https://github.com/apache/apisix-dashboard/issues/716 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance imp

[GitHub] [apisix] idbeta commented on issue #2647: bug: The download page link in the release page is invalid

2020-11-06 Thread GitBox
idbeta commented on issue #2647: URL: https://github.com/apache/apisix/issues/2647#issuecomment-723389018 > where did you get this link? https://github.com/apache/apisix/releases/tag/2.0 This is an automated message fr

[GitHub] [apisix-dashboard] membphis commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
membphis commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723389014 @nic-chen I think you have told me that, you have found this bug? all right? This is an automated message fr

[GitHub] [apisix] membphis commented on issue #2647: bug: The download page link in the release page is invalid

2020-11-06 Thread GitBox
membphis commented on issue #2647: URL: https://github.com/apache/apisix/issues/2647#issuecomment-723388805 where did you get this link? This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix-dashboard] membphis closed issue #714: Improve Makefile to test & build & deploy the manager-api

2020-11-06 Thread GitBox
membphis closed issue #714: URL: https://github.com/apache/apisix-dashboard/issues/714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] membphis commented on issue #714: Improve Makefile to test & build & deploy the manager-api

2020-11-06 Thread GitBox
membphis commented on issue #714: URL: https://github.com/apache/apisix-dashboard/issues/714#issuecomment-723388515 duplicated with https://github.com/apache/apisix-dashboard/issues/715 close this issue This is an aut

[GitHub] [apisix] membphis edited a comment on issue #2644: request help: APISIX Benchmark fails

2020-11-06 Thread GitBox
membphis edited a comment on issue #2644: URL: https://github.com/apache/apisix/issues/2644#issuecomment-723388373 > I saw 499 and 502 status code responses in access log. can you show us your golang API code? we'll make a try for this benchmark.

[GitHub] [apisix] membphis commented on issue #2644: request help: APISIX Benchmark fails

2020-11-06 Thread GitBox
membphis commented on issue #2644: URL: https://github.com/apache/apisix/issues/2644#issuecomment-723388373 > I saw 499 and 502 status code responses in access log. can you show me your golang API code? we'll make a try for this benchmark. ---

[GitHub] [apisix-dashboard] gxthrj edited a comment on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
gxthrj edited a comment on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723388215 I create a new issue to improve #715 This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] gxthrj commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
gxthrj commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723388215 I create a new issue to impove #715 This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] gxthrj opened a new issue #715: [Proposal]Standardize project output documents and simplify the way of making install

2020-11-06 Thread GitBox
gxthrj opened a new issue #715: URL: https://github.com/apache/apisix-dashboard/issues/715 1. Distinguish development documents & deployment documents; 2. Independently compiled directory structure; 3. Unified management dashboard and manager-api packaging method (independent & combin

[GitHub] [apisix-dashboard] membphis commented on issue #709: bug: Missing directory “/output/logs/”

2020-11-06 Thread GitBox
membphis commented on issue #709: URL: https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723387495 ok, got it. thansk for your explain This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] membphis commented on issue #714: Improve Makefile to test & build & deploy the manager-api

2020-11-06 Thread GitBox
membphis commented on issue #714: URL: https://github.com/apache/apisix-dashboard/issues/714#issuecomment-723387457 @gxthrj you can write your proposal here. This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix-dashboard] membphis opened a new issue #714: Improve Makefile to test & build & deploy the manager-api

2020-11-06 Thread GitBox
membphis opened a new issue #714: URL: https://github.com/apache/apisix-dashboard/issues/714 - [ ] E2E Test - [ ] Build & Deploy This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix-dashboard] membphis commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
membphis commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723387274 I think we need refractory the deploy doc. Let us discuss in issue first. This is an automated me

[GitHub] [apisix] LiteSun commented on issue #2082: request help: Update plugin's schema

2020-11-06 Thread GitBox
LiteSun commented on issue #2082: URL: https://github.com/apache/apisix/issues/2082#issuecomment-723385857 Got it! Tks👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #709: bug: Missing directory “/output/logs/”

2020-11-06 Thread GitBox
juzhiyuan commented on issue #709: URL: https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723366350 > we already have `logs` folder in `api`, why we choose a new temporary `output`? > > it makes me confused. The `output` directory is the final directory to sa

[apisix-dashboard] branch feat-deploy-with-docker updated (28c788d -> 2699181)

2020-11-06 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch feat-deploy-with-docker in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 28c788d fix: CI add 2699181 fix: path of `config.yaml` No new revisions were ad

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723364900 Why not use a template-configuration? No matter use a standalone file or just added them to codes. Thi

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan edited a comment on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723364900 How about using a template-configuration? No matter use a standalone file or just added them to codes. -

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723364294 @membphis Yes, we couldn't build it under the api directory due to users may copy them and move them to another place.

[GitHub] [apisix-dashboard] membphis closed pull request #713: fix: create log dir if not exists

2020-11-06 Thread GitBox
membphis closed pull request #713: URL: https://github.com/apache/apisix-dashboard/pull/713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-dashboard] membphis commented on pull request #713: fix: create log dir if not exists

2020-11-06 Thread GitBox
membphis commented on pull request #713: URL: https://github.com/apache/apisix-dashboard/pull/713#issuecomment-723362994 close this PR first. feel free to reopen it @nic-chen This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] nic-chen commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
nic-chen commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723361900 > > @juzhiyuan @moonming > > Actually, users only need to care about `/output/conf/`, only developers need to care about `/api/conf/` > > that is a bad way.

[GitHub] [apisix-dashboard] membphis commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
membphis commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723360929 > @juzhiyuan @moonming > > Actually, users only need to care about `/output/conf/`, only developers need to care about `/api/conf/` that is a bad way.

[GitHub] [apisix-dashboard] membphis commented on issue #709: bug: Missing directory “/output/logs/”

2020-11-06 Thread GitBox
membphis commented on issue #709: URL: https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723359281 here is an example of APISIX, please ref: https://github.com/apache/apisix/blob/master/Makefile#L87 This is

[GitHub] [apisix-dashboard] membphis commented on issue #709: bug: Missing directory “/output/logs/”

2020-11-06 Thread GitBox
membphis commented on issue #709: URL: https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723359079 we already have `logs` folder in `api`, why we choose a new temporary `output`? it makes me confused. ---

[GitHub] [apisix-dashboard] membphis commented on issue #709: bug: Missing directory “/output/logs/”

2020-11-06 Thread GitBox
membphis commented on issue #709: URL: https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723358684 the `output/logs` should be created in `api/run.sh` This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] membphis commented on pull request #713: fix: create log dir if not exists

2020-11-06 Thread GitBox
membphis commented on pull request #713: URL: https://github.com/apache/apisix-dashboard/pull/713#issuecomment-723358789 > fix: create log dir if not exists please discuss in issue first. https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723358684 -

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723358007 > @juzhiyuan @moonming > > Actually, users only need to care about `/output/conf/`, only developers need to care about `/api/conf/` > > But users

[GitHub] [apisix] membphis opened a new issue #2648: CI: support openresty 1.19.3

2020-11-06 Thread GitBox
membphis opened a new issue #2648: URL: https://github.com/apache/apisix/issues/2648 temporary patch, that is not good way: https://github.com/apache/apisix/pull/2646 This is an automated message from the Apache Git Service

[GitHub] [apisix] membphis commented on pull request #2646: CI: specified to use openresty `1.17.8.2`.

2020-11-06 Thread GitBox
membphis commented on pull request #2646: URL: https://github.com/apache/apisix/pull/2646#issuecomment-723357105 > why apisix can not work with openresty 1.19? the result of `json.encode` changed. we can fit this later. ---

[GitHub] [apisix] membphis merged pull request #2646: CI: specified to use openresty `1.17.8.2`.

2020-11-06 Thread GitBox
membphis merged pull request #2646: URL: https://github.com/apache/apisix/pull/2646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: CI: specified to use openresty `1.17.8.2`. (#2646)

2020-11-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 4b349dc CI: specified to use openresty `1.17.

[GitHub] [apisix] membphis closed issue #2645: CI: fail, because openresty released a new version 1.19.3.1

2020-11-06 Thread GitBox
membphis closed issue #2645: URL: https://github.com/apache/apisix/issues/2645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix-dashboard] nic-chen commented on pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
nic-chen commented on pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#issuecomment-723356469 @juzhiyuan @moonming Actually, users only need to care about `/output/conf/`, only developers need to care about `/api/conf/` --

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #701: feat: deploy with docker

2020-11-06 Thread GitBox
nic-chen commented on a change in pull request #701: URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519057295 ## File path: .github/workflows/deploy-with-docker.yml ## @@ -0,0 +1,40 @@ +name: Deploy with Docker + +on: + push: +branches: + - maste

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
moonming commented on a change in pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r519055960 ## File path: docs/deploy.md ## @@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`. ## Run -1. According t

[GitHub] [apisix-dashboard] nic-chen commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
nic-chen commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723345679 > > > is bug of manager API or apisix? > > > > This is a bug of manager API. > > @nic-chen please take a look working on it

[GitHub] [apisix] moonming commented on pull request #2646: CI: specified to use openresty `1.17.8.2`.

2020-11-06 Thread GitBox
moonming commented on pull request #2646: URL: https://github.com/apache/apisix/pull/2646#issuecomment-723344807 why apisix can not work with openresty 1.19? This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] idbeta opened a new issue #2647: bug: The download page link in the release page is invalid

2020-11-06 Thread GitBox
idbeta opened a new issue #2647: URL: https://github.com/apache/apisix/issues/2647 ### Issue description `download page` link to http://apisix.apache.org/downloads/ which is 404 now. This is an automated message from the

[GitHub] [apisix] membphis opened a new pull request #2646: CI: specified to use openresty `1.17.8.2`.

2020-11-06 Thread GitBox
membphis opened a new pull request #2646: URL: https://github.com/apache/apisix/pull/2646 will support `1.19.3.1` later. ### What this PR does / why we need it: fix https://github.com/apache/apisix/issues/2645 ### Pre-submission checklist: * [ ] Did you ex

[GitHub] [apisix] membphis opened a new issue #2645: CI: fail, because openresty released a new version 1.19.3.1

2020-11-06 Thread GitBox
membphis opened a new issue #2645: URL: https://github.com/apache/apisix/issues/2645 https://github.com/apache/apisix/runs/1364462832#step:11:15 ``` + openresty -V nginx version: openresty/1.19.3.1 built with OpenSSL 1.1.1h 22 Sep 2020 -

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan commented on a change in pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r518849752 ## File path: docs/deploy.md ## @@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`. ## Run -1. According

[GitHub] [apisix] NicolasBachs commented on issue #2644: request help: APISIX Benchmark fails

2020-11-06 Thread GitBox
NicolasBachs commented on issue #2644: URL: https://github.com/apache/apisix/issues/2644#issuecomment-723160449 I saw 499 and 502 status code responses in access log. When we ran the benchmark straight to golang API we haven't received any status code different to 200. ```

[apisix] branch master updated: feat: hide APISIX version from Server header. (#2639)

2020-11-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 1883554 feat: hide APISIX version from Server

[GitHub] [apisix] membphis merged pull request #2639: feat: hide APISIX version from Server header.

2020-11-06 Thread GitBox
membphis merged pull request #2639: URL: https://github.com/apache/apisix/pull/2639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on issue #2638: request help: disable ssl_session_tickets by default

2020-11-06 Thread GitBox
membphis commented on issue #2638: URL: https://github.com/apache/apisix/issues/2638#issuecomment-723159269 disable ssl_session_tickets by default +1 ^_^ This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] membphis commented on a change in pull request #2596: fix(log-rotate): avoid creating multiple timers

2020-11-06 Thread GitBox
membphis commented on a change in pull request #2596: URL: https://github.com/apache/apisix/pull/2596#discussion_r518844505 ## File path: apisix/timers.lua ## @@ -0,0 +1,89 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agr

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #702: 404 page not found

2020-11-06 Thread GitBox
juzhiyuan commented on issue #702: URL: https://github.com/apache/apisix-dashboard/issues/702#issuecomment-723156079 Yes, or users will get confused. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #701: feat: deploy with docker

2020-11-06 Thread GitBox
juzhiyuan commented on a change in pull request #701: URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r518843378 ## File path: .github/workflows/deploy-with-docker.yml ## @@ -0,0 +1,40 @@ +name: Deploy with Docker + +on: + push: +branches: + - mast

[GitHub] [apisix] membphis commented on issue #2643: request help: Use ngx.var.request_id as unique id, not jit-uuid.

2020-11-06 Thread GitBox
membphis commented on issue #2643: URL: https://github.com/apache/apisix/issues/2643#issuecomment-723152572 we mainly use `jit-uuid` when we need to generate Gateway ID in APISIX, it works in `init_lua` phase. I do not think we can use `ngx.var.request_id` in this phase. -

[apisix] branch master updated: fix(jwt-auth): validate if the claimed secret is base64 encoded. (#2642)

2020-11-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2ad7f65 fix(jwt-auth): validate if the claime

[GitHub] [apisix] membphis merged pull request #2642: fix(jwt-auth): validate if the claimed secret is base64 encoded.

2020-11-06 Thread GitBox
membphis merged pull request #2642: URL: https://github.com/apache/apisix/pull/2642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on issue #2644: request help: APISIX Benchmark fails

2020-11-06 Thread GitBox
membphis commented on issue #2644: URL: https://github.com/apache/apisix/issues/2644#issuecomment-723150925 you can check the access log, it will show you the upstream status code. I think it is useful for you to confirm: `3xx` or `4xx` are returned by APISIX or Glang software.

[GitHub] [apisix-dashboard] membphis commented on issue #702: 404 page not found

2020-11-06 Thread GitBox
membphis commented on issue #702: URL: https://github.com/apache/apisix-dashboard/issues/702#issuecomment-723149451 > the Dockerfile under the `/api` folder is used for e2e test, it need to run the newest code. @membphis @juzhiyuan that is not a good way. if it is used for E2

[GitHub] [apisix-dashboard] nic-chen commented on issue #702: 404 page not found

2020-11-06 Thread GitBox
nic-chen commented on issue #702: URL: https://github.com/apache/apisix-dashboard/issues/702#issuecomment-723147377 the Dockerfile under the `/api` folder is used for e2e test, it need to run the newest code. @membphis @juzhiyuan -

[GitHub] [apisix] qiujiayu closed pull request #1843: can't use lrucache from discovery

2020-11-06 Thread GitBox
qiujiayu closed pull request #1843: URL: https://github.com/apache/apisix/pull/1843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on issue #2296: request help: about prometheus metrics for deny access

2020-11-06 Thread GitBox
membphis commented on issue #2296: URL: https://github.com/apache/apisix/issues/2296#issuecomment-723145349 I think we can remove `plugin_attr` finally. I love `plugin metadata` way. for this issue, we can add new field `export_uri: /apisix/prometheus/metrics ` via `plugin met

[GitHub] [apisix-dashboard] membphis commented on issue #702: 404 page not found

2020-11-06 Thread GitBox
membphis commented on issue #702: URL: https://github.com/apache/apisix-dashboard/issues/702#issuecomment-723143465 > oh @ztgoto , sorry to lead your confused, please use the Dockerfile in the root folder[1]. As for the Dockerfile under the `/api` folder, @nic-chen @membphis do we really

[GitHub] [apisix] NicolasBachs opened a new issue #2644: request help:

2020-11-06 Thread GitBox
NicolasBachs opened a new issue #2644: URL: https://github.com/apache/apisix/issues/2644 ### Issue description I was performing stress test in order to check apisix performance but I got an unexpected status code response (Non-2xx or 3xx responses). **Direct to upstream (Golan

[GitHub] [apisix] membphis commented on issue #2640: [DISCUSS] Only keep one Server header in HTTP response

2020-11-06 Thread GitBox
membphis commented on issue #2640: URL: https://github.com/apache/apisix/issues/2640#issuecomment-723142248 > Do you remember why you added it deliberately? sorry I do not remember this :( if you think it is useless or wong, welcome to remove it. > I found sometimes there are

[GitHub] [apisix] membphis commented on issue #2634: I don't want to set up different config-default.yaml for different environments

2020-11-06 Thread GitBox
membphis commented on issue #2634: URL: https://github.com/apache/apisix/issues/2634#issuecomment-723139193 > But when i use the apisix version 2.0 and profile is dev. when apisix start, it required config-default-dev.yaml. let us fix it, I think that is a bug.

[GitHub] [apisix-dashboard] membphis edited a comment on issue #646: request help: let custom plugin show in dashboard

2020-11-06 Thread GitBox
membphis edited a comment on issue #646: URL: https://github.com/apache/apisix-dashboard/issues/646#issuecomment-723137410 I was confused with those labels. Welcome to split them into multiple different issues for easy tracking and fix. @juzhiyuan @idbeta ![image](https://us

[GitHub] [apisix-dashboard] membphis commented on issue #646: request help: let custom plugin show in dashboard

2020-11-06 Thread GitBox
membphis commented on issue #646: URL: https://github.com/apache/apisix-dashboard/issues/646#issuecomment-723137410 I was confused with those labels. Welcome to split them into multiple different issues for easy tracking and fix. ![image](https://user-images.githubusercontent.com/6

[GitHub] [apisix-dashboard] membphis commented on issue #646: request help: let custom plugin show in dashboard

2020-11-06 Thread GitBox
membphis commented on issue #646: URL: https://github.com/apache/apisix-dashboard/issues/646#issuecomment-723135729 > @thekingofworld We have reproduced this problem in the local environment, thank you for your feedback. do you find an easier way to reproduce this issue? or as the r

[GitHub] [apisix-dashboard] membphis commented on issue #699: feat: build web docker image in source code

2020-11-06 Thread GitBox
membphis commented on issue #699: URL: https://github.com/apache/apisix-dashboard/issues/699#issuecomment-723132780 > I think we should build web project and api project in two docker images and we can combine it in docker compose or in k8s pod. I think one docker or one server is m

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
idbeta edited a comment on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723100368 > is bug of manager API or apisix? This is a bug of manager API. This is an automated message fr

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #701: feat: deploy with docker

2020-11-06 Thread GitBox
codecov-io edited a comment on pull request #701: URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-722292181 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=h1) Report > Merging [#701](https://codecov.io/gh/apache/apisix-dashboard/pull/

[apisix-dashboard] branch feat-deploy-with-docker updated (6eb27bc -> 28c788d)

2020-11-06 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch feat-deploy-with-docker in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 6eb27bc feat: docker deploy test add 28c788d fix: CI No new revisions were adde

[GitHub] [apisix-dashboard] moonming commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
moonming commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723110981 > > is bug of manager API or apisix? > > This is a bug of manager API. @nic-chen please take a look ---

[GitHub] [apisix-dashboard] idbeta commented on issue #705: Upload SSL successfully but with error message

2020-11-06 Thread GitBox
idbeta commented on issue #705: URL: https://github.com/apache/apisix-dashboard/issues/705#issuecomment-723102564 > Does this issue duplicate with #697 ? @juzhiyuan @idbeta I am sorry for late reply, this is new~ This

[GitHub] [apisix-dashboard] idbeta commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
idbeta commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723100368 > is bug of manager API or apisix? This is a bug of manager API. This is an automated message from the Apac

[GitHub] [apisix-dashboard] spacewander commented on issue #705: Upload SSL successfully but with error message

2020-11-06 Thread GitBox
spacewander commented on issue #705: URL: https://github.com/apache/apisix-dashboard/issues/705#issuecomment-723086698 @bingoku What the host you are using for etcd? ```yaml etcd: host: # it's possible to define multiple etcd hosts addresses of the

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #700: feat: Add web "Dockerfile"

2020-11-06 Thread GitBox
ShiningRush commented on pull request #700: URL: https://github.com/apache/apisix-dashboard/pull/700#issuecomment-723086434 Why we need this?manager api can host static files, so keep one image would be better. This is an au

[GitHub] [apisix-dashboard] moonming commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
moonming commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723075512 is bug of manager API or apisix? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] bingoku commented on issue #705: Upload SSL successfully but with error message

2020-11-06 Thread GitBox
bingoku commented on issue #705: URL: https://github.com/apache/apisix-dashboard/issues/705#issuecomment-723074868 ``` /usr/local/apisix//deps/share/lua/5.1/resty/etcd/v3.lua:149: in function 'new' /usr/local/apisix/apisix/core/config_etcd.lua:416: in function

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan commented on a change in pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r518737954 ## File path: docs/deploy.md ## @@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`. ## Run -1. According

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
idbeta edited a comment on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723045873 @juzhiyuan Aliyun and Self make , They all can reproduce the problem. This is an automated message

[GitHub] [apisix-dashboard] idbeta commented on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
idbeta commented on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-723045873 @juzhiyuan [x]Aliyun [x]Self make They can all reproduce the problem. This is an automated message

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #697: dashboard 2.0 failed to fetch ssl certificate not found

2020-11-06 Thread GitBox
idbeta edited a comment on issue #697: URL: https://github.com/apache/apisix-dashboard/issues/697#issuecomment-722783272 @tiger333777 I have reproduced this problem locally and it is being solved, thanks for the feedback.

[apisix-dashboard] branch feat-deploy-with-docker updated (5e092c6 -> 6eb27bc)

2020-11-06 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch feat-deploy-with-docker in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 5e092c6 feat: added deploy with docker CD add b4b646b chore: refactor `conf` of

[GitHub] [apisix-dashboard] codecov-io commented on pull request #713: fix: create log dir if not exists

2020-11-06 Thread GitBox
codecov-io commented on pull request #713: URL: https://github.com/apache/apisix-dashboard/pull/713#issuecomment-723016071 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=h1) Report > Merging [#713](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #713: fix: create log dir if not exists

2020-11-06 Thread GitBox
nic-chen opened a new pull request #713: URL: https://github.com/apache/apisix-dashboard/pull/713 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance close #709

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
nic-chen commented on a change in pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r518670709 ## File path: docs/deploy.md ## @@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`. ## Run -1. According t

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
nic-chen commented on a change in pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r518670073 ## File path: docs/deploy.md ## @@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`. ## Run -1. According t

[GitHub] [apisix] Miss-you opened a new issue #2643: request help: Use ngx.var.request_id as unique id, not jit-uuid.

2020-11-06 Thread GitBox
Miss-you opened a new issue #2643: URL: https://github.com/apache/apisix/issues/2643 ### Issue description Use `ngx.var.request_id` as unique id, not `jit-uuid`. The distributed unique id generation algorithm is a classic problem. The current seed of jit-uuid is set by the lua

[GitHub] [apisix] Miss-you commented on pull request #2641: [wip]fix: disable ssl_session_tickets by default #2638

2020-11-06 Thread GitBox
Miss-you commented on pull request #2641: URL: https://github.com/apache/apisix/pull/2641#issuecomment-723006590 #2638 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #711: fix: deploy doc

2020-11-06 Thread GitBox
juzhiyuan commented on a change in pull request #711: URL: https://github.com/apache/apisix-dashboard/pull/711#discussion_r518655405 ## File path: docs/deploy.md ## @@ -81,7 +81,7 @@ The bundled files are located in the root directory `/output/html`. ## Run -1. According

  1   2   >