membphis commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723542779
> the dockfile need to be modify too
let us update it. the current way is not good.
This is an automa
gxthrj commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723542675
> Also, as far as know, the dockerfile under the api folder is used to do
test, it seems that you don't have enough commuting with chen.
just see the code of dockerfile,
membphis commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723542671
> If you want to only build the manager api, just passed some arguments when
building the image by using the root dockerfile.
>
> Right? @membphis
yes, that is
membphis commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519276779
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -147,6 +148,8 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
nic-chen commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519265886
##
File path: .github/workflows/e2e-test-backend.yml
##
@@ -28,7 +28,10 @@ jobs:
sleep 5
docker logs docker_managerapi_1
+
membphis opened a new issue #722:
URL: https://github.com/apache/apisix-dashboard/issues/722
we can add this picture into `readme` doc, helps the user know what is the
relat
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723538592
Also, as far as know, the dockerfile under the api folder is used to do
test, it seems that you don't have enough commuting with chen.
---
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723538375
So why there will have multiple Dockerfile files? This doesn't make sense
and it's unacceptable for me!
If you want to only build the manager api, just passed some ar
juzhiyuan merged pull request #82:
URL: https://github.com/apache/apisix-website/pull/82
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 7e65dbc fix: use empty docsUri (#82)
juzhiyuan closed issue #81:
URL: https://github.com/apache/apisix-website/issues/81
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
juzhiyuan closed issue #2647:
URL: https://github.com/apache/apisix/issues/2647
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519263674
##
File path: .github/workflows/e2e-test-backend.yml
##
@@ -28,7 +28,10 @@ jobs:
sleep 5
docker logs docker_managerapi_1
+
nic-chen commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519262495
##
File path: .github/workflows/e2e-test-backend.yml
##
@@ -28,7 +28,10 @@ jobs:
sleep 5
docker logs docker_managerapi_1
+
nic-chen commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519262363
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -147,6 +147,7 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
nic-chen commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-723536214
@gxthrj please help deploy in Cloud. I don't know how to trigger the hook.
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch feat-deploy-with-docker
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 225c41b docs: update doc for docker deploy
add 30ee6f5 fix: typo
No new revisio
nic-chen commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519261267
##
File path: docs/deploy-with-docker.zh-CN.md
##
@@ -34,7 +34,7 @@ $ docker build -t apisix-dashboard:{$tag} .
- `conf.listen.host` 为容器内监听 IP，
nic-chen commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723535130
>
https://github.com/apache/apisix-dashboard/blob/v2.0/api/internal/handler/consumer/consumer.go#L102-L110
>
> Should the manager-api still handle ID? cc @nic-chen @me
tzssangglass commented on issue #2649:
URL: https://github.com/apache/apisix/issues/2649#issuecomment-723535042
get it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
nic-chen commented on issue #2654:
URL: https://github.com/apache/apisix/issues/2654#issuecomment-723534892
> there is the new field we need to support, please confirm they are Unix
timestamp:
>
> * create_time
> * update_time
>
> @nic-chen @ShiningRush
yes, it is. a
membphis commented on issue #2649:
URL: https://github.com/apache/apisix/issues/2649#issuecomment-723533321
> In this way, still needto handle the case where `exp` is empty? I think
that's unnecessary.
after we set a default value in jsonschema, eg: `3600` sec, the `exp` can
not be
gxthrj commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723533080
> > there is a questions, We have designed two `dockerfile` for both api and
dashboard. I think the reason for this is because we need to build the image
independently.
>
tzssangglass commented on issue #2649:
URL: https://github.com/apache/apisix/issues/2649#issuecomment-723530452
In this way, still needto handle the case where `exp` is empty? I think
that's unnecessary.
This is an autom
membphis commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723528045
I suggest we remove `input.ID` to avoid trouble. only use the consumer name
is clearer and simpler.
This is
juzhiyuan commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723527549
https://github.com/apache/apisix-dashboard/blob/v2.0/api/internal/handler/consumer/consumer.go#L102-L110
Should the manager-api still handle ID? cc @nic-chen @membphi
membphis opened a new issue #2656:
URL: https://github.com/apache/apisix/issues/2656
for this case, it should throw an error message, eg: `the id and username
must be same for consumer object`.
```shell
$ curl http://127.0.0.1:9080/apisix/admin/consumers/2 -H 'X-API-KEY:
edd1c9f
juzhiyuan commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519252864
##
File path: docs/deploy-with-docker.zh-CN.md
##
@@ -34,7 +34,7 @@ $ docker build -t apisix-dashboard:{$tag} .
- `conf.listen.host` 为容器内监听 IP
membphis commented on issue #2651:
URL: https://github.com/apache/apisix/issues/2651#issuecomment-723527358
> And this one.
I make a try right now, it works fine(it should throw an error, that is a
bug)
I'll create a new issue about this bug.
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723527232
> web vs dashboard: I can not sure which one is better.
@membphis `web` is fine because this repo's name is `apisix-dashboard`, so
we don't need to wrap a `dashboard`
membphis commented on issue #2654:
URL: https://github.com/apache/apisix/issues/2654#issuecomment-723527184
there is the new field we need to support, please confirm they are Unix
timestamp:
* create_time
* update_time
@nic-chen @ShiningRush
-
juzhiyuan edited a comment on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723527147
> @juzhiyuan please give a suggest for renaming `.actions`
Just like workflows, actions are under the .github directory, just renamed
it to `.apache` or `.asf`
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723527147
> @juzhiyuan please give a suggest for renaming `.actions`
Just like workflows, actions are under the .github directory, just renamed
it to `.apache`.
`tools`
membphis commented on issue #2296:
URL: https://github.com/apache/apisix/issues/2296#issuecomment-723527025
`plugin attr` is mainly for providing the default value, we can use the
default value of `plugin metadata` to support this too.
here is an example:
https://github.com/apache/a
juzhiyuan edited a comment on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526964
> there is a questions, We have designed two `dockerfile` for both api and
dashboard. I think the reason for this is because we need to build the image
independently.
membphis commented on issue #2655:
URL: https://github.com/apache/apisix/issues/2655#issuecomment-723526788
can you provide a mini step for this bug? then we can use it to reproduce
this bug
This is an automated message from
membphis commented on pull request #2592:
URL: https://github.com/apache/apisix/pull/2592#issuecomment-723526640
@dabue we can merge this PR after https://github.com/apache/apisix/pull/2596
merged.
I think this plugin depends on this PR.
membphis merged pull request #2650:
URL: https://github.com/apache/apisix/pull/2650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 021f24a docs: put the chapter "admin api" to
membphis commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526401
I don't want the dashboard and API to be built independently.
For users, they can choose only API, or dashboard + API, nothing else.
Within a single Dockfile, us
moonming commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723526003
> there is a questions, We have designed two `dockerfile` for both api and
dashboard. I think the reason for this is because we need to build the image
independently.
gxthrj commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723525452
@juzhiyuan please give a suggest for renaming `.actions`
This is an automated message from the Apache Git Ser
gxthrj commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723525187
there is a questions, We have designed two `dockerfile` for both api and
dashboard. I think the reason for this is because we need to build the image
independently.
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 6a6d872 feat: added policy for semantic-pr (#
membphis commented on pull request #2652:
URL: https://github.com/apache/apisix/pull/2652#issuecomment-723524949
@juzhiyuan many thx, merged already
This is an automated message from the Apache Git Service.
To respond to the
membphis merged pull request #2652:
URL: https://github.com/apache/apisix/pull/2652
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis commented on issue #2649:
URL: https://github.com/apache/apisix/issues/2649#issuecomment-723524893
we can add a default value in JSON Schema here.
https://github.com/apache/apisix/blob/4b349dc5b3a72a7819273d35e387e561a4c536c7/apisix/plugins/jwt-auth.lua#L56
then we c
membphis commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519250057
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -147,6 +147,7 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
membphis commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519249979
##
File path: .github/workflows/e2e-test-backend.yml
##
@@ -28,7 +28,10 @@ jobs:
sleep 5
docker logs docker_managerapi_1
+
membphis commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519249743
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -147,6 +147,7 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
membphis commented on issue #720:
URL:
https://github.com/apache/apisix-dashboard/issues/720#issuecomment-723524280
Very good, I think you can make a checkpoint list. then you can check them
step by step.
This is an automat
membphis opened a new issue #721:
URL: https://github.com/apache/apisix-dashboard/issues/721
we need to follow Golang standard way:
https://github.com/golang-standards/project-layout
the current file structure is unacceptable:
 under one or more
+ * contrib
nic-chen commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519247125
##
File path: .github/workflows/e2e-test-backend.yml
##
@@ -28,7 +28,10 @@ jobs:
sleep 5
docker logs docker_managerapi_1
+
nic-chen commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519246782
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -147,6 +147,7 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
tzssangglass commented on issue #2649:
URL: https://github.com/apache/apisix/issues/2649#issuecomment-723520826
if `exp` is nil, it will cause a runtime error, like `attempt to perform
arithmetic on field 'exp' (a nil value)`, because use nil values in the `+`
operator.
but I have no i
membphis commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723520576
@nic-chen please if we need any update for manager-api. I think we do not
need to update `manager-api`.
if we do not need to update `manager-api`, we should remove the
nic-chen opened a new issue #720:
URL: https://github.com/apache/apisix-dashboard/issues/720
I will check current differences between manager api and admin api and
update here.
This is an automated message from the Apach
juzhiyuan opened a new pull request #82:
URL: https://github.com/apache/apisix-website/pull/82
close https://github.com/apache/apisix-website/issues/81
close https://github.com/apache/apisix/issues/2647
This is an automate
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch fix-docs
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit 9563b9753fd1e0141c62d6774cbb4c29066e22d9
Author: juzhiyuan
AuthorDate: Sun Nov 8 09:19:17 2020 +0800
f
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch fix-docs
in repository https://gitbox.apache.org/repos/asf/apisix-website.git.
at 9563b97 fix: use empty docsUri
This branch includes the following new commits:
new 9563b97 fix:
juzhiyuan commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723515066
Yes, the frontend has to update the consumer.
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on issue #2651:
URL: https://github.com/apache/apisix/issues/2651#issuecomment-723515019
And this one.
-
idbeta opened a new issue #2654:
URL: https://github.com/apache/apisix/issues/2654
### Issue description
There is no "createtime" when creating a consumer by adminAPI, which causes
dashboard to display wrong "Update Time"
### Environment
* apisix version (cmd: `apisix version`)
membphis opened a new issue #2653:
URL: https://github.com/apache/apisix/issues/2653
the `consumer_name` is clearer to undersatand.
to avoid ambiguity, use `consumer_name` instead and remove `consumer_id` in
doc and source code.
https://github.com/apache/apisix/search?q=consum
juzhiyuan opened a new pull request #2652:
URL: https://github.com/apache/apisix/pull/2652
### What this PR does / why we need it:
According to https://github.com/zeke/semantic-pull-requests , we use this
configuration to allow this bot to only to check PR's title.
### Pre-sub
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix.git
commit 85fb68bd76752ac67067670754e30246b18431a0
Author: 琚致远
AuthorDate: Sun Nov 8 08:37:27 2020 +0800
feat:
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix.git.
at 85fb68b feat: added policy for semantic-pr
This branch includes the following new commits:
new
membphis commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723514026
@juzhiyuan if we both use `username`, please confirm the `frontend` need to
update.
it shows you mainly use `id` now:
https://github.com/apache/apisix-dashboard/iss
membphis commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723513879
I check the process in APISIX, I am sure that we can use `username` is
enough. then we can ignore the field `id`.
> use the username as identify (from docs), then both
membphis commented on issue #2651:
URL: https://github.com/apache/apisix/issues/2651#issuecomment-723513870
Th
juzhiyuan commented on pull request #2650:
URL: https://github.com/apache/apisix/pull/2650#issuecomment-723513437
Oh let me file a PR for sementic bot, this PR looks good to me.
This is an automated message from the Apache G
moonming commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519238296
##
File path: api/test/e2e/ssl_test.go
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contrib
moonming commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519237883
##
File path: api/internal/handler/ssl/ssl.go
##
@@ -147,6 +147,7 @@ func (h *Handler) Create(c droplet.Context) (interface{},
error) {
}
juzhiyuan commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723512846
Why the frontend should do this fallback? If it's sure that we must use the
username as identify (from docs), then both fe and backend should use the
username.
-
juzhiyuan commented on issue #2651:
URL: https://github.com/apache/apisix/issues/2651#issuecomment-723512546
Not only this example, please check other examples in the Consumer part.
This is an automated message from the Apac
membphis commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723512495
@juzhiyuan
> if we can get `username`, we should use `username`. if not, we can use
`id`.
`frontend` should use this way to read the consumer `id`.
-
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723512397
1. Why .actions is ok? Is it clear for you when you see it in the first time?
2. If only the manager api is needed, why not update the repo's name to
manager-api?
membphis edited a comment on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723512066
the `id` and `username` must be the same. if they were not the same, will
return an error message. confirm this.
if we can get `username`, we should use `usern
membphis edited a comment on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723512066
the `id` and `username` must be the same. if they were not the same, will
return an error message. confirm this.
the doc is wrong. will update it soon.
membphis opened a new issue #2651:
URL: https://github.com/apache/apisix/issues/2651
This is an automated
membphis commented on issue #718:
URL:
https://github.com/apache/apisix-dashboard/issues/718#issuecomment-723512066
the `id` and `username` must be the same. if they were not the same, will
return an error message. confirm this.
the doc is wrong. will update it soon.
if we c
gxthrj edited a comment on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723446494
I recommend turning the project into a directory structure like this
```
apisix-dashboard
├── .actions
├── .github
├── README.md
├── api
│ └── make
gxthrj commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723510160
> 1. We don't have `.action`, we have `.actions`.
> 2. `.actions` is not clear for users, it should be renamed in this
reconstruction work.
> 3. In this proposal, you on
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch feat-deploy-with-docker
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from e1c5671 fix: CI fail
add 225c41b docs: update doc for docker deploy
No new revi
codecov-io edited a comment on pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#issuecomment-723461416
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/719?src=pr&el=h1)
Report
> Merging
[#719](https://codecov.io/gh/apache/apisix-dashboard/pull/
juzhiyuan commented on a change in pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#discussion_r519193131
##
File path: api/test/e2e/ssl_test.go
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contri
juzhiyuan edited a comment on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723464572
1. We don't have `.action`, we have `.actions`.
2. `.actions` is not clear for users, it should be renamed in this
reconstruction work.
3. In this proposal, yo
juzhiyuan commented on issue #715:
URL:
https://github.com/apache/apisix-dashboard/issues/715#issuecomment-723464572
1. We don't have `.action`, we have `.actions`.
2. `.actions` is not clear for users, it should be renamed in this refactor.
3. In this proposal, you only create 3 mak
codecov-io commented on pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719#issuecomment-723461416
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/719?src=pr&el=h1)
Report
> Merging
[#719](https://codecov.io/gh/apache/apisix-dashboard/pull/719?src
nic-chen opened a new pull request #719:
URL: https://github.com/apache/apisix-dashboard/pull/719
close #697
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dabue commented on a change in pull request #2592:
URL: https://github.com/apache/apisix/pull/2592#discussion_r519187087
##
File path: apisix/plugins/error-log-logger.lua
##
@@ -0,0 +1,220 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contrib
1 - 100 of 147 matches
Mail list logo
