[GitHub] [apisix] idbeta commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
idbeta commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725901464 > @souzens > > Thanks for feedback. > > but it works fine on my env using `etcd-3.4.13`. could you please provide more details ? thanks. > > @idbeta please help che

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725900813 OK, i will try to reproduce it in my minikube. This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725900114 > @ ziyou434 @souzens @yankunsam那么,你们所有人都在Kubernetes中部署APISIX和etcd吗? yes,required by my company. This is an au

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725899535 @ziyou434 @souzens @yankunsam So all of you deploy APISIX and etcd in Kubernetes? This is an automated message from th

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725899169 > > > That's strange, Could you use `tcpdump` in your environment, let's capture some HTTP packets between APISIX and the etcd to see whether the body is abnormal. > > > > >

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725896389 > > That's strange, Could you use `tcpdump` in your environment, let's capture some HTTP packets between APISIX and the etcd to see whether the body is abnormal. > > @ziyou434

[GitHub] [apisix] souzens commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
souzens commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725896048 ``` # # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with # this work for additional

[GitHub] [apisix] Gary-Airwallex commented on issue #2711: request help: plugins in global rules are prioritized over those in routes, regardless of priority

2020-11-11 Thread GitBox
Gary-Airwallex commented on issue #2711: URL: https://github.com/apache/apisix/issues/2711#issuecomment-725894084 TBH that still sounds counter intuitive to me. How about merging plugins from global rules with plugins from routes/services? We could mark global-rule plugins (e.g. with a pre

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725891419 > > That's strange, Could you use `tcpdump` in your environment, let's capture some HTTP packets between APISIX and the etcd to see whether the body is abnormal. > > @ziyou434

[GitHub] [apisix] yankunsam commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
yankunsam commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725891388 > > how to tell apisix the password of etcd? > > See https://github.com/apache/apisix/blob/master/conf/config-default.yaml for the details. As the guide document, I set

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725890628 > That's strange, Could you use `tcpdump` in your environment, let's capture some HTTP packets between APISIX and the etcd to see whether the body is abnormal. @ziyou434 Could y

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725890392 I find etcdctl get /apisix/services will return null,exist but null。/apisix/routes... is the same. I guess maybe errors occured in admin_init, but i haven't found. -

[GitHub] [apisix-dashboard] idbeta opened a new issue #792: bug: echo plugin can not set headers

2020-11-11 Thread GitBox
idbeta opened a new issue #792: URL: https://github.com/apache/apisix-dashboard/issues/792 - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance improvement - [ ] Other The headers option will automaticall

[GitHub] [apisix] backnero commented on issue #2678: bug: After upgrading to version 1.5, the attempt to call global'type' (a string value) error of ETCD appears

2020-11-11 Thread GitBox
backnero commented on issue #2678: URL: https://github.com/apache/apisix/issues/2678#issuecomment-725888505 I upgraded from 1.4.1 to version 1.5, so it is etcd api V2. When I use ``` etcdctl ls /apisix ``` ![image](https://user-images.githubusercontent.com/21979871/98907209-70a

[GitHub] [apisix] csh995426531 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
csh995426531 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725888363 me too. etcd version 3.4.13 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725884056 > how to tell apisix the password of etcd? See https://github.com/apache/apisix/blob/master/conf/config-default.yaml for the details. --

[GitHub] [apisix] ziyou434 commented on issue #2692: request help: got malformed version message: "" from etcd

2020-11-11 Thread GitBox
ziyou434 commented on issue #2692: URL: https://github.com/apache/apisix/issues/2692#issuecomment-725876907 > yes,need to add dns_resolver in config.yaml I want to instruct dns_reslover what kind of role does it play in the interaction between apisix and etcd, and why it is set up, plea

[GitHub] [apisix] Miss-you opened a new issue #2720: request help: Apache APISIX support gzip

2020-11-11 Thread GitBox
Miss-you opened a new issue #2720: URL: https://github.com/apache/apisix/issues/2720 ### Issue description Gzip is a file format used for file compression and decompression. It is based on the Deflate algorithm that allows files to be made smaller in size which allows for faster network

[GitHub] [apisix] yankunsam commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
yankunsam commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725877512 etcdserver: failed to apply request "header: put:" with response "" took (1.669µs) to execute, err is auth: user name is empty 2020-11-12 06:44:28.061760 W | etcdserver: failed

[GitHub] [apisix] ziyou434 edited a comment on issue #2692: request help: got malformed version message: "" from etcd

2020-11-11 Thread GitBox
ziyou434 edited a comment on issue #2692: URL: https://github.com/apache/apisix/issues/2692#issuecomment-725876907 > yes,need to add dns_resolver in config.yaml I want to instruct dns_reslover what kind of role does it play in the interaction between apisix and etcd, and why it is se

[GitHub] [apisix] spacewander commented on issue #2715: request help: openid-connect plugin

2020-11-11 Thread GitBox
spacewander commented on issue #2715: URL: https://github.com/apache/apisix/issues/2715#issuecomment-725876363 You can take a look as this article: https://swagger.io/docs/specification/authentication/openid-connect-discovery/ --

[GitHub] [apisix] yankunsam commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
yankunsam commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725875983 how to tell apisix the password of etcd? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] spacewander closed issue #2716: bug: apisix error logs

2020-11-11 Thread GitBox
spacewander closed issue #2716: URL: https://github.com/apache/apisix/issues/2716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725875467 That's strange, Could you use `tcpdump` in your environment, let's capture some HTTP packets between APISIX and the etcd to see whether the body is abnormal.

[GitHub] [apisix] spacewander commented on issue #2716: bug: apisix error logs

2020-11-11 Thread GitBox
spacewander commented on issue #2716: URL: https://github.com/apache/apisix/issues/2716#issuecomment-725875169 Should be solved by https://github.com/api7/lua-resty-etcd/pull/92/files This is an automated message from the Apa

[GitHub] [apisix] spacewander commented on issue #2717: request help: how do I get etcd data in a custom plugin

2020-11-11 Thread GitBox
spacewander commented on issue #2717: URL: https://github.com/apache/apisix/issues/2717#issuecomment-725874818 You can take a look at plugin-metadata API: https://github.com/apache/apisix/blob/master/doc/admin-api.md#plugin-metadata and its relative code.

[GitHub] [apisix] krufyliu commented on issue #2716: bug: apisix error logs

2020-11-11 Thread GitBox
krufyliu commented on issue #2716: URL: https://github.com/apache/apisix/issues/2716#issuecomment-725874462 @yankunsam what's your etcd address? i meet the same problem. if your etcd address has special character such as '-', the problem occurs.

[apisix] branch master updated: chore: sort the request headers output by the _M.uri and _M.old_uri function in t/lib/server.lua (#2696)

2020-11-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2ba28ff chore: sort the request headers ou

[GitHub] [apisix] spacewander merged pull request #2696: chore: sort the request headers output by the _M.uri and _M.old_uri function in t/lib/server.lua

2020-11-11 Thread GitBox
spacewander merged pull request #2696: URL: https://github.com/apache/apisix/pull/2696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #2636: chore: sort the request headers output by the _M.uri and _M.old_uri function in 't/lib/server.lua'

2020-11-11 Thread GitBox
spacewander closed issue #2636: URL: https://github.com/apache/apisix/issues/2636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] yankunsam commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
yankunsam commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725869963 > by test just now, apisix2.0 will report error above when run wtih etcd-3.4.13 > instead of etcd3.4.9 run ok docker.io/bitnami/etcd:3.4.9-debian-10-r34? The same errors.

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #785: feat(docs): improve README & Deploy

2020-11-11 Thread GitBox
juzhiyuan commented on a change in pull request #785: URL: https://github.com/apache/apisix-dashboard/pull/785#discussion_r521867296 ## File path: docs/deploy-with-docker.zh-CN.md ## @@ -17,44 +17,65 @@ # --> -# 使用 Docker 部署 +# 使用 Docker 构建并启动 -1. 构建镜像 +使用 Docker 构建 Dashb

[GitHub] [apisix] Firstsawyou commented on issue #2718: [DISCUSS] The error message "got malformed version message from etcd" is ambiguous

2020-11-11 Thread GitBox
Firstsawyou commented on issue #2718: URL: https://github.com/apache/apisix/issues/2718#issuecomment-725869358 I agree with you. I have also encountered such a situation, this prompt message is not clear. This is an automate

[GitHub] [apisix] membphis commented on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
membphis commented on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725865814 JSON Schema version is a useful field, we need to store and compare it. Needs to show a warning message if the JSON schema version is different from APISIX version. -

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #785: feat(docs): improve README & Deploy

2020-11-11 Thread GitBox
gxthrj commented on a change in pull request #785: URL: https://github.com/apache/apisix-dashboard/pull/785#discussion_r521863418 ## File path: docs/deploy-with-docker.zh-CN.md ## @@ -17,44 +17,65 @@ # --> -# 使用 Docker 部署 +# 使用 Docker 构建并启动 -1. 构建镜像 +使用 Docker 构建 Dashboar

[GitHub] [apisix] Firstsawyou opened a new issue #2719: doc(kafka-logger): modify the Chinese documentation of the `kafka-logger` plugin

2020-11-11 Thread GitBox
Firstsawyou opened a new issue #2719: URL: https://github.com/apache/apisix/issues/2719 ### Issue description In the `apisix/doc/zh-cn/plugins/kafka-logger.md` file, the descriptions of the `key` and `timeout` fields in the attribute directory are inconsistent. We need to adjust: h

[GitHub] [apisix] tokers opened a new issue #2718: [DISCUSS] The error message "got malformed version message from etcd" is ambiguous

2020-11-11 Thread GitBox
tokers opened a new issue #2718: URL: https://github.com/apache/apisix/issues/2718 When the etcd initialization fails, the output error message: ``` got malformed version message: "" from etcd ``` Which is ambiguous, i think the error details should be exposed. What do yo

[GitHub] [apisix] ziyou434 commented on issue #2716: bug: apisix error logs

2020-11-11 Thread GitBox
ziyou434 commented on issue #2716: URL: https://github.com/apache/apisix/issues/2716#issuecomment-725861985 It seems that this problem has bothered many people,maybe you can see #2695 ,let‘s discuss together. This is an auto

[GitHub] [apisix] GBXing closed issue #2717: request help: how do I get etcd data in a custom plugin

2020-11-11 Thread GitBox
GBXing closed issue #2717: URL: https://github.com/apache/apisix/issues/2717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix] GBXing opened a new issue #2717: request help: how do I get etcd data in a custom plugin

2020-11-11 Thread GitBox
GBXing opened a new issue #2717: URL: https://github.com/apache/apisix/issues/2717 ### Issue description I save some configuration data to the ETCD, hoping to load the configuration data into local memory when I start Apisix, and then get the configuration data when I develop my

[GitHub] [apisix] yankunsam opened a new issue #2716: bug: apisix error logs

2020-11-11 Thread GitBox
yankunsam opened a new issue #2716: URL: https://github.com/apache/apisix/issues/2716 ### Issue description ![image](https://user-images.githubusercontent.com/16130147/98901652-20bd6980-24ef-11eb-9e1f-0668e6728a36.png) ### Environment * apisix version (cmd: `apisix vers

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #791: bug: setting proxy-cache plugin prompt error

2020-11-11 Thread GitBox
juzhiyuan commented on issue #791: URL: https://github.com/apache/apisix-dashboard/issues/791#issuecomment-725852993 Not sure what happened but still duplicate as other plugins that need to rebuild the schema so they could work with react-jsonschema-form. Just added the checking label.

[GitHub] [apisix-dashboard] idbeta opened a new issue #791: bug: setting proxy-cache plugin prompt error

2020-11-11 Thread GitBox
idbeta opened a new issue #791: URL: https://github.com/apache/apisix-dashboard/issues/791 - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance improvement - [ ] Other When setting the mandatory option `c

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #790: bug: when create a route with kafka-logge, the plugin's option is missing field.

2020-11-11 Thread GitBox
juzhiyuan commented on issue #790: URL: https://github.com/apache/apisix-dashboard/issues/790#issuecomment-725851686 Duplicate as most of other plugins, need some time to build the schema that could work with react-jsonschema-form. ---

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #748: CI: need a better name

2020-11-11 Thread GitBox
juzhiyuan commented on issue #748: URL: https://github.com/apache/apisix-dashboard/issues/748#issuecomment-725851197 Please update the Test Cli if possible. This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #787: makefile: for `make release-src`, it should release the source code

2020-11-11 Thread GitBox
juzhiyuan commented on issue #787: URL: https://github.com/apache/apisix-dashboard/issues/787#issuecomment-725850943 make-release is more semantic and clearer. This is an automated message from the Apache Git Service. To re

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #788: bug: dashboard2.0 ip-restriction plugin set blacklist, can not set ipv4 or ipv4/CIDR

2020-11-11 Thread GitBox
juzhiyuan commented on issue #788: URL: https://github.com/apache/apisix-dashboard/issues/788#issuecomment-725849889 This schema works in many ways, but it's not compatible with the react-jsonschema-form dependency now, we will try to reactor the schema first as usual. Only when we

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #788: bug: dashboard2.0 ip-restriction plugin set blacklist, can not set ipv4 or ipv4/CIDR

2020-11-11 Thread GitBox
juzhiyuan commented on issue #788: URL: https://github.com/apache/apisix-dashboard/issues/788#issuecomment-725850126 So just pending and need some time on checking if there has a working scheme. This is an automated messag

[GitHub] [apisix] nic-chen commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
nic-chen commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725849820 > > @souzens > > Thanks for feedback. > > but it works fine on my env using `etcd-3.4.13`. could you please provide more details ? thanks. > > @idbeta please help check. than

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #652: docker-compose up

2020-11-11 Thread GitBox
juzhiyuan commented on issue #652: URL: https://github.com/apache/apisix-dashboard/issues/652#issuecomment-725848012 Then is it working on your side now? If it is, kindly close this issue please:) This is an automated messa

[GitHub] [apisix] yankunsam opened a new issue #2715: request help: openid-connect plugin

2020-11-11 Thread GitBox
yankunsam opened a new issue #2715: URL: https://github.com/apache/apisix/issues/2715 ### Issue description what is the detail for discovery_url for openid-connect? ### Environment * apisix version (cmd: `apisix version`): * OS:

[GitHub] [apisix] spacewander commented on issue #2711: request help: plugins in global rules are prioritized over those in routes, regardless of priority

2020-11-11 Thread GitBox
spacewander commented on issue #2711: URL: https://github.com/apache/apisix/issues/2711#issuecomment-725842304 We can allow user to postpone the global rule, so that we can achieve this without breaking current behavior. For example: ``` global rule -> lcoal rule -> postponed glob

[GitHub] [apisix] spacewander commented on issue #2714: request help: When accessing APISIX route, there are two servers in the response header.

2020-11-11 Thread GitBox
spacewander commented on issue #2714: URL: https://github.com/apache/apisix/issues/2714#issuecomment-725840875 We can remove the upstream one. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [apisix] spacewander edited a comment on issue #2640: [DISCUSS] Only keep one Server header in HTTP response

2020-11-11 Thread GitBox
spacewander edited a comment on issue #2640: URL: https://github.com/apache/apisix/issues/2640#issuecomment-722921945 The adding header is only in the test scaffold. https://github.com/apache/apisix/blob/3ab580fa7150736735c7dec67f6a3f4d2987b597/t/APISIX.pm#L392 @membphis Do yo

[GitHub] [apisix-dashboard] idbeta opened a new issue #790: bug: when create a route with kafka-logge, the plugin's option is missing field.

2020-11-11 Thread GitBox
idbeta opened a new issue #790: URL: https://github.com/apache/apisix-dashboard/issues/790 - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance improvement - [ ] Other when create a route with kafka-logge

[GitHub] [apisix] souzens edited a comment on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
souzens edited a comment on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725833390 > @souzens > > Thanks for feedback. > > but it works fine on my env using `etcd-3.4.13`. could you please provide more details ? thanks. > > @idbeta please

[GitHub] [apisix] souzens commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
souzens commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725833390 > @souzens > > Thanks for feedback. > > but it works fine on my env using `etcd-3.4.13`. could you please provide more details ? thanks. > > @idbeta please help ch

[GitHub] [apisix] idbeta opened a new issue #2714: request help: When accessing APISIX route, there are two servers in the response header.

2020-11-11 Thread GitBox
idbeta opened a new issue #2714: URL: https://github.com/apache/apisix/issues/2714 ### Issue description When accessing APISIX route, there are two servers in the response header, one of which is upstream, can it be distinguished by different fields? ```shell $ curl http://127

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725829212 > > > @ziyou434 Could you provides the options that used for etcd start. > > > > > > I use bitnami/etcd chart ,and --set auth.rbac.enabled=false. > > The chart use setup.

[GitHub] [apisix-dashboard] nic-chen commented on issue #783: 上游节点分组节点主机权重配置为0时,dashboard进行路由配置时,选后节点分组,报undefined

2020-11-11 Thread GitBox
nic-chen commented on issue #783: URL: https://github.com/apache/apisix-dashboard/issues/783#issuecomment-725826047 > I reproduce this bug in [demo page](http://139.217.190.60/routes/328072574489592268/edit). When the upstream nodes weight is 0, the API has no weight value. @nic-chen Plea

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2696: chore: sort the request headers output by the _M.uri and _M.old_uri function in t/lib/server.lua

2020-11-11 Thread GitBox
Firstsawyou commented on a change in pull request #2696: URL: https://github.com/apache/apisix/pull/2696#discussion_r521828845 ## File path: t/plugin/hmac-auth.t ## @@ -1246,16 +1246,16 @@ location /t { GET /t --- response_body uri: /uri -host: 127.0.0.1 +content-length: 52

[GitHub] [apisix] fregie opened a new issue #2713: request help: How to turn off access log?

2020-11-11 Thread GitBox
fregie opened a new issue #2713: URL: https://github.com/apache/apisix/issues/2713 ### Issue description My apisix run in docker and It's may be dangerous if access.log keep logging. I want to turn off the access log. T

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725813782 > > @ziyou434 Could you provides the options that used for etcd start. > > I use bitnami/etcd chart ,and --set auth.rbac.enabled=false. > The chart use setup.sh to start etcd

[GitHub] [apisix] nic-chen commented on a change in pull request #2696: chore: sort the request headers output by the _M.uri and _M.old_uri function in t/lib/server.lua

2020-11-11 Thread GitBox
nic-chen commented on a change in pull request #2696: URL: https://github.com/apache/apisix/pull/2696#discussion_r521816482 ## File path: t/plugin/hmac-auth.t ## @@ -1246,16 +1246,16 @@ location /t { GET /t --- response_body uri: /uri -host: 127.0.0.1 +content-length: 52 co

[GitHub] [apisix] ziyou434 edited a comment on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 edited a comment on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223 > @ziyou434 Could you provides the options that used for etcd start. I use bitnami/etcd chart ,and --set auth.rbac.enabled=false. The chart use setup.sh to start etcd

[GitHub] [apisix-dashboard] tokers edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725801467 > > What is the divergent-change? > > It means implement a feature cause multiple component changes.Oh, sorry for using a wrong word, what I want to say is `shotg

[GitHub] [apisix] ziyou434 edited a comment on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 edited a comment on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223 > @ziyou434 Could you provides the options that used for etcd start. I use bitnami/etcd chart ,and --set auth.rbac.enabled=false. The chart use setup.sh start etcd

[GitHub] [apisix] nic-chen commented on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
nic-chen commented on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725804599 > > > > I think the main logic should be: > > > > When APISIX starts, read the key `/apisix/jsonschema` of ETCD. > > > > If the key does not exist or is empty, then read the JSON

[GitHub] [apisix] ziyou434 edited a comment on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 edited a comment on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223 > @ziyou434 Could you provides the options that used for etcd start. I use bitnami/etcd chart ,and --set auth.rbac.enabled=false. The chart use setup.sh start etcd

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223 > @ziyou434 Could you provides the options that used for etcd start. I use bitnami/etcd chart ,and --set auth.rbac.enabled=false. The chart use setup.sh start etcd se

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725802291 @ziyou434 Could you provides the options that used for etcd start. This is an automated message from the Apache Git Ser

[GitHub] [apisix] ziyou434 edited a comment on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 edited a comment on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725801889 > > I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9 report errors > > Thanks for feedback. > > Could you provide the steps and config det

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725801889 > > I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9 report errors > > Thanks for feedback. > > Could you provide the steps and config details ?

[GitHub] [apisix-dashboard] tokers commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725801467 > > What is the divergent-change? > > It means implement a feature cause multiple component changes.Oh, sorry for using a wrong word, what I want to say is `shotgun-surg

[GitHub] [apisix] nic-chen commented on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
nic-chen commented on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725801183 > Is it necessary to automatically trigger schema synchronization when adding a new schema(e.g: add a new plugin) or modifying a schema, so that the consumer of the schema (e.g manag

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
ShiningRush edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327 > What is the divergent-change? It means implement a feature cause multiple component changes.Oh, sorry for using a wrong word, what I want to say is `shotgu

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
ShiningRush edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327 > What is the divergent-change? It means implement a feature cause multiple component changes.Oh, sorry for using a wrong word, what I want to say is `shotgu

[GitHub] [apisix] tokers commented on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
tokers commented on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725797834 > > > I think the main logic should be: > > > When APISIX starts, read the key `/apisix/jsonschema` of ETCD. > > > If the key does not exist or is empty, then read the JSON schema

[GitHub] [apisix] nic-chen commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
nic-chen commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725797587 > I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9 report errors Thanks for feedback. Could you provide the steps and config details ? thanks.

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
ShiningRush edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327 > What is the divergent-change? It means implement a feature cause multiple component changes. > it's totally OK to fallback this two methods to norma

[GitHub] [apisix-dashboard] ShiningRush commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
ShiningRush commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327 > What is the divergent-change? It means implement some features cause multiple component changes. > it's totally OK to fallback this two methods to normal Updat

[GitHub] [apisix] spacewander commented on issue #2709: bug: limit-count throws error casually in apisix 2.0

2020-11-11 Thread GitBox
spacewander commented on issue #2709: URL: https://github.com/apache/apisix/issues/2709#issuecomment-725795245 I think your issue is fixed. See https://github.com/apache/apisix/pull/2575/files#r52178 about why it is fixed. Feel free to reopen it if you still reproduce the issue with

[GitHub] [apisix] spacewander closed issue #2709: bug: limit-count throws error casually in apisix 2.0

2020-11-11 Thread GitBox
spacewander closed issue #2709: URL: https://github.com/apache/apisix/issues/2709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] ziyou434 commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-11 Thread GitBox
ziyou434 commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-725794810 I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9 report errors This is an automated message

[GitHub] [apisix] spacewander commented on a change in pull request #2575: change: make lrucache lock optional

2020-11-11 Thread GitBox
spacewander commented on a change in pull request #2575: URL: https://github.com/apache/apisix/pull/2575#discussion_r52178 ## File path: apisix/core/lrucache.lua ## @@ -125,42 +139,37 @@ end global_lru_fun = new_lru_fun() -local function _plugin(plugin_name, key, versi

[GitHub] [apisix] nic-chen commented on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
nic-chen commented on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725795019 > > I think the main logic should be: > > When APISIX starts, read the key `/apisix/jsonschema` of ETCD. > > If the key does not exist or is empty, then read the JSON schema from

[GitHub] [apisix-dashboard] tokers edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223 > > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. > > got it >

[GitHub] [apisix-dashboard] tokers edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223 > > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. > > got it >

[GitHub] [apisix-dashboard] tokers edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223 > > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. > > got it >

[GitHub] [apisix-dashboard] tokers edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223 > > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. > > got it >

[GitHub] [apisix-dashboard] tokers commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
tokers commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223 > > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. > > got it > > > T

[GitHub] [apisix] spacewander commented on issue #2709: bug: limit-count throws error casually in apisix 2.0

2020-11-11 Thread GitBox
spacewander commented on issue #2709: URL: https://github.com/apache/apisix/issues/2709#issuecomment-725790758 > > > > And have you tried the master branch? The lru cache is changed after 2.0 and some issues are addressed. Not sure if your problem is solved. > > What are thos

[GitHub] [apisix] liuxiran edited a comment on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
liuxiran edited a comment on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725787331 Is it necessary to automatically trigger schema synchronization when adding a new schema(e.g: add a new plugin) or modifying a schema, so that the consumer of the schema (e.g

[GitHub] [apisix] liuxiran edited a comment on issue #2082: request help: Update plugin's schema

2020-11-11 Thread GitBox
liuxiran edited a comment on issue #2082: URL: https://github.com/apache/apisix/issues/2082#issuecomment-724502301 - [x] key-auth This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] ShiningRush commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
ShiningRush commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725789436 > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. got it > The *r

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-11-11 Thread GitBox
ShiningRush edited a comment on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725789436 > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16 for the details. It was the etcd revision that the key was created. got it >

[GitHub] [apisix] JanLi-air commented on issue #2709: bug: limit-count throws error casually in apisix 2.0

2020-11-11 Thread GitBox
JanLi-air commented on issue #2709: URL: https://github.com/apache/apisix/issues/2709#issuecomment-725788987 > And have you tried the master branch? The lru cache is changed after 2.0 and some issues are addressed. Not sure if your problem is solved. What are those issues? Can you sh

[GitHub] [apisix] JanLi-air commented on issue #2709: bug: limit-count throws error casually in apisix 2.0

2020-11-11 Thread GitBox
JanLi-air commented on issue #2709: URL: https://github.com/apache/apisix/issues/2709#issuecomment-725787523 this is what I got, what is this value `lim:ver 2935`? This is an automated message from the Apache Git Service. To

[GitHub] [apisix] liuxiran commented on issue #2700: feat: use etcd to store the JSON schema of APISIX, then the manager API can read it from etcd

2020-11-11 Thread GitBox
liuxiran commented on issue #2700: URL: https://github.com/apache/apisix/issues/2700#issuecomment-725787331 Is it necessary to automatically trigger schema synchronization when adding a new schema(e.g: add a new plugin) or modifying a schema, so that the consumer of the schema (e.g manager

[GitHub] [apisix] JanLi-air edited a comment on issue #2709: bug: limit-count throws error casually in apisix 2.0

2020-11-11 Thread GitBox
JanLi-air edited a comment on issue #2709: URL: https://github.com/apache/apisix/issues/2709#issuecomment-725786739 ``` 2020/11/12 02:21:31 [error] 126#126: *3929332 [lua] limit-count.lua:169: phase_func(): lim:ver 2935, client: 172.16.128.215, server: , request: "GET /apisix/prometheus

  1   2   3   >