idbeta commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725901464
> @souzens
>
> Thanks for feedback.
>
> but it works fine on my env using `etcd-3.4.13`. could you please provide
more details ? thanks.
>
> @idbeta please help che
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725900813
OK, i will try to reproduce it in my minikube.
This is an automated message from the Apache Git Service.
To respond to
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725900114
> @ ziyou434 @souzens @yankunsam那么,你们所有人都在Kubernetes中部署APISIX和etcd吗?
yes,required by my company.
This is an au
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725899535
@ziyou434 @souzens @yankunsam So all of you deploy APISIX and etcd in
Kubernetes?
This is an automated message from th
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725899169
> > > That's strange, Could you use `tcpdump` in your environment, let's
capture some HTTP packets between APISIX and the etcd to see whether the body
is abnormal.
> >
> >
>
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725896389
> > That's strange, Could you use `tcpdump` in your environment, let's
capture some HTTP packets between APISIX and the etcd to see whether the body
is abnormal.
>
> @ziyou434
souzens commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725896048
```
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional
Gary-Airwallex commented on issue #2711:
URL: https://github.com/apache/apisix/issues/2711#issuecomment-725894084
TBH that still sounds counter intuitive to me. How about merging plugins
from global rules with plugins from routes/services? We could mark global-rule
plugins (e.g. with a pre
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725891419
> > That's strange, Could you use `tcpdump` in your environment, let's
capture some HTTP packets between APISIX and the etcd to see whether the body
is abnormal.
>
> @ziyou434
yankunsam commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725891388
> > how to tell apisix the password of etcd?
>
> See https://github.com/apache/apisix/blob/master/conf/config-default.yaml
for the details.
As the guide document, I set
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725890628
> That's strange, Could you use `tcpdump` in your environment, let's capture
some HTTP packets between APISIX and the etcd to see whether the body is
abnormal.
@ziyou434 Could y
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725890392
I find etcdctl get /apisix/services will return null,exist but
null。/apisix/routes... is the same.
I guess maybe errors occured in admin_init, but i haven't found.
-
idbeta opened a new issue #792:
URL: https://github.com/apache/apisix-dashboard/issues/792
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
The headers option will automaticall
backnero commented on issue #2678:
URL: https://github.com/apache/apisix/issues/2678#issuecomment-725888505
I upgraded from 1.4.1 to version 1.5, so it is etcd api V2. When I use
```
etcdctl ls /apisix
```
 to
execute, err is auth: user name is empty
2020-11-12 06:44:28.061760 W | etcdserver: failed
ziyou434 edited a comment on issue #2692:
URL: https://github.com/apache/apisix/issues/2692#issuecomment-725876907
> yes,need to add dns_resolver in config.yaml
I want to instruct dns_reslover what kind of role does it play in the
interaction between apisix and etcd, and why it is se
spacewander commented on issue #2715:
URL: https://github.com/apache/apisix/issues/2715#issuecomment-725876363
You can take a look as this article:
https://swagger.io/docs/specification/authentication/openid-connect-discovery/
--
yankunsam commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725875983
how to tell apisix the password of etcd?
This is an automated message from the Apache Git Service.
To respond to the
spacewander closed issue #2716:
URL: https://github.com/apache/apisix/issues/2716
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725875467
That's strange, Could you use `tcpdump` in your environment, let's capture
some HTTP packets between APISIX and the etcd to see whether the body is
abnormal.
spacewander commented on issue #2716:
URL: https://github.com/apache/apisix/issues/2716#issuecomment-725875169
Should be solved by https://github.com/api7/lua-resty-etcd/pull/92/files
This is an automated message from the Apa
spacewander commented on issue #2717:
URL: https://github.com/apache/apisix/issues/2717#issuecomment-725874818
You can take a look at plugin-metadata API:
https://github.com/apache/apisix/blob/master/doc/admin-api.md#plugin-metadata
and its relative code.
krufyliu commented on issue #2716:
URL: https://github.com/apache/apisix/issues/2716#issuecomment-725874462
@yankunsam what's your etcd address? i meet the same problem.
if your etcd address has special character such as '-', the problem occurs.
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 2ba28ff chore: sort the request headers ou
spacewander merged pull request #2696:
URL: https://github.com/apache/apisix/pull/2696
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #2636:
URL: https://github.com/apache/apisix/issues/2636
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
yankunsam commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725869963
> by test just now, apisix2.0 will report error above when run wtih
etcd-3.4.13
> instead of etcd3.4.9 run ok
docker.io/bitnami/etcd:3.4.9-debian-10-r34? The same errors.
juzhiyuan commented on a change in pull request #785:
URL: https://github.com/apache/apisix-dashboard/pull/785#discussion_r521867296
##
File path: docs/deploy-with-docker.zh-CN.md
##
@@ -17,44 +17,65 @@
#
-->
-# 使用 Docker 部署
+# 使用 Docker 构建并启动
-1. 构建镜像
+使用 Docker 构建 Dashb
Firstsawyou commented on issue #2718:
URL: https://github.com/apache/apisix/issues/2718#issuecomment-725869358
I agree with you. I have also encountered such a situation, this prompt
message is not clear.
This is an automate
membphis commented on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725865814
JSON Schema version is a useful field, we need to store and compare it.
Needs to show a warning message if the JSON schema version is different from
APISIX version.
-
gxthrj commented on a change in pull request #785:
URL: https://github.com/apache/apisix-dashboard/pull/785#discussion_r521863418
##
File path: docs/deploy-with-docker.zh-CN.md
##
@@ -17,44 +17,65 @@
#
-->
-# 使用 Docker 部署
+# 使用 Docker 构建并启动
-1. 构建镜像
+使用 Docker 构建 Dashboar
Firstsawyou opened a new issue #2719:
URL: https://github.com/apache/apisix/issues/2719
### Issue description
In the `apisix/doc/zh-cn/plugins/kafka-logger.md` file, the descriptions of
the `key` and `timeout` fields in the attribute directory are inconsistent. We
need to adjust:
h
tokers opened a new issue #2718:
URL: https://github.com/apache/apisix/issues/2718
When the etcd initialization fails, the output error message:
```
got malformed version message: "" from etcd
```
Which is ambiguous, i think the error details should be exposed. What do yo
ziyou434 commented on issue #2716:
URL: https://github.com/apache/apisix/issues/2716#issuecomment-725861985
It seems that this problem has bothered many people,maybe you can see #2695
,let‘s discuss together.
This is an auto
GBXing closed issue #2717:
URL: https://github.com/apache/apisix/issues/2717
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
GBXing opened a new issue #2717:
URL: https://github.com/apache/apisix/issues/2717
### Issue description
I save some configuration data to the ETCD, hoping to load the
configuration data into local memory when I start Apisix, and then get the
configuration data when I develop my
yankunsam opened a new issue #2716:
URL: https://github.com/apache/apisix/issues/2716
### Issue description

### Environment
* apisix version (cmd: `apisix vers
juzhiyuan commented on issue #791:
URL:
https://github.com/apache/apisix-dashboard/issues/791#issuecomment-725852993
Not sure what happened but still duplicate as other plugins that need to
rebuild the schema so they could work with react-jsonschema-form. Just added
the checking label.
idbeta opened a new issue #791:
URL: https://github.com/apache/apisix-dashboard/issues/791
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
When setting the mandatory option `c
juzhiyuan commented on issue #790:
URL:
https://github.com/apache/apisix-dashboard/issues/790#issuecomment-725851686
Duplicate as most of other plugins, need some time to build the schema that
could work with react-jsonschema-form.
---
juzhiyuan commented on issue #748:
URL:
https://github.com/apache/apisix-dashboard/issues/748#issuecomment-725851197
Please update the Test Cli if possible.
This is an automated message from the Apache Git Service.
To respon
juzhiyuan commented on issue #787:
URL:
https://github.com/apache/apisix-dashboard/issues/787#issuecomment-725850943
make-release is more semantic and clearer.
This is an automated message from the Apache Git Service.
To re
juzhiyuan commented on issue #788:
URL:
https://github.com/apache/apisix-dashboard/issues/788#issuecomment-725849889
This schema works in many ways, but it's not compatible with the
react-jsonschema-form dependency now, we will try to reactor the schema first
as usual.
Only when we
juzhiyuan commented on issue #788:
URL:
https://github.com/apache/apisix-dashboard/issues/788#issuecomment-725850126
So just pending and need some time on checking if there has a working
scheme.
This is an automated messag
nic-chen commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725849820
> > @souzens
> > Thanks for feedback.
> > but it works fine on my env using `etcd-3.4.13`. could you please
provide more details ? thanks.
> > @idbeta please help check. than
juzhiyuan commented on issue #652:
URL:
https://github.com/apache/apisix-dashboard/issues/652#issuecomment-725848012
Then is it working on your side now? If it is, kindly close this issue
please:)
This is an automated messa
yankunsam opened a new issue #2715:
URL: https://github.com/apache/apisix/issues/2715
### Issue description
what is the detail for discovery_url for openid-connect?
### Environment
* apisix version (cmd: `apisix version`):
* OS:
spacewander commented on issue #2711:
URL: https://github.com/apache/apisix/issues/2711#issuecomment-725842304
We can allow user to postpone the global rule, so that we can achieve this
without breaking current behavior. For example:
```
global rule -> lcoal rule -> postponed glob
spacewander commented on issue #2714:
URL: https://github.com/apache/apisix/issues/2714#issuecomment-725840875
We can remove the upstream one.
This is an automated message from the Apache Git Service.
To respond to the messag
spacewander edited a comment on issue #2640:
URL: https://github.com/apache/apisix/issues/2640#issuecomment-722921945
The adding header is only in the test scaffold.
https://github.com/apache/apisix/blob/3ab580fa7150736735c7dec67f6a3f4d2987b597/t/APISIX.pm#L392
@membphis
Do yo
idbeta opened a new issue #790:
URL: https://github.com/apache/apisix-dashboard/issues/790
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
when create a route with kafka-logge
souzens edited a comment on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725833390
> @souzens
>
> Thanks for feedback.
>
> but it works fine on my env using `etcd-3.4.13`. could you please provide
more details ? thanks.
>
> @idbeta please
souzens commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725833390
> @souzens
>
> Thanks for feedback.
>
> but it works fine on my env using `etcd-3.4.13`. could you please provide
more details ? thanks.
>
> @idbeta please help ch
idbeta opened a new issue #2714:
URL: https://github.com/apache/apisix/issues/2714
### Issue description
When accessing APISIX route, there are two servers in the response header,
one of which is upstream, can it be distinguished by different fields?
```shell
$ curl http://127
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725829212
> > > @ziyou434 Could you provides the options that used for etcd start.
> >
> >
> > I use bitnami/etcd chart ,and --set auth.rbac.enabled=false.
> > The chart use setup.
nic-chen commented on issue #783:
URL:
https://github.com/apache/apisix-dashboard/issues/783#issuecomment-725826047
> I reproduce this bug in [demo
page](http://139.217.190.60/routes/328072574489592268/edit). When the upstream
nodes weight is 0, the API has no weight value. @nic-chen Plea
Firstsawyou commented on a change in pull request #2696:
URL: https://github.com/apache/apisix/pull/2696#discussion_r521828845
##
File path: t/plugin/hmac-auth.t
##
@@ -1246,16 +1246,16 @@ location /t {
GET /t
--- response_body
uri: /uri
-host: 127.0.0.1
+content-length: 52
fregie opened a new issue #2713:
URL: https://github.com/apache/apisix/issues/2713
### Issue description
My apisix run in docker and It's may be dangerous if access.log keep logging.
I want to turn off the access log.
T
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725813782
> > @ziyou434 Could you provides the options that used for etcd start.
>
> I use bitnami/etcd chart ,and --set auth.rbac.enabled=false.
> The chart use setup.sh to start etcd
nic-chen commented on a change in pull request #2696:
URL: https://github.com/apache/apisix/pull/2696#discussion_r521816482
##
File path: t/plugin/hmac-auth.t
##
@@ -1246,16 +1246,16 @@ location /t {
GET /t
--- response_body
uri: /uri
-host: 127.0.0.1
+content-length: 52
co
ziyou434 edited a comment on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223
> @ziyou434 Could you provides the options that used for etcd start.
I use bitnami/etcd chart ,and --set auth.rbac.enabled=false.
The chart use setup.sh to start etcd
tokers edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725801467
> > What is the divergent-change?
>
> It means implement a feature cause multiple component changes.Oh, sorry
for using a wrong word, what I want to say is `shotg
ziyou434 edited a comment on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223
> @ziyou434 Could you provides the options that used for etcd start.
I use bitnami/etcd chart ,and --set auth.rbac.enabled=false.
The chart use setup.sh start etcd
nic-chen commented on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725804599
> > > > I think the main logic should be:
> > > > When APISIX starts, read the key `/apisix/jsonschema` of ETCD.
> > > > If the key does not exist or is empty, then read the JSON
ziyou434 edited a comment on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223
> @ziyou434 Could you provides the options that used for etcd start.
I use bitnami/etcd chart ,and --set auth.rbac.enabled=false.
The chart use setup.sh start etcd
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725804223
> @ziyou434 Could you provides the options that used for etcd start.
I use bitnami/etcd chart ,and --set auth.rbac.enabled=false.
The chart use setup.sh start etcd
se
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725802291
@ziyou434 Could you provides the options that used for etcd start.
This is an automated message from the Apache Git Ser
ziyou434 edited a comment on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725801889
> > I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9
report errors
>
> Thanks for feedback.
>
> Could you provide the steps and config det
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725801889
> > I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9
report errors
>
> Thanks for feedback.
>
> Could you provide the steps and config details ?
tokers commented on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725801467
> > What is the divergent-change?
>
> It means implement a feature cause multiple component changes.Oh, sorry
for using a wrong word, what I want to say is `shotgun-surg
nic-chen commented on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725801183
> Is it necessary to automatically trigger schema synchronization when
adding a new schema(e.g: add a new plugin) or modifying a schema, so that the
consumer of the schema (e.g manag
ShiningRush edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327
> What is the divergent-change?
It means implement a feature cause multiple component changes.Oh, sorry for
using a wrong word, what I want to say is `shotgu
ShiningRush edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327
> What is the divergent-change?
It means implement a feature cause multiple component changes.Oh, sorry for
using a wrong word, what I want to say is `shotgu
tokers commented on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725797834
> > > I think the main logic should be:
> > > When APISIX starts, read the key `/apisix/jsonschema` of ETCD.
> > > If the key does not exist or is empty, then read the JSON schema
nic-chen commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725797587
> I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9
report errors
Thanks for feedback.
Could you provide the steps and config details ? thanks.
ShiningRush edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327
> What is the divergent-change?
It means implement a feature cause multiple component changes.
> it's totally OK to fallback this two methods to norma
ShiningRush commented on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725796327
> What is the divergent-change?
It means implement some features cause multiple component changes.
> it's totally OK to fallback this two methods to normal Updat
spacewander commented on issue #2709:
URL: https://github.com/apache/apisix/issues/2709#issuecomment-725795245
I think your issue is fixed. See
https://github.com/apache/apisix/pull/2575/files#r52178 about why it is
fixed.
Feel free to reopen it if you still reproduce the issue with
spacewander closed issue #2709:
URL: https://github.com/apache/apisix/issues/2709
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ziyou434 commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-725794810
I also have this problem, and both versions of etcd3.4.13 and etcd 3.4.9
report errors
This is an automated message
spacewander commented on a change in pull request #2575:
URL: https://github.com/apache/apisix/pull/2575#discussion_r52178
##
File path: apisix/core/lrucache.lua
##
@@ -125,42 +139,37 @@ end
global_lru_fun = new_lru_fun()
-local function _plugin(plugin_name, key, versi
nic-chen commented on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725795019
> > I think the main logic should be:
> > When APISIX starts, read the key `/apisix/jsonschema` of ETCD.
> > If the key does not exist or is empty, then read the JSON schema from
tokers edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223
> > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
>
> got it
>
tokers edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223
> > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
>
> got it
>
tokers edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223
> > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
>
> got it
>
tokers edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223
> > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
>
> got it
>
tokers commented on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725792223
> > See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
>
> got it
>
> > T
spacewander commented on issue #2709:
URL: https://github.com/apache/apisix/issues/2709#issuecomment-725790758
>
>
> > And have you tried the master branch? The lru cache is changed after 2.0
and some issues are addressed. Not sure if your problem is solved.
>
> What are thos
liuxiran edited a comment on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725787331
Is it necessary to automatically trigger schema synchronization when adding
a new schema(e.g: add a new plugin) or modifying a schema, so that the consumer
of the schema (e.g
liuxiran edited a comment on issue #2082:
URL: https://github.com/apache/apisix/issues/2082#issuecomment-724502301
- [x] key-auth
This is an automated message from the Apache Git Service.
To respond to the message, please log
ShiningRush commented on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725789436
> See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
got it
> The *r
ShiningRush edited a comment on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-725789436
> See https://github.com/etcd-io/etcd/blob/master/api/mvccpb/kv.proto#L16
for the details. It was the etcd revision that the key was created.
got it
>
JanLi-air commented on issue #2709:
URL: https://github.com/apache/apisix/issues/2709#issuecomment-725788987
> And have you tried the master branch? The lru cache is changed after 2.0
and some issues are addressed. Not sure if your problem is solved.
What are those issues? Can you sh
JanLi-air commented on issue #2709:
URL: https://github.com/apache/apisix/issues/2709#issuecomment-725787523
this is what I got, what is this value `lim:ver 2935`?
This is an automated message from the Apache Git Service.
To
liuxiran commented on issue #2700:
URL: https://github.com/apache/apisix/issues/2700#issuecomment-725787331
Is it necessary to automatically trigger schema synchronization when adding
a new schema(e.g: add a new plugin) or modifying a schema, so that the consumer
of the schema (e.g manager
JanLi-air edited a comment on issue #2709:
URL: https://github.com/apache/apisix/issues/2709#issuecomment-725786739
```
2020/11/12 02:21:31 [error] 126#126: *3929332 [lua] limit-count.lua:169:
phase_func(): lim:ver 2935, client: 172.16.128.215, server: , request: "GET
/apisix/prometheus
1 - 100 of 216 matches
Mail list logo