[GitHub] [apisix-dashboard] LiteSun opened a new issue #821: Proposal: Monitor Routes

2020-11-17 Thread GitBox
LiteSun opened a new issue #821: URL: https://github.com/apache/apisix-dashboard/issues/821 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirements - [x] Feature or performance

[GitHub] [apisix-dashboard] LiteSun commented on issue #611: Proposal: Full lifecycle API management

2020-11-17 Thread GitBox
LiteSun commented on issue #611: URL: https://github.com/apache/apisix-dashboard/issues/611#issuecomment-729502416 Additional feature to discuss: 1. Monitor Routes 2. Alarm Mechanism 3. Version management of route Technical details will be discussed in the corresponding

[GitHub] [apisix] membphis commented on issue #2782: plugin(prometheus): incorrect http status name

2020-11-17 Thread GitBox
membphis commented on issue #2782: URL: https://github.com/apache/apisix/issues/2782#issuecomment-729502291 @idbeta do you have time to confirm if this is a bug, many thx This is an automated message from the Apache Git

[GitHub] [apisix] membphis opened a new issue #2782: plugin(prometheus): incorrect http status name

2020-11-17 Thread GitBox
membphis opened a new issue #2782: URL: https://github.com/apache/apisix/issues/2782 ![image](https://user-images.githubusercontent.com/6814606/99500783-ca03d400-29b5-11eb-8545-f541a9b9b7f8.png) This is an automated

[GitHub] [apisix] lilihongjava opened a new issue #2781: https plugins:curl: (60) Peer's certificate issuer has been marked as not trusted by the user.

2020-11-17 Thread GitBox
lilihongjava opened a new issue #2781: URL: https://github.com/apache/apisix/issues/2781 ### Issue description Operation steps: 1. openssl genrsa -out private.pem 2048 2. openssl req -new -x509 -key private.pem -out cacert.pem -days 1095 3. cat /home/cert/cacert.pem >>

[GitHub] [apisix-dashboard] membphis commented on issue #782: 能否增加配置导入导出的功能,用于升级或多数据中心的apisix之间进行迁移

2020-11-17 Thread GitBox
membphis commented on issue #782: URL: https://github.com/apache/apisix-dashboard/issues/782#issuecomment-729478555 This is the function we plan to do, and it is very useful for business users. Do you have any thoughts on this feature?

[GitHub] [apisix] spacewander edited a comment on issue #2779: doc: enable_websocket's location is not correct

2020-11-17 Thread GitBox
spacewander edited a comment on issue #2779: URL: https://github.com/apache/apisix/issues/2779#issuecomment-729477284 See https://github.com/apache/apisix/pull/2691/files We already removed it from the doc. This is an

[GitHub] [apisix] spacewander commented on issue #2779: doc: enable_websocket's location is not correct

2020-11-17 Thread GitBox
spacewander commented on issue #2779: URL: https://github.com/apache/apisix/issues/2779#issuecomment-729477284 See https://github.com/apache/apisix/pull/2691/files This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander opened a new pull request #2780: fix(http-logger): correct the Content-Type of newline format log report

2020-11-17 Thread GitBox
spacewander opened a new pull request #2780: URL: https://github.com/apache/apisix/pull/2780 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [x]

[GitHub] [apisix] starsz opened a new issue #2779: doc: enable_websocket's location is not correct

2020-11-17 Thread GitBox
starsz opened a new issue #2779: URL: https://github.com/apache/apisix/issues/2779 Hi. I found that `enable_websocket` had moved to the `upstream` location. So the doc https://github.com/apache/apisix/blob/master/doc/admin-api.md needs to update. Chinese document as well.

[GitHub] [apisix-dashboard] membphis commented on issue #784: bug: when created route by adminAPI, "method" can be null value which dashboard can not identify

2020-11-17 Thread GitBox
membphis commented on issue #784: URL: https://github.com/apache/apisix-dashboard/issues/784#issuecomment-729473561 for `method`, I think the Admin API's logic is fine. 1. no `method`: means any method. 2. has `method`: limit with listed method. It is the same as other

[GitHub] [apisix] nic-chen commented on issue #2110: request help: move `conf/cert` to `t/cert`

2020-11-17 Thread GitBox
nic-chen commented on issue #2110: URL: https://github.com/apache/apisix/issues/2110#issuecomment-729466382 > And there is another problem. I'm not sure the usage and difference between `apisix_admin_ssl.crt` and `apisix.crt`, but currently `apisix_admin_ssl.crt` could be customized in

[GitHub] [apisix-dashboard] nic-chen commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
nic-chen commented on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729464730 > @nic-chen please confirm that is a bug of Manager-API. if yes, we need to update the label updated

[GitHub] [apisix] spacewander closed issue #2613: request help: If the fusing interval of apisix depends on the setttings of upstream.checks.active.healthy.interval

2020-11-17 Thread GitBox
spacewander closed issue #2613: URL: https://github.com/apache/apisix/issues/2613 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #2613: request help: If the fusing interval of apisix depends on the setttings of upstream.checks.active.healthy.interval

2020-11-17 Thread GitBox
spacewander commented on issue #2613: URL: https://github.com/apache/apisix/issues/2613#issuecomment-729464561 Consider solved. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander commented on issue #2171: bug: test case: route-domain-with-local-dns.t is unstable

2020-11-17 Thread GitBox
spacewander commented on issue #2171: URL: https://github.com/apache/apisix/issues/2171#issuecomment-729464188 Should be solved now. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] spacewander closed issue #2171: bug: test case: route-domain-with-local-dns.t is unstable

2020-11-17 Thread GitBox
spacewander closed issue #2171: URL: https://github.com/apache/apisix/issues/2171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #2379: missing doc for plugin `node-status`

2020-11-17 Thread GitBox
spacewander commented on issue #2379: URL: https://github.com/apache/apisix/issues/2379#issuecomment-729463876 Solved. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] spacewander closed issue #2379: missing doc for plugin `node-status`

2020-11-17 Thread GitBox
spacewander closed issue #2379: URL: https://github.com/apache/apisix/issues/2379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander closed issue #2640: [DISCUSS] Only keep one Server header in HTTP response

2020-11-17 Thread GitBox
spacewander closed issue #2640: URL: https://github.com/apache/apisix/issues/2640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #2640: [DISCUSS] Only keep one Server header in HTTP response

2020-11-17 Thread GitBox
spacewander commented on issue #2640: URL: https://github.com/apache/apisix/issues/2640#issuecomment-729463518 Solved. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta edited a comment on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399 @juzhiyuan there two apis in this case click edit ``` Request URL: http://127.0.0.1:8080/apisix/admin/routes/1

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta edited a comment on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399 @juzhiyuan there two api in this case click edit ``` Request URL: http://127.0.0.1:8080/apisix/admin/routes/1

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta edited a comment on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399 @juzhiyuan there two api in this case click edit ``` http://127.0.0.1:8080/apisix/admin/routes/1

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta edited a comment on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399 @juzhiyuan ``` Request URL: http://127.0.0.1:8080/apisix/admin/upstreams

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta edited a comment on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399 @juzhiyuan ``` Request URL: http://127.0.0.1:8080/apisix/admin/upstreams ``` ```

[GitHub] [apisix-dashboard] idbeta commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta commented on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729456399 @juzhiyuan ``` Request URL: http://127.0.0.1:8080/apisix/admin/upstreams ``` ```

[GitHub] [apisix] odidev commented on issue #1887: Linux jobs in Travis-CI

2020-11-17 Thread GitBox
odidev commented on issue #1887: URL: https://github.com/apache/apisix/issues/1887#issuecomment-729454764 @moonming I am currently not looking into this activity as this project is moved to Github-actions. This is an

[GitHub] [apisix-dashboard] idbeta commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
idbeta commented on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729454603 > I mean could @idbeta please check and paste the response from that page here? > > [#786

[GitHub] [apisix] gy09535 commented on a change in pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
gy09535 commented on a change in pull request #2727: URL: https://github.com/apache/apisix/pull/2727#discussion_r525832876 ## File path: apisix/plugins/zipkin/reporter.lua ## @@ -105,38 +104,68 @@ function _M.report(self, span) annotations = span.logs } -

[GitHub] [apisix] gy09535 edited a comment on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
gy09535 edited a comment on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-729452331 For code style should we have some tools such vs code format config? This is an automated message from

[GitHub] [apisix] gy09535 commented on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
gy09535 commented on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-729452331 For code style should we has some tools such vs code format config? This is an automated message from the Apache

[GitHub] [apisix] gy09535 commented on pull request #2177: feat: Support plugin for "aliyun" log service

2020-11-17 Thread GitBox
gy09535 commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-729451324 Please review CC @moonming This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] gy09535 commented on a change in pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
gy09535 commented on a change in pull request #2727: URL: https://github.com/apache/apisix/pull/2727#discussion_r525832876 ## File path: apisix/plugins/zipkin/reporter.lua ## @@ -105,38 +104,68 @@ function _M.report(self, span) annotations = span.logs } -

[GitHub] [apisix] gy09535 commented on a change in pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
gy09535 commented on a change in pull request #2727: URL: https://github.com/apache/apisix/pull/2727#discussion_r525832876 ## File path: apisix/plugins/zipkin/reporter.lua ## @@ -105,38 +104,68 @@ function _M.report(self, span) annotations = span.logs } -

[GitHub] [apisix-dashboard] membphis commented on issue #786: bug: when created route by adminAPI, "upstream" can not be modify by dashboard

2020-11-17 Thread GitBox
membphis commented on issue #786: URL: https://github.com/apache/apisix-dashboard/issues/786#issuecomment-729448689 @nic-chen please confirm that is a bug of Manager-API. if yes, we need to update the label This is an

[GitHub] [apisix] Applenice commented on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
Applenice commented on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729448487 > @Applenice Could you introduce your demands why these headers shouldn't be passed? I think it should be configurable, and not all upstream need or care about this

[GitHub] [apisix-dashboard] moonming commented on issue #820: [DRAFT] Support global plugin

2020-11-17 Thread GitBox
moonming commented on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-729447848 We need to list the plug-in as an object separately, at this time etcd may not be convenient to use directly

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #820: [DRAFT] Support global plugin

2020-11-17 Thread GitBox
juzhiyuan opened a new issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820 This proposal will be resolved in 2.1, and development will be done in 2.2. *TODO* This is an automated message from the

[GitHub] [apisix] Miss-you commented on issue #2703: response-rewrite rewrite the response from apisix

2020-11-17 Thread GitBox
Miss-you commented on issue #2703: URL: https://github.com/apache/apisix/issues/2703#issuecomment-729437502 done https://github.com/apache/apisix/issues/2721 This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Miss-you closed issue #2703: response-rewrite rewrite the response from apisix

2020-11-17 Thread GitBox
Miss-you closed issue #2703: URL: https://github.com/apache/apisix/issues/2703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] spacewander closed issue #2714: bug: When accessing APISIX route, there are two servers in the response header.

2020-11-17 Thread GitBox
spacewander closed issue #2714: URL: https://github.com/apache/apisix/issues/2714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander merged pull request #2731: fix: remove upstream 'Server' header info. fix #2714

2020-11-17 Thread GitBox
spacewander merged pull request #2731: URL: https://github.com/apache/apisix/pull/2731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: fix: remove upstream 'Server' header info. fix #2714 (#2731)

2020-11-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 53e2d53 fix: remove upstream 'Server'

[GitHub] [apisix-dashboard] nic-chen commented on issue #605: discuss: how to get different type of plugin schema in 2.0 manager-api

2020-11-17 Thread GitBox
nic-chen commented on issue #605: URL: https://github.com/apache/apisix-dashboard/issues/605#issuecomment-729405247 > @nic-chen do we will implement this feature in milestone `2.2`? sure This is an automated message

[GitHub] [apisix] Miss-you closed issue #2721: request help: response-rewrite plug-in document optimization

2020-11-17 Thread GitBox
Miss-you closed issue #2721: URL: https://github.com/apache/apisix/issues/2721 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] Miss-you merged pull request #2732: docs: add Attention message for 'response-rewrite' doc.

2020-11-17 Thread GitBox
Miss-you merged pull request #2732: URL: https://github.com/apache/apisix/pull/2732 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: docs: add Attention message for 'response-rewrite' doc. (#2732)

2020-11-17 Thread yousa
This is an automated email from the ASF dual-hosted git repository. yousa pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new ec5ba5f docs: add Attention message for

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
Yiyiyimu commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525773360 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license

[GitHub] [apisix] gewei2000 closed issue #2775: request help: alwayls failed to fetch data from etcd

2020-11-17 Thread GitBox
gewei2000 closed issue #2775: URL: https://github.com/apache/apisix/issues/2775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] spacewander commented on a change in pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
spacewander commented on a change in pull request #2727: URL: https://github.com/apache/apisix/pull/2727#discussion_r525757548 ## File path: apisix/plugins/zipkin/reporter.lua ## @@ -105,38 +104,68 @@ function _M.report(self, span) annotations = span.logs } -

[GitHub] [apisix] tokers commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
tokers commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525755333 ## File path: apisix/cli/file.lua ## @@ -0,0 +1,146 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license

[GitHub] [apisix] tokers commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
tokers commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525753976 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license

[GitHub] [apisix] tokers commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
tokers commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525753350 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license

[GitHub] [apisix] starsz commented on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
starsz commented on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729381611 Hi, I think there is a temporary solution. If your apisix version is earlier than or equal to 2.0, you can change your `/bin/apisix`, comment the line like this ```

[GitHub] [apisix] spacewander commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
spacewander commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525733685 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] tokers edited a comment on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
tokers edited a comment on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729351415 We may need to add some notes in document of plugin proxy-rewrite to state that several headers can not be overridden/deleted by proxy-rewrite plugin (if we don't modify the

[GitHub] [apisix] tokers commented on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
tokers commented on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729351415 We may need to add some notes in document of plugin proxy-rewrite to state that several headers can not be overridden/deleted by proxy-rewrite plugin.

[GitHub] [apisix] Yiyiyimu commented on issue #2110: request help: move `conf/cert` to `t/cert`

2020-11-17 Thread GitBox
Yiyiyimu commented on issue #2110: URL: https://github.com/apache/apisix/issues/2110#issuecomment-729351421 And there is another problem. I'm not sure the usage and difference between `apisix_admin_ssl.crt` and `apisix.crt`, but currently `apisix_admin_ssl.crt` could be customized in

[GitHub] [apisix] tokers commented on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
tokers commented on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729350557 @Applenice Could you introduce your demands why these headers shouldn't be passed? This is an automated message from

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2732: docs: add Attention message for 'response-rewrite' doc.

2020-11-17 Thread GitBox
juzhiyuan commented on a change in pull request #2732: URL: https://github.com/apache/apisix/pull/2732#discussion_r525709907 ## File path: doc/zh-cn/plugins/response-rewrite.md ## @@ -85,3 +94,29 @@ X-Server-status: on {"code":"ok","message":"new json body"} ``` + +###

[GitHub] [apisix] tokers commented on issue #2774: request help: Advanced routing settings

2020-11-17 Thread GitBox
tokers commented on issue #2774: URL: https://github.com/apache/apisix/issues/2774#issuecomment-729347542 > Hi, @aijunziaixifu, As the @spacewander answered in #2763, you can write your filter function. > > Here, I give you an example, you can have a try. > > ``` > curl

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2776: feat(proxy-cache): the cache_zone field in the schema should be optional

2020-11-17 Thread GitBox
Firstsawyou commented on a change in pull request #2776: URL: https://github.com/apache/apisix/pull/2776#discussion_r525700820 ## File path: doc/plugins/proxy-cache.md ## @@ -31,7 +31,7 @@ The proxy-cache plugin, which provides the ability to cache upstream response da |

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2776: feat(proxy-cache): the cache_zone field in the schema should be optional

2020-11-17 Thread GitBox
Firstsawyou commented on a change in pull request #2776: URL: https://github.com/apache/apisix/pull/2776#discussion_r525698125 ## File path: doc/zh-cn/plugins/proxy-cache.md ## @@ -31,7 +31,7 @@ | 名称 | 类型 | 必选项 | 默认值| 有效值

[GitHub] [apisix] tokers commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
tokers commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525696266 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license

[GitHub] [apisix] Firstsawyou opened a new issue #2778: DISCUSS(kafka-logger): the key field should be optional

2020-11-17 Thread GitBox
Firstsawyou opened a new issue #2778: URL: https://github.com/apache/apisix/issues/2778 ### Issue description In the schema of the kafka-logger plugin, the key field is mandatory, as shown below: ``` .. properties = { .. key = {type =

[GitHub] [apisix] starsz commented on issue #2774: request help: Advanced routing settings

2020-11-17 Thread GitBox
starsz commented on issue #2774: URL: https://github.com/apache/apisix/issues/2774#issuecomment-729340051 Hi, @aijunziaixifu, As the @spacewander answered in https://github.com/apache/apisix/issues/2763, you can write your filter function. Here, I give you an example, you can have

[GitHub] [apisix] tokers edited a comment on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
tokers edited a comment on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729336401 @Applenice See https://github.com/apache/apisix/blob/master/doc/plugins/proxy-rewrite.md for details. Just some snippets reference: > > headers | object | optional |  

[GitHub] [apisix] tokers commented on issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
tokers commented on issue #2777: URL: https://github.com/apache/apisix/issues/2777#issuecomment-729336401 @Applenice See https://github.com/apache/apisix/blob/master/doc/plugins/proxy-rewrite.md for details. Just some snippet reference: > > headers | object | optional |   |   |

[GitHub] [apisix-dashboard] gxthrj edited a comment on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?

2020-11-17 Thread GitBox
gxthrj edited a comment on issue #819: URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729333405 Yes, I think upstream can be deleted directly, and 503 can be used when the route cannot find upstream. In other systems, such as k8s, this way is more respected.

[GitHub] [apisix-dashboard] gxthrj commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?

2020-11-17 Thread GitBox
gxthrj commented on issue #819: URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729333405 Yes, I think upstream can be deleted directly, and 503 can be used when the route cannot find upstream. In other systems, such as k8s, this way is more respected. The

[GitHub] [apisix] tokers commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
tokers commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525649569 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2685: refactor: moved etcd initialiation to apisix/cli/etcd.lua

2020-11-17 Thread GitBox
Firstsawyou commented on a change in pull request #2685: URL: https://github.com/apache/apisix/pull/2685#discussion_r525646617 ## File path: apisix/cli/etcd.lua ## @@ -0,0 +1,205 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] pahud commented on a change in pull request #2682: fix(doc): broken links

2020-11-17 Thread GitBox
pahud commented on a change in pull request #2682: URL: https://github.com/apache/apisix/pull/2682#discussion_r525644521 ## File path: doc/README.md ## @@ -101,8 +100,6 @@ The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS

[GitHub] [apisix] pahud commented on a change in pull request #2682: fix(doc): broken links

2020-11-17 Thread GitBox
pahud commented on a change in pull request #2682: URL: https://github.com/apache/apisix/pull/2682#discussion_r525644521 ## File path: doc/README.md ## @@ -101,8 +100,6 @@ The recommended approach is to deploy APISIX with [AWS CDK](https://aws.amazon.com/cdk/) on [AWS

[GitHub] [apisix-dashboard] EnableAsync commented on issue #819: request help: Is it normal that upstreams used by a router can be deleted directly?

2020-11-17 Thread GitBox
EnableAsync commented on issue #819: URL: https://github.com/apache/apisix-dashboard/issues/819#issuecomment-729317388 > > > > * I can directly delete the upstream used by route in dashboard. > > > > Is this expected behaviour? > > > > > > > > > Yes, even if the upstream

[GitHub] [apisix] liuxiran commented on issue #2439: plugin(basic-auth): update the schema

2020-11-17 Thread GitBox
liuxiran commented on issue #2439: URL: https://github.com/apache/apisix/issues/2439#issuecomment-729313435 The solution is the same with https://github.com/apache/apisix/issues/2441, it has already worked well with the apisix master branch and dashboard v2.0 branch. close is now

[GitHub] [apisix] liuxiran closed issue #2439: plugin(basic-auth): update the schema

2020-11-17 Thread GitBox
liuxiran closed issue #2439: URL: https://github.com/apache/apisix/issues/2439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[apisix] branch master updated (8983a8d -> a6678c3)

2020-11-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8983a8d fix(etcd): avoid getting with prefix (#2772) add a6678c3 fix(hmac-auth): when the request

[apisix] branch master updated (8983a8d -> a6678c3)

2020-11-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8983a8d fix(etcd): avoid getting with prefix (#2772) add a6678c3 fix(hmac-auth): when the request

[GitHub] [apisix] tzssangglass commented on issue #2748: doc(FAQ): "It is unreasonable to only enable passive checking"

2020-11-17 Thread GitBox
tzssangglass commented on issue #2748: URL: https://github.com/apache/apisix/issues/2748#issuecomment-729311979 need to explain how healthcheck works to complete this FAQ? This is an automated message from the Apache Git

[apisix] branch master updated (8983a8d -> a6678c3)

2020-11-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8983a8d fix(etcd): avoid getting with prefix (#2772) add a6678c3 fix(hmac-auth): when the request

[GitHub] [apisix] tzssangglass commented on a change in pull request #2751: docs: how could I only enable passive health check

2020-11-17 Thread GitBox
tzssangglass commented on a change in pull request #2751: URL: https://github.com/apache/apisix/pull/2751#discussion_r525629329 ## File path: FAQ.md ## @@ -288,3 +288,7 @@ By default, APISIX only listens on port 9080 when handling HTTP requests. If you ``` 2. Reload

[GitHub] [apisix] tzssangglass closed pull request #2751: docs: how could I only enable passive health check

2020-11-17 Thread GitBox
tzssangglass closed pull request #2751: URL: https://github.com/apache/apisix/pull/2751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix] branch master updated (8983a8d -> a6678c3)

2020-11-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8983a8d fix(etcd): avoid getting with prefix (#2772) add a6678c3 fix(hmac-auth): when the request

[apisix] branch master updated (8983a8d -> a6678c3)

2020-11-17 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8983a8d fix(etcd): avoid getting with prefix (#2772) add a6678c3 fix(hmac-auth): when the request

[GitHub] [apisix] spacewander commented on a change in pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
spacewander commented on a change in pull request #2727: URL: https://github.com/apache/apisix/pull/2727#discussion_r525627348 ## File path: apisix/plugins/zipkin/reporter.lua ## @@ -105,38 +104,68 @@ function _M.report(self, span) annotations = span.logs } -

[GitHub] [apisix] spacewander closed issue #2710: bug(hmac-auth): when the request contains escape characters, the signature verification fails

2020-11-17 Thread GitBox
spacewander closed issue #2710: URL: https://github.com/apache/apisix/issues/2710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander merged pull request #2749: fix(hmac-auth): when the request contains escape characters, the signature verification fails

2020-11-17 Thread GitBox
spacewander merged pull request #2749: URL: https://github.com/apache/apisix/pull/2749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch v2.0 updated (dac8b04 -> 0a6d8f7)

2020-11-17 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from dac8b04 ci: fix CI fail (#818) add 0a6d8f7 test: add e2e test for config route with service_id or

[apisix-dashboard] branch v2.0 updated (dac8b04 -> 0a6d8f7)

2020-11-17 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from dac8b04 ci: fix CI fail (#818) add 0a6d8f7 test: add e2e test for config route with service_id or

[apisix-dashboard] branch v2.0 updated (dac8b04 -> 0a6d8f7)

2020-11-17 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from dac8b04 ci: fix CI fail (#818) add 0a6d8f7 test: add e2e test for config route with service_id or

[apisix-dashboard] branch v2.0 updated (dac8b04 -> 0a6d8f7)

2020-11-17 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from dac8b04 ci: fix CI fail (#818) add 0a6d8f7 test: add e2e test for config route with service_id or

[apisix-dashboard] branch v2.0 updated (dac8b04 -> 0a6d8f7)

2020-11-17 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from dac8b04 ci: fix CI fail (#818) add 0a6d8f7 test: add e2e test for config route with service_id or

[GitHub] [apisix] Applenice opened a new issue #2777: request help: How to close X-Forwarded* and X-Real-IP in requests

2020-11-17 Thread GitBox
Applenice opened a new issue #2777: URL: https://github.com/apache/apisix/issues/2777 ### Issue description I don't want X-Forwarded* and X-Real-IP to appear in APISIX proxy rewrite requests, how do I configure it? I found no relevant information. Is there a way to add, but not a

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #810: test: add e2e test for config route with service_id or upstream_id

2020-11-17 Thread GitBox
juzhiyuan merged pull request #810: URL: https://github.com/apache/apisix-dashboard/pull/810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] EnableAsync commented on a change in pull request #810: test: add e2e test for config route with service_id or upstream_id

2020-11-17 Thread GitBox
EnableAsync commented on a change in pull request #810: URL: https://github.com/apache/apisix-dashboard/pull/810#discussion_r525605876 ## File path: api/test/e2e/route_service_upstream_test.go ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix] gxthrj closed issue #2070: request help: can not running pod in k8s,Readiness probe failed: dial tcp 10.244.0.54:9080: connect: connection refused

2020-11-17 Thread GitBox
gxthrj closed issue #2070: URL: https://github.com/apache/apisix/issues/2070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] gxthrj commented on issue #2070: request help: can not running pod in k8s,Readiness probe failed: dial tcp 10.244.0.54:9080: connect: connection refused

2020-11-17 Thread GitBox
gxthrj commented on issue #2070: URL: https://github.com/apache/apisix/issues/2070#issuecomment-729072460 @csh995426531 Any update? The reason should be that your port is incorrectly written as 9082. Let’s close this issue first and reopen it if you have any problems.

[GitHub] [apisix] Miss-you commented on pull request #2731: fix: remove upstream 'Server' header info. fix #2714

2020-11-17 Thread GitBox
Miss-you commented on pull request #2731: URL: https://github.com/apache/apisix/pull/2731#issuecomment-729070512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   3   >