[GitHub] [apisix] JanLi-air opened a new issue #2833: bug: config.yaml can only use those defined in config-default.yaml

2020-11-23 Thread GitBox
JanLi-air opened a new issue #2833: URL: https://github.com/apache/apisix/issues/2833 ### Issue description config.yaml is used to override those configurations in config-default.yaml. The problem is that some configurations are too niche to be included in config-default.yaml. Suc

[GitHub] [apisix] membphis commented on pull request #2832: ci: make it work under OpenResty 1.19

2020-11-23 Thread GitBox
membphis commented on pull request #2832: URL: https://github.com/apache/apisix/pull/2832#issuecomment-732717149 same problem, close this issue ![image](https://user-images.githubusercontent.com/6814606/100063220-d384b480-2e6b-11eb-92db-64fe792de4e7.png) ---

[GitHub] [apisix] membphis closed pull request #2832: ci: make it work under OpenResty 1.19

2020-11-23 Thread GitBox
membphis closed pull request #2832: URL: https://github.com/apache/apisix/pull/2832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis opened a new pull request #2832: ci: make it work under OpenResty 1.19

2020-11-23 Thread GitBox
membphis opened a new pull request #2832: URL: https://github.com/apache/apisix/pull/2832 same as https://github.com/apache/apisix/pull/2768 make a test This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #861: [Proposal]: Route group feature

2020-11-23 Thread GitBox
juzhiyuan commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-732711893 ok then it looks good to me 👏 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-11-23 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-732710689 > @liuxiran @membphis Just to make sure, if there will have 1-to-n requirement? (1 route with multiple group) I think one route only belongs to one group ---

[GitHub] [apisix] moonming merged pull request #2831: fix: min_etcd_version is a nil value when etcd version less than min_etcd_version

2020-11-23 Thread GitBox
moonming merged pull request #2831: URL: https://github.com/apache/apisix/pull/2831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: fix: min_etcd_version is a nil value when apisix init_etcd (#2831)

2020-11-23 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 82628f0 fix: min_etcd_version is a nil value w

[GitHub] [apisix-dashboard] idbeta opened a new issue #863: bug: 2.1 version create route with cors will cause an error

2020-11-23 Thread GitBox
idbeta opened a new issue #863: URL: https://github.com/apache/apisix-dashboard/issues/863 # Bug report ## Describe the bug 2.1 version create route with `cors` plugin and `cors` used the default setting `{}`, as below: ``` {"name":"test","uris":["/name"],"methods":["GET","

[GitHub] [apisix] liuxiran commented on issue #2737: Proposal: Support enable/disable route

2020-11-23 Thread GitBox
liuxiran commented on issue #2737: URL: https://github.com/apache/apisix/issues/2737#issuecomment-732689191 > > as for the second step I didn't find the relevant code , so do we have any reference codes or documentations? > > Just to make sure, @membphis please take a look at here.

[GitHub] [apisix] tokers commented on a change in pull request #2830: feat: the request parameter participating in the signature can be the parameter name

2020-11-23 Thread GitBox
tokers commented on a change in pull request #2830: URL: https://github.com/apache/apisix/pull/2830#discussion_r529226269 ## File path: apisix/plugins/hmac-auth.lua ## @@ -224,6 +224,13 @@ local function generate_signature(ctx, secret_key, params) for _, key in pairs

[GitHub] [apisix] DHB-liuhong opened a new pull request #2831: fix: min_etcd_version is a nil value when etcd version less than min_etcd_version

2020-11-23 Thread GitBox
DHB-liuhong opened a new pull request #2831: URL: https://github.com/apache/apisix/pull/2831 Signed-off-by: liuhong ### What this PR does / why we need it: Executing apisix init_etcd,it will report min_etcd_version is a nil value when etcd version is less than min_etcd_version

[GitHub] [apisix] juzhiyuan commented on issue #2737: Proposal: Support enable/disable route

2020-11-23 Thread GitBox
juzhiyuan commented on issue #2737: URL: https://github.com/apache/apisix/issues/2737#issuecomment-732671886 > as for the second step I didn't find the relevant code , so do we have any reference codes or documentations? Just to make sure, @membphis please take a look at here.

[GitHub] [apisix] juzhiyuan edited a comment on issue #2737: Proposal: Support enable/disable route

2020-11-23 Thread GitBox
juzhiyuan edited a comment on issue #2737: URL: https://github.com/apache/apisix/issues/2737#issuecomment-732671450 @liuxiran If this is ok, kindly remove the `discuss` label and add `enhancement`. This is an automated mess

[GitHub] [apisix] juzhiyuan commented on issue #2737: Proposal: Support enable/disable route

2020-11-23 Thread GitBox
juzhiyuan commented on issue #2737: URL: https://github.com/apache/apisix/issues/2737#issuecomment-732671450 If this is ok, kindly remove the `discuss` label and add `enhancement`. This is an automated message from the Apache

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #853: feat: show some important information after started the `manager-api`

2020-11-23 Thread GitBox
juzhiyuan commented on issue #853: URL: https://github.com/apache/apisix-dashboard/issues/853#issuecomment-732670889 oh yes! Please add some needed info in the log :) This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #861: [Proposal]: Route group feature

2020-11-23 Thread GitBox
juzhiyuan edited a comment on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-732670507 @liuxiran @membphis Just to make sure, if there will have 1-to-n requirement? (1 route with multiple group) ---

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #861: [Proposal]: Route group feature

2020-11-23 Thread GitBox
juzhiyuan commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-732670507 Just to make sure, if there will have 1-to-n requirement? (1 route with multiple group) This is an automat

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529218125 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2830: feat: the request parameter participating in the signature can be the parameter name

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2830: URL: https://github.com/apache/apisix/pull/2830#discussion_r529213525 ## File path: apisix/plugins/hmac-auth.lua ## @@ -224,6 +224,13 @@ local function generate_signature(ctx, secret_key, params) for _, key in

[GitHub] [apisix-dashboard] idbeta opened a new issue #862: bug: 2.1 version create route with jwt-auth will display an error

2020-11-23 Thread GitBox
idbeta opened a new issue #862: URL: https://github.com/apache/apisix-dashboard/issues/862 # Bug report ## Describe the bug 2.1 version create route with jwt-auth will display an error ![image](https://user-images.githubusercontent.com/7396835/100048866-e50c9300-2e50-11eb-9

[GitHub] [apisix-dashboard] idbeta edited a comment on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
idbeta edited a comment on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732639178 > @idbeta pls confirm this issue, it seems to be a bug ~My 2.1 version environment also has this problem.~ sorry, 2.1 version environment did not reproduce

[GitHub] [apisix-dashboard] idbeta commented on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
idbeta commented on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732639178 > @idbeta pls confirm this issue, it seems to be a bug My 2.1 version environment also has this problem. ---

[GitHub] [apisix-dashboard] starsz commented on issue #852: bug: manager-api supported `POST` method for consumer

2020-11-23 Thread GitBox
starsz commented on issue #852: URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732637307 > > So I think apisix-dashboard should forbid `POST` and merge `Create and Update` into a function which was called by`PUT` method. > > agree with this. @starsz would li

[apisix] branch v2.1 created (now e8c9a61)

2020-11-23 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch v2.1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at e8c9a61 fix No new revisions were added by this update.

[GitHub] [apisix] membphis commented on a change in pull request #2830: feat: the request parameter participating in the signature can be the parameter name

2020-11-23 Thread GitBox
membphis commented on a change in pull request #2830: URL: https://github.com/apache/apisix/pull/2830#discussion_r529184449 ## File path: apisix/plugins/hmac-auth.lua ## @@ -224,6 +224,13 @@ local function generate_signature(ctx, secret_key, params) for _, key in pai

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #609: Publish the Dashboard to DockerHub under Apache

2020-11-23 Thread GitBox
juzhiyuan edited a comment on issue #609: URL: https://github.com/apache/apisix-dashboard/issues/609#issuecomment-732636310 Hi, @totemofwolf would you have time for this issue? This is an automated message from the Apache Gi

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #609: Publish the Dashboard to DockerHub under Apache

2020-11-23 Thread GitBox
juzhiyuan commented on issue #609: URL: https://github.com/apache/apisix-dashboard/issues/609#issuecomment-732636310 Hi @totemofwolf would you have time to this issue? This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] juzhiyuan closed issue #804: Apache/apisix-dashboard docker image

2020-11-23 Thread GitBox
juzhiyuan closed issue #804: URL: https://github.com/apache/apisix-dashboard/issues/804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] LiteSun opened a new issue #861: [Proposal]: Route group feature

2020-11-23 Thread GitBox
LiteSun opened a new issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861 # why In order to allow users to filter out routes with a specified group from a large number of routes, I propose to add the route groups feature. # how ## front-end In order to fini

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #756: request help: add `info` page for Apache APISIX

2020-11-23 Thread GitBox
juzhiyuan commented on issue #756: URL: https://github.com/apache/apisix-dashboard/issues/756#issuecomment-732635397 duplicate with #850 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix-dashboard] juzhiyuan closed issue #756: request help: add `info` page for Apache APISIX

2020-11-23 Thread GitBox
juzhiyuan closed issue #756: URL: https://github.com/apache/apisix-dashboard/issues/756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #814: proxy-rewrite header invalid configuration

2020-11-23 Thread GitBox
juzhiyuan closed issue #814: URL: https://github.com/apache/apisix-dashboard/issues/814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #802: example-plugin return 500 error code

2020-11-23 Thread GitBox
juzhiyuan closed issue #802: URL: https://github.com/apache/apisix-dashboard/issues/802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #762: bug: dashboard2.0 ip-restriction UI display dislocation

2020-11-23 Thread GitBox
juzhiyuan closed issue #762: URL: https://github.com/apache/apisix-dashboard/issues/762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #764: need request-validation work in dashboard

2020-11-23 Thread GitBox
juzhiyuan closed issue #764: URL: https://github.com/apache/apisix-dashboard/issues/764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #790: bug: when create a route with kafka-logger, the plugin's option is missing field.

2020-11-23 Thread GitBox
juzhiyuan closed issue #790: URL: https://github.com/apache/apisix-dashboard/issues/790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #812: Dashboard Create Comsumer promblem:”Please enable one authentication plugin“

2020-11-23 Thread GitBox
juzhiyuan closed issue #812: URL: https://github.com/apache/apisix-dashboard/issues/812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #788: bug: dashboard2.0 ip-restriction plugin set blacklist, can not set ipv4 or ipv4/CIDR

2020-11-23 Thread GitBox
juzhiyuan closed issue #788: URL: https://github.com/apache/apisix-dashboard/issues/788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #815: Integrate with code-mirror to have a fallback to plugins' render issue

2020-11-23 Thread GitBox
juzhiyuan commented on issue #815: URL: https://github.com/apache/apisix-dashboard/issues/815#issuecomment-732635180 This issue is related to those issues. #764 #802 #812 #814 #790 #788 #762 T

[GitHub] [apisix-dashboard] juzhiyuan closed issue #587: add e2e test for Apache APISIX dashboard

2020-11-23 Thread GitBox
juzhiyuan closed issue #587: URL: https://github.com/apache/apisix-dashboard/issues/587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] starsz commented on issue #853: feat: show some important information after started the `manager-api`

2020-11-23 Thread GitBox
starsz commented on issue #853: URL: https://github.com/apache/apisix-dashboard/issues/853#issuecomment-732634376 Hi,@juzhiyuan. I think the version info is needed. And it's difficult to get `On your network` info accurately if the machine has multiple network cards.

[GitHub] [apisix-dashboard] juzhiyuan closed issue #675: test: Backend E2E is not stable

2020-11-23 Thread GitBox
juzhiyuan closed issue #675: URL: https://github.com/apache/apisix-dashboard/issues/675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #578: Can I set up stream_proxy through the new version of apisix-dashboard? No interface seems to be found

2020-11-23 Thread GitBox
juzhiyuan commented on issue #578: URL: https://github.com/apache/apisix-dashboard/issues/578#issuecomment-732632562 cc @membphis This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix] moonming commented on a change in pull request #2801: release: release 2.1 version.

2020-11-23 Thread GitBox
moonming commented on a change in pull request #2801: URL: https://github.com/apache/apisix/pull/2801#discussion_r529179748 ## File path: CHANGELOG.md ## @@ -32,6 +33,24 @@ - [0.7.0](#070) - [0.6.0](#060) +## 2.1.0 + +### Core +- :sunrise: **support ENV variable in configur

[GitHub] [apisix-dashboard] juzhiyuan closed issue #610: 1-key Dashboard

2020-11-23 Thread GitBox
juzhiyuan closed issue #610: URL: https://github.com/apache/apisix-dashboard/issues/610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #624: Architecture about How dashboard works with APISIX

2020-11-23 Thread GitBox
juzhiyuan closed issue #624: URL: https://github.com/apache/apisix-dashboard/issues/624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] Firstsawyou opened a new pull request #2830: feat: the request parameter participating in the signature can be the parameter name

2020-11-23 Thread GitBox
Firstsawyou opened a new pull request #2830: URL: https://github.com/apache/apisix/pull/2830 ### What this PR does / why we need it: close #2823 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been a

[GitHub] [apisix-dashboard] juzhiyuan closed issue #673: Improve FAQ

2020-11-23 Thread GitBox
juzhiyuan closed issue #673: URL: https://github.com/apache/apisix-dashboard/issues/673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] membphis commented on issue #852: bug: manager-api supported `POST` method for consumer

2020-11-23 Thread GitBox
membphis commented on issue #852: URL: https://github.com/apache/apisix-dashboard/issues/852#issuecomment-732628199 > So I think apisix-dashboard should forbid `POST` and merge `Create and Update` into a function which was called by`PUT` method. agree with this. @starsz would like t

[GitHub] [apisix] HelloBug0 commented on a change in pull request #2769: feat: enable access log or not

2020-11-23 Thread GitBox
HelloBug0 commented on a change in pull request #2769: URL: https://github.com/apache/apisix/pull/2769#discussion_r529177674 ## File path: .travis/apisix_cli_test.sh ## @@ -389,12 +389,86 @@ if [ ! $? -eq 0 ]; then exit 1 fi -git checkout conf/config.yaml +echo "passed:

[GitHub] [apisix] starsz commented on issue #2818: [DISCUSS]: Use luasocket lib instead of `curl` in "bin/apisix"

2020-11-23 Thread GitBox
starsz commented on issue #2818: URL: https://github.com/apache/apisix/issues/2818#issuecomment-732625779 Hi, @moonming, I think there is no need to use `lua-resty-http`. In CLI, we don't care about non-blocking, and luasocket is also easy to use now. What's your opinion about usi

[GitHub] [apisix-dashboard] juzhiyuan closed issue #717: bug: The route created by admin API is missing fields in the dashboard display

2020-11-23 Thread GitBox
juzhiyuan closed issue #717: URL: https://github.com/apache/apisix-dashboard/issues/717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] membphis commented on issue #2800: test(CLI): only need to confirm part of result, returned list may change in the future.

2020-11-23 Thread GitBox
membphis commented on issue #2800: URL: https://github.com/apache/apisix/issues/2800#issuecomment-732623644 > I'm going through the whole project background. I'm not so sure what 'init_kv=(' and 'apisix_cli_test.sh ' for, yet. Where can I figure it out quickly. Would you give me some clues

[GitHub] [apisix-dashboard] juzhiyuan closed issue #722: doc: deployment topology diagram

2020-11-23 Thread GitBox
juzhiyuan closed issue #722: URL: https://github.com/apache/apisix-dashboard/issues/722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] backnero commented on issue #2828: bug: Request the route of the same service for a short time, the path is lost

2020-11-23 Thread GitBox
backnero commented on issue #2828: URL: https://github.com/apache/apisix/issues/2828#issuecomment-732620943 when i enable config 'enable_debug' ``` 020/11/24 03:19:08 [error] 17#17: *6274 failed to run log_by_lua*: /usr/local/apisix/apisix/core/response.lua:128: headers have alrea

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #784: bug: when created route by adminAPI, "method" can be null value which dashboard can not identify

2020-11-23 Thread GitBox
juzhiyuan commented on issue #784: URL: https://github.com/apache/apisix-dashboard/issues/784#issuecomment-732613042 current solution: use multiple select[1] to resolve this issue [1] https://ant.design/components/select-cn/ -

[GitHub] [apisix] spacewander commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
spacewander commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529174101 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix-dashboard] starsz edited a comment on issue #849: backend APISIX instance status API

2020-11-23 Thread GitBox
starsz edited a comment on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-732029069 After discussed with @tokers @juzhiyuan .There are some things that need to do in the backend. Todo: ~~1. manager-api needs to start a goroutine to clean the n

[GitHub] [apisix] spacewander commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
spacewander commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529097971 ## File path: t/node/upstream-status-5xx.t ## @@ -0,0 +1,373 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix-dashboard] starsz commented on issue #849: backend APISIX instance status API

2020-11-23 Thread GitBox
starsz commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-732606230 @tokers. Agree with you. I think this can be done in DP. So, CP doesn't need to care about it. This is an

[GitHub] [apisix] membphis commented on issue #2737: Proposal: Support enable/disable route

2020-11-23 Thread GitBox
membphis commented on issue #2737: URL: https://github.com/apache/apisix/issues/2737#issuecomment-732605433 I write an example, follow @liuxiran design: add new field `status`. I think this way is good. ``` { "uri": "/hello",# uri "status": 0,# integer va

[GitHub] [apisix] spacewander commented on issue #2820: request help: how to apply bandwidth control in apisix?

2020-11-23 Thread GitBox
spacewander commented on issue #2820: URL: https://github.com/apache/apisix/issues/2820#issuecomment-732604124 Because Nginx doesn't provide a mechanism to limit ingress traffic. This is an automated message from the Apache G

[GitHub] [apisix-dashboard] spacewander commented on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
spacewander commented on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732600680 Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #821: [Proposal]: Monitor Routes

2020-11-23 Thread GitBox
juzhiyuan commented on issue #821: URL: https://github.com/apache/apisix-dashboard/issues/821#issuecomment-732599951 cc @liuxiran @membphis @moonming @starsz This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #822: [Proposal]: Alarm Mechanism

2020-11-23 Thread GitBox
juzhiyuan commented on issue #822: URL: https://github.com/apache/apisix-dashboard/issues/822#issuecomment-732599253 cc @nic-chen @membphis @tokers @liuxiran This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] wfgydbu edited a comment on issue #2820: request help: how to apply bandwidth control in apisix?

2020-11-23 Thread GitBox
wfgydbu edited a comment on issue #2820: URL: https://github.com/apache/apisix/issues/2820#issuecomment-732546797 > There is not such a feature. But you can write your plugin works on body_filter and do the egress limitation, then apply it to global rule. There is not way to archive an ing

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2?

2020-11-23 Thread GitBox
juzhiyuan commented on issue #831: URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-732595015 according to current tasks, this enhancement feature will resolve in 2.3. This is an automated message from

[apisix] branch master updated: fix(consumer): keep the id field for compatibility (#2829)

2020-11-23 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new c8823d0 fix(consumer): keep the id field for

[GitHub] [apisix] membphis merged pull request #2829: fix(consumer): keep the id field for compatibility

2020-11-23 Thread GitBox
membphis merged pull request #2829: URL: https://github.com/apache/apisix/pull/2829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #839: feat: support to connect etcd with `username` and `password`

2020-11-23 Thread GitBox
juzhiyuan commented on issue #839: URL: https://github.com/apache/apisix-dashboard/issues/839#issuecomment-732589128 Will this be resolved in 2.2? This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #853: feat: show some important information after started the `manager-api`

2020-11-23 Thread GitBox
juzhiyuan commented on issue #853: URL: https://github.com/apache/apisix-dashboard/issues/853#issuecomment-732584085 Just to make sure, what will log when starting the manager-api? How about this one? ``` The manager-api is running successfully! You can now access it by us

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
juzhiyuan commented on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732572672 https://github.com/apache/apisix/pull/2829 @spacewander Just to make sure, this PR will fix this issue?

[GitHub] [apisix-website] juzhiyuan commented on issue #96: Remove old release from mirrors

2020-11-23 Thread GitBox
juzhiyuan commented on issue #96: URL: https://github.com/apache/apisix-website/issues/96#issuecomment-732558875 old release are removed from https://dist.apache.org/repos/dist/release/apisix/ and https://downloads.apache.org/apisix/dashboard-2.0/ will take effect for a while

[GitHub] [apisix-website] juzhiyuan closed issue #96: Remove old release from mirrors

2020-11-23 Thread GitBox
juzhiyuan closed issue #96: URL: https://github.com/apache/apisix-website/issues/96 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-website] juzhiyuan commented on issue #96: Remove old release from mirrors

2020-11-23 Thread GitBox
juzhiyuan commented on issue #96: URL: https://github.com/apache/apisix-website/issues/96#issuecomment-732557279 DONE This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix-dashboard] liuxiran commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time

2020-11-23 Thread GitBox
liuxiran commented on issue #851: URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732556546 > I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as `CreatedAt`, `CreatedBy` etc. agree +

[GitHub] [apisix] spacewander opened a new pull request #2829: fix(consumer): keep the id field for compatibility

2020-11-23 Thread GitBox
spacewander opened a new pull request #2829: URL: https://github.com/apache/apisix/pull/2829 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have

[GitHub] [apisix] wfgydbu commented on issue #2820: request help: how to apply bandwidth control in apisix?

2020-11-23 Thread GitBox
wfgydbu commented on issue #2820: URL: https://github.com/apache/apisix/issues/2820#issuecomment-732546797 > There is not such a feature. But you can write your plugin works on body_filter and do the egress limitation, then apply it to global rule. There is not way to archive an ingress ba

[GitHub] [apisix] backnero closed issue #2738: bug: ? Is replaced with %3

2020-11-23 Thread GitBox
backnero closed issue #2738: URL: https://github.com/apache/apisix/issues/2738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time

2020-11-23 Thread GitBox
juzhiyuan commented on issue #851: URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732546208 Not sure if it's a bug indeed, what's your opinion? I would be more prefer with @ShiningRush's opinion 🤔 cc @membphis @nic-chen @liuxiran @tokers -

[GitHub] [apisix-dashboard] spacewander edited a comment on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
spacewander edited a comment on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732537568 @cleverpig ~~Could you show your dashboard commit so that we can reproduce the issue? It look like the latest dashboard (1a38fa6cf6540bc966098f6467a160312fb6b0f

[GitHub] [apisix-dashboard] spacewander edited a comment on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
spacewander edited a comment on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732537568 @cleverpig ~~Could you show your dashboard commit so that we can reproduce the issue? It look like the latest dashboard (1a38fa6cf6540bc966098f6467a160312fb6b0f

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529131022 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix-dashboard] spacewander commented on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
spacewander commented on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732537568 @cleverpig Could you show your dashboard commit so that we can reproduce the issue? It look like the latest dashboard (1a38fa6cf6540bc966098f6467a160312fb6b0fd) doesn

[GitHub] [apisix] backnero edited a comment on issue #2828: bug: Request the route of the same service for a short time, the path is lost

2020-11-23 Thread GitBox
backnero edited a comment on issue #2828: URL: https://github.com/apache/apisix/issues/2828#issuecomment-732536625 In addition, in version 2.0, when the global plug-in settings return to the head, two servers will appear. One of the apisix, one is my custom. Is it to show that apisix provi

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529126522 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] backnero commented on issue #2828: bug: Request the route of the same service for a short time, the path is lost

2020-11-23 Thread GitBox
backnero commented on issue #2828: URL: https://github.com/apache/apisix/issues/2828#issuecomment-732536625 In addition, in version 2.0, when the global plug-in settings return to the head, two servers will appear. One of the apisix, one is my custom. Is it to show that apisix provides ser

[GitHub] [apisix] backnero opened a new issue #2828: bug: Request the route of the same service for a short time, the path is lost

2020-11-23 Thread GitBox
backnero opened a new issue #2828: URL: https://github.com/apache/apisix/issues/2828 ### Issue description When two routes of the same upstream-service are requested, the first route responds successfully, and the second route shows path loss, or the response value is the same as the fi

[GitHub] [apisix] ShiningRush commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-11-23 Thread GitBox
ShiningRush commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-732533463 I will try to produce the bug in master, We have not been able to produce this bug stably before : ( This is an a

[GitHub] [apisix-dashboard] ShiningRush edited a comment on pull request #860: fix: add consumer with custom create time or update time

2020-11-23 Thread GitBox
ShiningRush edited a comment on pull request #860: URL: https://github.com/apache/apisix-dashboard/pull/860#issuecomment-732531024 I have leave my opinion on the issue(#851 ) , we should talk more before merge. This is an au

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #851: bug: manager-api do not support add consumer with custom create time or update time

2020-11-23 Thread GitBox
ShiningRush edited a comment on issue #851: URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732531288 I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as `CreatedAt`, `CreatedBy` etc.

[GitHub] [apisix-dashboard] ShiningRush commented on issue #851: bug: manager-api do not support add consumer with custom create time or update time

2020-11-23 Thread GitBox
ShiningRush commented on issue #851: URL: https://github.com/apache/apisix-dashboard/issues/851#issuecomment-732531288 I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as CreatedAt, CreatedBy etc. ---

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #860: fix: add consumer with custom create time or update time

2020-11-23 Thread GitBox
ShiningRush commented on pull request #860: URL: https://github.com/apache/apisix-dashboard/pull/860#issuecomment-732531024 I don't think it is a bug, audit field should maintain by server not client.So we should not accept client audit field such as `CreatedAt`, `CreatedBy` etc. ---

[GitHub] [apisix] spacewander commented on a change in pull request #2803: feat: support include other nginx config

2020-11-23 Thread GitBox
spacewander commented on a change in pull request #2803: URL: https://github.com/apache/apisix/pull/2803#discussion_r529111901 ## File path: .travis/apisix_cli_test.sh ## @@ -458,6 +458,64 @@ fi echo "passed: found 'my_dict' in nginx.conf" +# allow injecting configuration

[GitHub] [apisix] spacewander commented on a change in pull request #2769: feat: enable access log or not

2020-11-23 Thread GitBox
spacewander commented on a change in pull request #2769: URL: https://github.com/apache/apisix/pull/2769#discussion_r529109459 ## File path: .travis/apisix_cli_test.sh ## @@ -389,12 +389,86 @@ if [ ! $? -eq 0 ]; then exit 1 fi -git checkout conf/config.yaml +echo "passe

[GitHub] [apisix] GiftLee opened a new issue #2827: request help: fault-injection abort.body Using variables

2020-11-23 Thread GitBox
GiftLee opened a new issue #2827: URL: https://github.com/apache/apisix/issues/2827 ### Issue description abort.body {"status":"success","time":"$time_local"} $time_local is nginx variables or Custom variable ok english is poor i want this

[GitHub] [apisix] spacewander commented on a change in pull request #2801: release: release 2.1 version.

2020-11-23 Thread GitBox
spacewander commented on a change in pull request #2801: URL: https://github.com/apache/apisix/pull/2801#discussion_r529097117 ## File path: CHANGELOG.md ## @@ -32,6 +33,24 @@ - [0.7.0](#070) - [0.6.0](#060) +## 2.1.0 + +### Core +- :sunrise: **support ENV variable in confi

[GitHub] [apisix-dashboard] spacewander edited a comment on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
spacewander edited a comment on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732514806 ~~I guess it is because consumer id is removed in the master branch. We need to update the stored etcd data. https://github.com/apache/apisix/pull/2679~~ Sorr

[GitHub] [apisix-dashboard] spacewander edited a comment on issue #856: After create a consumer on dashboard, apisix throw a exception

2020-11-23 Thread GitBox
spacewander edited a comment on issue #856: URL: https://github.com/apache/apisix-dashboard/issues/856#issuecomment-732514806 I guess it is because consumer id is removed in the master branch. We need to update the stored etcd data. https://github.com/apache/apisix/pull/2679 -

  1   2   3   >