wenlincheng opened a new issue #2883:
URL: https://github.com/apache/apisix/issues/2883
### Issue description
### Environment
* apisix version (cmd: `apisix version`):2.0
* OS:MacOS
`
2020/11/28 06:48:51 [error] 42#42: *16841 lua entry thread aborted:
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735045558
The frontend has completed, this PR is waiting for the manager-api to
support this issue https://github.com/apache/apisix-dashboard/issues/495
codecov-io commented on pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899#issuecomment-735044453
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/899?src=pr=h1)
Report
> Merging
ShiningRush opened a new pull request #899:
URL: https://github.com/apache/apisix-dashboard/pull/899
- Add middleware to transform error, resolve #568
- Rename `placeholder.txt` to `.gitkeep`, It is more suitable
This is
spacewander closed issue #1335:
URL: https://github.com/apache/apisix/issues/1335
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on issue #612:
URL: https://github.com/apache/apisix/issues/612#issuecomment-735043320
Already done in many plugins.
This is an automated message from the Apache Git Service.
To respond to the message,
spacewander closed issue #612:
URL: https://github.com/apache/apisix/issues/612
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander closed issue #790:
URL: https://github.com/apache/apisix/issues/790
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
spacewander closed issue #1044:
URL: https://github.com/apache/apisix/issues/1044
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on issue #1044:
URL: https://github.com/apache/apisix/issues/1044#issuecomment-735043138
Duplicate of #812
This is an automated message from the Apache Git Service.
To respond to the message, please log
spacewander closed issue #2314:
URL: https://github.com/apache/apisix/issues/2314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander closed issue #2834:
URL: https://github.com/apache/apisix/issues/2834
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander merged pull request #2856:
URL: https://github.com/apache/apisix/pull/2856
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 1c211ff fix: validate plugin
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new f4dfcfb fix: we didn't initialize custom
moonming merged pull request #2874:
URL: https://github.com/apache/apisix/pull/2874
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tzssangglass commented on issue #2308:
URL: https://github.com/apache/apisix/issues/2308#issuecomment-735037826
i can do this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
juzhiyuan edited a comment on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735033723
https://github.com/apache/apisix-dashboard/pull/898/files#diff-0dc947a149da358540c612806141422ec2dab3029fcc1b255953be994655ec74R151-R160
This PR[1] would depend on
juzhiyuan commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735033723
This PR[1] would depend on this feature, related issue [2]
[1] https://github.com/apache/apisix-dashboard/pull/898
[2]
moonming commented on pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#issuecomment-735033621
is this pr will close #633？
This is an automated message from the Apache Git Service.
To respond to the
juzhiyuan edited a comment on issue #532:
URL:
https://github.com/apache/apisix-dashboard/issues/532#issuecomment-735033457
waiting for
https://github.com/apache/apisix/issues/2308#issuecomment-735024172
https://github.com/apache/apisix/issues/2308
juzhiyuan commented on issue #532:
URL:
https://github.com/apache/apisix-dashboard/issues/532#issuecomment-735033457
waiting for
https://github.com/apache/apisix/issues/2308#issuecomment-735024172
This is an automated
codecov-io edited a comment on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735022395
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr=h1)
Report
> Merging
juzhiyuan commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735033298
waiting for manager-api to support `disable` property.
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch juzhiyuan/feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from e98bb4b feat(Plugin): remove a7 plugin
add e769114 feat(Plugin): remove
moonming commented on issue #2881:
URL: https://github.com/apache/apisix/issues/2881#issuecomment-735033229
cc @gxthrj
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan edited a comment on issue #495:
URL:
https://github.com/apache/apisix-dashboard/issues/495#issuecomment-735029848
juzhiyuan edited a comment on issue #495:
URL:
https://github.com/apache/apisix-dashboard/issues/495#issuecomment-735029848
juzhiyuan edited a comment on issue #495:
URL:
https://github.com/apache/apisix-dashboard/issues/495#issuecomment-735029848
juzhiyuan commented on issue #495:
URL:
https://github.com/apache/apisix-dashboard/issues/495#issuecomment-735029848
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735028068
I think the plugins' doc need to be rewritten to show the difference. There
is no need to show the `disable a plugin for a route/service` in every doc
since they are similar.
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735027604
OK, I was misled right now. It is **disable a plugin for a route/service**,
not **disable a plugin**. We should clarify it in the doc. The current doc mess
`enable / disable a
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735027031
Better not mention this experimental feature in the doc.
This is an automated message from the Apache Git
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735026954
Isn't this behavior broken now? Add a disable field doesn't trigger the
`destory` method of the plugin. And re-enable a plugin doesn't the `init`
method.
membphis commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735024950
We can add a new section about this way, add a reference to the doc of
`plugin`.
This is an automated message from
juzhiyuan opened a new issue #2882:
URL: https://github.com/apache/apisix/issues/2882
### Issue description
Should we update plugins' docs to use the `disable` property instead of
omitting the plugin's data to disable that plugin?
e.g
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818598
##
File path: web/src/components/Plugin/data.tsx
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
spacewander commented on issue #2881:
URL: https://github.com/apache/apisix/issues/2881#issuecomment-735024193
CC @nic-chen
This is an automated message from the Apache Git Service.
To respond to the message, please log on
membphis commented on issue #2308:
URL: https://github.com/apache/apisix/issues/2308#issuecomment-735024172
We can support this feature in 2.2
This is an automated message from the Apache Git Service.
To respond to the
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818150
##
File path: web/src/components/Plugin/service.ts
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818123
##
File path: web/src/components/Plugin/data.tsx
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
juzhiyuan commented on a change in pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r531818067
##
File path: web/src/components/Plugin/IconFont.tsx
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Yiyiyimu opened a new issue #2881:
URL: https://github.com/apache/apisix/issues/2881
### Issue description
```
$ k logs apisix-gw-deployment-56467f797f-pcdws
got malformed version message: "" from etcd
```
which means no version message returned from etcdctl so no etcd
spacewander commented on issue #2880:
URL: https://github.com/apache/apisix/issues/2880#issuecomment-735022619
PR is welcome.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
codecov-io commented on pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-735022395
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/898?src=pr=h1)
Report
> Merging
juzhiyuan opened a new pull request #898:
URL: https://github.com/apache/apisix-dashboard/pull/898
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
-
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan/feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/juzhiyuan/feat-plugin by this
push:
new
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch juzhiyuan/feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at 09ad0c2 feat(plugin): added code mirror
This branch includes the following new
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch juzhiyuan/feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit 09ad0c28527739231da8e9ca284681ead162358e
Author: juzhiyuan
AuthorDate: Sat Nov 28 09:04:30
membphis commented on issue #896:
URL:
https://github.com/apache/apisix-dashboard/issues/896#issuecomment-735017771
We can choose a quick way at the first.
This is acceptable for me.
This is an automated message from
juzhiyuan commented on issue #2308:
URL: https://github.com/apache/apisix/issues/2308#issuecomment-734993691
any update? Does this support now?
This is an automated message from the Apache Git Service.
To respond to the
juzhiyuan commented on issue #850:
URL:
https://github.com/apache/apisix-dashboard/issues/850#issuecomment-734993296
This issue would be addressed by @guoqqqi
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on issue #850:
URL:
https://github.com/apache/apisix-dashboard/issues/850#issuecomment-734993125
@starsz @tokers Could we have API schema confirmed? so that the frontend
would go parallel.
This is an
jenskeiner opened a new issue #2880:
URL: https://github.com/apache/apisix/issues/2880
## Background
The `openid-connect` plugin, when configured accordingly, may obtain an _ID
token_, a _user info_ JSON object, and an _access token_, respectively, on
behalf of the requestor by
jenskeiner commented on a change in pull request #2859:
URL: https://github.com/apache/apisix/pull/2859#discussion_r531735142
##
File path: doc/plugin-develop.md
##
@@ -168,8 +168,8 @@ local _M = {
Determine which phase to run, generally access or rewrite. If you don't know
wfnuser commented on pull request #2846:
URL: https://github.com/apache/apisix/pull/2846#issuecomment-734907306
> Yes, you are right.
The pr is ready now.
This is an automated message from the Apache Git Service.
To
nic-chen commented on issue #896:
URL:
https://github.com/apache/apisix-dashboard/issues/896#issuecomment-734902007
In order to fix this bug quickly, I am going to change the ID field type to
interface, perform type conversion during input, and convert int to a string so
that when APISIX
codecov-io edited a comment on pull request #897:
URL: https://github.com/apache/apisix-dashboard/pull/897#issuecomment-734777124
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/897?src=pr=h1)
Report
> Merging
idbeta commented on a change in pull request #897:
URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r531677355
##
File path: api/test/e2e/upstream_test.go
##
@@ -188,7 +188,60 @@ func TestRoute_Node_Host(t *testing.T) {
}
}
-//TODO cHash
+func
idbeta commented on a change in pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#discussion_r531671974
##
File path: api/test/e2e/route_with_vars_test.go
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
codecov-io edited a comment on pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#issuecomment-734730162
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/895?src=pr=h1)
Report
> Merging
Firstsawyou closed issue #2860:
URL: https://github.com/apache/apisix/issues/2860
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
idbeta commented on a change in pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#discussion_r531671974
##
File path: api/test/e2e/route_with_vars_test.go
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
idbeta commented on a change in pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#discussion_r531671793
##
File path: api/test/e2e/route_with_vars_test.go
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Firstsawyou opened a new issue #2879:
URL: https://github.com/apache/apisix/issues/2879
### Issue description
In the `http-logger` plugin documentation, the description information of
the `batch_max_size` and `include_req_body` attributes is not clear. And the
`include_req_body` of
nic-chen closed issue #634:
URL: https://github.com/apache/apisix-dashboard/issues/634
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #634:
URL:
https://github.com/apache/apisix-dashboard/issues/634#issuecomment-734881472
close since PR merged.
This is an automated message from the Apache Git Service.
To respond to the message,
nic-chen commented on issue #856:
URL:
https://github.com/apache/apisix-dashboard/issues/856#issuecomment-734854361
@spacewander
field `algorithm` defines a default value (HS256) in json schema, but
creating a consumer on dashboard will not set this default value.
it's for
spacewander commented on issue #856:
URL:
https://github.com/apache/apisix-dashboard/issues/856#issuecomment-734822827
>
>
> It may be the default value from json schema problem
@nic-chen
Do you mean the `"remote_addrs":[""]` in @cleverpig's route?
spacewander commented on a change in pull request #2856:
URL: https://github.com/apache/apisix/pull/2856#discussion_r531563032
##
File path: apisix/core/config_etcd.lua
##
@@ -256,6 +264,14 @@ local function sync_data(self)
end
end
+
cleverpig commented on issue #856:
URL:
https://github.com/apache/apisix-dashboard/issues/856#issuecomment-734801426
my route configuration :
```
/apisix/routes/
init_dir
/apisix/routes/32853053411227
tokers commented on issue #2870:
URL: https://github.com/apache/apisix/issues/2870#issuecomment-734796253
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
moonming commented on issue #896:
URL:
https://github.com/apache/apisix-dashboard/issues/896#issuecomment-734795008
I think this is a serious bug
This is an automated message from the Apache Git Service.
To respond to the
moonming merged pull request #2876:
URL: https://github.com/apache/apisix/pull/2876
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 89d49ed chore: lint kafka-logger (#2876)
tokers removed a comment on issue #2855:
URL: https://github.com/apache/apisix/issues/2855#issuecomment-734791895
The existing admin api will be removed in the future, so may be is not
suitable to add new configuration center again.
cc @moonming
tokers commented on issue #2855:
URL: https://github.com/apache/apisix/issues/2855#issuecomment-734791895
The existing admin api will be removed in the future, so may be is not
suitable to add new configuration center again.
cc @moonming
tokers commented on issue #2695:
URL: https://github.com/apache/apisix/issues/2695#issuecomment-734789204
That's really awkward since etcd misses this option in the command line help
message, just use this option: `--enable-grpc-gateway`.
tokers commented on issue #2853:
URL: https://github.com/apache/apisix/issues/2853#issuecomment-734788661
> Do you have slack channels. I might have a lot of questions.
Yeah, also use this name `tokers`.
This is an
membphis commented on a change in pull request #897:
URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r531543175
##
File path: api/test/e2e/upstream_test.go
##
@@ -188,7 +188,60 @@ func TestRoute_Node_Host(t *testing.T) {
}
}
-//TODO cHash
+func
tokers commented on a change in pull request #2856:
URL: https://github.com/apache/apisix/pull/2856#discussion_r531541188
##
File path: apisix/plugin.lua
##
@@ -498,4 +498,102 @@ function _M.get(name)
end
+local function check_schema(plugins_conf, schema_type,
membphis commented on a change in pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#discussion_r531542277
##
File path: api/test/e2e/route_with_vars_test.go
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
nic-chen commented on issue #856:
URL:
https://github.com/apache/apisix-dashboard/issues/856#issuecomment-734784304
It may be the default value from json schema problem
This is an automated message from the Apache Git
membphis commented on issue #896:
URL:
https://github.com/apache/apisix-dashboard/issues/896#issuecomment-734783445
thid bug still not fixed?
This is an automated message from the Apache Git Service.
To respond to the
juzhiyuan edited a comment on pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#issuecomment-734777032
hah the `WIP` flag is usually used in GitLab, we could convert this issue to
draft by clicking that link if needed:
codecov-io commented on pull request #897:
URL: https://github.com/apache/apisix-dashboard/pull/897#issuecomment-734777124
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/897?src=pr=h1)
Report
> Merging
juzhiyuan commented on pull request #895:
URL: https://github.com/apache/apisix-dashboard/pull/895#issuecomment-734777032
hah the `WIP` flag is usually used in GitLab, we could convert this issue to
draft by clicking that link:
idbeta opened a new pull request #897:
URL: https://github.com/apache/apisix-dashboard/pull/897
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] E2E test
- [ ] New feature provided
- [ ] Improve performance
- Related
nic-chen opened a new issue #896:
URL: https://github.com/apache/apisix-dashboard/issues/896
# Bug report
## Describe the bug
`admin api` supports the id field as string and int type, `manager api` only
supports string,
which will cause the data with int type id entered
idbeta commented on issue #728:
URL:
https://github.com/apache/apisix-dashboard/issues/728#issuecomment-734774685
here is test case
```
{
caseDesc: "delete upstream - being used by route 1",
Object: MangerApiExpect(t),
Method:
tokers commented on issue #2853:
URL: https://github.com/apache/apisix/issues/2853#issuecomment-734774128
> > > Do we need to update the `lua-resty-etcd`?
> >
> >
> > Yep, we shall.
>
> So do we need to add a new API to read etcd by range?
I glanced the description
membphis commented on pull request #2874:
URL: https://github.com/apache/apisix/pull/2874#issuecomment-734766434
nice catch
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander merged pull request #2817:
URL: https://github.com/apache/apisix/pull/2817
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #2501:
URL: https://github.com/apache/apisix/issues/2501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new d7e5911 feat: How to distinguish whether
spacewander commented on a change in pull request #2877:
URL: https://github.com/apache/apisix/pull/2877#discussion_r531505568
##
File path: doc/zh-cn/plugin-develop.md
##
@@ -163,7 +163,7 @@ local _M = {
该插件在 rewrite 、access 阶段执行都可以，项目中是用 rewrite 阶段执行认证逻辑，一般 IP 准入、接口权限是在
wfnuser commented on issue #2853:
URL: https://github.com/apache/apisix/issues/2853#issuecomment-734757643
Do you have slack channels. I might have a lot of questions.
This is an automated message from the Apache Git
wfnuser commented on issue #2853:
URL: https://github.com/apache/apisix/issues/2853#issuecomment-734757322
> > Do we need to update the `lua-resty-etcd`?
>
> Yep, we shall.
So do we need to add a new API to read etcd by range?
idbeta opened a new issue #2878:
URL: https://github.com/apache/apisix/issues/2878
### Issue description
create with vars which operator was wrong, but APISIX still returns 200 and
insert to etcd.
### Environment
* apisix version (cmd: `apisix version`): master
* OS:
spacewander closed issue #2873:
URL: https://github.com/apache/apisix/issues/2873
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1 - 100 of 147 matches
Mail list logo
