[GitHub] [apisix-dashboard] moonming commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
moonming commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735356525 why we need apisix as prefix? YuanSheng Wang 于2020年11月29日 周日下午2:10写道: > Could we use something like /api/xxx in the future? because admin API > will be deprec

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #894: test: add e2e test cases for route with metric plugin

2020-11-28 Thread GitBox
nic-chen commented on a change in pull request #894: URL: https://github.com/apache/apisix-dashboard/pull/894#discussion_r532169784 ## File path: api/test/e2e/route_with_metric_plugin_test.go ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[apisix] branch v2.1 updated (4e82d55 -> 1deace9)

2020-11-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch v2.1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4e82d55 release: release 2.1 version. add 1deace9 fix No new revisions were added by this update. Summary of

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #892: test: add e2e test cases for route with log plugin

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #892: URL: https://github.com/apache/apisix-dashboard/pull/892#issuecomment-734637834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/892?src=pr&el=h1) Report > Merging [#892](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #892: test: add e2e test cases for route with log plugin

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #892: URL: https://github.com/apache/apisix-dashboard/pull/892#issuecomment-734637834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/892?src=pr&el=h1) Report > Merging [#892](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #892: test: add e2e test cases for route with log plugin

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #892: URL: https://github.com/apache/apisix-dashboard/pull/892#issuecomment-734637834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/892?src=pr&el=h1) Report > Merging [#892](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] 96RadhikaJadhav opened a new pull request #2890: Corrected the link

2020-11-28 Thread GitBox
96RadhikaJadhav opened a new pull request #2890: URL: https://github.com/apache/apisix/pull/2890 ### What this PR does / why we need it: It will direct the existing link to the correct one. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
juzhiyuan commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735353115 > > Could we use something like `/api/xxx` in the future? because admin API will be deprecated. > > need to add prefix `/apisix/` It's strange to see apisi

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #892: test: add e2e test cases for route with log plugin

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #892: URL: https://github.com/apache/apisix-dashboard/pull/892#issuecomment-734637834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/892?src=pr&el=h1) Report > Merging [#892](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #900: feat: add version info into manager-api

2020-11-28 Thread GitBox
juzhiyuan commented on a change in pull request #900: URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r532165568 ## File path: api/VERSION ## @@ -0,0 +1 @@ +v2.1-rc1 Review comment: Got it, we may have this tip to release guide 😃 ---

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
juzhiyuan commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735352878 🤔 when will the version be upgraded? This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #900: feat: add version info into manager-api

2020-11-28 Thread GitBox
starsz commented on a change in pull request #900: URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r532165217 ## File path: api/VERSION ## @@ -0,0 +1 @@ +v2.1-rc1 Review comment: Yeah. It's important. I had checked the apisix project. It needs to up

[GitHub] [apisix] tzssangglass commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-11-28 Thread GitBox
tzssangglass commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r532164938 ## File path: doc/zh-cn/admin-api.md ## @@ -723,3 +723,15 @@ Content-Type: text/plain ``` [Back to TOC](#目录) + +*地址*:/apisix/admin/plugins/meta_at

[GitHub] [apisix-dashboard] membphis commented on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
membphis commented on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735351866 > `api/test/e2e/id_compatible_test.go` looks good for me for the source code, need @gxthrj @ShiningRush @tokers @spacewander help ^_^

[GitHub] [apisix] membphis commented on a change in pull request #2887: release: release 2.1 version.

2020-11-28 Thread GitBox
membphis commented on a change in pull request #2887: URL: https://github.com/apache/apisix/pull/2887#discussion_r532163945 ## File path: README.md ## @@ -167,10 +165,9 @@ There are several ways to install the Apache Release version of APISIX: - Installation runtime depend

[GitHub] [apisix] tzssangglass edited a comment on pull request #2886: feat: provide the ability to view plug-in types

2020-11-28 Thread GitBox
tzssangglass edited a comment on pull request #2886: URL: https://github.com/apache/apisix/pull/2886#issuecomment-735350940 yes, i get the CI tip. but the following case can be tested successfully in my local, and CI tested failed ``` --- response_body eval qr/{"priority":0,"t

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #900: feat: add version info into manager-api

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #900: URL: https://github.com/apache/apisix-dashboard/pull/900#issuecomment-735216654 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/900?src=pr&el=h1) Report > Merging [#900](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] membphis commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-11-28 Thread GitBox
membphis commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r532163386 ## File path: doc/zh-cn/admin-api.md ## @@ -723,3 +723,15 @@ Content-Type: text/plain ``` [Back to TOC](#目录) + +*地址*:/apisix/admin/plugins/meta_attrib

[GitHub] [apisix] tzssangglass commented on pull request #2886: feat: provide the ability to view plug-in types

2020-11-28 Thread GitBox
tzssangglass commented on pull request #2886: URL: https://github.com/apache/apisix/pull/2886#issuecomment-735350940 yes, i get the CI tip. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #904: feat: support disable property for json schema according to APISIX's change

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#issuecomment-735344204 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/904?src=pr&el=h1) Report > Merging [#904](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] membphis commented on pull request #2886: feat: provide the ability to view plug-in types

2020-11-28 Thread GitBox
membphis commented on pull request #2886: URL: https://github.com/apache/apisix/pull/2886#issuecomment-735349579 > @membphis The error is reported in CI, but not when I run it locally, what conditions do I need to add to my local test environment to reproduce this? > https://github.com/

[GitHub] [apisix-dashboard] membphis commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
membphis commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735349443 > Could we use something like `/api/xxx` in the future? because admin API will be deprecated. need to add prefix `/apisix/` -

[GitHub] [apisix-dashboard] membphis commented on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
membphis commented on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735349358 `api/test/e2e/id_compatible_test.go` looks good for me. I think we can turn this PR to `ready` @nic-chen --

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #893: test: add route with priority

2020-11-28 Thread GitBox
membphis commented on a change in pull request #893: URL: https://github.com/apache/apisix-dashboard/pull/893#discussion_r532160585 ## File path: api/test/e2e/route_with_priority_test.go ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix] moonming commented on pull request #2887: release: release 2.1 version.

2020-11-28 Thread GitBox
moonming commented on pull request #2887: URL: https://github.com/apache/apisix/pull/2887#issuecomment-735348312 added Thanks, Ming Wen Twitter: _WenMing 罗泽轩 于2020年11月29日周日 上午11:43写道: > *@spacewander* commented on this pull request. > --

[GitHub] [apisix] moonming commented on a change in pull request #2887: release: release 2.1 version.

2020-11-28 Thread GitBox
moonming commented on a change in pull request #2887: URL: https://github.com/apache/apisix/pull/2887#discussion_r532160205 ## File path: rockspec/apisix-2.1-0.rockspec ## @@ -0,0 +1,77 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributo

[apisix] branch v2.1 updated (c0f3f73 -> 4e82d55)

2020-11-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch v2.1 in repository https://gitbox.apache.org/repos/asf/apisix.git. discard c0f3f73 release: release 2.1 version. add 4e82d55 release: release 2.1 version. This update added new revision

[GitHub] [apisix] willmafh commented on a change in pull request #2869: fix: start server failure

2020-11-28 Thread GitBox
willmafh commented on a change in pull request #2869: URL: https://github.com/apache/apisix/pull/2869#discussion_r532158031 ## File path: Makefile ## @@ -86,6 +86,8 @@ run: default ifeq ("$(wildcard logs/nginx.pid)", "") mkdir -p logs $(OR_EXEC) -p $$PWD/ -c $$

[GitHub] [apisix-dashboard] starsz commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
starsz commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735344829 Agree +1. This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-dashboard] codecov-io commented on pull request #904: feat: support disable property for json schema according to APISIX's change

2020-11-28 Thread GitBox
codecov-io commented on pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#issuecomment-735344204 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/904?src=pr&el=h1) Report > Merging [#904](https://codecov.io/gh/apache/apisix-dashboard/pull/904?src

[GitHub] [apisix-dashboard] gxthrj commented on issue #896: bug: manager api does not support int for field `id`

2020-11-28 Thread GitBox
gxthrj commented on issue #896: URL: https://github.com/apache/apisix-dashboard/issues/896#issuecomment-735344134 > In order to fix this bug quickly, I am going to change the ID field type to interface, perform type conversion during input, and convert int to a string so that when APISIX

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #904: feat: support disable property for json schema according to APISIX's change

2020-11-28 Thread GitBox
nic-chen opened a new pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix] gxthrj commented on issue #2881: request help: problem to access etcd when deploy on kubernetes

2020-11-28 Thread GitBox
gxthrj commented on issue #2881: URL: https://github.com/apache/apisix/issues/2881#issuecomment-735343963 @Yiyiyimu Please show the `svc` of etcd in default namespace. The config.yaml as below, make sure the svc name is `etcd-cluster-client` ```yaml etcd: host: - "http:/

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
juzhiyuan commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735343879 Agree, how about you? @membphis @liuxiran This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #894: test: add e2e test cases for route with metric plugin

2020-11-28 Thread GitBox
gxthrj commented on a change in pull request #894: URL: https://github.com/apache/apisix-dashboard/pull/894#discussion_r532155704 ## File path: api/test/e2e/route_with_metric_plugin_test.go ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-dashboard] moonming commented on pull request #874: test: add route with invalid remote_addr

2020-11-28 Thread GitBox
moonming commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-735343347 > ping @moonming As I said days before, these checks should be the work of json chema. Is there a problem with the json schema that can't be verified?

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #874: test: add route with invalid remote_addr

2020-11-28 Thread GitBox
moonming commented on a change in pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#discussion_r532155367 ## File path: api/test/e2e/route_e2e_remote_addr_test.go ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[apisix] branch feat/status updated (e35a156 -> 6bea303)

2020-11-28 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch feat/status in repository https://gitbox.apache.org/repos/asf/apisix.git. from e35a156 fix: keep the require statement for ngx.process inside http subsystem add 6bea303 fix: required

[GitHub] [apisix] tzssangglass commented on pull request #2886: feat: provide the ability to view plug-in types

2020-11-28 Thread GitBox
tzssangglass commented on pull request #2886: URL: https://github.com/apache/apisix/pull/2886#issuecomment-735342010 @membphis The error is reported in CI, but not when I run it locally, what conditions do I need to add to my local test environment to reproduce this? https://github.com/

[apisix] branch feat/status updated (24de385 -> e35a156)

2020-11-28 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch feat/status in repository https://gitbox.apache.org/repos/asf/apisix.git. from 24de385 fix: bad server_info module prefix add e35a156 fix: keep the require statement for ngx.process in

[GitHub] [apisix] spacewander commented on a change in pull request #2887: release: release 2.1 version.

2020-11-28 Thread GitBox
spacewander commented on a change in pull request #2887: URL: https://github.com/apache/apisix/pull/2887#discussion_r532150086 ## File path: CHANGELOG.md ## @@ -32,6 +33,33 @@ - [0.7.0](#070) - [0.6.0](#060) +## 2.1.0 + +### Core +- :sunrise: **support ENV variable in confi

[GitHub] [apisix-dashboard] tokers commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
tokers commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735338561 > Could we use something like `/api/xxx` in the future? because admin API will be deprecated. Maybe add the version is better? Like `/api/v1/xxx`, so that the API migra

[GitHub] [apisix] spacewander merged pull request #2877: fix: Synchronize with english doc

2020-11-28 Thread GitBox
spacewander merged pull request #2877: URL: https://github.com/apache/apisix/pull/2877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: fix: Synchronize with english doc (#2877)

2020-11-28 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new ce1d40b fix: Synchronize with english doc

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
juzhiyuan commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735337858 Could we use something like `/api/xxx` in the future? because admin API will be deprecated. This is an aut

[GitHub] [apisix-dashboard] tokers commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
tokers commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735328983 > LGTM, but should we still keep the `/apisix/admin`prefix? Maybe the `admin` section could be removed.

[apisix] branch feat/status updated (d298474 -> 24de385)

2020-11-28 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch feat/status in repository https://gitbox.apache.org/repos/asf/apisix.git. from d298474 fix: fixed broken markdown links and test cases failure add 24de385 fix: bad server_info module p

[apisix] branch feat/status updated (34276cb -> d298474)

2020-11-28 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch feat/status in repository https://gitbox.apache.org/repos/asf/apisix.git. from 34276cb feat: server info add d298474 fix: fixed broken markdown links and test cases failure No new rev

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735237768 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/902?src=pr&el=h1) Report > Merging [#902](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] tokers commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-28 Thread GitBox
tokers commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-735320711 > > That's really awkward since etcd misses this option in the command line help message, just use this option: `--enable-grpc-gateway`. > > Could it be added to the APISIX docum

[GitHub] [apisix] dabue commented on pull request #2592: feat: implement `error-log-logger` plug-in

2020-11-28 Thread GitBox
dabue commented on pull request #2592: URL: https://github.com/apache/apisix/pull/2592#issuecomment-735320201 @membphis @spacewander please review again, thx. This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #874: test: add route with invalid remote_addr

2020-11-28 Thread GitBox
juzhiyuan commented on pull request #874: URL: https://github.com/apache/apisix-dashboard/pull/874#issuecomment-735320051 ping @moonming This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #893: test: add route with priority

2020-11-28 Thread GitBox
juzhiyuan commented on a change in pull request #893: URL: https://github.com/apache/apisix-dashboard/pull/893#discussion_r532132994 ## File path: api/test/e2e/route_with_priority_test.go ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735237768 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/902?src=pr&el=h1) Report > Merging [#902](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #902: fix: make field ID compatible with both string and int

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #902: URL: https://github.com/apache/apisix-dashboard/pull/902#issuecomment-735237768 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/902?src=pr&el=h1) Report > Merging [#902](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-website] juzhiyuan commented on issue #90: Support Google Analytics

2020-11-28 Thread GitBox
juzhiyuan commented on issue #90: URL: https://github.com/apache/apisix-website/issues/90#issuecomment-735313277 Got it, cc @moonming This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-website] juzhiyuan closed issue #90: Support Google Analytics

2020-11-28 Thread GitBox
juzhiyuan closed issue #90: URL: https://github.com/apache/apisix-website/issues/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on issue #2843: doc: wrong link

2020-11-28 Thread GitBox
membphis commented on issue #2843: URL: https://github.com/apache/apisix/issues/2843#issuecomment-735311376 > @membphis Could you please guide me the path to the file where this link can be changed? https://github.com/apache/apisix/blob/master/doc/architecture-design.md#table-of-co

[GitHub] [apisix-dashboard] membphis commented on issue #495: Using Disable property from APISIX for Plugin

2020-11-28 Thread GitBox
membphis commented on issue #495: URL: https://github.com/apache/apisix-dashboard/issues/495#issuecomment-735310368 > Looks like it need to modify the code to achieve it? yes, you can take a look at the processes of APISIX ---

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #893: test: add route with priority

2020-11-28 Thread GitBox
membphis commented on a change in pull request #893: URL: https://github.com/apache/apisix-dashboard/pull/893#discussion_r532123186 ## File path: api/test/e2e/route_with_priority_test.go ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-website] justinmclean commented on issue #90: Support Google Analytics

2020-11-28 Thread GitBox
justinmclean commented on issue #90: URL: https://github.com/apache/apisix-website/issues/90#issuecomment-735308527 Due to privacy concerns it strongly suggested that you don't add Google Analytics to your site. It's likely that at some point in the near future that all ASF projects will b

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #897: test: add cHash upstream (E2E)

2020-11-28 Thread GitBox
nic-chen commented on a change in pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r532121800 ## File path: api/test/e2e/upstream_test.go ## @@ -188,10 +188,63 @@ func TestRoute_Node_Host(t *testing.T) { } } -//TODO cHash +func T

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #893: test: add route with priority

2020-11-28 Thread GitBox
nic-chen commented on a change in pull request #893: URL: https://github.com/apache/apisix-dashboard/pull/893#discussion_r532121656 ## File path: api/test/e2e/route_with_priority_test.go ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-dashboard] nic-chen merged pull request #888: test: add route with uri or uris ( E2E )

2020-11-28 Thread GitBox
nic-chen merged pull request #888: URL: https://github.com/apache/apisix-dashboard/pull/888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated: test: add route with uri or uris ( E2E ) (#888)

2020-11-28 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 478cbeb test: add route with uri o

[apisix-dashboard] branch master updated: test: add route with valid remote_address (E2E) (#884)

2020-11-28 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 8755d1c test: add route with valid

[GitHub] [apisix-dashboard] nic-chen merged pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
nic-chen merged pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] moonming commented on issue #2889: [DISCUSS]: requires a doc to display secondary endpoints in apisix

2020-11-28 Thread GitBox
moonming commented on issue #2889: URL: https://github.com/apache/apisix/issues/2889#issuecomment-735307057 sure,welcome pr This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-dashboard] moonming commented on pull request #895: test: add route with vars ( E2E )

2020-11-28 Thread GitBox
moonming commented on pull request #895: URL: https://github.com/apache/apisix-dashboard/pull/895#issuecomment-735306478 > is this pr will close #633? any response? This is an automated message from the Apache Git Serv

[GitHub] [apisix-dashboard] nic-chen commented on issue #495: Using Disable property from APISIX for Plugin

2020-11-28 Thread GitBox
nic-chen commented on issue #495: URL: https://github.com/apache/apisix-dashboard/issues/495#issuecomment-735305568 Looks like it need to modify the code to achieve it? I thought the schema had been modified before. This is

[GitHub] [apisix] 96RadhikaJadhav commented on issue #2843: doc: wrong link

2020-11-28 Thread GitBox
96RadhikaJadhav commented on issue #2843: URL: https://github.com/apache/apisix/issues/2843#issuecomment-735254799 @membphis Could you please guide me the path to the file where this link can be changed? This is an automate

[GitHub] [apisix] idbeta commented on issue #2695: request help: config_etcd.lua has been consistently and frequently reporting errors

2020-11-28 Thread GitBox
idbeta commented on issue #2695: URL: https://github.com/apache/apisix/issues/2695#issuecomment-735252985 > That's really awkward since etcd misses this option in the command line help message, just use this option: `--enable-grpc-gateway`. Could it be added to the APISIX documentati

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #888: test: add route with uri or uris ( E2E )

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #888: URL: https://github.com/apache/apisix-dashboard/pull/888#issuecomment-734663219 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/888?src=pr&el=h1) Report > Merging [#888](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r532056811 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -24,7 +24,7 @@ import ( func TestRoute_with_vaild_remote_addr(t *testing.T) {

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r532056800 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #884: test: add route with valid remote_address (E2E)

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #884: URL: https://github.com/apache/apisix-dashboard/pull/884#discussion_r532056762 ## File path: api/test/e2e/route_with_vaild_remote_addr.go ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #888: test: add route with uri or uris ( E2E )

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #888: URL: https://github.com/apache/apisix-dashboard/pull/888#discussion_r532056725 ## File path: api/test/e2e/route_with_uri_uris_test.go ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #895: test: add route with vars ( E2E )

2020-11-28 Thread GitBox
codecov-io edited a comment on pull request #895: URL: https://github.com/apache/apisix-dashboard/pull/895#issuecomment-734730162 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/895?src=pr&el=h1) Report > Merging [#895](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #888: test: add route with uri or uris ( E2E )

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #888: URL: https://github.com/apache/apisix-dashboard/pull/888#discussion_r532056153 ## File path: api/test/e2e/route_with_uri_uris_test.go ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #900: feat: add version info into manager-api

2020-11-28 Thread GitBox
juzhiyuan commented on a change in pull request #900: URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r532056005 ## File path: api/VERSION ## @@ -0,0 +1 @@ +v2.1-rc1 Review comment: Do we have to modify this file before releasing it? The release mana

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #895: test: add route with vars ( E2E )

2020-11-28 Thread GitBox
idbeta commented on a change in pull request #895: URL: https://github.com/apache/apisix-dashboard/pull/895#discussion_r532056055 ## File path: api/test/e2e/route_with_vars_test.go ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #900: feat: add version info into manager-api

2020-11-28 Thread GitBox
juzhiyuan commented on a change in pull request #900: URL: https://github.com/apache/apisix-dashboard/pull/900#discussion_r532056005 ## File path: api/VERSION ## @@ -0,0 +1 @@ +v2.1-rc1 Review comment: 🤔 Do we have to modify this file before releasing it? The release m

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #898: fix(Plugin): use codemirror instead of form in plugin module

2020-11-28 Thread GitBox
juzhiyuan commented on a change in pull request #898: URL: https://github.com/apache/apisix-dashboard/pull/898#discussion_r532055377 ## File path: web/src/components/Plugin/data.tsx ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #853: feat: show some important information after started the `manager-api`

2020-11-28 Thread GitBox
juzhiyuan edited a comment on issue #853: URL: https://github.com/apache/apisix-dashboard/issues/853#issuecomment-735249090 🤔 `Listen on` and `Log path`would be better IMO, but still looks good to me. This is an automated me

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #853: feat: show some important information after started the `manager-api`

2020-11-28 Thread GitBox
juzhiyuan commented on issue #853: URL: https://github.com/apache/apisix-dashboard/issues/853#issuecomment-735249090 🤔 `Listen on` and `Log path`would be better IMO This is an automated message from the Apache Git Service. T

[GitHub] [apisix-helm-chart] gxthrj opened a new issue #5: Request help: need to add dependence chart, such as etcd

2020-11-28 Thread GitBox
gxthrj opened a new issue #5: URL: https://github.com/apache/apisix-helm-chart/issues/5 Since the release of Apache APISIX version 2.0, etcd has been adjusted from v2 to v3. We need to explicitly indicate dependencies in the chart to prevent users from reporting errors during the upgra

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
juzhiyuan commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735248913 LGTM, but should we still keep the `/apisix/admin`prefix? This is an automated message from the Apache Git

[GitHub] [apisix] supermario1990 commented on a change in pull request #2877: fix: Synchronize with english doc

2020-11-28 Thread GitBox
supermario1990 commented on a change in pull request #2877: URL: https://github.com/apache/apisix/pull/2877#discussion_r532054618 ## File path: doc/zh-cn/plugin-develop.md ## @@ -163,7 +163,7 @@ local _M = { 该插件在 rewrite 、access 阶段执行都可以,项目中是用 rewrite 阶段执行认证逻辑,一般 IP 准入、接口权限是在 a

[GitHub] [apisix-helm-chart] gxthrj opened a new pull request #4: WIP: adjustments for APISIX 2.1 release

2020-11-28 Thread GitBox
gxthrj opened a new pull request #4: URL: https://github.com/apache/apisix-helm-chart/pull/4 Changes: 1. Add `namespace` for Kinds. 2. Explicit configure `allow_admin` in `configmap`, because the `allow_admin` in `config.default.yaml` is configured. 3. Adjust `etcd` default config

[GitHub] [apisix] tzssangglass opened a new issue #2889: [DISCUSS]: requires a doc to display all endpoints in apisix

2020-11-28 Thread GitBox
tzssangglass opened a new issue #2889: URL: https://github.com/apache/apisix/issues/2889 I found that some admin API provided by apisix are not found in any documentation, such as `/apisix/admin/plugins/list`, so do we need a doc to keep track of the admin API that is nowhere to put?

[GitHub] [apisix] tzssangglass commented on issue #2810: [DISCUSS]: allow user to specify APISIX id in config.yaml

2020-11-28 Thread GitBox
tzssangglass commented on issue #2810: URL: https://github.com/apache/apisix/issues/2810#issuecomment-735246368 > I have assigned this job to you @tzssangglass > good luck ^_^ ok This is an automated message from th

[GitHub] [apisix] membphis commented on issue #2810: [DISCUSS]: allow user to specify APISIX id in config.yaml

2020-11-28 Thread GitBox
membphis commented on issue #2810: URL: https://github.com/apache/apisix/issues/2810#issuecomment-735246232 I have assigned this job to you @tzssangglass good luck ^_^ This is an automated message from the Apache Git Serv

[apisix-helm-chart] 01/01: WIP: adjustments for APISIX 2.1 release

2020-11-28 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch kv/2.1 in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git commit 3bae680d97d6490f3fd4ed848009691a92bc2f96 Author: kv AuthorDate: Sat Nov 28 23:38:52 2020 +0800 WIP: adjustm

[apisix-helm-chart] branch kv/2.1 created (now 3bae680)

2020-11-28 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch kv/2.1 in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git. at 3bae680 WIP: adjustments for APISIX 2.1 release This branch includes the following new commits: new 3

[GitHub] [apisix-dashboard] starsz commented on issue #849: backend APISIX instance status API

2020-11-28 Thread GitBox
starsz commented on issue #849: URL: https://github.com/apache/apisix-dashboard/issues/849#issuecomment-735246051 Hi, I think the API may like this. ``` GET /apisix/admin/server_info/{id} ``` ResponseBody ``` { "up_time": 10, "last_report_time": 1606539

[GitHub] [apisix] membphis commented on a change in pull request #2887: release: release 2.1 version.

2020-11-28 Thread GitBox
membphis commented on a change in pull request #2887: URL: https://github.com/apache/apisix/pull/2887#discussion_r532052726 ## File path: rockspec/apisix-2.1-0.rockspec ## @@ -0,0 +1,77 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributo

[GitHub] [apisix] tzssangglass commented on issue #2810: [DISCUSS]: allow user to specify APISIX id in config.yaml

2020-11-28 Thread GitBox
tzssangglass commented on issue #2810: URL: https://github.com/apache/apisix/issues/2810#issuecomment-735245263 Let me try. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] membphis commented on pull request #2592: feat: implement `error-log-logger` plug-in

2020-11-28 Thread GitBox
membphis commented on pull request #2592: URL: https://github.com/apache/apisix/pull/2592#issuecomment-735245074 @dabue you need to rebase your branch This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] membphis commented on issue #2843: doc: wrong link

2020-11-28 Thread GitBox
membphis commented on issue #2843: URL: https://github.com/apache/apisix/issues/2843#issuecomment-735244948 @96RadhikaJadhav that is a todo job. welcome to fix this issue This is an automated message from the Apache Git Servi

[GitHub] [apisix] membphis closed issue #2888: ci: Failed to connect to 127.0.0.1 port 9180: Connection refused

2020-11-28 Thread GitBox
membphis closed issue #2888: URL: https://github.com/apache/apisix/issues/2888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

  1   2   >