[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #904: feat: support disable property for json schema according to APISIX's change

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#discussion_r533962675 ## File path: api/internal/core/store/validate.go ## @@ -238,22 +238,37 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{}) error {

[GitHub] [apisix-dashboard] membphis merged pull request #945: test: config route with management fileds (E2E)

2020-12-01 Thread GitBox
membphis merged pull request #945: URL: https://github.com/apache/apisix-dashboard/pull/945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated (3739e27 -> eaabe03)

2020-12-01 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 3739e27 test: e2e test chash upstream with key (remote_addr) (#897) add eaabe03 test: config rout

[GitHub] [apisix-dashboard] membphis merged pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
membphis merged pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated: test: e2e test chash upstream with key (remote_addr) (#897)

2020-12-01 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 3739e27 test: e2e test chash upstre

[GitHub] [apisix-dashboard] membphis commented on issue #938: panic: dial udp 8.8.8.8:80: connect: network is unreachable

2020-12-01 Thread GitBox
membphis commented on issue #938: URL: https://github.com/apache/apisix-dashboard/issues/938#issuecomment-737058417 @lin2627 you can make a try with the latest master branch. please feel free to reopen this issue if you still have this issue --

[GitHub] [apisix-dashboard] membphis merged pull request #947: fix: snowflake remove network dependency

2020-12-01 Thread GitBox
membphis merged pull request #947: URL: https://github.com/apache/apisix-dashboard/pull/947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-dashboard] membphis closed issue #938: panic: dial udp 8.8.8.8:80: connect: network is unreachable

2020-12-01 Thread GitBox
membphis closed issue #938: URL: https://github.com/apache/apisix-dashboard/issues/938 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated: fix: snowflake remove network dependency (#947)

2020-12-01 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 3123c43 fix: snowflake remove netwo

[GitHub] [apisix] membphis commented on issue #2864: request help: highly available deployment scheme for APISIX

2020-12-01 Thread GitBox
membphis commented on issue #2864: URL: https://github.com/apache/apisix/issues/2864#issuecomment-737057431 @liuxiran you can take a look at this article: https://www.upyun.com/opentalk/440.html This is an automated

[GitHub] [apisix] membphis closed issue #2864: request help: highly available deployment scheme for APISIX

2020-12-01 Thread GitBox
membphis closed issue #2864: URL: https://github.com/apache/apisix/issues/2864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] spacewander closed issue #2908: bug: use openid-connect plugin https error

2020-12-01 Thread GitBox
spacewander closed issue #2908: URL: https://github.com/apache/apisix/issues/2908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] nic-chen commented on pull request #945: test: config route with management fileds (E2E)

2020-12-01 Thread GitBox
nic-chen commented on pull request #945: URL: https://github.com/apache/apisix-dashboard/pull/945#issuecomment-737054341 LGTM Except for some code format issues. This is an automated message from the Apache Git Service. T

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r533954451 ## File path: api/test/e2e/upstream_test.go ## @@ -188,10 +191,198 @@ func TestRoute_Node_Host(t *testing.T) { } } -//TODO cHash -//TODO

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r533952686 ## File path: api/test/e2e/upstream_test.go ## @@ -188,10 +191,198 @@ func TestRoute_Node_Host(t *testing.T) { } } -//TODO cHash -//TODO

[apisix] branch master updated (a019b4e -> bbbd10e)

2020-12-01 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from a019b4e test: improve chash-balance cases (#2920) add bbbd10e feat: validate the operator in vars (#2911)

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #936: test: e2e test chash upstream hash on (consumer, header, cookie)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #936: URL: https://github.com/apache/apisix-dashboard/pull/936#discussion_r533952356 ## File path: api/test/e2e/upstream_chash_hash_on_test.go ## @@ -0,0 +1,381 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix] spacewander merged pull request #2911: feat: validate the operator in vars

2020-12-01 Thread GitBox
spacewander merged pull request #2911: URL: https://github.com/apache/apisix/pull/2911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #2878: request help: should strengthen the verification of operators

2020-12-01 Thread GitBox
spacewander closed issue #2878: URL: https://github.com/apache/apisix/issues/2878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #932: test: e2e test chash upstream with key (query_string, arg_xxx)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#discussion_r533951063 ## File path: api/test/e2e/upstream_chash_query_string_arg_xxx_test.go ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] backnero commented on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
backnero commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-737047384 ![image](https://user-images.githubusercontent.com/21979871/100841675-94311600-34b2-11eb-87bc-93efc876c39d.png) V2.0 image is updated

[GitHub] [apisix] backnero commented on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
backnero commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-737046508 ``` 2020/12/02 07:20:29 [warn] 14#14: *10 [lua] init.lua:262: sync_local_conf_to_etcd(): sync local conf to etcd, context: ngx.timer 2020/12/02 07:20:29 [error] 14#14: *10 [lua]

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #947: fix: snowflake remove network dependency

2020-12-01 Thread GitBox
ShiningRush commented on a change in pull request #947: URL: https://github.com/apache/apisix-dashboard/pull/947#discussion_r533945810 ## File path: api/internal/utils/utils.go ## @@ -37,35 +38,50 @@ func init() { } salt = uint16(i) } - +

[GitHub] [apisix-dashboard] nic-chen commented on pull request #932: test: e2e test chash upstream with key (query_string, arg_xxx)

2020-12-01 Thread GitBox
nic-chen commented on pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#issuecomment-737045775 ping @idbeta This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
nic-chen commented on a change in pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r533944507 ## File path: api/test/e2e/upstream_test.go ## @@ -188,10 +191,198 @@ func TestRoute_Node_Host(t *testing.T) { } } -//TODO cHash -//TOD

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
nic-chen commented on a change in pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#discussion_r533944507 ## File path: api/test/e2e/upstream_test.go ## @@ -188,10 +191,198 @@ func TestRoute_Node_Host(t *testing.T) { } } -//TODO cHash -//TOD

[GitHub] [apisix] backnero commented on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
backnero commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-737044901 The same configuration, image. I have used it for nearly half a month. During the period, the application will be restarted regularly, and this error did not appear. This error began

[GitHub] [apisix-dashboard] nic-chen commented on pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
nic-chen commented on pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#issuecomment-737044040 LGTM Except for some code format issues. This is an automated message from the Apache Git Service. T

[GitHub] [apisix] backnero commented on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
backnero commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-737043932 > i tried change ssl enable to "false" in config.yaml ,and apisix is no longer supported https access . > > look config-default.yaml ,add ssl config below > # ssl_cert: /pat

[GitHub] [apisix] tokers commented on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
tokers commented on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-737043492 Agree with @spacewander 's point, we should differentiate empty array and nil, we may need to apply some default manner when a field is empty, treating it as same as empty array is jus

[GitHub] [apisix] idbeta commented on issue #2883: request help: 配置 jwt-auth 插件 获取 token的时候报错

2020-12-01 Thread GitBox
idbeta commented on issue #2883: URL: https://github.com/apache/apisix/issues/2883#issuecomment-737042893 @wenlincheng Can you provide more detailed steps? This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] nic-chen merged pull request #880: test: add consumer test ( E2E )

2020-12-01 Thread GitBox
nic-chen merged pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated (95f2612 -> 9e4c617)

2020-12-01 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 95f2612 CD: auto deploy codes on the master branch to the online demo (#929) add 9e4c617 test: a

[GitHub] [apisix] juzhiyuan edited a comment on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
juzhiyuan edited a comment on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-737041987 A more detailed documentation for manager-api is needed if this change happened on this side 😂 This is an au

[GitHub] [apisix-dashboard] nic-chen commented on pull request #880: test: add consumer test ( E2E )

2020-12-01 Thread GitBox
nic-chen commented on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-737042247 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] juzhiyuan edited a comment on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
juzhiyuan edited a comment on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-737041987 A more detailed documentation for manager-api is needed if this change happened 😂 This is an automated messa

[GitHub] [apisix] juzhiyuan commented on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-737041987 A more detailed documentation for manager-api is needed emm This is an automated message from the Apache Git Service

[GitHub] [apisix] spacewander closed issue #2914: test: some test cases of chash-balance.t are unreasonable

2020-12-01 Thread GitBox
spacewander closed issue #2914: URL: https://github.com/apache/apisix/issues/2914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[apisix] branch master updated: test: improve chash-balance cases (#2920)

2020-12-01 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new a019b4e test: improve chash-balance cases

[GitHub] [apisix] spacewander merged pull request #2920: test: improve chash-balance cases

2020-12-01 Thread GitBox
spacewander merged pull request #2920: URL: https://github.com/apache/apisix/pull/2920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander opened a new pull request #2927: feat(limt-count): use 'remote_addr' as default key

2020-12-01 Thread GitBox
spacewander opened a new pull request #2927: URL: https://github.com/apache/apisix/pull/2927 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have

[GitHub] [apisix-dashboard] gxthrj commented on pull request #947: fix: snowflake remove network dependency

2020-12-01 Thread GitBox
gxthrj commented on pull request #947: URL: https://github.com/apache/apisix-dashboard/pull/947#issuecomment-737040988 > @gxthrj please take a look at the output of CI > > ![image](https://user-images.githubusercontent.com/6814606/100832085-1d8c1c80-34a2-11eb-8c4f-d9971c07bdde.png)

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #947: fix: snowflake remove network dependency

2020-12-01 Thread GitBox
gxthrj commented on a change in pull request #947: URL: https://github.com/apache/apisix-dashboard/pull/947#discussion_r533940352 ## File path: api/internal/utils/utils.go ## @@ -37,10 +38,13 @@ func init() { } salt = uint16(i) } - +

[GitHub] [apisix] idbeta commented on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
idbeta commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-737040323 @gxthrj look at this issue if you have time This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] juzhiyuan commented on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-737039707 After some thought, I agree with your opinion on the data plane, maybe as the bridge between frontend and data source, the manager-api would be more reasonable to take this responsi

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533938622 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scrip

[GitHub] [apisix-dashboard] codecov-io commented on pull request #951: Etcd basic auth

2020-12-01 Thread GitBox
codecov-io commented on pull request #951: URL: https://github.com/apache/apisix-dashboard/pull/951#issuecomment-737038046 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/951?src=pr&el=h1) Report > Merging [#951](https://codecov.io/gh/apache/apisix-dashboard/pull/951?src

[GitHub] [apisix] spacewander commented on issue #2924: [Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
spacewander commented on issue #2924: URL: https://github.com/apache/apisix/issues/2924#issuecomment-73703 Put my disagreement here: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533932864 Yes, but the backends care. This change just shift the duty to the back

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #880: test: add consumer test ( E2E )

2020-12-01 Thread GitBox
codecov-io edited a comment on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-734167166 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/880?src=pr&el=h1) Report > Merging [#880](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] tokers closed pull request #2884: feat: server info

2020-12-01 Thread GitBox
tokers closed pull request #2884: URL: https://github.com/apache/apisix/pull/2884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] tokers commented on pull request #2884: feat: server info

2020-12-01 Thread GitBox
tokers commented on pull request #2884: URL: https://github.com/apache/apisix/pull/2884#issuecomment-737034827 This PR was pushed directly at apache/apisix, i will close it and please see the new one https://github.com/apache/apisix/pull/2926. -

[GitHub] [apisix] tokers opened a new pull request #2926: feat: server info

2020-12-01 Thread GitBox
tokers opened a new pull request #2926: URL: https://github.com/apache/apisix/pull/2926 ### What this PR does / why we need it: Close #2821. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added

[GitHub] [apisix-dashboard] JieTrancender opened a new pull request #951: Etcd basic auth

2020-12-01 Thread GitBox
JieTrancender opened a new pull request #951: URL: https://github.com/apache/apisix-dashboard/pull/951 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - Rel

[GitHub] [apisix] agile6v commented on pull request #2884: feat: server info

2020-12-01 Thread GitBox
agile6v commented on pull request #2884: URL: https://github.com/apache/apisix/pull/2884#issuecomment-737032746 > > @agile6v We can add some limit to the report interval, such as the minimal report interval is 10s. > > agree. I think the minimal report interval can be `1 min`

[GitHub] [apisix-dashboard] spacewander commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
spacewander commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533932864 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scr

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533930714 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scrip

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533930714 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scrip

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #936: test: e2e test chash upstream hash on (consumer, header, cookie)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #936: URL: https://github.com/apache/apisix-dashboard/pull/936#discussion_r533929008 ## File path: api/test/e2e/upstream_chash_hash_on_test.go ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix] spacewander closed issue #1773: bug: skywalking service register failed

2020-12-01 Thread GitBox
spacewander closed issue #1773: URL: https://github.com/apache/apisix/issues/1773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander closed issue #2786: bug: config.yaml problem

2020-12-01 Thread GitBox
spacewander closed issue #2786: URL: https://github.com/apache/apisix/issues/2786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander closed issue #2658: bug: 用plugin-interceptors方法对/apisix/prometheus/metrics目录进行限制无效

2020-12-01 Thread GitBox
spacewander closed issue #2658: URL: https://github.com/apache/apisix/issues/2658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander commented on issue #2658: bug: 用plugin-interceptors方法对/apisix/prometheus/metrics目录进行限制无效

2020-12-01 Thread GitBox
spacewander commented on issue #2658: URL: https://github.com/apache/apisix/issues/2658#issuecomment-737025743 2.1 is released. Feel free to reopen it if it could be reproduced in the master branch. This is an autom

[GitHub] [apisix] spacewander closed issue #2865: request help: a doubt about the clean_handler

2020-12-01 Thread GitBox
spacewander closed issue #2865: URL: https://github.com/apache/apisix/issues/2865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] jaredhuang commented on issue #2912: bug: failed to fetch data from etcd

2020-12-01 Thread GitBox
jaredhuang commented on issue #2912: URL: https://github.com/apache/apisix/issues/2912#issuecomment-737024153 [root@tx-apisix-01 ~]# etcd --version etcd Version: 3.4.13 Git SHA: ae9734ed2 Go Version: go1.12.17 Go OS/Arch: linux/amd64 [root@tx-apisix-01 ~]

[GitHub] [apisix] spacewander opened a new pull request #2925: fix: we should check the length of input before calling memcmp

2020-12-01 Thread GitBox
spacewander opened a new pull request #2925: URL: https://github.com/apache/apisix/pull/2925 To avoid accessing memory which is out of bound. ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR sol

[GitHub] [apisix] membphis commented on pull request #2884: feat: server info

2020-12-01 Thread GitBox
membphis commented on pull request #2884: URL: https://github.com/apache/apisix/pull/2884#issuecomment-737021744 > @agile6v We can add some limit to the report interval, such as the minimal report interval is 10s. agree. I think the minimal report interval can be `1 min` --

[GitHub] [apisix-dashboard] spacewander commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
spacewander commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533924354 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scr

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533922366 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scrip

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533922366 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.scrip

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #950: make api-test filed

2020-12-01 Thread GitBox
juzhiyuan commented on issue #950: URL: https://github.com/apache/apisix-dashboard/issues/950#issuecomment-737018459 cc @idbeta This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] juzhiyuan opened a new issue #2924: [DRAFT][Proposal] Support both empty array and field-omitted for fields like remote_addrs

2020-12-01 Thread GitBox
juzhiyuan opened a new issue #2924: URL: https://github.com/apache/apisix/issues/2924 ## Background TODO ## Solution TODO This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [apisix-dashboard] JieTrancender opened a new issue #950: make api-test filed

2020-12-01 Thread GitBox
JieTrancender opened a new issue #950: URL: https://github.com/apache/apisix-dashboard/issues/950 # Bug report ## Describe the bug I got the newest code of master branch, and then exec `make api-test`. unfortunate, not pass all test. ## How to Reproduce And this

[GitHub] [apisix] tokers commented on pull request #2884: feat: server info

2020-12-01 Thread GitBox
tokers commented on pull request #2884: URL: https://github.com/apache/apisix/pull/2884#issuecomment-737014459 @agile6v We can add some limit to the report interval, such as the minimal report interval is 10s. This is an aut

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #932: test: e2e test chash upstream with key (query_string, arg_xxx)

2020-12-01 Thread GitBox
membphis commented on a change in pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#discussion_r533917324 ## File path: api/test/e2e/upstream_chash_query_string_arg_xxx_test.go ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [apisix-dashboard] membphis commented on pull request #880: test: add consumer with incorrect input ( E2E )

2020-12-01 Thread GitBox
membphis commented on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-737012509 @moonming please review this PR if you have time @idbeta please change the title, your test case is not the same as this title. -

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
liuxiran commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533916316 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.script

[GitHub] [apisix-dashboard] membphis commented on pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
membphis commented on pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#issuecomment-737011245 @nic-chen @moonming @gxthrj @ShiningRush please review this PR if you have time This is an automated me

[GitHub] [apisix-dashboard] membphis commented on pull request #945: test: config route with management fileds (E2E)

2020-12-01 Thread GitBox
membphis commented on pull request #945: URL: https://github.com/apache/apisix-dashboard/pull/945#issuecomment-737010494 @nic-chen @gxthrj @moonming please take a look when you have time This is an automated message from the

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
membphis commented on a change in pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#discussion_r533914202 ## File path: web/src/pages/Route/transform.ts ## @@ -82,6 +82,7 @@ export const transformStepData = ({ !Object.keys(step3DataCloned.script

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #932: test: e2e test chash upstream with key (query_string, arg_xxx)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#discussion_r533911545 ## File path: api/test/e2e/upstream_chash_query_string_arg_xxx_test.go ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #932: test: e2e test chash upstream with key (query_string, arg_xxx)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #932: URL: https://github.com/apache/apisix-dashboard/pull/932#discussion_r533909547 ## File path: api/test/e2e/upstream_chash_query_string_arg_xxx_test.go ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] membphis closed pull request #946: fix: sync json schema to fix the checking of `remote_addrs`

2020-12-01 Thread GitBox
membphis closed pull request #946: URL: https://github.com/apache/apisix-dashboard/pull/946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-dashboard] idbeta commented on pull request #880: test: add consumer with incorrect input ( E2E )

2020-12-01 Thread GitBox
idbeta commented on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-737005424 > @idbeta CI failed: https://github.com/apache/apisix-dashboard/pull/880/checks?check_run_id=1483626371#step:5:85 Because the listening port of `manager-api` has changed

[GitHub] [apisix-dashboard] membphis commented on pull request #880: test: add consumer with incorrect input ( E2E )

2020-12-01 Thread GitBox
membphis commented on pull request #880: URL: https://github.com/apache/apisix-dashboard/pull/880#issuecomment-737002686 @moonming @nic-chen please take a look at this PR This is an automated message from the Apache Git Servi

[GitHub] [apisix-dashboard] membphis commented on pull request #947: fix: snowflake remove network dependency

2020-12-01 Thread GitBox
membphis commented on pull request #947: URL: https://github.com/apache/apisix-dashboard/pull/947#issuecomment-736999759 @gxthrj please take a look at the output of CI ![image](https://user-images.githubusercontent.com/6814606/100832085-1d8c1c80-34a2-11eb-8c4f-d9971c07bdde.png)

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #949: feat: info page

2020-12-01 Thread GitBox
juzhiyuan commented on a change in pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#discussion_r533904811 ## File path: web/src/pages/Info/List.tsx ## @@ -0,0 +1,99 @@ +import React from 'react'; +import { PageContainer } from '@ant-design/pro-layout'

[GitHub] [apisix] lihansir commented on issue #2921: request help: How to use OIDC plugin correctly

2020-12-01 Thread GitBox
lihansir commented on issue #2921: URL: https://github.com/apache/apisix/issues/2921#issuecomment-736999176 > 2、When a request didn't carry an Authorization bearer token Header or the token is error > when the bearer_only is true, it always redirects to 401 page, but can't redirects to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #897: test: e2e test chash upstream with key (remote_addr)

2020-12-01 Thread GitBox
codecov-io edited a comment on pull request #897: URL: https://github.com/apache/apisix-dashboard/pull/897#issuecomment-734777124 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/897?src=pr&el=h1) Report > Merging [#897](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #949: feat: info page

2020-12-01 Thread GitBox
juzhiyuan commented on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-736998704 ![image](https://user-images.githubusercontent.com/2106987/100831841-845d0600-34a1-11eb-9df8-6b8e4d0dc75a.png) for this check, you need to add the Apache Software

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #949: feat: info page

2020-12-01 Thread GitBox
juzhiyuan edited a comment on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-736997856 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #949: feat: info page

2020-12-01 Thread GitBox
juzhiyuan commented on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-736997856 This PR still looks like a draft, let's convert it as draft. This is an automated message from the Apac

[GitHub] [apisix-dashboard] moonming commented on pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
moonming commented on pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#issuecomment-736996501 bad title This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix-dashboard] codecov-io commented on pull request #949: add: Static Info Pages

2020-12-01 Thread GitBox
codecov-io commented on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-736991197 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/949?src=pr&el=h1) Report > Merging [#949](https://codecov.io/gh/apache/apisix-dashboard/pull/949?src

[GitHub] [apisix-dashboard] codecov-io commented on pull request #948: fix: remote_addrs

2020-12-01 Thread GitBox
codecov-io commented on pull request #948: URL: https://github.com/apache/apisix-dashboard/pull/948#issuecomment-736990493 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/948?src=pr&el=h1) Report > Merging [#948](https://codecov.io/gh/apache/apisix-dashboard/pull/948?src

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #859: feat: add a unit test for consumer and remove implicit init

2020-12-01 Thread GitBox
codecov-io edited a comment on pull request #859: URL: https://github.com/apache/apisix-dashboard/pull/859#issuecomment-732124292 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/859?src=pr&el=h1) Report > Merging [#859](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] souzens edited a comment on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
souzens edited a comment on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-736985856 i tried change ssl enable to "false" in config.yaml ,and apisix is no longer supported https access . look config-default.yaml ,add ssl config below # ssl_cert: /

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #945: test: config route with management fileds (E2E)

2020-12-01 Thread GitBox
idbeta commented on a change in pull request #945: URL: https://github.com/apache/apisix-dashboard/pull/945#discussion_r533892699 ## File path: api/test/e2e/route_with_management_fileds_test.go ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix] souzens commented on issue #2923: bug: missing ssl cert for ssl

2020-12-01 Thread GitBox
souzens commented on issue #2923: URL: https://github.com/apache/apisix/issues/2923#issuecomment-736985856 i tried change ssl enable to "false" in config.yaml ,and apisix is no longer supported https access . This is an

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #949: add: Static Info Pages

2020-12-01 Thread GitBox
guoqqqi opened a new pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949 resolve #850 I have made a static page at present. Is the page style like this? I have some questions and need help: 1 When I add an icon to the Info page in the antd component, I don't se

[GitHub] [apisix-dashboard] codecov-io commented on pull request #947: fix: snowflake remove network dependency

2020-12-01 Thread GitBox
codecov-io commented on pull request #947: URL: https://github.com/apache/apisix-dashboard/pull/947#issuecomment-736984311 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/947?src=pr&el=h1) Report > Merging [#947](https://codecov.io/gh/apache/apisix-dashboard/pull/947?src

  1   2   3   4   >