[GitHub] [apisix] oldthreefeng commented on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
oldthreefeng commented on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738625580 > 我测试过老版本,etcd使用v2的接口是没有这个问题的 能给出测试过程的脚本么. @AloneFire This is an automated message from the Apache Git Se

[GitHub] [apisix-dashboard] membphis commented on issue #918: bug: config route with non-existent fields should return 400

2020-12-03 Thread GitBox
membphis commented on issue #918: URL: https://github.com/apache/apisix-dashboard/issues/918#issuecomment-738623980 if we fix #955, then we should fix this issue too This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #958: feat: implement API to get apisix instances status

2020-12-03 Thread GitBox
starsz commented on a change in pull request #958: URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r535896438 ## File path: api/internal/core/entity/entity.go ## @@ -220,3 +220,12 @@ type Script struct { ID string `json:"id"` Script

[GitHub] [apisix-dashboard] chenyicai opened a new issue #965: bug: Modify proxy_rewrite plugin in dashboard,unable to save it

2020-12-03 Thread GitBox
chenyicai opened a new issue #965: URL: https://github.com/apache/apisix-dashboard/issues/965 ### Issue description When i modify proxy_rewrite plugin in dashboard, i can not save it Fill in the configuration, click the confirm button, there is no response ### Environment

[GitHub] [apisix] spacewander opened a new pull request #2968: feat: disable node-status by default

2020-12-03 Thread GitBox
spacewander opened a new pull request #2968: URL: https://github.com/apache/apisix/pull/2968 Fix #2952 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been add

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #964: WIP: Refactor online debug

2020-12-03 Thread GitBox
liuxiran commented on a change in pull request #964: URL: https://github.com/apache/apisix-dashboard/pull/964#discussion_r535886940 ## File path: api/internal/handler/route/route_test.go ## @@ -985,6 +985,32 @@ func TestRoute(t *testing.T) { _, err = handler.BatchDelete

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #964: WIP: Refactor online debug

2020-12-03 Thread GitBox
nic-chen commented on a change in pull request #964: URL: https://github.com/apache/apisix-dashboard/pull/964#discussion_r535881379 ## File path: api/internal/handler/route/route_test.go ## @@ -985,6 +985,32 @@ func TestRoute(t *testing.T) { _, err = handler.BatchDelete

[GitHub] [apisix] Ben0625 commented on issue #2919: bug: failed to fetch data from etcd: failed to watch data, response code: 404

2020-12-03 Thread GitBox
Ben0625 commented on issue #2919: URL: https://github.com/apache/apisix/issues/2919#issuecomment-738609841 Finally I find out the reason: One of the member (10.193.161.156) of the etcd cluster didn't set enable-grpc-gateway to true... After restarting this member with the configuration add

[GitHub] [apisix] Ben0625 closed issue #2919: bug: failed to fetch data from etcd: failed to watch data, response code: 404

2020-12-03 Thread GitBox
Ben0625 closed issue #2919: URL: https://github.com/apache/apisix/issues/2919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #964: WIP: Refactor online debug

2020-12-03 Thread GitBox
nic-chen commented on a change in pull request #964: URL: https://github.com/apache/apisix-dashboard/pull/964#discussion_r535880445 ## File path: api/internal/handler/route/route_test.go ## @@ -985,6 +985,32 @@ func TestRoute(t *testing.T) { _, err = handler.BatchDelete

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
Firstsawyou commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535880387 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] nic-chen opened a new issue #2967: request help: In some plugins, directly use the code for parameter verification, we need to replace it with JSONSchema verification

2020-12-03 Thread GitBox
nic-chen opened a new issue #2967: URL: https://github.com/apache/apisix/issues/2967 ## Background In Apache APISIX Dashboard, we use a JSONSchema synchronized from APISIX for parameter verification. However, during the development and testing process, we found that there are

[GitHub] [apisix] spacewander commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
spacewander commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535874963 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
Firstsawyou commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535874299 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] chenyicai opened a new issue #2966: bug: Modify proxy_rewrite plugin in dashboard,unable to save it

2020-12-03 Thread GitBox
chenyicai opened a new issue #2966: URL: https://github.com/apache/apisix/issues/2966 ### Issue description When i modify proxy_rewrite plugin in dashboard, i can not save it Fill in the configuration, click the confirm button, there is no response ### Environment * a

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
Firstsawyou commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535872864 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] chenyicai closed issue #2945: bug:

2020-12-03 Thread GitBox
chenyicai closed issue #2945: URL: https://github.com/apache/apisix/issues/2945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] chenyicai commented on issue #2945: bug:

2020-12-03 Thread GitBox
chenyicai commented on issue #2945: URL: https://github.com/apache/apisix/issues/2945#issuecomment-738598173 Thank you very much for your reply. My question has already used proxy_ rewrite plugin solved it This is an automa

[GitHub] [apisix] ShiningRush commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
ShiningRush commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535868084 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] ShiningRush commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
ShiningRush commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535868084 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] starsz opened a new pull request #2965: feat: use luasocket instead of curl in etcd.lua

2020-12-03 Thread GitBox
starsz opened a new pull request #2965: URL: https://github.com/apache/apisix/pull/2965 ### What this PR does / why we need it: fix: #2818 fix: #2718 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features ha

[GitHub] [apisix] spacewander commented on a change in pull request #2941: docs: update doc of test

2020-12-03 Thread GitBox
spacewander commented on a change in pull request #2941: URL: https://github.com/apache/apisix/pull/2941#discussion_r535866953 ## File path: doc/how-to-build.md ## @@ -119,17 +119,29 @@ Makefile rules: ### Troubleshoot Testing **Set Nginx Path** + - If you run in to an iss

[GitHub] [apisix] spacewander opened a new pull request #2964: feat: route accroding to the graphql attributes

2020-12-03 Thread GitBox
spacewander opened a new pull request #2964: URL: https://github.com/apache/apisix/pull/2964 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have

[GitHub] [apisix] spacewander opened a new pull request #2963: chore: handle error when connecting with passwd to etcd without auth

2020-12-03 Thread GitBox
spacewander opened a new pull request #2963: URL: https://github.com/apache/apisix/pull/2963 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #964: WIP: Refactor online debug

2020-12-03 Thread GitBox
liuxiran commented on a change in pull request #964: URL: https://github.com/apache/apisix-dashboard/pull/964#discussion_r535863204 ## File path: api/internal/handler/route/route_test.go ## @@ -985,6 +985,32 @@ func TestRoute(t *testing.T) { _, err = handler.BatchDelete

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #964: WIP: Refactor online debug

2020-12-03 Thread GitBox
liuxiran opened a new pull request #964: URL: https://github.com/apache/apisix-dashboard/pull/964 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - Related issues fix: https://github.com/apache/apisix-dashboard/i

[GitHub] [apisix] AloneFire removed a comment on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
AloneFire removed a comment on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738582685 yes,you're right This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] AloneFire commented on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
AloneFire commented on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738582839 > This problem does exist if use `post` concurrently. > If you use `put`, there is no problem specifying a different id each time. yes,you're right ---

[GitHub] [apisix] AloneFire commented on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
AloneFire commented on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738582685 yes,you're right This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] yaobo-lab opened a new issue #2962: help~! 如何将 Kong已有业务平滑迁移至 apisix 解决方案?

2020-12-03 Thread GitBox
yaobo-lab opened a new issue #2962: URL: https://github.com/apache/apisix/issues/2962 社区朋友有解决方案。大家多提出来。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] nic-chen commented on pull request #951: feat: add etcd basic auth support

2020-12-03 Thread GitBox
nic-chen commented on pull request #951: URL: https://github.com/apache/apisix-dashboard/pull/951#issuecomment-738576750 @JieTrancender need test case for it This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
juzhiyuan commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738560642 It doesn't matter to do an interceptor 😃 to prevent from 2 api styles haha This is an automated message fr

[GitHub] [apisix] willmafh edited a comment on pull request #2869: fix: start server failure

2020-12-03 Thread GitBox
willmafh edited a comment on pull request #2869: URL: https://github.com/apache/apisix/pull/2869#issuecomment-738548049 > we need some test cases about this change I don't know how to add test cases in this condition. But I do test all situations on my local machine. --

[GitHub] [apisix] willmafh commented on pull request #2869: fix: start server failure

2020-12-03 Thread GitBox
willmafh commented on pull request #2869: URL: https://github.com/apache/apisix/pull/2869#issuecomment-738548049 > we need some test cases about this change I don't know how to add test cases in this condition. But I do test all situation on my local machine. --

[GitHub] [apisix] idbeta edited a comment on issue #2955: upgrade to 2.1: missing ssl cert for ssl

2020-12-03 Thread GitBox
idbeta edited a comment on issue #2955: URL: https://github.com/apache/apisix/issues/2955#issuecomment-738543849 The 2.1 version disable ssl by default, if you want to enable it, you need to set several configurations in `conf.yaml ` like `enable`, `ssl_cert`, `ssl_cert_key`. After setting

[GitHub] [apisix] idbeta edited a comment on issue #2955: upgrade to 2.1: missing ssl cert for ssl

2020-12-03 Thread GitBox
idbeta edited a comment on issue #2955: URL: https://github.com/apache/apisix/issues/2955#issuecomment-738543849 The 2.1 version disable ssl by default, if you need to enable it, you need to set several configurations in `conf.yaml ` like `enable`, `ssl_cert`, `ssl_cert_key`. After setting

[GitHub] [apisix] tokers commented on issue #2853: [DISCUSS] Pagination for fully synchronization from etcd

2020-12-03 Thread GitBox
tokers commented on issue #2853: URL: https://github.com/apache/apisix/issues/2853#issuecomment-738544568 @wfnuser Any new updates? This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix] idbeta edited a comment on issue #2955: upgrade to 2.1: missing ssl cert for ssl

2020-12-03 Thread GitBox
idbeta edited a comment on issue #2955: URL: https://github.com/apache/apisix/issues/2955#issuecomment-738543849 The 2.1 version does not enable ssl by default, if you need to enable it, you need to set several configurations in `conf.yaml ` like `enable`, `ssl_cert`, `ssl_cert_key`. After

[GitHub] [apisix] tokers opened a new pull request #2961: feat: detect whether etcd gRPC gateway is enabled in command line

2020-12-03 Thread GitBox
tokers opened a new pull request #2961: URL: https://github.com/apache/apisix/pull/2961 Signed-off-by: Alex Zhang ### What this PR does / why we need it: etcd gRPC gateway is required by APISIX, we should detect it when calling `bin/apisix init_etcd`, or errors will o

[GitHub] [apisix] idbeta commented on issue #2955: upgrade to 2.1: missing ssl cert for ssl

2020-12-03 Thread GitBox
idbeta commented on issue #2955: URL: https://github.com/apache/apisix/issues/2955#issuecomment-738543849 The 2.1 version does not enable ssl by default, if you need to enable it, you need to set several configurations in `conf.yaml ` `enable`, `ssl_cert`, `ssl_cert_key`. After setting,

[apisix-helm-chart] branch kv/2.1 updated (f742f50 -> 971bb9a)

2020-12-03 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch kv/2.1 in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git. from f742f50 rm ingress first, add it back when ingress-controller is ready add 971bb9a feat: remove etcd b

[GitHub] [apisix] idbeta edited a comment on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
idbeta edited a comment on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738539648 This problem does exist if use `post` concurrently. If you use `put`, there is no problem specifying a different id each time. --

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #904: feat: support disable property for json schema according to APISIX's change

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#issuecomment-735344204 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/904?src=pr&el=h1) Report > Merging [#904](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] idbeta commented on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
idbeta commented on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738539648 This problem does exist if use `post` concurrently. If you use `put`, there is no problem specifying a different id. ---

[GitHub] [apisix] spacewander commented on issue #2959: request help: in ssl ,sni only supports domain ? can you support ip?

2020-12-03 Thread GitBox
spacewander commented on issue #2959: URL: https://github.com/apache/apisix/issues/2959#issuecomment-738532902 No plan to support IP yet. It is possible, but rare to sign a certificate with IP address. This is an automated m

[GitHub] [apisix] spacewander closed issue #2959: request help: in ssl ,sni only supports domain ? can you support ip?

2020-12-03 Thread GitBox
spacewander closed issue #2959: URL: https://github.com/apache/apisix/issues/2959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738531630 > 2 things I'm considering. > > 1. Our docs don't have that api in the apisix repo. > 2. When we upgrade to 3.0, we only need to convert /apisix/admin to /api for e

[GitHub] [apisix] AloneFire commented on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
AloneFire commented on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738531523 我测试过老版本,etcd使用v2的接口是没有这个问题的 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] jaredhuang opened a new issue #2960: bug: missing upstream configuration in Route or Service

2020-12-03 Thread GitBox
jaredhuang opened a new issue #2960: URL: https://github.com/apache/apisix/issues/2960 ### Issue description when i start the limit-req plugin ,I set: burst 1 ,key remote_addr ,rate 1 ,rejected_code 503 I access my web site ,sometimes get 503 , sometimes get 500 , and i look t

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738529923 > I think API `Get label list` also need support search, like: > > `GET /apisix/admin/labels?label=key&label=key:value&...` > > User can filter when there are to

[GitHub] [apisix] zhuchengxing opened a new issue #2959: request help: in ssl ,sni only supports domain ? can you support ip?

2020-12-03 Thread GitBox
zhuchengxing opened a new issue #2959: URL: https://github.com/apache/apisix/issues/2959 ### Issue description in ssl ,sni only supports domain ? can you support ip? ### Environment * apisix version (cmd: `apisix version`): 2.0 * OS:centos7 -

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
juzhiyuan commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738526485 2 things I'm considering. 1. Our docs don't have that api in the apisix repo. 2. When we upgrade to 3.0, we only need to convert /apisix/admin to /api for example, the

[GitHub] [apisix-dashboard] idbeta commented on issue #941: test: need to do custom check for plugins

2020-12-03 Thread GitBox
idbeta commented on issue #941: URL: https://github.com/apache/apisix-dashboard/issues/941#issuecomment-738524747 I don’t quite understand your issue, can you provide a more detailed explanation? @nic-chen This is an autom

[GitHub] [apisix-dashboard] nic-chen commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
nic-chen commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738524806 > Based on previous discussions, we need two apis in manager-api, a API to get label list, and a API to search routes by labels filter. > > * Get label list(create a n

[GitHub] [apisix] tzssangglass commented on a change in pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tzssangglass commented on a change in pull request #2943: URL: https://github.com/apache/apisix/pull/2943#discussion_r535793418 ## File path: apisix/schema_def.lua ## @@ -496,6 +496,13 @@ _M.route = { }, id = id_schema, + +status = { +des

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738522684 > Hi @liuxiran, we may use a different prefix for the newer API :) How about using something like `HOST/api/labels` for fetching global label list. It looks more reaso

[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
liuxiran edited a comment on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738520168 > We should not add new API to admin API anymore. Yep, sorry to forget to synchronize the results of the discussion: 1. it is not required to modify DP

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738520168 > We should not add new API to admin API anymore. Yep, sorry to forget to synchronize the results of the discussion: 1. it is not required to modify DP 1.

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
juzhiyuan commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738519671 Hi @liuxiran, we may use a different prefix for the newer API :) How about using something like `HOST/api/labels` for fetching global label list. -

[GitHub] [apisix-dashboard] nic-chen commented on issue #962: feat: upstream support set `pass_host` parameter

2020-12-03 Thread GitBox
nic-chen commented on issue #962: URL: https://github.com/apache/apisix-dashboard/issues/962#issuecomment-738519514 > Just to make sure, if the manager-api supports this feature? > > cc @nic-chen yes, it has supported.

[GitHub] [apisix] AloneFire edited a comment on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
AloneFire edited a comment on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738518941 > 为什么不同步etcd的数据 或者使用同一个etcd集群呢 是这样,数据源不是etcd ,同步解决方案呢当然也可以通过操作etcd或者直接就避免并发同步, 但是Admin 接口在并发状态下会出现问题我觉得这就是一个bug --

[GitHub] [apisix] AloneFire commented on issue #2950: bug: Admin 接口并发创建 Router ID 重复

2020-12-03 Thread GitBox
AloneFire commented on issue #2950: URL: https://github.com/apache/apisix/issues/2950#issuecomment-738518941 > 为什么不同步etcd的数据 或者使用同一个etcd集群呢 是这样,数据源不是etcd ,同步解决方案呢当然也可以通过操作etcd或者直接就避免并发同步, 但是Admin 接口在并发状态下会出现问题我觉得这就是一个bug

[GitHub] [apisix-helm-chart] gxthrj commented on pull request #4: feat: adjustments for APISIX 2.1 release

2020-12-03 Thread GitBox
gxthrj commented on pull request #4: URL: https://github.com/apache/apisix-helm-chart/pull/4#issuecomment-738518637 > how about remove etcd binary file and use dependencies? Ok, Apache also does not allow binary files in the project. I will remove the etcd binary and add some comma

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #962: feat: upstream support set `pass_host` parameter

2020-12-03 Thread GitBox
juzhiyuan commented on issue #962: URL: https://github.com/apache/apisix-dashboard/issues/962#issuecomment-738518643 Just to make sure, if the manager-api supports this feature? cc @nic-chen This is an automated mess

[GitHub] [apisix-dashboard] spacewander commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
spacewander commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738516834 > > > > Do we need to implement this API in `Admin API`? > > It is necessary to increase a group schema in APISIX, and for v2.x we may not rely on the admin

[GitHub] [apisix-dashboard] gy09535 edited a comment on issue #962: feat: upstream support set `pass_host` parameter

2020-12-03 Thread GitBox
gy09535 edited a comment on issue #962: URL: https://github.com/apache/apisix-dashboard/issues/962#issuecomment-738515479 I think it is a good feature, now the pass_host value is always "pass", when we set the upstream node with domain in 2.0 dashboard, it can not set the host to the upst

[GitHub] [apisix-dashboard] gy09535 edited a comment on issue #962: feat: upstream support set `pass_host` parameter

2020-12-03 Thread GitBox
gy09535 edited a comment on issue #962: URL: https://github.com/apache/apisix-dashboard/issues/962#issuecomment-738515479 I think it is a good feature, now the pass_host value is always "pass", when we set the upstream node with domain with 2.0 dashboard, it can not set the host to the up

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-12-03 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-738515671 Based on previous discussions, we need two apis in manager-api, a API to get label list, and a API to search routes by labels filter. - Get label list(create a new API

[GitHub] [apisix] spacewander commented on issue #2958: request help: Customize configuration into etcd

2020-12-03 Thread GitBox
spacewander commented on issue #2958: URL: https://github.com/apache/apisix/issues/2958#issuecomment-738515640 This can't be done as we need a static file to bootstrap and we can't custom Nginx configuration on the fly. This

[GitHub] [apisix] spacewander closed issue #2958: request help: Customize configuration into etcd

2020-12-03 Thread GitBox
spacewander closed issue #2958: URL: https://github.com/apache/apisix/issues/2958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] gy09535 commented on issue #962: feat: upstream support set `pass_host` parameter

2020-12-03 Thread GitBox
gy09535 commented on issue #962: URL: https://github.com/apache/apisix-dashboard/issues/962#issuecomment-738515479 I think it is a good feature, now the pass_host value is always "pass", when we set the upstream node with domain , it can not set the host to the upstream, It is a problem.

[GitHub] [apisix] wfgydbu commented on issue #2957: bug: there is an error message when starting apisix 2.1

2020-12-03 Thread GitBox
wfgydbu commented on issue #2957: URL: https://github.com/apache/apisix/issues/2957#issuecomment-738512831 Problem solved, thanks again. This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] wfgydbu closed issue #2957: bug: there is an error message when starting apisix 2.1

2020-12-03 Thread GitBox
wfgydbu closed issue #2957: URL: https://github.com/apache/apisix/issues/2957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix] GiftLee opened a new issue #2958: request help: Customize configuration into etcd

2020-12-03 Thread GitBox
GiftLee opened a new issue #2958: URL: https://github.com/apache/apisix/issues/2958 config- default.yaml ,Customize Nginx Configuration ,such as configuration file should be put into etcd to configuration management. Configmap can be used for k8s, and APISIX etcd can be directly store

[GitHub] [apisix] wfgydbu commented on issue #2957: bug: there is an error message when starting apisix 2.1

2020-12-03 Thread GitBox
wfgydbu commented on issue #2957: URL: https://github.com/apache/apisix/issues/2957#issuecomment-738510334 Thanks! I'll take a look. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] spacewander commented on issue #2957: bug: there is an error message when starting apisix 2.1

2020-12-03 Thread GitBox
spacewander commented on issue #2957: URL: https://github.com/apache/apisix/issues/2957#issuecomment-738508616 Look like your lua-resty-etcd library is too old. From the code I guess you are using version < v1.2, but the APISIX 2.1 requires v1.4.2. You need to reinstall the dependenc

[GitHub] [apisix] gy09535 commented on a change in pull request #2953: fix: change string concat

2020-12-03 Thread GitBox
gy09535 commented on a change in pull request #2953: URL: https://github.com/apache/apisix/pull/2953#discussion_r535778902 ## File path: apisix/plugins/sls-logger.lua ## @@ -126,26 +127,23 @@ local function remove_stale_objects(premature) end local function combine_syslog(e

[GitHub] [apisix] GiftLee edited a comment on issue #2827: request help: fault-injection abort.body Using variables

2020-12-03 Thread GitBox
GiftLee edited a comment on issue #2827: URL: https://github.com/apache/apisix/issues/2827#issuecomment-738504369 i think enhance fault-injection ,add function like this ``` function _M.rewrite(conf, ctx) core.log.info("plugin rewrite phase, conf: ", core.json.del

[GitHub] [apisix] GiftLee commented on issue #2827: request help: fault-injection abort.body Using variables

2020-12-03 Thread GitBox
GiftLee commented on issue #2827: URL: https://github.com/apache/apisix/issues/2827#issuecomment-738504369 i think enhance fault-injection ,add function like this ``` function _M.rewrite(conf, ctx) core.log.info("plugin rewrite phase, conf: ", core.json.delay_enco

[GitHub] [apisix] wfgydbu commented on issue #2957: bug: there is an error message when starting apisix 2.1

2020-12-03 Thread GitBox
wfgydbu commented on issue #2957: URL: https://github.com/apache/apisix/issues/2957#issuecomment-738503746 I've tried to locate it by adding some `core.log.info(...)` Find the root statement is at https://github.com/apache/apisix/blob/master/apisix/core/etcd.lua#L188 Trying to

[GitHub] [apisix] gy09535 commented on a change in pull request #2953: fix: change string concat

2020-12-03 Thread GitBox
gy09535 commented on a change in pull request #2953: URL: https://github.com/apache/apisix/pull/2953#discussion_r535776872 ## File path: apisix/plugins/sls-logger.lua ## @@ -126,26 +127,23 @@ local function remove_stale_objects(premature) end local function combine_syslog(e

[GitHub] [apisix] spacewander commented on issue #2954: ctx.var.upstream_addr may be separated by commas.

2020-12-03 Thread GitBox
spacewander commented on issue #2954: URL: https://github.com/apache/apisix/issues/2954#issuecomment-738500790 PR is welcome! The value is 0 because `tonumber("xxx")` is nil. This is an automated message from the Apache Git S

[GitHub] [apisix-docker] cverdela opened a new issue #95: request help: can I ask if you can provide docker image apisix-dashboard 2.0 in docker hub

2020-12-03 Thread GitBox
cverdela opened a new issue #95: URL: https://github.com/apache/apisix-docker/issues/95 ### Issue description request help: can I ask if you can provide docker image apisix-dashboard 2.0 in docker hub i build this error when download some components ### Environment * apisi

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #949: feat: added info page

2020-12-03 Thread GitBox
juzhiyuan commented on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-738500315 cc @guoqqqi This PR's checks have failed, just click the details link to see what's happened. ![image](https://user-images.githubusercontent.com/2106987/1013

[GitHub] [apisix] wfgydbu opened a new issue #2957: bug: there is an error message when starting apisix 2.1

2020-12-03 Thread GitBox
wfgydbu opened a new issue #2957: URL: https://github.com/apache/apisix/issues/2957 ### Issue description A runtime error occurs when starting apisix at the first time. ### Environment * apisix version (cmd: `apisix version`): 2.1 * OS: Centos 7.6 ### Minimal

[GitHub] [apisix] cverdela opened a new issue #2956: request help: can I ask if you can provide docker image apisix-dashboard 2.0 in docker hub

2020-12-03 Thread GitBox
cverdela opened a new issue #2956: URL: https://github.com/apache/apisix/issues/2956 ### Issue description request help: can I ask if you can provide docker image apisix-dashboard 2.0 in docker hub i build this error when download some components ### Environment * apisix v

[GitHub] [apisix-docker] leon1509 closed issue #94: request help: Docker部署,无法访问dashboard!版本2.1

2020-12-03 Thread GitBox
leon1509 closed issue #94: URL: https://github.com/apache/apisix-docker/issues/94 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-docker] leon1509 edited a comment on issue #94: request help: Docker部署,无法访问dashboard!版本2.1

2020-12-03 Thread GitBox
leon1509 edited a comment on issue #94: URL: https://github.com/apache/apisix-docker/issues/94#issuecomment-738484975 allready ok!已经总结到这:https://github.com/leon1509/note/blob/master/Docker%E5%AE%89%E8%A3%85apisix.md This

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #904: feat: support disable property for json schema according to APISIX's change

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#issuecomment-735344204 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/904?src=pr&el=h1) Report > Merging [#904](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #904: feat: support disable property for json schema according to APISIX's change

2020-12-03 Thread GitBox
nic-chen commented on a change in pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#discussion_r535762118 ## File path: api/internal/core/store/validate.go ## @@ -238,22 +238,37 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{}) error {

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #904: feat: support disable property for json schema according to APISIX's change

2020-12-03 Thread GitBox
nic-chen commented on a change in pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#discussion_r535762067 ## File path: api/internal/core/store/validate.go ## @@ -238,22 +238,37 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{}) error {

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #904: feat: support disable property for json schema according to APISIX's change

2020-12-03 Thread GitBox
nic-chen commented on a change in pull request #904: URL: https://github.com/apache/apisix-dashboard/pull/904#discussion_r535761793 ## File path: api/internal/core/store/validate.go ## @@ -238,22 +238,37 @@ func (v *APISIXJsonSchemaValidator) Validate(obj interface{}) error {

[GitHub] [apisix-docker] leon1509 closed issue #94: request help: Docker部署,无法访问dashboard!版本2.1

2020-12-03 Thread GitBox
leon1509 closed issue #94: URL: https://github.com/apache/apisix-docker/issues/94 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-docker] leon1509 commented on issue #94: request help: Docker部署,无法访问dashboard!版本2.1

2020-12-03 Thread GitBox
leon1509 commented on issue #94: URL: https://github.com/apache/apisix-docker/issues/94#issuecomment-738484975 allready ok! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] tzssangglass commented on a change in pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tzssangglass commented on a change in pull request #2943: URL: https://github.com/apache/apisix/pull/2943#discussion_r535760947 ## File path: apisix/http/router/radixtree_host_uri.lua ## @@ -94,7 +94,14 @@ local function create_radixtree_router(routes) host_router = nil

[GitHub] [apisix] tokers commented on a change in pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tokers commented on a change in pull request #2943: URL: https://github.com/apache/apisix/pull/2943#discussion_r535752690 ## File path: apisix/http/router/radixtree_host_uri.lua ## @@ -94,7 +94,14 @@ local function create_radixtree_router(routes) host_router = nil f

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #949: feat: info page

2020-12-03 Thread GitBox
juzhiyuan commented on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-738457818 This style looks good to me, i will check why that info icon is missing. Any suggestion for this style? cc @moonming @liuxiran @tokers @starsz -

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #949: feat: info page

2020-12-03 Thread GitBox
guoqqqi commented on pull request #949: URL: https://github.com/apache/apisix-dashboard/pull/949#issuecomment-738211900 https://user-images.githubusercontent.com/72343596/101073196-0c462b80-35da-11eb-87e7-2b5d614068fc.png";> https://user-images.githubusercontent.com/72343596/101073203-11a

[GitHub] [apisix] tzssangglass edited a comment on pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tzssangglass edited a comment on pull request #2943: URL: https://github.com/apache/apisix/pull/2943#issuecomment-738170623 describe a strange phenomenon, I was using `/route_status` api and create new routes because I found that using route id 1 and `/hello` always failed when I ran my lo

[GitHub] [apisix] tzssangglass commented on pull request #2943: feat: support enable/disable route

2020-12-03 Thread GitBox
tzssangglass commented on pull request #2943: URL: https://github.com/apache/apisix/pull/2943#issuecomment-738170623 describe a strange phenomenon, I was using `/route_status` api and create new routes because I found that using route id 1 and `/hello` always failed when I ran my local tes

  1   2   3   >