[GitHub] [apisix-dashboard] LiteSun commented on pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
LiteSun commented on pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742336478 > > CI failed fixed. This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
LiteSun commented on pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742336043 > CI failed fixed. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix] moonming merged pull request #2964: feat: route accroding to the graphql attributes

2020-12-09 Thread GitBox
moonming merged pull request #2964: URL: https://github.com/apache/apisix/pull/2964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander opened a new pull request #3011: style: check misspell

2020-12-09 Thread GitBox
spacewander opened a new pull request #3011: URL: https://github.com/apache/apisix/pull/3011 Fix #3009. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve?

[apisix] branch master updated (85a84fb -> 93e2f16)

2020-12-09 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 85a84fb fix: avoid unnecessary type check and support var in local_conf (#2990) add 93e2f16 feat: route accr

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1005: fix: PATCH method bug

2020-12-09 Thread GitBox
nic-chen opened a new pull request #1005: URL: https://github.com/apache/apisix-dashboard/pull/1005 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Relate

[apisix] branch master updated: fix: avoid unnecessary type check and support var in local_conf (#2990)

2020-12-09 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 85a84fb fix: avoid unnecessary type check and

[GitHub] [apisix] moonming merged pull request #2990: fix: avoid unnecessary type check and support var in local_conf

2020-12-09 Thread GitBox
moonming merged pull request #2990: URL: https://github.com/apache/apisix/pull/2990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] jbampton opened a new pull request #1004: fix: spelling

2020-12-09 Thread GitBox
jbampton opened a new pull request #1004: URL: https://github.com/apache/apisix-dashboard/pull/1004 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Relate

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

2020-12-09 Thread GitBox
juzhiyuan edited a comment on pull request #898: URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742315027 > LGTM except more information about icons. > > It would be better to add a desc about the relationship between existing icons and their names or show the

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

2020-12-09 Thread GitBox
juzhiyuan commented on pull request #898: URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742315027 > LGTM except more information about icons. > > It would be better to add a desc about the relationship between existing icons and their names or show the project

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
juzhiyuan commented on a change in pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#discussion_r539939593 ## File path: web/config/proxy.ts ## @@ -14,11 +14,18 @@ * See the License for the specific language governing permissions and * limitation

[apisix-dashboard] branch master updated: docs: optimize metrics document (#970)

2020-12-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e611cd3 docs: optimize metrics doc

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #970: docs: optimize metrics document

2020-12-09 Thread GitBox
juzhiyuan merged pull request #970: URL: https://github.com/apache/apisix-dashboard/pull/970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] roneywei opened a new issue #3010: request help: How Cluster deployment?

2020-12-09 Thread GitBox
roneywei opened a new issue #3010: URL: https://github.com/apache/apisix/issues/3010 ### Issue description ### Environment * apisix version (cmd: `apisix version`): * OS: How Cluster deployment? This

[GitHub] [apisix-dashboard] jbampton commented on a change in pull request #1002: fix: spelling

2020-12-09 Thread GitBox
jbampton commented on a change in pull request #1002: URL: https://github.com/apache/apisix-dashboard/pull/1002#discussion_r539932448 ## File path: api/conf/schema.json ## @@ -3217,21 +3217,21 @@ "minProperties": 1,

[GitHub] [apisix] spacewander closed issue #2950: bug: Admin API concurrently created Router ID duplicate

2020-12-09 Thread GitBox
spacewander closed issue #2950: URL: https://github.com/apache/apisix/issues/2950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander merged pull request #3003: fix: avoid duplicate auto-generated id

2020-12-09 Thread GitBox
spacewander merged pull request #3003: URL: https://github.com/apache/apisix/pull/3003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: fix: avoid duplicate auto-generated id (#3003)

2020-12-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new d8176dc fix: avoid duplicate auto-generate

[GitHub] [apisix] idbeta commented on pull request #3003: fix: avoid duplicate auto-generated id

2020-12-09 Thread GitBox
idbeta commented on pull request #3003: URL: https://github.com/apache/apisix/pull/3003#issuecomment-742288134 > @idbeta @AloneFire you can make a try with this PR This commit has solved this problem #2950 This is an a

[GitHub] [apisix] membphis commented on a change in pull request #3008: feat: improve jsonschema validation on route resource

2020-12-09 Thread GitBox
membphis commented on a change in pull request #3008: URL: https://github.com/apache/apisix/pull/3008#discussion_r539918756 ## File path: doc/admin-api.md ## @@ -55,11 +55,12 @@ |-|-||---|| |name |False |Auxiliary |Identifies route names.

[GitHub] [apisix-dashboard] NetRainn commented on issue #1003: plugin proxy-rewrite has some problems

2020-12-09 Thread GitBox
NetRainn commented on issue #1003: URL: https://github.com/apache/apisix-dashboard/issues/1003#issuecomment-742285970 There is no problem with command generation maybe The format is wrong(dashboard) This is an automated m

[GitHub] [apisix-dashboard] membphis commented on pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
membphis commented on pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742285963 CI failed This is an automated message from the Apache Git Service. To respond to the message, please

[apisix-dashboard] branch master updated: fix: English spelling (#1002)

2020-12-09 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 867ee79 fix: English spelling (#100

[GitHub] [apisix-dashboard] membphis merged pull request #1002: fix: spelling

2020-12-09 Thread GitBox
membphis merged pull request #1002: URL: https://github.com/apache/apisix-dashboard/pull/1002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1002: fix: spelling

2020-12-09 Thread GitBox
membphis commented on a change in pull request #1002: URL: https://github.com/apache/apisix-dashboard/pull/1002#discussion_r539915259 ## File path: api/conf/schema.json ## @@ -3217,21 +3217,21 @@ "minProperties": 1,

[GitHub] [apisix] membphis opened a new issue #3009: English spelling

2020-12-09 Thread GitBox
membphis opened a new issue #3009: URL: https://github.com/apache/apisix/issues/3009 comments: https://github.com/apache/apisix-dashboard/pull/1002/files#diff-5fadf7c6b5b550d0a97075c3ddeaf29028204cd60da2660c6a1e1c72b4bbd0edR3220 I think we need to fix the JSON schema definition. --

[GitHub] [apisix] ziyou434 commented on issue #3007: request help: flamegraph

2020-12-09 Thread GitBox
ziyou434 commented on issue #3007: URL: https://github.com/apache/apisix/issues/3007#issuecomment-742284930 > the systemtap need the `kernel` debuginfo But I can't search out those packages in any mirrors,it's the problem. And linux kernel version is decided by contianer, I don't

[apisix-dashboard] branch master updated: feat(CI): supoort markdown links checker (#981)

2020-12-09 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 1564d4f feat(CI): supoort markdown

[GitHub] [apisix-dashboard] membphis merged pull request #981: feat(CI): supoort markdown links checker

2020-12-09 Thread GitBox
membphis merged pull request #981: URL: https://github.com/apache/apisix-dashboard/pull/981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] membphis commented on issue #3005: feat: enable the SSL feature in DP by default

2020-12-09 Thread GitBox
membphis commented on issue #3005: URL: https://github.com/apache/apisix/issues/3005#issuecomment-742282828 > Got it thx! Do we still put the copied certificates in `conf/cert`? confirm with this This is an automated m

[GitHub] [apisix] membphis commented on issue #3007: request help: flamegraph

2020-12-09 Thread GitBox
membphis commented on issue #3007: URL: https://github.com/apache/apisix/issues/3007#issuecomment-742282566 the systemtap need the `kernel` debuginfo This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] Yiyiyimu commented on issue #3005: feat: enable the SSL feature in DP by default

2020-12-09 Thread GitBox
Yiyiyimu commented on issue #3005: URL: https://github.com/apache/apisix/issues/3005#issuecomment-742282471 Got it thx! Do we still put the copied certificates in `conf/cert`? This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] membphis commented on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
membphis commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-742281936 @starsz many thx for you, wait for your PR ^_^ This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander commented on issue #2985: bug: 'limit-conn' plugin seems working in an unexpected manner

2020-12-09 Thread GitBox
spacewander commented on issue #2985: URL: https://github.com/apache/apisix/issues/2985#issuecomment-742281538 Solved by #2465 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix] spacewander closed issue #2985: bug: 'limit-conn' plugin seems working in an unexpected manner

2020-12-09 Thread GitBox
spacewander closed issue #2985: URL: https://github.com/apache/apisix/issues/2985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] membphis commented on issue #3005: feat: enable the SSL feature in DP by default

2020-12-09 Thread GitBox
membphis commented on issue #3005: URL: https://github.com/apache/apisix/issues/3005#issuecomment-742281443 we can copy the test certificate file as the placeholder. and the file name should contain the keyword `placeholder`. so we do not need to revert the whole PR. --

[GitHub] [apisix] spacewander merged pull request #2465: fix(limit-conn): always save the data of the limit object, and release it in log phase.

2020-12-09 Thread GitBox
spacewander merged pull request #2465: URL: https://github.com/apache/apisix/pull/2465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #2450: bug: limit-conn

2020-12-09 Thread GitBox
spacewander closed issue #2450: URL: https://github.com/apache/apisix/issues/2450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[apisix] branch master updated: bugfix: always necessary to save the data of the limit concurrency, and release the statistical status in the log phase. (#2465)

2020-12-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new a670ea2 bugfix: always necessary to save t

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-09 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r539897958 ## File path: apisix/plugins/traffic-split.lua ## @@ -0,0 +1,294 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- cont

[GitHub] [apisix] membphis commented on pull request #2465: fix(limit-conn): always save the data of the limit object, and release it in log phase.

2020-12-09 Thread GitBox
membphis commented on pull request #2465: URL: https://github.com/apache/apisix/pull/2465#issuecomment-742276772 @moonming @tokers @nic-chen please take a look at this PR This is an automated message from the Apache Git Servi

[GitHub] [apisix-dashboard] NetRainn opened a new issue #1003: plugin proxy-rewrite has some problems

2020-12-09 Thread GitBox
NetRainn opened a new issue #1003: URL: https://github.com/apache/apisix-dashboard/issues/1003 ### key and value is “test” ![image](https://user-images.githubusercontent.com/35440615/101730379-de3e7b00-3af4-11eb-9cbb-a055e95f9774.png) ### but I'll get it through Linux !

[GitHub] [apisix] Yiyiyimu commented on issue #3005: feat: enable the SSL feature in DP by default

2020-12-09 Thread GitBox
Yiyiyimu commented on issue #3005: URL: https://github.com/apache/apisix/issues/3005#issuecomment-742274571 Hi @membphis So do we use the original test certificate as the placeholder? If that is the case, I think we could directly revert the whole PR. -

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
LiteSun commented on a change in pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#discussion_r539880485 ## File path: web/config/proxy.ts ## @@ -14,11 +14,18 @@ * See the License for the specific language governing permissions and * limitations

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
juzhiyuan commented on a change in pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#discussion_r539871034 ## File path: web/config/proxy.ts ## @@ -14,11 +14,18 @@ * See the License for the specific language governing permissions and * limitation

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
moonming commented on a change in pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539869378 ## File path: web/src/e2e/Route.e2e.js ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #898: fix(Plugin): use codemirror instead of form in plugin module

2020-12-09 Thread GitBox
juzhiyuan merged pull request #898: URL: https://github.com/apache/apisix-dashboard/pull/898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: fix(Plugin): use codemirror instead of form in plugin module (#898)

2020-12-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 053721c fix(Plugin): use codemirro

[GitHub] [apisix-dashboard] juzhiyuan closed issue #815: Integrate with code-mirror to have a fallback to plugins' render issue

2020-12-09 Thread GitBox
juzhiyuan closed issue #815: URL: https://github.com/apache/apisix-dashboard/issues/815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] idbeta closed pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
idbeta closed pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] idbeta commented on pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
idbeta commented on pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742256783 There is a new frontend E2E test technology solution that needs to be evaluated. After the evaluation, I will decide whether to open this PR.

[GitHub] [apisix] Firstsawyou commented on pull request #2935: feat: Implement traffic splitting plugin

2020-12-09 Thread GitBox
Firstsawyou commented on pull request #2935: URL: https://github.com/apache/apisix/pull/2935#issuecomment-742247728 > > > @Firstsawyou Could you paste some sample traffic split configurations here to help us understand the schema better. > > > > > > @tokers These are two cases, w

[GitHub] [apisix-ingress-controller] jbampton commented on pull request #76: Fix spelling

2020-12-09 Thread GitBox
jbampton commented on pull request #76: URL: https://github.com/apache/apisix-ingress-controller/pull/76#issuecomment-742247615 Thanks @tokers 👍 This is an automated message from the Apache Git Service. To respond to the me

[apisix-ingress-controller] branch master updated: Fix spelling (#76)

2020-12-09 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 1d3805d Fix spelling (#76) 1

[GitHub] [apisix-ingress-controller] tokers merged pull request #76: Fix spelling

2020-12-09 Thread GitBox
tokers merged pull request #76: URL: https://github.com/apache/apisix-ingress-controller/pull/76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [apisix-ingress-controller] tokers commented on pull request #76: Fix spelling

2020-12-09 Thread GitBox
tokers commented on pull request #76: URL: https://github.com/apache/apisix-ingress-controller/pull/76#issuecomment-742246922 @jbampton Nice capture! This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
moonming commented on a change in pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539851684 ## File path: web/src/e2e/Route.e2e.js ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

[GitHub] [apisix] Firstsawyou commented on pull request #2935: feat: Implement traffic splitting plugin

2020-12-09 Thread GitBox
Firstsawyou commented on pull request #2935: URL: https://github.com/apache/apisix/pull/2935#issuecomment-742243058 > This plugin needs to be mentioned on the project README and the readme of the plugins. Yes i will update later.

[GitHub] [apisix-dashboard] jbampton opened a new pull request #1002: Fix spelling

2020-12-09 Thread GitBox
jbampton opened a new pull request #1002: URL: https://github.com/apache/apisix-dashboard/pull/1002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
codecov-io commented on pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001#issuecomment-742226272 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1001?src=pr&el=h1) Report > Merging [#1001](https://codecov.io/gh/apache/apisix-dashboard/pull/100

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1001: feat: change proxy target to localhost when test

2020-12-09 Thread GitBox
LiteSun opened a new pull request #1001: URL: https://github.com/apache/apisix-dashboard/pull/1001 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-ingress-controller] jbampton opened a new pull request #76: Fix spelling

2020-12-09 Thread GitBox
jbampton opened a new pull request #76: URL: https://github.com/apache/apisix-ingress-controller/pull/76 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] spacewander opened a new pull request #3008: feat: improve jsonschema validation on route resource

2020-12-09 Thread GitBox
spacewander opened a new pull request #3008: URL: https://github.com/apache/apisix/pull/3008 Fix #2671 Fix #2991 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does th

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

2020-12-09 Thread GitBox
juzhiyuan edited a comment on pull request #898: URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742221067 Hi @liuxiran @bzp2010 Kindly review this PR when you have time 💯 This is an automated message f

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #898: fix(Plugin): use codemirror instead of form in plugin module

2020-12-09 Thread GitBox
juzhiyuan commented on pull request #898: URL: https://github.com/apache/apisix-dashboard/pull/898#issuecomment-742221067 Hi @liuxiran @bzp2010 Kindly review this PR when you have time :) This is an automated message from the

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #75: chore: add Apache License header in each go source file.

2020-12-09 Thread GitBox
gxthrj merged pull request #75: URL: https://github.com/apache/apisix-ingress-controller/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[apisix-ingress-controller] branch master updated: chore: add Apache License header in each go source file. (#75)

2020-12-09 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new d7d8bdb chore: add Apache Licen

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #75: chore: add Apache License header in each go source file.

2020-12-09 Thread GitBox
gxthrj commented on pull request #75: URL: https://github.com/apache/apisix-ingress-controller/pull/75#issuecomment-742218184 Related to #38 , only golang files in this PR This is an automated message from the Apache Git Ser

[GitHub] [apisix-dashboard] moonming closed issue #998: CI failed: TestRoute_Create_Service

2020-12-09 Thread GitBox
moonming closed issue #998: URL: https://github.com/apache/apisix-dashboard/issues/998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] moonming merged pull request #1000: fix: fix router name conflict in route_service_upstream_test.go

2020-12-09 Thread GitBox
moonming merged pull request #1000: URL: https://github.com/apache/apisix-dashboard/pull/1000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: fix: fix router name conflict in route_service_upstream_test.go.

2020-12-09 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 38a71a7 fix: fix router name confli

[GitHub] [apisix-ingress-controller] moonming commented on pull request #75: chore: add Apache License header in each go source file.

2020-12-09 Thread GitBox
moonming commented on pull request #75: URL: https://github.com/apache/apisix-ingress-controller/pull/75#issuecomment-742217262 @Firstsawyou please add CI check for ASF header. This is an automated message from the Apache Gi

[GitHub] [apisix] ziyou434 commented on issue #3007: request help: flamegraph

2020-12-09 Thread GitBox
ziyou434 commented on issue #3007: URL: https://github.com/apache/apisix/issues/3007#issuecomment-742216528 About systemtap ``` stap-prep ... package kernel-4.14.198-152.320.amzn2.x86_64 is not installed package kernel-devel-4.14.198-152.320.amzn2.x86_64 is not installed

[GitHub] [apisix-dashboard] starsz edited a comment on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
starsz edited a comment on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-742216187 Hi, It looks good to me. I can help to implement this if I have the opportunity. This is an automated

[GitHub] [apisix-dashboard] starsz commented on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
starsz commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-742216187 HI, It looks good to me. I can help to implement this if I have the opportunity. This is an automated message

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #75: chore: add Apache License header in each go source file.

2020-12-09 Thread GitBox
tokers opened a new pull request #75: URL: https://github.com/apache/apisix-ingress-controller/pull/75 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tokers commented on pull request #75: chore: add Apache License header in each go source file.

2020-12-09 Thread GitBox
tokers commented on pull request #75: URL: https://github.com/apache/apisix-ingress-controller/pull/75#issuecomment-742213461 @membphis @moonming @gxthrj Please take a look. This is an automated message from the Apache Git S

[GitHub] [apisix] ziyou434 opened a new issue #3007: request help: flamegraph

2020-12-09 Thread GitBox
ziyou434 opened a new issue #3007: URL: https://github.com/apache/apisix/issues/3007 ### Issue description I want to know how to show specific functions in the flamegraph,I use the perf, because systamp has some version problem with kernel. perf record -F 99 -p 37 -g -- sleep 60 37

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
ShiningRush edited a comment on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-742205449 > GET /apisix/admin/labels?label=key&label=key:value&... This is too simple to use, If we add label for resource, we should also implement `label selector`

[GitHub] [apisix-dashboard] ShiningRush edited a comment on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
ShiningRush edited a comment on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-742205449 > GET /apisix/admin/labels?label=key&label=key:value&... This is too simple to use, If we add label for resource, we should also implement `label selector`

[GitHub] [apisix-dashboard] ShiningRush commented on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
ShiningRush commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-742205449 > GET /apisix/admin/labels?label=key&label=key:value&... This is too simple to use, If we add label for resource, we should also implement `label selector` as desc

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
idbeta commented on a change in pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539804242 ## File path: web/src/e2e/Route.e2e.js ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
idbeta commented on a change in pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539804113 ## File path: web/src/e2e/Route.e2e.js ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributo

[GitHub] [apisix] membphis commented on issue #2988: Carry SNI while doing SSL handshaking with upstream

2020-12-09 Thread GitBox
membphis commented on issue #2988: URL: https://github.com/apache/apisix/issues/2988#issuecomment-742200465 add `proxy_ssl_server_name on` to `apisix/cli/ngx_tpl.lua`, should be fine. welcome anyone to submit PR, fix this issue ---

[GitHub] [apisix-dashboard] LiteSun commented on pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
LiteSun commented on pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742200333 One PR one thing. I think the PR needs to be split into two PRs. 1. add create route E2E test 2. modify the YAML file to start the local manager-api for tes

[apisix-dashboard] branch juzhiyuan/feat-plugin updated (f207da9 -> f602efc)

2020-12-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan/feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from f207da9 feat: update ASF Release cfg add f602efc feat: update ASF Release cfg No

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
LiteSun commented on a change in pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539795869 ## File path: web/src/e2e/Route.e2e.js ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[apisix-dashboard] branch juzhiyuan/feat-plugin updated (530b886 -> f207da9)

2020-12-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan/feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 530b886 feat: use local icon files add f207da9 feat: update ASF Release cfg No ne

[apisix-dashboard] branch juzhiyuan/feat-plugin updated (3bc98b4 -> 530b886)

2020-12-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan/feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 3bc98b4 Merge branch 'master' into juzhiyuan/feat-plugin add 530b886 feat: use loc

[GitHub] [apisix-dashboard] liuxiran commented on issue #861: [Proposal]: Route group feature

2020-12-09 Thread GitBox
liuxiran commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-74219 Got it, then we will do it in the way of method2. Method2 is more difficult to implement than method1, it'll take more time. At the same time, @Jaycean has another arr

[GitHub] [apisix-dashboard] membphis commented on pull request #982: add frontend e2e test for create route

2020-12-09 Thread GitBox
membphis commented on pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742188134 welcome review @LiteSun @moonming @liuxiran This is an automated message from the Apache Git Service. T

[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies

2020-12-09 Thread GitBox
gxthrj commented on a change in pull request #3006: URL: https://github.com/apache/apisix/pull/3006#discussion_r539789408 ## File path: README_CN.md ## @@ -151,6 +151,15 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵 ## 立刻开始 +### 快速体验 + +使用docker快速build一个包含所有依赖的 apisix 镜像,一键启动。 + +```s

[GitHub] [apisix] gxthrj commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies

2020-12-09 Thread GitBox
gxthrj commented on a change in pull request #3006: URL: https://github.com/apache/apisix/pull/3006#discussion_r539789159 ## File path: docker/Dockerfile ## @@ -0,0 +1,52 @@ +FROM openresty/openresty:alpine-fat AS production-stage + +ARG APISIX_VERSION=master +LABEL apisix_vers

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route

2020-12-09 Thread GitBox
codecov-io edited a comment on pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report > Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: draft: add frontend e2e test for create route

2020-12-09 Thread GitBox
idbeta commented on a change in pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539783207 ## File path: .github/workflows/frontend-e2e-test.yml ## @@ -31,9 +41,20 @@ jobs: with: node-version: 14.x - - name: Inst

[GitHub] [apisix-dashboard] idbeta commented on pull request #982: draft: add frontend e2e test for create route

2020-12-09 Thread GitBox
idbeta commented on pull request #982: URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742178286 > ready for review? I want to try the `delete route` action again This is an automated message from

[GitHub] [apisix-ingress-controller] tokers opened a new issue #74: CI/CD Integration

2020-12-09 Thread GitBox
tokers opened a new issue #74: URL: https://github.com/apache/apisix-ingress-controller/issues/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1000: fix: backend e2e test failed

2020-12-09 Thread GitBox
nic-chen opened a new pull request #1000: URL: https://github.com/apache/apisix-dashboard/pull/1000 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Relate

[GitHub] [apisix-ingress-controller] tokers commented on issue #50: Discuss: how to configure `admin_key` for multi-APISIX cluster.

2020-12-09 Thread GitBox
tokers commented on issue #50: URL: https://github.com/apache/apisix-ingress-controller/issues/50#issuecomment-742174134 Secret is the most appropriate way, we can watch all namespaces except some unexpected like kube-system, istio-system and etc.

  1   2   3   >