[GitHub] [apisix-ingress-controller] gxthrj merged pull request #102: fix: set base url to seven module

2020-12-15 Thread GitBox
gxthrj merged pull request #102: URL: https://github.com/apache/apisix-ingress-controller/pull/102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: fix: set base url to seven module (#102)

2020-12-15 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 53496e6 fix: set base url to

[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #102: fix: set base url to seven module

2020-12-15 Thread GitBox
tokers edited a comment on pull request #102: URL: https://github.com/apache/apisix-ingress-controller/pull/102#issuecomment-745853609 > We can add a test case about `baseUrl`. We can only add very shallow test cases like checking the value is really set to conf.BaseUrl. We

[GitHub] [apisix-ingress-controller] tokers commented on pull request #102: fix: set base url to seven module

2020-12-15 Thread GitBox
tokers commented on pull request #102: URL: https://github.com/apache/apisix-ingress-controller/pull/102#issuecomment-745853609 > We can add a test case about `baseUrl`. We can only add very shallow test cases like checking the value is really set to conf.BaseUrl. We cannot

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
tokers commented on a change in pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r544076003 ## File path: go.mod ## @@ -10,6 +10,7 @@ require ( github.com/gxthrj/apisix-types v0.1.0 github.com/gxthrj/seven v0.1.9

[GitHub] [apisix-dashboard] nic-chen commented on issue #1058: 'schema-sync.sh' generates jsonschema data for apisix error

2020-12-15 Thread GitBox
nic-chen commented on issue #1058: URL: https://github.com/apache/apisix-dashboard/issues/1058#issuecomment-745818643 @Caelebs Apache APISIX 2.1 doesn't have the `error-log-logger` plugin. you could download in on: https://github.com/apache/apisix/releases/tag/2.1

[GitHub] [apisix-dashboard] Caelebs opened a new issue #1058: 'schema-sync.sh' generates jsonschema data for apisix error

2020-12-15 Thread GitBox
Caelebs opened a new issue #1058: URL: https://github.com/apache/apisix-dashboard/issues/1058 # Bug report [After modifying the plugin schema or creating a custom plugin in Apache APISIX, why can't I find it on the

[GitHub] [apisix] Yiyiyimu commented on issue #3057: bug: missing copy the files in `conf/cert`

2020-12-15 Thread GitBox
Yiyiyimu commented on issue #3057: URL: https://github.com/apache/apisix/issues/3057#issuecomment-745808050 My bad, missed this part. Thank you for point it out! BTW, do we have some test to test if `make install` could work correctly and build apisix successfully, like does the

[GitHub] [apisix] Yiyiyimu opened a new pull request #3059: fix: copy the files in conf/cert when installing

2020-12-15 Thread GitBox
Yiyiyimu opened a new pull request #3059: URL: https://github.com/apache/apisix/pull/3059 Signed-off-by: yiyiyimu ### What this PR does / why we need it: fix #3057 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #102: fix: set base url to seven module

2020-12-15 Thread GitBox
gxthrj commented on pull request #102: URL: https://github.com/apache/apisix-ingress-controller/pull/102#issuecomment-745802498 We can add a test case about `baseUrl`. This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] tokers commented on pull request #102: fix: set base url to seven module

2020-12-15 Thread GitBox
tokers commented on pull request #102: URL: https://github.com/apache/apisix-ingress-controller/pull/102#issuecomment-745800572 @gxthrj After merging, the docker image should be rebuilt  This is an automated message from

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #102: fix: set base url to seven module

2020-12-15 Thread GitBox
tokers opened a new pull request #102: URL: https://github.com/apache/apisix-ingress-controller/pull/102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] Fuchange commented on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-15 Thread GitBox
Fuchange commented on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745791819 > @Fuchange > 需要测试用例。 > 请参考:[https](https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh) :

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1056: feat: Refactor frontend e2e

2020-12-15 Thread GitBox
codecov-io edited a comment on pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#issuecomment-745188749 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1056?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-15 Thread GitBox
codecov-io edited a comment on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745195155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1055?src=pr=h1) Report > Merging

[GitHub] [apisix] NetRainn commented on issue #3058: bug:

2020-12-15 Thread GitBox
NetRainn commented on issue #3058: URL: https://github.com/apache/apisix/issues/3058#issuecomment-745773840 error.log Authorization is JWT token Did I use UUID? --原始邮件-- 发件人:

[GitHub] [apisix] spacewander commented on issue #3058: bug:

2020-12-15 Thread GitBox
spacewander commented on issue #3058: URL: https://github.com/apache/apisix/issues/3058#issuecomment-745772036 Show the backtrack in the error log, and your Authorization header's value? This is an automated message from the

[GitHub] [apisix] NetRainn opened a new issue #3058: bug:

2020-12-15 Thread GitBox
NetRainn opened a new issue #3058: URL: https://github.com/apache/apisix/issues/3058 # Use openid-connect

[GitHub] [apisix] spacewander commented on issue #3056: request help: prometheus port security problem

2020-12-15 Thread GitBox
spacewander commented on issue #3056: URL: https://github.com/apache/apisix/issues/3056#issuecomment-745767975 But we can add it to the TODO list. Maybe finish it in release 2.3? This is an automated message from the Apache

[GitHub] [apisix] spacewander commented on issue #3056: request help: prometheus port security problem

2020-12-15 Thread GitBox
spacewander commented on issue #3056: URL: https://github.com/apache/apisix/issues/3056#issuecomment-745756979 No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander commented on issue #3054: bug: {"error_msg":"404 Route Not Found"}

2020-12-15 Thread GitBox
spacewander commented on issue #3054: URL: https://github.com/apache/apisix/issues/3054#issuecomment-745756940 The admin port was changed to 9180. But the change is reverted before 2.1 release. I tried both the tag and release from

[GitHub] [apisix] spacewander commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543929390 ## File path: apisix/control/v1.lua ## @@ -0,0 +1,33 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] spacewander commented on pull request #3048: feat: add control API

2020-12-15 Thread GitBox
spacewander commented on pull request #3048: URL: https://github.com/apache/apisix/pull/3048#issuecomment-745744682 Related issue: #2798 #3022 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] ziyou434 commented on issue #3056: request help: prometheus port security problem

2020-12-15 Thread GitBox
ziyou434 commented on issue #3056: URL: https://github.com/apache/apisix/issues/3056#issuecomment-745743963 > You should provide an example to prove it is invalid. I tried myself, it works! emm, example involve some sensitive information, maybe my operator have mistake. Actually

[GitHub] [apisix] spacewander commented on issue #2658: bug: 用plugin-interceptors方法对/apisix/prometheus/metrics目录进行限制无效

2020-12-15 Thread GitBox
spacewander commented on issue #2658: URL: https://github.com/apache/apisix/issues/2658#issuecomment-745742224 You should provide an example to prove it is invalid. I tried myself, it works! This is an automated message

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-15 Thread GitBox
codecov-io edited a comment on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745195155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1055?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander commented on issue #3056: request help: prometheus port security problem

2020-12-15 Thread GitBox
spacewander commented on issue #3056: URL: https://github.com/apache/apisix/issues/3056#issuecomment-745742180 You should provide an example to prove it is invalid. I tried myself, it works! This is an automated message

[GitHub] [apisix] membphis commented on issue #3057: bug: missing copy the files in `conf/cert`

2020-12-15 Thread GitBox
membphis commented on issue #3057: URL: https://github.com/apache/apisix/issues/3057#issuecomment-745739457 @Yiyiyimu would you like to fix this issue? This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] membphis opened a new issue #3057: bug: missing copy the files in `conf/cert`

2020-12-15 Thread GitBox
membphis opened a new issue #3057: URL: https://github.com/apache/apisix/issues/3057 the APISIX enabled the SSL by default, PR: https://github.com/apache/apisix/commit/b7325f033ea721307c6b52beb52c85beaf710f28 so we need to copy the files in `conf/cert` too when installing.

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-15 Thread GitBox
codecov-io edited a comment on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745195155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1055?src=pr=h1) Report > Merging

[GitHub] [apisix] membphis commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
membphis commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543878209 ## File path: .travis/apisix_cli_test/test_control.sh ## @@ -0,0 +1,118 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] ziyou434 opened a new issue #3056: request help: prometheus port security problem

2020-12-15 Thread GitBox
ziyou434 opened a new issue #3056: URL: https://github.com/apache/apisix/issues/3056 ### Issue description Now prometheus use 9080 port,It's not safe. APISIX provide a IP Interceptors to ensure safety, but now it's Invalid. #2658 Port isolation is actually a more reasonable

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #979: Refactor online debug be

2020-12-15 Thread GitBox
imjoey commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r543860366 ## File path: api/test/e2e/route_online_debug_test.go ## @@ -42,7 +42,7 @@ func TestRoute_Online_Debug_Route_Not_Exist(t *testing.T) {

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1057: feat: support global rules for Manager API

2020-12-15 Thread GitBox
nic-chen opened a new pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance -

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
tokers commented on a change in pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543836431 ## File path: go.mod ## @@ -10,6 +10,7 @@ require ( github.com/gxthrj/apisix-types v0.1.0 github.com/gxthrj/seven v0.1.9

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
membphis commented on a change in pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543816381 ## File path: go.mod ## @@ -10,6 +10,7 @@ require ( github.com/gxthrj/apisix-types v0.1.0 github.com/gxthrj/seven

[apisix-ingress-controller] branch master updated: feat(CI): add a GitHub Action to lint the Markdown (#97)

2020-12-15 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 7be0167 feat(CI): add a GitHub

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #97: feat(CI): add a GitHub Action to lint the Markdown

2020-12-15 Thread GitBox
gxthrj merged pull request #97: URL: https://github.com/apache/apisix-ingress-controller/pull/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-15 Thread GitBox
nic-chen commented on pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-745707428 > It seems that the E2E test cases is unstable, @nic-chen please take a look: > > ``` > --- FAIL: TestRoute_Create_Service (0.93s) > Error:

[GitHub] [apisix] spacewander commented on a change in pull request #3023: fix: make debug-mode work with global rule

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3023: URL: https://github.com/apache/apisix/pull/3023#discussion_r543812186 ## File path: doc/architecture-design.md ## @@ -657,6 +657,9 @@ Server: openresty hello world ``` +If the information can be delivered via HTTP

[GitHub] [apisix] spacewander commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543808879 ## File path: doc/control-api.md ## @@ -0,0 +1,51 @@ + + +The control API can be used to +* expose APISIX internal state +* control the behavior of a

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
tokers commented on a change in pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543806297 ## File path: go.mod ## @@ -10,6 +10,7 @@ require ( github.com/gxthrj/apisix-types v0.1.0 github.com/gxthrj/seven v0.1.9

[GitHub] [apisix] spacewander commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543801690 ## File path: apisix/control/router.lua ## @@ -0,0 +1,107 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] spacewander commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543799370 ## File path: apisix/plugins/example-plugin.lua ## @@ -109,4 +110,28 @@ function _M.access(conf, ctx) end +local function hello() +local args

[GitHub] [apisix] nic-chen commented on issue #3037: after configoure the SSL,log error

2020-12-15 Thread GitBox
nic-chen commented on issue #3037: URL: https://github.com/apache/apisix/issues/3037#issuecomment-745694245 @liyin37 hi,how do you config your SSL? and what is the SSL data saved in ETCD? This is an automated message

[GitHub] [apisix] ziyou434 closed issue #3054: bug: {"error_msg":"404 Route Not Found"}

2020-12-15 Thread GitBox
ziyou434 closed issue #3054: URL: https://github.com/apache/apisix/issues/3054 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] ziyou434 commented on issue #3054: bug: {"error_msg":"404 Route Not Found"}

2020-12-15 Thread GitBox
ziyou434 commented on issue #3054: URL: https://github.com/apache/apisix/issues/3054#issuecomment-745693961 I have got the reason, open the admin port, the admin api should use http://127.0.0.1:9180/apisix/admin. I will close the issue.

[GitHub] [apisix] spacewander closed issue #3055: bug: environment variable can not work well in yaml

2020-12-15 Thread GitBox
spacewander closed issue #3055: URL: https://github.com/apache/apisix/issues/3055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #3055: bug: environment variable can not work well in yaml

2020-12-15 Thread GitBox
spacewander commented on issue #3055: URL: https://github.com/apache/apisix/issues/3055#issuecomment-745693600 Duplicate of https://github.com/apache/apisix/issues/3017 This is an automated message from the Apache Git

[GitHub] [apisix] spacewander merged pull request #3053: feat: improve the error msg when client doesn't send SNI

2020-12-15 Thread GitBox
spacewander merged pull request #3053: URL: https://github.com/apache/apisix/pull/3053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: improve the error msg when client doesn't send SNI (#3053)

2020-12-15 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 370beda feat: improve the error msg when

[GitHub] [apisix] spacewander commented on issue #3017: request help: set ENV variable in config.yaml, then admin API call still didn't recognize it

2020-12-15 Thread GitBox
spacewander commented on issue #3017: URL: https://github.com/apache/apisix/issues/3017#issuecomment-745692527 > Just make sure, will we backport this to the released v2.1 version? Even we backport it to v2.1, we still need to create a new release as v2.1.1. Currently there is no

[GitHub] [apisix] tzssangglass commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-15 Thread GitBox
tzssangglass commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r543495083 ## File path: t/admin/plugins.t ## @@ -162,3 +162,65 @@ plugins: } --- no_error_log [error] + + + +=== TEST 8: get all the attributes of all

[GitHub] [apisix] tzssangglass commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-15 Thread GitBox
tzssangglass commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r543493373 ## File path: t/admin/plugins.t ## @@ -162,3 +162,65 @@ plugins: } --- no_error_log [error] + + + +=== TEST 8: get all the attributes of all

[GitHub] [apisix] tzssangglass commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-15 Thread GitBox
tzssangglass commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r543490902 ## File path: doc/zh-cn/admin-api.md ## @@ -754,3 +754,15 @@ Content-Type: text/plain ``` [Back to TOC](#目录) +

[GitHub] [apisix] nanamikon commented on issue #3055: bug: environment variable can not work well in yaml

2020-12-15 Thread GitBox
nanamikon commented on issue #3055: URL: https://github.com/apache/apisix/issues/3055#issuecomment-745378724 refer to https://github.com/apache/apisix/issues/3017 This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #978: Refactor online debug fe

2020-12-15 Thread GitBox
juzhiyuan commented on a change in pull request #978: URL: https://github.com/apache/apisix-dashboard/pull/978#discussion_r543448524 ## File path: web/src/pages/Route/components/DebugViews/DebugDrawView.tsx ## @@ -170,7 +172,7 @@ const DebugDrawView: React.FC = (props) => {

[GitHub] [apisix] nanamikon opened a new issue #3055: bug: environment variable can not work well in yaml

2020-12-15 Thread GitBox
nanamikon opened a new issue #3055: URL: https://github.com/apache/apisix/issues/3055 ### Issue description ### Environment * apisix version (cmd: `apisix version`): 2.1 * OS: mac ### Minimal test code / Steps to reproduce the issue config.ymal ``` etcd:

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #979: Refactor online debug be

2020-12-15 Thread GitBox
liuxiran commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r543415884 ## File path: api/test/e2e/route_online_debug_test.go ## @@ -42,7 +42,7 @@ func TestRoute_Online_Debug_Route_Not_Exist(t *testing.T) {

[GitHub] [apisix-dashboard] starsz commented on pull request #1051: feat: support search route by label

2020-12-15 Thread GitBox
starsz commented on pull request #1051: URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-745342934 > @starsz this is a big PR, can we split this PR to multiple small PRs? > > small PR is easy to review and merge, and we can implement this feature step by step

[GitHub] [apisix] membphis commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-15 Thread GitBox
membphis commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r543394249 ## File path: doc/zh-cn/admin-api.md ## @@ -754,3 +754,15 @@ Content-Type: text/plain ``` [Back to TOC](#目录) + +*地址*:/apisix/admin/plugins/?all=true

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #979: Refactor online debug be

2020-12-15 Thread GitBox
membphis commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r543388169 ## File path: api/test/e2e/route_online_debug_test.go ## @@ -42,7 +42,7 @@ func TestRoute_Online_Debug_Route_Not_Exist(t *testing.T) {

[GitHub] [apisix-dashboard] membphis edited a comment on pull request #1051: feat: support search route by label

2020-12-15 Thread GitBox
membphis edited a comment on pull request #1051: URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-745315051 @starsz this is a big PR, can we split this PR to multiple small PRs? small PR is easy to review and merge, and we can implement this feature step by

[GitHub] [apisix-dashboard] membphis commented on pull request #1051: feat: support search route by label

2020-12-15 Thread GitBox
membphis commented on pull request #1051: URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-745315051 @starsz this is a big PR, can we split this PR to multiple small PRs? small PR is easy to review and merge.

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #979: Refactor online debug be

2020-12-15 Thread GitBox
nic-chen commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r543381385 ## File path: api/internal/handler/route/route.go ## @@ -397,3 +401,61 @@ func Exist(c *gin.Context) (interface{}, error) { return nil,

[GitHub] [apisix-dashboard] membphis commented on pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-15 Thread GitBox
membphis commented on pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-745312361 It seems that the E2E test cases is unstable, @nic-chen please take a look: ``` --- FAIL: TestRoute_Create_Service (0.93s) Error: printer.go:54: GET

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-15 Thread GitBox
membphis commented on a change in pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r543377491 ## File path: api/test/e2e/route_test.go ## @@ -224,6 +224,48 @@ func TestRoute_Update_Routes_With_Hosts(t *testing.T) { } } +func

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
membphis commented on a change in pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543369360 ## File path: go.mod ## @@ -10,6 +10,7 @@ require ( github.com/gxthrj/apisix-types v0.1.0 github.com/gxthrj/seven

[GitHub] [apisix] membphis commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
membphis commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543349592 ## File path: apisix/control/v1.lua ## @@ -0,0 +1,33 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] membphis closed issue #3039: request help: question about time zone

2020-12-15 Thread GitBox
membphis closed issue #3039: URL: https://github.com/apache/apisix/issues/3039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis merged pull request #3049: fix: remove hardcoded TZ env

2020-12-15 Thread GitBox
membphis merged pull request #3049: URL: https://github.com/apache/apisix/pull/3049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: fix: remove hardcoded TZ env (#3049)

2020-12-15 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 1ece1e1 fix: remove hardcoded TZ env (#3049)

[apisix] branch master updated: feat: share etcd client (#2932)

2020-12-15 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new d16ac7a feat: share etcd client (#2932)

[GitHub] [apisix] spacewander merged pull request #2932: feat: share etcd client

2020-12-15 Thread GitBox
spacewander merged pull request #2932: URL: https://github.com/apache/apisix/pull/2932 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
codecov-io edited a comment on pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
codecov-io commented on pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #101: test: add e2e test scaffold

2020-12-15 Thread GitBox
tokers opened a new pull request #101: URL: https://github.com/apache/apisix-ingress-controller/pull/101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] jbampton commented on a change in pull request #3023: fix: make debug-mode work with global rule

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #3023: URL: https://github.com/apache/apisix/pull/3023#discussion_r543272990 ## File path: doc/architecture-design.md ## @@ -657,6 +657,9 @@ Server: openresty hello world ``` +If the information can be delivered via HTTP

[GitHub] [apisix] jbampton commented on a change in pull request #3021: feat: rewrite handwriting validation with jsonschema

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #3021: URL: https://github.com/apache/apisix/pull/3021#discussion_r543275699 ## File path: apisix/plugins/openid-connect.lua ## @@ -148,6 +150,13 @@ end function _M.rewrite(plugin_conf, ctx) local conf =

[GitHub] [apisix] membphis commented on a change in pull request #2932: feat: share etcd client

2020-12-15 Thread GitBox
membphis commented on a change in pull request #2932: URL: https://github.com/apache/apisix/pull/2932#discussion_r543274675 ## File path: t/node/healthcheck-passive.t ## @@ -56,7 +56,7 @@ __DATA__ "interval": 100,

[GitHub] [apisix] jbampton commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543267735 ## File path: doc/control-api.md ## @@ -0,0 +1,51 @@ + + +The control API can be used to +* expose APISIX internal state +* control the behavior of a

[GitHub] [apisix] spacewander commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543261850 ## File path: doc/control-api.md ## @@ -0,0 +1,51 @@ + + +The control API can be used to +* expose APISIX internal state +* control the behavior of a

[GitHub] [apisix] jbampton commented on a change in pull request #3048: feat: add control API

2020-12-15 Thread GitBox
jbampton commented on a change in pull request #3048: URL: https://github.com/apache/apisix/pull/3048#discussion_r543257943 ## File path: .travis/apisix_cli_test/test_ci_only.sh ## @@ -17,18 +17,10 @@ # limitations under the License. # -# This file is like

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #98: chore: all modules use new config

2020-12-15 Thread GitBox
gxthrj merged pull request #98: URL: https://github.com/apache/apisix-ingress-controller/pull/98 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: chore: all modules use new config (#98)

2020-12-15 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 90f6638 chore: all modules use

[GitHub] [apisix] spacewander commented on a change in pull request #2932: feat: share etcd client

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #2932: URL: https://github.com/apache/apisix/pull/2932#discussion_r543259342 ## File path: t/node/healthcheck-passive.t ## @@ -56,7 +56,7 @@ __DATA__ "interval": 100,

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #98: chore: all modules use new config

2020-12-15 Thread GitBox
codecov-io commented on pull request #98: URL: https://github.com/apache/apisix-ingress-controller/pull/98#issuecomment-745223483 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/98?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] tokers commented on pull request #98: chore: all modules use new config

2020-12-15 Thread GitBox
tokers commented on pull request #98: URL: https://github.com/apache/apisix-ingress-controller/pull/98#issuecomment-745221295 > > > @gxthrj After this PR is merged, the dev docker image should be updated, also, docs and samples should be changed, since the way we configure ingress apisix

[GitHub] [apisix-ingress-controller] sober-wang commented on issue #100: standard_init_linux.go:211: exec user process caused "no such file or directory"

2020-12-15 Thread GitBox
sober-wang commented on issue #100: URL: https://github.com/apache/apisix-ingress-controller/issues/100#issuecomment-745218606 > > > > @sober-wang I have submitted a PR #98 , which configures ingress apisix by commands, > >

[GitHub] [apisix] ziyou434 commented on issue #2658: bug: 用plugin-interceptors方法对/apisix/prometheus/metrics目录进行限制无效

2020-12-15 Thread GitBox
ziyou434 commented on issue #2658: URL: https://github.com/apache/apisix/issues/2658#issuecomment-745212800 I found it still doesn't work in 2.1 version @spacewander This is an automated message from the Apache Git Service.

[GitHub] [apisix] spacewander commented on a change in pull request #3053: feat: improve the error msg when client doesn't send SNI

2020-12-15 Thread GitBox
spacewander commented on a change in pull request #3053: URL: https://github.com/apache/apisix/pull/3053#discussion_r543223500 ## File path: apisix/ssl/router/radixtree_sni.lua ## @@ -208,7 +208,9 @@ function _M.match_and_set(api_ctx) local sni sni, err =

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-15 Thread GitBox
codecov-io commented on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745195155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1055?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3053: feat: improve the error msg when client doesn't send SNI

2020-12-15 Thread GitBox
Firstsawyou commented on a change in pull request #3053: URL: https://github.com/apache/apisix/pull/3053#discussion_r543218611 ## File path: apisix/ssl/router/radixtree_sni.lua ## @@ -208,7 +208,9 @@ function _M.match_and_set(api_ctx) local sni sni, err =

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1056: feat: Refactor frontend e2e

2020-12-15 Thread GitBox
codecov-io commented on pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#issuecomment-745188749 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1056?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander merged pull request #3050: feat: return 502 for upstream not found in the DP

2020-12-15 Thread GitBox
spacewander merged pull request #3050: URL: https://github.com/apache/apisix/pull/3050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #3035: bug: del upstream but not del route, request the route, return 500

2020-12-15 Thread GitBox
spacewander closed issue #3035: URL: https://github.com/apache/apisix/issues/3035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feat: return 502 for upstream not found in the DP (#3050)

2020-12-15 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 8420a0f feat: return 502 for upstream not

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-15 Thread GitBox
nic-chen commented on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745184428 @Fuchange Test case needed. Please refer: https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh Thanks.

[GitHub] [apisix] ziyou434 commented on issue #3054: bug: {"error_msg":"404 Route Not Found"}

2020-12-15 Thread GitBox
ziyou434 commented on issue #3054: URL: https://github.com/apache/apisix/issues/3054#issuecomment-745183882 ``` # Configuration File - Nginx Server Configs # This is a read-only file, do not try to modify it. master_process on; worker_processes auto;

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1056: feat: Refactor frontend e2e

2020-12-15 Thread GitBox
LiteSun opened a new pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [x] Improve performance -

  1   2   >