[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544878303 ## File path: pkg/ingress/apisix/tls.go ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contr

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544876783 ## File path: pkg/ingress/controller/apisix_tls.go ## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544876592 ## File path: pkg/ingress/controller/apisix_tls.go ## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix] ziyou434 commented on issue #3062: request help: core.request.get_body()

2020-12-16 Thread GitBox
ziyou434 commented on issue #3062: URL: https://github.com/apache/apisix/issues/3062#issuecomment-747272459 finally I find ngx.log cut the body ,get_body() can receive all charactors. I will close this issue. This is an au

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
tokers commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544874266 ## File path: pkg/ingress/apisix/tls.go ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contr

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #103: fix: add item to workqueue with delay when syncFailed

2020-12-16 Thread GitBox
tokers commented on a change in pull request #103: URL: https://github.com/apache/apisix-ingress-controller/pull/103#discussion_r544738012 ## File path: pkg/ingress/controller/apisix_route.go ## @@ -144,6 +144,7 @@ func (c *ApisixRouteController) processNextWorkItem() bool {

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #958: feat: implement API to get apisix instances status

2020-12-16 Thread GitBox
starsz commented on a change in pull request #958: URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r544866618 ## File path: api/internal/handler/server_info/server_info_test.go ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix-dashboard] starsz commented on pull request #1051: feat: support search route by label

2020-12-16 Thread GitBox
starsz commented on pull request #1051: URL: https://github.com/apache/apisix-dashboard/pull/1051#issuecomment-747263698 I will split it into two PRs. The first is #1061. And after merging, I will push the second PR. Th

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #958: feat: implement API to get apisix instances status

2020-12-16 Thread GitBox
starsz commented on a change in pull request #958: URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r544859611 ## File path: api/test/e2e/server_info_test.go ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1062: chore(deps): update actions/setup-node requirement to v2.1.4

2020-12-16 Thread GitBox
codecov-io commented on pull request #1062: URL: https://github.com/apache/apisix-dashboard/pull/1062#issuecomment-747256318 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1062?src=pr&el=h1) Report > Merging [#1062](https://codecov.io/gh/apache/apisix-dashboard/pull/106

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544858010 ## File path: samples/deploy/crd/v1beta1/ApisixTls.yaml ## @@ -0,0 +1,34 @@ +# Review comment: Will test. --

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #95: feat: support TLS

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#issuecomment-746265626 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/95?src=pr&el=h1) Report > Merging [#95](https://codecov.io/gh/apache/apisix-

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544857724 ## File path: samples/deploy/rbac/apisix_view_clusterrole.yaml ## @@ -137,6 +137,7 @@ rules: - apisixroutes - apisixupstreams - api

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #95: feat: support TLS

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#issuecomment-746265626 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/95?src=pr&el=h1) Report > Merging [#95](https://codecov.io/gh/apache/apisix-

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544857486 ## File path: samples/deploy/crd/v1beta1/ApisixTls.yaml ## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #95: feat: support TLS

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#issuecomment-746265626 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/95?src=pr&el=h1) Report > Merging [#95](https://codecov.io/gh/apache/apisix-

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544856536 ## File path: pkg/ingress/controller/apisix_tls.go ## @@ -0,0 +1,186 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544856075 ## File path: pkg/ingress/apisix/tls_test.go ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [apisix-dashboard] dependabot[bot] opened a new pull request #1062: chore(deps): update actions/setup-node requirement to v2.1.4

2020-12-16 Thread GitBox
dependabot[bot] opened a new pull request #1062: URL: https://github.com/apache/apisix-dashboard/pull/1062 Updates the requirements on [actions/setup-node](https://github.com/actions/setup-node) to permit the latest version. Release notes Sourced from https://github.com/actions/s

[apisix-dashboard] branch dependabot/github_actions/actions/setup-node-v2.1.4 created (now 86eb096)

2020-12-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-v2.1.4 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 86eb096 chore(deps): update actions/setup-node requireme

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544855182 ## File path: pkg/ingress/apisix/tls.go ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contr

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544854332 ## File path: pkg/ingress/apisix/tls.go ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contr

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
gxthrj commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544852771 ## File path: cmd/ingress/ingress.go ## @@ -102,6 +102,8 @@ func NewIngressCommand() *cobra.Command { c.ApisixUpstre

[GitHub] [apisix-dashboard] starsz opened a new pull request #1061: feat: support search route by label

2020-12-16 Thread GitBox
starsz opened a new pull request #1061: URL: https://github.com/apache/apisix-dashboard/pull/1061 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix] Jaycean closed pull request #3067: chore: fix makefile indentation format error

2020-12-16 Thread GitBox
Jaycean closed pull request #3067: URL: https://github.com/apache/apisix/pull/3067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix-ingress-controller] tokers closed issue #14: BUG: Route mybe no desc field. And code not go fmt

2020-12-16 Thread GitBox
tokers closed issue #14: URL: https://github.com/apache/apisix-ingress-controller/issues/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-ingress-controller] tokers commented on issue #14: BUG: Route mybe no desc field. And code not go fmt

2020-12-16 Thread GitBox
tokers commented on issue #14: URL: https://github.com/apache/apisix-ingress-controller/issues/14#issuecomment-747220637 Solved since #9 merged. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [apisix-ingress-controller] tokers commented on issue #33: I execute the yaml file in k8s and report such an error in the log on the controller

2020-12-16 Thread GitBox
tokers commented on issue #33: URL: https://github.com/apache/apisix-ingress-controller/issues/33#issuecomment-747220447 @maxluo1992 See the point 4 in https://github.com/apache/apisix-ingress-controller/blob/master/docs/FAQ.md. ---

[GitHub] [apisix-ingress-controller] tokers closed issue #33: I execute the yaml file in k8s and report such an error in the log on the controller

2020-12-16 Thread GitBox
tokers closed issue #33: URL: https://github.com/apache/apisix-ingress-controller/issues/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-ingress-controller] tokers commented on issue #32: runtime error: invalid memory address or nil pointer dereference

2020-12-16 Thread GitBox
tokers commented on issue #32: URL: https://github.com/apache/apisix-ingress-controller/issues/32#issuecomment-747220090 Solved since #9 merged. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [apisix-ingress-controller] tokers closed issue #32: runtime error: invalid memory address or nil pointer dereference

2020-12-16 Thread GitBox
tokers closed issue #32: URL: https://github.com/apache/apisix-ingress-controller/issues/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #979: Refactor online debug be

2020-12-16 Thread GitBox
liuxiran commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r544826857 ## File path: api/internal/handler/route/route.go ## @@ -397,3 +401,61 @@ func Exist(c *gin.Context) (interface{}, error) { return nil,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #979: Refactor online debug be

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#issuecomment-742940185 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/979?src=pr&el=h1) Report > Merging [#979](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #104: doc: how to remove apisix admin key

2020-12-16 Thread GitBox
gxthrj merged pull request #104: URL: https://github.com/apache/apisix-ingress-controller/pull/104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: doc: how to remove apisix admin key (#104)

2020-12-16 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 19ce6c6 doc: how to remove apis

[GitHub] [apisix-dashboard] codecov-io commented on pull request #991: feat: refactor publish/offline fe

2020-12-16 Thread GitBox
codecov-io commented on pull request #991: URL: https://github.com/apache/apisix-dashboard/pull/991#issuecomment-747217119 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/991?src=pr&el=h1) Report > Merging [#991](https://codecov.io/gh/apache/apisix-dashboard/pull/991?src

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1060: feat(CI): add a GitHub Action to lint the YAML

2020-12-16 Thread GitBox
juzhiyuan merged pull request #1060: URL: https://github.com/apache/apisix-dashboard/pull/1060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated (303cc56 -> d1107ec)

2020-12-16 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 303cc56 docs: update CHANGELOG for v2.2 (#1037) add d1107ec feat(CI): add a GitHub Action to lint

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-16 Thread GitBox
liuxiran commented on a change in pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r544810323 ## File path: api/test/e2e/route_test.go ## @@ -224,6 +224,48 @@ func TestRoute_Update_Routes_With_Hosts(t *testing.T) { } } +func Te

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-744468932 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=h1) Report > Merging [#1049](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] Jaycean opened a new pull request #3067: chore:fix makefile indentation format error

2020-12-16 Thread GitBox
Jaycean opened a new pull request #3067: URL: https://github.com/apache/apisix/pull/3067 Signed-off-by: Jacean ### What this PR does / why we need it: - fix makefile indentation format error ### Pre-submission checklist: * [x] Did you explain what problem does this P

[GitHub] [apisix-ingress-controller] tokers commented on issue #32: runtime error: invalid memory address or nil pointer dereference

2020-12-16 Thread GitBox
tokers commented on issue #32: URL: https://github.com/apache/apisix-ingress-controller/issues/32#issuecomment-747187947 Duplicated with #14 . This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #104: doc: how to remove apisix admin key

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #104: URL: https://github.com/apache/apisix-ingress-controller/pull/104#issuecomment-747175088 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/104?src=pr&el=h1) Report > Merging [#104](https://codecov.io/gh/apache/api

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #104: doc: how to remove apisix admin key

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #104: URL: https://github.com/apache/apisix-ingress-controller/pull/104#issuecomment-747175088 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/104?src=pr&el=h1) Report > Merging [#104](https://codecov.io/gh/apache/api

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1055: fix: absolute Paths conf.WebDir

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#issuecomment-745195155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1055?src=pr&el=h1) Report > Merging [#1055](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] idbeta commented on pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
idbeta commented on pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#issuecomment-747175312 > LGTM except for 2 things: > > 1. The CreateRouteTest needs @idbeta's confirmation; > 2. hmm we have some Chinese in this test, this issue is related to i18n,

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #104: doc: how to remove apisix admin key

2020-12-16 Thread GitBox
codecov-io commented on pull request #104: URL: https://github.com/apache/apisix-ingress-controller/pull/104#issuecomment-747175088 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/104?src=pr&el=h1) Report > Merging [#104](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #104: doc: how to remove apisix admin key

2020-12-16 Thread GitBox
tokers opened a new pull request #104: URL: https://github.com/apache/apisix-ingress-controller/pull/104 Solve https://github.com/apache/apisix-ingress-controller/issues/33. This is an automated message from the Apache Git Se

[GitHub] [apisix-dashboard] Fuchange commented on a change in pull request #1055: fix: absolute Paths conf.WebDir

2020-12-16 Thread GitBox
Fuchange commented on a change in pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#discussion_r544777808 ## File path: api/test/shell/cli_test.sh ## @@ -95,6 +95,26 @@ if [[ `grep -c "INFO" ./error.log` -eq '0' ]]; then exit 1 fi +# run on a

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
idbeta commented on a change in pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#discussion_r54442 ## File path: web/cypress/integration/route/create_and_delete_route.spec.js ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [apisix] spacewander commented on a change in pull request #3044: feat(CI): add a GitHub Action to lint the YAML files

2020-12-16 Thread GitBox
spacewander commented on a change in pull request #3044: URL: https://github.com/apache/apisix/pull/3044#discussion_r544777287 ## File path: conf/config-default.yaml ## @@ -205,8 +206,8 @@ plugins: # plugin list (sorted in alphabetical order) - cons

[GitHub] [apisix] spacewander opened a new pull request #3066: test: remove useless skywalking mock

2020-12-16 Thread GitBox
spacewander opened a new pull request #3066: URL: https://github.com/apache/apisix/pull/3066 Now we connect to real skywalking for test. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain

[GitHub] [apisix] spacewander opened a new pull request #3065: fix: upgrade lua-resty-ngxvar to solve the upstream_xxx_time problem

2020-12-16 Thread GitBox
spacewander opened a new pull request #3065: URL: https://github.com/apache/apisix/pull/3065 Fix #2954 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or w

[GitHub] [apisix-ingress-controller] tokers commented on issue #33: I execute the yaml file in k8s and report such an error in the log on the controller

2020-12-16 Thread GitBox
tokers commented on issue #33: URL: https://github.com/apache/apisix-ingress-controller/issues/33#issuecomment-747170482 @maxluo1992 This is due to the lack of admin_key support, we will add some documents to tell users how to close APISIX's admin_key. ---

[GitHub] [apisix-ingress-controller] gxthrj closed issue #51: Discuss: use terratest for testing with Kubernetes

2020-12-16 Thread GitBox
gxthrj closed issue #51: URL: https://github.com/apache/apisix-ingress-controller/issues/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #51: Discuss: use terratest for testing with Kubernetes

2020-12-16 Thread GitBox
gxthrj commented on issue #51: URL: https://github.com/apache/apisix-ingress-controller/issues/51#issuecomment-747167912 Will add terratest in #101 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #74: CI/CD Integration

2020-12-16 Thread GitBox
gxthrj commented on issue #74: URL: https://github.com/apache/apisix-ingress-controller/issues/74#issuecomment-747165801 close this issue , check e2e at #101 This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
idbeta commented on a change in pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#discussion_r544767602 ## File path: web/cypress/support/commands.js ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [apisix-ingress-controller] gxthrj closed issue #74: CI/CD Integration

2020-12-16 Thread GitBox
gxthrj closed issue #74: URL: https://github.com/apache/apisix-ingress-controller/issues/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] ziyou434 commented on issue #3062: request help: core.request.get_body()

2020-12-16 Thread GitBox
ziyou434 commented on issue #3062: URL: https://github.com/apache/apisix/issues/3062#issuecomment-747163765 I redid some experiments and found that 12,000 characters was what ngx.req_get_body_data() got. So I use ngx.req_get_body_file() to find ```lua ngx.req.read_body() lo

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
LiteSun commented on a change in pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#discussion_r544764427 ## File path: docs/front-end-e2e.md ## @@ -0,0 +1,36 @@ + + +This project uses [Cypress](https://www.cypress.io/) as the front-end E2E test fram

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
codecov-io edited a comment on pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#issuecomment-745188749 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1056?src=pr&el=h1) Report > Merging [#1056](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #1055: fix: absolute Paths conf.WebDir

2020-12-16 Thread GitBox
ShiningRush commented on a change in pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#discussion_r544762168 ## File path: api/test/shell/cli_test.sh ## @@ -95,6 +95,26 @@ if [[ `grep -c "INFO" ./error.log` -eq '0' ]]; then exit 1 fi +# run o

[GitHub] [apisix] ziyou434 edited a comment on issue #3062: request help: core.request.get_body()

2020-12-16 Thread GitBox
ziyou434 edited a comment on issue #3062: URL: https://github.com/apache/apisix/issues/3062#issuecomment-747150775 ```lua function _M.get_body(max_size, ctx) -- TODO: improve the check with set client_max_body dynamically -- which requires to change Nginx source code

[GitHub] [apisix] Hcreak edited a comment on issue #3060: bug: kafka logger plugin - failed to process entries: failed to send data to Kafka topic: not found topic

2020-12-16 Thread GitBox
Hcreak edited a comment on issue #3060: URL: https://github.com/apache/apisix/issues/3060#issuecomment-747159569 Kafka is deployed in k8s Cluster. And I provide a packet capture file with apisix and kafka. [kafka_loggger.zip](https://github.com/apache/apisix/files/5706534/kafka_log

[GitHub] [apisix] Hcreak commented on issue #3060: bug: kafka logger plugin - failed to process entries: failed to send data to Kafka topic: not found topic

2020-12-16 Thread GitBox
Hcreak commented on issue #3060: URL: https://github.com/apache/apisix/issues/3060#issuecomment-747159569 Kafka is deployed in k8s Cluster. And I provide a packet capture file with apisix and kafka. [kafka_loggger.zip](https://github.com/apache/apisix/files/5706534/kafka_loggger.zi

[GitHub] [apisix-dashboard] Fuchange commented on a change in pull request #1055: fix: absolute Paths conf.WebDir

2020-12-16 Thread GitBox
Fuchange commented on a change in pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#discussion_r544755945 ## File path: api/internal/route.go ## @@ -49,9 +49,9 @@ func SetUpRouter() *gin.Engine { store := cookie.NewStore([]byte("secret"))

[GitHub] [apisix-dashboard] Fuchange commented on a change in pull request #1055: fix: absolute Paths conf.WebDir

2020-12-16 Thread GitBox
Fuchange commented on a change in pull request #1055: URL: https://github.com/apache/apisix-dashboard/pull/1055#discussion_r544755865 ## File path: api/conf/conf.go ## @@ -36,7 +36,7 @@ const ( EnvDEV = "dev" EnvLOCAL = "local" - WebDir = "./html" +

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1060: feat(CI): add a GitHub Action to lint the YAML

2020-12-16 Thread GitBox
codecov-io commented on pull request #1060: URL: https://github.com/apache/apisix-dashboard/pull/1060#issuecomment-747155651 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1060?src=pr&el=h1) Report > Merging [#1060](https://codecov.io/gh/apache/apisix-dashboard/pull/106

[GitHub] [apisix-dashboard] jbampton opened a new pull request #1060: feat(CI): add a GitHub Action to lint the YAML

2020-12-16 Thread GitBox
jbampton opened a new pull request #1060: URL: https://github.com/apache/apisix-dashboard/pull/1060 - add a `.yamllint` config file - lint some YAML Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [X] New fe

[GitHub] [apisix-website] juzhiyuan commented on issue #112: Ambiguous dates in web pages

2020-12-16 Thread GitBox
juzhiyuan commented on issue #112: URL: https://github.com/apache/apisix-website/issues/112#issuecomment-747151073 ok This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix] ziyou434 commented on issue #3062: request help: core.request.get_body()

2020-12-16 Thread GitBox
ziyou434 commented on issue #3062: URL: https://github.com/apache/apisix/issues/3062#issuecomment-747150775 ```lua function _M.get_body(max_size, ctx) -- TODO: improve the check with set client_max_body dynamically -- which requires to change Nginx source code if max_

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
LiteSun commented on a change in pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#discussion_r544747686 ## File path: web/cypress/integration/user/login.spec.js ## @@ -14,26 +14,21 @@ * See the License for the specific language governing permissio

[GitHub] [apisix] moonming commented on issue #3063: Not obvious how to report issues

2020-12-16 Thread GitBox
moonming commented on issue #3063: URL: https://github.com/apache/apisix/issues/3063#issuecomment-747140063 Are there examples of other apache projects? This should be a general template This is an automated message from the

[GitHub] [apisix-website] moonming commented on issue #112: Ambiguous dates in web pages

2020-12-16 Thread GitBox
moonming commented on issue #112: URL: https://github.com/apache/apisix-website/issues/112#issuecomment-747139682 @juzhiyuan please take a look This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-website] sebbASF opened a new issue #112: Ambiguous dates in web pages

2020-12-16 Thread GitBox
sebbASF opened a new issue #112: URL: https://github.com/apache/apisix-website/issues/112 The web pages use dates of the form: 10/12/2020 Such dates are ambiguous. It could either mean Oct 12th 2020 (in the US) or Dec 10th 2020 (elsewhere) Numeric-only dates should us

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #95: feat: support TLS

2020-12-16 Thread GitBox
tokers commented on a change in pull request #95: URL: https://github.com/apache/apisix-ingress-controller/pull/95#discussion_r544112231 ## File path: cmd/ingress/ingress.go ## @@ -102,6 +102,8 @@ func NewIngressCommand() *cobra.Command { c.ApisixUpstre

[GitHub] [apisix-website] jbampton opened a new pull request #111: feat(CI): add a GitHub Action to lint the YAML

2020-12-16 Thread GitBox
jbampton opened a new pull request #111: URL: https://github.com/apache/apisix-website/pull/111 - add a `.yamllint` config file - lint some YAML This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #103: fix: add item to workqueue with delay when syncFailed

2020-12-16 Thread GitBox
codecov-io commented on pull request #103: URL: https://github.com/apache/apisix-ingress-controller/pull/103#issuecomment-747137529 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/103?src=pr&el=h1) Report > Merging [#103](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #103: fix: add item to workqueue with delay when syncFailed

2020-12-16 Thread GitBox
gxthrj opened a new pull request #103: URL: https://github.com/apache/apisix-ingress-controller/pull/103 Fix: #59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] spacewander commented on issue #3064: Ambiguous dates in web pages

2020-12-16 Thread GitBox
spacewander commented on issue #3064: URL: https://github.com/apache/apisix/issues/3064#issuecomment-747135918 CC @moonming This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] spacewander commented on issue #3063: Not obvious how to report issues

2020-12-16 Thread GitBox
spacewander commented on issue #3063: URL: https://github.com/apache/apisix/issues/3063#issuecomment-747135877 CC @moonming This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] tokers commented on a change in pull request #2903: feat: Make headers to add to request in openid-connect plugin configurable.

2020-12-16 Thread GitBox
tokers commented on a change in pull request #2903: URL: https://github.com/apache/apisix/pull/2903#discussion_r544731942 ## File path: t/plugin/openid-connect.t ## @@ -626,6 +628,86 @@ Authorization: Bearer eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9.eyJkYXRhMSI6IkRhdGEgM +===

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1056: feat: Refactor frontend e2e

2020-12-16 Thread GitBox
LiteSun commented on a change in pull request #1056: URL: https://github.com/apache/apisix-dashboard/pull/1056#discussion_r544730547 ## File path: web/cypress/integration/route/create_and_delete_route.spec.js ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundatio

[apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-12-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 15adc4a Deploy to GitHub pages

[GitHub] [apisix-website] moonming merged pull request #110: docs: added blog Another way to implement Envoy filter

2020-12-16 Thread GitBox
moonming merged pull request #110: URL: https://github.com/apache/apisix-website/pull/110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-website] branch master updated: docs: added blog Another way to implement Envoy filter (#110)

2020-12-16 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new da7f658 docs: added blog Another way

[GitHub] [apisix] sebbASF opened a new issue #3064: Ambiguous dates in web pages

2020-12-16 Thread GitBox
sebbASF opened a new issue #3064: URL: https://github.com/apache/apisix/issues/3064 The web pages use dates of the form: 10/12/2020 Such dates are ambiguous. It could either mean Oct 12th 2020 (in the US) or Dec 10th 2020 (elsewhere) Numeric-only dates should use the

[GitHub] [apisix] sebbASF opened a new issue #3063: Not obvious how to report issues

2020-12-16 Thread GitBox
sebbASF opened a new issue #3063: URL: https://github.com/apache/apisix/issues/3063 I could not find any mention of *how* to report issues or submit PRs. For someone familiar with how GitHub and the ASF work, it is not difficult to find the GH issue URL, but it is not obvious to those wh

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1059: figure out what happened to gitleaks

2020-12-16 Thread GitBox
juzhiyuan opened a new issue #1059: URL: https://github.com/apache/apisix-dashboard/issues/1059 # Bug report ## Describe the bug https://github.com/apache/apisix-dashboard/runs/1564493861 This is an automate

[apisix-website] branch juzhiyuan-patch-1 updated (1b2ccb4 -> d50eb95)

2020-12-16 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 1b2ccb4 Update 2020-12-16-another-way-to-implement-envoy-filter.md add d50eb95 Update w

[GitHub] [apisix-website] jbampton commented on a change in pull request #110: docs: added blog Another way to implement Envoy filter

2020-12-16 Thread GitBox
jbampton commented on a change in pull request #110: URL: https://github.com/apache/apisix-website/pull/110#discussion_r544375390 ## File path: website/blog/2020-12-16-another-way-to-implement-envoy-filter.md ## @@ -0,0 +1,134 @@ +--- +title: "Envoy and Apache APISIX: Another w

[apisix-website] branch juzhiyuan-patch-1 updated (4e5edc5 -> 1b2ccb4)

2020-12-16 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 4e5edc5 Update 2020-12-16-another-way-to-implement-envoy-filter.md add 1b2ccb4 Update 20

[apisix-website] branch juzhiyuan-patch-1 updated (89e5df3 -> 4e5edc5)

2020-12-16 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 89e5df3 docs: added blog Envoy and Apache APISIX: Another way to implement Envoy filter

[apisix-dashboard] branch master updated: docs: update CHANGELOG for v2.2 (#1037)

2020-12-16 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 303cc56 docs: update CHANGELOG for

[apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-12-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 68dad66 Deploy to GitHub pages

[apisix-website] branch juzhiyuan-patch-1 created (now 89e5df3)

2020-12-16 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 89e5df3 docs: added blog Envoy and Apache APISIX: Another way to implement Envoy filter No

[GitHub] [apisix-dashboard] nic-chen merged pull request #1037: docs: update CHANGELOG for v2.2

2020-12-16 Thread GitBox
nic-chen merged pull request #1037: URL: https://github.com/apache/apisix-dashboard/pull/1037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-website] juzhiyuan opened a new pull request #110: docs: added blog Another way to implement Envoy filter

2020-12-16 Thread GitBox
juzhiyuan opened a new pull request #110: URL: https://github.com/apache/apisix-website/pull/110 added a new blog "Envoy and Apache APISIX: Another way to implement Envoy filter" This is an automated message from the

[apisix-website] branch master updated: feat: update dashboard version 2.2 link (#109)

2020-12-16 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 0d10a7d feat: update dashboard version 2

  1   2   >