[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1072: feat: support labels list

2020-12-20 Thread GitBox
starsz commented on a change in pull request #1072: URL: https://github.com/apache/apisix-dashboard/pull/1072#discussion_r546558401 ## File path: api/internal/handler/label/label.go ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix] zhuliquan opened a new issue #3090: apisix 可以处理带有冒号的uri吗? 例如这种/v1/books:batchGetBooks

2020-12-20 Thread GitBox
zhuliquan opened a new issue #3090: URL: https://github.com/apache/apisix/issues/3090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] spacewander commented on a change in pull request #3088: feat: add control api for plugin server-info

2020-12-20 Thread GitBox
spacewander commented on a change in pull request #3088: URL: https://github.com/apache/apisix/pull/3088#discussion_r546553530 ## File path: doc/control-api.md ## @@ -49,3 +49,9 @@ Here is the supported API: Introduced since `v2.2`. Return the jsonschema used by this APISIX

[GitHub] [apisix] membphis commented on a change in pull request #3061: draft: add ci on centos7

2020-12-20 Thread GitBox
membphis commented on a change in pull request #3061: URL: https://github.com/apache/apisix/pull/3061#discussion_r546547678 ## File path: .github/workflows/centos7.yml ## @@ -0,0 +1,103 @@ +name: test_apisix_on_centos7 + +on: + push: +branches: + - master + pull_requ

[GitHub] [apisix] nic-chen commented on issue #3079: apisix转发流量错误

2020-12-20 Thread GitBox
nic-chen commented on issue #3079: URL: https://github.com/apache/apisix/issues/3079#issuecomment-748811468 > 可以联系我1083796027提供两台线上的机子,你们可以查看调试日志等 OK This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] nic-chen commented on issue #3022: feat: support to export the JSON schema of APISIX via `CLI`

2020-12-20 Thread GitBox
nic-chen commented on issue #3022: URL: https://github.com/apache/apisix/issues/3022#issuecomment-748807842 @spacewander, here is an exported data example: ```json { "main": { "consumer": { "additionalProperties": false, "properties":

[GitHub] [apisix] moonming commented on pull request #2935: feat: Implement traffic splitting plugin

2020-12-20 Thread GitBox
moonming commented on pull request #2935: URL: https://github.com/apache/apisix/pull/2935#issuecomment-748807669 `traffic shaping` is a better ame This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix] spacewander opened a new pull request #3089: docs: update contributing guide

2020-12-20 Thread GitBox
spacewander opened a new pull request #3089: URL: https://github.com/apache/apisix/pull/3089 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix-dashboard] juzhiyuan closed issue #962: feat: upstream support set `pass_host` parameter

2020-12-20 Thread GitBox
juzhiyuan closed issue #962: URL: https://github.com/apache/apisix-dashboard/issues/962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated: feat: upstream support set `pass_host` parameter (#1088)

2020-12-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 072d497 feat: upstream support set

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1088: feat: upstream support set `pass_host` parameter

2020-12-20 Thread GitBox
juzhiyuan merged pull request #1088: URL: https://github.com/apache/apisix-dashboard/pull/1088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-20 Thread GitBox
moonming commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r546539544 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software F

[GitHub] [apisix-dashboard] juzhiyuan closed issue #809: My process of deploying dashboard on kubernetes

2020-12-20 Thread GitBox
juzhiyuan closed issue #809: URL: https://github.com/apache/apisix-dashboard/issues/809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #809: My process of deploying dashboard on kubernetes

2020-12-20 Thread GitBox
juzhiyuan commented on issue #809: URL: https://github.com/apache/apisix-dashboard/issues/809#issuecomment-748801945 related issue https://github.com/apache/apisix-website/pull/118 This is an automated message from the Apach

[GitHub] [apisix-website] juzhiyuan edited a comment on pull request #118: Create Deploying-apisix-dashboard-on-kubernetes.md

2020-12-20 Thread GitBox
juzhiyuan edited a comment on pull request #118: URL: https://github.com/apache/apisix-website/pull/118#issuecomment-748801656 tacker issue for me https://github.com/juzhiyuan/awesome/issues/3 This is an automated message fro

[GitHub] [apisix-website] juzhiyuan commented on pull request #118: Create Deploying-apisix-dashboard-on-kubernetes.md

2020-12-20 Thread GitBox
juzhiyuan commented on pull request #118: URL: https://github.com/apache/apisix-website/pull/118#issuecomment-748801656 tacker issue https://github.com/juzhiyuan/awesome/issues/3 This is an automated message from the Apache G

[GitHub] [apisix] candicandi commented on issue #3079: apisix转发流量错误

2020-12-20 Thread GitBox
candicandi commented on issue #3079: URL: https://github.com/apache/apisix/issues/3079#issuecomment-748801647 可以联系我1083796027提供两台线上的机子,你们可以查看调试日志等 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix-website] juzhiyuan commented on pull request #118: Create Deploying-apisix-dashboard-on-kubernetes.md

2020-12-20 Thread GitBox
juzhiyuan commented on pull request #118: URL: https://github.com/apache/apisix-website/pull/118#issuecomment-748801568 Thanks! I will modify this PR to let CI pass tomorrow. This is an automated message from the Apache Git S

[GitHub] [apisix] moonming commented on issue #3079: apisix转发流量错误

2020-12-20 Thread GitBox
moonming commented on issue #3079: URL: https://github.com/apache/apisix/issues/3079#issuecomment-748800833 @membphis @nic-chen @spacewander This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1089: Feat service

2020-12-20 Thread GitBox
LiteSun opened a new pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #809: My process of deploying dashboard on kubernetes

2020-12-20 Thread GitBox
juzhiyuan commented on issue #809: URL: https://github.com/apache/apisix-dashboard/issues/809#issuecomment-748797564 Oh yes, I added that label because no update here 😂 kindly refile a PR when you are free 💯 This is an aut

[GitHub] [apisix] tokers commented on a change in pull request #3088: feat: add control api for plugin server-info

2020-12-20 Thread GitBox
tokers commented on a change in pull request #3088: URL: https://github.com/apache/apisix/pull/3088#discussion_r546536232 ## File path: apisix/plugins/server-info.lua ## @@ -99,6 +99,17 @@ local function get() end +local function get_server_info() +local info, err = ge

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1072: feat: support labels list

2020-12-20 Thread GitBox
juzhiyuan commented on a change in pull request #1072: URL: https://github.com/apache/apisix-dashboard/pull/1072#discussion_r546535891 ## File path: api/internal/handler/label/label.go ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1072: feat: support labels list

2020-12-20 Thread GitBox
juzhiyuan commented on a change in pull request #1072: URL: https://github.com/apache/apisix-dashboard/pull/1072#discussion_r546535503 ## File path: api/internal/handler/label/label.go ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] tokers opened a new issue #121: [DISCUSS] e2e test cases

2020-12-20 Thread GitBox
tokers opened a new issue #121: URL: https://github.com/apache/apisix-ingress-controller/issues/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1072: feat: support labels list

2020-12-20 Thread GitBox
nic-chen commented on a change in pull request #1072: URL: https://github.com/apache/apisix-dashboard/pull/1072#discussion_r546534550 ## File path: api/internal/handler/label/label.go ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [apisix] spacewander commented on a change in pull request #3088: feat: add control api for plugin server-info

2020-12-20 Thread GitBox
spacewander commented on a change in pull request #3088: URL: https://github.com/apache/apisix/pull/3088#discussion_r546534487 ## File path: apisix/plugins/server-info.lua ## @@ -99,6 +99,17 @@ local function get() end +local function get_server_info() +local info, err

[GitHub] [apisix] yuncai929 edited a comment on issue #3083: Question: How to auto upgrade SSL cert?

2020-12-20 Thread GitBox
yuncai929 edited a comment on issue #3083: URL: https://github.com/apache/apisix/issues/3083#issuecomment-748792844 > How about acme? I remember we have an issue with this, but I couldn't find it now 😂 Thank you ask for my question! I use letsencrypt's certbot-auto

[GitHub] [apisix] yuncai929 commented on issue #3083: Question: How to auto upgrade SSL cert?

2020-12-20 Thread GitBox
yuncai929 commented on issue #3083: URL: https://github.com/apache/apisix/issues/3083#issuecomment-748792844 > How about acme? I remember we have an issue with this, but I couldn't find it now 😂 Thank you ask for my question! I use letsencrypt --

[GitHub] [apisix] tokers opened a new pull request #3088: feat: add control api for plugin server-info

2020-12-20 Thread GitBox
tokers opened a new pull request #3088: URL: https://github.com/apache/apisix/pull/3088 ### What this PR does / why we need it: Previously we added plugin server-info without exposing API since the same port problem of admin api and proxy. Now we have Control API support so w

[GitHub] [apisix-ingress-controller] tokers commented on issue #120: feat: Combine ApisixRoute, ApisixService, ApisixUpstream into one resource object

2020-12-20 Thread GitBox
tokers commented on issue #120: URL: https://github.com/apache/apisix-ingress-controller/issues/120#issuecomment-748784436 What about changing a name, people may confuse with the two versions of ApisixRoute. This is an auto

[GitHub] [apisix-website] ziyou434 opened a new pull request #118: Create Deploying-apisix-dashboard-on-kubernetes.md

2020-12-20 Thread GitBox
ziyou434 opened a new pull request #118: URL: https://github.com/apache/apisix-website/pull/118 # Deploying apisix dashboard on kubernetes Because there is no official image right now, so I used iiqi‘s image [https://github.com/iiQi/apisix-dashboard-docker](url). you can find “iiq

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #120: feat: Combine ApisixRoute, ApisixService, ApisixUpstream into one resource object

2020-12-20 Thread GitBox
gxthrj opened a new issue #120: URL: https://github.com/apache/apisix-ingress-controller/issues/120 During the development process, we maintained some additional complexity, because of splitting the CRD (custom resource object) to `ApisixRoute` `ApisixService` and `ApisixUpstream`. Con

[GitHub] [apisix-dashboard] ziyou434 commented on issue #809: My process of deploying dashboard on kubernetes

2020-12-20 Thread GitBox
ziyou434 commented on issue #809: URL: https://github.com/apache/apisix-dashboard/issues/809#issuecomment-748777655 . > Hi, anything could I help you? emm... I find you added the wait for update label, I remembered I added the PR ,but I can't find my action about this ,maybe

[GitHub] [apisix-ingress-controller] tokers commented on issue #60: We may need debounce mechanism to collapse Kubernetes events

2020-12-20 Thread GitBox
tokers commented on issue #60: URL: https://github.com/apache/apisix-ingress-controller/issues/60#issuecomment-748776353 @gxthrj The debounce mechanism is used to prevent ingress-apisix/apisix overwhelming from too many resource change events arriving in.

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1088: feat: upstream support set `pass_host` parameter

2020-12-20 Thread GitBox
guoqqqi opened a new pull request #1088: URL: https://github.com/apache/apisix-dashboard/pull/1088 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #60: We may need debounce mechanism to collapse Kubernetes events

2020-12-20 Thread GitBox
gxthrj commented on issue #60: URL: https://github.com/apache/apisix-ingress-controller/issues/60#issuecomment-748770573 Or Is this issue meaning : Need a mechanism to ensure that the resources in k8s and apisix are consistent ? ---

[GitHub] [apisix] tokers commented on issue #2988: Carry SNI while doing SSL handshaking with upstream

2020-12-20 Thread GitBox
tokers commented on issue #2988: URL: https://github.com/apache/apisix/issues/2988#issuecomment-748769845 @unbeatablekb No, we should add cases to verify it. This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] tokers commented on a change in pull request #3084: feat: add proxy_ssl_server_name

2020-12-20 Thread GitBox
tokers commented on a change in pull request #3084: URL: https://github.com/apache/apisix/pull/3084#discussion_r546517965 ## File path: conf/config-default.yaml ## @@ -174,6 +174,8 @@ nginx_config: # config for render the template to generate n # lua_s

[GitHub] [apisix] unbeatablekb commented on issue #2988: Carry SNI while doing SSL handshaking with upstream

2020-12-20 Thread GitBox
unbeatablekb commented on issue #2988: URL: https://github.com/apache/apisix/issues/2988#issuecomment-748767634 I have open a pr about this issue (as we can see above). Considered this functionality was guaranteed by Nginx and we just need to test the functionality of the generation of tem

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1087: feat(CI): no need to build web after being merged

2020-12-20 Thread GitBox
juzhiyuan commented on pull request #1087: URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748764761 🤔 I remember there has one button to let us rebase master before merging, but I couldn't find it recently 😂 -

[GitHub] [apisix-dashboard] liuxiran commented on issue #835: [Proposal]: Refactor route debug online

2020-12-20 Thread GitBox
liuxiran commented on issue #835: URL: https://github.com/apache/apisix-dashboard/issues/835#issuecomment-748759905 all prs merged, close it now. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix-dashboard] liuxiran closed issue #835: [Proposal]: Refactor route debug online

2020-12-20 Thread GitBox
liuxiran closed issue #835: URL: https://github.com/apache/apisix-dashboard/issues/835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1087: feat(CI): no need to build web after being merged

2020-12-20 Thread GitBox
liuxiran commented on pull request #1087: URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748759062 Not all prs do `merge master` before they being merged, so IMHO CI can run after pr merges to check if there are any problems in merge action. -

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1087: feat(CI): no need to build web after being merged

2020-12-20 Thread GitBox
codecov-io commented on pull request #1087: URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748755523 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=h1) Report > Merging [#1087](https://codecov.io/gh/apache/apisix-dashboard/pull/108

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1087: feat(CI): no need to build web after being merged

2020-12-20 Thread GitBox
juzhiyuan opened a new pull request #1087: URL: https://github.com/apache/apisix-dashboard/pull/1087 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - Relat

[apisix-dashboard] 01/01: feat(CI): no need to build web after being merged

2020-12-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit c4a4da4851d7f6c5d8615ac46d12bf05171e6e04 Author: 琚致远 AuthorDate: Mon Dec 21 12:48:09 2020 +0800

[apisix-dashboard] branch juzhiyuan-patch-1 created (now c4a4da4)

2020-12-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at c4a4da4 feat(CI): no need to build web after being merged This branch includes the followin

[GitHub] [apisix-dashboard] juzhiyuan closed issue #837: feat: Refactor Route publish and offline

2020-12-20 Thread GitBox
juzhiyuan closed issue #837: URL: https://github.com/apache/apisix-dashboard/issues/837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated: feat: refactor publish/offline fe (#991)

2020-12-20 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new daded21 feat: refactor publish/offline

[GitHub] [apisix-dashboard] LiteSun merged pull request #991: feat: refactor publish/offline fe

2020-12-20 Thread GitBox
LiteSun merged pull request #991: URL: https://github.com/apache/apisix-dashboard/pull/991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #991: feat: refactor publish/offline fe

2020-12-20 Thread GitBox
codecov-io edited a comment on pull request #991: URL: https://github.com/apache/apisix-dashboard/pull/991#issuecomment-747217119 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/991?src=pr&el=h1) Report > Merging [#991](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] gxthrj opened a new issue #3087: request help: Support LDAP

2020-12-20 Thread GitBox
gxthrj opened a new issue #3087: URL: https://github.com/apache/apisix/issues/3087 ### Issue description Support LDAP authentication. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] gxthrj opened a new issue #3086: request help: Support load balance by least connections

2020-12-20 Thread GitBox
gxthrj opened a new issue #3086: URL: https://github.com/apache/apisix/issues/3086 ### Issue description Support new feature load balance by least connections. This is an automated message from the Apache Git Servi

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #119: feat: Support TCP + TLS definition

2020-12-20 Thread GitBox
gxthrj opened a new issue #119: URL: https://github.com/apache/apisix-ingress-controller/issues/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #118: feat: Support retries in upstream definition

2020-12-20 Thread GitBox
gxthrj opened a new issue #118: URL: https://github.com/apache/apisix-ingress-controller/issues/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #117: feat: Support healthchecks definition

2020-12-20 Thread GitBox
gxthrj opened a new issue #117: URL: https://github.com/apache/apisix-ingress-controller/issues/117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #116: feat: Support UDP definition

2020-12-20 Thread GitBox
gxthrj opened a new issue #116: URL: https://github.com/apache/apisix-ingress-controller/issues/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #115: feat: Support TCP definition

2020-12-20 Thread GitBox
gxthrj opened a new issue #115: URL: https://github.com/apache/apisix-ingress-controller/issues/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #114: feat: Support GRPC definition

2020-12-20 Thread GitBox
gxthrj opened a new issue #114: URL: https://github.com/apache/apisix-ingress-controller/issues/114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] juzhiyuan commented on issue #3083: Question: How to auto upgrade SSL cert?

2020-12-20 Thread GitBox
juzhiyuan commented on issue #3083: URL: https://github.com/apache/apisix/issues/3083#issuecomment-748747752 How about acme? I remember we have an issue with this, but I couldn't find it now 😂 This is an automated message fr

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #838: Bug: Add defer recover for all go routines to prevent abnormal crash of manager-api

2020-12-20 Thread GitBox
juzhiyuan commented on issue #838: URL: https://github.com/apache/apisix-dashboard/issues/838#issuecomment-748747012 Any update for this issue? This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #809: My process of deploying dashboard on kubernetes

2020-12-20 Thread GitBox
juzhiyuan commented on issue #809: URL: https://github.com/apache/apisix-dashboard/issues/809#issuecomment-748746884 Hi, anything could I help you? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] juzhiyuan closed issue #752: do we should use `updated_time` and `created_time`?

2020-12-20 Thread GitBox
juzhiyuan closed issue #752: URL: https://github.com/apache/apisix-dashboard/issues/752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #752: do we should use `updated_time` and `created_time`?

2020-12-20 Thread GitBox
juzhiyuan commented on issue #752: URL: https://github.com/apache/apisix-dashboard/issues/752#issuecomment-748746751 no conclusion and not urgent here so closed. This is an automated message from the Apache Git Service. To r

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #741: Implmement sub-command like stop, restart for manager-api

2020-12-20 Thread GitBox
juzhiyuan commented on issue #741: URL: https://github.com/apache/apisix-dashboard/issues/741#issuecomment-748746543 any update? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander opened a new pull request #3085: feat: validate certificate & key

2020-12-20 Thread GitBox
spacewander opened a new pull request #3085: URL: https://github.com/apache/apisix/pull/3085 Fix #296 Fix #2816 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does thi

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #682: feature: support custom CPU quantity used for `manager api`

2020-12-20 Thread GitBox
juzhiyuan commented on issue #682: URL: https://github.com/apache/apisix-dashboard/issues/682#issuecomment-748746262 plan? This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #679: feature: support https for `manager api`

2020-12-20 Thread GitBox
juzhiyuan commented on issue #679: URL: https://github.com/apache/apisix-dashboard/issues/679#issuecomment-748746150 any plan? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #676: feature: support access log for `manager api`

2020-12-20 Thread GitBox
juzhiyuan commented on issue #676: URL: https://github.com/apache/apisix-dashboard/issues/676#issuecomment-748746096 Done? This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #614: proposal: UI autotest

2020-12-20 Thread GitBox
juzhiyuan commented on issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614#issuecomment-748745995 I will close this tracking issue, for there have a lot of detailed issues to track. This is an automated m

[GitHub] [apisix-dashboard] juzhiyuan closed issue #614: proposal: UI autotest

2020-12-20 Thread GitBox
juzhiyuan closed issue #614: URL: https://github.com/apache/apisix-dashboard/issues/614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #511: using dashboard for a while , the token expired

2020-12-20 Thread GitBox
juzhiyuan edited a comment on issue #511: URL: https://github.com/apache/apisix-dashboard/issues/511#issuecomment-748745689 3600s is the default expired due time. ![image](https://user-images.githubusercontent.com/2106987/102738511-4f97ec80-4385-11eb-91b9-fd5e422d851c.png) ---

[GitHub] [apisix-dashboard] juzhiyuan closed issue #511: using dashboard for a while , the token expired

2020-12-20 Thread GitBox
juzhiyuan closed issue #511: URL: https://github.com/apache/apisix-dashboard/issues/511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #511: using dashboard for a while , the token expired

2020-12-20 Thread GitBox
juzhiyuan commented on issue #511: URL: https://github.com/apache/apisix-dashboard/issues/511#issuecomment-748745689 ![image](https://user-images.githubusercontent.com/2106987/102738511-4f97ec80-4385-11eb-91b9-fd5e422d851c.png)

[GitHub] [apisix-dashboard] juzhiyuan closed issue #620: issues need to resolve after the manager api is refactored

2020-12-20 Thread GitBox
juzhiyuan closed issue #620: URL: https://github.com/apache/apisix-dashboard/issues/620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1079: feat: added websocket tab for route

2020-12-20 Thread GitBox
juzhiyuan merged pull request #1079: URL: https://github.com/apache/apisix-dashboard/pull/1079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-dashboard] juzhiyuan closed issue #831: request help: websocket tab is lost in 2.0rc2?

2020-12-20 Thread GitBox
juzhiyuan closed issue #831: URL: https://github.com/apache/apisix-dashboard/issues/831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated (e786ef6 -> 0a0bcab)

2020-12-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e786ef6 Refactor publish offline be (#1081) add 0a0bcab feat: added websocket tab for route (#10

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #933: feat: not allowed to specify `create_time` and `update_time` when create/edit route, service, upstream and consumer

2020-12-20 Thread GitBox
juzhiyuan commented on issue #933: URL: https://github.com/apache/apisix-dashboard/issues/933#issuecomment-748743796 Will this issue been resolved by the community or? This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #990: feat: Add a new API to get plugin information

2020-12-20 Thread GitBox
juzhiyuan commented on issue #990: URL: https://github.com/apache/apisix-dashboard/issues/990#issuecomment-748743581 Any update about that command line? This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-20 Thread GitBox
juzhiyuan commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r546496938 ## File path: api/internal/handler/global_rule/global_rule.go ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix-dashboard] juzhiyuan closed issue #974: request help: import k8s_deployment_info to upstream cann't use it

2020-12-20 Thread GitBox
juzhiyuan closed issue #974: URL: https://github.com/apache/apisix-dashboard/issues/974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #974: request help: import k8s_deployment_info to upstream cann't use it

2020-12-20 Thread GitBox
juzhiyuan commented on issue #974: URL: https://github.com/apache/apisix-dashboard/issues/974#issuecomment-748741944 related discussion: https://github.com/apache/apisix/issues/3068 This is an automated message from the Apac

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #883: chore: Show the correct lines of code in manager logger

2020-12-20 Thread GitBox
juzhiyuan commented on pull request #883: URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-748741171 ping @gxthrj This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1081: Refactor publish offline be

2020-12-20 Thread GitBox
juzhiyuan merged pull request #1081: URL: https://github.com/apache/apisix-dashboard/pull/1081 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated (1df23da -> e786ef6)

2020-12-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 1df23da fix: e2e test cases unstable (#1073) add e786ef6 Refactor publish offline be (#1081) No

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1086: support EWMA in upstream balancer

2020-12-20 Thread GitBox
juzhiyuan commented on issue #1086: URL: https://github.com/apache/apisix-dashboard/issues/1086#issuecomment-748739517 Doc: https://github.com/apache/apisix/blob/master/doc/admin-api.md#upstream May I know what should happen after selecting EWMA? cc @membphis --

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1079: feat: added websocket tab for route

2020-12-20 Thread GitBox
codecov-io edited a comment on pull request #1079: URL: https://github.com/apache/apisix-dashboard/pull/1079#issuecomment-748474348 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1079?src=pr&el=h1) Report > Merging [#1079](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1068: test: add frontend e2e test (create and delete consumer with key-auth)

2020-12-20 Thread GitBox
juzhiyuan commented on a change in pull request #1068: URL: https://github.com/apache/apisix-dashboard/pull/1068#discussion_r546490779 ## File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software F

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1081: Refactor publish offline be

2020-12-20 Thread GitBox
codecov-io edited a comment on pull request #1081: URL: https://github.com/apache/apisix-dashboard/pull/1081#issuecomment-748552262 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1081?src=pr&el=h1) Report > Merging [#1081](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1081: Refactor publish offline be

2020-12-20 Thread GitBox
codecov-io edited a comment on pull request #1081: URL: https://github.com/apache/apisix-dashboard/pull/1081#issuecomment-748552262 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1081?src=pr&el=h1) Report > Merging [#1081](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] moonming opened a new issue #1086: support EWMA in upstream balancer

2020-12-20 Thread GitBox
moonming opened a new issue #1086: URL: https://github.com/apache/apisix-dashboard/issues/1086 # Feature request https://github.com/apache/apisix/blob/4d316bc0681c80435ab1a3fc113c3c6ea3c82831/apisix/balancer.lua#L33 ## Please describe your feature A clear and concise de

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-20 Thread GitBox
nic-chen commented on pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-748733566 this PR should be closed now. feel free to reopen it if you need. This is an automated message from t

[GitHub] [apisix-dashboard] nic-chen closed pull request #1049: feat: support patch in route module in order to support publish/offline

2020-12-20 Thread GitBox
nic-chen closed pull request #1049: URL: https://github.com/apache/apisix-dashboard/pull/1049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated (e23e95e -> 1df23da)

2020-12-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e23e95e feat: use selector to choose methods (#1082) add 1df23da fix: e2e test cases unstable (#1

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1073: ci: fix e2e test cases unstable

2020-12-20 Thread GitBox
juzhiyuan merged pull request #1073: URL: https://github.com/apache/apisix-dashboard/pull/1073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1081: Refactor publish offline be

2020-12-20 Thread GitBox
nic-chen commented on a change in pull request #1081: URL: https://github.com/apache/apisix-dashboard/pull/1081#discussion_r546488247 ## File path: api/internal/core/entity/entity.go ## @@ -83,6 +83,7 @@ type Route struct { ServiceProtocol string `json:

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-20 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1) Report > Merging [#1066](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan closed issue #784: bug: when created route by adminAPI, "method" can be null value which dashboard can not identify

2020-12-20 Thread GitBox
juzhiyuan closed issue #784: URL: https://github.com/apache/apisix-dashboard/issues/784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

  1   2   >