membphis commented on pull request #1810:
URL: https://github.com/apache/apisix/pull/1810#issuecomment-749995191
close this PR first. if the community need it, then we can reopen and
continue this PR
This is an automated mes
membphis closed pull request #1810:
URL: https://github.com/apache/apisix/pull/1810
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Firstsawyou commented on a change in pull request #2935:
URL: https://github.com/apache/apisix/pull/2935#discussion_r547773973
##
File path: apisix/plugins/traffic-split.lua
##
@@ -0,0 +1,294 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- cont
Firstsawyou commented on a change in pull request #2935:
URL: https://github.com/apache/apisix/pull/2935#discussion_r547771484
##
File path: apisix/plugins/traffic-split.lua
##
@@ -0,0 +1,294 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- cont
membphis commented on a change in pull request #1057:
URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r547771052
##
File path: api/internal/handler/global_rule/global_rule.go
##
@@ -50,7 +49,7 @@ func (h *Handler) ApplyRoute(r *gin.Engine) {
Firstsawyou commented on a change in pull request #2935:
URL: https://github.com/apache/apisix/pull/2935#discussion_r547771484
##
File path: apisix/plugins/traffic-split.lua
##
@@ -0,0 +1,294 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- cont
membphis commented on issue #825:
URL:
https://github.com/apache/apisix-dashboard/issues/825#issuecomment-749993175
> cc @membphis
LGTM, thx
This is an automated message from the Apache Git Service.
To respond to the
membphis commented on pull request #3061:
URL: https://github.com/apache/apisix/pull/3061#issuecomment-749992823
@idbeta please take a look at the output of CI:
https://github.com/apache/apisix/pull/3061/checks?check_run_id=1594094992#step:10:910
```shell
bash: ./build-cach
starsz opened a new pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- Related
membphis commented on issue #1086:
URL:
https://github.com/apache/apisix-dashboard/issues/1086#issuecomment-749991743
> May I know what should happen after selecting EWMA? @juzhiyuan
same as `roundrobin`
This
membphis commented on pull request #104:
URL: https://github.com/apache/apisix-docker/pull/104#issuecomment-749986981
@jbampton CI failed, do you have time to fix it? thx
This is an automated message from the Apache Git Servi
spacewander commented on a change in pull request #2935:
URL: https://github.com/apache/apisix/pull/2935#discussion_r547752819
##
File path: apisix/plugins/traffic-split.lua
##
@@ -0,0 +1,294 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- cont
spacewander commented on issue #1085:
URL:
https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-749985034
Yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
idbeta commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547727677
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Fou
idbeta commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547725745
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Fou
idbeta commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547724259
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Fou
moonming commented on pull request #1810:
URL: https://github.com/apache/apisix/pull/1810#issuecomment-749971949
ping @membphis
This is an automated message from the Apache Git Service.
To respond to the message, please log
moonming closed pull request #1909:
URL: https://github.com/apache/apisix/pull/1909
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming closed pull request #1372:
URL: https://github.com/apache/apisix/pull/1372
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming commented on a change in pull request #3061:
URL: https://github.com/apache/apisix/pull/3061#discussion_r547716128
##
File path: .github/workflows/centos7.yml
##
@@ -0,0 +1,102 @@
+name: test_apisix_on_centos7
+
+on:
+ push:
+branches:
+ - master
+ pull_requ
codecov-io commented on pull request #127:
URL:
https://github.com/apache/apisix-ingress-controller/pull/127#issuecomment-749961833
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr&el=h1)
Report
> Merging
[#127](https://codecov.io/gh/apache/apisix-ing
tokers opened a new pull request #127:
URL: https://github.com/apache/apisix-ingress-controller/pull/127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
idbeta commented on pull request #1093:
URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-749960712
@nic-chen Help me run the backend E2E test again for this PR.
This is an automated message from the Apac
codecov-io edited a comment on pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1)
Report
> Merging
[#1066](https://codecov.io/gh/apache/apisix-dashboard/p
Hcreak commented on issue #1103:
URL:
https://github.com/apache/apisix-dashboard/issues/1103#issuecomment-749959687
Thanks for your reply, Do you mean that the next version will put wolf-rbac
into the Authentication category to fix this bug?
--
codecov-io edited a comment on pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1)
Report
> Merging
[#1066](https://codecov.io/gh/apache/apisix-dashboard/p
idbeta commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547696315
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Fou
codecov-io commented on pull request #1106:
URL: https://github.com/apache/apisix-dashboard/pull/1106#issuecomment-749959121
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1106?src=pr&el=h1)
Report
> Merging
[#1106](https://codecov.io/gh/apache/apisix-dashboard/pull/110
LiteSun opened a new pull request #1106:
URL: https://github.com/apache/apisix-dashboard/pull/1106
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related
idbeta commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547687019
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Fou
codecov-io commented on pull request #126:
URL:
https://github.com/apache/apisix-ingress-controller/pull/126#issuecomment-749953311
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/126?src=pr&el=h1)
Report
> Merging
[#126](https://codecov.io/gh/apache/apisix-ing
juzhiyuan commented on issue #1103:
URL:
https://github.com/apache/apisix-dashboard/issues/1103#issuecomment-749953075
BTW, yes, we must enable a Plugin under the Authentication category when
creating consumer.
This is an
tokers opened a new pull request #126:
URL: https://github.com/apache/apisix-ingress-controller/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
juzhiyuan commented on issue #1103:
URL:
https://github.com/apache/apisix-dashboard/issues/1103#issuecomment-749952723
Hi, please use the latest codes on the master branch.
This is an automated message from the Apache Git Se
codecov-io commented on pull request #1105:
URL: https://github.com/apache/apisix-dashboard/pull/1105#issuecomment-749952748
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1105?src=pr&el=h1)
Report
> Merging
[#1105](https://codecov.io/gh/apache/apisix-dashboard/pull/110
idbeta opened a new pull request #1105:
URL: https://github.com/apache/apisix-dashboard/pull/1105
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] E2E test
- [ ] New feature provided
- [ ] Improve performance
-
membphis commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547643536
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software F
codecov-io edited a comment on pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1)
Report
> Merging
[#1066](https://codecov.io/gh/apache/apisix-dashboard/p
membphis commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547640769
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software F
membphis commented on a change in pull request #1066:
URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547639576
##
File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software F
codecov-io commented on pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104#issuecomment-749930195
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=h1)
Report
> Merging
[#1104](https://codecov.io/gh/apache/apisix-dashboard/pull/110
idbeta opened a new pull request #1104:
URL: https://github.com/apache/apisix-dashboard/pull/1104
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] E2E test
- [ ] New feature provided
- [ ] Improve performance
-
membphis commented on issue #1085:
URL:
https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-749924833
yes, we need this feature ^_^
APISIX needs to be updated for this feature, all right? @spacewander
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1)
Report
> Merging
[#1097](https://codecov.io/gh/apache/apisix-dashboard/p
Firstsawyou commented on a change in pull request #2935:
URL: https://github.com/apache/apisix/pull/2935#discussion_r547627744
##
File path: apisix/plugins/traffic-split.lua
##
@@ -0,0 +1,294 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- cont
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1)
Report
> Merging
[#1097](https://codecov.io/gh/apache/apisix-dashboard/p
Hcreak opened a new issue #1103:
URL: https://github.com/apache/apisix-dashboard/issues/1103
# Bug report
## Describe the bug
I follow the steps of the official
document([https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/wolf-rbac.md])(https://github.com/apache/ap
spacewander commented on issue #3106:
URL: https://github.com/apache/apisix/issues/3106#issuecomment-749913058
I can reproduce with 2.0, but can't reproduce with master branch. The fix is
only on the master branch. Can you try the master branch directly? Remember to
stop and restart APISIX
juzhiyuan commented on issue #1013:
URL:
https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749911321
1. `/web/src`
2. `/web/cypress`
This is an automated message from the Apache Git Service.
To respond t
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1)
Report
> Merging
[#1097](https://codecov.io/gh/apache/apisix-dashboard/p
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749908753
--
starsz edited a comment on issue #1013:
URL:
https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749907366
@juzhiyuan Yes, I will. I want to know which directories should be checked
under `web`.
This is an a
starsz commented on issue #1013:
URL:
https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749907366
@juzhiyuan Yes, I will. I want to know which directories should be checked
under "web".
This is an automate
whioue commented on issue #3106:
URL: https://github.com/apache/apisix/issues/3106#issuecomment-749901211
> Is it solved by #2905? You can try it on the master branch.
@spacewander
I tried it on version 2.0 and it seems that it has not been solved for the
time being
---
whioue removed a comment on issue #3106:
URL: https://github.com/apache/apisix/issues/3106#issuecomment-749900750
> [＃2905](https://github.com/apache/apisix/pull/2905)解决了吗？您可以在master分支上尝试。
I tried it on version 2.0 and it seems that it has not been solved for the
time being
---
whioue commented on issue #3106:
URL: https://github.com/apache/apisix/issues/3106#issuecomment-749900750
> [＃2905](https://github.com/apache/apisix/pull/2905)解决了吗？您可以在master分支上尝试。
I tried it on version 2.0 and it seems that it has not been solved for the
time being
---
Firstsawyou opened a new issue #3108:
URL: https://github.com/apache/apisix/issues/3108
### Issue description
When the `limit-count` plugin is enabled on `service` and `upstream` is the
domain name. This will cause the `local key = (ctx.var[conf.key] or "") ..
ctx.conf_type .. ctx.c
spacewander commented on issue #3106:
URL: https://github.com/apache/apisix/issues/3106#issuecomment-749899492
Is it solved by https://github.com/apache/apisix/pull/2905? You can try it
on the master branch.
This is an autom
spacewander commented on issue #3100:
URL: https://github.com/apache/apisix/issues/3100#issuecomment-749899036
PR is welcome!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
azura27 opened a new issue #3107:
URL: https://github.com/apache/apisix/issues/3107
### Issue description
When I put a route and visit it whthin 0.3 seconds, It would cause an error
in zipkin plugin. Corresponding code is in apisix/apisix/plugins/zipkin.lua :
ctx.opentracing_sample = tr
whioue opened a new issue #3106:
URL: https://github.com/apache/apisix/issues/3106
### Issue description
想要consumer来绑定服务或路由，所以使用consumer-restriction插件来实现，使用这个插件有两种限制类型，一种是使用consumer_name这个没问题，另一种是service_id使用时，发现文档上实例是key-auth认证，这个没问题，但我使用此插件限制basic-auth时发现无法限制成功
### Environment
codecov-io edited a comment on pull request #1089:
URL: https://github.com/apache/apisix-dashboard/pull/1089#issuecomment-748893636
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1089?src=pr&el=h1)
Report
> Merging
[#1089](https://codecov.io/gh/apache/apisix-dashboard/p
Jaycean opened a new pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102
Signed-off-by: Jacean
Import & Export route from OpenAPI Specification3.0
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performan
juzhiyuan commented on issue #1013:
URL:
https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749884647
Hi @starsz, would we invoke a CI to check every PR?
This is an automated message from the Apache Git Serv
juzhiyuan closed issue #1013:
URL: https://github.com/apache/apisix-dashboard/issues/1013
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
LiteSun merged pull request #1101:
URL: https://github.com/apache/apisix-dashboard/pull/1101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 46bf1ef fix: misspelling (#1101)
46bf1
gxthrj commented on issue #106:
URL: https://github.com/apache/apisix-docker/issues/106#issuecomment-749881174
> @liyin37 Just confirm, do `cert` and `key` use `pem-encoded`?
@liyin37 I saw that your `cert` and `key` is RSA Encryption, the [admin
api](https://github.com/apache/apisi
spacewander commented on issue #3082:
URL: https://github.com/apache/apisix/issues/3082#issuecomment-749879460
I open a discussion there:
https://lists.apache.org/thread.html/r99e93b5bbade9e34a18e87b674bd999fdbe875a505c46664b731d9ff%40%3Cdev.apisix.apache.org%3E
Let's go to the mail list
spacewander commented on issue #2711:
URL: https://github.com/apache/apisix/issues/2711#issuecomment-749879370
@Gary-Airwallex
I have changed my mind and open a discussion there:
https://lists.apache.org/thread.html/r99e93b5bbade9e34a18e87b674bd999fdbe875a505c46664b731d9ff%40%3Cdev.apis
LiteSun edited a comment on issue #861:
URL:
https://github.com/apache/apisix-dashboard/issues/861#issuecomment-749876653
FE is not merged now.
This is an automated message from the Apache Git Service.
To respond to the mess
LiteSun commented on issue #861:
URL:
https://github.com/apache/apisix-dashboard/issues/861#issuecomment-749876653
FE is not ready now.
This is an automated message from the Apache Git Service.
To respond to the message, ple
LiteSun opened a new issue #861:
URL: https://github.com/apache/apisix-dashboard/issues/861
# why
In order to allow users to filter out routes with a specified group from a
large number of routes, I propose to add the route groups feature.
# how
## front-end
In order to fini
kuberxy closed issue #3097:
URL: https://github.com/apache/apisix/issues/3097
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a change to tag 0.1.0
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
at 135cff4 (commit)
No new revisions were added by this update.
spacewander commented on issue #297:
URL: https://github.com/apache/apisix/issues/297#issuecomment-749868002
This issue is marked as stale because it has not had activity for a long
time. It will be closed in the next 7 days unless the label "stale" is removed.
Thank you for your contribut
spacewander commented on issue #300:
URL: https://github.com/apache/apisix/issues/300#issuecomment-749867971
This issue is marked as stale because it has not had activity for a long
time. It will be closed in the next 7 days unless the label "stale" is removed.
Thank you for your contribut
spacewander closed issue #1207:
URL: https://github.com/apache/apisix/issues/1207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
codecov-io edited a comment on pull request #1067:
URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1)
Report
> Merging
[#1067](https://codecov.io/gh/apache/apisix-dashboard/p
spacewander commented on a change in pull request #3092:
URL: https://github.com/apache/apisix/pull/3092#discussion_r547586719
##
File path: apisix/control/v1.lua
##
@@ -14,11 +14,33 @@
-- See the License for the specific language governing permissions and
-- limitations unde
spacewander commented on a change in pull request #3105:
URL: https://github.com/apache/apisix/pull/3105#discussion_r547584817
##
File path: apisix/init.lua
##
@@ -185,6 +185,9 @@ function _M.http_ssl_phase()
end
ngx_exit(-1)
Review comment:
Should we
spacewander commented on issue #3104:
URL: https://github.com/apache/apisix/issues/3104#issuecomment-749859527
There is the doc: https://github.com/apache/apisix/tree/master/doc
This is an automated message from the Apache Gi
spacewander closed issue #3104:
URL: https://github.com/apache/apisix/issues/3104
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander merged pull request #3101:
URL: https://github.com/apache/apisix/pull/3101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 8eaa187 docs: when opening issue, also men
liuxiran commented on a change in pull request #999:
URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547572147
##
File path: web/src/pages/Route/List.tsx
##
@@ -90,6 +101,47 @@ const Page: React.FC = () => {
dataIndex: 'desc',
hideInSearch: tr
tokers commented on issue #106:
URL: https://github.com/apache/apisix-docker/issues/106#issuecomment-749857341
> I just change the cert and key ,the new result is below:
>
>
liuxiran commented on a change in pull request #999:
URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547572147
##
File path: web/src/pages/Route/List.tsx
##
@@ -90,6 +101,47 @@ const Page: React.FC = () => {
dataIndex: 'desc',
hideInSearch: tr
liuxiran commented on a change in pull request #999:
URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547572147
##
File path: web/src/pages/Route/List.tsx
##
@@ -90,6 +101,47 @@ const Page: React.FC = () => {
dataIndex: 'desc',
hideInSearch: tr
codecov-io edited a comment on pull request #122:
URL:
https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1)
Report
> Merging
[#122](https://codecov.io/gh/apache/api
liuxiran commented on a change in pull request #999:
URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547569358
##
File path: web/src/locales/en-US/component.ts
##
@@ -32,6 +32,7 @@ export default {
'component.global.loading': 'Loading',
'component.glo
liuxiran commented on a change in pull request #999:
URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547568903
##
File path: web/src/pages/Route/transform.ts
##
@@ -35,8 +44,14 @@ export const transformStepData = ({
};
}
+ const labels = {};
+ t
jinchizhou commented on pull request #1067:
URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-749690818
I am only converting to a string if the type is float. The body id are
guarantee to be a string or a float I assume? I use a new variable so that
shouldn't be breaki
juzhiyuan commented on issue #1098:
URL:
https://github.com/apache/apisix-dashboard/issues/1098#issuecomment-749652581
oh yes, that's because we don't have a proper description in Chinese, what's
your opinion? 🤔
This is an
codecov-io commented on pull request #1101:
URL: https://github.com/apache/apisix-dashboard/pull/1101#issuecomment-749632542
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1101?src=pr&el=h1)
Report
> Merging
[#1101](https://codecov.io/gh/apache/apisix-dashboard/pull/110
guoqqqi opened a new pull request #1101:
URL: https://github.com/apache/apisix-dashboard/pull/1101
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749609081
@guoqqqi After you update the i18n, you need to u
juzhiyuan commented on issue #1013:
URL:
https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749608322
Hi @guoqqqi, here has one misspelling in the `DebugDrawView` file, please
fix this.
As for misspellings in yarn.lock, ignore it because we couldn't modify it.
---
nic-chen commented on pull request #1067:
URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-749604190
> Not sure why these CI tests are blocking. I verified that these tests are
failing locally even without my changes.
I think it's due to
https://github.com/apac
codecov-io edited a comment on pull request #999:
URL: https://github.com/apache/apisix-dashboard/pull/999#issuecomment-742169695
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/999?src=pr&el=h1)
Report
> Merging
[#999](https://codecov.io/gh/apache/apisix-dashboard/pull/
1 - 100 of 167 matches
Mail list logo
