[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548436880 ## File path: README.md ## @@ -99,6 +99,7 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against - [Health

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1108: chore: mv main.go to cmd

nic-chen commented on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750795526 CI failed. @gxthrj This is an automated message from the Apache Git Service. To respond to the

[apisix-website] branch asf-site updated: Deploy to GitHub pages

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0b7edbb Deploy to GitHub pages

[GitHub] [apisix] spacewander commented on a change in pull request #2965: feat: use luasocket instead of curl in etcd.lua

spacewander commented on a change in pull request #2965: URL: https://github.com/apache/apisix/pull/2965#discussion_r548434807 ## File path: apisix/cli/etcd.lua ## @@ -160,31 +163,38 @@ function _M.init(env, show_output) for index, host in ipairs(yaml_conf.etcd.host) do

[GitHub] [apisix-website] moonming merged pull request #119: docs: add apisix-ingress-controller

moonming merged pull request #119: URL: https://github.com/apache/apisix-website/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-website] branch master updated: docs: add apisix-ingress-controller (#119)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 8598f8a docs: add

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1064: fix: when enable or disable existing SSL, an error occurred

codecov-io edited a comment on pull request #1064: URL: https://github.com/apache/apisix-dashboard/pull/1064#issuecomment-747536592 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1064?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #129: doc: update develop.md

codecov-io edited a comment on pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129#issuecomment-750784557 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/129?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1064: fix: when enable or disable existing SSL, an error occurred

nic-chen commented on a change in pull request #1064: URL: https://github.com/apache/apisix-dashboard/pull/1064#discussion_r548433832 ## File path: api/internal/utils/utils.go ## @@ -97,6 +98,16 @@ func InterfaceToString(val interface{}) string { return str } +func

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #129: doc: update develop.md

tokers commented on a change in pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129#discussion_r548433722 ## File path: docs/develop.md ## @@ -89,12 +93,14 @@ spec: http: paths: - backend: - serviceName: httpserver

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1064: fix: when enable or disable existing SSL, an error occurred

nic-chen commented on a change in pull request #1064: URL: https://github.com/apache/apisix-dashboard/pull/1064#discussion_r548433266 ## File path: api/internal/handler/ssl/ssl.go ## @@ -86,7 +86,11 @@ func (h *Handler) Get(c droplet.Context) (interface{}, error) { }

[GitHub] [apisix] spacewander commented on issue #3117: The proxy-rewrite plugin does not support pass nginx's variable within header

spacewander commented on issue #3117: URL: https://github.com/apache/apisix/issues/3117#issuecomment-750791853 Only constant value is supported. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #129: doc: update develop.md

tokers commented on a change in pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129#discussion_r548430523 ## File path: docs/develop.md ## @@ -89,12 +93,14 @@ spec: http: paths: - backend: - serviceName: httpserver

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #129: doc: update develop.md

tokers commented on a change in pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129#discussion_r548430523 ## File path: docs/develop.md ## @@ -89,12 +93,14 @@ spec: http: paths: - backend: - serviceName: httpserver

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #129: doc: update develop.md

gxthrj commented on a change in pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129#discussion_r548428684 ## File path: docs/develop.md ## @@ -89,12 +93,14 @@ spec: http: paths: - backend: - serviceName: httpserver

[GitHub] [apisix] yongboy opened a new issue #3117: The proxy-rewrite plugin does not support pass nginx's variable within header

yongboy opened a new issue #3117: URL: https://github.com/apache/apisix/issues/3117 ## Issue description I want to pass the nginx's [Embedded Variables](http://nginx.org/en/docs/http/ngx_http_core_module.html#variables) for upstream applications, below is my proxy-rewrite plugin's

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #129: doc: update develop.md

codecov-io commented on pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129#issuecomment-750784557 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/129?src=pr=h1) Report > Merging

[GitHub] [apisix] gy09535 commented on a change in pull request #3070: feat: add batch process metrics

gy09535 commented on a change in pull request #3070: URL: https://github.com/apache/apisix/pull/3070#discussion_r548426208 ## File path: doc/plugins/prometheus.md ## @@ -125,6 +125,7 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) *

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #129: doc: update develop.md

tokers opened a new pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1110: fix: not allowed to specify `create_time` and `update_time` when create/edit route, service, upstream and consumer

codecov-io commented on pull request #1110: URL: https://github.com/apache/apisix-dashboard/pull/1110#issuecomment-750781968 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1110?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1110: fix: not allowed to specify `create_time` and `update_time` when create/edit route, service, upstream and consumer

nic-chen commented on a change in pull request #1110: URL: https://github.com/apache/apisix-dashboard/pull/1110#discussion_r548423974 ## File path: api/test/e2e/route_with_management_fileds_test.go ## @@ -363,3 +363,75 @@ func TestRoute_search_by_label(t *testing.T) {

[GitHub] [apisix] spacewander commented on issue #3116: request help: To get route object and set headers

spacewander commented on issue #3116: URL: https://github.com/apache/apisix/issues/3116#issuecomment-750779304 Take a look at https://github.com/apache/apisix/commit/bdd00e1f55fd13cd3d2b12656ec1dc2d4e3f6e0b This is an

[GitHub] [apisix] ShaoZeMing commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

ShaoZeMing commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750778406 > > Take a look at https://github.com/apache/apisix/blob/master/apisix/plugins/openid-connect.lua > > I find a better one:

[GitHub] [apisix] ShaoZeMing commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

ShaoZeMing commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750777535 > > ### Issue description > > 我想实现一个网关自定义鉴权的功能，很类似rbac的拓展，但我们并不是用的这套rbac进行认证的，我想请教一下，是否有拓展能个填写自定义的请求地址，可以根据目标服务返回状态判断是否通行，并且可以将访问的数据携带下游服务中。如下图示意： > >

[GitHub] [apisix] spacewander commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

spacewander commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750776708 > > > Take a look at https://github.com/apache/apisix/blob/master/apisix/plugins/openid-connect.lua I find a better one:

[GitHub] [apisix] gy09535 commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

gy09535 commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750774401 > ### Issue description > 我想实现一个网关自定义鉴权的功能，很类似rbac的拓展，但我们并不是用的这套rbac进行认证的，我想请教一下，是否有拓展能个填写自定义的请求地址，可以根据目标服务返回状态判断是否通行，并且可以将访问的数据携带下游服务中。如下图示意： > >

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd

codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1112: feat: add test cases for rejecting request data if it contains an empty array

nic-chen commented on a change in pull request #1112: URL: https://github.com/apache/apisix-dashboard/pull/1112#discussion_r548417852 ## File path: api/test/e2e/route_test.go ## @@ -392,3 +392,135 @@ func TestRoute_Patch(t *testing.T) { testCaseCheck(tc)

[GitHub] [apisix] spacewander commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

spacewander commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750772190 Of course, you can't use openid-connect directly as your auth server doesn't implement the OIDC protocol. But you can implement similar thing base on this plugin as your auth

[GitHub] [apisix] spacewander merged pull request #3105: fix: ctx being contaminated due to a new feature of openresty 1.19

spacewander merged pull request #3105: URL: https://github.com/apache/apisix/pull/3105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #3079: apisix转发流量错误

spacewander closed issue #3079: URL: https://github.com/apache/apisix/issues/3079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: fix: ctx being contaminated due to a new feature of openresty 1.19 (#3105)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 5de9990 fix: ctx being contaminated due

[GitHub] [apisix-ingress-controller] nic-chen merged pull request #126: chore: go profile

nic-chen merged pull request #126: URL: https://github.com/apache/apisix-ingress-controller/pull/126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[apisix-ingress-controller] branch master updated: chore: go profile (#126)

This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new a3591e7 chore: go

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1116: test: enhance frontend e2e test stability (consumer)

codecov-io edited a comment on pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#issuecomment-750762834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1116?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #773: chore: introduce corba as the cli scafford

juzhiyuan commented on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-750768003 ping @membphis This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford

tokers commented on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-750767227 License about new dependencies: * github.com/cameront/go-jsonpatch MIT * github.com/coreos/bbolt MIT * github.com/dustin/go-humanize MIT *

[GitHub] [apisix] spacewander commented on a change in pull request #3070: feat: add batch process metrics

spacewander commented on a change in pull request #3070: URL: https://github.com/apache/apisix/pull/3070#discussion_r548411407 ## File path: doc/plugins/prometheus.md ## @@ -125,6 +125,7 @@ Or you can goto [Grafana official](https://grafana.com/grafana/dashboards/11719) *

[GitHub] [apisix] gy09535 commented on a change in pull request #3070: feat: add batch process metrics

gy09535 commented on a change in pull request #3070: URL: https://github.com/apache/apisix/pull/3070#discussion_r548408386 ## File path: apisix/utils/batch-processor.lua ## @@ -146,8 +150,20 @@ function batch_processor:push(entry) return end +if not

[GitHub] [apisix] spacewander commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

spacewander commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750765726 Take a look at https://github.com/apache/apisix/blob/master/apisix/plugins/openid-connect.lua This is an

[GitHub] [apisix] Ben0625 opened a new issue #3116: request help: To get route object and set headers

Ben0625 opened a new issue #3116: URL: https://github.com/apache/apisix/issues/3116 ### Issue description I want to get the self-defined parameter serve_name(which corresponds to Route one to one) printed in the 'access.log' by changing access_log_format ($http_serve_name). I want to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford

codecov-io edited a comment on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr=h1) Report > Merging

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #119: doc: add release download address for apisix-ingress-controller

juzhiyuan commented on a change in pull request #119: URL: https://github.com/apache/apisix-website/pull/119#discussion_r548404305 ## File path: docs/download.md ## @@ -20,6 +20,12 @@ Use the links below to download the Apache APISIX™ from one of our mirrors. | --- |

[GitHub] [apisix-website] gxthrj opened a new pull request #119: doc: add release download address for apisix-ingress-controller

gxthrj opened a new pull request #119: URL: https://github.com/apache/apisix-website/pull/119 Fixes: #[Add issue number here] Changes: add release download address for apisix-ingress-controller Screenshots of the change:

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1116: test: enhance frontend e2e test stability (consumer)

codecov-io commented on pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#issuecomment-750762834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1116?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] idbeta opened a new pull request #1116: test: enhance frontend e2e test stability (consumer)

idbeta opened a new pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance try to

[GitHub] [apisix] tokers commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

tokers commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-750756950 What you said is just like a Webhook feature. Now APISIX doesn't have it, PR's welcome! This is an automated message

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #128: chore: integrated api7/seven

codecov-io commented on pull request #128: URL: https://github.com/apache/apisix-ingress-controller/pull/128#issuecomment-750754484 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/128?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #128: chore: integrated api7/seven

tokers opened a new pull request #128: URL: https://github.com/apache/apisix-ingress-controller/pull/128 This commit integrated github.com/api7/seven module, previously the release it not so convenient. What's more, we have the follow changes: * Apache License V2 header is

[GitHub] [apisix-dashboard] idbeta commented on pull request #1109: fix: delete POST method in /apisix/admin/consumer

idbeta commented on pull request #1109: URL: https://github.com/apache/apisix-dashboard/pull/1109#issuecomment-750753105 > cc @idbeta @LiteSun It seems that the case is unstable. Let me try to fix it. Please help me to rerun the test first.

[GitHub] [apisix] ShaoZeMing opened a new issue #3115: 类似网关指定的路由或服务请求一个指定服务地址，根据地址定义的参数控制是否通过，并可以将部分参数传递下游？

ShaoZeMing opened a new issue #3115: URL: https://github.com/apache/apisix/issues/3115 ### Issue description 我想实现一个网关自定义鉴权的功能，很类似rbac的拓展，但我们并不是用的这套rbac进行认证的，我想请教一下，是否有拓展能个填写自定义的请求地址，可以根据目标服务返回状态判断是否通行，并且可以将访问的数据携带下游服务中。如下图示意：

[GitHub] [apisix] redynasc commented on pull request #2546: feat:health check for stream proxy

redynasc commented on pull request #2546: URL: https://github.com/apache/apisix/pull/2546#issuecomment-750751643 resolve the conflict This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] spacewander commented on issue #3114: request help: 如何覆盖掉全局的限速设置

spacewander commented on issue #3114: URL: https://github.com/apache/apisix/issues/3114#issuecomment-750743745 We can implement it in v2.3 version. Let's move the discussion to #986. This is an automated message from the

[GitHub] [apisix] spacewander commented on issue #3114: request help: 如何覆盖掉全局的限速设置

spacewander commented on issue #3114: URL: https://github.com/apache/apisix/issues/3114#issuecomment-750742183 It is not supported yet: https://github.com/apache/apisix/issues/986 This is an automated message from the Apache

[GitHub] [apisix] spacewander closed issue #3114: request help: 如何覆盖掉全局的限速设置

spacewander closed issue #3114: URL: https://github.com/apache/apisix/issues/3114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1115: bug: host pass error with dashboard 2.0

juzhiyuan commented on issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750742054  https://github.com/apache/apisix-dashboard/pull/1088

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1115: bug: host pass error with dashboard 2.0

juzhiyuan closed issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1115: bug: host pass error with dashboard 2.0

juzhiyuan commented on issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750741730 already supported yesterday, please check. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] kuberxy opened a new issue #3114: request help: 如何覆盖掉全局的限速设置

kuberxy opened a new issue #3114: URL: https://github.com/apache/apisix/issues/3114 我想对来自于公网的所有请求进行限速，但来自内网的请求不限速，该如何配置？ 我尝试的配置如下： apisix.yaml: ```yaml plugins: - name: limit-req global_rules: - id: 1 plugins: limit-req:

[GitHub] [apisix-ingress-controller] tokers commented on issue #96: Refactor: Move `seven` module into apisix-ingress-controller

tokers commented on issue #96: URL: https://github.com/apache/apisix-ingress-controller/issues/96#issuecomment-750729080 Let me do it. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] gy09535 edited a comment on issue #1115: bug: host pass error with dashboard 2.0

gy09535 edited a comment on issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750727084 > Do you mean dashboard need to support config `pass_host`? yeah, when we want change the backend service host, we can change it to node.

[GitHub] [apisix] nic-chen commented on pull request #3008: feat: improve jsonschema validation on route resource

nic-chen commented on pull request #3008: URL: https://github.com/apache/apisix/pull/3008#issuecomment-750727515 It doesn't have. If passing an empty array for it does not affect matching route, we could ignore it.

[GitHub] [apisix-dashboard] gy09535 commented on issue #1115: bug: host pass error with dashboard 2.0

gy09535 commented on issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750727084 > Do you mean dashboard need to support config `pass_host`? yeah, If we not do that, the upstream host should not be set.

[GitHub] [apisix] spacewander commented on pull request #3008: feat: improve jsonschema validation on route resource

spacewander commented on pull request #3008: URL: https://github.com/apache/apisix/pull/3008#issuecomment-750726704 `methods` doesn't have its single form? This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-ingress-controller] tokers commented on issue #57: prometheus metrics support

tokers commented on issue #57: URL: https://github.com/apache/apisix-ingress-controller/issues/57#issuecomment-750726619 We have the basic prometheus /metrics API, will add more metics to it in the future. This is an

[GitHub] [apisix-ingress-controller] tokers closed issue #57: prometheus metrics support

tokers closed issue #57: URL: https://github.com/apache/apisix-ingress-controller/issues/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1112: feat: add test cases for rejecting request data if it contains an empty array

nic-chen commented on a change in pull request #1112: URL: https://github.com/apache/apisix-dashboard/pull/1112#discussion_r548369168 ## File path: api/test/e2e/route_test.go ## @@ -392,3 +392,135 @@ func TestRoute_Patch(t *testing.T) { testCaseCheck(tc)

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI

codecov-io edited a comment on pull request #122: URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr=h1) Report > Merging

[GitHub] [apisix] nic-chen commented on pull request #3008: feat: improve jsonschema validation on route resource

nic-chen commented on pull request #3008: URL: https://github.com/apache/apisix/pull/3008#issuecomment-750724925 @spacewander missing update for `methods`.. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI

codecov-io edited a comment on pull request #122: URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen commented on issue #1115: bug: host pass error with dashboard 2.0

nic-chen commented on issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115#issuecomment-750723933 Do you mean dashboard need to support config `pass_host`? This is an automated message from the

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1109: fix: delete POST method in /apisix/admin/consumer

juzhiyuan edited a comment on pull request #1109: URL: https://github.com/apache/apisix-dashboard/pull/1109#issuecomment-750723667 cc @idbeta @LiteSun This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1109: fix: delete POST method in /apisix/admin/consumer

juzhiyuan commented on pull request #1109: URL: https://github.com/apache/apisix-dashboard/pull/1109#issuecomment-750723667 cc @LiteSun This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

juzhiyuan commented on a change in pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548366594 ## File path: .github/workflows/spellchecker.yml ## @@ -0,0 +1,21 @@ +name: spellchecker +on: + pull_request: +branches: + - master

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1089: feat(FE): add service module

juzhiyuan commented on a change in pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089#discussion_r548364908 ## File path: web/src/pages/Route/components/Step1/RequestConfigView.tsx ## @@ -376,6 +383,19 @@ const RequestConfigView: React.FC = ({

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI

codecov-io edited a comment on pull request #122: URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr=h1) Report > Merging

[GitHub] [apisix] gy09535 commented on a change in pull request #3070: feat: add batch process metrics

gy09535 commented on a change in pull request #3070: URL: https://github.com/apache/apisix/pull/3070#discussion_r548366235 ## File path: t/plugin/prometheus.t ## @@ -1088,3 +1088,207 @@ GET /apisix/prometheus/metrics --- error_code: 200 --- no_error_log [error] + + + +===

[GitHub] [apisix] gy09535 commented on a change in pull request #3070: feat: add batch process metrics

gy09535 commented on a change in pull request #3070: URL: https://github.com/apache/apisix/pull/3070#discussion_r548366235 ## File path: t/plugin/prometheus.t ## @@ -1088,3 +1088,207 @@ GET /apisix/prometheus/metrics --- error_code: 200 --- no_error_log [error] + + + +===

[GitHub] [apisix] spacewander commented on a change in pull request #3070: feat: add batch process metrics

spacewander commented on a change in pull request #3070: URL: https://github.com/apache/apisix/pull/3070#discussion_r548366160 ## File path: apisix/utils/batch-processor.lua ## @@ -146,8 +150,20 @@ function batch_processor:push(entry) return end +if not

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

starsz commented on a change in pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548365743 ## File path: .github/workflows/spellchecker.yml ## @@ -0,0 +1,21 @@ +name: spellchecker +on: + pull_request: +branches: + - master

[GitHub] [apisix-dashboard] gy09535 opened a new issue #1115: bug: host pass error with dashboard 2.0

gy09535 opened a new issue #1115: URL: https://github.com/apache/apisix-dashboard/issues/1115 ### Issue description When we set upstream in dashboard ,the value of "upstream.pass_host" not be set, after that we set the nodes with domain, the domain value should be set to the backend

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI

codecov-io edited a comment on pull request #122: URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] starsz commented on pull request #1109: fix: delete POST method in /apisix/admin/consumer

starsz commented on pull request #1109: URL: https://github.com/apache/apisix-dashboard/pull/1109#issuecomment-750721669 Ping @juzhiyuan. Help me look at the frontend CI. This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

juzhiyuan commented on a change in pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548364731 ## File path: .github/workflows/spellchecker.yml ## @@ -0,0 +1,21 @@ +name: spellchecker +on: + pull_request: +branches: + - master

[GitHub] [apisix] gy09535 opened a new issue #3113: bug: host pass error with dashboard 2.0

gy09535 opened a new issue #3113: URL: https://github.com/apache/apisix/issues/3113 ### Issue description When we set upstream in dashboard ,the value of "upstream.pass_host" not be set, after that we set the nodes with domain, the domain value should be set to the backend node, but

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1089: feat(FE): add service module

codecov-io edited a comment on pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089#issuecomment-748893636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1089?src=pr=h1) Report > Merging

[GitHub] [apisix] membphis commented on pull request #3105: fix: ctx being contaminated due to a new feature of openresty 1.19

membphis commented on pull request #3105: URL: https://github.com/apache/apisix/pull/3105#issuecomment-750720872 @nic-chen CI failed This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] HelloBug0 opened a new issue #3112: request help: what is the use of item_release in lrucache.lua

HelloBug0 opened a new issue #3112: URL: https://github.com/apache/apisix/issues/3112 ### Issue description When I study the code of APISIX, I'm not quite clear the file apisix/core/lrucache.lua from line 100 to line

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1064: fix: when enable or disable existing SSL, an error occurred

membphis commented on a change in pull request #1064: URL: https://github.com/apache/apisix-dashboard/pull/1064#discussion_r548363534 ## File path: api/internal/handler/ssl/ssl.go ## @@ -86,7 +86,11 @@ func (h *Handler) Get(c droplet.Context) (interface{}, error) { }

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1107: feat: add spell checker (#1013)

codecov-io commented on pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750719962 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] membphis commented on pull request #126: chore: go profile

membphis commented on pull request #126: URL: https://github.com/apache/apisix-ingress-controller/pull/126#issuecomment-750718804 @nic-chen you can take a look at this PR This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

starsz commented on a change in pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548362076 ## File path: .github/workflows/spellchecker.yml ## @@ -0,0 +1,24 @@ +name: spellchecker +on: + push: +branches: + - master Review

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

juzhiyuan commented on a change in pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548360413 ## File path: .github/workflows/spellchecker.yml ## @@ -0,0 +1,24 @@ +name: spellchecker +on: + push: +branches: + - master Review

[GitHub] [apisix] gy09535 commented on issue #2532: feat: Apisix upstream domain resolver can not support "search xxxx, options xxxxx" in k8s environment

gy09535 commented on issue #2532: URL: https://github.com/apache/apisix/issues/2532#issuecomment-750716267 > > I will try to do it next week, if I have times. > > any news? @gy09535 I am doing it in my company repository, when I finish it I will copy it to apisix.

[GitHub] [apisix] spacewander closed issue #2165: request help: multi-tenancy/multi-workspace feature

spacewander closed issue #2165: URL: https://github.com/apache/apisix/issues/2165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming commented on issue #2165: request help: multi-tenancy/multi-workspace feature

moonming commented on issue #2165: URL: https://github.com/apache/apisix/issues/2165#issuecomment-750715182 yes. Thanks, Ming Wen Twitter: _WenMing 罗泽轩 于2020年12月24日周四 上午10:40写道： > @moonming > I remember we move this feature to

[GitHub] [apisix] spacewander commented on issue #967: IP does not poll when using passive health-check

spacewander commented on issue #967: URL: https://github.com/apache/apisix/issues/967#issuecomment-750712515 This issue is marked as stale because it has not had activity for a long time. It will be closed in the next 7 days unless the label "stale" is removed. Thank you for your

[GitHub] [apisix] spacewander commented on issue #803: request help: Does the APISIX need to write the configuration to the local disk?

spacewander commented on issue #803: URL: https://github.com/apache/apisix/issues/803#issuecomment-750712286 This issue is marked as stale because it has not had activity for a long time. It will be closed in the next 7 days unless the label "stale" is removed. Thank you for your

[GitHub] [apisix] spacewander commented on issue #2165: request help: multi-tenancy/multi-workspace feature

spacewander commented on issue #2165: URL: https://github.com/apache/apisix/issues/2165#issuecomment-750712099 @moonming I remember we move this feature to Enterprise version? This is an automated message from the Apache

[GitHub] [apisix] spacewander commented on issue #812: request help: support tars/taf/trpc with tengine's or nginx's module

spacewander commented on issue #812: URL: https://github.com/apache/apisix/issues/812#issuecomment-750711937 This issue is marked as stale because it has not had activity for a long time. It will be closed in the next 7 days unless the label "stale" is removed. Thank you for your

  1   2   3   >