[GitHub] [apisix] spacewander commented on a change in pull request #2965: feat: use luasocket instead of curl in etcd.lua

2020-12-24 Thread GitBox
spacewander commented on a change in pull request #2965: URL: https://github.com/apache/apisix/pull/2965#discussion_r548827770 ## File path: apisix/cli/etcd.lua ## @@ -179,14 +179,14 @@ function _M.init(env, show_output) local post_json_auth = dkjson.encode(json_

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1118: fix: be consumer e2e test ci failed in pr#999

2020-12-24 Thread GitBox
codecov-io commented on pull request #1118: URL: https://github.com/apache/apisix-dashboard/pull/1118#issuecomment-751202005 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1118?src=pr&el=h1) Report > Merging [#1118](https://codecov.io/gh/apache/apisix-dashboard/pull/111

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1118: fix: be consumer e2e test ci failed in pr#999

2020-12-24 Thread GitBox
liuxiran opened a new pull request #1118: URL: https://github.com/apache/apisix-dashboard/pull/1118 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Relate

[GitHub] [apisix-helm-chart] spacewander opened a new pull request #10: chore: fix the service name in NOTES.txt

2020-12-24 Thread GitBox
spacewander opened a new pull request #10: URL: https://github.com/apache/apisix-helm-chart/pull/10 Fix #9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[apisix] branch master updated: feat: Implement traffic splitting plugin (#2935)

2020-12-24 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 86fa46d feat: Implement traffic splitting

[GitHub] [apisix] spacewander merged pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
spacewander merged pull request #2935: URL: https://github.com/apache/apisix/pull/2935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #2603: request help: dynamic-upstream 插件如何与1.5版本的apisix融合及2.0版本融合,后期考虑将这个插件直接集成到apisix中吗

2020-12-24 Thread GitBox
spacewander closed issue #2603: URL: https://github.com/apache/apisix/issues/2603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander closed issue #2303: Proposal: inptroduce traffic split plugin

2020-12-24 Thread GitBox
spacewander closed issue #2303: URL: https://github.com/apache/apisix/issues/2303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-helm-chart] moonming opened a new issue #9: request help: helm charts for Apache APISIX

2020-12-24 Thread GitBox
moonming opened a new issue #9: URL: https://github.com/apache/apisix-helm-chart/issues/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-helm-chart] Miss-you opened a new issue #8: BUG:install fail ‘pod has unbound immediate PersistentVolumeClaims’ on Qcloud/TencentCloud TKE

2020-12-24 Thread GitBox
Miss-you opened a new issue #8: URL: https://github.com/apache/apisix-helm-chart/issues/8 env:TKE command:helm install apisix ./chart/apisix -n default ![image](https://user-images.githubusercontent.com/3816205/103125563-737d6a00-46c6-11eb-8ff4-b27fb4df6f68.png) ![

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] moonming merged pull request #129: doc: update develop.md

2020-12-24 Thread GitBox
moonming merged pull request #129: URL: https://github.com/apache/apisix-ingress-controller/pull/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[apisix-ingress-controller] branch master updated: doc: update develop.md (#129)

2020-12-24 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new e58e6d6 doc: update develop

[GitHub] [apisix-ingress-controller] moonming merged pull request #128: chore: integrated api7/seven

2020-12-24 Thread GitBox
moonming merged pull request #128: URL: https://github.com/apache/apisix-ingress-controller/pull/128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[apisix-ingress-controller] branch master updated: chore: integrated api7/seven (#128)

2020-12-24 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new cf99f1f chore: integrated a

[GitHub] [apisix] spacewander commented on issue #2637: feat(CLI): support to specify proxy timeout in config.yaml

2020-12-24 Thread GitBox
spacewander commented on issue #2637: URL: https://github.com/apache/apisix/issues/2637#issuecomment-751194479 Now we set the timeout dynamically via https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#set_timeouts, see https://github.com/apache/apisix/blob/master/d

[GitHub] [apisix] spacewander closed issue #2637: feat(CLI): support to specify proxy timeout in config.yaml

2020-12-24 Thread GitBox
spacewander closed issue #2637: URL: https://github.com/apache/apisix/issues/2637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-ingress-controller] moonming merged pull request #122: chore: hone e2e test scaffold and run cases in CI

2020-12-24 Thread GitBox
moonming merged pull request #122: URL: https://github.com/apache/apisix-ingress-controller/pull/122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[apisix-ingress-controller] branch master updated: chore: hone e2e test scaffold and run cases in CI (#122)

2020-12-24 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new d339fe5 chore: hone e2e tes

[GitHub] [apisix] gewei2000 commented on issue #3126: request help: do we support pinpoint?

2020-12-24 Thread GitBox
gewei2000 commented on issue #3126: URL: https://github.com/apache/apisix/issues/3126#issuecomment-751192237 > We don't support pinpoint. It seems there is not an official / widely-used pinpoint client for OpenResty. Anyway, PR is welcome! 3Q ---

[GitHub] [apisix] gewei2000 closed issue #3126: request help: do we support pinpoint?

2020-12-24 Thread GitBox
gewei2000 closed issue #3126: URL: https://github.com/apache/apisix/issues/3126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] tokers opened a new issue #133: Refactor: Optimize process of resources push to APISIX

2020-12-24 Thread GitBox
tokers opened a new issue #133: URL: https://github.com/apache/apisix-ingress-controller/issues/133 When `ApisixRoute`, `ApisixUpstream` and other CRDs are watched by ingress controller, it converts these objects to the format of APISIX Resources, like Route, Upstream and etc. Curre

[GitHub] [apisix] spacewander commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-24 Thread GitBox
spacewander commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r548819011 ## File path: apisix/admin/plugins.lua ## @@ -37,7 +37,42 @@ function _M.stream_check_schema(plugins_conf, schema_type) end +local function get_pl

[GitHub] [apisix] tzssangglass commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-24 Thread GitBox
tzssangglass commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r548818437 ## File path: apisix/admin/plugins.lua ## @@ -37,7 +37,42 @@ function _M.stream_check_schema(plugins_conf, schema_type) end +local function get_p

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1104: test: add frontend e2e test (smoke test for metrics page)

2020-12-24 Thread GitBox
juzhiyuan commented on a change in pull request #1104: URL: https://github.com/apache/apisix-dashboard/pull/1104#discussion_r548817956 ## File path: web/cypress/integration/metrics/metrics-smoketest.spec.js ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [apisix] spacewander closed issue #3060: bug: kafka logger plugin - failed to process entries: failed to send data to Kafka topic: not found topic

2020-12-24 Thread GitBox
spacewander closed issue #3060: URL: https://github.com/apache/apisix/issues/3060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1104: test: add frontend e2e test (smoke test for metrics page)

2020-12-24 Thread GitBox
juzhiyuan commented on a change in pull request #1104: URL: https://github.com/apache/apisix-dashboard/pull/1104#discussion_r548817837 ## File path: web/cypress/integration/metrics/metrics-smoketest.spec.js ## @@ -16,7 +16,7 @@ */ /* eslint-disable no-undef */ -context('ss

[GitHub] [apisix-dashboard] liuxiran commented on pull request #999: feat: add route group

2020-12-24 Thread GitBox
liuxiran commented on pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#issuecomment-751190127 > e2e failed, @idbeta @nic-chen https://github.com/apache/apisix-dashboard/blob/e0af89e7df02de137aeac3d4bad53cf2efde41c6/api/test/e2e/consumer_test.go#L191

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-24 Thread GitBox
juzhiyuan commented on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-751190129 After those PRs were merged, we need to: - [ ] Use a global file to contain global variables; - [ ] We should use `it should xxx` instead of `it creates xxx`; -

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1089: feat(FE): add service module

2020-12-24 Thread GitBox
juzhiyuan merged pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-dashboard] juzhiyuan closed issue #471: Support Service

2020-12-24 Thread GitBox
juzhiyuan closed issue #471: URL: https://github.com/apache/apisix-dashboard/issues/471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated (b3819c5 -> e0af89e)

2020-12-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from b3819c5 chore: introduce corba as the cli scafford (#773) add e0af89e feat(FE): add service modul

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #999: feat: add route group

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#issuecomment-742169695 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/999?src=pr&el=h1) Report > Merging [#999](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1) Report > Merging [#1066](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-24 Thread GitBox
juzhiyuan commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r548815779 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1089: feat(FE): add service module

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089#issuecomment-748893636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1089?src=pr&el=h1) Report > Merging [#1089](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548815490 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-24 Thread GitBox
juzhiyuan commented on a change in pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105#discussion_r548814851 ## File path: web/cypress/integration/settings/settings-smoketest.spec.js ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#issuecomment-750762834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1116?src=pr&el=h1) Report > Merging [#1116](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander commented on issue #3126: request help: do we support pinpoint?

2020-12-24 Thread GitBox
spacewander commented on issue #3126: URL: https://github.com/apache/apisix/issues/3126#issuecomment-751186654 We don't support pinpoint. It seems there is not an official / widely-used pinpoint client for OpenResty. Anyway, PR is welcome! -

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1089: feat(FE): add service module

2020-12-24 Thread GitBox
liuxiran commented on a change in pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089#discussion_r548813728 ## File path: web/src/pages/Service/Create.tsx ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix] momo8zero closed issue #3123: request help: Route中vars不能使用IN操作符

2020-12-24 Thread GitBox
momo8zero closed issue #3123: URL: https://github.com/apache/apisix/issues/3123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] momo8zero commented on issue #3123: request help: Route中vars不能使用IN操作符

2020-12-24 Thread GitBox
momo8zero commented on issue #3123: URL: https://github.com/apache/apisix/issues/3123#issuecomment-751185291 > "vars": [ > ["http_token","IN",["1","2"]] > ] > is the correct way. > > The validation has bug. I fix it in #3124. Thank you!!!

[GitHub] [apisix] gewei2000 opened a new issue #3126: request help: do we support pinpoint?

2020-12-24 Thread GitBox
gewei2000 opened a new issue #3126: URL: https://github.com/apache/apisix/issues/3126 ### Issue description do we support pinpoint? ### Environment * apisix version (cmd: `apisix version`):2.1 * OS: centos7 * OpenResty / Nginx version: 1.19.3.1 --

[GitHub] [apisix-dashboard] tokers closed issue #739: Use cobra instead of flags for better CLI interactive feeling

2020-12-24 Thread GitBox
tokers closed issue #739: URL: https://github.com/apache/apisix-dashboard/issues/739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] tokers commented on issue #739: Use cobra instead of flags for better CLI interactive feeling

2020-12-24 Thread GitBox
tokers commented on issue #739: URL: https://github.com/apache/apisix-dashboard/issues/739#issuecomment-751184943 Solved since #773 was merged. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-dashboard] tokers merged pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
tokers merged pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-dashboard] branch master updated (b3463fd -> b3819c5)

2020-12-24 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from b3463fd fix: delete POST method in /apisix/admin/consumer (#1109) add b3819c5 chore: introduce corb

[GitHub] [apisix] spacewander opened a new pull request #3125: docs: improve the plugin-develop doc

2020-12-24 Thread GitBox
spacewander opened a new pull request #3125: URL: https://github.com/apache/apisix/pull/3125 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #999: feat: add route group

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r548812825 ## File path: web/src/pages/Route/components/Step1/LabelsDrawer.tsx ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
tokers commented on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-751184427 > @tokers , What happen to the `.actions/openwhisk-utilities`? > Please see the file changes. We don't reference it as a submodule, just download it and use it in

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #999: feat: add route group

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r548812801 ## File path: web/src/pages/Route/List.tsx ## @@ -14,21 +14,32 @@ * See the License for the specific language governing permissions and * limit

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #999: feat: add route group

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r548812782 ## File path: web/src/locales/zh-CN/component.ts ## @@ -32,6 +32,7 @@ export default { 'component.global.loading': '加载中', 'component.global.l

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1096: test: add frontend e2e test (smoke test for ssl)

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1096: URL: https://github.com/apache/apisix-dashboard/pull/1096#issuecomment-749412383 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1096?src=pr&el=h1) Report > Merging [#1096](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #999: feat: add route group

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#issuecomment-742169695 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/999?src=pr&el=h1) Report > Merging [#999](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report > Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] spacewander commented on issue #3123: request help: Route中vars不能使用IN操作符

2020-12-24 Thread GitBox
spacewander commented on issue #3123: URL: https://github.com/apache/apisix/issues/3123#issuecomment-751183185 "vars": [ ["http_token","IN",["1","2"]] ] is the correct way. The validation has bug. I fix it in https://github.com/apache/apisix/pull/3124.

[GitHub] [apisix] spacewander opened a new pull request #3124: fix: correct the validation of route.vars

2020-12-24 Thread GitBox
spacewander opened a new pull request #3124: URL: https://github.com/apache/apisix/pull/3124 Previously only the type is applied, and it is too strict. And now we should allow 4 items in the vars expression. Fix #3123 Signed-off-by: spacewander ### What this PR does

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#issuecomment-750762834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1116?src=pr&el=h1) Report > Merging [#1116](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-24 Thread GitBox
idbeta commented on a change in pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#discussion_r548811562 ## File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js ## @@ -57,6 +57,8 @@ context('Create and Delete Consumer', () =>

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1108: chore: adjust directory structure of api

2020-12-24 Thread GitBox
starsz commented on a change in pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548810935 ## File path: api/internal/filter/authentication.go ## @@ -20,11 +20,11 @@ import ( "net/http" "strings" - "github.com/dgr

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report > Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix] idbeta commented on a change in pull request #3061: test: add ci on centos7

2020-12-24 Thread GitBox
idbeta commented on a change in pull request #3061: URL: https://github.com/apache/apisix/pull/3061#discussion_r548811041 ## File path: .github/workflows/centos7.yml ## @@ -0,0 +1,109 @@ +name: test_apisix_on_centos7 + +on: + push: +branches: + - master + pull_reques

[GitHub] [apisix] tokers commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
tokers commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548810397 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [**Att

[GitHub] [apisix] spacewander commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2020-12-24 Thread GitBox
spacewander commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-751181222 We only need lock when the cache is miss, and need to create the object (via query other system) This is an autom

[GitHub] [apisix-dashboard] tokers merged pull request #1109: fix: delete POST method in /apisix/admin/consumer

2020-12-24 Thread GitBox
tokers merged pull request #1109: URL: https://github.com/apache/apisix-dashboard/pull/1109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-dashboard] tokers closed issue #852: bug: manager-api supported `POST` method for consumer

2020-12-24 Thread GitBox
tokers closed issue #852: URL: https://github.com/apache/apisix-dashboard/issues/852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix-dashboard] branch master updated: fix: delete POST method in /apisix/admin/consumer (#1109)

2020-12-24 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new b3463fd fix: delete POST method in /a

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548809598 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [

[GitHub] [apisix-dashboard] starsz commented on pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
starsz commented on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-751179386 @tokers , What happen to the `.actions/openwhisk-utilities`? Please see the file changes. This is an au

[GitHub] [apisix-docker] gxthrj commented on issue #107: request help: docker hub for apisix v1.5

2020-12-24 Thread GitBox
gxthrj commented on issue #107: URL: https://github.com/apache/apisix-docker/issues/107#issuecomment-751179377 @moonming Do you have time to look at this issue, it seems something was wrong when building or pushing image. Th

[GitHub] [apisix] tokers commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
tokers commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548807680 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [**Att

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1109: fix: delete POST method in /apisix/admin/consumer

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1109: URL: https://github.com/apache/apisix-dashboard/pull/1109#issuecomment-750319379 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1109?src=pr&el=h1) Report > Merging [#1109](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
membphis commented on a change in pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#discussion_r548807322 ## File path: api/go.sum ## @@ -1,30 +1,86 @@ +cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= Review comment

[GitHub] [apisix] HelloBug0 commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2020-12-24 Thread GitBox
HelloBug0 commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-751174034 Oh, I mean locking from line 100 to line 104. Sorry about the mistake. ```lua local cache_obj = fetch_valid_cache(lru_obj, invalid_stale, item_ttl,

[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: mv main.go to cmd

2020-12-24 Thread GitBox
gxthrj commented on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751173797 > should we move 'log' and 'conf' into 'internal' too? Done This is an automated message from the

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report > Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548804016 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report > Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: mv main.go to cmd

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report > Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #773: chore: introduce corba as the cli scafford

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-747383388 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/773?src=pr&el=h1) Report > Merging [#773](https://codecov.io/gh/apache/apisix-dashboard/pull/

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1098: The menu bar `consumer ` in Chinese view supports Chinese

2020-12-24 Thread GitBox
juzhiyuan commented on issue #1098: URL: https://github.com/apache/apisix-dashboard/issues/1098#issuecomment-751172436 1. `消费者`; 2. `应用`; 3. xxx This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1013: add spell CI tool

2020-12-24 Thread GitBox
juzhiyuan closed issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1107: feat: add spell checker (#1013)

2020-12-24 Thread GitBox
juzhiyuan merged pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: feat: add spell checker (#1013) (#1107)

2020-12-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 2666052 feat: add spell checker (#

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

2020-12-24 Thread GitBox
juzhiyuan commented on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751172123 ping @guoqqqi This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix] nopost commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2020-12-24 Thread GitBox
nopost commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-751168179 Organization: zihao.biz Location: Hangzhou, China Contact: nop...@qq.com Scenario: to manage dynamic proxy and pass proxy api ,As a gateway, it processes the traffic between var

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #1063: fix: when create a route without ID in request body by Admin API, it can't be displayed in Manager API

2020-12-24 Thread GitBox
ShiningRush commented on a change in pull request #1063: URL: https://github.com/apache/apisix-dashboard/pull/1063#discussion_r548796489 ## File path: api/internal/core/store/store.go ## @@ -54,7 +54,7 @@ type GenericStore struct { type GenericStoreOption struct { Base

[GitHub] [apisix-dashboard] jinchizhou closed pull request #1114: test if CI tests broke

2020-12-24 Thread GitBox
jinchizhou closed pull request #1114: URL: https://github.com/apache/apisix-dashboard/pull/1114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1096: test: add frontend e2e test (smoke test for ssl)

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #1096: URL: https://github.com/apache/apisix-dashboard/pull/1096#discussion_r548795161 ## File path: web/cypress/integration/ssl/ssl-smoketest.spec.js ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1096: test: add frontend e2e test (smoke test for ssl)

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #1096: URL: https://github.com/apache/apisix-dashboard/pull/1096#discussion_r548795125 ## File path: web/cypress/integration/ssl/ssl-smoketest.spec.js ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix] tokers commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
tokers commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548793999 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [**Att

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1089: feat(FE): add service module

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089#discussion_r548793531 ## File path: web/src/pages/Service/components/Step1.tsx ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1063: fix: when create a route without ID in request body by Admin API, it can't be displayed in Manager API

2020-12-24 Thread GitBox
codecov-io edited a comment on pull request #1063: URL: https://github.com/apache/apisix-dashboard/pull/1063#issuecomment-747899278 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1063?src=pr&el=h1) Report > Merging [#1063](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548793046 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [

[GitHub] [apisix] starsz commented on a change in pull request #2965: feat: use luasocket instead of curl in etcd.lua

2020-12-24 Thread GitBox
starsz commented on a change in pull request #2965: URL: https://github.com/apache/apisix/pull/2965#discussion_r548792861 ## File path: apisix/cli/etcd.lua ## @@ -160,31 +163,38 @@ function _M.init(env, show_output) for index, host in ipairs(yaml_conf.etcd.host) do

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#discussion_r548792530 ## File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js ## @@ -57,6 +57,8 @@ context('Create and Delete Consumer', () =

[GitHub] [apisix] tokers commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
tokers commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548791147 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [**Att

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1097: feat: "upstream" i18n

2020-12-24 Thread GitBox
LiteSun commented on a change in pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548782425 ## File path: web/src/pages/Upstream/locales/en-US.ts ## @@ -61,10 +68,12 @@ export default { 'upstream.step.healthy.checks.successes': 'Succe

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-24 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r548790153 ## File path: doc/plugins/traffic-split.md ## @@ -0,0 +1,409 @@ + + +- [中文](../zh-cn/plugins/traffic-split.md) + +# Summary + +- [**Name**](#name) +- [

  1   2   3   >