[GitHub] [apisix-dashboard] nic-chen commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
nic-chen commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-751327560 merged. thanks @jinchizhou This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix-dashboard] nic-chen merged pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
nic-chen merged pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] nic-chen closed issue #566: bug: need to check ID between path and body

2020-12-25 Thread GitBox
nic-chen closed issue #566: URL: https://github.com/apache/apisix-dashboard/issues/566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated: fix: error check to ensure path id doesn't conflict body id (#1067)

2020-12-25 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 678b94d fix: error check to ensure

[GitHub] [apisix] HelloBug0 commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2020-12-25 Thread GitBox
HelloBug0 commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-751319250 I see. There is need to protect the cache when setting a stale object. In this way, I also have two questions. + Why do we lock the function execution of fetch_valid_cache in line

[GitHub] [apisix] juzhiyuan merged pull request #3122: ci: remove mac os CI

2020-12-25 Thread GitBox
juzhiyuan merged pull request #3122: URL: https://github.com/apache/apisix/pull/3122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: ci: remove mac os CI (#3122)

2020-12-25 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new fb70133 ci: remove mac os CI (#3122) fb70133

[GitHub] [apisix] dabuge opened a new pull request #3130: document fixed

2020-12-25 Thread GitBox
dabuge opened a new pull request #3130: URL: https://github.com/apache/apisix/pull/3130 ### What this PR does / why we need it: Optimized several places in the document that may cause confusion to developers T

[GitHub] [apisix-dashboard] nic-chen commented on issue #1127: bug: manager-api doesn't support PATCH method

2020-12-25 Thread GitBox
nic-chen commented on issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-751316039 @starsz Patch methods for service, upstream, consumer have bug, you could refer to Patch method for SSL or route.

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1) Report > Merging [#1067](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1) Report > Merging [#1067](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1) Report > Merging [#1067](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1) Report > Merging [#1067](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1) Report > Merging [#1067](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method

2020-12-25 Thread GitBox
starsz commented on issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-751310873 Please assigned it to me. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1129: fix(FE): upstream value not change when change upstream_id

2020-12-25 Thread GitBox
juzhiyuan merged pull request #1129: URL: https://github.com/apache/apisix-dashboard/pull/1129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: WIP: fetch category from manager-api

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1122: URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/p

[apisix-dashboard] branch master updated (de3c03e -> 06cb68f)

2020-12-25 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from de3c03e test: add frontend e2e test (smoke test for ssl) (#1096) add 06cb68f fix:value not change

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1129: fix(FE): upstream value not change when change upstream_id

2020-12-25 Thread GitBox
codecov-io commented on pull request #1129: URL: https://github.com/apache/apisix-dashboard/pull/1129#issuecomment-751310068 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1129?src=pr&el=h1) Report > Merging [#1129](https://codecov.io/gh/apache/apisix-dashboard/pull/112

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1129: fix(FE): upstream value not change when change upstream_id

2020-12-25 Thread GitBox
LiteSun opened a new pull request #1129: URL: https://github.com/apache/apisix-dashboard/pull/1129 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix] spacewander commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2020-12-25 Thread GitBox
spacewander commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-751309188 There is only a getter, and a setter to set a stale object back as valid object. There is not a way to create a new one. -

[GitHub] [apisix] Firstsawyou commented on issue #3108: bug: limit-count plugin does not take effect

2020-12-25 Thread GitBox
Firstsawyou commented on issue #3108: URL: https://github.com/apache/apisix/issues/3108#issuecomment-751308388 > how is the bug?and need test cases to cover In version 1.5, the ctx.conf_version generated by different `workers` is different, which leads to this bug. Example:

[GitHub] [apisix] tokers commented on pull request #3129: WIP:feat: support linux "resolv.conf" file resolve process

2020-12-25 Thread GitBox
tokers commented on pull request #3129: URL: https://github.com/apache/apisix/pull/3129#issuecomment-751307999 Good feature! This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #131: chore: refactor conf/ directory

2020-12-25 Thread GitBox
tokers commented on a change in pull request #131: URL: https://github.com/apache/apisix-ingress-controller/pull/131#discussion_r548930435 ## File path: conf/config-default.json ## @@ -0,0 +1,13 @@ +{ + "log_level": "info", + "log_output": "stderr", + "http_listen": ":8080"

[GitHub] [apisix] HelloBug0 commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2020-12-25 Thread GitBox
HelloBug0 commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-751306315 It's possible to create the object in function fetch_valid_cache in line 100. ```lua local function fetch_valid_cache(lru_obj, invalid_stale, item_ttl,

[GitHub] [apisix] spacewander commented on a change in pull request #3125: docs: improve the plugin-develop doc

2020-12-25 Thread GitBox
spacewander commented on a change in pull request #3125: URL: https://github.com/apache/apisix/pull/3125#discussion_r548927856 ## File path: doc/plugin-develop.md ## @@ -106,33 +108,41 @@ $(INSTALL) apisix/plugins/skywalking/*.lua $(INST_LUADIR)/apisix/plugins/skywalk ## sc

[GitHub] [apisix-dashboard] juzhiyuan closed issue #641: add e2e test for SSL

2020-12-25 Thread GitBox
juzhiyuan closed issue #641: URL: https://github.com/apache/apisix-dashboard/issues/641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1096: test: add frontend e2e test (smoke test for ssl)

2020-12-25 Thread GitBox
juzhiyuan merged pull request #1096: URL: https://github.com/apache/apisix-dashboard/pull/1096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: test: add frontend e2e test (smoke test for ssl) (#1096)

2020-12-25 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new de3c03e test: add frontend e2e tes

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1096: test: add frontend e2e test (smoke test for ssl)

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1096: URL: https://github.com/apache/apisix-dashboard/pull/1096#issuecomment-749412383 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1096?src=pr&el=h1) Report > Merging [#1096](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] moonming commented on issue #3108: bug: limit-count plugin does not take effect

2020-12-25 Thread GitBox
moonming commented on issue #3108: URL: https://github.com/apache/apisix/issues/3108#issuecomment-751301095 how is the bug?and need test cases to cover This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix] nic-chen commented on a change in pull request #3125: docs: improve the plugin-develop doc

2020-12-25 Thread GitBox
nic-chen commented on a change in pull request #3125: URL: https://github.com/apache/apisix/pull/3125#discussion_r548923262 ## File path: doc/plugin-develop.md ## @@ -106,33 +108,41 @@ $(INSTALL) apisix/plugins/skywalking/*.lua $(INST_LUADIR)/apisix/plugins/skywalk ## schem

[GitHub] [apisix] spacewander closed issue #3128: request help: can't set redis policy in 'limit-count'

2020-12-25 Thread GitBox
spacewander closed issue #3128: URL: https://github.com/apache/apisix/issues/3128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-docker] gxthrj commented on issue #96: Unable to start port 9443 in docker

2020-12-25 Thread GitBox
gxthrj commented on issue #96: URL: https://github.com/apache/apisix-docker/issues/96#issuecomment-751270373 It seems the `ssl_cert` and `ssl_cert_key` must be set In APISIX 2.1 when ssl is enabled. This is an automated mes

[GitHub] [apisix-docker] gxthrj commented on issue #97: bug: when set `apisix.ssl.enable: true`, can not start APISIX with docker 2.1-alpine

2020-12-25 Thread GitBox
gxthrj commented on issue #97: URL: https://github.com/apache/apisix-docker/issues/97#issuecomment-751269913 Close this issue now , it is the same reason with #106 This is an automated message from the Apache Git Service. To

[GitHub] [apisix-docker] gxthrj closed issue #97: bug: when set `apisix.ssl.enable: true`, can not start APISIX with docker 2.1-alpine

2020-12-25 Thread GitBox
gxthrj closed issue #97: URL: https://github.com/apache/apisix-docker/issues/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #131: chore: refactor conf/ directory

2020-12-25 Thread GitBox
gxthrj commented on a change in pull request #131: URL: https://github.com/apache/apisix-ingress-controller/pull/131#discussion_r548890838 ## File path: conf/config-default.json ## @@ -0,0 +1,13 @@ +{ + "log_level": "info", + "log_output": "stderr", + "http_listen": ":8080"

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1128: WIP: add backend e2e test for service

2020-12-25 Thread GitBox
codecov-io commented on pull request #1128: URL: https://github.com/apache/apisix-dashboard/pull/1128#issuecomment-751268618 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1128?src=pr&el=h1) Report > Merging [#1128](https://codecov.io/gh/apache/apisix-dashboard/pull/112

[GitHub] [apisix] Firstsawyou commented on issue #3108: bug: limit-count plugin does not take effect

2020-12-25 Thread GitBox
Firstsawyou commented on issue #3108: URL: https://github.com/apache/apisix/issues/3108#issuecomment-751268462 This bug has been fixed in the version after `1.5`. This `bug` can be reproduced in the `1.5` version, but this `bug` cannot be reproduced in the `2.0` version. After comparing th

[GitHub] [apisix-dashboard] idbeta opened a new pull request #1128: WIP: add backend e2e test for service

2020-12-25 Thread GitBox
idbeta opened a new pull request #1128: URL: https://github.com/apache/apisix-dashboard/pull/1128 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] E2E test - [ ] New feature provided - [ ] Improve performance - Relate

[GitHub] [apisix-dashboard] idbeta opened a new issue #1127: bug: manager-api do not support PATCH method

2020-12-25 Thread GitBox
idbeta opened a new issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127 # Bug report ## Describe the bug manager-api do not support PATCH method: when using the following three types of bodies to update node of `service`, will be error 1. ``` {

[GitHub] [apisix-dashboard] juzhiyuan closed issue #694: Use Icons from local

2020-12-25 Thread GitBox
juzhiyuan closed issue #694: URL: https://github.com/apache/apisix-dashboard/issues/694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #687: Improve documentation about how to use with APISIX

2020-12-25 Thread GitBox
juzhiyuan closed issue #687: URL: https://github.com/apache/apisix-dashboard/issues/687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #922: test: E2E test case unstable

2020-12-25 Thread GitBox
juzhiyuan commented on issue #922: URL: https://github.com/apache/apisix-dashboard/issues/922#issuecomment-751265398 ![image](https://user-images.githubusercontent.com/2106987/103138304-0f7d9480-470c-11eb-834e-c02813c86343.png) FYI: @starsz is working on this issue. --

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1035: bug: create route with plugin, will be error

2020-12-25 Thread GitBox
juzhiyuan closed issue #1035: URL: https://github.com/apache/apisix-dashboard/issues/1035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] gy09535 opened a new pull request #3129: WIP:feat: support linux "resolv.conf" file resolve process

2020-12-25 Thread GitBox
gy09535 opened a new pull request #3129: URL: https://github.com/apache/apisix/pull/3129 ### What this PR does / why we need it: fix:https://github.com/apache/apisix/issues/2532 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or w

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1124: fix: can not manual input in upstream

2020-12-25 Thread GitBox
juzhiyuan merged pull request #1124: URL: https://github.com/apache/apisix-dashboard/pull/1124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: fix: can not manual input in upstream (#1124)

2020-12-25 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 2daab27 fix: can not manual input

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1124: fix: can not manual input in upstream

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1124: URL: https://github.com/apache/apisix-dashboard/pull/1124#issuecomment-751219802 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1124?src=pr&el=h1) Report > Merging [#1124](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: WIP: fetch category from manager-api

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1122: URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] membphis commented on a change in pull request #3061: test: add ci on centos7

2020-12-25 Thread GitBox
membphis commented on a change in pull request #3061: URL: https://github.com/apache/apisix/pull/3061#discussion_r548883373 ## File path: utils/centos7-install-dependencies-ci.sh ## @@ -0,0 +1,38 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] [apisix-docker] gxthrj commented on issue #106: 9443 端口无法请求

2020-12-25 Thread GitBox
gxthrj commented on issue #106: URL: https://github.com/apache/apisix-docker/issues/106#issuecomment-751260516 Close this issue now , feel free to reopen if you have any doubt. This is an automated message from the Apache Gi

[GitHub] [apisix-docker] gxthrj closed issue #106: 9443 端口无法请求

2020-12-25 Thread GitBox
gxthrj closed issue #106: URL: https://github.com/apache/apisix-docker/issues/106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
juzhiyuan commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751258787 cc @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] nic-chen merged pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
nic-chen merged pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] nic-chen closed issue #731: [style] adjust directory structure of api to golang standard style

2020-12-25 Thread GitBox
nic-chen closed issue #731: URL: https://github.com/apache/apisix-dashboard/issues/731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen closed issue #721: refactory(manager-api): use Golang standard file structure

2020-12-25 Thread GitBox
nic-chen closed issue #721: URL: https://github.com/apache/apisix-dashboard/issues/721 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-dashboard] branch master updated: chore: adjust directory structure of api (#1108)

2020-12-25 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new cc9eb35 chore: adjust directory st

[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
gxthrj commented on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751254496 cc @nic-chen This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] Firstsawyou commented on issue #3128: request help: can't set redis policy in 'limit-count'

2020-12-25 Thread GitBox
Firstsawyou commented on issue #3128: URL: https://github.com/apache/apisix/issues/3128#issuecomment-751254234 The schema does not match, it seems that redis_port is not an `integer` causing the problem. This is an automated

[GitHub] [apisix-dashboard] gxthrj commented on pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
gxthrj commented on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751252597 > @gxthrj do we need to update docs for changes ? The original document refers to `make build` directly when building, so there is no need to update docs. But w

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr&el=h1) Report > Merging [#1067](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] qwxingzhe commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
qwxingzhe commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751249655 > @qwxingzhe > APISIX 2.1 doesn't have plugin `error-log-logger.lua`, you can download it on: > https://github.com/apache/apisix/releases/tag/2.1 > > if you a

[GitHub] [apisix] spacewander merged pull request #3127: chore: expose more schema via control API

2020-12-25 Thread GitBox
spacewander merged pull request #3127: URL: https://github.com/apache/apisix/pull/3127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (86fa46d -> baf8a26)

2020-12-25 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 86fa46d feat: Implement traffic splitting plugin (#2935) add baf8a26 chore: expose more schema via contro

[GitHub] [apisix-dashboard] nic-chen commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
nic-chen commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751249003 @qwxingzhe APISIX 2.1 doesn't have plugin `error-log-logger.lua`, you can download it on: https://github.com/apache/apisix/releases/tag/2.1 if you are using c

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
nic-chen commented on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-751247756 @gxthrj do we need to update docs for changes ? This is an automated message from the Apache Git Serv

[GitHub] [apisix] jbampton commented on a change in pull request #3125: docs: improve the plugin-develop doc

2020-12-25 Thread GitBox
jbampton commented on a change in pull request #3125: URL: https://github.com/apache/apisix/pull/3125#discussion_r548869892 ## File path: doc/plugin-develop.md ## @@ -106,33 +108,41 @@ $(INSTALL) apisix/plugins/skywalking/*.lua $(INST_LUADIR)/apisix/plugins/skywalk ## schem

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
gxthrj commented on a change in pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548869960 ## File path: api/internal/handler/route/route.go ## @@ -29,16 +29,16 @@ import ( "github.com/shiningrush/droplet" "github.com/shi

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
starsz commented on a change in pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548868619 ## File path: api/internal/handler/route/route.go ## @@ -29,16 +29,16 @@ import ( "github.com/shiningrush/droplet" "github.com/shi

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1124: fix: can not manual input in upstream

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1124: URL: https://github.com/apache/apisix-dashboard/pull/1124#issuecomment-751219802 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1124?src=pr&el=h1) Report > Merging [#1124](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report > Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] starsz commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
starsz commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751242989 Hi @qwxingzhe, Because the `schema-sync.lua` doesn't preload the package `ngx.errlog` on v2.2. Maybe you can try the `schema-sync.lua` on master branch. See more de

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report > Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander commented on issue #3128: request help: can't set redis policy in 'limit-count'

2020-12-25 Thread GitBox
spacewander commented on issue #3128: URL: https://github.com/apache/apisix/issues/3128#issuecomment-751242454 The `redis_port` should be integer. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#issuecomment-750012360 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1108?src=pr&el=h1) Report > Merging [#1108](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #1108: chore: adjust directory structure of api

2020-12-25 Thread GitBox
gxthrj commented on a change in pull request #1108: URL: https://github.com/apache/apisix-dashboard/pull/1108#discussion_r548865291 ## File path: api/internal/handler/route/route.go ## @@ -30,15 +30,15 @@ import ( "github.com/shiningrush/droplet/data" "github.co

[GitHub] [apisix] zhuliquan opened a new issue #3128: request help: can't set redis policy in 'limit-count'

2020-12-25 Thread GitBox
zhuliquan opened a new issue #3128: URL: https://github.com/apache/apisix/issues/3128 ### Issue description **error:** {"error_msg":"failed to check the configuration of plugin limit-count err: failed to validate dependent schema for \"policy\": value should match only one schema, bu

[GitHub] [apisix-dashboard] qwxingzhe edited a comment on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
qwxingzhe edited a comment on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751222659 > @qwxingzhe > what versions are your APISIX and Dashboard? Dashboard:v2.2 APISIX :2.1 lua:5.1.4 I installed it according to this document

[GitHub] [apisix-dashboard] qwxingzhe edited a comment on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
qwxingzhe edited a comment on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751222659 > @qwxingzhe > what versions are your APISIX and Dashboard? Dashboard:v2.2 APISIX :2.1 I installed it according to this document https://githu

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105#issuecomment-749952748 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1105?src=pr&el=h1) Report > Merging [#1105](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] qwxingzhe commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
qwxingzhe commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751222659 > @qwxingzhe > what versions are your APISIX and Dashboard? v2.2 I installed it according to this document https://github.com/apache/apisix-dashboard/bl

[GitHub] [apisix-dashboard] nic-chen merged pull request #1123: fix: fix some sleep location in e2e test

2020-12-25 Thread GitBox
nic-chen merged pull request #1123: URL: https://github.com/apache/apisix-dashboard/pull/1123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1122: WIP: fetch category from manager-api

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1122: URL: https://github.com/apache/apisix-dashboard/pull/1122#issuecomment-751216045 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1122?src=pr&el=h1) Report > Merging [#1122](https://codecov.io/gh/apache/apisix-dashboard/p

[apisix-dashboard] branch master updated: fix: fix some sleep location in e2e test (#1123)

2020-12-25 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 78b4031 fix: fix some sleep locati

[GitHub] [apisix-dashboard] idbeta opened a new issue #1126: test: add global files to contain selector mappers and public methods

2020-12-25 Thread GitBox
idbeta opened a new issue #1126: URL: https://github.com/apache/apisix-dashboard/issues/1126 # Feature request ## Please describe your feature E2E test: add a global file to contain selector mappers add some public methods, like `create base route`, `create base upstream

[GitHub] [apisix-dashboard] nic-chen commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-25 Thread GitBox
nic-chen commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751220770 @qwxingzhe what versions are your APISIX and Dashboard? This is an automated message from the Apache G

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1125: E2E: Upstream

2020-12-25 Thread GitBox
juzhiyuan opened a new issue #1125: URL: https://github.com/apache/apisix-dashboard/issues/1125 # Feature request TODO - [ ] Create Upstream in Route - [ ] Select Upstream in Route then Input manually related issue - https://github.com/apache/apisix-dashboard/pull

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1124: fix: can not manual input in upstream

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1124: URL: https://github.com/apache/apisix-dashboard/pull/1124#issuecomment-751219802 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1124?src=pr&el=h1) Report > Merging [#1124](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-749346372 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1093?src=pr&el=h1) Report > Merging [#1093](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1124: fix: can not manual input in upstream

2020-12-25 Thread GitBox
codecov-io commented on pull request #1124: URL: https://github.com/apache/apisix-dashboard/pull/1124#issuecomment-751219802 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1124?src=pr&el=h1) Report > Merging [#1124](https://codecov.io/gh/apache/apisix-dashboard/pull/112

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-25 Thread GitBox
nic-chen commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r548843169 ## File path: api/test/e2e/global_rule_test.go ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1123: fix: fix some sleep location in e2e test

2020-12-25 Thread GitBox
codecov-io edited a comment on pull request #1123: URL: https://github.com/apache/apisix-dashboard/pull/1123#issuecomment-751218950 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=h1) Report > Merging [#1123](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1124: fix: can not manual input

2020-12-25 Thread GitBox
LiteSun opened a new pull request #1124: URL: https://github.com/apache/apisix-dashboard/pull/1124 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1118: fix: be consumer e2e test ci failed in pr#999

2020-12-25 Thread GitBox
juzhiyuan merged pull request #1118: URL: https://github.com/apache/apisix-dashboard/pull/1118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated (95ca6e0 -> 02a4702)

2020-12-25 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 95ca6e0 fix: when create a route without ID in request body by Admin API, it can't be displayed in Man

[GitHub] [apisix] nic-chen opened a new pull request #3127: chore: expose more schema via control API

2020-12-25 Thread GitBox
nic-chen opened a new pull request #3127: URL: https://github.com/apache/apisix/pull/3127 ### What this PR does / why we need it: Expose `upstream_hash_header_schema` and `upstream_hash_vars_schema`. We need them to verify `hash_on` of upstream: https://github.com/apach

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1123: fix: fix some sleep location in e2e test

2020-12-25 Thread GitBox
codecov-io commented on pull request #1123: URL: https://github.com/apache/apisix-dashboard/pull/1123#issuecomment-751218950 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1123?src=pr&el=h1) Report > Merging [#1123](https://codecov.io/gh/apache/apisix-dashboard/pull/112

  1   2   >