[GitHub] [apisix-dashboard] moonming commented on a change in pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
moonming commented on a change in pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#discussion_r549251272 ## File path: web/cypress/integration/route/search-route.spec.js ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-749346372 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1093?src=pr&el=h1) Report > Merging [#1093](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
juzhiyuan commented on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-751619401 ping @moonming This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1133: 通过dockerfile无法创建镜像

2020-12-27 Thread GitBox
juzhiyuan commented on issue #1133: URL: https://github.com/apache/apisix-dashboard/issues/1133#issuecomment-751619104 Hello, @LY-GO @zd1990 I see you are using 2.0-rc3, but clone from the master branch, I'm curious that the master branch is going to release v2.0, not 2.0-rc3. @idb

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: improve upstream i18n

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] LY-GO commented on issue #1133: 通过dockerfile无法创建镜像

2020-12-27 Thread GitBox
LY-GO commented on issue #1133: URL: https://github.com/apache/apisix-dashboard/issues/1133#issuecomment-751617973 i also meet same question This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix] dabue opened a new pull request #3143: test:update server-info.t with 'toolkit.json' to print table

2020-12-27 Thread GitBox
dabue opened a new pull request #3143: URL: https://github.com/apache/apisix/pull/3143 ### What this PR does / why we need it: update server-info.t with toolkit.json when write the table value by sort, and remove some unused lines in case 2. #3095 ### Pre-submission checkl

[GitHub] [apisix] pguokun opened a new issue #3142: config_etcd.lua:262: sync_data(): failed to check item data of [/apisix/routes] err:additional properties forbidden

2020-12-27 Thread GitBox
pguokun opened a new issue #3142: URL: https://github.com/apache/apisix/issues/3142 **Issues Description:** After installing apisix v2.1 and apisix-dashboard v2.2, after adding a new routing configuration through apisix-dashboard, the ```apisix/logs/error.log``` file shows that ```c

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1134: The Plan of dashboard shows the gateway’s Plugin interceptors

2020-12-27 Thread GitBox
juzhiyuan commented on issue #1134: URL: https://github.com/apache/apisix-dashboard/issues/1134#issuecomment-751611725 No, we don't have a plan for this feature now, welcome PR to resolve this. This is an automated message f

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] Hcreak commented on issue #1134: The Plan of dashboard shows the gateway’s Plugin interceptors

2020-12-27 Thread GitBox
Hcreak commented on issue #1134: URL: https://github.com/apache/apisix-dashboard/issues/1134#issuecomment-751608202 If there is it will be the best This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] Hcreak commented on issue #1134: The Plan of dashboard shows the gateway’s Plugin interceptors

2020-12-27 Thread GitBox
Hcreak commented on issue #1134: URL: https://github.com/apache/apisix-dashboard/issues/1134#issuecomment-751607952 I want to know if you have any plans for this, and if you put it in Milestones, Thanks. This is an auto

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1134: The Plan of dashboard shows the gateway’s Plugin interceptors

2020-12-27 Thread GitBox
juzhiyuan commented on issue #1134: URL: https://github.com/apache/apisix-dashboard/issues/1134#issuecomment-751603661 You would lead this feature and we will help u if needed. This is an automated message from the Apache G

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1134: The Plan of dashboard shows the gateway’s Plugin interceptors

2020-12-27 Thread GitBox
juzhiyuan commented on issue #1134: URL: https://github.com/apache/apisix-dashboard/issues/1134#issuecomment-751603459 Hi, would you have any proposal for this feature? This is an automated message from the Apache Git Servi

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
juzhiyuan commented on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-751603251 We don't need to update branch every time, only before review done and ready to merge. This is an a

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan closed issue #642: add e2e test for Upstream

2020-12-27 Thread GitBox
juzhiyuan closed issue #642: URL: https://github.com/apache/apisix-dashboard/issues/642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-27 Thread GitBox
juzhiyuan merged pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated (e594fc0 -> b194c61)

2020-12-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e594fc0 test: add frontend e2e test (smoke test for metrics page) (#1104) add b194c61 test: add

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1) Report > Merging [#1066](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] Hcreak opened a new issue #1134: The Plan of dashboard shows the gateway’s Plugin interceptors

2020-12-27 Thread GitBox
Hcreak opened a new issue #1134: URL: https://github.com/apache/apisix-dashboard/issues/1134 # Feature request https://github.com/apache/apisix/blob/master/doc/zh-cn/plugin-interceptors.md I need use `interceptors` functions to protect some plugin interfaces, Do you have a

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1104: test: add frontend e2e test (smoke test for metrics page)

2020-12-27 Thread GitBox
juzhiyuan merged pull request #1104: URL: https://github.com/apache/apisix-dashboard/pull/1104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: test: add frontend e2e test (smoke test for metrics page) (#1104)

2020-12-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e594fc0 test: add frontend e2e tes

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1104: test: add frontend e2e test (smoke test for metrics page)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1104: URL: https://github.com/apache/apisix-dashboard/pull/1104#issuecomment-749930195 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr&el=h1) Report > Merging [#1104](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] idbeta commented on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
idbeta commented on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-751571316 > @idbeta please fix the conflict first fixed. This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-749346372 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1093?src=pr&el=h1) Report > Merging [#1093](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-749346372 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1093?src=pr&el=h1) Report > Merging [#1093](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] zd1990 opened a new issue #1133: 通过dockerfile无法创建镜像

2020-12-27 Thread GitBox
zd1990 opened a new issue #1133: URL: https://github.com/apache/apisix-dashboard/issues/1133 # Bug report ## Describe the bug 通过docker部署的文档无法创建镜像,编译镜像报错 ## How to Reproduce ` git clone https://github.com/apache/apisix-dashboard.git ` ` cd apisix-dash

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3140: test: limit-count add more test cases to cover the case where the upstream is a domain name

2020-12-27 Thread GitBox
Firstsawyou commented on a change in pull request #3140: URL: https://github.com/apache/apisix/pull/3140#discussion_r549205602 ## File path: t/plugin/limit-count.t ## @@ -1175,3 +1175,95 @@ passed [200, 200, 503, 503] --- no_error_log [error] + + + +=== TEST 37: the limit-co

[apisix] branch master updated: ci: pass again (#3141)

2020-12-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 45e909a ci: pass again (#3141) 45e909a is

[GitHub] [apisix] spacewander merged pull request #3141: ci: pass again

2020-12-27 Thread GitBox
spacewander merged pull request #3141: URL: https://github.com/apache/apisix/pull/3141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] qwxingzhe commented on issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-27 Thread GitBox
qwxingzhe commented on issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120#issuecomment-751559477 It took me more than 30 minutes to rebuild,tks. This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] qwxingzhe closed issue #1120: schema- sync.sh generate schema.json Is empty

2020-12-27 Thread GitBox
qwxingzhe closed issue #1120: URL: https://github.com/apache/apisix-dashboard/issues/1120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1) Report > Merging [#1066](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-27 Thread GitBox
juzhiyuan merged pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: test: enhance frontend e2e test stability (consumer) (#1116)

2020-12-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 47e5345 test: enhance frontend e2e

[GitHub] [apisix] HelloBug0 commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2020-12-27 Thread GitBox
HelloBug0 commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-751556350 OK, I will check that. Thanks for your help. This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#issuecomment-750762834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1116?src=pr&el=h1) Report > Merging [#1116](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander opened a new pull request #3141: ci: pass again

2020-12-27 Thread GitBox
spacewander opened a new pull request #3141: URL: https://github.com/apache/apisix/pull/3141 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] spacewander closed pull request #3137: revert: "feat: add script_id field used by dashboard (#3096)"

2020-12-27 Thread GitBox
spacewander closed pull request #3137: URL: https://github.com/apache/apisix/pull/3137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander commented on a change in pull request #3140: test: limit-count add more test cases to cover the case where the upstream is a domain name

2020-12-27 Thread GitBox
spacewander commented on a change in pull request #3140: URL: https://github.com/apache/apisix/pull/3140#discussion_r549192349 ## File path: t/plugin/limit-count.t ## @@ -1175,3 +1175,95 @@ passed [200, 200, 503, 503] --- no_error_log [error] + + + +=== TEST 37: the limit-co

[GitHub] [apisix] Firstsawyou commented on pull request #3139: ctx.var in upstream_uri on proxy-rewrite plugin

2020-12-27 Thread GitBox
Firstsawyou commented on pull request #3139: URL: https://github.com/apache/apisix/pull/3139#issuecomment-751547606 We need test cases to cover this feature. This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] Firstsawyou commented on pull request #3139: ctx.var in upstream_uri on proxy-rewrite plugin

2020-12-27 Thread GitBox
Firstsawyou commented on pull request #3139: URL: https://github.com/apache/apisix/pull/3139#issuecomment-751547564 Need to add semantic "PR" title, for example: `feat: ctx.var in upstream_uri on proxy-rewrite plugin` This i

[GitHub] [apisix] zhuliquan edited a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan edited a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751544555 > The characters with `:` in the `url` here are very similar to the prefix path, right? @spacewander Yes, **/test/v1/files:/test/v1/files:listReputationHistories** and

[GitHub] [apisix] zhuliquan edited a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan edited a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751544555 > The characters with `:` in the `url` here are very similar to the prefix path, right? @spacewander Yes, **/test/v1/files:/test/v1/files:listReputationHistories** and

[GitHub] [apisix] zhuliquan commented on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan commented on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751544555 > The characters with `:` in the `url` here are very similar to the prefix path, right? @spacewander No, **/test/v1/files:/test/v1/files:listReputationHistories** and **/test

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared

2020-12-27 Thread GitBox
codecov-io commented on pull request #1132: URL: https://github.com/apache/apisix-dashboard/pull/1132#issuecomment-751523636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=h1) Report > Merging [#1132](https://codecov.io/gh/apache/apisix-dashboard/pull/113

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared

2020-12-27 Thread GitBox
liuxiran opened a new pull request #1132: URL: https://github.com/apache/apisix-dashboard/pull/1132 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix ___ ### Bugfix - Description [Test case] 1. click `

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: improve upstream i18n

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: improve upstream i18n

2020-12-27 Thread GitBox
liuxiran commented on a change in pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549169518 ## File path: web/src/pages/Upstream/locales/zh-CN.ts ## @@ -15,80 +15,89 @@ * limitations under the License. */ export default { - 'upstr

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: improve upstream i18n

2020-12-27 Thread GitBox
liuxiran commented on a change in pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549168850 ## File path: web/src/components/RightContent/AvatarDropdown.tsx ## @@ -97,25 +98,25 @@ const AvatarDropdown: React.FC = ({ menu }) => {

[GitHub] [apisix] Firstsawyou opened a new pull request #3140: test: limit-count add more test cases to cover the case where the upstream is a domain name

2020-12-27 Thread GitBox
Firstsawyou opened a new pull request #3140: URL: https://github.com/apache/apisix/pull/3140 close #3108 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features hav

[GitHub] [apisix] BFergerson opened a new pull request #3139: ctx.var in upstream_uri on proxy-rewrite plugin

2020-12-27 Thread GitBox
BFergerson opened a new pull request #3139: URL: https://github.com/apache/apisix/pull/3139 ### What this PR does / why we need it: Adds the ability to use `ctx.var` in `upstream_uri` on the proxy-rewrite plugin. Fixes #3133 --

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1086: support EWMA in upstream balancer

2020-12-27 Thread GitBox
juzhiyuan closed issue #1086: URL: https://github.com/apache/apisix-dashboard/issues/1086 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1131: feat: support EWMA

2020-12-27 Thread GitBox
juzhiyuan merged pull request #1131: URL: https://github.com/apache/apisix-dashboard/pull/1131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: feat: support EWMA (#1131)

2020-12-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 14da383 feat: support EWMA (#1131)

[GitHub] [apisix] Firstsawyou commented on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
Firstsawyou commented on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751487805 The characters with `:` in the `url` here are very similar to the prefix path, right? @spacewander This is an au

[GitHub] [apisix] qwxingzhe opened a new pull request #3138: change: add interface to get list part

2020-12-27 Thread GitBox
qwxingzhe opened a new pull request #3138: URL: https://github.com/apache/apisix/pull/3138 ### What this PR does / why we need it: I return the missing part of the interface to get the list, so I add it here ### Pre-submission checklist: * [ ] Did you explain what pr

[GitHub] [apisix-ingress-controller] gxthrj closed issue #125: route value.id lost

2020-12-27 Thread GitBox
gxthrj closed issue #125: URL: https://github.com/apache/apisix-ingress-controller/issues/125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #125: route value.id lost

2020-12-27 Thread GitBox
gxthrj commented on issue #125: URL: https://github.com/apache/apisix-ingress-controller/issues/125#issuecomment-751480148 Close this issue as fixed in https://github.com/apache/apisix-dashboard/pull/1063, feel free to reopen if you find any problem.

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] gxthrj closed issue #96: Refactor: Move `seven` module into apisix-ingress-controller

2020-12-27 Thread GitBox
gxthrj closed issue #96: URL: https://github.com/apache/apisix-ingress-controller/issues/96 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] spacewander opened a new pull request #3137: Revert "feat: add script_id field used by dashboard (#3096)"

2020-12-27 Thread GitBox
spacewander opened a new pull request #3137: URL: https://github.com/apache/apisix/pull/3137 This reverts commit a661b940b0ae2fe45a8a8612e41d7bcda136a0c4. ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem doe

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1057: feat: support global rules for Manager API

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#issuecomment-747873491 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1057?src=pr&el=h1) Report > Merging [#1057](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] idbeta edited a comment on issue #3136: bug: why does host proxy_write not support such as ip+port

2020-12-27 Thread GitBox
idbeta edited a comment on issue #3136: URL: https://github.com/apache/apisix/issues/3136#issuecomment-751473281 Now the `host` cannot contain port, but the document do not explain it, I think is a good feat. @spacewander T

[GitHub] [apisix] idbeta commented on pull request #3061: test: add ci on centos7

2020-12-27 Thread GitBox
idbeta commented on pull request #3061: URL: https://github.com/apache/apisix/pull/3061#issuecomment-751473372 ping @membphis @moonming This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] idbeta commented on issue #3136: bug: why does host proxy_write not support such as ip+port

2020-12-27 Thread GitBox
idbeta commented on issue #3136: URL: https://github.com/apache/apisix/issues/3136#issuecomment-751473281 Now the `host` cannot contain port, but the document do not explain it, I think is a bug. @spacewander This is an aut

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1131: feat: support EWMA

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1131: URL: https://github.com/apache/apisix-dashboard/pull/1131#issuecomment-751430098 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1131?src=pr&el=h1) Report > Merging [#1131](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1131: feat: support EWMA

2020-12-27 Thread GitBox
juzhiyuan commented on pull request #1131: URL: https://github.com/apache/apisix-dashboard/pull/1131#issuecomment-751472755 > missing test case https://github.com/apache/apisix-dashboard/issues/1125 This is an automate

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr&el=h1) Report > Merging [#1066](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] membphis commented on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-27 Thread GitBox
membphis commented on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-751471333 @idbeta please fix the conflict first This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] membphis closed issue #644: add e2e test for Setting

2020-12-27 Thread GitBox
membphis closed issue #644: URL: https://github.com/apache/apisix-dashboard/issues/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] membphis merged pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-27 Thread GitBox
membphis merged pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: test: add frontend e2e test (smoke test for settings page) (#1105)

2020-12-27 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new c341e2e test: add frontend e2e test

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-27 Thread GitBox
membphis commented on a change in pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105#discussion_r549116708 ## File path: web/cypress/integration/settings/settings-smoketest.spec.js ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105#issuecomment-749952748 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1105?src=pr&el=h1) Report > Merging [#1105](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1116: test: enhance frontend e2e test stability (consumer)

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1116: URL: https://github.com/apache/apisix-dashboard/pull/1116#issuecomment-750762834 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1116?src=pr&el=h1) Report > Merging [#1116](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1131: feat: support EWMA

2020-12-27 Thread GitBox
codecov-io edited a comment on pull request #1131: URL: https://github.com/apache/apisix-dashboard/pull/1131#issuecomment-751430098 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1131?src=pr&el=h1) Report > Merging [#1131](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] zhuliquan edited a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan edited a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463366 # GRPC service I use grpc build service protobuf: ```syntax="proto3"; import "google/api/annotations.proto"; package test_grpc.api.file; option go_pac

[GitHub] [apisix] zhuliquan edited a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan edited a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463366 # GRPC service I use grpc build service protobuf: ```syntax="proto3"; import "google/api/annotations.proto"; package test_grpc.api.file; option go_pac

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

2020-12-27 Thread GitBox
juzhiyuan commented on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751464111 most texts are updated, we could merge this one first IMO. This is an automated message from the Apac

[GitHub] [apisix] zhuliquan edited a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan edited a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463366 # GRPC service I use grpc build service protobuf: ```syntax="proto3"; import "google/api/annotations.proto"; package test_grpc.api.file; option go_pac

[GitHub] [apisix] zhuliquan removed a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan removed a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463800 I have post my case in issue #3134发自我的华为手机 原始邮件 发件人: Yuelin Zheng 日期: 2020年12月27日周日 19:53收件人: apache/apisix 抄送: zhuliquan , Author 主题: Re: [apache/apisi

[GitHub] [apisix] zhuliquan edited a comment on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan edited a comment on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463366 # GRPC service I use grpc build service protobuf: ```syntax="proto3"; import "google/api/annotations.proto"; package test_grpc.api.file; option go_pac

[GitHub] [apisix] zhuliquan commented on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan commented on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463800 I have post my case in issue #3134发自我的华为手机 原始邮件 发件人: Yuelin Zheng 日期: 2020年12月27日周日 19:53收件人: apache/apisix 抄送: zhuliquan , Author 主题: Re: [apache/apisix] I hav

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1097: feat: "upstream" i18n

2020-12-27 Thread GitBox
juzhiyuan commented on a change in pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549108676 ## File path: web/src/components/Upstream/UpstreamForm.tsx ## @@ -136,9 +136,9 @@ const UpstreamForm: React.FC = forwardRef( =

[GitHub] [apisix] zhuliquan commented on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
zhuliquan commented on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751463366 # GRPC service I use grpc build service protobuf: ```syntax="proto3"; import "google/api/annotations.proto"; package test_grpc.api.file; option go_package =

[GitHub] [apisix-dashboard] guoqqqi closed pull request #1131: feat: support EWMA

2020-12-27 Thread GitBox
guoqqqi closed pull request #1131: URL: https://github.com/apache/apisix-dashboard/pull/1131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] Firstsawyou commented on issue #3134: I have some trouble on route match

2020-12-27 Thread GitBox
Firstsawyou commented on issue #3134: URL: https://github.com/apache/apisix/issues/3134#issuecomment-751458508 Can you provide a minimal reproducible use case? This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] Firstsawyou edited a comment on issue #3136: bug: why does host proxy_write not support such as ip+port

2020-12-27 Thread GitBox
Firstsawyou edited a comment on issue #3136: URL: https://github.com/apache/apisix/issues/3136#issuecomment-751455645 Are you talking about the `proxy_rewrite` plugin? See if the format of the `host` you set is incorrect, the `host` you set needs to meet the prompt the regex pattern ^[0-9

[GitHub] [apisix] Firstsawyou commented on issue #3136: bug: why does host proxy_write not support such as ip+port

2020-12-27 Thread GitBox
Firstsawyou commented on issue #3136: URL: https://github.com/apache/apisix/issues/3136#issuecomment-751455645 Are you talking about the `proxy_rewrite` plugin? See if the format of the `host` you set is incorrect, the `host` you set needs to meet the prompt regularity. For example: `

[GitHub] [apisix] jeesk opened a new issue #3136: bug: why does host proxy_write not support such as ip+port

2020-12-27 Thread GitBox
jeesk opened a new issue #3136: URL: https://github.com/apache/apisix/issues/3136 ### Issue description when I set host of proxy_wiite, tell me Invalid plugin data does not match the regex pattern ^[0-9a-zA-Z-.]+$. ### Environment * apisix version (cmd: `apisix version

[apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-12-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8441a0a Deploy to GitHub pages

[GitHub] [apisix] spacewander commented on issue #3133: Combining basic-auth & proxy-rewrite

2020-12-27 Thread GitBox
spacewander commented on issue #3133: URL: https://github.com/apache/apisix/issues/3133#issuecomment-751441819 You may need to change proxy-rewrite like what we have done with fault-injection: https://github.com/apache/apisix/blob/53777519b8261994f34dfd67fc07cc1b97ba2946/apisix/plugins/

[GitHub] [apisix] spacewander opened a new pull request #3135: tests: fix unstable test in traffic-split.t

2020-12-27 Thread GitBox
spacewander opened a new pull request #3135: URL: https://github.com/apache/apisix/pull/3135 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new featu