[GitHub] [apisix-dashboard] nic-chen commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
nic-chen commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754472202 Sorry, It's not a problem with the returned data, just about data format. The logic of this is really different, you could have a look the proposal:

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1209: fix(FE): service issues

2021-01-04 Thread GitBox
juzhiyuan merged pull request #1209: URL: https://github.com/apache/apisix-dashboard/pull/1209 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-dashboard] branch v2.3 updated (f57454a -> ba86c83)

2021-01-04 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.3 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from f57454a fix: set create_time/update_time as omitempty (#1203) add ba86c83 fix(FE): service issues

[apisix-dashboard] branch v2.3 updated (cd3bb4f -> f57454a)

2021-01-04 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.3 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from cd3bb4f fix(fe): route search with status (#1205) add f57454a fix: set create_time/update_time as

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1203: fix: Set create_time/update_time as omitempty

2021-01-04 Thread GitBox
juzhiyuan merged pull request #1203: URL: https://github.com/apache/apisix-dashboard/pull/1203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551768201 ## File path: pkg/seven/state/solver.go ## @@ -15,54 +15,96 @@ package state import ( + "context" + "errors" +

[GitHub] [apisix-dashboard] imjoey commented on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
imjoey commented on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754470012 > emmm let me do a cherry-pick from master to v2.3 That would be great since the `master` users could get this hot fix soon. Thanks.

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1205: fix(fe): route search with status

2021-01-04 Thread GitBox
juzhiyuan merged pull request #1205: URL: https://github.com/apache/apisix-dashboard/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-dashboard] branch v2.3 updated (de52887 -> cd3bb4f)

2021-01-04 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v2.3 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from de52887 Merge branch 'master' into v2.3 add cd3bb4f fix(fe): route search with status (#1205) No

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
juzhiyuan commented on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754469546 emmm let me do a cherry-pick from master to v2.3 This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1204: bug(BE): manager-api will panic when accessing with malformed authorization string

2021-01-04 Thread GitBox
juzhiyuan closed issue #1204: URL: https://github.com/apache/apisix-dashboard/issues/1204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
juzhiyuan merged pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-dashboard] branch master updated: fix: well handle with malformed auth token in request header (#1206)

2021-01-04 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new dd7658a fix: well handle with

[GitHub] [apisix] spacewander closed pull request #3191: chore: remove the stale CI

2021-01-04 Thread GitBox
spacewander closed pull request #3191: URL: https://github.com/apache/apisix/pull/3191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander opened a new pull request #3194: update ci doc

2021-01-04 Thread GitBox
spacewander opened a new pull request #3194: URL: https://github.com/apache/apisix/pull/3194 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ]

[GitHub] [apisix-dashboard] imjoey commented on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
imjoey commented on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754468519 > @imjoey to 2.3 or master? @juzhiyuan IMHO, this fix should be applied to both `v2.3` and `master`. Since the `v2.3` branch would be merged into master branch

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
juzhiyuan commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754468487 @imjoey How about using `DEFAULT_GLOBAL_RULE_ID` as that rule's id? This is an automated message from

[GitHub] [apisix-dashboard] nic-chen commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
nic-chen commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754467676 @imjoey can't reproduce on my side.. could you provide more detail, please ? thanks. This is an

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
juzhiyuan commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754467485 https://github.com/apache/apisix-dashboard/blob/master/web/src/constants.ts#L35 This is an automated

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1207: fix(be): search by status on the route list page is invalid

2021-01-04 Thread GitBox
Jaycean commented on a change in pull request #1207: URL: https://github.com/apache/apisix-dashboard/pull/1207#discussion_r551765815 ## File path: api/internal/handler/route/route.go ## @@ -218,7 +220,11 @@ func (h *Handler) List(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
juzhiyuan commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754467270 @imjoey Hello, the frontend will ALWAYS use one fixed id as global_rule id, using `1` currently. This

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
juzhiyuan commented on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754465784 @imjoey to 2.3 or master? This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1207: fix(be): search by status on the route list page is invalid

2021-01-04 Thread GitBox
starsz commented on a change in pull request #1207: URL: https://github.com/apache/apisix-dashboard/pull/1207#discussion_r551761963 ## File path: api/internal/handler/route/route.go ## @@ -218,7 +220,11 @@ func (h *Handler) List(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1209: Fix(FE): service

2021-01-04 Thread GitBox
LiteSun opened a new pull request #1209: URL: https://github.com/apache/apisix-dashboard/pull/1209 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [apisix-dashboard] imjoey commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
imjoey commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754461210 Sorry not provide the reproduce steps: - Create two plugins on the `Plugin List` page - Use `curl http://manager-api:9000/apisix/admin/global_rules` to fetch the

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551760445 ## File path: charts/ingress-apisix/templates/tests/test-connection.yaml ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software

[GitHub] [apisix-dashboard] nic-chen commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
nic-chen commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754458882 I know the difference between the two data. what are the steps to reproduce? This is an automated

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
starsz commented on a change in pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#discussion_r551758004 ## File path: api/internal/filter/authentication.go ## @@ -41,8 +42,8 @@ func Authentication() gin.HandlerFunc {

[GitHub] [apisix-dashboard] imjoey commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
imjoey commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754456906 @nic-chen there are two plugins in : `cors` and `echo`. The following screenshot could be illustrated on that.

[GitHub] [apisix-dashboard] nic-chen commented on issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
nic-chen commented on issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208#issuecomment-754453705 don't quite understand, where is the second data returned? This is an automated message from the

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
imjoey commented on a change in pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#discussion_r551755233 ## File path: api/internal/filter/authentication.go ## @@ -41,8 +42,8 @@ func Authentication() gin.HandlerFunc {

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
imjoey commented on a change in pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#discussion_r551755233 ## File path: api/internal/filter/authentication.go ## @@ -41,8 +42,8 @@ func Authentication() gin.HandlerFunc {

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551753004 ## File path: pkg/seven/state/solver.go ## @@ -15,54 +15,96 @@ package state import ( + "context" + "errors" +

[GitHub] [apisix-dashboard] imjoey opened a new issue #1208: bug(global_rule): check if the returned global_rule list data is as expected

2021-01-04 Thread GitBox
imjoey opened a new issue #1208: URL: https://github.com/apache/apisix-dashboard/issues/1208 # Bug report ## Describe the bug I enabled two plugins in global scope ( also known as `global_rule` ). The json data in response from endpoint

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551752350 ## File path: pkg/seven/state/builder.go ## @@ -84,161 +86,198 @@ func paddingUpstream(upstream *v1.Upstream, currentUpstream

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551752081 ## File path: pkg/seven/state/service_worker.go ## @@ -64,114 +67,93 @@ func (w *serviceWorker) trigger(event Event, rwg

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551751900 ## File path: pkg/seven/apisix/route.go ## @@ -49,7 +49,7 @@ func FindCurrentRoute(route *v1.Route) (*v1.Route, error) {

[apisix-dashboard] branch v2.3 updated (eb87c95 -> de52887)

2021-01-04 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch v2.3 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from eb87c95 feat(cli): Show GitHash for manager-api in branch v2.3 (backport #1162) (#1181) add

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551750041 ## File path: pkg/seven/state/builder.go ## @@ -84,161 +86,198 @@ func paddingUpstream(upstream *v1.Upstream, currentUpstream

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551749012 ## File path: charts/ingress-apisix/values.yaml ## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
tokers commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551748731 ## File path: test/e2e/scaffold/scaffold.go ## @@ -208,3 +210,7 @@ func waitExponentialBackoff(condFunc func() (bool, error)) error {

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551748586 ## File path: test/e2e/scaffold/httpbin.go ## @@ -84,7 +86,8 @@ spec: ) func (s *Scaffold) newHTTPBIN() (*corev1.Service, error) { -

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551747804 ## File path: docs/install.md ## @@ -54,7 +54,19 @@ kubectl apply -k /path/to/apisix-ingress-controller/samples/deploy ## Helm -//

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
tokers commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551747610 ## File path: charts/ingress-apisix/templates/deployment.yaml ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551747507 ## File path: test/e2e/scaffold/scaffold.go ## @@ -208,3 +210,7 @@ func waitExponentialBackoff(condFunc func() (bool, error)) error {

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #153: chore: support to deploy ingress-apisix through helm charts

2021-01-04 Thread GitBox
gxthrj commented on a change in pull request #153: URL: https://github.com/apache/apisix-ingress-controller/pull/153#discussion_r551738522 ## File path: charts/ingress-apisix/templates/deployment.yaml ## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] idbeta commented on pull request #3061: test: add ci on centos7

2021-01-04 Thread GitBox
idbeta commented on pull request #3061: URL: https://github.com/apache/apisix/pull/3061#issuecomment-754428028 ping @moonming This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] idbeta commented on a change in pull request #3061: test: add ci on centos7

2021-01-04 Thread GitBox
idbeta commented on a change in pull request #3061: URL: https://github.com/apache/apisix/pull/3061#discussion_r551738534 ## File path: .github/workflows/centos7-ci.yml ## @@ -0,0 +1,87 @@ +name: CI Centos7 + +on: + push: +branches: + - master + pull_request: +

[GitHub] [apisix] azura27 opened a new issue #3193: bug: 10 second URL test comes with 1 second api_ctx nil value error

2021-01-04 Thread GitBox
azura27 opened a new issue #3193: URL: https://github.com/apache/apisix/issues/3193 ### Issue description When I test with WRK, 10 seconds flow would have one second error, and cause the QPS to decrease 1w For issue tracing: in function: common_phase(phase_name) ADD log:

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
imjoey commented on a change in pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#discussion_r551733304 ## File path: api/internal/filter/authentication.go ## @@ -41,8 +42,8 @@ func Authentication() gin.HandlerFunc {

[GitHub] [apisix-dashboard] imjoey commented on issue #1168: feat: adding Icons for plugins

2021-01-04 Thread GitBox
imjoey commented on issue #1168: URL: https://github.com/apache/apisix-dashboard/issues/1168#issuecomment-754418133 @juzhiyuan will keep an eye on this. Please let @liuxiran and me know if there is anything we can do. Thanks.

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
starsz commented on a change in pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#discussion_r551731839 ## File path: api/internal/filter/authentication.go ## @@ -41,8 +42,8 @@ func Authentication() gin.HandlerFunc {

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1168: feat: adding Icons for plugins

2021-01-04 Thread GitBox
juzhiyuan commented on issue #1168: URL: https://github.com/apache/apisix-dashboard/issues/1168#issuecomment-754416260 Not sure, I will handle this issue those days :) This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] imjoey commented on issue #1168: feat: adding Icons for plugins

2021-01-04 Thread GitBox
imjoey commented on issue #1168: URL: https://github.com/apache/apisix-dashboard/issues/1168#issuecomment-754415897 Hi @juzhiyuan , may I ask that what kinds of icons will be added for each plugin? Is there a plan or a design? Looking forward to your reply. Thanks.

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
codecov-io edited a comment on pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#issuecomment-753841174 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/151?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551729574 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551729448 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551729401 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #149: fix: catch route failure and trigger retry

2021-01-04 Thread GitBox
tokers commented on a change in pull request #149: URL: https://github.com/apache/apisix-ingress-controller/pull/149#discussion_r551695917 ## File path: pkg/seven/state/builder.go ## @@ -84,161 +86,198 @@ func paddingUpstream(upstream *v1.Upstream, currentUpstream

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
tokers commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551726850 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your routing

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551709972 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1207: fix: search by status on the route list page is invalid

2021-01-04 Thread GitBox
Jaycean opened a new pull request #1207: URL: https://github.com/apache/apisix-dashboard/pull/1207 Signed-off-by: Jacean Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ]

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
codecov-io edited a comment on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754373831 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1206?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1195: test: backend e2e test for create consumer with jwt

2021-01-04 Thread GitBox
codecov-io edited a comment on pull request #1195: URL: https://github.com/apache/apisix-dashboard/pull/1195#issuecomment-753807570 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1195?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1195: test: backend e2e test for create consumer with jwt

2021-01-04 Thread GitBox
idbeta commented on a change in pull request #1195: URL: https://github.com/apache/apisix-dashboard/pull/1195#discussion_r551710004 ## File path: api/test/e2e/consumer_test.go ## @@ -536,3 +536,70 @@ func TestConsumer_with_createtime_updatetime(t *testing.T) {

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551709972 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix] membphis closed issue #2583: doc: English version of FAQ

2021-01-04 Thread GitBox
membphis closed issue #2583: URL: https://github.com/apache/apisix/issues/2583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis merged pull request #2605: docs: sync English version

2021-01-04 Thread GitBox
membphis merged pull request #2605: URL: https://github.com/apache/apisix/pull/2605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: docs: sync English version (#2605)

2021-01-04 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new ad4a222 docs: sync English version (#2605)

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551708362 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551708104 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
codecov-io edited a comment on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754373831 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1206?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
codecov-io edited a comment on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754373831 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1206?src=pr=h1) Report > Merging

[GitHub] [apisix] membphis commented on issue #3190: chore: when etcd is not started, need to print a more friendly warning message

2021-01-04 Thread GitBox
membphis commented on issue #3190: URL: https://github.com/apache/apisix/issues/3190#issuecomment-754375536 nice, thx This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
codecov-io edited a comment on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754373831 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1206?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
codecov-io commented on pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206#issuecomment-754373831 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1206?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] imjoey opened a new pull request #1206: fix: well handle with malformed auth token in request header

2021-01-04 Thread GitBox
imjoey opened a new pull request #1206: URL: https://github.com/apache/apisix-dashboard/pull/1206 Signed-off-by: imjoey Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ]

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1205: fix(fe): route search with status

2021-01-04 Thread GitBox
codecov-io commented on pull request #1205: URL: https://github.com/apache/apisix-dashboard/pull/1205#issuecomment-754373070 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1205?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1205: fix(fe): route search with status

2021-01-04 Thread GitBox
liuxiran opened a new pull request #1205: URL: https://github.com/apache/apisix-dashboard/pull/1205 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - Related issues Fe of #1189 ___ ### Bugfix - How

[GitHub] [apisix-ingress-controller] Firstsawyou commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
Firstsawyou commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551700359 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your

[GitHub] [apisix] idbeta commented on pull request #2605: docs: sync English version

2021-01-04 Thread GitBox
idbeta commented on pull request #2605: URL: https://github.com/apache/apisix/pull/2605#issuecomment-754369401 > @idbeta > Need to solve conflict. fixed. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] nic-chen commented on issue #1204: bug(BE): manager-api will panic when accessing with malformed authorization string

2021-01-04 Thread GitBox
nic-chen commented on issue #1204: URL: https://github.com/apache/apisix-dashboard/issues/1204#issuecomment-754369318 sure, thanks. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] Jaycean commented on issue #1189: bug: search by status on the route list page is invalid

2021-01-04 Thread GitBox
Jaycean commented on issue #1189: URL: https://github.com/apache/apisix-dashboard/issues/1189#issuecomment-754368999 @liuxiran Please Assigne to me. Thks. This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] spacewander opened a new pull request #3192: test: make admin/plugins-reload.t stable

2021-01-04 Thread GitBox
spacewander opened a new pull request #3192: URL: https://github.com/apache/apisix/pull/3192 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix-dashboard] imjoey commented on issue #1204: bug(BE): manager-api will panic when accessing with malformed authorization string

2021-01-04 Thread GitBox
imjoey commented on issue #1204: URL: https://github.com/apache/apisix-dashboard/issues/1204#issuecomment-754368299 @nic-chen I can tackle this. Pls assign to me if possible. Thanks. This is an automated message from the

[GitHub] [apisix-dashboard] nic-chen commented on issue #1204: bug(BE): manager-api will panic when accessing with malformed authorization string

2021-01-04 Thread GitBox
nic-chen commented on issue #1204: URL: https://github.com/apache/apisix-dashboard/issues/1204#issuecomment-754367626 Thanks for reporting. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] spacewander commented on pull request #3191: chore: remove the stale CI

2021-01-04 Thread GitBox
spacewander commented on pull request #3191: URL: https://github.com/apache/apisix/pull/3191#issuecomment-754367267 Should be merged after https://github.com/apache/apisix/pull/3172 This is an automated message from the

[GitHub] [apisix] spacewander opened a new pull request #3191: chore: remove the stale CI

2021-01-04 Thread GitBox
spacewander opened a new pull request #3191: URL: https://github.com/apache/apisix/pull/3191 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix] spacewander commented on pull request #2605: docs: sync English version

2021-01-04 Thread GitBox
spacewander commented on pull request #2605: URL: https://github.com/apache/apisix/pull/2605#issuecomment-754364953 @idbeta Need to solve conflict. This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] spacewander commented on issue #3190: chore: when etcd is not started, need to print a more friendly warning message

2021-01-04 Thread GitBox
spacewander commented on issue #3190: URL: https://github.com/apache/apisix/issues/3190#issuecomment-754364610 Duplicate of #2718 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] spacewander closed issue #3190: chore: when etcd is not started, need to print a more friendly warning message

2021-01-04 Thread GitBox
spacewander closed issue #3190: URL: https://github.com/apache/apisix/issues/3190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis opened a new issue #3190: chore: when etcd is not started, need to print a more friendly warning message

2021-01-04 Thread GitBox
membphis opened a new issue #3190: URL: https://github.com/apache/apisix/issues/3190 `got malformed version message: "" from etcd` is not easy to understand. ```shell $ make init ./bin/apisix init ./bin/apisix init_etcd got malformed version message: "" from etcd make:

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #151: docs: API specification for CRDs

2021-01-04 Thread GitBox
tokers commented on a change in pull request #151: URL: https://github.com/apache/apisix-ingress-controller/pull/151#discussion_r551689567 ## File path: docs/CRD-specification.md ## @@ -0,0 +1,196 @@ + + +# CRD specification + +Use the following CRDs to define your routing

[GitHub] [apisix-docker] xzzh999 commented on issue #113: Bad argument #1 to 'ipairs' (table expected, got nil)

2021-01-04 Thread GitBox
xzzh999 commented on issue #113: URL: https://github.com/apache/apisix-docker/issues/113#issuecomment-754362514 this fixed by copy conf folder for the container This is an automated message from the Apache Git Service. To

[GitHub] [apisix-docker] xzzh999 closed issue #113: Bad argument #1 to 'ipairs' (table expected, got nil)

2021-01-04 Thread GitBox
xzzh999 closed issue #113: URL: https://github.com/apache/apisix-docker/issues/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] imjoey opened a new issue #1204: bug(BE): manager-api will panic when accessing with malformed authorization string

2021-01-04 Thread GitBox
imjoey opened a new issue #1204: URL: https://github.com/apache/apisix-dashboard/issues/1204 # Bug report ## Describe the bug The manager-api backend will panic if the authorization string in request header is malformed. ## How to Reproduce 1. Run `make api-run`

[GitHub] [apisix] gewei2000 commented on issue #3174: request help: prometheus not support filter by route

2021-01-04 Thread GitBox
gewei2000 commented on issue #3174: URL: https://github.com/apache/apisix/issues/3174#issuecomment-754359775 @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to

[apisix] branch v2.2 updated (d03a09b -> e8dcf37)

2021-01-04 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch v2.2 in repository https://gitbox.apache.org/repos/asf/apisix.git. discard d03a09b style discard 474b4cf ignore release package discard 8507d5f silent tar: .: file changed as we read

[GitHub] [apisix] idbeta commented on pull request #3185: feat: add consumer plugin validation at DP side

2021-01-04 Thread GitBox
idbeta commented on pull request #3185: URL: https://github.com/apache/apisix/pull/3185#issuecomment-754357773 @spacewander this PR has fixed https://github.com/apache/apisix-dashboard/issues/1190 This is an automated

[GitHub] [apisix] spacewander closed issue #3186: Cannot parse DNS IPv6 address

2021-01-04 Thread GitBox
spacewander closed issue #3186: URL: https://github.com/apache/apisix/issues/3186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   3   >