LiteSun commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-759275183
IMO, Remove plug-in functionality needs to be added
Interface interaction issues need to be discussed
- When will the delete button be displayed?
- Should the
membphis merged pull request #3256:
URL: https://github.com/apache/apisix/pull/3256
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from d68016e docs: enrich stand alone mode's doc (#3264)
add 57e3209 docs: fix table of contents Markdown link
membphis commented on a change in pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#discussion_r556324270
##
File path: t/plugin/batch-requests.t
##
@@ -988,7 +988,7 @@ passed
GET /t
--- error_code: 400
--- response_body eval
-qr/\{"error_msg":"invalid
membphis commented on pull request #3253:
URL: https://github.com/apache/apisix/pull/3253#issuecomment-759273039
I rerun the CI
This is an automated message from the Apache Git Service.
To respond to the message, please log
LiteSun commented on a change in pull request #1276:
URL: https://github.com/apache/apisix-dashboard/pull/1276#discussion_r556322421
##
File path: web/src/components/Plugin/data.tsx
##
@@ -26,3 +26,8 @@ export const PLUGIN_ICON_LIST: Record = {
'openid-connect': ,
codecov-io edited a comment on pull request #1276:
URL: https://github.com/apache/apisix-dashboard/pull/1276#issuecomment-758597221
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1276?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1276:
URL: https://github.com/apache/apisix-dashboard/pull/1276#issuecomment-758597221
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1276?src=pr=h1)
Report
> Merging
membphis commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-759269462
@juzhiyuan Do you have any advice?
This is an automated message from the Apache Git Service.
To respond
membphis commented on issue #3207:
URL: https://github.com/apache/apisix/issues/3207#issuecomment-759269071
> When calling the `make run` or `apisix start` command in the `/root`
directory, we can see this prompt message:
I want to know why the lack of permissions cannot be detected
Firstsawyou commented on issue #3207:
URL: https://github.com/apache/apisix/issues/3207#issuecomment-759266879
> @Firstsawyou do you know why we can capture this error in CLI? Is there
any way we can capture this error when the user calls `apisix start` or `make
run`?
When calling
LiteSun merged pull request #1285:
URL: https://github.com/apache/apisix-dashboard/pull/1285
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new b42553f fix: Delete excess content.
belongwqz commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-759264425
> > Route is higher than Service IMO, even if it's disabled.
>
> you are right.
>
> @belongwqz for your case, you need to delete the plugin in route first.
imjoey commented on issue #1154:
URL:
https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-759259060
> > Shall we also return the ultimate data when using PUT method? FYI, the
answer is yes for APISIX, need to make manager-api the same as Admin API?
>
> the Admin API
membphis commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-759257189
> Route is higher than Service IMO, even if it's disabled.
you are right.
@belongwqz for your case, you need to delete the plugin in route first.
juzhiyuan edited a comment on issue #1227:
URL:
https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759256925
`apisix/admin/plugins?all=true`
juzhiyuan commented on issue #1227:
URL:
https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759256925
`apisix/admin/plugins?all=true`
membphis commented on issue #578:
URL:
https://github.com/apache/apisix-dashboard/issues/578#issuecomment-759256458
@bingoku we need a proposal first, need to confirm with the community about
how to support this feature step by step.
Welcome to submit your proposal. and welcome to
membphis commented on issue #3207:
URL: https://github.com/apache/apisix/issues/3207#issuecomment-759255351
@Firstsawyou do you know why we can capture this error in CLI? Is there any
way we can capture this error when the user calls `apisix start` or `make run`?
membphis commented on issue #1154:
URL:
https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-759254816
> Shall we also return the ultimate data when using PUT method? FYI, the
answer is yes for APISIX, need to make manager-api the same as Admin API?
the Admin API and
Firstsawyou commented on issue #3267:
URL: https://github.com/apache/apisix/issues/3267#issuecomment-759253207
It is recommended to use the latest version, this problem may have been
fixed in the latest version.
This is an
Firstsawyou commented on a change in pull request #3263:
URL: https://github.com/apache/apisix/pull/3263#discussion_r556301713
##
File path: apisix/plugins/authz-keycloak.lua
##
@@ -17,15 +17,18 @@
local core = require("apisix.core")
local http = require
liuxiran commented on a change in pull request #1284:
URL: https://github.com/apache/apisix-dashboard/pull/1284#discussion_r556279018
##
File path: web/src/pages/Setting/Setting.tsx
##
@@ -62,7 +62,15 @@ const Setting: React.FC = () => {
});
setTimeout(() =>
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 82a9198 docs: Update
juzhiyuan merged pull request #1244:
URL: https://github.com/apache/apisix-dashboard/pull/1244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
belongwqz commented on issue #2550:
URL: https://github.com/apache/apisix/issues/2550#issuecomment-759249500
How to setup apisix to get the same effect in nginx as:
```
location /static_sub_path/ {
alias /local_static_file_path/;
}
```
duanzhaoqian opened a new issue #3267:
URL: https://github.com/apache/apisix/issues/3267
### Issue description
运行一段时间出现，不确定原因
### Environment
* apisix version
spacewander commented on issue #1227:
URL:
https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759248727
@juzhiyuan
It is expected that the property is injected into each plugin. Which plugins
have that property and which don't?
tokers commented on a change in pull request #19:
URL: https://github.com/apache/apisix-helm-chart/pull/19#discussion_r556298891
##
File path: chart/apisix/templates/configmap.yaml
##
@@ -82,7 +82,9 @@ data:
- 0.0.0.0/0
{{- end}}
# - "::/64"
- #
lilien1010 commented on a change in pull request #19:
URL: https://github.com/apache/apisix-helm-chart/pull/19#discussion_r556298189
##
File path: chart/apisix/templates/configmap.yaml
##
@@ -82,7 +82,9 @@ data:
- 0.0.0.0/0
{{- end}}
# - "::/64"
-
spacewander merged pull request #3264:
URL: https://github.com/apache/apisix/pull/3264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #1597:
URL: https://github.com/apache/apisix/issues/1597
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander closed issue #2635:
URL: https://github.com/apache/apisix/issues/2635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new d68016e docs: enrich stand alone mode's
totemofwolf commented on a change in pull request #19:
URL: https://github.com/apache/apisix-helm-chart/pull/19#discussion_r556293901
##
File path: chart/apisix/templates/configmap.yaml
##
@@ -82,7 +82,9 @@ data:
- 0.0.0.0/0
{{- end}}
# - "::/64"
-
juzhiyuan commented on pull request #1285:
URL: https://github.com/apache/apisix-dashboard/pull/1285#issuecomment-759241477
ping @nic-chen
https://github.com/apache/apisix-dashboard/pull/1285/checks?check_run_id=1692874435
juzhiyuan commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-759240603
Route is higher than Service IMO, even if it's disabled.
@membphis, what's your opinion?
This is
tokers opened a new pull request #19:
URL: https://github.com/apache/apisix-helm-chart/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nic-chen commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-759228835
I think this is normal. The only problem is that the FE needs to provide the
feature of deleting a plugin.
@LiteSun @juzhiyuan
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r556280298
##
File path: api/internal/handler/route_export/route_export.go
##
@@ -0,0 +1,298 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
liuxiran commented on a change in pull request #1284:
URL: https://github.com/apache/apisix-dashboard/pull/1284#discussion_r556279018
##
File path: web/src/pages/Setting/Setting.tsx
##
@@ -62,7 +62,15 @@ const Setting: React.FC = () => {
});
setTimeout(() =>
liuxiran commented on a change in pull request #1284:
URL: https://github.com/apache/apisix-dashboard/pull/1284#discussion_r556279018
##
File path: web/src/pages/Setting/Setting.tsx
##
@@ -62,7 +62,15 @@ const Setting: React.FC = () => {
});
setTimeout(() =>
Firstsawyou commented on issue #3266:
URL: https://github.com/apache/apisix/issues/3266#issuecomment-759223056
We will check it.
This is an automated message from the Apache Git Service.
To respond to the message, please log
roneywei commented on issue #3260:
URL: https://github.com/apache/apisix/issues/3260#issuecomment-75933
IdP ：Support Auth0, okta, etc
We are use cas !
Hope apisix support cas ！
This is an automated
Firstsawyou commented on pull request #3264:
URL: https://github.com/apache/apisix/pull/3264#issuecomment-759214506
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 3fcb580 test: backend e2e test
nic-chen merged pull request #1195:
URL: https://github.com/apache/apisix-dashboard/pull/1195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
codecov-io commented on pull request #1285:
URL: https://github.com/apache/apisix-dashboard/pull/1285#issuecomment-759208186
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1285?src=pr=h1)
Report
> Merging
guoqqqi opened a new pull request #1285:
URL: https://github.com/apache/apisix-dashboard/pull/1285
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
codecov-io commented on pull request #1284:
URL: https://github.com/apache/apisix-dashboard/pull/1284#issuecomment-759199156
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1284?src=pr=h1)
Report
> Merging
ThanoshanMV opened a new pull request #1284:
URL: https://github.com/apache/apisix-dashboard/pull/1284
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
Yangzcy423911 commented on issue #3266:
URL: https://github.com/apache/apisix/issues/3266#issuecomment-759198107
etcd detail
etcdctl version
etcdctl version: 3.4.14
API version: 3.4
This is an automated message
juzhiyuan commented on a change in pull request #3264:
URL: https://github.com/apache/apisix/pull/3264#discussion_r556255715
##
File path: doc/stand-alone.md
##
@@ -228,3 +228,70 @@ ssl:
- "yourdomain.com"
#END
```
+
+ How to config global rule
+
+```yaml
juzhiyuan commented on issue #1227:
URL:
https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759197485
Because I see that a part of plugins have that property, and others don't
have :( little curious
This
nic-chen commented on issue #1227:
URL:
https://github.com/apache/apisix-dashboard/issues/1227#issuecomment-759197171
Add the disable attribute to the schema of all plugins? Or should the
manager api do this hack? What is your opinion? Thanks. @juzhiyuan
What do you think is
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759197160
not sure, I need some time to work on it.
This is an automated message from the Apache Git Service.
spacewander commented on a change in pull request #3264:
URL: https://github.com/apache/apisix/pull/3264#discussion_r556254832
##
File path: doc/stand-alone.md
##
@@ -228,3 +228,70 @@ ssl:
- "yourdomain.com"
#END
```
+
+ How to config global rule
+
+```yaml
liuxiran commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759197008
> What happened to the lint...
does the default config of lint changed together with the dependences?
juzhiyuan commented on issue #578:
URL:
https://github.com/apache/apisix-dashboard/issues/578#issuecomment-759196875
All right, it seems that this feature cannot implement using a good way :(
cc @membphis please have a final confirm
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759196482
https://github.com/apache/apisix-dashboard/pull/1283/checks?check_run_id=1692687432
This is an
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759196428
What happened to the lint...
This is an automated message from the Apache Git Service.
To respond to
imjoey commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759196407
/lgtm
This is an automated message from the Apache Git Service.
To respond to the message, please
juzhiyuan commented on a change in pull request #3264:
URL: https://github.com/apache/apisix/pull/3264#discussion_r556252413
##
File path: doc/stand-alone.md
##
@@ -228,3 +228,70 @@ ssl:
- "yourdomain.com"
#END
```
+
+ How to config global rule
Review
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from c3b1ea0 chore: fix punctuation problem (#1280)
add 2261de1 chore: lint Markdown and remove
nic-chen merged pull request #1274:
URL: https://github.com/apache/apisix-dashboard/pull/1274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
spacewander commented on issue #3266:
URL: https://github.com/apache/apisix/issues/3266#issuecomment-759193930
Look like etcd returns an unexpected response to APISIX?
Need a network capture file to confirm it.
BTW, what's your etcd version?
juzhiyuan commented on pull request #1244:
URL: https://github.com/apache/apisix-dashboard/pull/1244#issuecomment-759192489
ping
This is an automated message from the Apache Git Service.
To respond to the message, please log
nic-chen merged pull request #1280:
URL: https://github.com/apache/apisix-dashboard/pull/1280
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from ecfef5b docs: add readme for install Apache APISIX Dashboard with RPM
package (#1273)
add
codecov-io commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759192384
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr=h1)
Report
> Merging
juzhiyuan commented on a change in pull request #1276:
URL: https://github.com/apache/apisix-dashboard/pull/1276#discussion_r556250603
##
File path: web/src/components/Plugin/data.tsx
##
@@ -26,3 +26,8 @@ export const PLUGIN_ICON_LIST: Record = {
'openid-connect': ,
nic-chen commented on issue #1275:
URL:
https://github.com/apache/apisix-dashboard/issues/1275#issuecomment-759191192
> > > > oh, please have a look at test cases for plugin orchestration:
> > > >
juzhiyuan opened a new pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
spacewander closed issue #3265:
URL: https://github.com/apache/apisix/issues/3265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on issue #3265:
URL: https://github.com/apache/apisix/issues/3265#issuecomment-759189826
@belongwqz
We can't do it as Nginx doesn't support listening new port on the fly.
This is an automated
LiteSun commented on a change in pull request #1276:
URL: https://github.com/apache/apisix-dashboard/pull/1276#discussion_r556247681
##
File path: web/src/components/Plugin/data.tsx
##
@@ -26,3 +26,8 @@ export const PLUGIN_ICON_LIST: Record = {
'openid-connect': ,
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch fix-mirror
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at 51e6d52 fix: omit taobao mirror
This branch includes the following new commits:
new 51e6d52
imjoey commented on issue #1275:
URL:
https://github.com/apache/apisix-dashboard/issues/1275#issuecomment-759185875
> > > oh, please have a look at test cases for plugin orchestration:
> > >
codecov-io commented on pull request #1282:
URL: https://github.com/apache/apisix-dashboard/pull/1282#issuecomment-759184804
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1282?src=pr=h1)
Report
> Merging
nic-chen commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-759184568
> > > before we import new route data, do we need to clean the old route
first?
> >
> >
> > I think that the original data should not be modified, and the
Firstsawyou commented on issue #3265:
URL: https://github.com/apache/apisix/issues/3265#issuecomment-759184458
The settings of stream route can be dynamically configured through etcd. The
configuration file is to enable and configure the stream port.
Yangzcy423911 opened a new issue #3266:
URL: https://github.com/apache/apisix/issues/3266
### Issue description
### Environment
* apisix version (cmd: `apisix version`): 2.2
* OS: (cmd: `uname -a`)
* OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`)
starsz opened a new pull request #1282:
URL: https://github.com/apache/apisix-dashboard/pull/1282
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
membphis commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-759181507
> how about giving the choice to users? e.g: Add a param to deside whether
to cover the old routes or return a error, which tells users that they already
have the
Firstsawyou commented on a change in pull request #3220:
URL: https://github.com/apache/apisix/pull/3220#discussion_r556240672
##
File path: apisix/cli/ops.lua
##
@@ -375,6 +375,10 @@ end
local function start(env, ...)
+if env.is_root_path then
+
belongwqz commented on issue #578:
URL:
https://github.com/apache/apisix-dashboard/issues/578#issuecomment-759180579
> I see this parameter is set in the configuration file[1], we don't support
it dynamically from Dashboard :( Would you have any proposal for this feature?
>
> [1]
belongwqz opened a new issue #3265:
URL: https://github.com/apache/apisix/issues/3265
### Issue description
根据
starsz opened a new issue #1281:
URL: https://github.com/apache/apisix-dashboard/issues/1281
# Bug report
## Describe the bug
Hi, I found that the called check in those unit test is inaccurate.
consumer_test.go
global_rule_test.go
server_info_test.go
See:
spacewander commented on issue #3260:
URL: https://github.com/apache/apisix/issues/3260#issuecomment-759179019
I am not familiar of cas. It seems it supports:
JWT: https://apereo.github.io/cas/6.3.x/installation/JWT-Authentication.html
OpenID-Connect:
spacewander opened a new pull request #3264:
URL: https://github.com/apache/apisix/pull/3264
Fix #1597
Fix #2635
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does
nic-chen commented on a change in pull request #1270:
URL: https://github.com/apache/apisix-dashboard/pull/1270#discussion_r556236129
##
File path: .github/workflows/backend-e2e-test.yml
##
@@ -52,3 +52,8 @@ jobs:
- name: run test for plugin skywalking
codecov-io commented on pull request #1280:
URL: https://github.com/apache/apisix-dashboard/pull/1280#issuecomment-759173665
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1280?src=pr=h1)
Report
> Merging
starsz opened a new pull request #1280:
URL: https://github.com/apache/apisix-dashboard/pull/1280
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
juzhiyuan commented on pull request #1276:
URL: https://github.com/apache/apisix-dashboard/pull/1276#issuecomment-759170673
ping
This is an automated message from the Apache Git Service.
To respond to the message, please log
idbeta commented on a change in pull request #1195:
URL: https://github.com/apache/apisix-dashboard/pull/1195#discussion_r556226052
##
File path: api/test/e2e/route_with_plugin_jwt_test.go
##
@@ -173,4 +174,115 @@ func TestRoute_With_Auth_Plugin(t *testing.T) {
juzhiyuan commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-759167247
The Dashboard maintains a dataset[1] to ensure the plugin editor could
validate as expected 藍
[1]
Firstsawyou commented on a change in pull request #3220:
URL: https://github.com/apache/apisix/pull/3220#discussion_r556227795
##
File path: apisix/cli/ops.lua
##
@@ -375,6 +375,10 @@ end
local function start(env, ...)
+if env.is_root_path then
+
Firstsawyou commented on a change in pull request #3220:
URL: https://github.com/apache/apisix/pull/3220#discussion_r556226898
##
File path: apisix/cli/ops.lua
##
@@ -375,6 +375,10 @@ end
local function start(env, ...)
+if env.is_root_path then
+
idbeta commented on a change in pull request #1195:
URL: https://github.com/apache/apisix-dashboard/pull/1195#discussion_r556226052
##
File path: api/test/e2e/route_with_plugin_jwt_test.go
##
@@ -173,4 +174,115 @@ func TestRoute_With_Auth_Plugin(t *testing.T) {
1 - 100 of 220 matches
Mail list logo
