[GitHub] [apisix-website] juzhiyuan opened a new pull request #140: feat: added deploy CD

2021-01-14 Thread GitBox
juzhiyuan opened a new pull request #140: URL: https://github.com/apache/apisix-website/pull/140 Changes: added deploy CD This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] hnlq715 opened a new issue #3303: feat: use tool to format lua code automatically

2021-01-14 Thread GitBox
hnlq715 opened a new issue #3303: URL: https://github.com/apache/apisix/issues/3303 As title This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-website] branch juzhiyuan-patch-1 created (now 177879a)

2021-01-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 177879a Update deploy.yml This branch includes the following new commits: new 177879a

[apisix-website] 01/01: Update deploy.yml

2021-01-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit 177879ad2b543984820be379278b2af087fd68b9 Author: 琚致远 AuthorDate: Fri Jan 15 15:59:05 2021 +0800

[GitHub] [apisix] Firstsawyou commented on issue #3301: request help: I user apisix proxy a request which using for upload big file (5MB around) , the request raise Error:socket hang up

2021-01-14 Thread GitBox
Firstsawyou commented on issue #3301: URL: https://github.com/apache/apisix/issues/3301#issuecomment-760718034 It may be that the file size of the proxy is limited. @spacewander Please help to look at this problem when you have time.

[GitHub] [apisix] idbeta commented on issue #3302: doc/zh-cn/how-to-build.md

2021-01-14 Thread GitBox
idbeta commented on issue #3302: URL: https://github.com/apache/apisix/issues/3302#issuecomment-760716918 Welcome to pr @admin-xl-2048 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] admin-xl-2048 commented on issue #3302: doc/zh-cn/how-to-build.md

2021-01-14 Thread GitBox
admin-xl-2048 commented on issue #3302: URL: https://github.com/apache/apisix/issues/3302#issuecomment-760715462 There is a small error under this file: CD apache-apisix-2.2 should be changed to CD apisix-2.2 This is an

[GitHub] [apisix] admin-xl-2048 opened a new issue #3302: doc/zh-cn/how-to-build.md

2021-01-14 Thread GitBox
admin-xl-2048 opened a new issue #3302: URL: https://github.com/apache/apisix/issues/3302 # Improve Docs ## Please describe which part of docs should be improved or typo fixed A clear and concise description of what you want and what your use case is. ## Describe the

[GitHub] [apisix-dashboard] admin-xl-2048 commented on issue #1305: make build2.3版本的时候cypress和node-pty无法下载;显示二进制文件过大。Expected downloaded file to have size: 203515894 Computed size: 9120117

2021-01-14 Thread GitBox
admin-xl-2048 commented on issue #1305: URL: https://github.com/apache/apisix-dashboard/issues/1305#issuecomment-760711148 非常感谢,按照这个方法我已经解决掉了。 --原始邮件-- 发件人:

[GitHub] [apisix] hnlq715 commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-14 Thread GitBox
hnlq715 commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r557947934 ## File path: apisix/balancer/ewma.lua ## @@ -25,80 +28,102 @@ local lrucache_trans_format = core.lrucache.new({ ttl = 300, count = 256 }) -

[GitHub] [apisix] hnlq715 commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-14 Thread GitBox
hnlq715 commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r557947468 ## File path: apisix/balancer/ewma.lua ## @@ -25,80 +28,102 @@ local lrucache_trans_format = core.lrucache.new({ ttl = 300, count = 256 }) -

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1306: fix: Switch Language doesn't work.

2021-01-14 Thread GitBox
guoqqqi opened a new pull request #1306: URL: https://github.com/apache/apisix-dashboard/pull/1306 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] membphis commented on a change in pull request #3300: feat: ewma use p2c to improve performance

2021-01-14 Thread GitBox
membphis commented on a change in pull request #3300: URL: https://github.com/apache/apisix/pull/3300#discussion_r557934625 ## File path: apisix/balancer/ewma.lua ## @@ -25,80 +28,102 @@ local lrucache_trans_format = core.lrucache.new({ ttl = 300, count = 256 }) -

[GitHub] [apisix] spacewander commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-14 Thread GitBox
spacewander commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-760703943 By saying `switch to LuaJIT only`, I mean two things: 1. install Luarocks from source, and avoid installing Lua 2. change the `#!` in `bin/apisix` to use luajit.

[GitHub] [apisix] pengtaochang opened a new issue #3301: request help: I user apisix proxy a request which using for upload big file (5MB around) , the request raise Error:socket hang up

2021-01-14 Thread GitBox
pengtaochang opened a new issue #3301: URL: https://github.com/apache/apisix/issues/3301 ### Issue description I user apisix proxy a request which using for upload big file (5MB around) , the request raise Error:socket hang up. I had test my api server, upload and download api

[GitHub] [apisix] membphis commented on pull request #3300: feat: ewma use p2c to improve performance

2021-01-14 Thread GitBox
membphis commented on pull request #3300: URL: https://github.com/apache/apisix/pull/3300#issuecomment-760701953 nice PR @hnlq715 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1305: make build2.3版本的时候cypress和node-pty无法下载;显示二进制文件过大。Expected downloaded file to have size: 203515894 Computed size: 9120117

2021-01-14 Thread GitBox
juzhiyuan commented on issue #1305: URL: https://github.com/apache/apisix-dashboard/issues/1305#issuecomment-760701021 Hi, this issue is fixed in the master branch. You could simply do this patch[1] for your codes. [1]

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1305: make build2.3版本的时候cypress和node-pty无法下载;显示二进制文件过大。Expected downloaded file to have size: 203515894 Computed size: 9120117

2021-01-14 Thread GitBox
juzhiyuan closed issue #1305: URL: https://github.com/apache/apisix-dashboard/issues/1305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] hnlq715 opened a new pull request #3300: feat: ewma use p2c to improve performance

2021-01-14 Thread GitBox
hnlq715 opened a new pull request #3300: URL: https://github.com/apache/apisix/pull/3300 ### What this PR does / why we need it: Details can be found in #3211 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features

[GitHub] [apisix] membphis commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-14 Thread GitBox
membphis commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-760697698 @fukiki what is your OS name and version? what is the Luarocks version? what is the Lua version? we need those information.

[GitHub] [apisix] membphis commented on a change in pull request #3282: docs: 'how-to-build' add a troubleshooting of luasocket

2021-01-14 Thread GitBox
membphis commented on a change in pull request #3282: URL: https://github.com/apache/apisix/pull/3282#discussion_r557922669 ## File path: doc/how-to-build.md ## @@ -109,6 +109,49 @@ Makefile rules: Environment variable can be used to configure APISIX. Please take a look at

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557915888 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557900139 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix] spacewander commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-14 Thread GitBox
spacewander commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-760691640 @fukiki @liuxiran The documentation need to be updated. I think we should mention that only LuaJIT is supported. Unless you know Lua well, it is not obvious to find the

[GitHub] [apisix-dashboard] nic-chen merged pull request #1301: chore: sync the latest JSON Schema

2021-01-14 Thread GitBox
nic-chen merged pull request #1301: URL: https://github.com/apache/apisix-dashboard/pull/1301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-dashboard] branch master updated (b9a0227 -> 84af5f1)

2021-01-14 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from b9a0227 fix: Support string type for the script field in Route (#1289) add 84af5f1 chore: sync

[GitHub] [apisix-dashboard] nic-chen closed issue #1227: The API for fetching all plugins should return `disable` property

2021-01-14 Thread GitBox
nic-chen closed issue #1227: URL: https://github.com/apache/apisix-dashboard/issues/1227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] spacewander merged pull request #3287: refactor: the parent of upstream should point to its original src

2021-01-14 Thread GitBox
spacewander merged pull request #3287: URL: https://github.com/apache/apisix/pull/3287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: refactor: the parent of upstream should point to its original src (#3287)

2021-01-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new bbbdf58 refactor: the parent of upstream

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1304: feat(FE): test for plugin page

2021-01-14 Thread GitBox
codecov-io commented on pull request #1304: URL: https://github.com/apache/apisix-dashboard/pull/1304#issuecomment-760687643 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1304?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] idbeta commented on issue #1288: chore: reduce the size of the compiled binary file of manager-api

2021-01-14 Thread GitBox
idbeta commented on issue #1288: URL: https://github.com/apache/apisix-dashboard/issues/1288#issuecomment-760686696 > @idbeta What about preparing some stuffs like debuginfo.rpm when compiling it. sorry, I don't quite understand what you mean. I don't think `reduce` is necessary

[GitHub] [apisix-dashboard] admin-xl-2048 opened a new issue #1305: make build2.3版本的时候cypress和node-pty无法下载;显示二进制文件过大。Expected downloaded file to have size: 203515894 Computed size: 9120117

2021-01-14 Thread GitBox
admin-xl-2048 opened a new issue #1305: URL: https://github.com/apache/apisix-dashboard/issues/1305 # Feature request ## Please describe your feature A clear and concise description of what you want and what your use case is. ## Describe the solution you'd like A

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557900139 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix-dashboard] idbeta opened a new pull request #1304: feat(FE): test for plugin page

2021-01-14 Thread GitBox
idbeta opened a new pull request #1304: URL: https://github.com/apache/apisix-dashboard/pull/1304 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] E2E - [ ] New feature provided - [ ] Improve performance - [ ] Backport

[GitHub] [apisix-dashboard] liuxiran commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-01-14 Thread GitBox
liuxiran commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-760680814 > @liuxiran Thanks for your advice. I think we should add a doc after those issues were solved: > > 1. remove the etcd dependency in the unit test #1161 > 2. use

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-14 Thread GitBox
tokers commented on a change in pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#discussion_r557885773 ## File path: api/internal/handler/data_loader/import.go ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix] liuxiran edited a comment on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-14 Thread GitBox
liuxiran edited a comment on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-760675043 Once I came to the same issue, and thanks to @spacewander, he told me that I have to use `Lua5.1` instead, and then I tried to find Lua5.1 for fedora32(which is the os of my

[GitHub] [apisix] liuxiran commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-14 Thread GitBox
liuxiran commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-760675043 Once I came to the same issue, and thanks to @spacewander, he told me that I have to use `Lua5.1` instead, and then I tried to find Lua5.1 for fedora32, unfortunately there was not

[GitHub] [apisix-dashboard] tokers commented on issue #1288: chore: reduce the size of the compiled binary file of manager-api

2021-01-14 Thread GitBox
tokers commented on issue #1288: URL: https://github.com/apache/apisix-dashboard/issues/1288#issuecomment-760663667 > > > I'm not sure whether this is an good idea since for now i don't think the manager api is stable enough, once it crashes, debug info is important to dump the stack,

[GitHub] [apisix-dashboard] starsz commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-01-14 Thread GitBox
starsz commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-760662897 @liuxiran Thanks for your advice. I think we should add a doc after those issues were solved: 1. remove the etcd dependency in the unit test #1161 2. use ginko

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
tokers commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557875463 ## File path: api/internal/filter/authentication.go ## @@ -17,62 +17,79 @@ package filter import ( + "errors" "net/http"

[GitHub] [apisix-dashboard] starsz closed issue #1281: The called check in unit test is inaccurate

2021-01-14 Thread GitBox
starsz closed issue #1281: URL: https://github.com/apache/apisix-dashboard/issues/1281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] tokers commented on issue #3211: Feature: implement p2c balancer with random, ewma, leastloaded

2021-01-14 Thread GitBox
tokers commented on issue #3211: URL: https://github.com/apache/apisix/issues/3211#issuecomment-760660477 > -- | -- OK, My Nginx version is old :) This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: WIP: user can skip upstream when select service_id

2021-01-14 Thread GitBox
codecov-io edited a comment on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1298: fix: Login page bottom white background.

2021-01-14 Thread GitBox
liuxiran commented on a change in pull request #1298: URL: https://github.com/apache/apisix-dashboard/pull/1298#discussion_r557873105 ## File path: web/src/global.less ## @@ -21,6 +21,7 @@ body, #root { height: 100%; word-break: break-word; + background-color: #f0f2f5;

[GitHub] [apisix-dashboard] nic-chen removed a comment on pull request #1301: chore: sync the latest JSON Schema

2021-01-14 Thread GitBox
nic-chen removed a comment on pull request #1301: URL: https://github.com/apache/apisix-dashboard/pull/1301#issuecomment-760588574 @juzhiyuan @LiteSun ci failed: https://github.com/apache/apisix-dashboard/pull/1301/checks?check_run_id=1705633221 It seems that the schema cannot

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
codecov-io edited a comment on pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#issuecomment-760587036 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1296?src=pr=h1) Report > Merging

[GitHub] [apisix] fukiki commented on issue #3281: Document how-to-build.md should add a troubleshooting of luasocket

2021-01-14 Thread GitBox
fukiki commented on issue #3281: URL: https://github.com/apache/apisix/issues/3281#issuecomment-760646065 @spacewander I understand the reason of the mistake and the solution, thanks for your explain. I still wish that the document could add relevant content, to avoid subsequent

[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1278: bug(fe): route created with service can not use the service upstream

2021-01-14 Thread GitBox
liuxiran edited a comment on issue #1278: URL: https://github.com/apache/apisix-dashboard/issues/1278#issuecomment-760083931 > Once we auto fill upstream info from service, a new upstream object would be bound to that route unexpectedly IMO you mean we should omit the `upstream` in

[GitHub] [apisix-ingress-controller] moonming commented on pull request #177: doc: add doc about run on aws eks

2021-01-14 Thread GitBox
moonming commented on pull request #177: URL: https://github.com/apache/apisix-ingress-controller/pull/177#issuecomment-760643686 great, we can post to apisix.apache.org too This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1289: fix: Support string type for the script field in Route

2021-01-14 Thread GitBox
juzhiyuan merged pull request #1289: URL: https://github.com/apache/apisix-dashboard/pull/1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1275: bug: the script field in Route is limited to map, instead of string

2021-01-14 Thread GitBox
juzhiyuan closed issue #1275: URL: https://github.com/apache/apisix-dashboard/issues/1275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-dashboard] branch master updated: fix: Support string type for the script field in Route (#1289)

2021-01-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new b9a0227 fix: Support string type

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-01-14 Thread GitBox
juzhiyuan commented on issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303#issuecomment-760642013 cc @nic-chen @starsz This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] imjoey commented on pull request #1289: fix: Support string type for the script field in Route

2021-01-14 Thread GitBox
imjoey commented on pull request #1289: URL: https://github.com/apache/apisix-dashboard/pull/1289#issuecomment-760641858 > But e2e test failed. @nic-chen @gxthrj CI passed, PTAL. Thanks. This is an automated message

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1301: chore: sync the latest JSON Schema

2021-01-14 Thread GitBox
codecov-io edited a comment on pull request #1301: URL: https://github.com/apache/apisix-dashboard/pull/1301#issuecomment-760282606 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1301?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-14 Thread GitBox
juzhiyuan commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-760640883 failed with English. ```sh curl 'http://139.217.190.60/apisix/admin/routes' \ -H 'Content-Type: application/json;charset=UTF-8' \ --data-binary

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1302: WIP: user can skip upstream when select service_id

2021-01-14 Thread GitBox
codecov-io commented on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557853660 ## File path: api/cmd/managerapi.go ## @@ -19,6 +19,7 @@ package cmd import ( "context" "fmt" +

[GitHub] [apisix-ingress-controller] tokers commented on pull request #177: doc: add doc about run on aws eks

2021-01-14 Thread GitBox
tokers commented on pull request #177: URL: https://github.com/apache/apisix-ingress-controller/pull/177#issuecomment-760635408 @membphis @moonming @gxthrj Please take a look when you have time. This is an automated message

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #177: doc: add doc about run on aws eks

2021-01-14 Thread GitBox
tokers opened a new pull request #177: URL: https://github.com/apache/apisix-ingress-controller/pull/177 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557852288 ## File path: api/go.mod ## @@ -21,6 +21,7 @@ require ( github.com/gin-contrib/sessions v0.0.3 github.com/gin-contrib/static

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
starsz commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557852183 ## File path: api/cmd/managerapi.go ## @@ -62,7 +63,7 @@ func NewManagerAPICommand() *cobra.Command { var newMws

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
nic-chen commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557847807 ## File path: api/cmd/managerapi.go ## @@ -62,7 +63,7 @@ func NewManagerAPICommand() *cobra.Command { var

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
nic-chen commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557846111 ## File path: api/go.mod ## @@ -21,6 +21,7 @@ require ( github.com/gin-contrib/sessions v0.0.3 github.com/gin-contrib/static

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
nic-chen commented on a change in pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#discussion_r557845884 ## File path: api/cmd/managerapi.go ## @@ -19,6 +19,7 @@ package cmd import ( "context" "fmt" +

[GitHub] [apisix-dashboard] liuxiran opened a new issue #1303: Doc: a better doc about how to write and run e2e test and unit test for Backend

2021-01-14 Thread GitBox
liuxiran opened a new issue #1303: URL: https://github.com/apache/apisix-dashboard/issues/1303 # Feature request ## Please describe your feature Recently when my partners and I tried to finish the the issues of backend, we always found troubles in writting unit test cases and

[GitHub] [apisix] nic-chen merged pull request #3299: chore: remove injected field of plugin schema from properties

2021-01-14 Thread GitBox
nic-chen merged pull request #3299: URL: https://github.com/apache/apisix/pull/3299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: chore: remove injected field of plugin schema from properties (#3299)

2021-01-14 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 5bdfb8f chore: remove injected field of

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-14 Thread GitBox
Jaycean commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-760622249 > > > > before we import new route data, do we need to clean the old route first? > > > > > > > > > I think that the original data should not be modified,

[GitHub] [apisix] spacewander closed issue #1749: feature: need to record which matches the current request.

2021-01-14 Thread GitBox
spacewander closed issue #1749: URL: https://github.com/apache/apisix/issues/1749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #1749: feature: need to record which matches the current request.

2021-01-14 Thread GitBox
spacewander commented on issue #1749: URL: https://github.com/apache/apisix/issues/1749#issuecomment-760620879 Consider solved This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander closed issue #3261: request help: support chash key splicing

2021-01-14 Thread GitBox
spacewander closed issue #3261: URL: https://github.com/apache/apisix/issues/3261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander opened a new pull request #3298: ci: lint test file

2021-01-14 Thread GitBox
spacewander opened a new pull request #3298: URL: https://github.com/apache/apisix/pull/3298 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix-dashboard] idbeta commented on issue #1288: chore: reduce the size of the compiled binary file of manager-api

2021-01-14 Thread GitBox
idbeta commented on issue #1288: URL: https://github.com/apache/apisix-dashboard/issues/1288#issuecomment-760605744 > > I'm not sure whether this is an good idea since for now i don't think the manager api is stable enough, once it crashes, debug info is important to dump the stack,

[GitHub] [apisix-dashboard] membphis commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-14 Thread GitBox
membphis commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-760613921 > Chinese as the key is a normal requirement IMHO, what's your opinion? > * If Chinese is supported, it should be better to also support all other non English languages

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-14 Thread GitBox
juzhiyuan commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-760612472 thanks for your point! @gxthrj please take a look at this issue, too. This is an automated message from

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1302: WIP: user can skip upstream when select service_id

2021-01-14 Thread GitBox
LiteSun commented on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760603783 > just to make sure that this pr could also solves #1278 , if so I will move to other issues, thanks ^-^ > > cc @LiteSun @juzhiyuan According to the

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1054: fix: ssl config support set labels

2021-01-14 Thread GitBox
codecov-io commented on pull request #1054: URL: https://github.com/apache/apisix-dashboard/pull/1054#issuecomment-760612299 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1054?src=pr=h1) Report > Merging

[GitHub] [apisix] membphis merged pull request #3278: feat: support hash on vars_combinations

2021-01-14 Thread GitBox
membphis merged pull request #3278: URL: https://github.com/apache/apisix/pull/3278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated (45f7dd6 -> d1d6533)

2021-01-14 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 45f7dd6 feat: benchmark support specify upstream count (#3292) add d1d6533 feat: support hash on

[GitHub] [apisix] nic-chen opened a new pull request #3299: chore: remove injected field of plugin schema from properties

2021-01-14 Thread GitBox
nic-chen opened a new pull request #3299: URL: https://github.com/apache/apisix/pull/3299 ### What this PR does / why we need it: Injected `$comment` into properties will cause the schema to fail to load, so need to move it. ### Pre-submission checklist: * [x] Did

[GitHub] [apisix] membphis merged pull request #3292: feat: benchmark support specify upstream count

2021-01-14 Thread GitBox
membphis merged pull request #3292: URL: https://github.com/apache/apisix/pull/3292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feat: benchmark support specify upstream count (#3292)

2021-01-14 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 45f7dd6 feat: benchmark support specify

[GitHub] [apisix-dashboard] imjoey commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-14 Thread GitBox
imjoey commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-760595948 Yep, I slightly changed my mind and we should confirm the following two things fine, then we can add support. - If Chinese is supported, it should be better to also

[GitHub] [apisix] spacewander commented on issue #3225: request help: apisix connected use tls with etcd

2021-01-14 Thread GitBox
spacewander commented on issue #3225: URL: https://github.com/apache/apisix/issues/3225#issuecomment-760591745 The `lua-resty-etcd` already supports disabling tls verify: https://github.com/apache/apisix/blob/5482a4bf72b33eabb83fd4bf396a222366c589f3/conf/config-default.yaml#L192-L193

[GitHub] [apisix] spacewander closed issue #3225: request help: apisix connected use tls with etcd

2021-01-14 Thread GitBox
spacewander closed issue #3225: URL: https://github.com/apache/apisix/issues/3225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] hnlq715 edited a comment on issue #3211: Feature: implement p2c balancer with random, ewma, leastloaded

2021-01-14 Thread GitBox
hnlq715 edited a comment on issue #3211: URL: https://github.com/apache/apisix/issues/3211#issuecomment-760586816 @tokers Nginx features are merged into open source version smoothly :-) http://nginx.org/en/docs/http/ngx_http_upstream_module.html#zone ``` Syntax: | zone name 

[GitHub] [apisix-dashboard] starsz commented on issue #1288: chore: reduce the size of the compiled binary file of manager-api

2021-01-14 Thread GitBox
starsz commented on issue #1288: URL: https://github.com/apache/apisix-dashboard/issues/1288#issuecomment-760588681 > I'm not sure whether this is an good idea since for now i don't think the manager api is stable enough, once it crashes, debug info is important to dump the stack,

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1301: chore: sync the latest JSON Schema

2021-01-14 Thread GitBox
nic-chen commented on pull request #1301: URL: https://github.com/apache/apisix-dashboard/pull/1301#issuecomment-760588574 @juzhiyuan @LiteSun ci failed: https://github.com/apache/apisix-dashboard/pull/1301/checks?check_run_id=1705633221 It seems that the schema cannot be

[GitHub] [apisix] spacewander commented on issue #3283: Support disable ssl verify for etcd connection

2021-01-14 Thread GitBox
spacewander commented on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-760587745 Sorry, it is my mistake... This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] pengtaochang commented on issue #3294: request help: I need to get the upstream setting in current router rule when develop a new plugin.

2021-01-14 Thread GitBox
pengtaochang commented on issue #3294: URL: https://github.com/apache/apisix/issues/3294#issuecomment-760587010 Thank you very much, you solved my problem perfectly. This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1296: chore: move the authentication middleware into droplet framework

2021-01-14 Thread GitBox
codecov-io commented on pull request #1296: URL: https://github.com/apache/apisix-dashboard/pull/1296#issuecomment-760587036 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1296?src=pr=h1) Report > Merging

[GitHub] [apisix] hnlq715 commented on issue #3211: Feature: implement p2c balancer with random, ewma, leastloaded

2021-01-14 Thread GitBox
hnlq715 commented on issue #3211: URL: https://github.com/apache/apisix/issues/3211#issuecomment-760586816 @tokers Nginx features are merged into open source version smoothly :-) http://nginx.org/en/docs/http/ngx_http_upstream_module.html#zone ``` Syntax: | state file;

[GitHub] [apisix-dashboard] starsz commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-14 Thread GitBox
starsz commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-760582566 I think we should support Chinese labels. This will be more convenient for some companies. In another way, we only need to update the validate schema, then we can

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-14 Thread GitBox
Jaycean commented on a change in pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r557803573 ## File path: api/internal/handler/route_export/route_export.go ## @@ -0,0 +1,432 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] tokers commented on issue #3283: Support disable ssl verify for etcd connection

2021-01-14 Thread GitBox
tokers commented on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-760581240 > But we don't pass the option to it. You mean APISIX or others? https://github.com/apache/apisix/blob/master/apisix/core/config_etcd.lua#L502

[GitHub] [apisix] tokers commented on issue #3211: Feature: implement p2c balancer with random, ewma, leastloaded

2021-01-14 Thread GitBox
tokers commented on issue #3211: URL: https://github.com/apache/apisix/issues/3211#issuecomment-760580542 > @ElvinEfendi Very insightful, thanks > > @moonming @membphis > Reviewing [nginx's random

[GitHub] [apisix] hnlq715 edited a comment on issue #3211: Feature: implement p2c balancer with random, ewma, leastloaded

2021-01-14 Thread GitBox
hnlq715 edited a comment on issue #3211: URL: https://github.com/apache/apisix/issues/3211#issuecomment-760578226 @ElvinEfendi Very insightful, thanks @moonming @membphis Reviewing [nginx's random

[GitHub] [apisix] spacewander commented on issue #3283: Support disable ssl verify for etcd connection

2021-01-14 Thread GitBox
spacewander commented on issue #3283: URL: https://github.com/apache/apisix/issues/3283#issuecomment-760578300 @starsz It would be great. We can do it in a separate PR. This is an automated message from the Apache Git

  1   2   3   >