liodo198592 opened a new issue #186:
URL: https://github.com/apache/apisix-ingress-controller/issues/186
### Issue description
The Ginkgo tool is used in the e2e test script, but the pre-installation
check is not performed in the makefile Installation check.
![image](https://user
gxthrj commented on issue #186:
URL:
https://github.com/apache/apisix-ingress-controller/issues/186#issuecomment-763416538
Thanks @liodo198592 , There needs to be a check on the ginkgo command.
This is an automated message f
spacewander opened a new pull request #3356:
URL: https://github.com/apache/apisix/pull/3356
Those test may mislead people.
Also add a check to prevent skipping test by accident.
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submi
gxthrj commented on issue #186:
URL:
https://github.com/apache/apisix-ingress-controller/issues/186#issuecomment-763416954
Is anyone interested in helping fix this issue?
This is an automated message from the Apache Git Serv
membphis opened a new issue #3357:
URL: https://github.com/apache/apisix/issues/3357
here is a case:
```shell
$ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/hello",
"hosts": ["A.COM"],
nanamikon commented on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763427804
The patch method can use subpaths refer to
and I
nanamikon edited a comment on issue #3351:
URL: https://github.com/apache/apisix/issues/3351#issuecomment-763427804
The patch method can use subpaths refer to
wy92 opened a new issue #3358:
URL: https://github.com/apache/apisix/issues/3358
https://github.com/apache/apisix/blob/319c3ebefd22cd2949b84d97d196fd2a80630d38/apisix/plugins/prometheus/exporter.lua#L105
This is an automated
dw-3 opened a new issue #3359:
URL: https://github.com/apache/apisix/issues/3359
curl http://127.0.0.1:80/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/index.html",
"plugins": {
"traffic-split": {
"ru
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
from e11f7e0 docs: add flowcharts of the logic during synchronization
(#184)
add 0615aea doc:
membphis merged pull request #185:
URL: https://github.com/apache/apisix-ingress-controller/pull/185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
cao19881125 commented on issue #186:
URL:
https://github.com/apache/apisix-ingress-controller/issues/186#issuecomment-763430817
let me have a try
This is an automated message from the Apache Git Service.
To respond to the me
moonming commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763430987
@dw-3
Please use English in the public channel, thx
This is an automated message from the Apache Git Service.
To
moonming commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763431190
and format your json for human read
This is an automated message from the Apache Git Service.
To respond to the messa
moonming commented on issue #3349:
URL: https://github.com/apache/apisix/issues/3349#issuecomment-763431499
Please use English in the public channel, thx
This is an automated message from the Apache Git Service.
To respond to
moonming closed issue #3349:
URL: https://github.com/apache/apisix/issues/3349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
tokers opened a new pull request #187:
URL: https://github.com/apache/apisix-ingress-controller/pull/187
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] B
tokers commented on pull request #187:
URL:
https://github.com/apache/apisix-ingress-controller/pull/187#issuecomment-763433273
@gxthrj @moonming @membphis
This is an automated message from the Apache Git Service.
To respon
guoqqqi commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560767507
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -89,8 +89,8 @@ context('Create and Search Route', () => {
cy.contains
codecov-io edited a comment on pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#issuecomment-762760524
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1334?src=pr&el=h1)
Report
> Merging
[#1334](https://codecov.io/gh/apache/apisix-dashboard/p
codecov-io commented on pull request #187:
URL:
https://github.com/apache/apisix-ingress-controller/pull/187#issuecomment-763434495
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/187?src=pr&el=h1)
Report
> Merging
[#187](https://codecov.io/gh/apache/apisix-ing
dw-3 commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763435752
> and format your json for human read
I entered json, and it changed in github
This is an automated message from t
idbeta commented on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-763436044
You should add instructions in the document.
This is an automated message from the Apache Git Service.
T
dw-3 commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763436202
> > and format your json for human read
>
> I entered json, and it changed in github
{
"update_time":1611131384,
"upstream":{
"type":"roundrobin",
tokers commented on a change in pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#discussion_r560774798
##
File path: pkg/apisix/apisix.go
##
@@ -73,39 +81,28 @@ type Upstream interface {
// Service is the specific client interface to take o
codecov-io edited a comment on pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#issuecomment-762760524
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1334?src=pr&el=h1)
Report
> Merging
[#1334](https://codecov.io/gh/apache/apisix-dashboard/p
codecov-io edited a comment on pull request #176:
URL:
https://github.com/apache/apisix-ingress-controller/pull/176#issuecomment-762555613
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/176?src=pr&el=h1)
Report
> Merging
[#176](https://codecov.io/gh/apache/api
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new cc15856 chore: caching (#176
tokers merged pull request #176:
URL: https://github.com/apache/apisix-ingress-controller/pull/176
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Firstsawyou commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763441337
Hi, @dw-3
You need to set the vars part like this:
```json
{
"uri": "/index.html",
"plugins": {
"traffic-split": {
"rules": [
{
"match": [
{
codecov-io edited a comment on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-762690400
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1326?src=pr&el=h1)
Report
> Merging
[#1326](https://codecov.io/gh/apache/apisix-dashboard/p
dw-3 commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763446751
> Hi, @dw-3
>
> You need to set the vars part like this:
>
> ```json
> {
> "uri": "/index.html",
> "plugins": {
> "traffic-split": {
> "rules": [
> {
> "
codecov-io edited a comment on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-762690400
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1326?src=pr&el=h1)
Report
> Merging
[#1326](https://codecov.io/gh/apache/apisix-dashboard/p
codecov-io edited a comment on pull request #187:
URL:
https://github.com/apache/apisix-ingress-controller/pull/187#issuecomment-763434495
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/187?src=pr&el=h1)
Report
> Merging
[#187](https://codecov.io/gh/apache/api
tokers commented on pull request #183:
URL:
https://github.com/apache/apisix-ingress-controller/pull/183#issuecomment-763448784
> How do users find this article?
>
> We should reference it in REAME.md.
All docs about deployment are linked by the [How to
Install](https://githu
guoqqqi commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560791838
##
File path: web/cypress/integration/lang/switch-language.spec.js
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
idbeta opened a new issue #3360:
URL: https://github.com/apache/apisix/issues/3360
### Issue description
```
# Failed test 'TEST 7: access external endpoint - pattern "Batch
Processor[http logger] successfully processed the entries" should match a line
in error.log (req 0)'
spacewander commented on issue #3288:
URL: https://github.com/apache/apisix/issues/3288#issuecomment-763454537
Consider solved
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander closed issue #3288:
URL: https://github.com/apache/apisix/issues/3288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander commented on issue #:
URL: https://github.com/apache/apisix/issues/#issuecomment-763455418
Consider solved
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander closed issue #:
URL: https://github.com/apache/apisix/issues/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Firstsawyou commented on issue #3359:
URL: https://github.com/apache/apisix/issues/3359#issuecomment-763455877
> > Hi, @dw-3
> > You need to set the vars part like this:
> > ```json
> > {
> > "uri": "/index.html",
> > "plugins": {
> > "traffic-split": {
> > "rules": [
spacewander commented on issue #3342:
URL: https://github.com/apache/apisix/issues/3342#issuecomment-763456416
@membphis
Maybe we can ignore the failed DNS response?
This is an automated message from the Apache Git Servic
idbeta opened a new issue #3361:
URL: https://github.com/apache/apisix/issues/3361
### Issue description
Now the release package has only `amd64` version, without `arm64` version,
it is impossible to test APISIX related functions in arm64 environment.
--
idbeta closed issue #3361:
URL: https://github.com/apache/apisix/issues/3361
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
guoqqqi commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560805845
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -89,8 +89,8 @@ context('Create and Search Route', () => {
cy.contains
yongboy opened a new issue #3362:
URL: https://github.com/apache/apisix/issues/3362
Sometimes, we may not need some keys below existing in ETCD, or maybe
deleted by some OPS.
| Key | Value|
|-|--|
| /apisix/services | nit_dir |
| /apisix/node_status | init_di
juzhiyuan commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560806321
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -89,8 +89,8 @@ context('Create and Search Route', () => {
cy.contai
juzhiyuan commented on a change in pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#discussion_r560807289
##
File path: web/cypress/integration/route/search-route.spec.js
##
@@ -89,8 +89,8 @@ context('Create and Search Route', () => {
cy.contai
juzhiyuan commented on a change in pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r560808184
##
File path: web/cypress/integration/route/online-debug.spec.js
##
@@ -54,6 +54,9 @@ context('Online debug', () => {
cy.get(domSelecto
juzhiyuan merged pull request #150:
URL: https://github.com/apache/apisix-website/pull/150
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new c8312a8 Add new majunjie into commit
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 149b926 feat: add @starsz to team me
juzhiyuan merged pull request #151:
URL: https://github.com/apache/apisix-website/pull/151
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
membphis commented on issue #3316:
URL: https://github.com/apache/apisix/issues/3316#issuecomment-763467204
you can make a try, if need any help, pls let us know, we'll help you
@18210212423
This is an automated message fro
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 705921f deploy: 149b9263d7db54d
fukiki commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-763470991
> can we put this file `bin/apisix.lua` to `apisix/cli`?
`apisix.lua` is a part of cli, put it into `apisix/cli` will be better.
Thanks.
I will modify it.
Firstsawyou opened a new pull request #3363:
URL: https://github.com/apache/apisix/pull/3363
### What this PR does / why we need it:
We can add new features to the fault-injection plugin for the following
reasons:
Currently, the `fault-injection` plugin does not support cu
juzhiyuan commented on issue #1337:
URL:
https://github.com/apache/apisix-dashboard/issues/1337#issuecomment-763479667
This is not an easy job, but I will draft documentation about this after
v2.4 release.
This is an automa
tokers opened a new pull request #188:
URL: https://github.com/apache/apisix-ingress-controller/pull/188
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] B
membphis commented on issue #3336:
URL: https://github.com/apache/apisix/issues/3336#issuecomment-763482842
> `"scheme": "http", ` or `"scheme": "https", `
For users, it is easier to understand. Some users may not know what TLS is,
so I think `https` is more common.
-
membphis commented on issue #1065:
URL:
https://github.com/apache/apisix-dashboard/issues/1065#issuecomment-763485293
ping @nic-chen
This is an automated message from the Apache Git Service.
To respond to the message, pleas
membphis commented on pull request #1315:
URL: https://github.com/apache/apisix-dashboard/pull/1315#issuecomment-763485474
ping @starsz
This is an automated message from the Apache Git Service.
To respond to the message, ple
tokers commented on issue #58:
URL:
https://github.com/apache/apisix-ingress-controller/issues/58#issuecomment-763485673
No plan to support it yet.
This is an automated message from the Apache Git Service.
To respond to the
tokers closed issue #58:
URL: https://github.com/apache/apisix-ingress-controller/issues/58
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
tokers merged pull request #188:
URL: https://github.com/apache/apisix-ingress-controller/pull/188
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
KishaniKandasamy commented on pull request #148:
URL: https://github.com/apache/apisix-website/pull/148#issuecomment-763487213
> > > Hi , The changes which were committed with the 1 st commit , are done
when running automated migration using CLI.
> >
> >
> >  were added to refs/heads/master by this push:
new f5ee17f feat: add pkg idgen
idbeta edited a comment on issue #1288:
URL:
https://github.com/apache/apisix-dashboard/issues/1288#issuecomment-760686696
> @idbeta What about preparing some stuffs like debuginfo.rpm when compiling
it.
sorry, I don't quite understand what you mean.
I don't think `reduce` is nec
liuxiran commented on a change in pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r560833899
##
File path: web/cypress/integration/route/online-debug.spec.js
##
@@ -54,6 +54,9 @@ context('Online debug', () => {
cy.get(domSelector
membphis commented on issue #1336:
URL:
https://github.com/apache/apisix-dashboard/issues/1336#issuecomment-763488723
@nic-chen what do you think?
This is an automated message from the Apache Git Service.
To respond to the m
nic-chen commented on issue #1065:
URL:
https://github.com/apache/apisix-dashboard/issues/1065#issuecomment-763489516
close by https://github.com/apache/apisix/pull/3076
and we have synced the schema.
This is an automated
nic-chen closed issue #1065:
URL: https://github.com/apache/apisix-dashboard/issues/1065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
membphis merged pull request #3345:
URL: https://github.com/apache/apisix/pull/3345
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis closed issue #2798:
URL: https://github.com/apache/apisix/issues/2798
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 319c3eb test: make ci stable (#3329)
add 95c0170 feat: allow getting health check status via control API
(#
nic-chen commented on issue #1336:
URL:
https://github.com/apache/apisix-dashboard/issues/1336#issuecomment-763494732
@belongwqz
Could it be achieved by nginx configuration? I don’t understand why we need
to change the Manager API to support this feature. Thanks.
---
membphis commented on issue #3342:
URL: https://github.com/apache/apisix/issues/3342#issuecomment-763495078
> Maybe we can ignore the failed DNS response?
agree, and need to write an error log for this case.
if there is no healthy node, we should return `503` for this case.
-
liuxiran commented on issue #1065:
URL:
https://github.com/apache/apisix-dashboard/issues/1065#issuecomment-763495368
May I ask whether Fe also need to support empty nodes in upstream? The
current policy is that use have to fill in at least one node
-
Caelebs commented on issue #1337:
URL:
https://github.com/apache/apisix-dashboard/issues/1337#issuecomment-763495404
> 这不是一件容易的事，但是我将在v2.4发布之后起草有关此问题的文档。
nice. looking forward to the next version
This is an automated
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 271be10 doc: add doc about
membphis merged pull request #187:
URL: https://github.com/apache/apisix-ingress-controller/pull/187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Caelebs removed a comment on issue #1337:
URL:
https://github.com/apache/apisix-dashboard/issues/1337#issuecomment-763495404
> 这不是一件容易的事，但是我将在v2.4发布之后起草有关此问题的文档。
nice. looking forward to the next version
This is an au
liuxiran edited a comment on issue #1065:
URL:
https://github.com/apache/apisix-dashboard/issues/1065#issuecomment-763495368
May I ask whether Fe also need to support empty nodes in upstream? The
current policy is that user have to fill in at least one node
-
Caelebs commented on issue #1337:
URL:
https://github.com/apache/apisix-dashboard/issues/1337#issuecomment-763495643
> This is not an easy job, but I will draft documentation about this after
v2.4 release.
nice. looking forward to the next version
-
pengtaochang opened a new issue #3364:
URL: https://github.com/apache/apisix/issues/3364
### Issue description
I want to user apisix proxy the apisix dashboard, but don't know what need
to do.
Thanks.
### Environment
apisix-dashboard 2.3
* apisix version (cmd: `apisix version
nic-chen opened a new issue #1065:
URL: https://github.com/apache/apisix-dashboard/issues/1065
Manager API should keep same as Admin API, we need to track the discussion
in APISIX, and sync if any thing changes.
related issue:
https://github.com/apache/apisix/issues/3072
-
membphis commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r560842633
##
File path: Makefile
##
@@ -56,6 +57,9 @@ ifeq ($(LUAROCKS_VER),luarocks 3.)
else
luarocks install rockspec/apisix-master-0.rockspec --tree=dep
spacewander commented on issue #3342:
URL: https://github.com/apache/apisix/issues/3342#issuecomment-763498274
We returns `502` when no endpoint can be selected, maybe returns `502` for
this case is better?
This is an automa
idbeta opened a new pull request #3365:
URL: https://github.com/apache/apisix/pull/3365
### What this PR does / why we need it:
add shell script for run APISIX testcases on ARM64
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
membphis commented on issue #3342:
URL: https://github.com/apache/apisix/issues/3342#issuecomment-763501279
`502` means the upstream is running but cannot respond to requests normally
`503` means the upstream can not working (stoped or restarting)
so I think we should use `503` if
idbeta commented on pull request #1304:
URL: https://github.com/apache/apisix-dashboard/pull/1304#issuecomment-763507300
After removing the `cy.wait()` of this use case, CI failed , so I add it
back now, please analyze if you have time, @LiteSun. I will raise an issue
later.
---
idbeta edited a comment on pull request #1304:
URL: https://github.com/apache/apisix-dashboard/pull/1304#issuecomment-763507300
After removing the `cy.wait()` of the case, CI failed , so I add it back
now, please analyze if you have time, @LiteSun. I will raise an issue later.
--
nic-chen commented on issue #1065:
URL:
https://github.com/apache/apisix-dashboard/issues/1065#issuecomment-763507783
I think FE don't need this feature now, it's for ingress controller,
manually add upstream should not allow empty nodes.
-
tokers commented on a change in pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#discussion_r560870942
##
File path: api/cmd/managerapi.go
##
@@ -119,5 +132,28 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags()
tokers commented on a change in pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#discussion_r560873158
##
File path: api/cmd/managerapi.go
##
@@ -119,5 +132,28 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags()
starsz commented on pull request #1315:
URL: https://github.com/apache/apisix-dashboard/pull/1315#issuecomment-763526811
> ping @starsz
Sorry, I am too busy to deal with it on those days.
I will update it when I am free.
---
tokers commented on issue #3358:
URL: https://github.com/apache/apisix/issues/3358#issuecomment-763529322
@wy92 You mean add the per-route data.
This is an automated message from the Apache Git Service.
To respond to the mess
tokers edited a comment on issue #3358:
URL: https://github.com/apache/apisix/issues/3358#issuecomment-763529322
@wy92 You mean add the per-route data?
This is an automated message from the Apache Git Service.
To respond to t
starsz commented on issue #1332:
URL:
https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-763530488
Aha! Much appreciated.
This is an automated message from the Apache Git Service.
To respond to the message,
1 - 100 of 321 matches
Mail list logo
