tokers commented on pull request #152:
URL: https://github.com/apache/apisix-website/pull/152#issuecomment-764475914
@moonming
This is an automated message from the Apache Git Service.
To respond to the message, please log
spacewander commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561460712
##
File path: doc/plugins/authz-keycloak.md
##
@@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
liuxiran commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764442783
Do we need to add **test cases** about
1. import a error file
2. a file includes two or more APIs
juzhiyuan closed issue #1329:
URL: https://github.com/apache/apisix-dashboard/issues/1329
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
imjoey commented on pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764638880
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tokers commented on a change in pull request #3379:
URL: https://github.com/apache/apisix/pull/3379#discussion_r561607289
##
File path: apisix/schema_def.lua
##
@@ -81,7 +81,6 @@ local remote_addr_def = {
local label_value_def = {
description = "value of label",
membphis edited a comment on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287
please merge the code of master branch, CI failed ^_^
This is an automated message from the Apache Git
nic-chen commented on issue #706:
URL:
https://github.com/apache/apisix-dashboard/issues/706#issuecomment-764443679
fixed by #977
This is an automated message from the Apache Git Service.
To respond to the message, please
tokers commented on pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764625660
could we add a test case to verify that these events are really ignored?
This is an automated message
Firstsawyou commented on pull request #3382:
URL: https://github.com/apache/apisix/pull/3382#issuecomment-764659792
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tokers commented on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-764630383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
imjoey edited a comment on issue #1154:
URL:
https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan merged pull request #3379:
URL: https://github.com/apache/apisix/pull/3379
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tokers commented on issue #122:
URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765068236
@ClementeGao Could you provide a minimal reproducible case?
This is an automated message from the Apache Git
fukiki commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561461963
##
File path: apisix/cli/apisix.lua
##
@@ -0,0 +1,36 @@
+#!/usr/bin/env /usr/local/Cellar/openresty/1.19.3.1_1/luajit/bin/luajit
Review comment:
A
nic-chen closed issue #706:
URL: https://github.com/apache/apisix-dashboard/issues/706
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Yiyiyimu commented on a change in pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#discussion_r561659098
##
File path: apisix/core/config_etcd.lua
##
@@ -241,7 +241,11 @@ local function sync_data(self)
else
if not dir_res.nodes then
-
membphis commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764550918
> Hi @spacewander @starsz, do we have any quick ideas to export those test
cases from Lua?
I do not have a good idea for this job :(
nic-chen commented on issue #679:
URL:
https://github.com/apache/apisix-dashboard/issues/679#issuecomment-764445689
not urgent, we could move to next version
This is an automated message from the Apache Git Service.
To
nic-chen closed issue #872:
URL: https://github.com/apache/apisix-dashboard/issues/872
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
FeynmanZhou edited a comment on pull request #195:
URL:
https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764610978
Updated https://github.com/apache/apisix-ingress-controller/pull/196
This is an
imjoey commented on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764178423
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Firstsawyou commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764511598
This problem may have been fixed, you can try the latest version 2.2 .
This is an automated message from the
fukiki commented on issue #193:
URL:
https://github.com/apache/apisix-ingress-controller/issues/193#issuecomment-764505170
I will try it.
This is an automated message from the Apache Git Service.
To respond to the message,
imjoey commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561447284
##
File path: apisix/cli/apisix.lua
##
@@ -0,0 +1,36 @@
+#!/usr/bin/env /usr/local/Cellar/openresty/1.19.3.1_1/luajit/bin/luajit
Review comment:
Firstsawyou commented on a change in pull request #3382:
URL: https://github.com/apache/apisix/pull/3382#discussion_r561981155
##
File path: apisix/upstream.lua
##
@@ -131,21 +131,21 @@ function _M.set_by_route(route, api_ctx)
local up_conf = api_ctx.matched_upstream
spacewander commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764432147
I don't any idea unless we modify the code of APISIX and dump the data we
used.
This is an automated
nic-chen closed issue #887:
URL: https://github.com/apache/apisix-dashboard/issues/887
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gxthrj merged pull request #196:
URL: https://github.com/apache/apisix-ingress-controller/pull/196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
juzhiyuan commented on issue #1345:
URL:
https://github.com/apache/apisix-dashboard/issues/1345#issuecomment-764653558
anyone would like to take this proposal?
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764140775
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
juzhiyuan commented on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-765104426
Then you need to fix this ASAP once 2.4 is released, or this issue would
always exist here.
This is an
gxthrj commented on issue #122:
URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765089745
@ClementeGao If you have solved this issue, Please add some describe here,
Thanks~
This is an automated message
ShiningRush commented on a change in pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#discussion_r562364607
##
File path: api/internal/core/storage/storage.go
##
@@ -36,12 +36,13 @@ type WatchResponse struct {
type Keypair struct {
Key
spacewander commented on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764428267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gxthrj commented on a change in pull request #191:
URL:
https://github.com/apache/apisix-ingress-controller/pull/191#discussion_r561908172
##
File path: test/e2e/scaffold/ingress.go
##
@@ -29,6 +29,141 @@ import (
const (
_serviceAccount =
spacewander commented on issue #1833:
URL: https://github.com/apache/apisix/issues/1833#issuecomment-764468162
Surpassed by #3344.
This is an automated message from the Apache Git Service.
To respond to the message, please
nic-chen commented on issue #1336:
URL:
https://github.com/apache/apisix-dashboard/issues/1336#issuecomment-764103855
> > @belongwqz
> > Could it be achieved by nginx configuration? I don’t understand why we
need to change the Manager API to support this feature. Thanks.
>
> The
juzhiyuan commented on a change in pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561887414
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -93,7 +93,7 @@ context('Create Route with Upstream', ()
spacewander commented on a change in pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#discussion_r561589660
##
File path: apisix/core/config_etcd.lua
##
@@ -241,7 +241,11 @@ local function sync_data(self)
else
if not dir_res.nodes
nic-chen commented on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764107353
![image](https://user-images.githubusercontent.com/33000667/105258756-62405400-5bc5-11eb-8535-0cd1068ad2b1.png)
we should need some more test cases for it..
membphis merged pull request #3387:
URL: https://github.com/apache/apisix/pull/3387
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guoqqqi commented on a change in pull request #1347:
URL: https://github.com/apache/apisix-dashboard/pull/1347#discussion_r562339889
##
File path: web/src/pages/Service/Create.tsx
##
@@ -81,13 +81,12 @@ const Page: React.FC = (props) => {
(serviceId ? update(serviceId,
spacewander commented on issue #3384:
URL: https://github.com/apache/apisix/issues/3384#issuecomment-764481176
Maybe we can reuse producer via lrucache, like this:
https://github.com/apache/apisix/blob/e5916cf541281e7fe756dd2e393bd6dcf702c220/apisix/plugins/limit-req.lua#L67?
juzhiyuan commented on issue #1356:
URL:
https://github.com/apache/apisix-dashboard/issues/1356#issuecomment-765099546
Thanks for your feedback!
This is an automated message from the Apache Git Service.
To respond to the
Jaycean removed a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765076940
> > > Hi, @Jaycean. Need unit test.
> >
> >
> > At present, the function interface needs to export the existing route
data and ensure the correctness
tokers commented on a change in pull request #190:
URL:
https://github.com/apache/apisix-ingress-controller/pull/190#discussion_r561669309
##
File path: Makefile
##
@@ -58,12 +59,18 @@ unit-test:
go test -cover -coverprofile=coverage.txt ./...
### e2e-test:
tokers commented on pull request #196:
URL:
https://github.com/apache/apisix-ingress-controller/pull/196#issuecomment-764626385
This is an automated message from the Apache Git Service.
To respond to the message, please log
membphis merged pull request #3386:
URL: https://github.com/apache/apisix/pull/3386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tokers merged pull request #3255:
URL: https://github.com/apache/apisix/pull/3255
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis edited a comment on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-764733027
> Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can
it solve your problem?
this is not a best way in APISIX. we can use the Route + proxy cache
spacewander merged pull request #3377:
URL: https://github.com/apache/apisix/pull/3377
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
juzhiyuan commented on pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#issuecomment-764146583
![image](https://user-images.githubusercontent.com/2106987/105260352-9d905200-5bc8-11eb-8e5d-6c5353e1aa4a.png)
Those commits are not related to Language
gxthrj commented on pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764650741
LGTM
This is an automated message from the Apache Git Service.
To respond to the message,
yongboy commented on issue #3362:
URL: https://github.com/apache/apisix/issues/3362#issuecomment-764193701
Here is the PR: #3372
This is an automated message from the Apache Git Service.
To respond to the message, please log
spacewander closed issue #1698:
URL: https://github.com/apache/apisix/issues/1698
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tokers edited a comment on pull request #192:
URL:
https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764691853
> Need to update docs which contains `ApisixTls`.
The docs are all about CRD `ApisixTls`, considering the compatiblity, i
didn't change the CRD
membphis merged pull request #3366:
URL: https://github.com/apache/apisix/pull/3366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
juzhiyuan commented on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764413569
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
fukiki commented on pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764510956
@gxthrj Please take a look when you have time.
This is an automated message from the Apache Git
Yiyiyimu commented on issue #3362:
URL: https://github.com/apache/apisix/issues/3362#issuecomment-764439631
> I remember that if these keys (`/apisix/routes`, `/apisix/services`, etc.)
do not exist, the ETCD watch will fail.
> @Yiyiyimu please have a look.
Yeah I remember the
codecov-io edited a comment on pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#issuecomment-761318695
This is an automated message from the Apache Git Service.
To respond to the message, please
tokers commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561877898
##
File path: apisix/router.lua
##
@@ -32,6 +33,14 @@ local function filter(route)
return
end
+if route.value.host then
+
Firstsawyou commented on issue #3374:
URL: https://github.com/apache/apisix/issues/3374#issuecomment-764351519
> This will break the compatibility. Is there a strong reason to do the
change?
The 500 response code represents a problem caused by an error in the program
code. However,
Firstsawyou commented on issue #3388:
URL: https://github.com/apache/apisix/issues/3388#issuecomment-764474431
@membphis @spacewander If you have time, please take a look.
This is an automated message from the Apache Git
codecov-io commented on pull request #190:
URL:
https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764424799
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=h1)
Report
> Merging
juzhiyuan closed issue #1343:
URL: https://github.com/apache/apisix-dashboard/issues/1343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
spacewander closed issue #3395:
URL: https://github.com/apache/apisix/issues/3395
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander commented on issue #3375:
URL: https://github.com/apache/apisix/issues/3375#issuecomment-764228763
I am not quite understand what you need. But you can submit a PR first so we
can discuss with the code.
This is
nic-chen commented on issue #1329:
URL:
https://github.com/apache/apisix-dashboard/issues/1329#issuecomment-764573055
> @nic-chen I'm afraid I cannot reproduce in my environment. Is the etcd
also newly installed? I guess there's something wrong with the data in etcd. So
could you please
tokers merged pull request #195:
URL: https://github.com/apache/apisix-ingress-controller/pull/195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
spacewander commented on issue #3395:
URL: https://github.com/apache/apisix/issues/3395#issuecomment-765106090
Duplicate of #2208
This is an automated message from the Apache Git Service.
To respond to the message, please
moonming commented on pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20#issuecomment-764649196
@TkClark please use English in the public channel
This is an automated message from the Apache Git
jenskeiner commented on pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#issuecomment-764621696
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
idbeta edited a comment on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764201065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tokers commented on a change in pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#discussion_r561754424
##
File path: README.md
##
@@ -21,7 +21,7 @@
[![Go Report
juzhiyuan commented on issue #1075:
URL:
https://github.com/apache/apisix-dashboard/issues/1075#issuecomment-764509238
This issue is relying on Cypress's Write permission, which needs infra's
reply.
This is an automated
membphis closed issue #1646:
URL: https://github.com/apache/apisix/issues/1646
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis commented on issue #3344:
URL: https://github.com/apache/apisix/issues/3344#issuecomment-764418234
I think we can fix this issue in milestone 2.3 (this month) @JanLi-air
This is an automated message from the Apache
moonming commented on a change in pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561920602
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -93,7 +93,7 @@ context('Create Route with Upstream', () =>
liuxiran commented on a change in pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#discussion_r561648621
##
File path: api/test/e2e/import_test.go
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
tokers closed pull request #3382:
URL: https://github.com/apache/apisix/pull/3382
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
juzhiyuan merged pull request #1339:
URL: https://github.com/apache/apisix-dashboard/pull/1339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
spacewander commented on issue #3373:
URL: https://github.com/apache/apisix/issues/3373#issuecomment-764257035
```
proxy_hide_header Cache-Control;
proxy_hide_header Expires;
add_header Cache-Control
TkClark commented on a change in pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r561792363
##
File path: chart/apisix/values.yaml
##
@@ -188,5 +190,5 @@ nodeSelector: {}
tolerations: []
-affinity: {}
-
+affinity:
+ enabled: true
LiteSun closed pull request #1341:
URL: https://github.com/apache/apisix-dashboard/pull/1341
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
membphis commented on issue #3340:
URL: https://github.com/apache/apisix/issues/3340#issuecomment-765061361
> The current test method of Apache APISIX pays more attention to normal
input/output, in order to test the robustness of the program, fuzz testing can
be used.
I think you
tokers merged pull request #190:
URL: https://github.com/apache/apisix-ingress-controller/pull/190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
juzhiyuan commented on a change in pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r561449442
##
File path: web/cypress/integration/route/online-debug.spec.js
##
@@ -21,19 +21,20 @@ import defaultSettings from
tokers commented on issue #3384:
URL: https://github.com/apache/apisix/issues/3384#issuecomment-764633660
> > Maybe we can reuse producer via lrucache, like this:
>
> >
>
> >
liuxiran commented on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764162784
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
spacewander commented on issue #3383:
URL: https://github.com/apache/apisix/issues/3383#issuecomment-764439052
CC @juzhiyuan @nic-chen
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan merged pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
spacewander commented on pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#issuecomment-764195467
BTW, you can split the test into two files, like the
https://github.com/apache/apisix/blob/master/t/plugin/limit-conn2.t. Since it
is too big now.
membphis commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287
please merge the code of master branch
This is an automated message from the Apache Git Service.
To respond to
tokers commented on issue #3336:
URL: https://github.com/apache/apisix/issues/3336#issuecomment-764168873
It's more flexible if the scheme is defined for each node.
This is an automated message from the Apache Git Service.
spacewander merged pull request #3381:
URL: https://github.com/apache/apisix/pull/3381
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
belongwqz commented on issue #3393:
URL: https://github.com/apache/apisix/issues/3393#issuecomment-765070054
> @belongwqz Actually you can use `serverless` plugin to customize your
demand.
All right, maybe we can give more examples in the `serverless` plugin
documentation to show
membphis commented on issue #1300:
URL:
https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764226137
do we need to transfer this issue to APISIX?
This is an automated message from the Apache Git Service.
To
nic-chen commented on issue #746:
URL:
https://github.com/apache/apisix-dashboard/issues/746#issuecomment-765091552
not urgent, we could move to the next version
This is an automated message from the Apache Git Service.
101 - 200 of 540 matches
Mail list logo