[GitHub] [apisix-website] tokers commented on pull request #152: feat: add 2021-01-21-run-ingress-apisix-on-amazon-eks.md

2021-01-21 Thread GitBox
tokers commented on pull request #152: URL: https://github.com/apache/apisix-website/pull/152#issuecomment-764475914 @moonming This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander commented on a change in pull request #3308: feat: authz-keycloak plugin - dynamic scope and resource mapping.

2021-01-21 Thread GitBox
spacewander commented on a change in pull request #3308: URL: https://github.com/apache/apisix/pull/3308#discussion_r561460712 ## File path: doc/plugins/authz-keycloak.md ## @@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](https:/

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764442783 Do we need to add **test cases** about 1. import a error file 2. a file includes two or more APIs

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1329: bug: non-json data causes error logs

2021-01-21 Thread GitBox
juzhiyuan closed issue #1329: URL: https://github.com/apache/apisix-dashboard/issues/1329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] imjoey commented on pull request #1344: fix: ignore the init_dir event of etcd storage when store processing

2021-01-21 Thread GitBox
imjoey commented on pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764638880 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] tokers commented on a change in pull request #3379: feat: remove restriction of label pattern to support Chinese

2021-01-21 Thread GitBox
tokers commented on a change in pull request #3379: URL: https://github.com/apache/apisix/pull/3379#discussion_r561607289 ## File path: apisix/schema_def.lua ## @@ -81,7 +81,6 @@ local remote_addr_def = { local label_value_def = { description = "value of label",

[GitHub] [apisix] membphis edited a comment on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
membphis edited a comment on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287 please merge the code of master branch, CI failed ^_^ This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] nic-chen commented on issue #706: chore: need to write the error message into log

2021-01-21 Thread GitBox
nic-chen commented on issue #706: URL: https://github.com/apache/apisix-dashboard/issues/706#issuecomment-764443679 fixed by #977 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] tokers commented on pull request #1344: fix: ignore the init_dir event of etcd storage when store processing

2021-01-21 Thread GitBox
tokers commented on pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764625660 could we add a test case to verify that these events are really ignored? This is an automated message

[GitHub] [apisix] Firstsawyou commented on pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code

2021-01-21 Thread GitBox
Firstsawyou commented on pull request #3382: URL: https://github.com/apache/apisix/pull/3382#issuecomment-764659792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] tokers commented on pull request #1333: chore: add stop subcommand

2021-01-21 Thread GitBox
tokers commented on pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-764630383 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data

2021-01-21 Thread GitBox
imjoey edited a comment on issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] juzhiyuan merged pull request #3379: feat: remove restriction of label pattern to support Chinese

2021-01-21 Thread GitBox
juzhiyuan merged pull request #3379: URL: https://github.com/apache/apisix/pull/3379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-docker] tokers commented on issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string

2021-01-21 Thread GitBox
tokers commented on issue #122: URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765068236 @ClementeGao Could you provide a minimal reproducible case? This is an automated message from the Apache Git

[GitHub] [apisix] fukiki commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
fukiki commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561461963 ## File path: apisix/cli/apisix.lua ## @@ -0,0 +1,36 @@ +#!/usr/bin/env /usr/local/Cellar/openresty/1.19.3.1_1/luajit/bin/luajit Review comment: A

[GitHub] [apisix-dashboard] nic-chen closed issue #706: chore: need to write the error message into log

2021-01-21 Thread GitBox
nic-chen closed issue #706: URL: https://github.com/apache/apisix-dashboard/issues/706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3372: feat: allow ETCD work without some special keys

2021-01-21 Thread GitBox
Yiyiyimu commented on a change in pull request #3372: URL: https://github.com/apache/apisix/pull/3372#discussion_r561659098 ## File path: apisix/core/config_etcd.lua ## @@ -241,7 +241,11 @@ local function sync_data(self) else if not dir_res.nodes then -

[GitHub] [apisix-dashboard] membphis commented on issue #1238: sync plugins' testcases from apisix automatically

2021-01-21 Thread GitBox
membphis commented on issue #1238: URL: https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764550918 > Hi @spacewander @starsz, do we have any quick ideas to export those test cases from Lua? I do not have a good idea for this job :(

[GitHub] [apisix-dashboard] nic-chen commented on issue #679: feature: support https for `manager api`

2021-01-21 Thread GitBox
nic-chen commented on issue #679: URL: https://github.com/apache/apisix-dashboard/issues/679#issuecomment-764445689 not urgent, we could move to next version This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] nic-chen closed issue #872: bug: manager-api should not allow create route with remote_addrs and remote_addr at the same time

2021-01-21 Thread GitBox
nic-chen closed issue #872: URL: https://github.com/apache/apisix-dashboard/issues/872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-ingress-controller] FeynmanZhou edited a comment on pull request #195: doc: run ingress apisix on kubesphere

2021-01-21 Thread GitBox
FeynmanZhou edited a comment on pull request #195: URL: https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764610978 Updated https://github.com/apache/apisix-ingress-controller/pull/196 This is an

[GitHub] [apisix] imjoey commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64

2021-01-21 Thread GitBox
imjoey commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764178423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] Firstsawyou commented on issue #3389: bug: get empty data from etcd when apisix init

2021-01-21 Thread GitBox
Firstsawyou commented on issue #3389: URL: https://github.com/apache/apisix/issues/3389#issuecomment-764511598 This problem may have been fixed, you can try the latest version 2.2 . This is an automated message from the

[GitHub] [apisix-ingress-controller] fukiki commented on issue #193: request help: Need to add Apache APISIX link in README

2021-01-21 Thread GitBox
fukiki commented on issue #193: URL: https://github.com/apache/apisix-ingress-controller/issues/193#issuecomment-764505170 I will try it. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] imjoey commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
imjoey commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561447284 ## File path: apisix/cli/apisix.lua ## @@ -0,0 +1,36 @@ +#!/usr/bin/env /usr/local/Cellar/openresty/1.19.3.1_1/luajit/bin/luajit Review comment:

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code

2021-01-21 Thread GitBox
Firstsawyou commented on a change in pull request #3382: URL: https://github.com/apache/apisix/pull/3382#discussion_r561981155 ## File path: apisix/upstream.lua ## @@ -131,21 +131,21 @@ function _M.set_by_route(route, api_ctx) local up_conf = api_ctx.matched_upstream

[GitHub] [apisix-dashboard] spacewander commented on issue #1238: sync plugins' testcases from apisix automatically

2021-01-21 Thread GitBox
spacewander commented on issue #1238: URL: https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764432147 I don't any idea unless we modify the code of APISIX and dump the data we used. This is an automated

[GitHub] [apisix-dashboard] nic-chen closed issue #887: test: need e2e test to ensure JSONSchema default value works fine

2021-01-21 Thread GitBox
nic-chen closed issue #887: URL: https://github.com/apache/apisix-dashboard/issues/887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #196: refine the deployment guide of kubesphere, reorder the list in instll.md

2021-01-21 Thread GitBox
gxthrj merged pull request #196: URL: https://github.com/apache/apisix-ingress-controller/pull/196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1345: Dashboard for Apache APISIX Ingress Controller

2021-01-21 Thread GitBox
juzhiyuan commented on issue #1345: URL: https://github.com/apache/apisix-dashboard/issues/1345#issuecomment-764653558 anyone would like to take this proposal? This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1326: fix(fe): update url regexp in online debug

2021-01-21 Thread GitBox
juzhiyuan commented on pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764140775 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2021-01-21 Thread GitBox
juzhiyuan commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-765104426 Then you need to fix this ASAP once 2.4 is released, or this issue would always exist here. This is an

[GitHub] [apisix-docker] gxthrj commented on issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string

2021-01-21 Thread GitBox
gxthrj commented on issue #122: URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765089745 @ClementeGao If you have solved this issue, Please add some describe here, Thanks~ This is an automated message

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #1344: fix: ignore the init_dir event when watching etcd events

2021-01-21 Thread GitBox
ShiningRush commented on a change in pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344#discussion_r562364607 ## File path: api/internal/core/storage/storage.go ## @@ -36,12 +36,13 @@ type WatchResponse struct { type Keypair struct { Key

[GitHub] [apisix] spacewander commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless

2021-01-21 Thread GitBox
spacewander commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764428267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #191: fix:BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…

2021-01-21 Thread GitBox
gxthrj commented on a change in pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191#discussion_r561908172 ## File path: test/e2e/scaffold/ingress.go ## @@ -29,6 +29,141 @@ import ( const ( _serviceAccount =

[GitHub] [apisix] spacewander commented on issue #1833: request help: how to proxy grpc to grpcs.

2021-01-21 Thread GitBox
spacewander commented on issue #1833: URL: https://github.com/apache/apisix/issues/1833#issuecomment-764468162 Surpassed by #3344. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] nic-chen commented on issue #1336: Support subpath to use the reverse proxy

2021-01-21 Thread GitBox
nic-chen commented on issue #1336: URL: https://github.com/apache/apisix-dashboard/issues/1336#issuecomment-764103855 > > @belongwqz > > Could it be achieved by nginx configuration? I don’t understand why we need to change the Manager API to support this feature. Thanks. > > The

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1308: test: Create Upstream in Route.

2021-01-21 Thread GitBox
juzhiyuan commented on a change in pull request #1308: URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561887414 ## File path: web/cypress/integration/route/create-route-with-upstream.spec.js ## @@ -93,7 +93,7 @@ context('Create Route with Upstream', ()

[GitHub] [apisix] spacewander commented on a change in pull request #3372: feat: allow ETCD work without some special keys

2021-01-21 Thread GitBox
spacewander commented on a change in pull request #3372: URL: https://github.com/apache/apisix/pull/3372#discussion_r561589660 ## File path: apisix/core/config_etcd.lua ## @@ -241,7 +241,11 @@ local function sync_data(self) else if not dir_res.nodes

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1326: fix(fe): update url regexp in online debug

2021-01-21 Thread GitBox
nic-chen commented on pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764107353 ![image](https://user-images.githubusercontent.com/33000667/105258756-62405400-5bc5-11eb-8535-0cd1068ad2b1.png) we should need some more test cases for it..

[GitHub] [apisix] membphis merged pull request #3387: fix: support upstream_id & consumer with grpc

2021-01-21 Thread GitBox
membphis merged pull request #3387: URL: https://github.com/apache/apisix/pull/3387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1347: fix: editing a Service, the upstream info will be lost.

2021-01-21 Thread GitBox
guoqqqi commented on a change in pull request #1347: URL: https://github.com/apache/apisix-dashboard/pull/1347#discussion_r562339889 ## File path: web/src/pages/Service/Create.tsx ## @@ -81,13 +81,12 @@ const Page: React.FC = (props) => { (serviceId ? update(serviceId,

[GitHub] [apisix] spacewander commented on issue #3384: request help: unbalanced message in kafka partition using kafka-logger plugin

2021-01-21 Thread GitBox
spacewander commented on issue #3384: URL: https://github.com/apache/apisix/issues/3384#issuecomment-764481176 Maybe we can reuse producer via lrucache, like this: https://github.com/apache/apisix/blob/e5916cf541281e7fe756dd2e393bd6dcf702c220/apisix/plugins/limit-req.lua#L67?

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1356: There is a vulnerability in codemirror 5.57.0,upgrade recommended

2021-01-21 Thread GitBox
juzhiyuan commented on issue #1356: URL: https://github.com/apache/apisix-dashboard/issues/1356#issuecomment-765099546 Thanks for your feedback! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] Jaycean removed a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
Jaycean removed a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765076940 > > > Hi, @Jaycean. Need unit test. > > > > > > At present, the function interface needs to export the existing route data and ensure the correctness

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #190: chore:add ginkgo check before e2e-test(apache #186)

2021-01-21 Thread GitBox
tokers commented on a change in pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#discussion_r561669309 ## File path: Makefile ## @@ -58,12 +59,18 @@ unit-test: go test -cover -coverprofile=coverage.txt ./... ### e2e-test:

[GitHub] [apisix-ingress-controller] tokers commented on pull request #196: refine the deployment guide of kubesphere, reorder the list in instll.md

2021-01-21 Thread GitBox
tokers commented on pull request #196: URL: https://github.com/apache/apisix-ingress-controller/pull/196#issuecomment-764626385 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] membphis merged pull request #3386: chore: update lua-resty-expr to v1.1.0

2021-01-21 Thread GitBox
membphis merged pull request #3386: URL: https://github.com/apache/apisix/pull/3386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] tokers merged pull request #3255: chore: ngx.req.get_body_data -> req_get_body_data

2021-01-21 Thread GitBox
tokers merged pull request #3255: URL: https://github.com/apache/apisix/pull/3255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis edited a comment on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-21 Thread GitBox
membphis edited a comment on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-764733027 > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? this is not a best way in APISIX. we can use the Route + proxy cache

[GitHub] [apisix] spacewander merged pull request #3377: fix: ignore the case of configured host

2021-01-21 Thread GitBox
spacewander merged pull request #3377: URL: https://github.com/apache/apisix/pull/3377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1334: test: switch language

2021-01-21 Thread GitBox
juzhiyuan commented on pull request #1334: URL: https://github.com/apache/apisix-dashboard/pull/1334#issuecomment-764146583 ![image](https://user-images.githubusercontent.com/2106987/105260352-9d905200-5bc8-11eb-8e5d-6c5353e1aa4a.png) Those commits are not related to Language

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #194: doc: Add Apache APISIX link in README

2021-01-21 Thread GitBox
gxthrj commented on pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764650741 LGTM This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] yongboy commented on issue #3362: discuss: should we support the etcd missing some special keys case

2021-01-21 Thread GitBox
yongboy commented on issue #3362: URL: https://github.com/apache/apisix/issues/3362#issuecomment-764193701 Here is the PR: #3372 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander closed issue #1698: request help: Does route supports to match ':authority' header of grpc?

2021-01-21 Thread GitBox
spacewander closed issue #1698: URL: https://github.com/apache/apisix/issues/1698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS

2021-01-21 Thread GitBox
tokers edited a comment on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764691853 > Need to update docs which contains `ApisixTls`. The docs are all about CRD `ApisixTls`, considering the compatiblity, i didn't change the CRD

[GitHub] [apisix] membphis merged pull request #3366: docs(traffic-split): update the vars example of the docs

2021-01-21 Thread GitBox
membphis merged pull request #3366: URL: https://github.com/apache/apisix/pull/3366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] juzhiyuan commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless

2021-01-21 Thread GitBox
juzhiyuan commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764413569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-ingress-controller] fukiki commented on pull request #194: doc: Add Apache APISIX link in README

2021-01-21 Thread GitBox
fukiki commented on pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764510956 @gxthrj Please take a look when you have time. This is an automated message from the Apache Git

[GitHub] [apisix] Yiyiyimu commented on issue #3362: discuss: should we support the etcd missing some special keys case

2021-01-21 Thread GitBox
Yiyiyimu commented on issue #3362: URL: https://github.com/apache/apisix/issues/3362#issuecomment-764439631 > I remember that if these keys (`/apisix/routes`, `/apisix/services`, etc.) do not exist, the ETCD watch will fail. > @Yiyiyimu please have a look. Yeah I remember the

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1308: test: Create Upstream in Route.

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1308: URL: https://github.com/apache/apisix-dashboard/pull/1308#issuecomment-761318695 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] tokers commented on a change in pull request #3377: fix: ignore the case of configured host

2021-01-21 Thread GitBox
tokers commented on a change in pull request #3377: URL: https://github.com/apache/apisix/pull/3377#discussion_r561877898 ## File path: apisix/router.lua ## @@ -32,6 +33,14 @@ local function filter(route) return end +if route.value.host then +

[GitHub] [apisix] Firstsawyou commented on issue #3374: Modify the 500 response code in the upstream.lua file to 503 response code

2021-01-21 Thread GitBox
Firstsawyou commented on issue #3374: URL: https://github.com/apache/apisix/issues/3374#issuecomment-764351519 > This will break the compatibility. Is there a strong reason to do the change? The 500 response code represents a problem caused by an error in the program code. However,

[GitHub] [apisix] Firstsawyou commented on issue #3388: bug: the balancer_ip is old, resulting in 504 timeout

2021-01-21 Thread GitBox
Firstsawyou commented on issue #3388: URL: https://github.com/apache/apisix/issues/3388#issuecomment-764474431 @membphis @spacewander If you have time, please take a look. This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #190: * chore:add ginkgo check before e2e-test(apache #186)

2021-01-21 Thread GitBox
codecov-io commented on pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764424799 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1343: Route: update description input box

2021-01-21 Thread GitBox
juzhiyuan closed issue #1343: URL: https://github.com/apache/apisix-dashboard/issues/1343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] spacewander closed issue #3395: request help: Apisix have feature like kong strip_path? Thanks

2021-01-21 Thread GitBox
spacewander closed issue #3395: URL: https://github.com/apache/apisix/issues/3395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #3375: discuss: the discovery module need more features

2021-01-21 Thread GitBox
spacewander commented on issue #3375: URL: https://github.com/apache/apisix/issues/3375#issuecomment-764228763 I am not quite understand what you need. But you can submit a PR first so we can discuss with the code. This is

[GitHub] [apisix-dashboard] nic-chen commented on issue #1329: bug: non-json data causes error logs

2021-01-21 Thread GitBox
nic-chen commented on issue #1329: URL: https://github.com/apache/apisix-dashboard/issues/1329#issuecomment-764573055 > @nic-chen I'm afraid I cannot reproduce in my environment. Is the etcd also newly installed? I guess there's something wrong with the data in etcd. So could you please

[GitHub] [apisix-ingress-controller] tokers merged pull request #195: doc: run ingress apisix on kubesphere

2021-01-21 Thread GitBox
tokers merged pull request #195: URL: https://github.com/apache/apisix-ingress-controller/pull/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on issue #3395: request help: Apisix have feature like kong strip_path? Thanks

2021-01-21 Thread GitBox
spacewander commented on issue #3395: URL: https://github.com/apache/apisix/issues/3395#issuecomment-765106090 Duplicate of #2208 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-helm-chart] moonming commented on pull request #20: 修改Helm模板支持多etcdhost,添加默认反亲和

2021-01-21 Thread GitBox
moonming commented on pull request #20: URL: https://github.com/apache/apisix-helm-chart/pull/20#issuecomment-764649196 @TkClark please use English in the public channel This is an automated message from the Apache Git

[GitHub] [apisix] jenskeiner commented on pull request #3308: feat: authz-keycloak plugin - dynamic scope and resource mapping.

2021-01-21 Thread GitBox
jenskeiner commented on pull request #3308: URL: https://github.com/apache/apisix/pull/3308#issuecomment-764621696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] idbeta edited a comment on pull request #3365: test: add shell script for run APISIX testcases on ARM64

2021-01-21 Thread GitBox
idbeta edited a comment on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764201065 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #194: doc: Add Apache APISIX link in README

2021-01-21 Thread GitBox
tokers commented on a change in pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194#discussion_r561754424 ## File path: README.md ## @@ -21,7 +21,7 @@ [![Go Report

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1075: feat: show front-end e2e test report on PR's comment.

2021-01-21 Thread GitBox
juzhiyuan commented on issue #1075: URL: https://github.com/apache/apisix-dashboard/issues/1075#issuecomment-764509238 This issue is relying on Cypress's Write permission, which needs infra's reply. This is an automated

[GitHub] [apisix] membphis closed issue #1646: bug: limit-req in consumer is not work for grpc-proxy

2021-01-21 Thread GitBox
membphis closed issue #1646: URL: https://github.com/apache/apisix/issues/1646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis commented on issue #3344: feat: support gRPC over SSL

2021-01-21 Thread GitBox
membphis commented on issue #3344: URL: https://github.com/apache/apisix/issues/3344#issuecomment-764418234 I think we can fix this issue in milestone 2.3 (this month) @JanLi-air This is an automated message from the Apache

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #1308: test: Create Upstream in Route.

2021-01-21 Thread GitBox
moonming commented on a change in pull request #1308: URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561920602 ## File path: web/cypress/integration/route/create-route-with-upstream.spec.js ## @@ -93,7 +93,7 @@ context('Create Route with Upstream', () =>

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
liuxiran commented on a change in pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#discussion_r561648621 ## File path: api/test/e2e/import_test.go ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [apisix] tokers closed pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code

2021-01-21 Thread GitBox
tokers closed pull request #3382: URL: https://github.com/apache/apisix/pull/3382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1339: feat: add domSelector and data for search-route

2021-01-21 Thread GitBox
juzhiyuan merged pull request #1339: URL: https://github.com/apache/apisix-dashboard/pull/1339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on issue #3373: request help: The proxy-cache plugin overrides `Cache-Control` in upstream header.

2021-01-21 Thread GitBox
spacewander commented on issue #3373: URL: https://github.com/apache/apisix/issues/3373#issuecomment-764257035 ``` proxy_hide_header Cache-Control; proxy_hide_header Expires; add_header Cache-Control

[GitHub] [apisix-helm-chart] TkClark commented on a change in pull request #20: 修改Helm模板支持多etcdhost,添加默认反亲和

2021-01-21 Thread GitBox
TkClark commented on a change in pull request #20: URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r561792363 ## File path: chart/apisix/values.yaml ## @@ -188,5 +190,5 @@ nodeSelector: {} tolerations: [] -affinity: {} - +affinity: + enabled: true

[GitHub] [apisix-dashboard] LiteSun closed pull request #1341: test: user can skip upstream when select service_id

2021-01-21 Thread GitBox
LiteSun closed pull request #1341: URL: https://github.com/apache/apisix-dashboard/pull/1341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] membphis commented on issue #3340: How to do fuzz testing on Apache APISIX

2021-01-21 Thread GitBox
membphis commented on issue #3340: URL: https://github.com/apache/apisix/issues/3340#issuecomment-765061361 > The current test method of Apache APISIX pays more attention to normal input/output, in order to test the robustness of the program, fuzz testing can be used. I think you

[GitHub] [apisix-ingress-controller] tokers merged pull request #190: chore:add ginkgo check before e2e-test(apache #186)

2021-01-21 Thread GitBox
tokers merged pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1326: fix(fe): update url regexp in online debug

2021-01-21 Thread GitBox
juzhiyuan commented on a change in pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r561449442 ## File path: web/cypress/integration/route/online-debug.spec.js ## @@ -21,19 +21,20 @@ import defaultSettings from

[GitHub] [apisix] tokers commented on issue #3384: request help: unbalanced message in kafka partition using kafka-logger plugin

2021-01-21 Thread GitBox
tokers commented on issue #3384: URL: https://github.com/apache/apisix/issues/3384#issuecomment-764633660 > > Maybe we can reuse producer via lrucache, like this: > > > > > >

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1326: fix(fe): update url regexp in online debug

2021-01-21 Thread GitBox
liuxiran commented on pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764162784 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] spacewander commented on issue #3383: request help: how do i know plugin Orchestration condition variables

2021-01-21 Thread GitBox
spacewander commented on issue #3383: URL: https://github.com/apache/apisix/issues/3383#issuecomment-764439052 CC @juzhiyuan @nic-chen This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1334: test: switch language

2021-01-21 Thread GitBox
juzhiyuan merged pull request #1334: URL: https://github.com/apache/apisix-dashboard/pull/1334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on pull request #3308: feat: authz-keycloak plugin - dynamic scope and resource mapping.

2021-01-21 Thread GitBox
spacewander commented on pull request #3308: URL: https://github.com/apache/apisix/pull/3308#issuecomment-764195467 BTW, you can split the test into two files, like the https://github.com/apache/apisix/blob/master/t/plugin/limit-conn2.t. Since it is too big now.

[GitHub] [apisix] membphis commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
membphis commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287 please merge the code of master branch This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] tokers commented on issue #3336: feat: support to specify the scheme(http/https) in upstream

2021-01-21 Thread GitBox
tokers commented on issue #3336: URL: https://github.com/apache/apisix/issues/3336#issuecomment-764168873 It's more flexible if the scheme is defined for each node. This is an automated message from the Apache Git Service.

[GitHub] [apisix] spacewander merged pull request #3381: fix: markdownlint issue

2021-01-21 Thread GitBox
spacewander merged pull request #3381: URL: https://github.com/apache/apisix/pull/3381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] belongwqz commented on issue #3393: Plugin enhance

2021-01-21 Thread GitBox
belongwqz commented on issue #3393: URL: https://github.com/apache/apisix/issues/3393#issuecomment-765070054 > @belongwqz Actually you can use `serverless` plugin to customize your demand. All right, maybe we can give more examples in the `serverless` plugin documentation to show

[GitHub] [apisix-dashboard] membphis commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-21 Thread GitBox
membphis commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764226137 do we need to transfer this issue to APISIX? This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] nic-chen commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2021-01-21 Thread GitBox
nic-chen commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-765091552 not urgent, we could move to the next version This is an automated message from the Apache Git Service.

<    1   2   3   4   5   6   >