Firstsawyou commented on pull request #3382:
URL: https://github.com/apache/apisix/pull/3382#issuecomment-764661585
> Does the broken compatibility really no matter?
This will only affect some test cases.
This is an
Firstsawyou commented on pull request #3382:
URL: https://github.com/apache/apisix/pull/3382#issuecomment-764659792
> why change this？
I think the use of the 500 response code in the code is unreasonable,
because this is not caused by a code program error, but because there is no
guoqqqi commented on a change in pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561898842
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -93,7 +93,7 @@ context('Create Route with Upstream', () =>
juzhiyuan commented on issue #1345:
URL:
https://github.com/apache/apisix-dashboard/issues/1345#issuecomment-764653558
anyone would like to take this proposal?
This is an automated message from the Apache Git Service.
To
juzhiyuan opened a new issue #1345:
URL: https://github.com/apache/apisix-dashboard/issues/1345
_TODO_
anyone would like to take this proposal?
This is an automated message from the Apache Git Service.
To respond to
gxthrj merged pull request #196:
URL: https://github.com/apache/apisix-ingress-controller/pull/196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 25682fc refine the deployment
gxthrj commented on pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764650741
LGTM
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan commented on a change in pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561887871
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -93,7 +93,7 @@ context('Create Route with Upstream', ()
juzhiyuan commented on a change in pull request #1308:
URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561887414
##
File path: web/cypress/integration/route/create-route-with-upstream.spec.js
##
@@ -93,7 +93,7 @@ context('Create Route with Upstream', ()
moonming commented on pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20#issuecomment-764649196
@TkClark please use English in the public channel
This is an automated message from the Apache Git
juzhiyuan merged pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 6d7f11a align dashboard menu options to the left (#1338)
add f1a13ba test: switch language
juzhiyuan closed issue #1290:
URL: https://github.com/apache/apisix-dashboard/issues/1290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan commented on a change in pull request #1302:
URL: https://github.com/apache/apisix-dashboard/pull/1302#discussion_r561880801
##
File path: web/cypress/integration/route/create-route-can-skip-upstream.spec.js
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache
moonming commented on a change in pull request #3382:
URL: https://github.com/apache/apisix/pull/3382#discussion_r561885573
##
File path: apisix/upstream.lua
##
@@ -131,21 +131,21 @@ function _M.set_by_route(route, api_ctx)
local up_conf = api_ctx.matched_upstream
codecov-io commented on pull request #196:
URL:
https://github.com/apache/apisix-ingress-controller/pull/196#issuecomment-764647115
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/196?src=pr=h1)
Report
> Merging
FeynmanZhou commented on pull request #196:
URL:
https://github.com/apache/apisix-ingress-controller/pull/196#issuecomment-764645466
> @FeynmanZhou CI failed, a few markdown formats need to be tweaked. :)
Fixed
This
tokers commented on pull request #196:
URL:
https://github.com/apache/apisix-ingress-controller/pull/196#issuecomment-764642033
@FeynmanZhou CI failed, a few markdown formats need to be tweaked. :)
This is an automated
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 64029e0 feat: remove restriction of label
juzhiyuan merged pull request #3379:
URL: https://github.com/apache/apisix/pull/3379
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
juzhiyuan closed issue #3378:
URL: https://github.com/apache/apisix/issues/3378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
imjoey commented on pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764638880
> could we add a test case to verify that these events are really ignored?
@tokers sure, Thanks.
tokers commented on issue #3384:
URL: https://github.com/apache/apisix/issues/3384#issuecomment-764633660
> > Maybe we can reuse producer via lrucache, like this:
>
> >
>
> >
tokers commented on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-764630383
Ok, will add it as soon as Possible.
This is an automated message from the Apache Git Service.
To
tokers commented on pull request #3382:
URL: https://github.com/apache/apisix/pull/3382#issuecomment-764628665
Does the broken compatibility really no matter?
This is an automated message from the Apache Git Service.
To
tokers commented on pull request #196:
URL:
https://github.com/apache/apisix-ingress-controller/pull/196#issuecomment-764626385
@FeynmanZhou Thanks for your contribution!
This is an automated message from the Apache Git
tokers commented on pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764625660
could we add a test case to verify that these events are really ignored?
This is an automated message
jenskeiner commented on pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#issuecomment-764621696
> BTW, you can split the test into two files, like the
https://github.com/apache/apisix/blob/master/t/plugin/limit-conn2.t. Since it
is too big now.
done
codecov-io commented on pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764618036
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1344?src=pr=h1)
Report
> Merging
imjoey opened a new pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344
Signed-off-by: imjoey
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ]
FeynmanZhou edited a comment on pull request #195:
URL:
https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764610978
Updated https://github.com/apache/apisix-ingress-controller/pull/196
This is an
FeynmanZhou commented on pull request #195:
URL:
https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764610978
https://github.com/apache/apisix-ingress-controller/pull/196
This is an automated message
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561839068
##
File path: .github/workflows/lint.yml
##
@@ -1,6 +1,6 @@
name: ❄️ Lint
-on: [pull_request]
+on: [push, pull_request]
Review comment:
FeynmanZhou opened a new pull request #196:
URL: https://github.com/apache/apisix-ingress-controller/pull/196
Signed-off-by: FeynmanZhou
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature
Yiyiyimu commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-764605634
@idbeta How could we know that "not differ too much" would happen, or "they
are within an order of magnitude". Maybe we need some methods to get over those
false positives, but not
imjoey commented on issue #1329:
URL:
https://github.com/apache/apisix-dashboard/issues/1329#issuecomment-764591605
> > @nic-chen I'm afraid I cannot reproduce in my environment. Is the etcd
also newly installed? I guess there's something wrong with the data in etcd. So
could you please
codecov-io edited a comment on pull request #1334:
URL: https://github.com/apache/apisix-dashboard/pull/1334#issuecomment-762760524
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1334?src=pr=h1)
Report
> Merging
tokers merged pull request #195:
URL: https://github.com/apache/apisix-ingress-controller/pull/195
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new ff9fada doc: run ingress
membphis merged pull request #3366:
URL: https://github.com/apache/apisix/pull/3366
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 5e00a73 chore: update lua-resty-expr to v1.1.0 (#3386)
add 62b5f7c docs(traffic-split): update the vars
nic-chen commented on issue #1329:
URL:
https://github.com/apache/apisix-dashboard/issues/1329#issuecomment-764573055
> @nic-chen I'm afraid I cannot reproduce in my environment. Is the etcd
also newly installed? I guess there's something wrong with the data in etcd. So
could you please
membphis commented on pull request #3363:
URL: https://github.com/apache/apisix/pull/3363#issuecomment-764572425
ci failed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
membphis merged pull request #3386:
URL: https://github.com/apache/apisix/pull/3386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 5e00a73 chore: update lua-resty-expr to
TkClark commented on a change in pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r561792363
##
File path: chart/apisix/values.yaml
##
@@ -188,5 +190,5 @@ nodeSelector: {}
tolerations: []
-affinity: {}
-
+affinity:
+ enabled: true
spacewander commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764560217
May be fixed by https://github.com/apache/apisix/pull/2690
This is an automated message from the Apache Git
membphis commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561788165
##
File path: bin/apisix
##
@@ -1,36 +1,43 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or
gy09535 edited a comment on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764556332
> @gy09535
> Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379
--user=apisix: get --from-key /apisix/upstreams` doesn't have:
>
> ```
gy09535 commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764556332
> @gy09535
> Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379
--user=apisix: get --from-key /apisix/upstreams` doesn't have:
>
> ```
>
membphis commented on issue #3357:
URL: https://github.com/apache/apisix/issues/3357#issuecomment-764554659
> In addition, the Apache APISIX Admin needs to change the `host` to lower
case
this is not a good way I think
Fuchange commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561784037
##
File path: bin/apisix
##
@@ -1,36 +1,43 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or
membphis commented on pull request #1333:
URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-764554100
ping @tokers
This is an automated message from the Apache Git Service.
To respond to the message,
membphis commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764550918
> Hi @spacewander @starsz, do we have any quick ideas to export those test
cases from Lua?
I do not have a good idea for this job :(
membphis commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561775948
##
File path: .github/workflows/lint.yml
##
@@ -1,6 +1,6 @@
name: ❄️ Lint
-on: [pull_request]
+on: [push, pull_request]
Review comment:
why do
gxthrj commented on a change in pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r561778742
##
File path: chart/apisix/values.yaml
##
@@ -188,5 +190,5 @@ nodeSelector: {}
tolerations: []
-affinity: {}
-
+affinity:
+ enabled: true
membphis commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561774681
##
File path: bin/apisix
##
@@ -1,36 +1,43 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or
Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-764543546
> > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix,
can it solve your problem?
>
> let me try
You can refer to this document for
TkClark opened a new pull request #20:
URL: https://github.com/apache/apisix-helm-chart/pull/20
1. 更新etcd host 写入，支持多host
2. 修改etcd.port为etcd.default
3. 修改README.me
4. deployment添加默认的反亲和性
This is an automated
gy09535 commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764539213
> @gy09535
> Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379
--user=apisix: get --from-key /apisix/upstreams` doesn't have:
>
> ```
>
gy09535 commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764537267
> @gy09535
> Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379
--user=apisix: get --from-key /apisix/upstreams` doesn't have:
>
> ```
>
idbeta commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-764537188
> > ok, good idea, the performance of Github action will change a lot, I
tested it several times, QPS from `13300` to `21433`, so different.
>
> Wow that indeed differs a lot.
spacewander commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764536515
@gy09535
Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379
--user=apisix: get --from-key /apisix/upstreams` doesn't have:
```
gy09535 commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764532446
> This problem may have been fixed, you can try the latest version 2.2 .
which pr fix this ?
This is an
FeynmanZhou commented on pull request #195:
URL:
https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764530599
> @FeynmanZhou please take a look, thx
ok, thanks for including KubeSphere and Porter in this guide : )
spacewander commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561755538
##
File path: doc/plugins/authz-keycloak.md
##
@@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
Yiyiyimu commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-764530183
> ok, good idea, the performance of Github action will change a lot, I
tested it several times, QPS from `13300` to `21433`, so different.
Wow that indeed differs a lot. Would
tokers commented on a change in pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#discussion_r561754424
##
File path: README.md
##
@@ -21,7 +21,7 @@
[\.(png|jpg|js|css)$` in apisix, can
it solve your problem?
let me try
moonming commented on pull request #195:
URL:
https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764525766
@FeynmanZhou please take a look, thx
This is an automated message from the Apache Git
liuxiran commented on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764523735
> @liuxiran just for reference:
https://stackoverflow.com/questions/5717093/check-if-a-javascript-string-is-a-url
thanks a lot, I tried it, which covers all
idbeta commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-764523577
> The lowest result out of 5 test seems very easy to be surpassed. Maybe we
could test for like 100 times, get its distribution and try to set the
benchmark value
ok, good
tokers commented on pull request #195:
URL:
https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764522531
@gxthrj @moonming @membphis Please take a look when you have time.
This is an automated message
tokers opened a new pull request #195:
URL: https://github.com/apache/apisix-ingress-controller/pull/195
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
tzssangglass commented on issue #3384:
URL: https://github.com/apache/apisix/issues/3384#issuecomment-764521849
> Maybe we can reuse producer via lrucache, like this:
>
>
https://github.com/apache/apisix/blob/e5916cf541281e7fe756dd2e393bd6dcf702c220/apisix/plugins/limit-req.lua#L67
juzhiyuan commented on pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#issuecomment-764519898
@liuxiran just for reference:
https://stackoverflow.com/questions/5717093/check-if-a-javascript-string-is-a-url
fukiki commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-764519554
@membphis @tokers Please take a look when you have time.
This is an automated message from the Apache Git
Yiyiyimu commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-764518459
The lowest result out of 5 test seems very easy to be surpassed. Maybe we
could test for like 100 times, get its distribution and try to set the
benchmark value
liuxiran commented on a change in pull request #1326:
URL: https://github.com/apache/apisix-dashboard/pull/1326#discussion_r561741334
##
File path: web/cypress/integration/route/online-debug.spec.js
##
@@ -21,19 +21,20 @@ import defaultSettings from
codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1)
Report
> Merging
idbeta opened a new issue #3391:
URL: https://github.com/apache/apisix/issues/3391
### why
The current CI of apisix does not have performance testing. In order to
avoid the problem of performance degradation of apisix caused by some
modifications, it is necessary to increase the
codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1)
Report
> Merging
jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561735568
##
File path: t/plugin/authz-keycloak.t
##
@@ -137,7 +224,7 @@ done
"authz-keycloak": {
jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561735319
##
File path: apisix/plugins/authz-keycloak.lua
##
@@ -224,31 +275,326 @@ local function authz_keycloak_get_token_endpoint(conf)
end
-local
jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561734178
##
File path: doc/plugins/authz-keycloak.md
##
@@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561734178
##
File path: doc/plugins/authz-keycloak.md
##
@@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
Firstsawyou commented on issue #3389:
URL: https://github.com/apache/apisix/issues/3389#issuecomment-764511598
This problem may have been fixed, you can try the latest version 2.2 .
This is an automated message from the
fukiki commented on pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764510956
@gxthrj Please take a look when you have time.
This is an automated message from the Apache Git
jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561731105
##
File path: apisix/plugins/authz-keycloak.lua
##
@@ -171,13 +222,13 @@ local function authz_keycloak_discover(url, ssl_verify,
keepalive, timeout,
Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-764509337
Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it
solve your problem?
This is an
juzhiyuan commented on issue #1075:
URL:
https://github.com/apache/apisix-dashboard/issues/1075#issuecomment-764509238
This issue is relying on Cypress's Write permission, which needs infra's
reply.
This is an automated
jenskeiner commented on a change in pull request #3308:
URL: https://github.com/apache/apisix/pull/3308#discussion_r561729833
##
File path: doc/plugins/authz-keycloak.md
##
@@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak
Authorization Docs](https:/
codecov-io commented on pull request #194:
URL:
https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764508833
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=h1)
Report
> Merging
gewei2000 opened a new issue #3390:
URL: https://github.com/apache/apisix/issues/3390
### Issue description
does the `proxy_cache` plugin support static resource cache,
such as nginx config `location ~* /service_a/(.*)\.(png|jpg|js|css)$`
### Environment
* apisix version
fukiki opened a new pull request #194:
URL: https://github.com/apache/apisix-ingress-controller/pull/194
Signed-off-by: fukiki
Fix #193
- Why submit this pull request?
- [X] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
fukiki commented on issue #193:
URL:
https://github.com/apache/apisix-ingress-controller/issues/193#issuecomment-764505170
I will try it.
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan commented on issue #1279:
URL:
https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-764497539
no, I will take this.
This is an automated message from the Apache Git Service.
To respond to the
401 - 500 of 540 matches
Mail list logo
