Yiyiyimu commented on pull request #3482:
URL: https://github.com/apache/apisix/pull/3482#issuecomment-771445321
Hi @membphis it's actually an existing feature, that was temporarily removed
in #2101. And this PR is to re-add it.
Actually, I'm not sure about the meaning of printing init_e
wanghaisheng opened a new issue #3489:
URL: https://github.com/apache/apisix/issues/3489
as you all know graphql based bff is a special api gateway, I was
wondering is there anyone trying to build graphql bff based on apisix?
wanghaisheng opened a new issue #3488:
URL: https://github.com/apache/apisix/issues/3488
as you all know graphql based bff is a special api gateway, I was
wondering is there anyone trying to build graphql bff based on apisix?
Firstsawyou commented on pull request #2586:
URL: https://github.com/apache/apisix/pull/2586#issuecomment-771442289
Hi, @tashiya-menuri Do you need help?
This is an automated message from the Apache Git Service.
To respond
nic-chen commented on pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#issuecomment-771440904
@Jaycean
we should remove `Dockerfile-apisix` from this repo since we are downloading
it from `apisix-docker` repo
---
tokers commented on pull request #213:
URL:
https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-771439126
@Junnplus Please update your branch with the newest master, it fixed the
broken e2e case, after that, your PR can be merged :)
-
gxthrj merged pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new e1a85f1 fix: broken e2e test ca
codecov-io commented on pull request #224:
URL:
https://github.com/apache/apisix-ingress-controller/pull/224#issuecomment-771438286
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=h1)
Report
> Merging
[#224](https://codecov.io/gh/apache/apisix-ing
membphis commented on issue #3445:
URL: https://github.com/apache/apisix/issues/3445#issuecomment-771436928
> Although it can be processed by the redis cluster, the concurrency
supported by the redis cluster is limited. If it is necessary to process a
million level calls, how should it be
Jaycean commented on pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#issuecomment-771435853
At present, apisix-docker needs to modify Dockerfile because apisix needs to
modify luajit environment. After solving this problem, the CI of PR can pass.
Jaycean commented on a change in pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#discussion_r568379640
##
File path: .github/workflows/backend-e2e-test.yml
##
@@ -20,6 +20,11 @@ jobs:
with:
go-version: '1.13'
+ - name: do
tokers commented on pull request #224:
URL:
https://github.com/apache/apisix-ingress-controller/pull/224#issuecomment-771431431
@gxthrj @membphis Please take a look at this PR.
This is an automated message from the Apache Gi
tokers opened a new pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224
The image apache/apisix:dev was updated these two days, the status code when
upstream is not available was changed from 502 to 503, so the e2e case should
also be adjusted.
--
membphis commented on issue #3485:
URL: https://github.com/apache/apisix/issues/3485#issuecomment-771430491
Does anyone use HTTP2 in this way?
This is an automated message from the Apache Git Service.
To respond to the messag
juzhiyuan commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771430134
> docker-compose supports using context to load Dockerfile from remote git
repository.
Good to know this tip!
---
juzhiyuan commented on a change in pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#discussion_r568374373
##
File path: .github/workflows/backend-e2e-test.yml
##
@@ -20,6 +20,11 @@ jobs:
with:
go-version: '1.13'
+ - name:
tokers commented on pull request #213:
URL:
https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-771429063
@Junnplus Yes it can be, the broken e2e case is not related with the changes
in this PR. It should be fixed in another PR.
@gxthrj
-
juzhiyuan commented on a change in pull request #1408:
URL: https://github.com/apache/apisix-dashboard/pull/1408#discussion_r568373678
##
File path: api/test/e2e/info_test.go
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * cont
Junnplus commented on pull request #213:
URL:
https://github.com/apache/apisix-ingress-controller/pull/213#issuecomment-771426375
@gxthrj Can we merge this PR? cc @tokers
This is an automated message from the Apache Git Ser
idbeta opened a new pull request #3487:
URL: https://github.com/apache/apisix/pull/3487
### What this PR does / why we need it:
test: modify apisix path for centos7 ci
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
Jaycean commented on pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#issuecomment-771419491
> @Jaycean Hi, please try the way mentioned in [#1415
(comment)](https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771414595)
, we could remove the lo
imjoey commented on pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416#issuecomment-771417600
@Jaycean Hi, please try the way mentioned in
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771414595 ,
we could remove the local duplicated Dockerf
Jaycean opened a new pull request #1416:
URL: https://github.com/apache/apisix-dashboard/pull/1416
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backpor
imjoey commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771414595
> @nic-chen
> Thks.
> Then I'll submit a PR to modify Dockerfile-apisix later.
> Please assigne to me.
@Jaycean Regarding to the implementation, AFAIK, docker-
Yiyiyimu commented on a change in pull request #3472:
URL: https://github.com/apache/apisix/pull/3472#discussion_r568362869
##
File path: Makefile
##
@@ -55,7 +55,9 @@ help: default
.PHONY: deps
deps: default
ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luarocks)
starsz commented on a change in pull request #1408:
URL: https://github.com/apache/apisix-dashboard/pull/1408#discussion_r568358840
##
File path: api/internal/handler/tool/tool.go
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
Firstsawyou commented on issue #3486:
URL: https://github.com/apache/apisix/issues/3486#issuecomment-771402500
It would be better to provide relevant error log information.
This is an automated message from the Apache Git Ser
xyz101121 opened a new issue #3486:
URL: https://github.com/apache/apisix/issues/3486
1. apisix中的config.yaml已经配置dns_resolver
2.route配置的upstream
 were added to refs/heads/master by this push:
new ae48fa3 chore: change the modul
gxthrj merged pull request #220:
URL: https://github.com/apache/apisix-ingress-controller/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Jaycean commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771382631
@nic-chen
Thks.
Then I'll submit a PR to modify Dockerfile-apisix later.
Please assigne to me.
---
Jaycean commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771377570
@imjoey
There are two Dockerfiles in `apisix-dashborad`. One is used to build the
`manage-api`, and the other is used to build `apisix`.
`Apisix-docker` project i
Firstsawyou commented on issue #3474:
URL: https://github.com/apache/apisix/issues/3474#issuecomment-771376786
> Did kafka-logger support log_format Metadata?
>
>
https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/kafka-logger.md
The kafka-logger plugin does not su
gxthrj opened a new pull request #125:
URL: https://github.com/apache/apisix-docker/pull/125
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
nic-chen commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771375501
hi @Jaycean
Thanks.
`Dockerfile-apisix` can be used directly in this way, but
`Dockerfile-dashborad` requires an additional modification, which is to use the
local
imjoey commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771372034
@Jaycean thanks for reporting. It's reasonable for me. Could you please
introduce us the differences of the two Dockerfiles in this project and
apisix-docker project? Thanks
Jaycean commented on issue #1415:
URL:
https://github.com/apache/apisix-dashboard/issues/1415#issuecomment-771370909
ping @nic-chen @starsz @imjoey
This is an automated message from the Apache Git Service.
To respond to the
spacewander opened a new pull request #3484:
URL: https://github.com/apache/apisix/pull/3484
Fix #2495
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or w
tashiya-menuri commented on pull request #2586:
URL: https://github.com/apache/apisix/pull/2586#issuecomment-771365056
@membphis @Firstsawyou I will take a look on this.
This is an automated message from the Apache Git Servic
membphis commented on pull request #3483:
URL: https://github.com/apache/apisix/pull/3483#issuecomment-771344111
current image:
---
membphis opened a new pull request #3483:
URL: https://github.com/apache/apisix/pull/3483
### What this PR does / why we need it:
as title
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ]
mdh67899 commented on issue #3474:
URL: https://github.com/apache/apisix/issues/3474#issuecomment-771340253
Did kafka-logger support log_format Metadata?
https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/kafka-logger.md
mdh67899 removed a comment on issue #3474:
URL: https://github.com/apache/apisix/issues/3474#issuecomment-771339841
https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/kafka-logger.md
This is an automated message
mdh67899 commented on issue #3474:
URL: https://github.com/apache/apisix/issues/3474#issuecomment-771339841
https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/kafka-logger.md
This is an automated message from the
Yiyiyimu opened a new pull request #3482:
URL: https://github.com/apache/apisix/pull/3482
Signed-off-by: yiyiyimu
### What this PR does / why we need it:
fix #3242
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new featur
spacewander closed issue #2180:
URL: https://github.com/apache/apisix/issues/2180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander commented on issue #2180:
URL: https://github.com/apache/apisix/issues/2180#issuecomment-771337485
Look like we already support it.
We can use `$geoip` and the `var` in route.
This is an automated message from
spacewander commented on a change in pull request #3472:
URL: https://github.com/apache/apisix/pull/3472#discussion_r568301053
##
File path: Makefile
##
@@ -55,7 +55,9 @@ help: default
.PHONY: deps
deps: default
ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luaroc
tokers opened a new issue #223:
URL: https://github.com/apache/apisix-ingress-controller/issues/223
The current design about CRDs basically follows the configuration of [Apache
APISIX](http://apisix.apache.org/), i.e. ApisixRoute for Route, ApisixService
for Service and ApisixUpstream for
Yiyiyimu commented on a change in pull request #3472:
URL: https://github.com/apache/apisix/pull/3472#discussion_r568295463
##
File path: Makefile
##
@@ -55,7 +55,9 @@ help: default
.PHONY: deps
deps: default
ifeq ($(LUAROCKS_VER),luarocks 3.)
+ifeq ("$(wildcard ~/.luarocks)
123libohan commented on issue #3445:
URL: https://github.com/apache/apisix/issues/3445#issuecomment-771320247
> @123libohan What's the quota you mentioned above? Is the limited QPS?
Yes, if it is in a cluster environment, it is impossible to guarantee the
control of the total transfe
123libohan removed a comment on issue #3445:
URL: https://github.com/apache/apisix/issues/3445#issuecomment-771320067
Yes, if it is in a cluster environment, it is impossible to guarantee the
control of the total transfer amount
123libohan commented on issue #3445:
URL: https://github.com/apache/apisix/issues/3445#issuecomment-771320067
Yes, if it is in a cluster environment, it is impossible to guarantee the
control of the total transfer amount
Thi
Jaycean opened a new issue #1415:
URL: https://github.com/apache/apisix-dashboard/issues/1415
# Feature request
## Please describe your feature
At present, the Dockfile and Dockerfile-apisix in the dashboard are
maintained locally. Two days ago, the relevant dependencies of ap
membphis merged pull request #3467:
URL: https://github.com/apache/apisix/pull/3467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b033a75 chore: sync install-dependencies.md &
spacewander edited a comment on issue #3480:
URL: https://github.com/apache/apisix/issues/3480#issuecomment-771305795
Please read the doc:
https://github.com/apache/apisix/blob/master/doc/plugins/proxy-rewrite.md, and
its example of `headers`.
And you also need to read the doc of `m
Firstsawyou commented on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-771310231
> > Based on the information provided, your problem cannot be determined.
You should provide a complete usage example.
> > e.g.:
> > curl http://127.0.0.1:9080/apisix/admin/u
spacewander commented on issue #3480:
URL: https://github.com/apache/apisix/issues/3480#issuecomment-771305795
Please read the doc:
https://github.com/apache/apisix/blob/master/doc/plugins/proxy-rewrite.md, and
its example of `headers`.
And you also need to read the doc of `more_set
spacewander opened a new pull request #3481:
URL: https://github.com/apache/apisix/pull/3481
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new featu
hnlq715 commented on issue #3478:
URL: https://github.com/apache/apisix/issues/3478#issuecomment-771301018
Seems like keep alive works...close this issue
This is an automated message from the Apache Git Service.
To respond to
hnlq715 closed issue #3478:
URL: https://github.com/apache/apisix/issues/3478
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
juzhiyuan edited a comment on issue #1407:
URL:
https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-771299792
This is an automated message from the Apache Git Service.
To respond to the message, please log on
juzhiyuan commented on issue #1407:
URL:
https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-771299792
Ya! @vinayaksh42 Would u like to contribute to Japanese?
This is an automated message from the Apache Git
Junnplus commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568276235
##
File path: README.md
##
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
see
https://github.com/apa
sandy420 opened a new issue #3480:
URL: https://github.com/apache/apisix/issues/3480
e.g.:
This is my configuration in nginx,and How to implement the header set in
nginx in Apisix:
location = / {
more_set_input_headers "Host:qastatic.56qq.com";
proxy_pass http://qas
juzhiyuan commented on pull request #1413:
URL: https://github.com/apache/apisix-dashboard/pull/1413#issuecomment-771298373
waiting for testcase
This is an automated message from the Apache Git Service.
To respond to the mess
juzhiyuan commented on a change in pull request #1414:
URL: https://github.com/apache/apisix-dashboard/pull/1414#discussion_r568275012
##
File path: web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
##
@@ -63,16 +65,18 @@ context('Create and Delete Plugin List',
sandy420 commented on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-771292923
>
>
> Based on the information provided, your problem cannot be determined. You
should provide a complete usage example.
e.g.:
curl http://127.0.0.1:9080/apisix/admin/up
moonming commented on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-771291987
ping @Firstsawyou
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander opened a new issue #3479:
URL: https://github.com/apache/apisix/issues/3479
See https://github.com/apache/apisix/pull/3308#discussion_r563283583
This is an automated message from the Apache Git Service.
To respond
spacewander merged pull request #3476:
URL: https://github.com/apache/apisix/pull/3476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 0b22938 chore: should exclude utils/ from
juzhiyuan commented on pull request #1402:
URL: https://github.com/apache/apisix-dashboard/pull/1402#issuecomment-771287903
@guoqqqi LGTM, and please add test cases for this PR.
This is an automated message from the Apache Gi
hnlq715 opened a new issue #3478:
URL: https://github.com/apache/apisix/issues/3478
### Issue description
### Environment
* apisix version (cmd: `apisix version`):
```
master branch
```
* OS (cmd: `uname -a`):
```
```
* OpenResty / Nginx version (cmd: `ngi
juzhiyuan commented on a change in pull request #1402:
URL: https://github.com/apache/apisix-dashboard/pull/1402#discussion_r568265974
##
File path: web/src/components/Plugin/PluginDetail.tsx
##
@@ -35,8 +35,10 @@ import { LinkOutlined } from '@ant-design/icons';
import Ajv fr
liuxiran commented on pull request #1414:
URL: https://github.com/apache/apisix-dashboard/pull/1414#issuecomment-771284158
https://github.com/apache/apisix-dashboard/pull/1414/checks?check_run_id=1811238315
This is an automa
liuxiran commented on pull request #1413:
URL: https://github.com/apache/apisix-dashboard/pull/1413#issuecomment-771283437
it worked well when I ran this pr locally :100:
how about add to a test case to cover this situation?
-
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568253049
##
File path: README.md
##
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
It's also required for dashbo
tokers commented on a change in pull request #27:
URL: https://github.com/apache/apisix-helm-chart/pull/27#discussion_r568252751
##
File path: README.md
##
@@ -19,63 +19,4 @@
# Apache APISIX Helm Charts
-## Dependencies
Review comment:
Even so, link is necessary.
spacewander closed issue #2532:
URL: https://github.com/apache/apisix/issues/2532
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander merged pull request #3442:
URL: https://github.com/apache/apisix/pull/3442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 563b259 feat: switch resolver to lua-resty
liuxiran commented on issue #1410:
URL:
https://github.com/apache/apisix-dashboard/issues/1410#issuecomment-771257085
> fixed? @liuxiran
I have submitted a pr, it may be due to the interaction between loop
operations
a few more CI runs are needed to test whether the solution is
vinayaksh42 commented on issue #1407:
URL:
https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-771055148
Does this issue require Japanese and german language prior knowledge?
This is an automated message from
liuxiran commented on pull request #1414:
URL: https://github.com/apache/apisix-dashboard/pull/1414#issuecomment-771049377
https://github.com/apache/apisix-dashboard/pull/1414/checks?check_run_id=1808679183
This is an automa
liuxiran opened a new pull request #1414:
URL: https://github.com/apache/apisix-dashboard/pull/1414
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backpo
Firstsawyou opened a new issue #3477:
URL: https://github.com/apache/apisix/issues/3477
# Improve Docs
## Please describe which part of docs should be improved or typo fixed
The metrics of the Prometheus document are inconsistent with the metrics of
the current plugin.
We n
guoqqqi opened a new pull request #1413:
URL: https://github.com/apache/apisix-dashboard/pull/1413
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backpor
moonming commented on issue #3475:
URL: https://github.com/apache/apisix/issues/3475#issuecomment-770963887
> > Why not use the `http_status` metric? it has the matched_host label and
i think we can aggregate by this label.
>
>
>
> I'm very sorry, I only read the documentatio
Firstsawyou commented on issue #3475:
URL: https://github.com/apache/apisix/issues/3475#issuecomment-770953139
There is already a `matched_host` metric.
This is an automated message from the Apache Git Service.
To respond to
Firstsawyou closed issue #3475:
URL: https://github.com/apache/apisix/issues/3475
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Firstsawyou commented on issue #3475:
URL: https://github.com/apache/apisix/issues/3475#issuecomment-770937675
> Why not use the `http_status` metric? it has the matched_host label and i
think we can aggregate by this label.
I'm very sorry, I only read the documentation, not the code
moonming commented on issue #1165:
URL:
https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-770926932
When packaging, write a separate version file, which is a json string, is
this ok?
We are only responsible for the packaged version
-
This is an automated email from the ASF dual-hosted git repository.
majunjie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 6e98820 fix: Minor problems left (#
imjoey closed issue #1023:
URL: https://github.com/apache/apisix-dashboard/issues/1023
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
1 - 100 of 196 matches
Mail list logo
