[GitHub] [apisix] Firstsawyou commented on issue #3516: request help:

2021-02-04 Thread GitBox
Firstsawyou commented on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-773853290 > 参考测试用例执行,缺少 issuedFor,该值指的是什么? > {"error":"invalid_request","error_description":"You must provide the issuedFor"} It looks like your request is abnormal and you need to

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #162: fix: update CD configuration

2021-02-04 Thread GitBox
juzhiyuan commented on a change in pull request #162: URL: https://github.com/apache/apisix-website/pull/162#discussion_r570769598 ## File path: .github/workflows/deploy.yml ## @@ -23,30 +23,13 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job ca

[GitHub] [apisix] hnlq715 edited a comment on issue #3502: request help: any point to improve grpc transcode performance?

2021-02-04 Thread GitBox
hnlq715 edited a comment on issue #3502: URL: https://github.com/apache/apisix/issues/3502#issuecomment-773845176 1. do not use for loop https://github.com/apache/apisix/blob/53c7aba023d4119fa688919e726e1f73cb6ec71e/apisix/plugins/grpc-transcode/util.lua#L94 2. find_method can be impr

[GitHub] [apisix] gzhsnail commented on pull request #3345: feat: allow getting health check status via control API

2021-02-04 Thread GitBox
gzhsnail commented on pull request #3345: URL: https://github.com/apache/apisix/pull/3345#issuecomment-773847221 Is it possible to view the results of health examination now? 请问现在是已经可以查看到健康检查的结果了吗? This is an automated mes

[GitHub] [apisix] hnlq715 edited a comment on issue #3502: request help: any point to improve grpc transcode performance?

2021-02-04 Thread GitBox
hnlq715 edited a comment on issue #3502: URL: https://github.com/apache/apisix/issues/3502#issuecomment-773845176 1. https://github.com/apache/apisix/blob/53c7aba023d4119fa688919e726e1f73cb6ec71e/apisix/plugins/grpc-transcode/util.lua#L94 2. find_method can be improved with map https://

[GitHub] [apisix] hnlq715 commented on issue #3502: request help: any point to improve grpc transcode performance?

2021-02-04 Thread GitBox
hnlq715 commented on issue #3502: URL: https://github.com/apache/apisix/issues/3502#issuecomment-773845176 https://github.com/apache/apisix/blob/master/apisix/plugins/grpc-transcode/util.lua#L94 This is an automated

[GitHub] [apisix] diaosj closed issue #3526: request help: Can I drop requests from Prometheus in access.log?

2021-02-04 Thread GitBox
diaosj closed issue #3526: URL: https://github.com/apache/apisix/issues/3526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix] diaosj commented on issue #3526: request help: Can I drop requests from Prometheus in access.log?

2021-02-04 Thread GitBox
diaosj commented on issue #3526: URL: https://github.com/apache/apisix/issues/3526#issuecomment-773844108 > Since Nginx doesn't support disabling access log on the fly, AFAIK there is no way to do that. > Previously I solved this problem at the collector side, like skipping special UA/p

[GitHub] [apisix-website] liuxiran commented on a change in pull request #162: fix: update CD configuration

2021-02-04 Thread GitBox
liuxiran commented on a change in pull request #162: URL: https://github.com/apache/apisix-website/pull/162#discussion_r570762889 ## File path: .github/workflows/deploy.yml ## @@ -23,30 +23,13 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can

[GitHub] [apisix] Firstsawyou commented on issue #3528: request help: Why ip-restriction return json instead of default 403 error page

2021-02-04 Thread GitBox
Firstsawyou commented on issue #3528: URL: https://github.com/apache/apisix/issues/3528#issuecomment-773839088 I think it is reasonable to return json. As a gateway, apisix does not need to care about these web pages, this is not what it should focus on. You can display related pages based

[GitHub] [apisix] hnlq715 edited a comment on issue #3502: request help: any point to improve grpc transcode performance?

2021-02-04 Thread GitBox
hnlq715 edited a comment on issue #3502: URL: https://github.com/apache/apisix/issues/3502#issuecomment-773833685 @membphis @tokers After recompile the nginx binary with `--without-luajit-gc64`, I generate the lua land flamegraph. * grpc transcode [apisix-lua-land.svg.gz](https:/

[GitHub] [apisix] spacewander commented on issue #3528: request help: Why ip-restriction return json instead of default 403 error page

2021-02-04 Thread GitBox
spacewander commented on issue #3528: URL: https://github.com/apache/apisix/issues/3528#issuecomment-773836896 As an API gateway, we prefer to communicate via HTTP+JSON instead of plain HTML. This is an automated message fro

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1315: feat: refactor route unit test

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1315: URL: https://github.com/apache/apisix-dashboard/pull/1315#discussion_r570757422 ## File path: api/internal/handler/route/route_test.go ## @@ -14,1743 +14,1421 @@ * See the License for the specific language governing permissi

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1432: chore: added global files to contain test selector mappers and public data

2021-02-04 Thread GitBox
guoqqqi commented on pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#issuecomment-773834314 All right. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] hnlq715 commented on issue #3502: request help: any point to improve grpc transcode performance?

2021-02-04 Thread GitBox
hnlq715 commented on issue #3502: URL: https://github.com/apache/apisix/issues/3502#issuecomment-773833685 @membphis @tokers After recompile the nginx binary with `--without-luajit-gc64`, I generate the lua land flamegraph. [apisix-lua-land.svg.gz](https://github.com/apache/apisix/f

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1432: chore: added global files to contain test selector mappers and public data

2021-02-04 Thread GitBox
guoqqqi commented on a change in pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#discussion_r570755027 ## File path: web/cypress/fixtures/selector.json ## @@ -1,49 +1,46 @@ { - "switcher": ".ant-space-align-center", + "languageSwitcher": ".ant-s

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1319: chore: introduce ginkgo framework for backend E2E testing

2021-02-04 Thread GitBox
codecov-io edited a comment on pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#issuecomment-761824342 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1319?src=pr&el=h1) Report > Merging [#1319](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1432: chore: added global files to contain test selector mappers and public data

2021-02-04 Thread GitBox
juzhiyuan commented on pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#issuecomment-773831809 NOT: all reusable variables、selectors This is an automated message from the Apache Git Service. To re

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1432: chore: added global files to contain test selector mappers and public data

2021-02-04 Thread GitBox
guoqqqi commented on pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#issuecomment-773830951 > This PR looks good to me, but I have a question to confirm, if a selector is not public, should we extract a variable in that case? @guoqqqi I think we'd better

[GitHub] [apisix] nanamikon opened a new issue #3528: request help: Why ip-restriction return json instead of default 403 error page

2021-02-04 Thread GitBox
nanamikon opened a new issue #3528: URL: https://github.com/apache/apisix/issues/3528 ### Issue description ip-restriction will return json when the remote ip matches blacklist ``` {"message":"Your IP address is not allowed"} ``` I think default 403 error page will be bett

[GitHub] [apisix-dashboard] imjoey commented on pull request #1424: feat: support IP allow list

2021-02-04 Thread GitBox
imjoey commented on pull request #1424: URL: https://github.com/apache/apisix-dashboard/pull/1424#issuecomment-773822305 @nic-chen This is a great and useful feature for users. How about add relevant docs in user guide? Thanks. -

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1315: feat: refactor route unit test

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1315: URL: https://github.com/apache/apisix-dashboard/pull/1315#discussion_r570745494 ## File path: api/internal/handler/route/route_test.go ## @@ -14,1743 +14,1421 @@ * See the License for the specific language governing permissi

[GitHub] [apisix] nanamikon commented on issue #3518: request help: vars_combinations can not work

2021-02-04 Thread GitBox
nanamikon commented on issue #3518: URL: https://github.com/apache/apisix/issues/3518#issuecomment-773818944 Refer to https://github.com/apache/apisix/issues/3261 and https://github.com/apache/apisix/releases/tag/2.2 I think 2.2 does not support vars_combinations , master branch may be

[GitHub] [apisix-dashboard] starsz commented on pull request #1420: feat: added support for -c to set the config file path

2021-02-04 Thread GitBox
starsz commented on pull request #1420: URL: https://github.com/apache/apisix-dashboard/pull/1420#issuecomment-773818747 Hi, @vinayaksh42 Maybe you should fix the conflict and sync the master branch. This is an automated m

[GitHub] [apisix] tongorz edited a comment on issue #3503: Question: How to select dynamic upstream by url path or url parameter ?

2021-02-04 Thread GitBox
tongorz edited a comment on issue #3503: URL: https://github.com/apache/apisix/issues/3503#issuecomment-773817342 > @tongorz It looks like you wanna proxy to the IP which specified in the parameter? Yes. I want all traffic to https://Server_IPMI_IP:443 go through proxy server first.

[GitHub] [apisix] tongorz edited a comment on issue #3503: Question: How to select dynamic upstream by url path or url parameter ?

2021-02-04 Thread GitBox
tongorz edited a comment on issue #3503: URL: https://github.com/apache/apisix/issues/3503#issuecomment-773817342 > @tongorz It looks like you wanna proxy to the IP which specified in the parameter? Yes. I want all traffic to http://Server_IPMI_IP:443 go through proxy server first.

[GitHub] [apisix] tongorz commented on issue #3503: Question: How to select dynamic upstream by url path or url parameter ?

2021-02-04 Thread GitBox
tongorz commented on issue #3503: URL: https://github.com/apache/apisix/issues/3503#issuecomment-773817342 > @tongorz It looks like you wanna proxy to the IP which specified in the parameter? Yes. I want all traffic to IPMI WEB of Servers go through proxy server first.

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1432: chore: added global files to contain test selector mappers and public data

2021-02-04 Thread GitBox
juzhiyuan commented on pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#issuecomment-773815046 don't forget to sync codes from the master branch. This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1424: feat: support IP allow list

2021-02-04 Thread GitBox
nic-chen commented on a change in pull request #1424: URL: https://github.com/apache/apisix-dashboard/pull/1424#discussion_r570741234 ## File path: api/internal/conf/conf.go ## @@ -43,7 +43,7 @@ var ( ENV string Schema gjson.Result

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1432: chore: added global files to contain test selector mappers and public data

2021-02-04 Thread GitBox
juzhiyuan commented on a change in pull request #1432: URL: https://github.com/apache/apisix-dashboard/pull/1432#discussion_r570740379 ## File path: web/cypress/fixtures/selector.json ## @@ -1,49 +1,46 @@ { - "switcher": ".ant-space-align-center", + "languageSwitcher": ".ant

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1319: chore: introduce ginkgo framework for backend E2E testing

2021-02-04 Thread GitBox
nic-chen commented on pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#issuecomment-773814684 @membphis license check result: ``` github.com/yudai/gojsondiff,https://github.com/yudai/gojsondiff/blob/master/LICENSE,MIT github.com/nxadm/tail,https://gith

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
juzhiyuan commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570740069 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) err

[GitHub] [apisix-dashboard] starsz commented on pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
starsz commented on pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773812399 > /lgtm Thank you for your code review. 😄 This is an automated message from the Apache Git Servic

[GitHub] [apisix-dashboard] starsz merged pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
starsz merged pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated (57c9d94 -> 4577740)

2021-02-04 Thread starsz
This is an automated email from the ASF dual-hosted git repository. starsz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 57c9d94 feat: add a tool to check the version of APISIX Dashboard for release (#1418) add 4577740 f

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
imjoey commented on a change in pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570739032 ## File path: api/internal/utils/consts/versionMap.go ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570738755 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) error

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570738755 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) error

[GitHub] [apisix] juzhiyuan opened a new issue #3527: Add "APISIX Helm Charts" to "Good first issue" section

2021-02-04 Thread GitBox
juzhiyuan opened a new issue #3527: URL: https://github.com/apache/apisix/issues/3527 # Improve Docs ## Please describe which part of docs should be improved or typo fixed Anyone could help to add `APISIX Helm Charts Good first issue[1]` to README? ## Describe the soluti

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570737662 ## File path: api/internal/utils/consts/versionMap.go ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1315: feat: refactor route unit test

2021-02-04 Thread GitBox
imjoey commented on a change in pull request #1315: URL: https://github.com/apache/apisix-dashboard/pull/1315#discussion_r570736116 ## File path: api/internal/handler/route/route_test.go ## @@ -14,1743 +14,1421 @@ * See the License for the specific language governing permissi

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
imjoey commented on a change in pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570735124 ## File path: api/internal/utils/consts/versionMap.go ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
juzhiyuan commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570734642 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) err

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1424: feat: support IP allow list

2021-02-04 Thread GitBox
codecov-io edited a comment on pull request #1424: URL: https://github.com/apache/apisix-dashboard/pull/1424#issuecomment-773727651 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1424?src=pr&el=h1) Report > Merging [#1424](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
juzhiyuan commented on pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773805734 need more members to review this PR. This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] nic-chen closed issue #961: feat: need a tool to check version before release

2021-02-04 Thread GitBox
nic-chen closed issue #961: URL: https://github.com/apache/apisix-dashboard/issues/961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen merged pull request #1418: feat: add a tool to check the version of APISIX Dashboard for release

2021-02-04 Thread GitBox
nic-chen merged pull request #1418: URL: https://github.com/apache/apisix-dashboard/pull/1418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: feat: add a tool to check the version of APISIX Dashboard for release (#1418)

2021-02-04 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 57c9d94 feat: add a tool to check

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1315: feat: refactor route unit test

2021-02-04 Thread GitBox
Jaycean commented on a change in pull request #1315: URL: https://github.com/apache/apisix-dashboard/pull/1315#discussion_r570726674 ## File path: api/internal/handler/route/route_test.go ## @@ -14,1743 +14,1421 @@ * See the License for the specific language governing permiss

[GitHub] [apisix-ingress-controller] tokers opened a new issue #241: Support Kubernetes Ingress resources

2021-02-04 Thread GitBox
tokers opened a new issue #241: URL: https://github.com/apache/apisix-ingress-controller/issues/241 We shall have the capability to watch [Ingress resources](https://kubernetes.io/docs/concepts/services-networking/ingress/) and convert them to APISIX resources like Routes and Upstreams.

[GitHub] [apisix-dashboard] Jaycean commented on issue #1332: feat: Improve testing coverage for the POST and PATCH methods of the resources

2021-02-04 Thread GitBox
Jaycean commented on issue #1332: URL: https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-773785492 issue: #1161 Planned unit test refactoring of ssl,route,upstream,service. Unit testing of the patch method will be added.

[GitHub] [apisix-dashboard] starsz closed issue #1405: ManagerAPI should support -v to get the version and git hash.

2021-02-04 Thread GitBox
starsz closed issue #1405: URL: https://github.com/apache/apisix-dashboard/issues/1405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] starsz merged pull request #1431: feat: support -v command to show version

2021-02-04 Thread GitBox
starsz merged pull request #1431: URL: https://github.com/apache/apisix-dashboard/pull/1431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated (61d8118 -> eaa6a73)

2021-02-04 Thread starsz
This is an automated email from the ASF dual-hosted git repository. starsz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 61d8118 fix: change the /version to /apisix/admin/tool/version (#1429) add eaa6a73 feat: support -v

[GitHub] [apisix-dashboard] Jaycean closed pull request #1423: chore: add ssl PATCH method unit test

2021-02-04 Thread GitBox
Jaycean closed pull request #1423: URL: https://github.com/apache/apisix-dashboard/pull/1423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1423: chore: add ssl PATCH method unit test

2021-02-04 Thread GitBox
Jaycean commented on pull request #1423: URL: https://github.com/apache/apisix-dashboard/pull/1423#issuecomment-773784025 This PR is closed first, and then re open a new pr. This is an automated message from the Apache Git Se

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1423: chore: add ssl PATCH method unit test

2021-02-04 Thread GitBox
Jaycean edited a comment on pull request #1423: URL: https://github.com/apache/apisix-dashboard/pull/1423#issuecomment-773783342 > > ping @starsz > > Hi, I was adding the unit test of patch method before, but I see that you are refactoring the unit test. Have you started the unit test of

[GitHub] [apisix-dashboard] starsz merged pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
starsz merged pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated (661e48f -> 61d8118)

2021-02-04 Thread starsz
This is an automated email from the ASF dual-hosted git repository. starsz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 661e48f feat: remove the etcd dependency in the service unit test add 61d8118 fix: change the /versi

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570716879 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) error

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1423: chore: add ssl PATCH method unit test

2021-02-04 Thread GitBox
Jaycean commented on pull request #1423: URL: https://github.com/apache/apisix-dashboard/pull/1423#issuecomment-773783342 > > ping @starsz > > Hi, I was adding the unit test of patch method before, but I see that you are refactoring the unit test. Have you started the unit test of SSL? I

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570716382 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) error

[GitHub] [apisix-dashboard] starsz commented on pull request #1423: chore: add ssl PATCH method unit test

2021-02-04 Thread GitBox
starsz commented on pull request #1423: URL: https://github.com/apache/apisix-dashboard/pull/1423#issuecomment-773782762 > ping @starsz > Hi, I was adding the unit test of patch method before, but I see that you are refactoring the unit test. Have you started the unit test of SSL? If it

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1423: chore: add ssl PATCH method unit test

2021-02-04 Thread GitBox
Jaycean commented on pull request #1423: URL: https://github.com/apache/apisix-dashboard/pull/1423#issuecomment-773780729 ping @starsz Hi, I was adding the unit test of patch method before, but I see that you are refactoring the unit test. Have you started the unit test of SSL? If it h

[GitHub] [apisix-dashboard] Jaycean closed pull request #1422: chore: add route PATCH mothed unit test

2021-02-04 Thread GitBox
Jaycean closed pull request #1422: URL: https://github.com/apache/apisix-dashboard/pull/1422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1422: chore: add route PATCH mothed unit test

2021-02-04 Thread GitBox
Jaycean commented on pull request #1422: URL: https://github.com/apache/apisix-dashboard/pull/1422#issuecomment-773779945 PR #1315 refactor route unit test,This PR close This is an automated message from the Apache Git Servic

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
tokers commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570712580 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) error

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
juzhiyuan commented on pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#issuecomment-773775629 ping @tokers @imjoey 's help to review codes. This is an automated message from the Apache Git Servic

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1429: fix: change the /version to /apisix/admin/tool/version

2021-02-04 Thread GitBox
juzhiyuan commented on a change in pull request #1429: URL: https://github.com/apache/apisix-dashboard/pull/1429#discussion_r570709552 ## File path: api/internal/filter/authentication.go ## @@ -45,50 +45,55 @@ func (mw *AuthenticationMiddleware) Handle(ctx droplet.Context) err

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1430: feat: add version match API

2021-02-04 Thread GitBox
starsz commented on a change in pull request #1430: URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570707626 ## File path: api/internal/handler/tool/tool.go ## @@ -17,28 +17,48 @@ package tool import ( + "net/http" + "github.com/gin-goni

[GitHub] [apisix-dashboard] starsz merged pull request #1169: feat: remove the etcd dependency in the service unit test

2021-02-04 Thread GitBox
starsz merged pull request #1169: URL: https://github.com/apache/apisix-dashboard/pull/1169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated: feat: remove the etcd dependency in the service unit test

2021-02-04 Thread starsz
This is an automated email from the ASF dual-hosted git repository. starsz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 661e48f feat: remove the etcd depende

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1424: feat: support IP allow list

2021-02-04 Thread GitBox
codecov-io edited a comment on pull request #1424: URL: https://github.com/apache/apisix-dashboard/pull/1424#issuecomment-773727651 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1424?src=pr&el=h1) Report > Merging [#1424](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander closed issue #3520: request help:

2021-02-04 Thread GitBox
spacewander closed issue #3520: URL: https://github.com/apache/apisix/issues/3520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] cocoonYh edited a comment on issue #3524: bug: apisix cant find upstream and return 500

2021-02-04 Thread GitBox
cocoonYh edited a comment on issue #3524: URL: https://github.com/apache/apisix/issues/3524#issuecomment-773766830 > It is very similar to the problem here and may have been fixed: > #3342 > #3339 > > Try to configure another host, will this problem still occur? > > ```

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1319: chore: introduce ginkgo framework for backend E2E testing

2021-02-04 Thread GitBox
codecov-io edited a comment on pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#issuecomment-761824342 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1319?src=pr&el=h1) Report > Merging [#1319](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] cocoonYh closed issue #3524: bug: apisix cant find upstream and return 500

2021-02-04 Thread GitBox
cocoonYh closed issue #3524: URL: https://github.com/apache/apisix/issues/3524 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] cocoonYh commented on issue #3524: bug: apisix cant find upstream and return 500

2021-02-04 Thread GitBox
cocoonYh commented on issue #3524: URL: https://github.com/apache/apisix/issues/3524#issuecomment-773766830 > It is very similar to the problem here and may have been fixed: > #3342 > #3339 > > Try to configure another host, will this problem still occur? > > ``` > "no

[GitHub] [apisix] spacewander commented on issue #3526: request help: Can I drop requests from Prometheus in access.log?

2021-02-04 Thread GitBox
spacewander commented on issue #3526: URL: https://github.com/apache/apisix/issues/3526#issuecomment-773764929 Since Nginx doesn't support disabling access log on the fly, AFAIK there is no way to do that. Previously I solved this problem at the collector side, like skipping special UA/

[GitHub] [apisix] hnlq715 commented on issue #3502: request help: any point to improve grpc transcode performance?

2021-02-04 Thread GitBox
hnlq715 commented on issue #3502: URL: https://github.com/apache/apisix/issues/3502#issuecomment-773761123 @tokers still ``` sudo ./stap++ samples/lj-lua-bt.sxx -x 1239 Found exact match for libluajit: /usr/local/openresty/luajit/lib/libluajit-5.1.so.2.1.0 semantic error: u

[GitHub] [apisix] Firstsawyou commented on issue #3524: bug: apisix cant find upstream and return 500

2021-02-04 Thread GitBox
Firstsawyou commented on issue #3524: URL: https://github.com/apache/apisix/issues/3524#issuecomment-773759363 It is very similar to the problem here and may have been fixed: https://github.com/apache/apisix/issues/3342 https://github.com/apache/apisix/issues/3339 Try to confi

[GitHub] [apisix-ingress-controller] tokers commented on pull request #236: chore: new apisix upstream controller

2021-02-04 Thread GitBox
tokers commented on pull request #236: URL: https://github.com/apache/apisix-ingress-controller/pull/236#issuecomment-773756033 @gxthrj @membphis Please take a look when you have time :) This is an automated message from the

[GitHub] [apisix] diaosj opened a new issue #3526: request help: Can I drop requests from Prometheus in access.log?

2021-02-04 Thread GitBox
diaosj opened a new issue #3526: URL: https://github.com/apache/apisix/issues/3526 ### Issue description I enable the Prometheus plugin and the `access.log` file is filled with requests from Prometheus. ``` {"remote_addr":"","time_local":"05/Feb/2021:11:11:10 +0800","http_host":""

[GitHub] [apisix-website] imjoey commented on a change in pull request #162: fix: update CD configuration

2021-02-04 Thread GitBox
imjoey commented on a change in pull request #162: URL: https://github.com/apache/apisix-website/pull/162#discussion_r570690945 ## File path: .github/workflows/deploy.yml ## @@ -23,30 +23,13 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #240: chore: optimized the log for waiting cache sync, and other event details

2021-02-04 Thread GitBox
tokers opened a new pull request #240: URL: https://github.com/apache/apisix-ingress-controller/pull/240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] idbeta closed pull request #3365: test: add shell script for run APISIX testcases on ARM64

2021-02-04 Thread GitBox
idbeta closed pull request #3365: URL: https://github.com/apache/apisix/pull/3365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[apisix-ingress-controller] branch master updated: chore: remove ApisixService CRD (#230)

2021-02-04 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 0b15c20 chore: remove Apisix

[GitHub] [apisix-ingress-controller] tokers merged pull request #230: chore: remove ApisixService CRD

2021-02-04 Thread GitBox
tokers merged pull request #230: URL: https://github.com/apache/apisix-ingress-controller/pull/230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1169: feat: remove the etcd dependency in the service unit test

2021-02-04 Thread GitBox
codecov-io edited a comment on pull request #1169: URL: https://github.com/apache/apisix-dashboard/pull/1169#issuecomment-752815085 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1169?src=pr&el=h1) Report > Merging [#1169](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] idbeta opened a new pull request #3525: test: add fuzzing on apisix dp

2021-02-04 Thread GitBox
idbeta opened a new pull request #3525: URL: https://github.com/apache/apisix/pull/3525 ### What this PR does / why we need it: relate https://github.com/apache/apisix/issues/3340 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what ne

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #162: fix: update CD configuration

2021-02-04 Thread GitBox
juzhiyuan commented on a change in pull request #162: URL: https://github.com/apache/apisix-website/pull/162#discussion_r570686499 ## File path: .github/workflows/deploy.yml ## @@ -23,30 +23,13 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job ca

[GitHub] [apisix] idbeta commented on issue #3340: How to do fuzz testing on Apache APISIX

2021-02-04 Thread GitBox
idbeta commented on issue #3340: URL: https://github.com/apache/apisix/issues/3340#issuecomment-773748299 Because there are no more opinions, I think [boofuzz](https://github.com/jtpereyda/boofuzz) is more suitable. It can test both dp and cp. The case writing is also very simple. I will p

[GitHub] [apisix] cocoonYh opened a new issue #3524: bug: apisix cant find upstream and return 500

2021-02-04 Thread GitBox
cocoonYh opened a new issue #3524: URL: https://github.com/apache/apisix/issues/3524 ### Issue description i run apisix with docker for mac, and running server on mac directly. apisix:2.2-centos apisix-dashboard:2.3 etcd:3.4.9 ### Environment * apisix version (c

[GitHub] [apisix-website] imjoey commented on a change in pull request #162: fix: update CD configuration

2021-02-04 Thread GitBox
imjoey commented on a change in pull request #162: URL: https://github.com/apache/apisix-website/pull/162#discussion_r570685334 ## File path: .github/workflows/deploy.yml ## @@ -23,30 +23,13 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can

[GitHub] [apisix] Yiyiyimu commented on pull request #3482: chore: add argument verbose to print init_etcd debug info

2021-02-04 Thread GitBox
Yiyiyimu commented on pull request #3482: URL: https://github.com/apache/apisix/pull/3482#issuecomment-773745716 > you can create a new issue about this, todo things Thanks for remind! Issue created as #3523 This is an

[GitHub] [apisix] Yiyiyimu opened a new issue #3523: Todo: print more logs for apisix cli in verbose mode

2021-02-04 Thread GitBox
Yiyiyimu opened a new issue #3523: URL: https://github.com/apache/apisix/issues/3523 Currently `apisix start --verbose` only prints etcd logs for initializing directories, which seems useless to us. It would be better to remove it and also add more useful logs to apisix cli. -

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1319: chore: introduce ginkgo framework for backend E2E testing

2021-02-04 Thread GitBox
nic-chen commented on a change in pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#discussion_r570682835 ## File path: api/test/e2enew/base/base.go ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[apisix-website] branch fix-cd updated (886123e -> 23c868b)

2021-02-04 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch fix-cd in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 886123e Update deploy.yml add 23c868b Update deploy.yml No new revisions were added by this update

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1319: chore: introduce ginkgo framework for backend E2E testing

2021-02-04 Thread GitBox
nic-chen commented on a change in pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#discussion_r570682794 ## File path: api/test/e2enew/base/base.go ## @@ -0,0 +1,308 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[apisix-dashboard] branch master updated (9824b5f -> 0b5a687)

2021-02-04 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 9824b5f fix: docker build failed in backend e2e test CI (#1433) add 0b5a687 fix: added defer reco

  1   2   3   >