[GitHub] [apisix] xuyancheng24 commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, api

2021-02-06 Thread GitBox
xuyancheng24 commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774630376 how to get route and upstream configuration in etcd This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1448: test: Increase the stability of frontend e2e

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1448: URL: https://github.com/apache/apisix-dashboard/pull/1448#issuecomment-774629853 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1448?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] zhangxiaohui123456 commented on issue #246: request help: Client.Timeout exceeded while awaiting headers

2021-02-06 Thread GitBox
zhangxiaohui123456 commented on issue #246: URL: https://github.com/apache/apisix-ingress-controller/issues/246#issuecomment-774629895 > @zhangxiaohui123456 Could you try to log in to the apisix ingress controller container and connect to the apisix-admin service? I use curl

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1448: test: Increase the stability of frontend e2e

2021-02-06 Thread GitBox
codecov-io commented on pull request #1448: URL: https://github.com/apache/apisix-dashboard/pull/1448#issuecomment-774629853 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1448?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1448: test: Increase the stability of frontend e2e

2021-02-06 Thread GitBox
guoqqqi opened a new pull request #1448: URL: https://github.com/apache/apisix-dashboard/pull/1448 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ]

[GitHub] [apisix] Firstsawyou commented on issue #3548: request help: Docker service not support ipv6.

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3548: URL: https://github.com/apache/apisix/issues/3548#issuecomment-774629536 > Just edit config.yaml and > > ``` > enable_ipv6: false > ``` > > Thx. You can set the parameter `enable_ipv6: true` to false in the configuration

[GitHub] [apisix] eavesmy commented on issue #3548: request help: Docker service not support ipv6.

2021-02-06 Thread GitBox
eavesmy commented on issue #3548: URL: https://github.com/apache/apisix/issues/3548#issuecomment-774629474 Just edit config.yaml and ``` enable_ipv6: false ``` Thx. This is an automated message from the Apache

[GitHub] [apisix] eavesmy closed issue #3548: request help: Docker service not support ipv6.

2021-02-06 Thread GitBox
eavesmy closed issue #3548: URL: https://github.com/apache/apisix/issues/3548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] tokers opened a new issue #3549: request help: only enables upstream passive health checker

2021-02-06 Thread GitBox
tokers opened a new issue #3549: URL: https://github.com/apache/apisix/issues/3549 It seems Apache APISIX cannot only enable the passive health checker for now. ![image](https://user-images.githubusercontent.com/10428333/107140304-21ce2d80-695c-11eb-9ad0-5e7ccb6f229f.png)

[GitHub] [apisix] eavesmy opened a new issue #3548: request help: Docker service not support ipv6.

2021-02-06 Thread GitBox
eavesmy opened a new issue #3548: URL: https://github.com/apache/apisix/issues/3548 ### Issue description My docker service not support ipv6 but nginx.conf has ```[::]: 8090```. When i start apisix-dockr then log output ```nginx: [emerg] socket() [::]:9080 failed (97: Address

[GitHub] [apisix] Firstsawyou commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, apis

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774628617 You need to determine if the upstream node `127.0.0.1:900` is available. It is better to provide route and upstream configuration in etcd, rather than the configuration

[GitHub] [apisix] Firstsawyou commented on issue #3546: request help: when weight set to zero, the node still causes a 5xx error

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3546: URL: https://github.com/apache/apisix/issues/3546#issuecomment-774627204 > But I still wonder why. Does APISIX loop all the nodes before routing? APISIX has a retry mechanism for all upstream nodes. You can learn more about it here:

[GitHub] [apisix] xuyancheng24 commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, api

2021-02-06 Thread GitBox
xuyancheng24 commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774627052 ![route](https://user-images.githubusercontent.com/37585344/107139796-da926d80-6958-11eb-8f3d-6700e46536d9.jpg)

[GitHub] [apisix] Firstsawyou commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, apis

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774625995 You should use the port monitored by apisix to access. If it is still not available, please provide your etcd configuration data.

[GitHub] [apisix] hnlq715 opened a new pull request #3547: feat: support grpc proxy with insecure mode

2021-02-06 Thread GitBox
hnlq715 opened a new pull request #3547: URL: https://github.com/apache/apisix/pull/3547 ### What this PR does / why we need it: Details can be found in #3496. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features

[GitHub] [apisix] diaosj commented on issue #3546: request help: when weight set to zero, the node still causes a 5xx error

2021-02-06 Thread GitBox
diaosj commented on issue #3546: URL: https://github.com/apache/apisix/issues/3546#issuecomment-774622520 But I still wonder why. Does APISIX loop all the nodes before routing? This is an automated message from the Apache

[GitHub] [apisix] diaosj commented on issue #3546: request help: when weight set to zero, the node still causes a 5xx error

2021-02-06 Thread GitBox
diaosj commented on issue #3546: URL: https://github.com/apache/apisix/issues/3546#issuecomment-774620414 > You can try the latest version, not sure if this problem has been fixed. ok. thx! This is an automated

[GitHub] [apisix] xuyancheng24 commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, api

2021-02-06 Thread GitBox
xuyancheng24 commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774619518 dashboard is9000 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] Firstsawyou commented on issue #3546: request help: when weight set to zero, the node still causes a 5xx error

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3546: URL: https://github.com/apache/apisix/issues/3546#issuecomment-774618347 You can try the latest version, not sure if this problem has been fixed. This is an automated message from the

[GitHub] [apisix] Firstsawyou commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, apis

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774617342 By the way, your problem description should be placed in the following `Issue description`. This is an automated

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
nic-chen commented on a change in pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571562860 ## File path: api/test/shell/manager_smoking.sh ## @@ -52,6 +52,12 @@ else echo "no Version output" exit 1 fi +

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
nic-chen commented on a change in pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571562843 ## File path: Dockerfile ## @@ -19,9 +19,10 @@ FROM alpine:latest as pre-build ARG APISIX_DASHBOARD_VERSION=master RUN set -x \ -&&

[GitHub] [apisix] Firstsawyou commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, apis

2021-02-06 Thread GitBox
Firstsawyou commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-774616969 ``` http://192.168.153.136:9000/token ``` Is the 9000 port a dashboard port? This is an automated

[GitHub] [apisix-dashboard] nic-chen closed issue #1355: Support limit the client address

2021-02-06 Thread GitBox
nic-chen closed issue #1355: URL: https://github.com/apache/apisix-dashboard/issues/1355 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] nic-chen commented on issue #1355: Support limit the client address

2021-02-06 Thread GitBox
nic-chen commented on issue #1355: URL: https://github.com/apache/apisix-dashboard/issues/1355#issuecomment-774616954 fixed by #1424 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1447: fix: change manually debug url regexp to lib url-regex-safe

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1447: URL: https://github.com/apache/apisix-dashboard/pull/1447#issuecomment-774616253 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1447?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1447: fix: change manually debug url regexp to lib url-regex-safe

2021-02-06 Thread GitBox
codecov-io commented on pull request #1447: URL: https://github.com/apache/apisix-dashboard/pull/1447#issuecomment-774616253 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1447?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
juzhiyuan merged pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] diaosj opened a new issue #3546: request help: when weight set to zero, the node still causes a 5xx error

2021-02-06 Thread GitBox
diaosj opened a new issue #3546: URL: https://github.com/apache/apisix/issues/3546 ### Issue description Set two nodes to an upstream. Suppose they are `NodeA` and `NodeB`. Upstream JSON is like this: ```

[apisix-dashboard] branch master updated: chore: sync JSON Schema from APISIX version 2.3 (#1445)

2021-02-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 5348579 chore: sync JSON Schema

[GitHub] [apisix] xuyancheng24 opened a new issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, api

2021-02-06 Thread GitBox
xuyancheng24 opened a new issue #3545: URL: https://github.com/apache/apisix/issues/3545 ### Issue description ### Environment * apisix version (cmd: `apisix version`):2.2 * OS (cmd: `uname -a`):Linux 192.168.153.135 3.10.0-1160.el7.x86_64 #1 SMP Mon Oct 19 16:18:59 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1447: fix: change manually debug url regexp to lib url-regex-safe

2021-02-06 Thread GitBox
liuxiran opened a new pull request #1447: URL: https://github.com/apache/apisix-dashboard/pull/1447 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3521: ci: add release check

2021-02-06 Thread GitBox
Yiyiyimu commented on a change in pull request #3521: URL: https://github.com/apache/apisix/pull/3521#discussion_r571558102 ## File path: .github/workflows/build.yml ## @@ -53,6 +53,30 @@ jobs: with: submodules: recursive + - name: Extract branch

[GitHub] [apisix] Yiyiyimu commented on pull request #3521: ci: add release check

2021-02-06 Thread GitBox
Yiyiyimu commented on pull request #3521: URL: https://github.com/apache/apisix/pull/3521#issuecomment-774611616 The tarball compressed by Github Actions could be found at ![image](https://user-images.githubusercontent.com/34589752/107138382-145e7680-694f-11eb-9d4b-5626d2f7f95a.png)

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3501: fix: remove kubectl dependency in chaos test, use k8s API instead

2021-02-06 Thread GitBox
Yiyiyimu commented on a change in pull request #3501: URL: https://github.com/apache/apisix/pull/3501#discussion_r571554776 ## File path: t/chaos/go.mod ## @@ -1,8 +1,38 @@ module github.com/apache/apisix/t/chaos require ( + github.com/chaos-mesh/chaos-mesh v1.1.1

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
nic-chen commented on a change in pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571554467 ## File path: api/VERSION ## @@ -1 +1 @@ -master +2.3 Review comment: @imjoey it will show warning notification when dashboard

[GitHub] [apisix] Yiyiyimu commented on pull request #3521: ci: add release check

2021-02-06 Thread GitBox
Yiyiyimu commented on pull request #3521: URL: https://github.com/apache/apisix/pull/3521#issuecomment-774610699 @spacewander PTAL This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3512: feat: the traffic-split plugin supports upstream_id

2021-02-06 Thread GitBox
Firstsawyou commented on a change in pull request #3512: URL: https://github.com/apache/apisix/pull/3512#discussion_r571553487 ## File path: doc/plugins/traffic-split.md ## @@ -111,6 +113,40 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3512: feat: the traffic-split plugin supports upstream_id

2021-02-06 Thread GitBox
Firstsawyou commented on a change in pull request #3512: URL: https://github.com/apache/apisix/pull/3512#discussion_r571553352 ## File path: apisix/plugins/traffic-split.lua ## @@ -258,18 +258,21 @@ end local function new_rr_obj(weighted_upstreams) local server_list = {}

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3512: feat: the traffic-split plugin supports upstream_id

2021-02-06 Thread GitBox
Firstsawyou commented on a change in pull request #3512: URL: https://github.com/apache/apisix/pull/3512#discussion_r571551164 ## File path: apisix/plugins/traffic-split.lua ## @@ -258,18 +258,21 @@ end local function new_rr_obj(weighted_upstreams) local server_list = {}

[GitHub] [apisix] tokers commented on a change in pull request #3512: feat: the traffic-split plugin supports upstream_id

2021-02-06 Thread GitBox
tokers commented on a change in pull request #3512: URL: https://github.com/apache/apisix/pull/3512#discussion_r571550953 ## File path: apisix/plugins/traffic-split.lua ## @@ -258,18 +258,21 @@ end local function new_rr_obj(weighted_upstreams) local server_list = {}

[GitHub] [apisix-ingress-controller] tokers commented on issue #246: request help: Client.Timeout exceeded while awaiting headers

2021-02-06 Thread GitBox
tokers commented on issue #246: URL: https://github.com/apache/apisix-ingress-controller/issues/246#issuecomment-774608818 @zhangxiaohui123456 Could you try to log in to the apisix ingress controller container and connect to the apisix-admin service?

[GitHub] [apisix-ingress-controller] tokers commented on issue #73: kubectl plugin support

2021-02-06 Thread GitBox
tokers commented on issue #73: URL: https://github.com/apache/apisix-ingress-controller/issues/73#issuecomment-774608448 @masfbeca Assigned, feel free to ask any questions here :) This is an automated message from the

[apisix-ingress-controller] branch master updated: chore: new apisix upstream controller (#236)

2021-02-06 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 8ca5075 chore: new apisix

[GitHub] [apisix-ingress-controller] tokers closed issue #223: New design for ApisixUpstream

2021-02-06 Thread GitBox
tokers closed issue #223: URL: https://github.com/apache/apisix-ingress-controller/issues/223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] tokers merged pull request #236: chore: new apisix upstream controller

2021-02-06 Thread GitBox
tokers merged pull request #236: URL: https://github.com/apache/apisix-ingress-controller/pull/236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #236: chore: new apisix upstream controller

2021-02-06 Thread GitBox
tokers commented on a change in pull request #236: URL: https://github.com/apache/apisix-ingress-controller/pull/236#discussion_r571550240 ## File path: pkg/ingress/controller/apisix_upstream.go ## @@ -15,202 +15,244 @@ package controller import ( - "fmt" -

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
Jaycean commented on pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-774608071 @imjoey https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571542457 done. I used rebase, resulting in no review record.

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1444: chore: Added a data global file

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1444: URL: https://github.com/apache/apisix-dashboard/pull/1444#issuecomment-774506240 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1444?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3512: feat: the traffic-split plugin supports upstream_id

2021-02-06 Thread GitBox
Firstsawyou commented on a change in pull request #3512: URL: https://github.com/apache/apisix/pull/3512#discussion_r571548530 ## File path: apisix/plugins/traffic-split.lua ## @@ -258,18 +258,21 @@ end local function new_rr_obj(weighted_upstreams) local server_list = {}

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
Jaycean commented on a change in pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571544037 ## File path: api/internal/handler/ssl/ssl.go ## @@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
imjoey commented on a change in pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571542457 ## File path: api/internal/handler/ssl/ssl.go ## @@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
imjoey commented on a change in pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571541798 ## File path: api/internal/handler/ssl/ssl.go ## @@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
starsz commented on a change in pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571541696 ## File path: api/internal/handler/ssl/ssl.go ## @@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774482460 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1445?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774482460 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1445?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
imjoey commented on a change in pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571531489 ## File path: api/VERSION ## @@ -1 +1 @@ -master +2.3 Review comment: @nic-chen Any reason to change this to `2.3`? IMHO, we shall keep

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
imjoey commented on a change in pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571531652 ## File path: api/test/shell/manager_smoking.sh ## @@ -52,6 +52,12 @@ else echo "no Version output" exit 1 fi +

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774482460 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1445?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774482460 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1445?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774482460 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1445?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774482460 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1445?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1420: feat: added support for -c to set the config file path

2021-02-06 Thread GitBox
nic-chen commented on pull request #1420: URL: https://github.com/apache/apisix-dashboard/pull/1420#issuecomment-774592900 need test case for the change This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] Yiyiyimu commented on pull request #3521: ci: add release check

2021-02-06 Thread GitBox
Yiyiyimu commented on pull request #3521: URL: https://github.com/apache/apisix/pull/3521#issuecomment-774592809 One problem is which test should we use. Currently we only ignore luarocks check, should we ignore more? This

[GitHub] [apisix] spacewander opened a new pull request #3544: fix: don't use port 80 for all schemes

2021-02-06 Thread GitBox
spacewander opened a new pull request #3544: URL: https://github.com/apache/apisix/pull/3544 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#issuecomment-774589588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1446?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
imjoey commented on a change in pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#discussion_r571531652 ## File path: api/test/shell/manager_smoking.sh ## @@ -52,6 +52,12 @@ else echo "no Version output" exit 1 fi +

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#issuecomment-774589588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1446?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#issuecomment-774589588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1446?src=pr=h1) Report > Merging

[GitHub] [apisix] Yiyiyimu closed pull request #3542: fix: make deps error: file changed as we read it

2021-02-06 Thread GitBox
Yiyiyimu closed pull request #3542: URL: https://github.com/apache/apisix/pull/3542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3542: fix: make deps error: file changed as we read it

2021-02-06 Thread GitBox
Yiyiyimu commented on a change in pull request #3542: URL: https://github.com/apache/apisix/pull/3542#discussion_r571531395 ## File path: Makefile ## @@ -238,13 +239,7 @@ release-src: --exclude t \ --exclude utils \ --exclude release \ - --exclude

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#issuecomment-774589588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1446?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#issuecomment-774589588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1446?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
codecov-io commented on pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446#issuecomment-774589588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1446?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1446: fix: the git commit hash in the docker is empty string

2021-02-06 Thread GitBox
nic-chen opened a new pull request #1446: URL: https://github.com/apache/apisix-dashboard/pull/1446 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1445: chore: sync JSON Schema from APISIX version 2.3

2021-02-06 Thread GitBox
LiteSun commented on pull request #1445: URL: https://github.com/apache/apisix-dashboard/pull/1445#issuecomment-774589319 The reason why the front-end e2e hangs is because the authz-keycloak schema is updated, the front-end needs to update the test data of the authz-keycloak plugin. will

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #236: chore: new apisix upstream controller

2021-02-06 Thread GitBox
gxthrj commented on a change in pull request #236: URL: https://github.com/apache/apisix-ingress-controller/pull/236#discussion_r571530227 ## File path: pkg/ingress/controller/apisix_upstream.go ## @@ -15,202 +15,244 @@ package controller import ( - "fmt" -

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
imjoey commented on a change in pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571527493 ## File path: api/internal/handler/ssl/ssl.go ## @@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #236: chore: new apisix upstream controller

2021-02-06 Thread GitBox
tokers commented on a change in pull request #236: URL: https://github.com/apache/apisix-ingress-controller/pull/236#discussion_r571526041 ## File path: pkg/ingress/controller/apisix_upstream.go ## @@ -15,202 +15,244 @@ package controller import ( - "fmt" -

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
starsz commented on a change in pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#discussion_r571525517 ## File path: api/internal/handler/ssl/ssl.go ## @@ -198,7 +198,16 @@ func (h *Handler) Create(c droplet.Context) (interface{}, error) {

[GitHub] [apisix] cwy57885142 commented on issue #3516: request help:

2021-02-06 Thread GitBox
cwy57885142 commented on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-774583199 ![Uploading 9[Q90}Z_H}SA4REW@9}TW23.png…]() This is an automated message from the Apache Git Service. To

[GitHub] [apisix-ingress-controller] zhangxiaohui123456 opened a new issue #246: request help: Client.Timeout exceeded while awaiting headers

2021-02-06 Thread GitBox
zhangxiaohui123456 opened a new issue #246: URL: https://github.com/apache/apisix-ingress-controller/issues/246 ### Issue description when ### Environment When apisixUpstream is configured, what is the reason for the error reported by the ingress-controller logs:

[GitHub] [apisix] cwy57885142 commented on issue #3516: request help:

2021-02-06 Thread GitBox
cwy57885142 commented on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-774582192 同样请求情况下也遇到过如下报错: {"error":"invalid_request","error_description":"Client does not support permissions"}[ This

[GitHub] [apisix-docker] fukiki opened a new pull request #129: ci: execute ci about apisix and dashboard when pull_request

2021-02-06 Thread GitBox
fukiki opened a new pull request #129: URL: https://github.com/apache/apisix-docker/pull/129 `apisix_all_in_one_ci.yaml` and `dashboard_all_in_one_ci.yaml`should be executed in the phase of pull_request. Related to #126

[GitHub] [apisix] cwy57885142 commented on issue #3516: request help:

2021-02-06 Thread GitBox
cwy57885142 commented on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-774582037 > > 参考测试用例执行,缺少 issuedFor,该值指的是什么? > > {"error":"invalid_request","error_description":"You must provide the issuedFor"} > > It looks like your request is abnormal and

[GitHub] [apisix-dashboard] idbeta edited a comment on pull request #1319: chore: introduce ginkgo framework for backend E2E testing

2021-02-06 Thread GitBox
idbeta edited a comment on pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#issuecomment-772256248 @nic-chen Can you provide us with what will be the output when the case fails in the new framework? Is it more convenient to locate the reason? ping

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #236: chore: new apisix upstream controller

2021-02-06 Thread GitBox
gxthrj commented on a change in pull request #236: URL: https://github.com/apache/apisix-ingress-controller/pull/236#discussion_r571520893 ## File path: pkg/ingress/controller/apisix_upstream.go ## @@ -15,202 +15,244 @@ package controller import ( - "fmt" -

[GitHub] [apisix] spacewander closed pull request #3543: Trigger CI

2021-02-06 Thread GitBox
spacewander closed pull request #3543: URL: https://github.com/apache/apisix/pull/3543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] cwy57885142 removed a comment on issue #3516: request help:

2021-02-06 Thread GitBox
cwy57885142 removed a comment on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-774580729 > > 参考测试用例执行,缺少 issuedFor,该值指的是什么? > > {"error":"invalid_request","error_description":"You must provide the issuedFor"} > > It looks like your request is

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
codecov-io edited a comment on pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-773958991 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1436?src=pr=h1) Report > Merging

[GitHub] [apisix] cwy57885142 commented on issue #3516: request help:

2021-02-06 Thread GitBox
cwy57885142 commented on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-774580729 > > 参考测试用例执行,缺少 issuedFor,该值指的是什么? > > {"error":"invalid_request","error_description":"You must provide the issuedFor"} > > It looks like your request is abnormal and

[GitHub] [apisix] spacewander closed issue #3541: Add global plugins, such as cors, zipkin, and find that the response header appears twice. I want to know if the global plugin is called repeatedly in

2021-02-06 Thread GitBox
spacewander closed issue #3541: URL: https://github.com/apache/apisix/issues/3541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] starsz commented on pull request #1436: feat: refactor ssl unit test

2021-02-06 Thread GitBox
starsz commented on pull request #1436: URL: https://github.com/apache/apisix-dashboard/pull/1436#issuecomment-774580281 > @nic-chen @starsz @imjoey > May I ask you some questions? > SSL has more unit test cases than before. > Why does the coverage rate decrease instead? > Is

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1444: chore: Added a data global file

2021-02-06 Thread GitBox
juzhiyuan commented on a change in pull request #1444: URL: https://github.com/apache/apisix-dashboard/pull/1444#discussion_r571520050 ## File path: web/cypress/fixtures/data.json ## @@ -0,0 +1,31 @@ +{ + "deletePluginSuccess": "Delete Plugin Successfully", +

[apisix-website] branch asf-site updated: deploy: 76cda0394d63328139451082815191a4ae3ac2ad

2021-02-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ad6fc20 deploy:

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1444: chore: Added a data global file

2021-02-06 Thread GitBox
LiteSun commented on a change in pull request #1444: URL: https://github.com/apache/apisix-dashboard/pull/1444#discussion_r571520096 ## File path: web/cypress/fixtures/data.json ## @@ -0,0 +1,31 @@ +{ + "deletePluginSuccess": "Delete Plugin Successfully", Review comment:

[apisix-website] branch master updated: fix: adjust images' dimension (#158) (#165)

2021-02-06 Thread liuxiran
This is an automated email from the ASF dual-hosted git repository. liuxiran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 76cda03 fix: adjust images'

[GitHub] [apisix-website] liuxiran merged pull request #165: fix: adjust images' dimension (#158)

2021-02-06 Thread GitBox
liuxiran merged pull request #165: URL: https://github.com/apache/apisix-website/pull/165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-website] liuxiran closed issue #158: adjust images' dimention

2021-02-06 Thread GitBox
liuxiran closed issue #158: URL: https://github.com/apache/apisix-website/issues/158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] ShaoZeMing commented on issue #3541: Add global plugins, such as cors, zipkin, and find that the response header appears twice. I want to know if the global plugin is called repeated

2021-02-06 Thread GitBox
ShaoZeMing commented on issue #3541: URL: https://github.com/apache/apisix/issues/3541#issuecomment-774579746 > It is fine to call global plugin multiple times, as there is a phase filter: >

  1   2   >