[GitHub] [apisix] iamayushdas commented on pull request #3768: docs: fixed powered-by link

2021-03-05 Thread GitBox
iamayushdas commented on pull request #3768: URL: https://github.com/apache/apisix/pull/3768#issuecomment-791885541 @juzhiyuan review this This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1557: feat: sync fields of `upstream` from APISIX

2021-03-05 Thread GitBox
nic-chen commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791850533 should add some more test cases for it, will update later. This is an automated message from the

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1557: feat: sync fields of `upstream` from APISIX

2021-03-05 Thread GitBox
nic-chen commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791850425 > Hi, please have a search at how many fields are mismatched between manager-api and admin-api, and sync them ASAP. This is needed to replace admin-api. This

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo

2021-03-05 Thread GitBox
Jaycean commented on a change in pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#discussion_r588803930 ## File path: api/test/e2enew/route/route_with_vars_test.go ## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo

2021-03-05 Thread GitBox
Jaycean commented on a change in pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#discussion_r588803895 ## File path: api/test/e2enew/route/route_with_vars_test.go ## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix] iamayushdas opened a new pull request #3768: docs: fixed powered-by link

2021-03-05 Thread GitBox
iamayushdas opened a new pull request #3768: URL: https://github.com/apache/apisix/pull/3768 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ]

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3693: feat: add Spanish translation of the FAQ

2021-03-05 Thread GitBox
juzhiyuan commented on a change in pull request #3693: URL: https://github.com/apache/apisix/pull/3693#discussion_r588795559 ## File path: docs/es/latest/FAQ.md ## @@ -0,0 +1,357 @@ + + +# PREGUNTAS FRECUENTES + +## ¿Por qué un nuevo portal API? + +Existen nuevos

[GitHub] [apisix] juzhiyuan commented on issue #3726: [Discuss] standardize release guide & branch/tag relations

2021-03-05 Thread GitBox
juzhiyuan commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-791806494 got it~ This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] Yiyiyimu commented on issue #3726: [Discuss] standardize release guide & branch/tag relations

2021-03-05 Thread GitBox
Yiyiyimu commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-791649138 > Hi, any conclusion here? Hi I think I could follow the proposal and try to update the release guide this weekend~

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo

2021-03-05 Thread GitBox
codecov-io commented on pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560#issuecomment-791589509 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo

2021-03-05 Thread GitBox
Jaycean opened a new pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1559: test: update test

2021-03-05 Thread GitBox
codecov-io edited a comment on pull request #1559: URL: https://github.com/apache/apisix-dashboard/pull/1559#issuecomment-791552197 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1559: test: update test

2021-03-05 Thread GitBox
codecov-io commented on pull request #1559: URL: https://github.com/apache/apisix-dashboard/pull/1559#issuecomment-791552197 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1559: test: update test

2021-03-05 Thread GitBox
guoqqqi opened a new pull request #1559: URL: https://github.com/apache/apisix-dashboard/pull/1559 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server command

2021-03-05 Thread GitBox
spacewander commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r588436495 ## File path: docs/en/latest/FAQ.md ## @@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks: For the first problem, you can

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1557: feat: sync fields of `upstream` from APISIX

2021-03-05 Thread GitBox
juzhiyuan commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791485449 ![image](https://user-images.githubusercontent.com/2106987/110135159-2249cf00-7e09-11eb-853a-0a3a9728cd74.png) BTW, @LiteSun Please create an issue about why

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1557: feat: sync fields of `upstream` from APISIX

2021-03-05 Thread GitBox
juzhiyuan commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791484822 Hi, please have a search at how many fields are mismatched between manager-api and admin-api, and sync them ASAP. This is needed to replace admin-api.

[GitHub] [apisix] juzhiyuan commented on issue #3726: [Discuss] standardize release guide & branch/tag relations

2021-03-05 Thread GitBox
juzhiyuan commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-791482346 Hi, any conclusion here? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1490: feat: support yaml to config plugin in plugin config page

2021-03-05 Thread GitBox
juzhiyuan commented on pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-791477882 I have no idea how to resolve this conflict  please fix it when you have time. This is an

[GitHub] [apisix] stu01509 commented on issue #3767: docs: fix powered-by link

2021-03-05 Thread GitBox
stu01509 commented on issue #3767: URL: https://github.com/apache/apisix/issues/3767#issuecomment-791477602 I will fix it This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server command

2021-03-05 Thread GitBox
spacewander commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r588352987 ## File path: docs/en/latest/FAQ.md ## @@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks: For the first problem, you can

[GitHub] [apisix] juzhiyuan opened a new issue #3767: docs: fix powered-by link

2021-03-05 Thread GitBox
juzhiyuan opened a new issue #3767: URL: https://github.com/apache/apisix/issues/3767 # Improve Docs ## Please describe which part of docs should be improved or typo fixed Hi, I noticed that this `powered-by.md` is missing 樂 for this file is under the root directory.

[GitHub] [apisix-website] juzhiyuan opened a new issue #246: docs: added event about releasing APISIX 2.4

2021-03-05 Thread GitBox
juzhiyuan opened a new issue #246: URL: https://github.com/apache/apisix-website/issues/246 Hi, we just released Apache APISIX 2.4, we could add an event for this. 1. See https://github.com/apache/apisix/blob/master/CHANGELOG.md#240 2. Add a new event here:

[GitHub] [apisix-website] stu01509 edited a comment on issue #224: The top `version` is not set for phone layout

2021-03-05 Thread GitBox
stu01509 edited a comment on issue #224: URL: https://github.com/apache/apisix-website/issues/224#issuecomment-791394321 > > Hi @juzhiyuan > > I knew the version info is wrapped by **DocsVersionDropdownNavbarItem**, but where can I found more detail about this? > >

[GitHub] [apisix-website] stu01509 opened a new pull request #245: fix: fix the version number in mobile size overflow

2021-03-05 Thread GitBox
stu01509 opened a new pull request #245: URL: https://github.com/apache/apisix-website/pull/245 Fixes: #224 Changes: I adjust the `sidebarVersionSwitch` to outside and add the `sidebarVersionSwitch a` class to prevent when the screen size below 997px, the **a** tag will be

[apisix] branch master updated: docs: change the img tag to markdown syntax (#3765)

2021-03-05 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new f657b90 docs: change the img tag to

[GitHub] [apisix] spacewander merged pull request #3765: docs: change the img tag to markdown syntax

2021-03-05 Thread GitBox
spacewander merged pull request #3765: URL: https://github.com/apache/apisix/pull/3765 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander closed issue #3730: docs: use markdown way to import images

2021-03-05 Thread GitBox
spacewander closed issue #3730: URL: https://github.com/apache/apisix/issues/3730 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-05 Thread GitBox
spacewander commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r588284177 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err =

[GitHub] [apisix-website] juzhiyuan merged pull request #244: feat: upgrade APISIX version

2021-03-05 Thread GitBox
juzhiyuan merged pull request #244: URL: https://github.com/apache/apisix-website/pull/244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-website] branch master updated: feat: upgrade APISIX version (#244)

2021-03-05 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new a82a1b4 feat: upgrade APISIX

[GitHub] [apisix-website] stu01509 commented on issue #224: The top `version` is not set for phone layout

2021-03-05 Thread GitBox
stu01509 commented on issue #224: URL: https://github.com/apache/apisix-website/issues/224#issuecomment-791394321 > > Hi @juzhiyuan > > I knew the version info is wrapped by **DocsVersionDropdownNavbarItem**, but where can I found more detail about this? > >

[GitHub] [apisix] stu01509 opened a new pull request #3766: docs: add --server command

2021-03-05 Thread GitBox
stu01509 opened a new pull request #3766: URL: https://github.com/apache/apisix/pull/3766 ### What this PR does / why we need it: Fix #3671 Add **--server** command option. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve?

[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-05 Thread GitBox
tzssangglass commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r588243727 ## File path: t/plugin/traffic-split.t ## @@ -1615,7 +1615,134 @@ passed -=== TEST 46: the upstream_id is used in the plugin +=== TEST 46: set

[GitHub] [apisix] stu01509 opened a new pull request #3765: docs: change the img tag to markdown syntax

2021-03-05 Thread GitBox
stu01509 opened a new pull request #3765: URL: https://github.com/apache/apisix/pull/3765 ### What this PR does / why we need it: Fix #3730 Change the img tag to markdown syntax. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or

[GitHub] [apisix] Firstsawyou commented on issue #3764: bug:

2021-03-05 Thread GitBox
Firstsawyou commented on issue #3764: URL: https://github.com/apache/apisix/issues/3764#issuecomment-791337489 You should provide the installation steps of APISIX dependent environment, such as the installation of `openresty, openresty-openssl-xxx`.

[apisix] branch release/2.4 created (now 9ee82f9)

2021-03-05 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/2.4 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 9ee82f9 ci: auto generate and check for rpm package (#3621) No new revisions were added by this update.

[apisix] branch master updated: feat: release 2.4 (#3723)

2021-03-05 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b7b784f feat: release 2.4 (#3723) b7b784f

[GitHub] [apisix] spacewander merged pull request #3723: feat: release 2.4

2021-03-05 Thread GitBox
spacewander merged pull request #3723: URL: https://github.com/apache/apisix/pull/3723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] wudj opened a new issue #3764: bug:

2021-03-05 Thread GitBox
wudj opened a new issue #3764: URL: https://github.com/apache/apisix/issues/3764 ### Issue description ### Environment * apisix version (cmd: `apisix version`):2.3 * OS (cmd: `uname -a`):Ubuntu 16 LTS * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):

[GitHub] [apisix-dashboard] nic-chen commented on issue #1549: feat: support `discovery_type` in Dashboard

2021-03-05 Thread GitBox
nic-chen commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-791306031 > i think there still need some code for dashboard show, so i can't check the feature from dashboard now. yes, you are right. the pr is only for backend.

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-05 Thread GitBox
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791305010 need some test cases for duplicate check, thanks. @batman-ezio This is an automated message from the

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1558: feat:Support duplicate one existing Route

2021-03-05 Thread GitBox
nic-chen commented on a change in pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#discussion_r588163878 ## File path: api/internal/handler/route/route.go ## @@ -307,6 +307,12 @@ func generateLuaCode(script map[string]interface{}) (string, error)

[GitHub] [apisix-dashboard] batman-ezio opened a new pull request #1558: feat:Support duplicate one existing Route

2021-03-05 Thread GitBox
batman-ezio opened a new pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-website] spacewander opened a new pull request #244: feat: upgrade APISIX version

2021-03-05 Thread GitBox
spacewander opened a new pull request #244: URL: https://github.com/apache/apisix-website/pull/244 Fixes: #[Add issue number here] Changes: Screenshots of the change: This is an automated

[apisix] 01/01: ci: auto generate and check for rpm package (#3621)

2021-03-05 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch release/rpm in repository https://gitbox.apache.org/repos/asf/apisix.git commit 9ee82f9d27b2866e8f64244b9f2493e881df771f Author: Shuyang Wu AuthorDate: Wed Mar 3 17:59:59 2021 +0800

[apisix] branch release/rpm created (now 9ee82f9)

2021-03-05 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/rpm in repository https://gitbox.apache.org/repos/asf/apisix.git. at 9ee82f9 ci: auto generate and check for rpm package (#3621) This branch includes the following new