[GitHub] [apisix-dashboard] imjoey commented on issue #1595: What is the he Unique identifier of a route (name or id)?

2021-03-18 Thread GitBox
imjoey commented on issue #1595: URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-801716090 > @imjoey agree > but for the better FE, can we add id file and display in the LIST view? > when user can route by admin api Put `/route/a1` and `route/a2` and so on.

[GitHub] [apisix] spacewander commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-18 Thread GitBox
spacewander commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r596626770 ## File path: docs/en/latest/discovery/consul_kv.md ## @@ -73,6 +76,31 @@ The `keepalive` has two optional values: - `true`, default and recommend

[GitHub] [apisix-dashboard] starsz commented on issue #1609: Backend API Cookie secret

2021-03-18 Thread GitBox
starsz commented on issue #1609: URL: https://github.com/apache/apisix-dashboard/issues/1609#issuecomment-801714995 Good capture. @stu01509 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] nanamikon opened a new issue #3858: bug: When use traffic-split , the key of chash is missing

2021-03-18 Thread GitBox
nanamikon opened a new issue #3858: URL: https://github.com/apache/apisix/issues/3858 ### Issue description ### Environment * apisix version (2.3): * OS (ubuntu 16): * OpenResty / Nginx version (1.19.3): * etcd version, if have (3.14): * apisix-dashboard version,

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1584: feat: save Service list page's meta status

2021-03-18 Thread GitBox
guoqqqi commented on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-801709198 Hi, I've added the ability to save the paginator state for each page in this PR and we can make it a component in the next PR.

[GitHub] [apisix-dashboard] imjoey commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-18 Thread GitBox
imjoey commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-801706213 @liuxiran the FE e2e test still seems broken. Shall we fix it beforehand? This is an automated message

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1558: feat:Support duplicate one existing Route

2021-03-18 Thread GitBox
guoqqqi commented on a change in pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#discussion_r596616937 ## File path: web/config/routes.ts ## @@ -39,6 +39,10 @@ const routes = [ path: '/routes/:rid/edit', component: './Route/Create',

[GitHub] [apisix] Firstsawyou commented on pull request #3854: change: remove deprecated upstream.enable_websocket

2021-03-18 Thread GitBox
Firstsawyou commented on pull request #3854: URL: https://github.com/apache/apisix/pull/3854#issuecomment-801705132 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] starsz commented on pull request #1598: feat: check if the service is using by route when deleting

2021-03-18 Thread GitBox
starsz commented on pull request #1598: URL: https://github.com/apache/apisix-dashboard/pull/1598#issuecomment-801705128 > @starsz > I think you should sync codes from branch master to see if there is conflict in e2e test cases. I think @LiteSun had done this before.

[GitHub] [apisix] spacewander commented on a change in pull request #3839: feat: add allow_origins_by_regex to cors plugin

2021-03-18 Thread GitBox
spacewander commented on a change in pull request #3839: URL: https://github.com/apache/apisix/pull/3839#discussion_r596545363 ## File path: docs/en/latest/plugins/cors.md ## @@ -43,6 +43,7 @@ title: cors | expose_headers | string | optional| "*" | | Which

[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support

2021-03-18 Thread GitBox
spacewander commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r596598466 ## File path: docs/en/latest/discovery/nacos.md ## @@ -0,0 +1,93 @@ +--- +title: nacos +--- + + + +### Configuration for Nacos + +Add following

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1558: feat:Support duplicate one existing Route

2021-03-18 Thread GitBox
juzhiyuan commented on a change in pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#discussion_r596610249 ## File path: web/config/routes.ts ## @@ -39,6 +39,10 @@ const routes = [ path: '/routes/:rid/edit', component: './Route/Create',

[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1615: feat: manual deletion of apisix node data

2021-03-18 Thread GitBox
bisakhmondal opened a new pull request #1615: URL: https://github.com/apache/apisix-dashboard/pull/1615 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1599: feat: check if the upstream is using by route when deleting

2021-03-18 Thread GitBox
codecov-io edited a comment on pull request #1599: URL: https://github.com/apache/apisix-dashboard/pull/1599#issuecomment-800959157 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1599?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status

2021-03-18 Thread GitBox
codecov-io edited a comment on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1599: feat: check if the upstream is using by route when deleting

2021-03-18 Thread GitBox
codecov-io edited a comment on pull request #1599: URL: https://github.com/apache/apisix-dashboard/pull/1599#issuecomment-800959157 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1599?src=pr=h1) Report > Merging

[GitHub] [apisix] tokers opened a new issue #3857: Optimize the Serverless plugin

2021-03-18 Thread GitBox
tokers opened a new issue #3857: URL: https://github.com/apache/apisix/issues/3857 ### Issue description Currently the serverless plugin functions don't have args, when we want to access some per-request data in `api_ctx`, we have to use `ngx.ctx.api_ctx`, which is obscure for new

[GitHub] [apisix] imjoey opened a new issue #3856: request help: Support exposing databases as web services

2021-03-18 Thread GitBox
imjoey opened a new issue #3856: URL: https://github.com/apache/apisix/issues/3856 ### Issue description When constructing data middle platform, uses may need expose their databases, e.g. relational/bigdata/nosql, as web services for API consumers. For now, we firstly develop

[GitHub] [apisix-website] stu01509 commented on issue #264: Typo in the title of limit-count plugin

2021-03-18 Thread GitBox
stu01509 commented on issue #264: URL: https://github.com/apache/apisix-website/issues/264#issuecomment-801687201 I will fix it  This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1598: feat: check if the service is using by route when deleting

2021-03-18 Thread GitBox
codecov-io edited a comment on pull request #1598: URL: https://github.com/apache/apisix-dashboard/pull/1598#issuecomment-800084435 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1598?src=pr=h1) Report > Merging

[GitHub] [apisix] imjoey commented on issue #3849: bug: roundrobin 负载均衡 k8s短域名 和 ip 同时配置只会选择一种轮询

2021-03-18 Thread GitBox
imjoey commented on issue #3849: URL: https://github.com/apache/apisix/issues/3849#issuecomment-801674117 @godsoul this seems very weird. Are you using an APISIX instance as a normal Service, or as an ingress gateway? Could you please elaborate on the deployment architecture? We do need

[GitHub] [apisix] yongboy commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-18 Thread GitBox
yongboy commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r596587593 ## File path: docs/en/latest/discovery/consul_kv.md ## @@ -73,6 +76,31 @@ The `keepalive` has two optional values: - `true`, default and recommend value,

[GitHub] [apisix] yongboy commented on a change in pull request #3848: feat: add dump for consul_kv

2021-03-18 Thread GitBox
yongboy commented on a change in pull request #3848: URL: https://github.com/apache/apisix/pull/3848#discussion_r596582250 ## File path: apisix/discovery/consul_kv.lua ## @@ -230,6 +241,73 @@ local function update_application(server_name_prefix, data) end +local function

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1601: feat: add rawDataEditor in route

2021-03-18 Thread GitBox
codecov-io edited a comment on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1601: feat: add rawDataEditor in route

2021-03-18 Thread GitBox
codecov-io edited a comment on pull request #1601: URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] batman-ezio commented on a change in pull request #1558: feat:Support duplicate one existing Route

2021-03-18 Thread GitBox
batman-ezio commented on a change in pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#discussion_r596573541 ## File path: web/config/routes.ts ## @@ -39,6 +39,10 @@ const routes = [ path: '/routes/:rid/edit', component: './Route/Create',

<    1   2   3