ShaoZeMing commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802728346
> @ShaoZeMing Hi, thanks for your report, let's try to resolve your issue.
And please try the following steps:
>
> In dashboard 2.4, we don't support showing route
starsz commented on a change in pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597560799
##
File path: api/test/e2e/server_info_delete_test.go
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
starsz commented on a change in pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#discussion_r597560799
##
File path: api/test/e2e/server_info_delete_test.go
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Jaycean commented on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802708104
cc @liuxiran @LiteSun @juzhiyuan FE CI Failed PTAL. Thks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
liuxiran commented on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802700710
also cc @guoqqqi to review when you have time, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
yongboy commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597519487
##
File path: apisix/discovery/consul_kv.lua
##
@@ -244,7 +244,7 @@ end
local function read_dump_srvs()
local data, err =
liuxiran commented on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-802684898
https://github.com/apache/apisix-dashboard/pull/1612/checks?check_run_id=2146684625
just waiting for #1619 to solve this ci error
--
This is an automated message
liuxiran commented on a change in pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#discussion_r597520254
##
File path: web/cypress/fixtures/route-json-data.json
##
@@ -0,0 +1,30 @@
+{
+ "debugPostJson": {
+"name": "test_https",
+"status":
yongboy commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597519487
##
File path: apisix/discovery/consul_kv.lua
##
@@ -244,7 +244,7 @@ end
local function read_dump_srvs()
local data, err =
codecov-io edited a comment on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1)
Report
> Merging
spacewander opened a new pull request #3872:
URL: https://github.com/apache/apisix/pull/3872
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
codecov-io edited a comment on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from f4f27d1 feat: check if the service is used by route when deleting
(#1598)
add 1ba32d9 feat:
membphis merged pull request #1617:
URL: https://github.com/apache/apisix-dashboard/pull/1617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
membphis closed issue #1609:
URL: https://github.com/apache/apisix-dashboard/issues/1609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
spacewander commented on a change in pull request #3848:
URL: https://github.com/apache/apisix/pull/3848#discussion_r597481993
##
File path: apisix/discovery/consul_kv.lua
##
@@ -244,7 +244,7 @@ end
local function read_dump_srvs()
local data, err =
codecov-io edited a comment on pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619#issuecomment-802512861
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1619?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr=h1)
Report
> Merging
Firstsawyou commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802634629
> @Firstsawyou
>
> [#3865
(comment)](https://github.com/apache/apisix/issues/3865#issuecomment-802452402)
is exported as `OpenAPI v3`.
okay.
--
This is an
bisakhmondal commented on pull request #1589:
URL: https://github.com/apache/apisix-dashboard/pull/1589#issuecomment-802631419
> LGTM for the code , it would be better to add test case for this nice new
feature
Thanks. Yeah, it's a nice but really minor addition to the codebase. Hey
liuxiran edited a comment on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802621063
> @liuxiran just ignored it, Netlify still has some issues to resolve, I'm
working on it.
got it, thanks.
then since all the errors fixed, please
liuxiran commented on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802621063
> @liuxiran just ignored it, Netlify still has some issues to resolve, I'm
working on it.
got
> @liuxiran just ignored it, Netlify still has some issues
bisakhmondal commented on issue #1482:
URL:
https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802620825
> Hi, after discuss with @nic-chen @starsz @LiteSun, we have a new way to
support this feature.
>
> How about only adding one extra message that tells users:
LiteSun opened a new pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ]
Firstsawyou opened a new pull request #3871:
URL: https://github.com/apache/apisix/pull/3871
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ]
juzhiyuan commented on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802617293
@liuxiran just ignored it, Netlify still has some issues to resolve, I'm
working on it.
--
This is an automated message from the Apache Git Service.
To respond to
liuxiran commented on pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-802616705
![Screenshot_20210319_150946](https://user-images.githubusercontent.com/2561857/111743827-368bd280-88c5-11eb-9115-f388d92b13fa.jpg)
codecov-io edited a comment on pull request #308:
URL:
https://github.com/apache/apisix-ingress-controller/pull/308#issuecomment-802563470
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/308?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-800291441
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1601?src=pr=h1)
Report
> Merging
tokers opened a new issue #309:
URL: https://github.com/apache/apisix-ingress-controller/issues/309
We don't have any documents to tell users the compatibility between APISIX
and apisix-ingress-controller. It's better to keep a record of this
relationship between them, so people won't
gxthrj commented on a change in pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#discussion_r597449561
##
File path: compose/dashboard-compose.yaml
##
@@ -0,0 +1,35 @@
+version: "3"
Review comment:
docker-compose.yaml already have dashboard
juzhiyuan commented on issue #3851:
URL: https://github.com/apache/apisix/issues/3851#issuecomment-802606898
We Apache community build software shared by the global world, and welcome
anyone to use and give feedback.
--
This is an automated message from the Apache Git Service.
To
LiteSun commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-802603911
ping~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Firstsawyou opened a new pull request #3870:
URL: https://github.com/apache/apisix/pull/3870
fix #3851
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been
juzhiyuan commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802600363
@Firstsawyou
https://github.com/apache/apisix/issues/3865#issuecomment-802452402 is
exported as `OpenAPI v3`.
--
This is an automated message from the Apache Git Service.
juzhiyuan commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802599858
@ShaoZeMing Hi, thanks for your report, let's try to resolve your issue. And
please try the following steps:
In dashboard 2.4, we don't support showing route configuration
juzhiyuan commented on pull request #1615:
URL: https://github.com/apache/apisix-dashboard/pull/1615#issuecomment-802595331
Hi, @bisakhmondal, what do you think of this solution?
https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-802523508
--
This is an automated
ShaoZeMing commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802589320
> > > Your configuration data looks strange. It seems that the field names
of apisix have been modified?
> >
> >
> > Sorry i didn't understand you too much
>
>
nanamikon closed issue #3858:
URL: https://github.com/apache/apisix/issues/3858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
codecov-io edited a comment on pull request #308:
URL:
https://github.com/apache/apisix-ingress-controller/pull/308#issuecomment-802563470
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/308?src=pr=h1)
Report
> Merging
Firstsawyou removed a comment on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802582618
> > Your configuration data looks strange. It seems that the field names of
apisix have been modified?
>
> Sorry i didn't understand you too much
There are
Firstsawyou commented on issue #3865:
URL: https://github.com/apache/apisix/issues/3865#issuecomment-802582617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
101 - 146 of 146 matches
Mail list logo