[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-28 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118653 And By the way, I have tried to create a consumer but it always says `invalid json data` like this: ![image](https://user-images.githubusercontent.com/41932086/112797525-1797f800-90

[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-28 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118141 @Firstsawyou Thanks for your reply. 1. I have check and I'm sure jwt-auth is not enabled in my routes. 2. Where can I config `global_rules` ? I cannot find it in `config-d

[GitHub] [apisix] spacewander commented on a change in pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode

2021-03-28 Thread GitBox
spacewander commented on a change in pull request #3870: URL: https://github.com/apache/apisix/pull/3870#discussion_r603046994 ## File path: apisix/plugins/traffic-split.lua ## @@ -148,26 +148,18 @@ end local function set_pass_host(ctx, upstream_info, host) --- Current

[GitHub] [apisix-dashboard] aiyiyi121 opened a new issue #1687: request help: What’s the function of export OpenAPI on the dashboard

2021-03-28 Thread GitBox
aiyiyi121 opened a new issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API c

[GitHub] [apisix] Firstsawyou commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-28 Thread GitBox
Firstsawyou commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809104963 @KMFtcy You need to check the following two points: 1. Is the jwt-auth plugin configured in your consumer object? If so, you need to check whether the jwt-auth plugin is ena

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808024334 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=h1) Report > Merging [#1675](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] aiyiyi121 opened a new issue #3930: request help: What’s the function of export OpenAPI on the dashboard

2021-03-28 Thread GitBox
aiyiyi121 opened a new issue #3930: URL: https://github.com/apache/apisix/issues/3930 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API configurati

[GitHub] [apisix] Firstsawyou commented on pull request #3929: docs: Improve proxy-rewrite plugin docs

2021-03-28 Thread GitBox
Firstsawyou commented on pull request #3929: URL: https://github.com/apache/apisix/pull/3929#issuecomment-809097623 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-28 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809095854 @tokers No. Is it necessary to bind a consumer to a route? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] bisakhmondal closed issue #1682: Updating URI of an existing route causes 404 error

2021-03-28 Thread GitBox
bisakhmondal closed issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1682: Updating URI of an existing route causes 404 error

2021-03-28 Thread GitBox
bisakhmondal commented on issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682#issuecomment-809093438 Thanks, @nic-chen, @starsz for looking into this. Actually, the error has nothing to do with manager-api. Thanks to @Jaycean, only `/hello`, `/hello_` and `/hello1` ro

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-28 Thread GitBox
bisakhmondal commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809088311 > Yes, after all, this upstream is just for testing No issues. Totally agree with you :) -- This is an automated message from the Apache Git Service. To re

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-28 Thread GitBox
Jaycean commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809081483 > Wonderful @Jaycean. Thank you for the elaborated information. > So the whole time the 404 was thrown by upstream itself. Yes, after all, this upstream is just

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-28 Thread GitBox
bisakhmondal commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809080765 Wonderful @Jaycean❤️. Thank you for the elaborated information. So the whole time the 404 was thrown by upstream itself😶. -- This is an automated message from

[GitHub] [apisix-ingress-controller] tokers commented on issue #317: request help: Could not resolve host:

2021-03-28 Thread GitBox
tokers commented on issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317#issuecomment-809079408 @pioneer-hash I have re-organized the description so that it can be more clear. BTW, please add the environment information in the text. -- This is an automated mes

[GitHub] [apisix] tokers commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-28 Thread GitBox
tokers commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809077781 @KMFtcy Is there any consumer data in your APISIX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] qian0817 opened a new pull request #3929: docs: Improve proxy-rewrite plugin docs

2021-03-28 Thread GitBox
qian0817 opened a new pull request #3929: URL: https://github.com/apache/apisix/pull/3929 change proxy rewrite to proxy-rewrite ### What this PR does / why we need it: In the proxy-rewrite.md document, some plugin names are proxy rewrite, which is a typo. related issue

[GitHub] [apisix] KMFtcy opened a new issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-28 Thread GitBox
KMFtcy opened a new issue #3928: URL: https://github.com/apache/apisix/issues/3928 ### Issue description Hi there! I'm running apisix in a docker container. The docker image built from project https://github.com/apache/apisix-docker with command below ``` docker build --build-ar

[GitHub] [apisix] whl739 commented on issue #3923: request help: timer enhancement

2021-03-28 Thread GitBox
whl739 commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809056944 But also `core.timer` provides `self.running` to prevent callback function to run repeatly, timers are still affected. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander opened a new pull request #3927: test: enable master-worker mode by default

2021-03-28 Thread GitBox
spacewander opened a new pull request #3927: URL: https://github.com/apache/apisix/pull/3927 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] spacewander opened a new pull request #3926: ci: the last day of travis

2021-03-28 Thread GitBox
spacewander opened a new pull request #3926: URL: https://github.com/apache/apisix/pull/3926 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] spacewander commented on issue #3923: request help: timer enhancement

2021-03-28 Thread GitBox
spacewander commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809050063 > The background timer can not set a interval time, and the callback function have to check the time by itself, it's not easy to use. Yes, as OpenResty doesn't provide a can

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 @juzhiyuan after looking into the fix suggested by @guoqqqi above, i got to know many of the routings was wrongly done like "Service ,upstream, consumer". pa

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 @juzhiyuan after looking into the fix suggested by @guoqqqi above, i got to know many of the routings was wrongly done like "Service ,upstream, consumer". pa

[GitHub] [apisix-ingress-controller] pioneer-hash opened a new issue #317: request help: Could not resolve host:

2021-03-28 Thread GitBox
pioneer-hash opened a new issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317 ### Issue description When I install INGRESS-Controller I start creating the route , unable to synchronize configuration. this is my ingress-log: 2021-03-29T10:35:41+08:00

[GitHub] [apisix] whl739 commented on issue #3923: request help: cancelable timer

2021-03-28 Thread GitBox
whl739 commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809036856 The background timer can not set a interval time, and the callback function have to check the time by itself, it's not easy to use. It's implemention is that spawn registed timer thr

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. >

[GitHub] [apisix] spacewander commented on a change in pull request #3883: feat: add 5xx error page

2021-03-28 Thread GitBox
spacewander commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r602991217 ## File path: apisix/error_handler.lua ## @@ -0,0 +1,54 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor l

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander opened a new pull request #3925: feat(skywalking): allow destory and configure report interval for rep…

2021-03-28 Thread GitBox
spacewander opened a new pull request #3925: URL: https://github.com/apache/apisix/pull/3925 …orter Fix #2895 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does t

[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. >

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809031431 @juzhiyuan should i change the path name of edit to configure for all or not, i guess that would be good. What say? -- This is an automated message from the Apach

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-28 Thread GitBox
Jaycean edited a comment on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809023973 > Okay, @Jaycean, I'm opening an issue. > See the ci is also failing with a 404 for that particular test. > ![image](https://user-images.githubusercontent.c

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-28 Thread GitBox
Jaycean commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809023973 > Okay, @Jaycean, I'm opening an issue. > See the ci is also failing with a 404 for that particular test. > ![image](https://user-images.githubusercontent.com/4149

[GitHub] [apisix] zhangguanzhang commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2021-03-28 Thread GitBox
zhangguanzhang commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-809019375 组织:金山办公 地址:中国:武汉,珠海 联系方式:zhangguanzh...@qq.com 使用场景:产品线较多,入口需要一个网关来管理所有url -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-28 Thread GitBox
Jaycean commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602977216 ## File path: api/internal/handler/data_loader/route_export.go ## @@ -245,8 +246,14 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context, rout

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-28 Thread GitBox
starsz commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602973342 ## File path: api/test/e2e/route_export_test.go ## @@ -2505,6 +2503,499 @@ func TestRoute_Export_Equal_URI(t *testing.T) { } +func TestRoute_

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-28 Thread GitBox
starsz commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602973125 ## File path: web/cypress/fixtures/export-route-dataset.json ## @@ -131,7 +129,6 @@ } }, "x-apisix-enable_webso

[GitHub] [apisix-ingress-controller] tokers commented on issue #312: bug: Modify the route.yaml configuration to not update apisix synchronously

2021-03-28 Thread GitBox
tokers commented on issue #312: URL: https://github.com/apache/apisix-ingress-controller/issues/312#issuecomment-809011741 @pioneer-hash Thanks for your report, I have captured this bug, I will fix it as soon as possible. -- This is an automated message from the Apache Git Service. To r

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-28 Thread GitBox
tokers commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602968683 ## File path: api/internal/handler/data_loader/route_export.go ## @@ -245,8 +246,14 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context, route

[GitHub] [apisix] Yiyiyimu commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …

2021-03-28 Thread GitBox
Yiyiyimu commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-809002482 > Yes we should move this PR and include it in the GitHub Super Linter PR #3045 Hi @jbampton I thought we've already moved this PR to #3045 🤣 Besides, if I take it rig

[GitHub] [apisix-dashboard] tokers commented on issue #1684: program panic when failed to initialize etcd store is unreasonable

2021-03-28 Thread GitBox
tokers commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-809001865 > that also happens when ectd is unable to connect Yep, let it crash is not a good way here. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-website] tokers commented on a change in pull request #275: Feat #216 add project 2

2021-03-28 Thread GitBox
tokers commented on a change in pull request #275: URL: https://github.com/apache/apisix-website/pull/275#discussion_r602963516 ## File path: website/docusaurus.config.js ## @@ -60,6 +60,17 @@ module.exports = { releaseDate: "2021-03-12", firstDocPath: "/apisi

[GitHub] [apisix] Yiyiyimu merged pull request #3914: test: show how to bypass the ctx.var cache

2021-03-28 Thread GitBox
Yiyiyimu merged pull request #3914: URL: https://github.com/apache/apisix/pull/3914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[apisix] branch master updated: test: show how to bypass the ctx.var cache (#3914)

2021-03-28 Thread shuyangw
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3ba24c4 test: show how to bypass the ctx.var

[GitHub] [apisix-dashboard] nic-chen commented on issue #1682: Updating URI of an existing route causes 404 error

2021-03-28 Thread GitBox
nic-chen commented on issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682#issuecomment-808996364 @bisakhmondal what is the content in nginx.conf and is there error log for this? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [apisix-website] stu01509 opened a new pull request #275: Feat #216 add project 2

2021-03-28 Thread GitBox
stu01509 opened a new pull request #275: URL: https://github.com/apache/apisix-website/pull/275 Fixes: #216 Changes: Add the **apisix-project** project. Screenshots of the change: -- This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] batman-ezio commented on issue #1684: program panic when failed to initialize etcd store is unreasonable

2021-03-28 Thread GitBox
batman-ezio commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-808980058 that also happens when ectd is unable to connect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] diaosj commented on issue #3917: request help: question about Prometheus memory consumption

2021-03-28 Thread GitBox
diaosj commented on issue #3917: URL: https://github.com/apache/apisix/issues/3917#issuecomment-808949145 > https://github.com/apache/apisix/blob/83931ba0a5c95e04ec867a4ffd0821d426ca0d27/apisix/cli/ngx_tpl.lua#L131 > > I would appreciate it if you can make it configurable. Tha

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1672: doc: add more details and examples to import openapi guide

2021-03-28 Thread GitBox
liuxiran commented on a change in pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#discussion_r602901727 ## File path: docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md ## @@ -21,34 +21,21 @@ title: Import OpenAPI Guide # --> -The OpenAPI Specificatio

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808919338 > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > The

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
guoqqqi commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808918555 Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. Then I found a sm

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1679: feat: autocomplete when people input http header

2021-03-28 Thread GitBox
guoqqqi commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808912724 LGTM! Hi, I can help you to add an E2E test to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[apisix] branch master updated: docs: tells users where they are (#3922)

2021-03-28 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2b60d18 docs: tells users where they are (

[GitHub] [apisix] spacewander merged pull request #3922: docs: tells users where they are

2021-03-28 Thread GitBox
spacewander merged pull request #3922: URL: https://github.com/apache/apisix/pull/3922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
juzhiyuan commented on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808910790 Hi! Thanks for your first contribution :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-website] juzhiyuan closed issue #178: Add a bundle of Good first issues links to Homepage

2021-03-28 Thread GitBox
juzhiyuan closed issue #178: URL: https://github.com/apache/apisix-website/issues/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [apisix-website] juzhiyuan commented on pull request #274: fix: add a bundle of good first issues links to homepage

2021-03-28 Thread GitBox
juzhiyuan commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808910548 good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [apisix-website] juzhiyuan merged pull request #274: fix: add a bundle of good first issues links to homepage

2021-03-28 Thread GitBox
juzhiyuan merged pull request #274: URL: https://github.com/apache/apisix-website/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-website] branch master updated: fix: add a bundle of good first issues links to homepage (#274)

2021-03-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new d68dc25 fix: add a bundle of good fi

[GitHub] [apisix] spacewander commented on issue #3923: request help: cancelable timer

2021-03-28 Thread GitBox
spacewander commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-808910477 The timer is not logger only, we can use it in other plugins too. See: https://github.com/apache/apisix/blob/c9df9fca652d14d32c8331820640ed9344c4529a/apisix/plugins/server-info.

[GitHub] [apisix] spacewander opened a new pull request #3924: test: make consul_kv stable

2021-03-28 Thread GitBox
spacewander opened a new pull request #3924: URL: https://github.com/apache/apisix/pull/3924 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] whl739 opened a new issue #3923: request help: cancelable timer

2021-03-28 Thread GitBox
whl739 opened a new issue #3923: URL: https://github.com/apache/apisix/issues/3923 Currently, apisix provides a background timer for logger related plugins, whitch is not universal. See this demand: a plugin may register a timer in `init` function, the timer will be recurring to pul

[GitHub] [apisix-website] juzhiyuan commented on pull request #274: fix: add a bundle of good first issues links to homepage

2021-03-28 Thread GitBox
juzhiyuan commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808907716 ![image](https://user-images.githubusercontent.com/2106987/112756550-508d8980-9018-11eb-9eae-c017cae01f8c.png) Hi, it looks like the icon is not aligned with text?

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3922: docs: tells users where they are

2021-03-28 Thread GitBox
juzhiyuan commented on a change in pull request #3922: URL: https://github.com/apache/apisix/pull/3922#discussion_r60261 ## File path: docs/en/latest/config.json ## @@ -1,6 +1,11 @@ { "version": 2.4, "sidebar": [ +{ + "type": "link", + "label": "Apache

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #274: fix: add a bundle of good first issues links to homepage

2021-03-28 Thread GitBox
KishaniKandasamy commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808905764 > > LGTM, and needs @1502shivam-singh's review :) > > ![image](https://user-images.githubusercontent.com/2106987/112740134-06bb8980-8fad-11eb-8ecb-88802047152b.p

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #274: fix: add a bundle of good first issues links to homepage

2021-03-28 Thread GitBox
1502shivam-singh commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808904115 > LGTM, and needs @1502shivam-singh's review :) > > ![image](https://user-images.githubusercontent.com/2106987/112740134-06bb8980-8fad-11eb-8ecb-88802047152b

[GitHub] [apisix] spacewander commented on issue #3920: request help: nginx: [emerg] invalid port in "table:" of the "listen" directive in ...

2021-03-28 Thread GitBox
spacewander commented on issue #3920: URL: https://github.com/apache/apisix/issues/3920#issuecomment-808899494 The `enable_http2` feature is first added in 2.4. See: https://github.com/apache/apisix/pull/3547 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] spacewander closed issue #3920: request help: nginx: [emerg] invalid port in "table:" of the "listen" directive in ...

2021-03-28 Thread GitBox
spacewander closed issue #3920: URL: https://github.com/apache/apisix/issues/3920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-28 Thread GitBox
Jaycean commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602878978 ## File path: web/cypress/fixtures/export-route-dataset.json ## @@ -131,7 +129,6 @@ } }, "x-apisix-enable_webs

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1673: fix: unable to export route with nil methods field

2021-03-28 Thread GitBox
nic-chen commented on a change in pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602877478 ## File path: web/cypress/fixtures/export-route-dataset.json ## @@ -131,7 +129,6 @@ } }, "x-apisix-enable_web

[GitHub] [apisix] iamayushdas commented on pull request #3922: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on pull request #3922: URL: https://github.com/apache/apisix/pull/3922#issuecomment-808893336 There's an error from Centos test only, i guess , what say @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
codecov-io edited a comment on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] iamayushdas commented on a change in pull request #3921: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on a change in pull request #3921: URL: https://github.com/apache/apisix/pull/3921#discussion_r602873810 ## File path: apisix/plugins/openid-connect.lua ## @@ -101,6 +101,7 @@ local schema = { local _M = { version = 0.1, priority = 2599, +ty

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
codecov-io commented on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/pull/168

[GitHub] [apisix-dashboard] Mm0mMMMM commented on pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
Mm0m commented on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890168 Hi, I see that the system info name needs to be changed in this issue and I have completed it. 😊😊 -- This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] Mm0mMMMM opened a new pull request #1686: chore: improve System Info module

2021-03-28 Thread GitBox
Mm0m opened a new pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided -

[GitHub] [apisix] iamayushdas opened a new pull request #3922: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas opened a new pull request #3922: URL: https://github.com/apache/apisix/pull/3922 Please answer these questions before submitting a pull request - Why submit this pull request? * [ ] Bugfix * [x] New feature provided * [ ] Improve performance * [ ] Backport patc

[GitHub] [apisix] iamayushdas closed pull request #3921: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas closed pull request #3921: URL: https://github.com/apache/apisix/pull/3921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [apisix-website] juzhiyuan merged pull request #273: Feat #216 add project

2021-03-28 Thread GitBox
juzhiyuan merged pull request #273: URL: https://github.com/apache/apisix-website/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-website] juzhiyuan closed issue #216: add more projects to /docs

2021-03-28 Thread GitBox
juzhiyuan closed issue #216: URL: https://github.com/apache/apisix-website/issues/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[apisix-website] branch master updated: feat: #216 add helm-chart project (#273)

2021-03-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 8184dc3 feat: #216 add helm-chart pr

[GitHub] [apisix-docker] juzhiyuan merged pull request #153: docs: move the md files to /docs/en/latest foleder

2021-03-28 Thread GitBox
juzhiyuan merged pull request #153: URL: https://github.com/apache/apisix-docker/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-docker] branch master updated: docs: move the md files to /docs/en/latest foleder (#153)

2021-03-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new 02d19b9 docs: move the md files to /d

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3921: docs: tells users where they are

2021-03-28 Thread GitBox
juzhiyuan commented on a change in pull request #3921: URL: https://github.com/apache/apisix/pull/3921#discussion_r602869421 ## File path: apisix/plugins/openid-connect.lua ## @@ -101,6 +101,7 @@ local schema = { local _M = { version = 0.1, priority = 2599, +type

[GitHub] [apisix] nic-chen commented on pull request #3921: docs: tells users where they are

2021-03-28 Thread GitBox
nic-chen commented on pull request #3921: URL: https://github.com/apache/apisix/pull/3921#issuecomment-808880055 @iamayushdas please have a look at TEST 9 in `t/admin/plugins.t` ``` # Failed test 'TEST 9: confirm the plugin of auth type - response_body - like (repeated req

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808878108 @juzhiyuan @guoqqqi @LiteSun @gxthrj have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] iamayushdas commented on pull request #3921: docs: tells users where they are

2021-03-28 Thread GitBox
iamayushdas commented on pull request #3921: URL: https://github.com/apache/apisix/pull/3921#issuecomment-808877673 @juzhiyuan have a look , in to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1679: feat: autocomplete when people input http header

2021-03-28 Thread GitBox
codecov-io commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808860155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=h1) Report > Merging [#1679](https://codecov.io/gh/apache/apisix-dashboard/pull/167