[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
starsz commented on a change in pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#discussion_r619600269 ## File path: api/internal/core/entity/format_test.go ## @@ -101,3 +101,53 @@ func TestNodesFormat_Map(t *testing.T) { assert.Contains(t,

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1816: feat: Use monaco editor

2021-04-23 Thread GitBox
codecov-commenter commented on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-826045073 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit f8152530d8676da15241d306ddb6e1ec79e75ded https://app.netlify.com/sites/a

[GitHub] [apisix] tokers opened a new pull request #4121: feat: support to use upstream_id in stream_route

2021-04-23 Thread GitBox
tokers opened a new pull request #4121: URL: https://github.com/apache/apisix/pull/4121 ### What this PR does / why we need it: Currently, we can only use `upstream` inside `stream_route`, although `upstream_id` is a valid field in it, it's not used totally. ### Pre-su

[GitHub] [apisix] tokers commented on issue #4112: chore: update architecture diagram

2021-04-23 Thread GitBox
tokers commented on issue #4112: URL: https://github.com/apache/apisix/issues/4112#issuecomment-826039774 @himanshu007-creator Assigned to you :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] himanshu007-creator commented on issue #4112: chore: update architecture diagram

2021-04-23 Thread GitBox
himanshu007-creator commented on issue #4112: URL: https://github.com/apache/apisix/issues/4112#issuecomment-826037176 Hi , i would like to work on this issue. Please assign me this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix-ingress-controller] tokers commented on issue #321: Add e2e test cases for plugins

2021-04-23 Thread GitBox
tokers commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-826034534 > Thanks for your reply! > > > > Help needed: is there any way to run test cases for just one plugin? I want to run test cases I wrote for plugin "server-info".

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 94189cb84b3bec2a3a54631aa2b40a3242fdc082 https://deploy-preview-1813--apisix-dash

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 94189cb84b3bec2a3a54631aa2b40a3242fdc082 https://app.netlify.com/sites/a

[GitHub] [apisix] winnetcn commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2021-04-23 Thread GitBox
winnetcn commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-826014675 Organization: purcotton.com Location: Shenzhen, China Contact: zeng...@winnermedical.com Scenario: Build a hybrid integrated platform(iPaaS), including Enterprise Gateway, API

[GitHub] [apisix] winnetcn commented on issue #4113: request help: Is there a plan to Support SAP RFC protocol conversion?

2021-04-23 Thread GitBox
winnetcn commented on issue #4113: URL: https://github.com/apache/apisix/issues/4113#issuecomment-826013601 Refer to this website:http://www.restcloud.cn/restcloud/mycms/sap.html and https://github.com/SAP/gorfc/blob/master/gorfc/gorfc.go -- This is an automated message from the Apache G

[GitHub] [apisix-website] juzhiyuan commented on pull request #318: chore: Test Docusaurus webpack 5 support

2021-04-23 Thread GitBox
juzhiyuan commented on pull request #318: URL: https://github.com/apache/apisix-website/pull/318#issuecomment-826007856 Wow! Welcome & Thanks for your PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1823: fix: add missing label in nodes component

2021-04-23 Thread GitBox
codecov-commenter commented on pull request #1823: URL: https://github.com/apache/apisix-dashboard/pull/1823#issuecomment-825804099 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1823?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-website] netlify[bot] commented on pull request #320: docs: download link in Release Guide

2021-04-23 Thread GitBox
netlify[bot] commented on pull request #320: URL: https://github.com/apache/apisix-website/pull/320#issuecomment-825802626 Deploy preview for *apisix* processing. Building with commit 2b051ed53f2d75de50f38318b676e37a587eab95 https://app.netlify.com/sites/apisix/deploys/608301fc

[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #320: docs: download link in Release Guide

2021-04-23 Thread GitBox
KishaniKandasamy opened a new pull request #320: URL: https://github.com/apache/apisix-website/pull/320 Fixes: #319 Changes: update Release Guide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-website] KishaniKandasamy opened a new issue #319: docs: download link in Release Guide

2021-04-23 Thread GitBox
KishaniKandasamy opened a new issue #319: URL: https://github.com/apache/apisix-website/issues/319 **Actual Behaviour** The download link in release guide is directed to https://github.com/apache/apisix-website ![Capture](https://user-images.githubusercontent.com/53715187/115906

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1823: fix: add missing label in nodes component

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1823: URL: https://github.com/apache/apisix-dashboard/pull/1823#issuecomment-825791751 Deploy preview for *apisix-dashboard* ready! Built with commit cfaee0c7cb5de93816762f9e06ddea6455e9f50a https://deploy-preview-1823--apisix-dash

[GitHub] [apisix-dashboard] ericsyh opened a new pull request #1823: Fix: add missing label in nodes component

2021-04-23 Thread GitBox
ericsyh opened a new pull request #1823: URL: https://github.com/apache/apisix-dashboard/pull/1823 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided -

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1823: Fix: add missing label in nodes component

2021-04-23 Thread GitBox
netlify[bot] commented on pull request #1823: URL: https://github.com/apache/apisix-dashboard/pull/1823#issuecomment-825791751 Deploy preview for *apisix-dashboard* processing. Building with commit cfaee0c7cb5de93816762f9e06ddea6455e9f50a https://app.netlify.com/sites/apisix-d

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1802: feat: rewrite route-with-jwt-plugin-test using ginkgo

2021-04-23 Thread GitBox
bisakhmondal commented on a change in pull request #1802: URL: https://github.com/apache/apisix-dashboard/pull/1802#discussion_r619370267 ## File path: api/test/e2enew/route/route_with_plugin_jwt_test.go ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #318: chore: Test Docusaurus webpack 5 support

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #318: URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138 Deploy preview for *apisix* ready! Built with commit 53aae2443b42eb0ffe297222e67d99d967c57e93 https://deploy-preview-318--apisix.netlify.app -- T

[GitHub] [apisix-website] netlify[bot] commented on pull request #318: chore: Test Docusaurus webpack 5 support

2021-04-23 Thread GitBox
netlify[bot] commented on pull request #318: URL: https://github.com/apache/apisix-website/pull/318#issuecomment-825774138 Deploy preview for *apisix* processing. Building with commit 53aae2443b42eb0ffe297222e67d99d967c57e93 https://app.netlify.com/sites/apisix/deploys/6082f5f2

[GitHub] [apisix-website] slorber opened a new pull request #318: chore: Test Docusaurus webpack 5 support

2021-04-23 Thread GitBox
slorber opened a new pull request #318: URL: https://github.com/apache/apisix-website/pull/318 Use an unreleased version of Docusaurus to test the webpack5 support works for this site. See also https://github.com/facebook/docusaurus/pull/4089 -- This is an automated message from t

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 2f694e34b0a7e105c22c1cbadda20ba039c9e568 https://deploy-preview-1813--apisix-dash

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 2f694e34b0a7e105c22c1cbadda20ba039c9e568 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 001e449530f184c83485977b55924a9953b2c4a1 https://deploy-preview-1813--apisix-dash

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 001e449530f184c83485977b55924a9953b2c4a1 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1818: feat: support more judgment conditions for plugin orchestration

2021-04-23 Thread GitBox
juzhiyuan commented on issue #1818: URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-825684952 😳 Could you explain more detailed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1815: [Fe]: issue regarding viewport in `route` page

2021-04-23 Thread GitBox
juzhiyuan commented on issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815#issuecomment-825681037 Good! There indeed has one configuration to enable scroll y -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] spacewander closed issue #4120: request help: 希望在openid-connect插件增加token有效期缓存机制

2021-04-23 Thread GitBox
spacewander closed issue #4120: URL: https://github.com/apache/apisix/issues/4120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [apisix] spacewander commented on issue #4120: request help: 希望在openid-connect插件增加token有效期缓存机制

2021-04-23 Thread GitBox
spacewander commented on issue #4120: URL: https://github.com/apache/apisix/issues/4120#issuecomment-825612375 The library we used already supported it: https://github.com/zmartzone/lua-resty-openidc/blob/4ff64540ece124a64f66c5f5c5ed6b2dd8a58483/lib/resty/openidc.lua#L1582 https://gi

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit d70f25c2e9fa5030eb1e2c16a9d4c4adbbf7ca51 https://deploy-preview-1813--apisix-dash

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit dcebacd59f21d385bf71994ba6fbb1105767cabb https://app.netlify.com/sites/a

[GitHub] [apisix] Firstsawyou commented on issue #4120: request help: 希望在openid-connect插件增加token有效期缓存机制

2021-04-23 Thread GitBox
Firstsawyou commented on issue #4120: URL: https://github.com/apache/apisix/issues/4120#issuecomment-825589636 The openid-connect plugin does not seem to support it yet. This is a very useful feature. @spacewander What do you think? -- This is an automated message from the Apache Git S

[GitHub] [apisix-ingress-controller] fhuzero commented on issue #321: Add e2e test cases for plugins

2021-04-23 Thread GitBox
fhuzero commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-825585993 Thanks for your reply! > > Help needed: is there any way to run test cases for just one plugin? I want to run test cases I wrote for plugin "server-info". Modi

[GitHub] [apisix] Firstsawyou commented on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Firstsawyou commented on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825585144 > But you can see in the log, the param 'request' without my params. You should provide sample code for this part. -- This is an automated message from the Apache Git Serv

[GitHub] [apisix] cranehovers opened a new issue #4120: request help: 希望在openid-connect插件增加token有效期缓存机制

2021-04-23 Thread GitBox
cranehovers opened a new issue #4120: URL: https://github.com/apache/apisix/issues/4120 ### Issue description 希望在openid-connect插件增加token缓存机制,每次和令牌服务器交互的时候,获取token的有效期,在token的有效期内,不再重复向令牌服务器请求,减少令牌服务器的压力 ### Environment * apisix version (cmd: `apisix version`): * OS (cmd: `un

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1822: docs : update FAQ in user guide

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1822: URL: https://github.com/apache/apisix-dashboard/pull/1822#issuecomment-825551082 Deploy preview for *apisix-dashboard* ready! Built with commit b2dd68dafc14f0a3b334058298136617dd3cc6d3 https://deploy-preview-1822--apisix-dash

[GitHub] [apisix-dashboard] KishaniKandasamy opened a new pull request #1822: docs : update FAQ in user guide

2021-04-23 Thread GitBox
KishaniKandasamy opened a new pull request #1822: URL: https://github.com/apache/apisix-dashboard/pull/1822 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [X] Bugfix - [ ] New feature provi

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1822: docs : update FAQ in user guide

2021-04-23 Thread GitBox
netlify[bot] commented on pull request #1822: URL: https://github.com/apache/apisix-dashboard/pull/1822#issuecomment-825551082 Deploy preview for *apisix-dashboard* processing. Building with commit b2dd68dafc14f0a3b334058298136617dd3cc6d3 https://app.netlify.com/sites/apisix-d

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in in user guide

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* ready! Built with commit a45ba91c9d0c446d8ad7dfc40435b8820e526019 https://deploy-preview-1808--apisix-dash

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1808: docs : FAQ in in user guide

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808#issuecomment-823429134 Deploy preview for *apisix-dashboard* processing. Building with commit a45ba91c9d0c446d8ad7dfc40435b8820e526019 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] KishaniKandasamy closed pull request #1808: docs : FAQ in in user guide

2021-04-23 Thread GitBox
KishaniKandasamy closed pull request #1808: URL: https://github.com/apache/apisix-dashboard/pull/1808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about th

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit e26fa5c150551ce405c14cb179ac19c4a475ee2d https://app.netlify.com/sites/a

[GitHub] [apisix-docker] juzhiyuan merged pull request #163: chore: dashboard release 2.6

2021-04-23 Thread GitBox
juzhiyuan merged pull request #163: URL: https://github.com/apache/apisix-docker/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-docker] branch master updated: chore: dashboard release 2.6 (#163)

2021-04-23 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new e829ecd chore: dashboard release 2.6

[GitHub] [apisix] tokers commented on a change in pull request #4114: feat: patch tcp.sock.connect to use our DNS resolver

2021-04-23 Thread GitBox
tokers commented on a change in pull request #4114: URL: https://github.com/apache/apisix/pull/4114#discussion_r619076945 ## File path: apisix/core/resolver.lua ## @@ -0,0 +1,51 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor licens

[GitHub] [apisix] riskgod edited a comment on issue #4117: { message: 'Invalid signature' } in hmac after add Date clock_skew

2021-04-23 Thread GitBox
riskgod edited a comment on issue #4117: URL: https://github.com/apache/apisix/issues/4117#issuecomment-825507023 > In the lower part of the hmac-auth plugin, adjust the log level to warn and check the log output. > > https://github.com/apache/apisix/blob/725e9879cdfba39b5a16e027f34

[GitHub] [apisix-ingress-controller] tokers commented on issue #321: Add e2e test cases for plugins

2021-04-23 Thread GitBox
tokers commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-825528321 > Help needed: is there any way to run test cases for just one plugin? I want to run test cases I wrote for plugin "server-info". Modifying ginkgo command under PHONY

[GitHub] [apisix] tokers commented on a change in pull request #4118: docs: added X-API-KEY introduction

2021-04-23 Thread GitBox
tokers commented on a change in pull request #4118: URL: https://github.com/apache/apisix/pull/4118#discussion_r619075379 ## File path: docs/en/latest/FAQ.md ## @@ -424,3 +424,45 @@ $ curl http://127.0.0.1:9080/ip -i HTTP/1.1 200 OK ... ``` + +## What is the `X-API-KEY` of A

[GitHub] [apisix-ingress-controller] tokers commented on issue #403: request help: apply -f upstrem.yaml cannot find the service

2021-04-23 Thread GitBox
tokers commented on issue #403: URL: https://github.com/apache/apisix-ingress-controller/issues/403#issuecomment-825527052 No, it's not related with the order to create these to objects. The error log prompts that there is an `ApisixUpstream` object in the `default` namespace which

[GitHub] [apisix] Hxhong edited a comment on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Hxhong edited a comment on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825515989 ![image](https://user-images.githubusercontent.com/42258295/115848274-46637d00-a456-11eb-87e7-6e2e6e7e1d1e.png) the first image I print the param 'upstream_uri' before I add o

[GitHub] [apisix] Firstsawyou edited a comment on issue #4117: { message: 'Invalid signature' } in hmac after add Date clock_skew

2021-04-23 Thread GitBox
Firstsawyou edited a comment on issue #4117: URL: https://github.com/apache/apisix/issues/4117#issuecomment-825420666 > ${dataNow} > User-Agent:curl/7.29.0 > x-custom-a:test The signature string here seems to be incorrect, we don't need a key in the signature header. You try it

[GitHub] [apisix-docker] nic-chen opened a new pull request #163: chore: dashboard release 2.6

2021-04-23 Thread GitBox
nic-chen opened a new pull request #163: URL: https://github.com/apache/apisix-docker/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [apisix] Hxhong commented on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Hxhong commented on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825515989 ![image](https://user-images.githubusercontent.com/42258295/115847191-47e07580-a455-11eb-8f06-81fa459aec66.png) the first image I print the param 'upstream_uri' before I add other pa

[GitHub] [apisix-dashboard] liuxiran commented on issue #1815: [Fe]: issue regarding viewport in `route` page

2021-04-23 Thread GitBox
liuxiran commented on issue #1815: URL: https://github.com/apache/apisix-dashboard/issues/1815#issuecomment-825515330 Inspired by antd: ![2021-04-23 16-59-44屏幕截图](https://user-images.githubusercontent.com/2561857/115847509-9e4db400-a455-11eb-83d6-925e5bd22185.png) add a scroll-y

[GitHub] [apisix] spacewander opened a new pull request #4119: feat(ext-plugin): step 2, add basic structure

2021-04-23 Thread GitBox
spacewander opened a new pull request #4119: URL: https://github.com/apache/apisix/pull/4119 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] riskgod commented on issue #4117: { message: 'Invalid signature' } in hmac after add Date clock_skew

2021-04-23 Thread GitBox
riskgod commented on issue #4117: URL: https://github.com/apache/apisix/issues/4117#issuecomment-825507023 > In the lower part of the hmac-auth plugin, adjust the log level to warn and check the log output. > > https://github.com/apache/apisix/blob/725e9879cdfba39b5a16e027f345ca26ee

[GitHub] [apisix] riskgod closed issue #4117: { message: 'Invalid signature' } in hmac after add Date clock_skew

2021-04-23 Thread GitBox
riskgod closed issue #4117: URL: https://github.com/apache/apisix/issues/4117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-823852872 Deploy preview for *apisix-dashboard* ready! Built with commit aa4535dcdb9f5fe4568bd600e9614cc3d146cdef https://deploy-preview-1812--apisix-dash

[GitHub] [apisix] Firstsawyou commented on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Firstsawyou commented on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825492956 > > > ctx.var.upstream_uri = upstream_uri > > > > > > Try to rewrite your URI in this way? > > it's the same... After using this method, can you provide acc

[GitHub] [apisix] Firstsawyou commented on issue #4117: { message: 'Invalid signature' } in hmac after add Date clock_skew

2021-04-23 Thread GitBox
Firstsawyou commented on issue #4117: URL: https://github.com/apache/apisix/issues/4117#issuecomment-825491372 In the lower part of the hmac-auth plugin, adjust the log level to warn and check the log output. https://github.com/apache/apisix/blob/725e9879cdfba39b5a16e027f345ca26ee43

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-825484125 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1812?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-823852872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-825484125 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1812?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-825484125 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1812?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1816: feat: Use monaco editor

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1816: URL: https://github.com/apache/apisix-dashboard/pull/1816#issuecomment-824585997 Deploy preview for *apisix-dashboard* processing. Building with commit e5b98bbac8e0991619771d0d05e05a4e7cafcab1 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
codecov-commenter commented on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-825484125 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1812?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-823852872 Deploy preview for *apisix-dashboard* processing. Building with commit a4a7e3edde0448783c45e06ba34a621559cb5dd6 https://app.netlify.com/sites/a

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823973919 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #401: feat: tcp route translation

2021-04-23 Thread GitBox
codecov-commenter edited a comment on pull request #401: URL: https://github.com/apache/apisix-ingress-controller/pull/401#issuecomment-824684718 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/401?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* ready! Built with commit 549b064d3032ebde3ead3152d245784783fb67d2 https://deploy-preview-1813--apisix-dash

[GitHub] [apisix] Hxhong commented on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Hxhong commented on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825473436 > @Hxhong you demo `priority = 1000` it seems to be duplicate of the existing plugin > and in plugin develop doc i find this > > > Note : The priority of the new plugin cannot

[GitHub] [apisix] Hxhong commented on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Hxhong commented on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825472803 > > ctx.var.upstream_uri = upstream_uri > > Try to rewrite your URI in this way? it's the same... -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1813: feat: refactor Plugin Orchestration

2021-04-23 Thread GitBox
netlify[bot] edited a comment on pull request #1813: URL: https://github.com/apache/apisix-dashboard/pull/1813#issuecomment-823954424 Deploy preview for *apisix-dashboard* processing. Building with commit 549b064d3032ebde3ead3152d245784783fb67d2 https://app.netlify.com/sites/a

[GitHub] [apisix-ingress-controller] fhuzero commented on issue #321: Add e2e test cases for plugins

2021-04-23 Thread GitBox
fhuzero commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-825467862 Help needed: is there any way to run test cases for just one plugin? I want to run test cases I wrote for plugin "server-info". Modifying ginkgo command under PHONY

[GitHub] [apisix] riskgod commented on issue #4117: { message: 'Invalid signature' } in hmac after add Date clock_skew

2021-04-23 Thread GitBox
riskgod commented on issue #4117: URL: https://github.com/apache/apisix/issues/4117#issuecomment-825460444 > Try to set the value of `clock_skew` to a higher value? still failed, after test 2 kind of valid, one is success without clock_skew, here is the test code ``` const

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1710: feat: duplicate upstream service consumer

2021-04-23 Thread GitBox
LiteSun commented on a change in pull request #1710: URL: https://github.com/apache/apisix-dashboard/pull/1710#discussion_r618998603 ## File path: web/src/pages/Upstream/Create.tsx ## @@ -30,13 +30,19 @@ const Page: React.FC = (props) => { const [form1] = Form.useForm();

[GitHub] [apisix-dashboard] LiteSun commented on issue #1810: style(fe): how about changing the navigation bar to dark?

2021-04-23 Thread GitBox
LiteSun commented on issue #1810: URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-825448305 Black looks more technological. LGTM+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] spacewander closed issue #4095: bug: cors() does not work after modifying

2021-04-23 Thread GitBox
spacewander closed issue #4095: URL: https://github.com/apache/apisix/issues/4095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [apisix] Firstsawyou commented on issue #4110: request help: I develop a plugin to rewrite URI, but it doesn't work. How to rewrite URI

2021-04-23 Thread GitBox
Firstsawyou commented on issue #4110: URL: https://github.com/apache/apisix/issues/4110#issuecomment-825441990 > ctx.var.upstream_uri = upstream_uri Try to rewrite your URI in this way? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1812: fix: can not configure upstream with no nodes

2021-04-23 Thread GitBox
liuxiran commented on pull request #1812: URL: https://github.com/apache/apisix-dashboard/pull/1812#issuecomment-825440571 > Hi, @liuxiran > In golang, you should distinguish `nil slice` and `empty slice` > > ``` > var x []*entity.Node > ``` > > is a nil slice. >