[GitHub] [apisix] spacewander commented on issue #4461: request help: How much lua_max_pending_timers should be set to

2021-07-07 Thread GitBox
spacewander commented on issue #4461: URL: https://github.com/apache/apisix/issues/4461#issuecomment-876181048 Can you analyze the stack trace and find out each type of timer caller and their numbers? BTW, your stack trace doesn't match the `balancer.lua` from the v2.2 version. It seems

[GitHub] [apisix] KishaniKandasamy commented on pull request #4562: docs: make the components of request URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy commented on pull request #4562: URL: https://github.com/apache/apisix/pull/4562#issuecomment-876177524 @juzhiyuan @Yiyiyimu @tzssangglass please give some review when you are available.. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix] KishaniKandasamy opened a new pull request #4562: docs: make the components of request URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy opened a new pull request #4562: URL: https://github.com/apache/apisix/pull/4562 ### What this PR does / why we need it: fix: #4526 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? *

[GitHub] [apisix] KishaniKandasamy commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-876164390 Yesss then It would be better doing so:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: 92eeef1eba6a220fcf7eefcdf00134a39211e125

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] spacewander commented on a change in pull request #4561: fix: metrics api etcd key not found warning

2021-07-07 Thread GitBox
spacewander commented on a change in pull request #4561: URL: https://github.com/apache/apisix/pull/4561#discussion_r665856352 ## File path: apisix/plugins/prometheus/exporter.lua ## @@ -308,7 +308,13 @@ function _M.collect() "processing metrics endp

[GitHub] [apisix] tzssangglass commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
tzssangglass commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-876109359 > Hi @tzssangglass , Thanks for the feedback but I thought we could omit port number in URLs, As if it is not given then the User may know that By default, HTTP uses port 80🤔.Wha

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 92eeef1eba6a220fcf7eefcdf00134a39211e1

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: 120a4cb21c995849805848f6055992b672a979c9

[GitHub] [apisix] kuberxy commented on issue #4461: request help: How much lua_max_pending_timers should be set to

2021-07-07 Thread GitBox
kuberxy commented on issue #4461: URL: https://github.com/apache/apisix/issues/4461#issuecomment-876102589 I get this infomations in error log after I use patch mechanism. ``` 2021/07/08 11:37:31 [error] 21507#21507: *116264 [lua] balancer.lua:96: create_obj_fun(): fail to create hea

[GitHub] [apisix] tzssangglass commented on issue #4534: apisix plugin 如何编写测试用例

2021-07-07 Thread GitBox
tzssangglass commented on issue #4534: URL: https://github.com/apache/apisix/issues/4534#issuecomment-876102533 hope it helps you: https://github.com/iresty/programming-openresty-zh/tree/master/testing -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] yzeng25 commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
yzeng25 commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-876100749 Hi all, after this morning's discussion, we decided to use the term "Upstream service" and "上游服务" in our documents. PR is ready for review,. @juzhiyuan @tokers @spacewander @Y

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 120a4cb21c995849805848f6055992b672a979

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-helm-chart] arabot777 opened a new issue #113: Can an external etcd cluster be used to install dashboard using helm?

2021-07-07 Thread GitBox
arabot777 opened a new issue #113: URL: https://github.com/apache/apisix-helm-chart/issues/113 I use command `helm install apisix apisix/apisix \ --set ingress-controller.enabled=true \ --set dashboard.enabled=true \ --set etcd.enabled=false \ --set etcd.host={http://192.168

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready! :hammer: Explore the source changes: 6fe548b35711cef8d1834717f37829dd3e9e2801

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
codecov-commenter edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864773105 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1946?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1946: refactor: migrate to viper configure manage

2021-07-07 Thread GitBox
netlify[bot] edited a comment on pull request #1946: URL: https://github.com/apache/apisix-dashboard/pull/1946#issuecomment-864770757 :construction_worker: Deploy Preview for *apisix-dashboard* processing. :hammer: Explore the source changes: 788864942152a6c9f8252a5ead33d86a99a83a

[GitHub] [apisix] liaomengge commented on a change in pull request #4462: docs: update global-rule.md

2021-07-07 Thread GitBox
liaomengge commented on a change in pull request #4462: URL: https://github.com/apache/apisix/pull/4462#discussion_r665839760 ## File path: docs/zh/latest/architecture-design/global-rule.md ## @@ -45,6 +45,7 @@ curl -X PUT \ 如上所注册的 `limit-count` 插件将会作用于所有的请求。 我们可以通过以下接口查看所有

[GitHub] [apisix] billnote opened a new pull request #4561: fix: metrics api etcd key not found warning

2021-07-07 Thread GitBox
billnote opened a new pull request #4561: URL: https://github.com/apache/apisix/pull/4561 ### What this PR does / why we need it: fix: [https://github.com/apache/apisix/issues/4552](url) ### Pre-submission checklist: * [ ] Did you explain what problem does this PR so

[GitHub] [apisix] billnote commented on issue #4552: bug: request prometheus metrics. throw etcd key not found: [/routes] warning

2021-07-07 Thread GitBox
billnote commented on issue #4552: URL: https://github.com/apache/apisix/issues/4552#issuecomment-876088074 ok, i will open a PR later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [apisix] KishaniKandasamy edited a comment on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy edited a comment on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-876079483 Hi @tzssangglass , Thanks for the feedback but I thought we could omit port number in URLs, As if it is not given then the User may know that By default, HTTP u

[GitHub] [apisix] KishaniKandasamy edited a comment on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy edited a comment on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-876079483 > > Hi everyone What about this? > > ![requesturl](https://user-images.githubusercontent.com/53715187/124796106-6c38f200-df6e-11eb-9338-1707559c0eb0.jpg) > >

[GitHub] [apisix] KishaniKandasamy commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-876079483 > > Hi everyone What about this? > > ![requesturl](https://user-images.githubusercontent.com/53715187/124796106-6c38f200-df6e-11eb-9338-1707559c0eb0.jpg) > > the por

[GitHub] [apisix] adugeek commented on pull request #4488: feat(stream): support stream subsystem discovery

2021-07-07 Thread GitBox
adugeek commented on pull request #4488: URL: https://github.com/apache/apisix/pull/4488#issuecomment-876076923 @tokers sorry, busying in the past week. and it takes a little time to learn "how to write test case" -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] Applenice commented on a change in pull request #4524: feat: support lua_shared_dict variable in ngx_tpl.lua loaded via configuration file

2021-07-07 Thread GitBox
Applenice commented on a change in pull request #4524: URL: https://github.com/apache/apisix/pull/4524#discussion_r665827451 ## File path: apisix/cli/ngx_tpl.lua ## @@ -57,7 +57,7 @@ env {*name*}; {% end %} {% end %} -{% if stream_proxy then %} +{% if stream then %} Review

[GitHub] [apisix] Applenice commented on a change in pull request #4524: feat: support lua_shared_dict variable in ngx_tpl.lua loaded via configuration file

2021-07-07 Thread GitBox
Applenice commented on a change in pull request #4524: URL: https://github.com/apache/apisix/pull/4524#discussion_r665826913 ## File path: conf/config-default.yaml ## @@ -96,6 +96,9 @@ apisix: # see https://github.com/api7/lua-resty-radixtr

[GitHub] [apisix-helm-chart] tokers commented on issue #111: feat: Optimize configuration items, add etcd.prefix and schema

2021-07-07 Thread GitBox
tokers commented on issue #111: URL: https://github.com/apache/apisix-helm-chart/issues/111#issuecomment-876073236 @dickens7 You mean this? https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L202 -- This is an automated message from the Apache Git Service.

[GitHub] [apisix] tokers commented on a change in pull request #4560: ci: refactor chaos test with ginkgo

2021-07-07 Thread GitBox
tokers commented on a change in pull request #4560: URL: https://github.com/apache/apisix/pull/4560#discussion_r665825043 ## File path: .github/workflows/chaos.yml ## @@ -40,30 +40,35 @@ jobs: kubectl get pods -n kube-system kubectl version - - name

[GitHub] [apisix] spacewander commented on pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-07 Thread GitBox
spacewander commented on pull request #4559: URL: https://github.com/apache/apisix/pull/4559#issuecomment-876069932 Need to make the CI pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] arthur-zhang commented on a change in pull request #4558: fix: has_route_not_under_apisix value is wrongly assigned

2021-07-07 Thread GitBox
arthur-zhang commented on a change in pull request #4558: URL: https://github.com/apache/apisix/pull/4558#discussion_r665818101 ## File path: apisix/api_router.lua ## @@ -90,14 +90,18 @@ function fetch_api_router() core.json.delay_encode(api_routes,

[GitHub] [apisix] spacewander commented on a change in pull request #4558: fix: has_route_not_under_apisix value is wrongly assigned

2021-07-07 Thread GitBox
spacewander commented on a change in pull request #4558: URL: https://github.com/apache/apisix/pull/4558#discussion_r665816077 ## File path: apisix/api_router.lua ## @@ -90,14 +90,18 @@ function fetch_api_router() core.json.delay_encode(api_routes, t

[GitHub] [apisix] arthur-zhang commented on a change in pull request #4558: fix: has_route_not_under_apisix value is wrongly assigned

2021-07-07 Thread GitBox
arthur-zhang commented on a change in pull request #4558: URL: https://github.com/apache/apisix/pull/4558#discussion_r665814650 ## File path: apisix/api_router.lua ## @@ -89,13 +89,20 @@ function fetch_api_router() core.log.debug("fetched api routes: ",

[GitHub] [apisix] tokers commented on issue #4555: Unable to access Prometheus mertics endpoint

2021-07-07 Thread GitBox
tokers commented on issue #4555: URL: https://github.com/apache/apisix/issues/4555#issuecomment-876053343 > I just learned about the changes to the Prometheus plugin since 2.6 in the official site's documentation, and I have now resolved the issue. But I think the documentation may have so

[GitHub] [apisix] LLLLimbo commented on issue #4555: Unable to access Prometheus mertics endpoint

2021-07-07 Thread GitBox
imbo commented on issue #4555: URL: https://github.com/apache/apisix/issues/4555#issuecomment-876050986 I just learned about the changes to the Prometheus plugin since 2.6 in the official site's documentation, and I have now resolved the issue. But I think the documentation may have so

[GitHub] [apisix] anjia0532 commented on issue #2140: request help: What IDE to use for development? How to debug?

2021-07-07 Thread GitBox
anjia0532 commented on issue #2140: URL: https://github.com/apache/apisix/issues/2140#issuecomment-876050182 Try a EmmyLua plugin with IDEA? Segmentfault's blog [使用idea调试lua代码-Openresty](https://segmentfault.com/a/119018430640) -- This is an automated message from the Apache Git Serv

[GitHub] [apisix-docker] tao12345666333 commented on issue #195: Request Error Code: 2000001 The manager-api and apache apisix are mismatched.

2021-07-07 Thread GitBox
tao12345666333 commented on issue #195: URL: https://github.com/apache/apisix-docker/issues/195#issuecomment-876049213 There is a version difference between apisix-dashboard and apisix now. For example, apisix v2.7 and apisix-dashboard v2.7 can work together. -- This is an automated me

[GitHub] [apisix-dashboard] starsz commented on issue #1965: This code snippet is confusing me

2021-07-07 Thread GitBox
starsz commented on issue #1965: URL: https://github.com/apache/apisix-dashboard/issues/1965#issuecomment-876045537 Oh, I found the reason. Because in the docker of CI, we don't add the version and hash into binary. So the version in manager-api is "", and will return the mismatch.

[GitHub] [apisix] anjia0532 commented on a change in pull request #4553: docs: How to fix `unable to get local issuer certificate` error

2021-07-07 Thread GitBox
anjia0532 commented on a change in pull request #4553: URL: https://github.com/apache/apisix/pull/4553#discussion_r665805261 ## File path: docs/en/latest/FAQ.md ## @@ -536,3 +536,19 @@ HTTP/1.1 200 OK "url": "http://127.0.0.1/get"; } ``` + +## How to fix `unable to get loc

[GitHub] [apisix] LLLLimbo commented on issue #4555: Unable to access Prometheus mertics endpoint

2021-07-07 Thread GitBox
imbo commented on issue #4555: URL: https://github.com/apache/apisix/issues/4555#issuecomment-876037228 > @imbo Can you access it from the inside of the APISIX container? Yes, no problem to access from inside -- This is an automated message from the Apache Git Service. To r

[GitHub] [apisix] spacewander commented on a change in pull request #4524: feat: support lua_shared_dict variable in ngx_tpl.lua loaded via configuration file

2021-07-07 Thread GitBox
spacewander commented on a change in pull request #4524: URL: https://github.com/apache/apisix/pull/4524#discussion_r665796523 ## File path: conf/config-default.yaml ## @@ -96,6 +96,9 @@ apisix: # see https://github.com/api7/lua-resty-radix

[GitHub] [apisix] spacewander commented on a change in pull request #4558: fix: has_route_not_under_apisix value is wrongly assigned

2021-07-07 Thread GitBox
spacewander commented on a change in pull request #4558: URL: https://github.com/apache/apisix/pull/4558#discussion_r665796956 ## File path: apisix/api_router.lua ## @@ -89,13 +89,20 @@ function fetch_api_router() core.log.debug("fetched api routes: ",

[GitHub] [apisix-docker] luckydog85 commented on issue #195: Request Error Code: 2000001 The manager-api and apache apisix are mismatched.

2021-07-07 Thread GitBox
luckydog85 commented on issue #195: URL: https://github.com/apache/apisix-docker/issues/195#issuecomment-876034203 自带同版本怎么不匹配 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [apisix-docker] luckydog85 opened a new issue #195: Request Error Code: 2000001 The manager-api and apache apisix are mismatched.

2021-07-07 Thread GitBox
luckydog85 opened a new issue #195: URL: https://github.com/apache/apisix-docker/issues/195 ![image](https://user-images.githubusercontent.com/10277372/124845897-45100e00-dfca-11eb-9b89-05ee992ce636.png) -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix] Yiyiyimu opened a new pull request #4560: ci: refactor chaos test with ginkgo

2021-07-07 Thread GitBox
Yiyiyimu opened a new pull request #4560: URL: https://github.com/apache/apisix/pull/4560 Signed-off-by: yiyiyimu ### What this PR does / why we need it: Split #4315 to make review easier ### Pre-submission checklist: * [ ] Did you explain what problem does this PR s

[GitHub] [apisix] tzssangglass commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
tzssangglass commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-875849483 > Hi everyone What about this? > ![requesturl](https://user-images.githubusercontent.com/53715187/124796106-6c38f200-df6e-11eb-9338-1707559c0eb0.jpg) the port part is mi

[GitHub] [apisix] tzssangglass commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
tzssangglass commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-875849131 > Hi @KishaniKandasamy sorry I failed to get which place should we change I think he meant to turn the text description of the url, such as protocl, host, etc., into the fo

[GitHub] [apisix] tzssangglass commented on a change in pull request #4462: docs: update global-rule.md

2021-07-07 Thread GitBox
tzssangglass commented on a change in pull request #4462: URL: https://github.com/apache/apisix/pull/4462#discussion_r657973130 ## File path: docs/zh/latest/architecture-design/global-rule.md ## @@ -45,6 +45,7 @@ curl -X PUT \ 如上所注册的 `limit-count` 插件将会作用于所有的请求。 我们可以通过以下接口查看

[GitHub] [apisix] tzssangglass commented on a change in pull request #4462: docs: update global-rule.md

2021-07-07 Thread GitBox
tzssangglass commented on a change in pull request #4462: URL: https://github.com/apache/apisix/pull/4462#discussion_r665602371 ## File path: docs/zh/latest/architecture-design/global-rule.md ## @@ -45,6 +45,7 @@ curl -X PUT \ 如上所注册的 `limit-count` 插件将会作用于所有的请求。 我们可以通过以下接口查看

[GitHub] [apisix] tzssangglass commented on pull request #4498: docs: added /apisix/admin/plugins/reload into admin-api.md

2021-07-07 Thread GitBox
tzssangglass commented on pull request #4498: URL: https://github.com/apache/apisix/pull/4498#issuecomment-875809681 hi, @Patil2099, any news? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-helm-chart] dickens7 opened a new issue #111: feat: Optimize configuration items, add etcd.prefix and schema

2021-07-07 Thread GitBox
dickens7 opened a new issue #111: URL: https://github.com/apache/apisix-helm-chart/issues/111 Optimize configuration items, add etcd.prefix and schema -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix-dashboard] dickens7 closed issue #1970: feat: Optimize configuration items, add etcd.prefix and schema

2021-07-07 Thread GitBox
dickens7 closed issue #1970: URL: https://github.com/apache/apisix-dashboard/issues/1970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [apisix-helm-chart] dickens7 opened a new pull request #112: feat: Optimize configuration items, add etcd.prefix and schema

2021-07-07 Thread GitBox
dickens7 opened a new pull request #112: URL: https://github.com/apache/apisix-helm-chart/pull/112 #111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [apisix-dashboard] dickens7 commented on issue #1970: feat: Optimize configuration items, add etcd.prefix and schema

2021-07-07 Thread GitBox
dickens7 commented on issue #1970: URL: https://github.com/apache/apisix-dashboard/issues/1970#issuecomment-875798036 Wrong place -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix-dashboard] dickens7 opened a new issue #1970: feat: Optimize configuration items, add etcd.prefix and schema

2021-07-07 Thread GitBox
dickens7 opened a new issue #1970: URL: https://github.com/apache/apisix-dashboard/issues/1970 # Feature request Optimize configuration items, add etcd.prefix and schema -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] Yiyiyimu commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
Yiyiyimu commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-875790579 Hi @KishaniKandasamy sorry I failed to get which place should we change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] Yiyiyimu commented on pull request #4549: feat: enable balancer phase for plugins

2021-07-07 Thread GitBox
Yiyiyimu commented on pull request #4549: URL: https://github.com/apache/apisix/pull/4549#issuecomment-875787466 cc @dmsolr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] KishaniKandasamy commented on issue #4526: [DISCUSS] Make parts of API URL much simpler

2021-07-07 Thread GitBox
KishaniKandasamy commented on issue #4526: URL: https://github.com/apache/apisix/issues/4526#issuecomment-875753215 Hi everyone What about this? ![requesturl](https://user-images.githubusercontent.com/53715187/124796106-6c38f200-df6e-11eb-9338-1707559c0eb0.jpg) -- This is an autom

[GitHub] [apisix] KishaniKandasamy commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
KishaniKandasamy commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875743610 > what do you think? @KishaniKandasamy @iamayushdas Yes It is a much better way to understand internal words -- This is an automated message from t

[GitHub] [apisix] Yiyiyimu commented on issue #4552: bug: request prometheus metrics. throw etcd key not found: [/routes] warning

2021-07-07 Thread GitBox
Yiyiyimu commented on issue #4552: URL: https://github.com/apache/apisix/issues/4552#issuecomment-875742336 @billnote do you mind propose a PR to fix it~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] Yiyiyimu commented on issue #4547: bug: 404 route not found if URI contains %0A

2021-07-07 Thread GitBox
Yiyiyimu commented on issue #4547: URL: https://github.com/apache/apisix/issues/4547#issuecomment-875737576 need to use new version before closing this issue. my bad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] yzeng25 commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
yzeng25 commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875732303 > > Hi, AFAIK, Upstream is used in Apache APISIX (as an Entity) and Kong (as an Upstream Object), it's more technical but not easy to understand > > > > Hi I think

[GitHub] [apisix] Yiyiyimu closed issue #4547: bug: 404 route not found if URI contains %0A

2021-07-07 Thread GitBox
Yiyiyimu closed issue #4547: URL: https://github.com/apache/apisix/issues/4547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [apisix] Yiyiyimu commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
Yiyiyimu commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875725712 > Hi, AFAIK, Upstream is used in Apache APISIX (as an Entity) and Kong (as an Upstream Object), it's more technical but not easy to understand Hi I think the reason we cal

[GitHub] [apisix-dashboard] starsz commented on pull request #1968: feat: When Dashboard and APISIX version do not match, make the prompt information clearer (#1944)

2021-07-07 Thread GitBox
starsz commented on pull request #1968: URL: https://github.com/apache/apisix-dashboard/pull/1968#issuecomment-875709384 Hello @RedemptionC, need to fix the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] dickens7 opened a new pull request #4559: feat Request-ID plugin add snowflake algorithm

2021-07-07 Thread GitBox
dickens7 opened a new pull request #4559: URL: https://github.com/apache/apisix/pull/4559 ### What this PR does / why we need it: #4209 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have

[GitHub] [apisix] arthur-zhang opened a new pull request #4558: fix: has_route_not_under_apisix value is wrongly assigned

2021-07-07 Thread GitBox
arthur-zhang opened a new pull request #4558: URL: https://github.com/apache/apisix/pull/4558 has_route_not_under_apisix is wrongly assigned, which will cause router strange behaviour. `has_route_not_under_apisix` is initiated to `false`, and fetch_api_router() method is iterating

[GitHub] [apisix] dickens7 commented on pull request #4212: [WIP] feat snowflake plugin

2021-07-07 Thread GitBox
dickens7 commented on pull request #4212: URL: https://github.com/apache/apisix/pull/4212#issuecomment-875701161 Refactor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [apisix] dickens7 closed pull request #4212: [WIP] feat snowflake plugin

2021-07-07 Thread GitBox
dickens7 closed pull request #4212: URL: https://github.com/apache/apisix/pull/4212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[apisix-website] branch master updated: fix: added icon to go runner doc card (#404)

2021-07-07 Thread shuyangw
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 6571ab4 fix: added icon to go runner

[GitHub] [apisix-website] Yiyiyimu merged pull request #404: fix: added icon to go runner doc card

2021-07-07 Thread GitBox
Yiyiyimu merged pull request #404: URL: https://github.com/apache/apisix-website/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-website] Yiyiyimu merged pull request #405: fix: miss the "Plugin" in the label

2021-07-07 Thread GitBox
Yiyiyimu merged pull request #405: URL: https://github.com/apache/apisix-website/pull/405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[apisix-website] branch master updated (4763885 -> a2fc6af)

2021-07-07 Thread shuyangw
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 4763885 docs: added celebrate 200 contributors blog (#401) add a2fc6af fix: miss the "Plugin" in the

[GitHub] [apisix] spacewander opened a new pull request #4557: feat: increase ext-plugin timeout to 60s

2021-07-07 Thread GitBox
spacewander opened a new pull request #4557: URL: https://github.com/apache/apisix/pull/4557 5s is not enough Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR

[GitHub] [apisix] iamayushdas commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
iamayushdas commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875601330 Table is a good option but what do you think , where will you be placing that table, IMO we could place them in "general" -- This is an automated message from the Apache G

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1969: request help: imported configuration can't be deleted

2021-07-07 Thread GitBox
juzhiyuan commented on issue #1969: URL: https://github.com/apache/apisix-dashboard/issues/1969#issuecomment-875594045 @philzhangrui Hi, could you please provide your steps in detail? I would love to help to have a check. -- This is an automated message from the Apache Git Service. To r

[GitHub] [apisix-website] juzhiyuan merged pull request #401: docs: added celebrate 200 contributors blog

2021-07-07 Thread GitBox
juzhiyuan merged pull request #401: URL: https://github.com/apache/apisix-website/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[apisix-website] branch master updated: docs: added celebrate 200 contributors blog (#401)

2021-07-07 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 4763885 docs: added celebrate 200 co

[GitHub] [apisix] juzhiyuan commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
juzhiyuan commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875591854 what do you think? @KishaniKandasamy @iamayushdas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] juzhiyuan commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
juzhiyuan commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875591705 > Similarly, here is what I would ask: is there an "upstream" since there is no "downstream"? which of the following is more broadly accepted, "后端服务", or "上游"? Hi, AFAIK

[GitHub] [apisix] yzeng25 commented on pull request #4546: docs: update CN and EN getting-started documents

2021-07-07 Thread GitBox
yzeng25 commented on pull request #4546: URL: https://github.com/apache/apisix/pull/4546#issuecomment-875582063 > > I think it's not appropriate to call it "后端服务" since there is no "前端". Maybe call it "上游" is more accurate > > If we decide to use the term "上游",then we may use it ever

[GitHub] [apisix] zuiyangqingzhou commented on issue #4556: bug: the limit-conn plugin has a bug

2021-07-07 Thread GitBox
zuiyangqingzhou commented on issue #4556: URL: https://github.com/apache/apisix/issues/4556#issuecomment-875580794 Are there any plans to fix this problem? Because some scenarios require global rules to cooperate with routes -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] tokers commented on issue #4550: bug: 启用Kafka-logger,批量上报到后台的日志格式为JSONArray,而非JSONObject格式,跟JAVA客户端的批量上报实现有区别。

2021-07-07 Thread GitBox
tokers commented on issue #4550: URL: https://github.com/apache/apisix/issues/4550#issuecomment-875550442 By saying `JSONArray`, you mean the format like: ```json [ {...}, {...}, {...} ] ``` Or just like the following: ```json {...} {...}

[GitHub] [apisix] tokers commented on a change in pull request #4553: doc(faq.md): How to fix `unable to get local issuer certificate` error

2021-07-07 Thread GitBox
tokers commented on a change in pull request #4553: URL: https://github.com/apache/apisix/pull/4553#discussion_r665308155 ## File path: docs/en/latest/FAQ.md ## @@ -536,3 +536,19 @@ HTTP/1.1 200 OK "url": "http://127.0.0.1/get"; } ``` + +## How to fix `unable to get local

[apisix] branch master updated: feat(cli): check listen port conflicts with each other (#4540)

2021-07-07 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 765b7f1 feat(cli): check listen port conflicts

[GitHub] [apisix] tokers merged pull request #4540: feat(cli): check listen port conflicts with each other

2021-07-07 Thread GitBox
tokers merged pull request #4540: URL: https://github.com/apache/apisix/pull/4540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1968: feat: When Dashboard and APISIX version do not match, make the prompt information clearer (#1944)

2021-07-07 Thread GitBox
tokers commented on a change in pull request #1968: URL: https://github.com/apache/apisix-dashboard/pull/1968#discussion_r665306494 ## File path: api/internal/handler/tool/tool.go ## @@ -101,9 +102,11 @@ func (h *Handler) VersionMatch(c droplet.Context) (interface{}, error) {

[GitHub] [apisix] tokers commented on issue #4555: Unable to access Prometheus mertics endpoint

2021-07-07 Thread GitBox
tokers commented on issue #4555: URL: https://github.com/apache/apisix/issues/4555#issuecomment-875545583 @imbo Can you access it from the inside of the APISIX container? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] tokers commented on issue #4556: bug: the limit-conn plugin has a bug

2021-07-07 Thread GitBox
tokers commented on issue #4556: URL: https://github.com/apache/apisix/issues/4556#issuecomment-875544366 That's a known issue, we should avoid running same plugins both in global rules and routes (especially with same configurations). -- This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #576: feat: add logic for ApisixRoute v2beta1

2021-07-07 Thread GitBox
tokers commented on a change in pull request #576: URL: https://github.com/apache/apisix-ingress-controller/pull/576#discussion_r665302140 ## File path: pkg/kube/translation/apisix_route.go ## @@ -133,6 +134,150 @@ func (t *translator) translateHTTPRouteNotStrictly(ctx *Trans

  1   2   >