[GitHub] [apisix] yzeng25 commented on a change in pull request #4577: docs: update CN and EN how-to-build document

2021-07-13 Thread GitBox
yzeng25 commented on a change in pull request #4577: URL: https://github.com/apache/apisix/pull/4577#discussion_r669337981 ## File path: docs/zh/latest/how-to-build.md ## @@ -21,146 +21,219 @@ title: 如何构建 Apache APISIX # --> -## 1. 安装依赖 +## 步骤1:安装依赖 -Apache APISIX 的运行环境需要

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1981: ApiSix-Dashboard white screen

2021-07-13 Thread GitBox
juzhiyuan commented on issue #1981: URL: https://github.com/apache/apisix-dashboard/issues/1981#issuecomment-879637805 cc @iamayushdas to have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4577: docs: update CN and EN how-to-build document

2021-07-13 Thread GitBox
juzhiyuan commented on a change in pull request #4577: URL: https://github.com/apache/apisix/pull/4577#discussion_r669335662 ## File path: docs/zh/latest/how-to-build.md ## @@ -21,146 +21,219 @@ title: 如何构建 Apache APISIX # --> -## 1. 安装依赖 +## 步骤1:安装依赖 -Apache APISIX 的运行环境

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

2021-07-13 Thread GitBox
juzhiyuan commented on issue #1980: URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879636998 yes, I would prefer keeping the `closeOnMask = false` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #410: feat: added company who uses Apache APISIX logo

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #410: URL: https://github.com/apache/apisix-website/pull/410#issuecomment-878749034 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: b73bd40fa96e13fde11b581c466f3ce852f2aa16 :mag: Inspec

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #410: feat: added company who uses Apache APISIX logo

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #410: URL: https://github.com/apache/apisix-website/pull/410#issuecomment-878749034 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: b73bd40fa96e13fde11b581c466f3ce852f2aa16 :mag

[GitHub] [apisix-helm-chart] tokers commented on pull request #114: chore: 🔧 Add json schema to validate helm3 values.

2021-07-13 Thread GitBox
tokers commented on pull request #114: URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879618865 > > @CloudXiaobai It seems that this schema is not complete. > > Yes, I think it is sufficient to check only the core parts, most users will not bother to configure

[GitHub] [apisix-helm-chart] tokers removed a comment on pull request #114: chore: 🔧 Add json schema to validate helm3 values.

2021-07-13 Thread GitBox
tokers removed a comment on pull request #114: URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879618042 > Yes, I think it is sufficient to check only the core parts, most users will not bother to configure the full value file. We may use some tools to help us

[GitHub] [apisix-helm-chart] tokers commented on pull request #114: chore: 🔧 Add json schema to validate helm3 values.

2021-07-13 Thread GitBox
tokers commented on pull request #114: URL: https://github.com/apache/apisix-helm-chart/pull/114#issuecomment-879618042 > Yes, I think it is sufficient to check only the core parts, most users will not bother to configure the full value file. We may use some tools to help us to gener

[GitHub] [apisix-ingress-controller] tokers merged pull request #590: fix: modify ingress controller docker image version to 1.0.0

2021-07-13 Thread GitBox
tokers merged pull request #590: URL: https://github.com/apache/apisix-ingress-controller/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix-ingress-controller] branch v1.0.0 updated: fix: modify ingress controller docker image version to 1.0.0 (#590)

2021-07-13 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch v1.0.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/v1.0.0 by this push: new 50f0859 fix: modify ingress

[GitHub] [apisix-dashboard] wjmmjr opened a new issue #1981: ApiSix-Dashboard white screen

2021-07-13 Thread GitBox
wjmmjr opened a new issue #1981: URL: https://github.com/apache/apisix-dashboard/issues/1981 ## Issue description When I fill in “Select Upstream”,The screen turned white.The premise is that I didn't create any upstream ## Expected behavior ## How to Reproduce ![52(C

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #1944: When Dashboard and APISIX version do not match, make the prompt information clearer

2021-07-13 Thread GitBox
juzhiyuan edited a comment on issue #1944: URL: https://github.com/apache/apisix-dashboard/issues/1944#issuecomment-879611188 also cc @liuxiran @nic-chen @RedemptionC @Applenice @iamayushdas @sshniro @guoqqqi to have a look, thanks! -- This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1944: When Dashboard and APISIX version do not match, make the prompt information clearer

2021-07-13 Thread GitBox
juzhiyuan commented on issue #1944: URL: https://github.com/apache/apisix-dashboard/issues/1944#issuecomment-879611188 also cc @liuxiran @nic-chen @RedemptionC @Applenice @iamayushdas @sshniro to have a look, thanks! -- This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1944: When Dashboard and APISIX version do not match, make the prompt information clearer

2021-07-13 Thread GitBox
juzhiyuan commented on issue #1944: URL: https://github.com/apache/apisix-dashboard/issues/1944#issuecomment-879610792 In fact, we could also support telling users where to download the compatible software, and how to upgrade it. Also, if the Dashboard has the ability to handle fiel

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1944: When Dashboard and APISIX version do not match, make the prompt information clearer

2021-07-13 Thread GitBox
juzhiyuan commented on issue #1944: URL: https://github.com/apache/apisix-dashboard/issues/1944#issuecomment-879607016 ## Background Currently, Apache APISIX Dashboard and Apache APISIX are two separate projects (hereinafter referred to as Dashboard and APISIX). Whenever APISIX cha

[GitHub] [apisix-dashboard] foolwc commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

2021-07-13 Thread GitBox
foolwc commented on issue #1980: URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879606711 Maybe we could use Ant Design Drawer component in a uniform way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] bluesgao commented on a change in pull request #4575: fix: ref check while deleting proto via Admin API

2021-07-13 Thread GitBox
bluesgao commented on a change in pull request #4575: URL: https://github.com/apache/apisix/pull/4575#discussion_r669303618 ## File path: t/admin/proto.t ## @@ -0,0 +1,233 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreeme

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-878784559 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: a7608465d50a4159fc3b763f3f20bada11145509 :mag: Inspec

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-878784559 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: a7608465d50a4159fc3b763f3f20bada11145509 :mag

[GitHub] [apisix-website] juzhiyuan commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879583918 just merged, please sync master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-website] juzhiyuan merged pull request #412: docs: release ingress 1.1

2021-07-13 Thread GitBox
juzhiyuan merged pull request #412: URL: https://github.com/apache/apisix-website/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[apisix-website] branch master updated: docs: release ingress 1.1 (#412)

2021-07-13 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 530a91b docs: release ingress 1.1 (#

[GitHub] [apisix-website] iamayushdas commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879583663 > @iamayushdas You need more patience and focus on why this error occurred, just go through the codes and think why. I acknowledge this, thanks -- This is an a

[GitHub] [apisix-website] juzhiyuan commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879583242 @iamayushdas You need more patience and focus on why this error occurred, just go through the codes and think why. -- This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1979: feat: set a initial weight value for the upstream node

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #1979: URL: https://github.com/apache/apisix-dashboard/pull/1979#issuecomment-879582789 so should we allow the default value 1? @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

2021-07-13 Thread GitBox
juzhiyuan closed issue #1980: URL: https://github.com/apache/apisix-dashboard/issues/1980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-website] iamayushdas commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879582084 > Just fixed this issue here https://github.com/apache/apisix-website/pull/412/files#diff-2c12df13ad0ff398ec46834d8336f3d6e5089a89a1d2b7c39f5f209abcec0217R163 > >

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

2021-07-13 Thread GitBox
juzhiyuan commented on issue #1980: URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879582161 This is not a bug, just a configuration from Ant Design component. Why we should allow the click mask to close? Once it's closed, how about the editing data? -- This i

[GitHub] [apisix-website] juzhiyuan commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879581397 After #412 gets merged, please sync codes from the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-website] juzhiyuan commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879581228 Just fixed this issue here https://github.com/apache/apisix-website/pull/412/files#diff-2c12df13ad0ff398ec46834d8336f3d6e5089a89a1d2b7c39f5f209abcec0217R163 And yes

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #412: docs: release ingress 1.1

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #412: URL: https://github.com/apache/apisix-website/pull/412#issuecomment-879551896 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: e3011eb73f6340cbc54a0beb3dd7cb9f936a7b39 :mag: Inspec

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #412: docs: release ingress 1.1

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #412: URL: https://github.com/apache/apisix-website/pull/412#issuecomment-879551896 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: e3011eb73f6340cbc54a0beb3dd7cb9f936a7b39 :mag

[GitHub] [apisix] spacewander commented on a change in pull request #4549: feat: enable balancer phase for plugins

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4549: URL: https://github.com/apache/apisix/pull/4549#discussion_r669267826 ## File path: t/plugin/serverless.t ## @@ -679,3 +679,159 @@ GET /hello --- error_log default phase: access match uri /hello + + + +=== TEST 23: run

[apisix] branch master updated: feat: enable balancer phase for plugins (#4549)

2021-07-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3509d1d feat: enable balancer phase for pl

[GitHub] [apisix] spacewander merged pull request #4549: feat: enable balancer phase for plugins

2021-07-13 Thread GitBox
spacewander merged pull request #4549: URL: https://github.com/apache/apisix/pull/4549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] spacewander commented on a change in pull request #4575: fix: ref check while deleting proto via Admin API

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4575: URL: https://github.com/apache/apisix/pull/4575#discussion_r669266447 ## File path: t/admin/proto.t ## @@ -0,0 +1,233 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agre

[GitHub] [apisix] tzssangglass commented on a change in pull request #4549: feat: enable balancer phase for plugins

2021-07-13 Thread GitBox
tzssangglass commented on a change in pull request #4549: URL: https://github.com/apache/apisix/pull/4549#discussion_r669261787 ## File path: t/plugin/serverless.t ## @@ -679,3 +679,159 @@ GET /hello --- error_log default phase: access match uri /hello + + + +=== TEST 23: ru

[GitHub] [apisix] membphis commented on pull request #3894: feat: Add ldap-auth plugin

2021-07-13 Thread GitBox
membphis commented on pull request #3894: URL: https://github.com/apache/apisix/pull/3894#issuecomment-879557970 > @membphis @moonming > Can we introduce libldap as an extern dependency? This library needs to be installed manually. @moonming need your help. ^_^ -- This is an au

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #410: feat: added company who uses Apache APISIX logo

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #410: URL: https://github.com/apache/apisix-website/pull/410#issuecomment-878749034 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: 5b5622987155a4bb0188a058b8a20b4cb9d5c85b :mag: Inspec

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #410: feat: added company who uses Apache APISIX logo

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #410: URL: https://github.com/apache/apisix-website/pull/410#issuecomment-878749034 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: 5b5622987155a4bb0188a058b8a20b4cb9d5c85b :mag

[GitHub] [apisix-website] iamayushdas edited a comment on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas edited a comment on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879554248 I got you @Yiyiyimu Oh! Thats where the problem arises, but we are just using main/master branches, let me reconfirm with @juzhiyuan -- This is an automa

[GitHub] [apisix-website] iamayushdas commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879554248 Oh! Thats where the problem arises, but we are just using main/master branches, let me reconfirm with @juzhiyuan -- This is an automated message from the Apache

[GitHub] [apisix-dashboard] nic-chen commented on issue #1975: bug: error using the openid-connect plugin

2021-07-13 Thread GitBox
nic-chen commented on issue #1975: URL: https://github.com/apache/apisix-dashboard/issues/1975#issuecomment-879553340 > `client_id`, `client_secret`,`discovery` are required. cc @juzhiyuan @LiteSun yes, it needs to be configured for the plugin `openid-connect` in the route. @LiteSu

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #412: docs: release ingress 1.1

2021-07-13 Thread GitBox
netlify[bot] edited a comment on pull request #412: URL: https://github.com/apache/apisix-website/pull/412#issuecomment-879551896 :heavy_check_mark: Deploy Preview for *apisix* ready! :hammer: Explore the source changes: a94f1d8c35da25b85ad5dae353b604c88ca271ed :mag: Inspec

[GitHub] [apisix-website] netlify[bot] commented on pull request #412: docs: release ingress 1.1

2021-07-13 Thread GitBox
netlify[bot] commented on pull request #412: URL: https://github.com/apache/apisix-website/pull/412#issuecomment-879551896 :construction_worker: Deploy Preview for *apisix* processing. :hammer: Explore the source changes: a94f1d8c35da25b85ad5dae353b604c88ca271ed :mag: Inspe

[GitHub] [apisix-website] gxthrj opened a new pull request #412: docs: release ingress 1.1

2021-07-13 Thread GitBox
gxthrj opened a new pull request #412: URL: https://github.com/apache/apisix-website/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

2021-07-13 Thread GitBox
iamayushdas commented on issue #1980: URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879548549 Hmm, Right. We should have that feature. Agree? cc @juzhiyuan @liuxiran -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-dashboard] foolwc opened a new issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

2021-07-13 Thread GitBox
foolwc opened a new issue #1980: URL: https://github.com/apache/apisix-dashboard/issues/1980 ## Issue description Plugin config drawer onClose has no animation and cannot close by clicking mask. ## Expected behavior Just like other dawer: consumer view drawer. ## How to Repr

[GitHub] [apisix] spacewander closed issue #4571: bug: `Skywalking` plugin can not be enabled both in Global and Route rules.

2021-07-13 Thread GitBox
spacewander closed issue #4571: URL: https://github.com/apache/apisix/issues/4571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] spacewander merged pull request #4589: fix(skywalking): handle conflict between global rule and route

2021-07-13 Thread GitBox
spacewander merged pull request #4589: URL: https://github.com/apache/apisix/pull/4589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: fix(skywalking): handle conflict between global rule and route (#4589)

2021-07-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 9bcca2c fix(skywalking): handle conflict b

[GitHub] [apisix] spacewander merged pull request #4586: docs: don't need to modify config-default.yaml to add your plugin

2021-07-13 Thread GitBox
spacewander merged pull request #4586: URL: https://github.com/apache/apisix/pull/4586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated (302073e -> 816de42)

2021-07-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 302073e test: clean fake upstream API (#4578) add 816de42 docs: don't need to modify config-default.yaml

[GitHub] [apisix] spacewander commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r669242926 ## File path: docs/zh/latest/plugins/request-id.md ## @@ -71,6 +72,99 @@ X-Request-Id: fe32076a-d0a5-49a6-a361-6c244c1df956 .. ``` +### 使用 snow

[GitHub] [apisix] spacewander merged pull request #4578: test: clean fake upstream API

2021-07-13 Thread GitBox
spacewander merged pull request #4578: URL: https://github.com/apache/apisix/pull/4578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: test: clean fake upstream API (#4578)

2021-07-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 302073e test: clean fake upstream API (#45

[GitHub] [apisix] spacewander commented on a change in pull request #4549: feat: enable balancer phase for plugins

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4549: URL: https://github.com/apache/apisix/pull/4549#discussion_r669242229 ## File path: apisix/balancer.lua ## @@ -308,15 +309,24 @@ function _M.run(route, ctx) return core.response.exit(502) end +

[GitHub] [apisix] dickens7 commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-13 Thread GitBox
dickens7 commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r669241399 ## File path: apisix/plugins/request-id.lua ## @@ -14,25 +14,58 @@ -- See the License for the specific language governing permissions and -- limitations

[GitHub] [apisix] dickens7 commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-13 Thread GitBox
dickens7 commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r669241158 ## File path: docs/zh/latest/plugins/request-id.md ## @@ -71,6 +72,99 @@ X-Request-Id: fe32076a-d0a5-49a6-a361-6c244c1df956 .. ``` +### 使用 snowfla

[GitHub] [apisix] juzhiyuan edited a comment on pull request #4598: docs: value according to code

2021-07-13 Thread GitBox
juzhiyuan edited a comment on pull request #4598: URL: https://github.com/apache/apisix/pull/4598#issuecomment-879538203 @iamayushdas Hi, thanks for your contributions! But please update your PR to have better content: 1. Please use a meaningful title, tells users what happened, and

[GitHub] [apisix] spacewander merged pull request #4580: change: enable stream proxy only by default

2021-07-13 Thread GitBox
spacewander merged pull request #4580: URL: https://github.com/apache/apisix/pull/4580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated (307c7f6 -> 03a9b80)

2021-07-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 307c7f6 feat: Add option retry_timeout that like nginx's proxy_next_upstream_timeout (#4574) add 03a9b80

[GitHub] [apisix] juzhiyuan commented on pull request #4598: docs: value according to code

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #4598: URL: https://github.com/apache/apisix/pull/4598#issuecomment-879538203 @iamayushdas Hi, thanks for your contributions! But please update your PR to have better content: 1. Please use a meaningful title, tells users what happened, and what th

[GitHub] [apisix] starsz commented on a change in pull request #4549: feat: enable balancer phase for plugins

2021-07-13 Thread GitBox
starsz commented on a change in pull request #4549: URL: https://github.com/apache/apisix/pull/4549#discussion_r669230828 ## File path: apisix/balancer.lua ## @@ -308,15 +309,24 @@ function _M.run(route, ctx) return core.response.exit(502) end +p

[GitHub] [apisix] spacewander commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r669234243 ## File path: docs/zh/latest/plugins/request-id.md ## @@ -71,6 +72,99 @@ X-Request-Id: fe32076a-d0a5-49a6-a361-6c244c1df956 .. ``` +### 使用 snow

[GitHub] [apisix-website] Yiyiyimu edited a comment on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
Yiyiyimu edited a comment on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879534656 Hi @iamayushdas Do you know how are we building multi-version docs for now? I created an extra branch in apisix-docker repo but it seems we should not build on all

[GitHub] [apisix-website] Yiyiyimu commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
Yiyiyimu commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879534656 Hi @iamayushdas Do you know how are we building multi-versoin docs for now? It seems we should not build on all branches but the selected ones -- This is an automated me

[GitHub] [apisix] starsz commented on a change in pull request #4549: feat: enable balancer phase for plugins

2021-07-13 Thread GitBox
starsz commented on a change in pull request #4549: URL: https://github.com/apache/apisix/pull/4549#discussion_r669230828 ## File path: apisix/balancer.lua ## @@ -308,15 +309,24 @@ function _M.run(route, ctx) return core.response.exit(502) end +p

[GitHub] [apisix] dickens7 commented on pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-13 Thread GitBox
dickens7 commented on pull request #4559: URL: https://github.com/apache/apisix/pull/4559#issuecomment-879531464 TODO: upgrade api7/lua-snowflake to 2.1-1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] spacewander commented on pull request #4598: docs: value according to code

2021-07-13 Thread GitBox
spacewander commented on pull request #4598: URL: https://github.com/apache/apisix/pull/4598#issuecomment-879526768 This is an example of a valid title: https://github.com/apache/apisix/pull/4593 "docs: fix standalone mode yaml config" -- This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] gxthrj closed issue #582: bug: Should not call func recordStatus when only delete ApisixUpstream

2021-07-13 Thread GitBox
gxthrj closed issue #582: URL: https://github.com/apache/apisix-ingress-controller/issues/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #589: fix: do not need to record status when ApisixUpstream removed

2021-07-13 Thread GitBox
gxthrj merged pull request #589: URL: https://github.com/apache/apisix-ingress-controller/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix-ingress-controller] branch master updated: fix: do not need to record status when ApisixUpstream removed (#589)

2021-07-13 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 7291212 fix: do not need to rec

[GitHub] [apisix] spacewander merged pull request #4574: feat: Add option retry_timeout that like nginx's proxy_next_upstream_timeout

2021-07-13 Thread GitBox
spacewander merged pull request #4574: URL: https://github.com/apache/apisix/pull/4574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: feat: Add option retry_timeout that like nginx's proxy_next_upstream_timeout (#4574)

2021-07-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 307c7f6 feat: Add option retry_timeout tha

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #583: chore: merge from v1.1

2021-07-13 Thread GitBox
gxthrj merged pull request #583: URL: https://github.com/apache/apisix-ingress-controller/pull/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix-ingress-controller] branch master updated: chore: merge from v1.1 (#583)

2021-07-13 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new c78c823 chore: merge from v1.1

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #590: fix: modify ingress controller docker image version to 1.0.0

2021-07-13 Thread GitBox
gxthrj commented on a change in pull request #590: URL: https://github.com/apache/apisix-ingress-controller/pull/590#discussion_r66903 ## File path: samples/deploy/deployment/ingress-controller.yaml ## @@ -41,7 +41,7 @@ spec: hostNetwork: true dnsPolicy: Clus

[GitHub] [apisix-website] iamayushdas commented on issue #392: feature request: refine code block copy button behaviour to ignore the leading `$`

2021-07-13 Thread GitBox
iamayushdas commented on issue #392: URL: https://github.com/apache/apisix-website/issues/392#issuecomment-879522969 can we also change the format of our code blocks @Yiyiyimu from this: https://user-images.githubusercontent.com/40708551/125547714-c4c9d65c-09fb-4ec6-a4ff-85e45

[GitHub] [apisix] philzhangrui commented on pull request #4595: feat: add request body parameter

2021-07-13 Thread GitBox
philzhangrui commented on pull request #4595: URL: https://github.com/apache/apisix/pull/4595#issuecomment-879523021 This code is mainly used to make gray level with the requester parameters,At present, the latest basic tone, you need to help me optimize, see where to optimize -- This i

[GitHub] [apisix] tzssangglass commented on a change in pull request #4587: feat(plugin): Add new plugin bot-restriction for bot spider restriction

2021-07-13 Thread GitBox
tzssangglass commented on a change in pull request #4587: URL: https://github.com/apache/apisix/pull/4587#discussion_r668884705 ## File path: apisix/plugins/ua-restriction.lua ## @@ -0,0 +1,121 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- co

[GitHub] [apisix] tzssangglass commented on a change in pull request #4587: feat(plugin): Add new plugin bot-restriction for bot spider restriction

2021-07-13 Thread GitBox
tzssangglass commented on a change in pull request #4587: URL: https://github.com/apache/apisix/pull/4587#discussion_r669220358 ## File path: apisix/plugins/ua-restriction.lua ## @@ -0,0 +1,121 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- co

[GitHub] [apisix] iamayushdas commented on pull request #4598: docs: value according to code

2021-07-13 Thread GitBox
iamayushdas commented on pull request #4598: URL: https://github.com/apache/apisix/pull/4598#issuecomment-879520797 cc @Yiyiyimu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [apisix] iamayushdas opened a new pull request #4598: docs: value according to code

2021-07-13 Thread GitBox
iamayushdas opened a new pull request #4598: URL: https://github.com/apache/apisix/pull/4598 ### What this PR does / why we need it: include_in_response default value has been edited to true according to Lua file https://github.com/apache/apisix-dashboard/issues/1960 ### Pr

[GitHub] [apisix-docker] iamayushdas commented on pull request #194: docs: removed `$` from code snippets

2021-07-13 Thread GitBox
iamayushdas commented on pull request #194: URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-879515798 cc @Yiyiyimu done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix-website] iamayushdas edited a comment on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas edited a comment on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879510355 cc @juzhiyuan https://user-images.githubusercontent.com/40708551/125545874-52c21d21-f547-4b63-b660-0efa094ea9bd.png";> -- This is an automated message from

[GitHub] [apisix-website] iamayushdas commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879510355 https://user-images.githubusercontent.com/40708551/125545874-52c21d21-f547-4b63-b660-0efa094ea9bd.png";> -- This is an automated message from the Apache Git Servic

[GitHub] [apisix] spacewander commented on pull request #4586: docs: don't need to modify config-default.yaml to add your plugin

2021-07-13 Thread GitBox
spacewander commented on pull request #4586: URL: https://github.com/apache/apisix/pull/4586#issuecomment-879499944 > > > I remenber that if I add my plugin in `config.yaml`, it will overwrite the default list of plugins in `config-default.yaml`. Is this behavior fixed now? I

[GitHub] [apisix] spacewander commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r669204115 ## File path: apisix/plugins/request-id.lua ## @@ -41,9 +72,134 @@ function _M.check_schema(conf) end +-- Generates the current process worker num

[GitHub] [apisix] spacewander commented on a change in pull request #4587: feat(plugin): Add new plugin bot-restriction for bot spider restriction

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4587: URL: https://github.com/apache/apisix/pull/4587#discussion_r669203790 ## File path: apisix/plugins/ua-restriction.lua ## @@ -0,0 +1,121 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- con

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1979: feat: set a initial weight value for the upstream node

2021-07-13 Thread GitBox
iamayushdas commented on pull request #1979: URL: https://github.com/apache/apisix-dashboard/pull/1979#issuecomment-879499002 Okay then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1979: feat: set a initial weight value for the upstream node

2021-07-13 Thread GitBox
nic-chen commented on pull request #1979: URL: https://github.com/apache/apisix-dashboard/pull/1979#issuecomment-879498759 > > Thanks for your review firstly. @iamayushdas > > > Just like the initial value for connecting/sending/reading timeout, by setting a initial weight value for

[GitHub] [apisix-website] juzhiyuan commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879498634 I still couldn't see what's the content of that `[object Object]`, please print it. You may need `JSON.stringify` to handle it. -- This is an automated message from the

[GitHub] [apisix] spacewander commented on a change in pull request #4575: fix: ref check while deleting proto via Admin API

2021-07-13 Thread GitBox
spacewander commented on a change in pull request #4575: URL: https://github.com/apache/apisix/pull/4575#discussion_r669202568 ## File path: t/admin/proto.t ## @@ -0,0 +1,93 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agree

[GitHub] [apisix-website] iamayushdas commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
iamayushdas commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879496265 > @iamayushdas look which one? This error, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-website] juzhiyuan commented on pull request #411: feat: added java plugin runner download block

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #411: URL: https://github.com/apache/apisix-website/pull/411#issuecomment-879495812 @iamayushdas look which one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1979: feat: set a initial weight value for the upstream node

2021-07-13 Thread GitBox
juzhiyuan commented on pull request #1979: URL: https://github.com/apache/apisix-dashboard/pull/1979#issuecomment-879494472 > Thanks for your review firstly. @iamayushdas > Just like the initial value for connecting/sending/reading timeout, by setting a initial weight value for the upstr

[GitHub] [apisix-website] iamayushdas commented on issue #409: feature request: Add all plugins list

2021-07-13 Thread GitBox
iamayushdas commented on issue #409: URL: https://github.com/apache/apisix-website/issues/409#issuecomment-879494146 > @1502shivam-singh Yes, you are right, but another point to add Plugins Hub is because, we could let more people who haven't been using the Dashboard know, what plugins it

[GitHub] [apisix-website] juzhiyuan commented on issue #409: feature request: Add all plugins list

2021-07-13 Thread GitBox
juzhiyuan commented on issue #409: URL: https://github.com/apache/apisix-website/issues/409#issuecomment-879493674 @1502shivam-singh Yes, you are right, but another point to add Plugins Hub is because, we could let more people who haven't been using the Dashboard know, what plugins it cont

  1   2   3   >