[GitHub] [apisix] liuxiran commented on issue #4680: bug: It should return 400 when update consumer with mismatched username in path and body

2021-07-26 Thread GitBox
liuxiran commented on issue #4680: URL: https://github.com/apache/apisix/issues/4680#issuecomment-887256081 > Yes. We can add similar check like > https://github.com/apache/apisix/blob/20df78432dc9447c7a1c2f63c1cd53a1a641a3fa/apisix/admin/routes.lua#L46 > > PR is welcome! T

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4660: docs: fix the problem of how-to-build note block display

2021-07-26 Thread GitBox
juzhiyuan commented on a change in pull request #4660: URL: https://github.com/apache/apisix/pull/4660#discussion_r677163605 ## File path: docs/en/latest/getting-started.md ## @@ -172,9 +170,7 @@ curl "http://127.0.0.1:9080/apisix/admin/upstreams/1"; -H "X-API-KEY: edd1c9f0343

[GitHub] [apisix] spacewander commented on a change in pull request #4660: docs: fix the problem of how-to-build note block display

2021-07-26 Thread GitBox
spacewander commented on a change in pull request #4660: URL: https://github.com/apache/apisix/pull/4660#discussion_r677160959 ## File path: docs/en/latest/getting-started.md ## @@ -172,9 +170,7 @@ curl "http://127.0.0.1:9080/apisix/admin/upstreams/1"; -H "X-API-KEY: edd1c9f03

[GitHub] [apisix] spacewander commented on issue #4680: bug: It should return 400 when update consumer with mismatched username in path and body

2021-07-26 Thread GitBox
spacewander commented on issue #4680: URL: https://github.com/apache/apisix/issues/4680#issuecomment-887251110 Yes. We can add similar check like https://github.com/apache/apisix/blob/20df78432dc9447c7a1c2f63c1cd53a1a641a3fa/apisix/admin/routes.lua#L46 PR is welcome! -- This is

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4660: docs: fix the problem of how-to-build note block display

2021-07-26 Thread GitBox
juzhiyuan commented on a change in pull request #4660: URL: https://github.com/apache/apisix/pull/4660#discussion_r677154192 ## File path: docs/en/latest/getting-started.md ## @@ -172,9 +170,7 @@ curl "http://127.0.0.1:9080/apisix/admin/upstreams/1"; -H "X-API-KEY: edd1c9f0343

[GitHub] [apisix] liuxiran opened a new issue #4680: bug: It should return 400 when update consumer with mismatched username in path and body

2021-07-26 Thread GitBox
liuxiran opened a new issue #4680: URL: https://github.com/apache/apisix/issues/4680 ### Issue description ### Environment Bug report without environment information will be ignored or closed. * apisix version (cmd: `apisix version`): 2.7 * OS (cmd: `uname -a`): Darwi

[GitHub] [apisix] pawarjayesh1985 edited a comment on issue #4667: bug: Getting 502 Bad Gateway issue

2021-07-26 Thread GitBox
pawarjayesh1985 edited a comment on issue #4667: URL: https://github.com/apache/apisix/issues/4667#issuecomment-887234953 @tokers : Below are the logs 2021/07/26 13:04:13 [warn] 47#47: *8 [lua] plugin.lua:173: load(): new plugins: {"ext-plugin-pre-req":true,"batch-requests":true,"pr

[GitHub] [apisix] pawarjayesh1985 commented on issue #4667: bug: Getting 502 Bad Gateway issue

2021-07-26 Thread GitBox
pawarjayesh1985 commented on issue #4667: URL: https://github.com/apache/apisix/issues/4667#issuecomment-887234953 2021/07/26 13:04:13 [warn] 47#47: *8 [lua] plugin.lua:173: load(): new plugins: {"ext-plugin-pre-req":true,"batch-requests":true,"proxy-cache":true,"fault-injection":true,"req

[GitHub] [apisix] tzssangglass commented on a change in pull request #4670: docs: Add some questions and answers to the FAQ

2021-07-26 Thread GitBox
tzssangglass commented on a change in pull request #4670: URL: https://github.com/apache/apisix/pull/4670#discussion_r677141314 ## File path: docs/en/latest/FAQ.md ## @@ -569,3 +569,5 @@ The difference between `plugin-metadata` and `plugin-configs`: - Plugin instance scope:

[GitHub] [apisix] tao12345666333 commented on issue #4388: Another implementation of ingress controller

2021-07-26 Thread GitBox
tao12345666333 commented on issue #4388: URL: https://github.com/apache/apisix/issues/4388#issuecomment-887230920 > The k8s endpoints discovery is very useful,I think it should be merge into apisix I agree. @adugeek would you like to add a `kubernetes` discovery plugin for Apache AP

[GitHub] [apisix-helm-chart] tutuV opened a new issue #119: the pod is pending, just follow the official website steps

2021-07-26 Thread GitBox
tutuV opened a new issue #119: URL: https://github.com/apache/apisix-helm-chart/issues/119 只是按照官网步骤,继续安装,没有正常运行 。 Just follow the official website steps, continue to install, did not work properly. 是不是需要自己创建pv,供etcd使用? Do I need to create PV for etcd use? ![image](https

[GitHub] [apisix-website] Baoyuantop commented on issue #428: bug: Refreshing the page after closing the 200 contributor guide causes flickering

2021-07-26 Thread GitBox
Baoyuantop commented on issue #428: URL: https://github.com/apache/apisix-website/issues/428#issuecomment-887207657 This issue is relatively easy to solve, I will send a PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-website] guoqqqi opened a new issue #428: bug: Refreshing the page after closing the 200 contributor guide causes flickering

2021-07-26 Thread GitBox
guoqqqi opened a new issue #428: URL: https://github.com/apache/apisix-website/issues/428 **Actual Behaviour** The pop-up window at the bottom right corner of the current home page of the official website will flash when the page is refreshed after being closed manually. **Ex

[GitHub] [apisix] guoqqqi closed issue #4679: bug: Refreshing the page after closing the 200 contributor guide causes flickering

2021-07-26 Thread GitBox
guoqqqi closed issue #4679: URL: https://github.com/apache/apisix/issues/4679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2004: chore: update auth plugin tip

2021-07-26 Thread GitBox
netlify[bot] edited a comment on pull request #2004: URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: c9c91588783ce71d063946d2e5095b21c3118318 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2004: chore: update auth plugin tip

2021-07-26 Thread GitBox
netlify[bot] commented on pull request #2004: URL: https://github.com/apache/apisix-dashboard/pull/2004#issuecomment-887196390 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: c9c91588783ce71d063946d2e5095b21c3118318 🔍 Inspect the deploy log

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #2004: chore: update auth plugin tip

2021-07-26 Thread GitBox
LiteSun opened a new pull request #2004: URL: https://github.com/apache/apisix-dashboard/pull/2004 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided -

[GitHub] [apisix] guoqqqi opened a new issue #4679: bug: Refreshing the page after closing the 200 contributor guide causes flickering

2021-07-26 Thread GitBox
guoqqqi opened a new issue #4679: URL: https://github.com/apache/apisix/issues/4679 ### Issue description The pop-up window at the bottom right corner of the current home page of the official website will flash when the page is refreshed after being closed manually. ### Environme

[apisix] branch release/2.8 created (now 69e54d4)

2021-07-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/2.8 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 69e54d4 docs: fix section titles' links (#4671) No new revisions were added by this update.

[GitHub] [apisix] spacewander merged pull request #4658: feat: release 2.8

2021-07-26 Thread GitBox
spacewander merged pull request #4658: URL: https://github.com/apache/apisix/pull/4658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: feat: release 2.8 (#4658)

2021-07-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 20df784 feat: release 2.8 (#4658) 20df784

[apisix] tag 2.8 created (now 69e54d4)

2021-07-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to tag 2.8 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 69e54d4 (commit) No new revisions were added by this update.

[GitHub] [apisix] spacewander opened a new pull request #4678: fix: upgrade lua-resty-expr to fix the rule validation

2021-07-26 Thread GitBox
spacewander opened a new pull request #4678: URL: https://github.com/apache/apisix/pull/4678 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix-dashboard] nic-chen merged pull request #1999: chore: compatible with Apache APISIX 2.7

2021-07-26 Thread GitBox
nic-chen merged pull request #1999: URL: https://github.com/apache/apisix-dashboard/pull/1999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[apisix-dashboard] branch master updated (904fbc2 -> 8257598)

2021-07-26 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 904fbc2 feat: When Dashboard and APISIX version do not match, make the prompt information clearer (#19

[GitHub] [apisix] spacewander commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-26 Thread GitBox
spacewander commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r677076966 ## File path: apisix/plugins/request-id.lua ## @@ -14,25 +14,58 @@ -- See the License for the specific language governing permissions and -- limitati

[GitHub] [apisix-docker] guoqqqi commented on pull request #197: ci: release on multiarch

2021-07-26 Thread GitBox
guoqqqi commented on pull request #197: URL: https://github.com/apache/apisix-docker/pull/197#issuecomment-887167342 ![image](https://user-images.githubusercontent.com/72343596/127087697-add75bba-e32c-4cb9-9475-6e4295e0f3d1.png) On M1, `make build-dashboard` I encountered this error @

[GitHub] [apisix-ingress-controller] gxthrj closed issue #456: docs: More and more docs for APISIX Ingress Controller

2021-07-26 Thread GitBox
gxthrj closed issue #456: URL: https://github.com/apache/apisix-ingress-controller/issues/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj closed issue #454: The features and docs needing to add After General Availability

2021-07-26 Thread GitBox
gxthrj closed issue #454: URL: https://github.com/apache/apisix-ingress-controller/issues/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj closed issue #449: bug: When controller become to leader from candidate code panic error

2021-07-26 Thread GitBox
gxthrj closed issue #449: URL: https://github.com/apache/apisix-ingress-controller/issues/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj closed issue #448: bug: Always sync ingress failed if apisix cluster not ready when apisix-ingress start.

2021-07-26 Thread GitBox
gxthrj closed issue #448: URL: https://github.com/apache/apisix-ingress-controller/issues/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj closed issue #338: bug: minikube setup

2021-07-26 Thread GitBox
gxthrj closed issue #338: URL: https://github.com/apache/apisix-ingress-controller/issues/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #338: bug: minikube setup

2021-07-26 Thread GitBox
gxthrj commented on issue #338: URL: https://github.com/apache/apisix-ingress-controller/issues/338#issuecomment-887162870 The issue is stale, feel free to reopen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] gxthrj closed issue #397: Use annotations to rich the Kubernetes Ingress

2021-07-26 Thread GitBox
gxthrj closed issue #397: URL: https://github.com/apache/apisix-ingress-controller/issues/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix] tzssangglass commented on a change in pull request #4670: docs: Add some questions and answers to the FAQ

2021-07-26 Thread GitBox
tzssangglass commented on a change in pull request #4670: URL: https://github.com/apache/apisix/pull/4670#discussion_r677067858 ## File path: docs/en/latest/FAQ.md ## @@ -569,3 +569,5 @@ The difference between `plugin-metadata` and `plugin-configs`: - Plugin instance scope:

[GitHub] [apisix-docker] tao12345666333 commented on pull request #197: ci: release on multiarch

2021-07-26 Thread GitBox
tao12345666333 commented on pull request #197: URL: https://github.com/apache/apisix-docker/pull/197#issuecomment-887155632 > Can we support build apisix-dashboard on multi-arch? It can be added in other PR. Let's merge this PR. -- This is an automated message from the Apache Git S

[GitHub] [apisix] spacewander commented on a change in pull request #4660: docs: fix the problem of how-to-build note block display

2021-07-26 Thread GitBox
spacewander commented on a change in pull request #4660: URL: https://github.com/apache/apisix/pull/4660#discussion_r677062737 ## File path: docs/en/latest/getting-started.md ## @@ -172,9 +170,7 @@ curl "http://127.0.0.1:9080/apisix/admin/upstreams/1"; -H "X-API-KEY: edd1c9f03

[GitHub] [apisix] spacewander opened a new pull request #4677: test: save a port in the test framework

2021-07-26 Thread GitBox
spacewander opened a new pull request #4677: URL: https://github.com/apache/apisix/pull/4677 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix-ingress-controller] gxthrj closed issue #116: feat: Support UDP definition

2021-07-26 Thread GitBox
gxthrj closed issue #116: URL: https://github.com/apache/apisix-ingress-controller/issues/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj closed issue #396: feat: support udp route

2021-07-26 Thread GitBox
gxthrj closed issue #396: URL: https://github.com/apache/apisix-ingress-controller/issues/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix] tzssangglass commented on a change in pull request #4670: docs: Add some questions and answers to the FAQ

2021-07-26 Thread GitBox
tzssangglass commented on a change in pull request #4670: URL: https://github.com/apache/apisix/pull/4670#discussion_r677059373 ## File path: docs/en/latest/FAQ.md ## @@ -569,3 +569,5 @@ The difference between `plugin-metadata` and `plugin-configs`: - Plugin instance scope:

[GitHub] [apisix-website] Yiyiyimu commented on pull request #410: feat: added company who uses Apache APISIX logo

2021-07-26 Thread GitBox
Yiyiyimu commented on pull request #410: URL: https://github.com/apache/apisix-website/pull/410#issuecomment-887146536 cc @guoqqqi do you have some progress on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #1991: 在预览插件的时候,建议只显示启动的插件而不是显示所有的插件

2021-07-26 Thread GitBox
Baoyuantop commented on issue #1991: URL: https://github.com/apache/apisix-dashboard/issues/1991#issuecomment-887145457 Thank you @liuxiran, I understand, I will submit a PR for this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-docker] Yiyiyimu commented on pull request #197: ci: release on multiarch

2021-07-26 Thread GitBox
Yiyiyimu commented on pull request #197: URL: https://github.com/apache/apisix-docker/pull/197#issuecomment-887145147 > Can we support build apisix-dashboard on multi-arch? > can not build dashboard multiarch image since yarn build failed. ref: https://github.com/Yiyiyimu/apisix-dock

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #118: feat: add helm chart FAQ entry on the navbar

2021-07-26 Thread GitBox
tokers commented on a change in pull request #118: URL: https://github.com/apache/apisix-helm-chart/pull/118#discussion_r677056977 ## File path: docs/en/latest/FAQ.md ## @@ -0,0 +1,52 @@ +--- +title: FAQ +--- + + + +### 1. How to install APISIX only? + +The Charts will install

[GitHub] [apisix] tokers commented on a change in pull request #4670: docs: Add some questions and answers to the FAQ

2021-07-26 Thread GitBox
tokers commented on a change in pull request #4670: URL: https://github.com/apache/apisix/pull/4670#discussion_r677054811 ## File path: docs/en/latest/FAQ.md ## @@ -569,3 +569,5 @@ The difference between `plugin-metadata` and `plugin-configs`: - Plugin instance scope: `plug

[GitHub] [apisix] tokers commented on issue #4667: bug: Getting 502 Bad Gateway issue

2021-07-26 Thread GitBox
tokers commented on issue #4667: URL: https://github.com/apache/apisix/issues/4667#issuecomment-887142343 Are there any error logs in the error.log file of Apache APISIX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] nanamikon commented on a change in pull request #4676: feat: support dash in args (#4519)

2021-07-26 Thread GitBox
nanamikon commented on a change in pull request #4676: URL: https://github.com/apache/apisix/pull/4676#discussion_r677053635 ## File path: apisix/core/ctx.lua ## @@ -159,10 +160,22 @@ do val, err = cookie:get(sub_str(key, 8)) if err the

[GitHub] [apisix] nanamikon commented on a change in pull request #4676: feat: support dash in args (#4519)

2021-07-26 Thread GitBox
nanamikon commented on a change in pull request #4676: URL: https://github.com/apache/apisix/pull/4676#discussion_r677053588 ## File path: t/core/ctx.t ## @@ -1008,3 +1008,23 @@ GET /hello hello world --- error_log eval qr/request log: \{"route_id":"1","route_name":"my_rout

[GitHub] [apisix] tokers commented on a change in pull request #4676: feat: support dash in args (#4519)

2021-07-26 Thread GitBox
tokers commented on a change in pull request #4676: URL: https://github.com/apache/apisix/pull/4676#discussion_r677052901 ## File path: apisix/core/ctx.lua ## @@ -159,10 +160,22 @@ do val, err = cookie:get(sub_str(key, 8)) if err then

[GitHub] [apisix] starsz commented on a change in pull request #4559: feat: Request-ID plugin add snowflake algorithm

2021-07-26 Thread GitBox
starsz commented on a change in pull request #4559: URL: https://github.com/apache/apisix/pull/4559#discussion_r677052926 ## File path: apisix/plugins/request-id.lua ## @@ -41,9 +74,142 @@ function _M.check_schema(conf) end +-- Generates the current process data machine +l

[GitHub] [apisix] tokers commented on issue #4674: Proposal: Addition of an authorization plugin

2021-07-26 Thread GitBox
tokers commented on issue #4674: URL: https://github.com/apache/apisix/issues/4674#issuecomment-887140363 Just one question, So if people want to use this plugin when they deploy their Apache APISIX cluster on Kuberentes, we may have to prepare an image which contains the policy file and t

[GitHub] [apisix] spacewander commented on a change in pull request #4676: feat: support dash in args (#4519)

2021-07-26 Thread GitBox
spacewander commented on a change in pull request #4676: URL: https://github.com/apache/apisix/pull/4676#discussion_r677048124 ## File path: t/core/ctx.t ## @@ -1008,3 +1008,23 @@ GET /hello hello world --- error_log eval qr/request log: \{"route_id":"1","route_name":"my_ro

[GitHub] [apisix] hsluoyz commented on issue #4674: Proposal: Addition of an authorization plugin

2021-07-26 Thread GitBox
hsluoyz commented on issue #4674: URL: https://github.com/apache/apisix/issues/4674#issuecomment-887135292 @spacewander thanks! `authz-casbin` would be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix-dashboard] tzssangglass commented on pull request #1999: chore: compatible with Apache APISIX 2.7

2021-07-26 Thread GitBox
tzssangglass commented on pull request #1999: URL: https://github.com/apache/apisix-dashboard/pull/1999#issuecomment-887134100 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [apisix] spacewander commented on issue #4674: Proposal: Addition of an authorization plugin

2021-07-26 Thread GitBox
spacewander commented on issue #4674: URL: https://github.com/apache/apisix/issues/4674#issuecomment-887133588 We already have `authz-keycloak`, what about using name `authz-casbin`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] spacewander commented on issue #4674: Proposal: Addition of an authorization plugin

2021-07-26 Thread GitBox
spacewander commented on issue #4674: URL: https://github.com/apache/apisix/issues/4674#issuecomment-887133068 LGTM. There are three minor issues: 1. `local plugin_name = "apisix-authz"` should be `local plugin_name = "casbin-authz"` 2. we don't need ` type = 'auth'` as it doesn't int

[GitHub] [apisix] spacewander commented on a change in pull request #4633: feat: add error log skywalking reporter

2021-07-26 Thread GitBox
spacewander commented on a change in pull request #4633: URL: https://github.com/apache/apisix/pull/4633#discussion_r677039740 ## File path: t/plugin/error-log-logger-skywalking.t ## @@ -0,0 +1,201 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] [apisix-ingress-controller] Yiyiyimu edited a comment on pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
Yiyiyimu edited a comment on pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#issuecomment-887044526 Hi @fhuzero ~I think it would be nice if you could also [include the documentations](https://github.com/apache/apisix-ingress-controller/commit/979531b27

[GitHub] [apisix-ingress-controller] Yiyiyimu commented on pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
Yiyiyimu commented on pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#issuecomment-887044526 Hi @fhuzero I think it would be nice if you could also [include the documentations](https://github.com/apache/apisix-ingress-controller/commit/979531b274751a97a

[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1950: Why can't I edit my plugin configuration in version 2.7

2021-07-26 Thread GitBox
liuxiran edited a comment on issue #1950: URL: https://github.com/apache/apisix-dashboard/issues/1950#issuecomment-886239837 > ![图片](https://user-images.githubusercontent.com/18514089/123041105-72d05100-d427-11eb-97f1-40469e887724.png) > Well, I didn't use consumers in previous versions

[GitHub] [apisix-dashboard] liuxiran closed issue #1938: there is a problem with the yaml data format

2021-07-26 Thread GitBox
liuxiran closed issue #1938: URL: https://github.com/apache/apisix-dashboard/issues/1938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [apisix-dashboard] liuxiran commented on issue #1938: there is a problem with the yaml data format

2021-07-26 Thread GitBox
liuxiran commented on issue #1938: URL: https://github.com/apache/apisix-dashboard/issues/1938#issuecomment-887036267 Since our contributor has updated editor to `monaco`, which is more powerful and will help your code style while editing, so we remove the `Format` function, hope this w

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1982: fix: make service chash key Input inputable and selectable

2021-07-26 Thread GitBox
liuxiran commented on pull request #1982: URL: https://github.com/apache/apisix-dashboard/pull/1982#issuecomment-887023504 Thanks for your test cases, it is ok for the whole idea and process👏, and suggestions for improvement I have attached to the review. To ensure test coverage, we also

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1982: fix: make service chash key Input inputable and selectable

2021-07-26 Thread GitBox
liuxiran commented on a change in pull request #1982: URL: https://github.com/apache/apisix-dashboard/pull/1982#discussion_r676938070 ## File path: web/cypress/integration/service/create-service-with-chash-upstream.spec.js ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache So

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1982: fix: make service chash key Input inputable and selectable

2021-07-26 Thread GitBox
liuxiran commented on a change in pull request #1982: URL: https://github.com/apache/apisix-dashboard/pull/1982#discussion_r676938070 ## File path: web/cypress/integration/service/create-service-with-chash-upstream.spec.js ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache So

[GitHub] [apisix-dashboard] liuxiran commented on issue #1991: 在预览插件的时候,建议只显示启动的插件而不是显示所有的插件

2021-07-26 Thread GitBox
liuxiran commented on issue #1991: URL: https://github.com/apache/apisix-dashboard/issues/1991#issuecomment-887009455 > I tried the current issue, this is the current preview screenshot: > > ![image](https://user-images.githubusercontent.com/30611190/126974094-9d607fef-1292-4744-8e9

[GitHub] [apisix] dmsolr commented on a change in pull request #4633: feat: add error log skywalking reporter

2021-07-26 Thread GitBox
dmsolr commented on a change in pull request #4633: URL: https://github.com/apache/apisix/pull/4633#discussion_r676798070 ## File path: t/plugin/error-log-skywalking-logger.t ## @@ -0,0 +1,357 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contri

[GitHub] [apisix] dmsolr commented on a change in pull request #4633: feat: add error log skywalking reporter

2021-07-26 Thread GitBox
dmsolr commented on a change in pull request #4633: URL: https://github.com/apache/apisix/pull/4633#discussion_r676797798 ## File path: t/plugin/error-log-skywalking-logger.t ## @@ -0,0 +1,357 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contri

[GitHub] [apisix] dmsolr commented on a change in pull request #4633: feat: add error log skywalking reporter

2021-07-26 Thread GitBox
dmsolr commented on a change in pull request #4633: URL: https://github.com/apache/apisix/pull/4633#discussion_r676797377 ## File path: apisix/plugins/log-generator.lua ## @@ -0,0 +1,63 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributo

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1998: feat(plugin): allowing limit-count to dynamically adapt to the BE rules

2021-07-26 Thread GitBox
guoqqqi commented on a change in pull request #1998: URL: https://github.com/apache/apisix-dashboard/pull/1998#discussion_r676795398 ## File path: web/src/components/Plugin/UI/limit-count.tsx ## @@ -135,7 +145,7 @@ const RedisClusterForm: React.FC = () => {

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #596: support ingress v1beta1 https

2021-07-26 Thread GitBox
tao12345666333 commented on a change in pull request #596: URL: https://github.com/apache/apisix-ingress-controller/pull/596#discussion_r676787631 ## File path: pkg/kube/translation/ingress.go ## @@ -16,6 +16,9 @@ package translation import ( "bytes" + "fmt" +

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1994: feat(plugin): allowing cors to dynamically adapt to the BE rules

2021-07-26 Thread GitBox
guoqqqi commented on a change in pull request #1994: URL: https://github.com/apache/apisix-dashboard/pull/1994#discussion_r676787154 ## File path: web/src/components/Plugin/UI/cors.tsx ## @@ -156,15 +161,15 @@ const Cors: React.FC = ({ form }) => { ))}

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1974: feat(plugin): add dynamic schema for api-breaker

2021-07-26 Thread GitBox
guoqqqi commented on pull request #1974: URL: https://github.com/apache/apisix-dashboard/pull/1974#issuecomment-886868799 Hi, Thank you for your contribution. Here are some conflicts in this PR that need to be resolved -- This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
codecov-commenter edited a comment on pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#issuecomment-886048345 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/606?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1998: feat(plugin): allowing limit-count to dynamically adapt to the BE rules

2021-07-26 Thread GitBox
codecov-commenter edited a comment on pull request #1998: URL: https://github.com/apache/apisix-dashboard/pull/1998#issuecomment-886308670 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1998?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] nanamikon opened a new pull request #4676: feat: support dash in args (#4519)

2021-07-26 Thread GitBox
nanamikon opened a new pull request #4676: URL: https://github.com/apache/apisix/pull/4676 ### What this PR does / why we need it: Support fetch value from arg name with dash , see #4519 ### Pre-submission checklist: * [ 1] Did you explain what problem does this PR s

[GitHub] [apisix-ingress-controller] fhuzero commented on a change in pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
fhuzero commented on a change in pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#discussion_r676713461 ## File path: pkg/kube/translation/knative_ingress.go ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-ingress-controller] fhuzero commented on a change in pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
fhuzero commented on a change in pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#discussion_r676711690 ## File path: pkg/ingress/knative_ingress.go ## @@ -0,0 +1,299 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-website] KishaniKandasamy commented on issue #409: feature: support Plugins Hub

2021-07-26 Thread GitBox
KishaniKandasamy commented on issue #409: URL: https://github.com/apache/apisix-website/issues/409#issuecomment-886787187 > Sure, and using this ptototype? > > [#409 (comment)](https://github.com/apache/apisix-website/issues/409#issuecomment-880620378) Yes -- This is an aut

[GitHub] [apisix-website] juzhiyuan commented on issue #409: feature: support Plugins Hub

2021-07-26 Thread GitBox
juzhiyuan commented on issue #409: URL: https://github.com/apache/apisix-website/issues/409#issuecomment-886781095 Sure, and using this ptototype? https://github.com/apache/apisix-website/issues/409#issuecomment-880620378 -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] nic-chen opened a new issue #1944: When Dashboard and APISIX version do not match, make the prompt information clearer

2021-07-26 Thread GitBox
nic-chen opened a new issue #1944: URL: https://github.com/apache/apisix-dashboard/issues/1944 # Feature request ## Please describe your feature When the APISIX version does not match the Dashboard version, the prompt information is not clear enough to allow users to directly

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1998: feat(plugin): fix UI limit-count

2021-07-26 Thread GitBox
netlify[bot] edited a comment on pull request #1998: URL: https://github.com/apache/apisix-dashboard/pull/1998#issuecomment-886144035 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 42890de006c6536441ebcd7ac8334434fcd828a9 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1998: feat(plugin): fix UI limit-count

2021-07-26 Thread GitBox
netlify[bot] edited a comment on pull request #1998: URL: https://github.com/apache/apisix-dashboard/pull/1998#issuecomment-886144035 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 42890de006c6536441ebcd7ac8334434fcd828a9 🔍 Inspect the dep

[GitHub] [apisix] pawarjayesh1985 commented on issue #4667: bug: Getting 502 Bad Gateway issue

2021-07-26 Thread GitBox
pawarjayesh1985 commented on issue #4667: URL: https://github.com/apache/apisix/issues/4667#issuecomment-886679670 @tokers : below are the details. $ curl -i -X GET "http://localhost:9181/order"; % Total% Received % Xferd Average Speed TimeTime Time Current

[GitHub] [apisix-dashboard] okaybase commented on pull request #1997: docs: update the dashboard installation version

2021-07-26 Thread GitBox
okaybase commented on pull request #1997: URL: https://github.com/apache/apisix-dashboard/pull/1997#issuecomment-886678322 please take time to review, thanks~ @liuxiran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-ingress-controller] tokers opened a new issue #607: timeout settings for e2e framework

2021-07-26 Thread GitBox
tokers opened a new issue #607: URL: https://github.com/apache/apisix-ingress-controller/issues/607 Timeout for waiting for the components/custom resources to launch or set up now is hardcoded. It's not reasonable since the GitHub Action is slow sometimes. We may tidy up the timeout

[GitHub] [apisix] tzssangglass commented on a change in pull request #4670: docs: Add some questions and answers to the FAQ

2021-07-26 Thread GitBox
tzssangglass commented on a change in pull request #4670: URL: https://github.com/apache/apisix/pull/4670#discussion_r676528055 ## File path: docs/zh/latest/FAQ.md ## @@ -549,4 +549,22 @@ apisix: ``` **注意:** -尝试使用 cosocket 连接任何TLS服务时,都需要配置 `apisix.ssl.ssl_trusted_certificat

[GitHub] [apisix] philzhangrui opened a new issue #4675: request help: Write your own plug-ins to improve performance

2021-07-26 Thread GitBox
philzhangrui opened a new issue #4675: URL: https://github.com/apache/apisix/issues/4675 ### Issue description I wrote a plug-in myself. In the access phase, add 1 to the number of requests in redis, and then return the error code. Each execution takes more than 1 second. I want

[GitHub] [apisix] rushitote opened a new issue #4674: Proposal: Addition of an authorization plugin

2021-07-26 Thread GitBox
rushitote opened a new issue #4674: URL: https://github.com/apache/apisix/issues/4674 ## Background Hi, we have been developing `casbin-authz` plugin for APISIX based on [Lua Casbin](https://github.com/casbin/lua-casbin/) which is the Lua implementation of the [Casbin](https://casbi

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #118: feat: add helm chart FAQ entry on the navbar

2021-07-26 Thread GitBox
tokers commented on a change in pull request #118: URL: https://github.com/apache/apisix-helm-chart/pull/118#discussion_r676521813 ## File path: docs/en/latest/FAQ.md ## @@ -0,0 +1,52 @@ +--- +title: FAQ +--- + + + +### 1. How to install APISIX only? + +The Charts will install

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
tokers commented on a change in pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#discussion_r676520643 ## File path: pkg/kube/translation/knative_ingress.go ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #606: feat: add support for Knative

2021-07-26 Thread GitBox
tokers commented on a change in pull request #606: URL: https://github.com/apache/apisix-ingress-controller/pull/606#discussion_r676519882 ## File path: pkg/ingress/knative_ingress.go ## @@ -0,0 +1,299 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-dashboard] tokers closed issue #1944: When Dashboard and APISIX version do not match, make the prompt information clearer

2021-07-26 Thread GitBox
tokers closed issue #1944: URL: https://github.com/apache/apisix-dashboard/issues/1944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix-dashboard] tokers merged pull request #1968: feat: When Dashboard and APISIX version do not match, make the prompt information clearer (#1944)

2021-07-26 Thread GitBox
tokers merged pull request #1968: URL: https://github.com/apache/apisix-dashboard/pull/1968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[apisix-dashboard] branch master updated: feat: When Dashboard and APISIX version do not match, make the prompt information clearer (#1944) (#1968)

2021-07-26 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 904fbc2 feat: When Dashboard and APIS

[apisix] branch master updated (3e30b71 -> e3e0183)

2021-07-26 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 3e30b71 docs: make the doc consistent with the case (#4659) add e3e0183 docs: fix section titles' links (#4669

[GitHub] [apisix] tokers merged pull request #4669: docs: fix broken links issues on section titles

2021-07-26 Thread GitBox
tokers merged pull request #4669: URL: https://github.com/apache/apisix/pull/4669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] tokers merged pull request #4659: docs: make the doc desc consistent with the case

2021-07-26 Thread GitBox
tokers merged pull request #4659: URL: https://github.com/apache/apisix/pull/4659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[apisix] branch master updated (57236b4 -> 3e30b71)

2021-07-26 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 57236b4 feat: set the basic id attribute when creating a resource via POST (#4661) add 3e30b71 docs: make the

  1   2   >