[GitHub] [apisix-dashboard] liuxiran merged pull request #2051: fix: update menu sidebar

2021-08-09 Thread GitBox
liuxiran merged pull request #2051: URL: https://github.com/apache/apisix-dashboard/pull/2051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894734801 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894672192 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 1815a1765e529966f208d7f054cc09e161fc9ad2 🔍 Inspect the deploy

[GitHub] [apisix-ingress-controller] sober-wang removed a comment on issue #610: proposal: New architecture of Apache APISIX Ingress controller

2021-08-09 Thread GitBox
sober-wang removed a comment on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-895769097 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix-ingress-controller] sober-wang commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller

2021-08-09 Thread GitBox
sober-wang commented on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-895769097 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894672192 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 1815a1765e529966f208d7f054cc09e161fc9ad2 🔍 Inspect the dep

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
liuxiran commented on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-895759492 Hi @bzp2010 , thanks for this greate change for dashboard. It is believed that user authentication is also a concern of many open source users, it would be bett

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
bzp2010 commented on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-895737216 ### Current Plan Update Time: 2021-08-10 Description: At present, we plan to provide two types of user storage methods. 1. The first is

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
liuxiran commented on a change in pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#discussion_r685694803 ## File path: web/cypress/integration/route/create-route-both-use-uri-uris.spec.js ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1697: How to add grafana

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #1697: URL: https://github.com/apache/apisix-dashboard/pull/1697#issuecomment-895699011 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: eab816e3d62e76a7e9522769cb2171f0b4b3e419 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1697: How to add grafana

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #1697: URL: https://github.com/apache/apisix-dashboard/pull/1697#issuecomment-895699011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1697: How to add grafana

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #1697: URL: https://github.com/apache/apisix-dashboard/pull/1697#issuecomment-895699011 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 126ca2c1f4c495554ea56a16ea40d36f17367ad3 🔍 Inspect the dep

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888083698 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888083698 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888083698 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894734801 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888075167 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: e146da2e266d21e287bf521f57c148b0cf680df0 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] okaybase edited a comment on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
okaybase edited a comment on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895712054 > so could you close this PR? because we are going to be compatible with 2.7 version :) of course, if you need, i also can do this at suitable time. --

[GitHub] [apisix-dashboard] okaybase commented on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
okaybase commented on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895712054 > so could you close this PR? because we are going to be compatible with 2.7 version :) of course~ -- This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888083698 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] okaybase closed pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
okaybase closed pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
juzhiyuan commented on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895711701 so could you close this PR? because we are going to be compatible with 2.7 version :) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] okaybase edited a comment on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
okaybase edited a comment on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895709760 > @nic-chen Please leave more detailed reasons, thanks. @nic-chen @juzhiyuan haha :smile: it doesn't matter, maybe i can understand(step by step forward

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888083698 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2010?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2010: feat: new authentication framework

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2010: URL: https://github.com/apache/apisix-dashboard/pull/2010#issuecomment-888075167 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: e146da2e266d21e287bf521f57c148b0cf680df0 🔍 Inspect the dep

[GitHub] [apisix-dashboard] okaybase commented on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
okaybase commented on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895709760 > @nic-chen Please leave more detailed reasons, thanks. @nic-chen @juzhiyuan haha :smile: it doesn't matter, maybe i can understand. -- This is an automated m

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894672192 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 96b74bf852f240cce51d425bed0e086f55005366 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894672192 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 96b74bf852f240cce51d425bed0e086f55005366 🔍 Inspect the dep

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
liuxiran commented on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-895705755 @Baoyuantop please fix the conflict files first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1981: ApiSix-Dashboard white screen

2021-08-09 Thread GitBox
juzhiyuan closed issue #1981: URL: https://github.com/apache/apisix-dashboard/issues/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1933: On the front end, the websocket button is useless

2021-08-09 Thread GitBox
juzhiyuan closed issue #1933: URL: https://github.com/apache/apisix-dashboard/issues/1933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
juzhiyuan merged pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[apisix-dashboard] branch master updated: fix: websocket enable in route (#2052)

2021-08-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new b0dfcb4 fix: websocket enable in r

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
juzhiyuan commented on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895702587 @nic-chen Please leave more detailed reasons, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1697: How to add grafana

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #1697: URL: https://github.com/apache/apisix-dashboard/pull/1697#issuecomment-895699011 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 8838a4489dc52804d83477e3d9323320959213b0 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] nic-chen commented on pull request #2049: chore: sync JSON Schema

2021-08-09 Thread GitBox
nic-chen commented on pull request #2049: URL: https://github.com/apache/apisix-dashboard/pull/2049#issuecomment-895701756 @okaybase thanks, but we couldn't sync it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1939: cannot find package "github.com/apisix/manager-api/

2021-08-09 Thread GitBox
juzhiyuan closed issue #1939: URL: https://github.com/apache/apisix-dashboard/issues/1939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1697: How to add grafana

2021-08-09 Thread GitBox
netlify[bot] commented on pull request #1697: URL: https://github.com/apache/apisix-dashboard/pull/1697#issuecomment-895699011 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 8838a4489dc52804d83477e3d9323320959213b0 🔍 Inspect the deploy log

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1765: docs: Update api documentation

2021-08-09 Thread GitBox
juzhiyuan closed pull request #1765: URL: https://github.com/apache/apisix-dashboard/pull/1765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[GitHub] [apisix-dashboard] juzhiyuan closed issue #2053: Click submit in the viewing page of Consumer will create an new consumer

2021-08-09 Thread GitBox
juzhiyuan closed issue #2053: URL: https://github.com/apache/apisix-dashboard/issues/2053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894734801 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2046?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] tzssangglass merged pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
tzssangglass merged pull request #4782: URL: https://github.com/apache/apisix/pull/4782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[apisix] branch master updated: feat(plugin): add limit quota header switch for limit-count (#4782)

2021-08-09 Thread tzssangglass
This is an automated email from the ASF dual-hosted git repository. tzssangglass pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7b69a37 feat(plugin): add limit quota hea

[GitHub] [apisix] tzssangglass commented on issue #4769: bug: unable to authenticate using the wolf-rbac plugin

2021-08-09 Thread GitBox
tzssangglass commented on issue #4769: URL: https://github.com/apache/apisix/issues/4769#issuecomment-895686414 I think you have the wrong `consumer-restriction` configuration, see: https://github.com/apache/apisix/blob/master/docs/zh/latest/plugins/consumer-restriction.md#%E7%A4%BA%E4%BE%8

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2053: Click submit in the viewing page of Consumer will create an new consumer

2021-08-09 Thread GitBox
Baoyuantop commented on issue #2053: URL: https://github.com/apache/apisix-dashboard/issues/2053#issuecomment-895685225 Solved at #1987 @jagerzhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894672192 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 7094baf692e9bfe6dd4630e42e575bcd3d7207ca 🔍 Inspect the deploy

[GitHub] [apisix] jbampton commented on pull request #4725: docs: fix spelling

2021-08-09 Thread GitBox
jbampton commented on pull request #4725: URL: https://github.com/apache/apisix/pull/4725#issuecomment-895681876 Thanks @spacewander 🥇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
Baoyuantop commented on a change in pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#discussion_r685646102 ## File path: web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js ## @@ -31,6 +31,7 @@ context('Create Edit and Dele

[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
Baoyuantop commented on a change in pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#discussion_r685645904 ## File path: web/cypress/integration/route/create-route-both-use-uri-uris.spec.js ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2046: fix: support uri/host/remote_addr

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2046: URL: https://github.com/apache/apisix-dashboard/pull/2046#issuecomment-894672192 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 7094baf692e9bfe6dd4630e42e575bcd3d7207ca 🔍 Inspect the dep

[GitHub] [apisix] tzssangglass commented on issue #4770: request help: when i run ip-restriction single test,always appears below errors

2021-08-09 Thread GitBox
tzssangglass commented on issue #4770: URL: https://github.com/apache/apisix/issues/4770#issuecomment-895679140 On the master branch, I execute `make deps` nstall the latest dependencies. Turn on etcd, and use `prove -Itest-nginx/lib -r t/plugin/ip-restriction.t` to run test, it wo

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895300843 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix] spacewander closed issue #4746: discuss: Improve bug report template

2021-08-09 Thread GitBox
spacewander closed issue #4746: URL: https://github.com/apache/apisix/issues/4746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] spacewander opened a new pull request #4784: feat: parse_addr supports IPv6 without brackets

2021-08-09 Thread GitBox
spacewander opened a new pull request #4784: URL: https://github.com/apache/apisix/pull/4784 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] zhangbing17 closed issue #4762: request help: 关于细粒度

2021-08-09 Thread GitBox
zhangbing17 closed issue #4762: URL: https://github.com/apache/apisix/issues/4762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #620: fix: sync apisix failed when use v2beta1 ApisixRoute

2021-08-09 Thread GitBox
tokers commented on a change in pull request #620: URL: https://github.com/apache/apisix-ingress-controller/pull/620#discussion_r685637444 ## File path: test/e2e/testdata/apisix-gw-config.yaml ## @@ -27,6 +27,7 @@ apisix: - 0.0.0.0/0 port_admin: 9180 stream_proxy:

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 0f4e85625092f748064bf4919939a2ad2208133a 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 0f4e85625092f748064bf4919939a2ad2208133a 🔍 Inspect the dep

[GitHub] [apisix] Xunzhuo edited a comment on issue #157: feature: support WebAssembly in apisix.

2021-08-09 Thread GitBox
Xunzhuo edited a comment on issue #157: URL: https://github.com/apache/apisix/issues/157#issuecomment-895661939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [apisix] Xunzhuo edited a comment on issue #157: feature: support WebAssembly in apisix.

2021-08-09 Thread GitBox
Xunzhuo edited a comment on issue #157: URL: https://github.com/apache/apisix/issues/157#issuecomment-895661939 @membphis If we want to achieve this in 'APISIX' ,there are couple of things to do: 1. choose a wasm runtime 2. set rules and impl wasm host in apisix 3. impl couple of l

[GitHub] [apisix] Xunzhuo commented on issue #157: feature: support WebAssembly in apisix.

2021-08-09 Thread GitBox
Xunzhuo commented on issue #157: URL: https://github.com/apache/apisix/issues/157#issuecomment-895661939 @membphis If we want to achieve this in 'APISIX' ,there are couple of things to do: -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] shoulda commented on issue #4770: request help: when i run ip-restriction single test,always appears below errors

2021-08-09 Thread GitBox
shoulda commented on issue #4770: URL: https://github.com/apache/apisix/issues/4770#issuecomment-895660407 > > ip-restriction single test > > what it is? 就是跑ip-restriction插件的单测😄 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix] okaybase commented on a change in pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
okaybase commented on a change in pull request #4782: URL: https://github.com/apache/apisix/pull/4782#discussion_r685619443 ## File path: apisix/plugins/limit-count.lua ## @@ -184,8 +185,10 @@ function _M.access(conf, ctx) return 500, {error_msg = "failed to limit coun

[GitHub] [apisix] zhangbing17 commented on issue #4769: bug: unable to authenticate using the wolf-rbac plugin

2021-08-09 Thread GitBox
zhangbing17 commented on issue #4769: URL: https://github.com/apache/apisix/issues/4769#issuecomment-895654068 > 的错误`resource '\/' not exist`,我认为这是由狼返回的。您使用的请求路径是`/`,请检查 wolf 中是否存在此请求路径。 It's changed to this, but ![image](https://user-images.githubusercontent.com/23377580/12879325

[GitHub] [apisix] okaybase commented on a change in pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
okaybase commented on a change in pull request #4782: URL: https://github.com/apache/apisix/pull/4782#discussion_r685619443 ## File path: apisix/plugins/limit-count.lua ## @@ -184,8 +185,10 @@ function _M.access(conf, ctx) return 500, {error_msg = "failed to limit coun

[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #29: ci: add master to protected_branches

2021-08-09 Thread GitBox
codecov-commenter commented on pull request #29: URL: https://github.com/apache/apisix-go-plugin-runner/pull/29#issuecomment-895649000 # [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/29?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] spacewander commented on a change in pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
spacewander commented on a change in pull request #4782: URL: https://github.com/apache/apisix/pull/4782#discussion_r685614005 ## File path: apisix/plugins/limit-count.lua ## @@ -184,8 +185,10 @@ function _M.access(conf, ctx) return 500, {error_msg = "failed to limit c

[GitHub] [apisix] spacewander merged pull request #4725: docs: fix spelling

2021-08-09 Thread GitBox
spacewander merged pull request #4725: URL: https://github.com/apache/apisix/pull/4725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: docs: fix spelling (#4725)

2021-08-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new e502977 docs: fix spelling (#4725) e502977

[GitHub] [apisix] okaybase edited a comment on pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
okaybase edited a comment on pull request #4782: URL: https://github.com/apache/apisix/pull/4782#issuecomment-895386065 > why we need this? Is there a related issue? sometimes, service provider don't want to show limit quota info to the response header, such as some crawlers. -- T

[GitHub] [apisix-dashboard] LiteSun merged pull request #1990: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules

2021-08-09 Thread GitBox
LiteSun merged pull request #1990: URL: https://github.com/apache/apisix-dashboard/pull/1990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[apisix-dashboard] branch master updated: feat(plugin): allowing limit-conn to dynamically adapt to the BE rules (#1990)

2021-08-09 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 930e47a feat(plugin): allowing limit-

[GitHub] [apisix] zhangdadan commented on issue #4776: bug: plugins:proxy_cache, GET ,apisix-cache-status return,but POST not.

2021-08-09 Thread GitBox
zhangdadan commented on issue #4776: URL: https://github.com/apache/apisix/issues/4776#issuecomment-895625928 > You can try the configuration here: > > https://github.com/apache/apisix/blob/6655a358890925ee82a23a74b4edecca4130bba0/apisix/cli/ngx_tpl.lua#L599 Thanks,it' useful --

[GitHub] [apisix] zhangdadan closed issue #4776: bug: plugins:proxy_cache, GET ,apisix-cache-status return,but POST not.

2021-08-09 Thread GitBox
zhangdadan closed issue #4776: URL: https://github.com/apache/apisix/issues/4776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895489388 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: df9c83da30181e0865955982bb12d0d6dbbf1868 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
codecov-commenter edited a comment on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
codecov-commenter commented on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895490584 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
netlify[bot] commented on pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054#issuecomment-895489388 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: df9c83da30181e0865955982bb12d0d6dbbf1868 🔍 Inspect the deploy log

[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #2054: fix: perform pid lookup for existing pid file

2021-08-09 Thread GitBox
bisakhmondal opened a new pull request #2054: URL: https://github.com/apache/apisix-dashboard/pull/2054 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [x] New feature provided

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
liuxiran commented on a change in pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#discussion_r685423533 ## File path: web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js ## @@ -31,6 +31,7 @@ context('Create Edit and Delete

[GitHub] [apisix] okaybase commented on pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
okaybase commented on pull request #4782: URL: https://github.com/apache/apisix/pull/4782#issuecomment-895386065 > why we need this? Is there a related issue? In some scenarios, such as some crawlers, service provider don't want to show limit quota info to the response header. --

[GitHub] [apisix] tzssangglass commented on pull request #4782: feat(plugin): add limit quota header switch for limit-count

2021-08-09 Thread GitBox
tzssangglass commented on pull request #4782: URL: https://github.com/apache/apisix/pull/4782#issuecomment-895385141 why we need this? Is there a related issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] tzssangglass merged pull request #4783: docs: improve redis password/timeout desc

2021-08-09 Thread GitBox
tzssangglass merged pull request #4783: URL: https://github.com/apache/apisix/pull/4783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificati

[GitHub] [apisix] tzssangglass closed issue #4781: Improve Docs: redis_password and redis_timeout can be configured both in redis policy and redis-cluster policy

2021-08-09 Thread GitBox
tzssangglass closed issue #4781: URL: https://github.com/apache/apisix/issues/4781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[apisix] branch master updated: docs: improve redis password/timeout desc (#4783)

2021-08-09 Thread tzssangglass
This is an automated email from the ASF dual-hosted git repository. tzssangglass pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2238b54 docs: improve redis password/time

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2051: fix: update menu sidebar

2021-08-09 Thread GitBox
codecov-commenter commented on pull request #2051: URL: https://github.com/apache/apisix-dashboard/pull/2051#issuecomment-895372903 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2051?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2051: fix: update menu sidebar

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2051: URL: https://github.com/apache/apisix-dashboard/pull/2051#issuecomment-895102170 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 596941c9f0eb5b8a52cd3cf928bc312946dba182 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2051: fix: update helpers.tsx

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2051: URL: https://github.com/apache/apisix-dashboard/pull/2051#issuecomment-895102170 👷 Deploy Preview for *apisix-dashboard* processing. 🔨 Explore the source changes: 596941c9f0eb5b8a52cd3cf928bc312946dba182 🔍 Inspect the dep

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2053: Click submit in the viewing page of Consumer will create an new consumer

2021-08-09 Thread GitBox
juzhiyuan commented on issue #2053: URL: https://github.com/apache/apisix-dashboard/issues/2053#issuecomment-895355700 cc @LiteSun to take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] tzssangglass commented on issue #4769: bug: unable to authenticate using the wolf-rbac plugin

2021-08-09 Thread GitBox
tzssangglass commented on issue #4769: URL: https://github.com/apache/apisix/issues/4769#issuecomment-895342787 the error of `resource '\/' not exist`,I think this was returned by wolf. The request path you are using is `/`, check if this request path exists in wolf. -- This is an auto

[GitHub] [apisix] tzssangglass commented on issue #4770: request help: when i run ip-restriction single test,always appears below errors

2021-08-09 Thread GitBox
tzssangglass commented on issue #4770: URL: https://github.com/apache/apisix/issues/4770#issuecomment-895337675 > ip-restriction single test what it is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix] tzssangglass commented on a change in pull request #4759: feat: add route_id type support

2021-08-09 Thread GitBox
tzssangglass commented on a change in pull request #4759: URL: https://github.com/apache/apisix/pull/4759#discussion_r685308683 ## File path: t/plugin/consumer-restriction.t ## @@ -1476,7 +1476,242 @@ passed -=== TEST 47: delete: route (id: 1) +=== TEST 47: update consume

[GitHub] [apisix] tzssangglass commented on issue #4762: request help: 关于细粒度

2021-08-09 Thread GitBox
tzssangglass commented on issue #4762: URL: https://github.com/apache/apisix/issues/4762#issuecomment-895325940 > 你说的这个我看咱们apisix现在是不支持的吧? It's not a question of support or not, there are many ways to achieve. Creating a lot of routes is one way to implement this, as is using casbin,

[GitHub] [apisix] tzssangglass commented on issue #4776: bug: plugins:proxy_cache, GET ,apisix-cache-status return,but POST not.

2021-08-09 Thread GitBox
tzssangglass commented on issue #4776: URL: https://github.com/apache/apisix/issues/4776#issuecomment-895323655 You can try the configuration here:https://github.com/apache/apisix/blob/6655a358890925ee82a23a74b4edecca4130bba0/apisix/cli/ngx_tpl.lua#L599 -- This is an automated message fr

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
codecov-commenter commented on pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895300843 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [apisix-dashboard] jagerzhang opened a new issue #2053: Click submit in the viewing page of Consumer will create an new consumer

2021-08-09 Thread GitBox
jagerzhang opened a new issue #2053: URL: https://github.com/apache/apisix-dashboard/issues/2053 ## Issue description Recurrence steps: 1. click [查看(veiw)] button: ![image](https://user-images.githubusercontent.com/9711651/128722692-d625c64f-28b2-4bd3-89a7-b69879f0c8f8.png)

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2052: fix: websocket enable in route

2021-08-09 Thread GitBox
netlify[bot] edited a comment on pull request #2052: URL: https://github.com/apache/apisix-dashboard/pull/2052#issuecomment-895267965 ✔️ Deploy Preview for *apisix-dashboard* ready! 🔨 Explore the source changes: 69b19d907a4aea84ba22bc44a46ac92ff0a327e9 🔍 Inspect the deploy

[GitHub] [apisix-dashboard] w7team commented on issue #2007: 路由管理不是非常方便,需要增加一个工作分区的概念

2021-08-09 Thread GitBox
w7team commented on issue #2007: URL: https://github.com/apache/apisix-dashboard/issues/2007#issuecomment-895272096 > > > How to define the concept of workspace? by region? by organization? I think if workspace is poorly defined, it is only suitable for a few scenarios. > > > >

  1   2   >