[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-10 Thread GitBox
juzhiyuan commented on pull request #2238: URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-991468278 ![image](https://user-images.githubusercontent.com/2106987/145664905-ed8cb776-91b4-4ccc-891f-2a8143e84283.png) Hi @zaunist, could you please give some hints on

[GitHub] [apisix-dashboard] kevinw66 commented on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-10 Thread GitBox
kevinw66 commented on pull request #2238: URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-991457979 > > I merged new commits from master. BTW, the ut is hard to run in local machine because of too many dependencies server, is there any plan to solve this? like mock s

[GitHub] [apisix] Fatpa commented on issue #5751: request help: unfriendly notice message return when forgetting enable Authentication plugin on route / service configuration

2021-12-10 Thread GitBox
Fatpa commented on issue #5751: URL: https://github.com/apache/apisix/issues/5751#issuecomment-991414332 Can show the warning in the apisix error log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-10 Thread GitBox
codecov-commenter edited a comment on pull request #2238: URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-990536196 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-10 Thread GitBox
codecov-commenter edited a comment on pull request #2238: URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-990536196 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2238?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-ingress-controller] mayocream commented on a change in pull request #770: feat: implement apisix healthz check

2021-12-10 Thread GitBox
mayocream commented on a change in pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#discussion_r767029638 ## File path: pkg/api/router/apisix_healthz.go ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [apisix-ingress-controller] mayocream commented on a change in pull request #770: feat: implement apisix healthz check

2021-12-10 Thread GitBox
mayocream commented on a change in pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#discussion_r767028754 ## File path: pkg/ingress/controller.go ## @@ -653,6 +653,10 @@ func (c *Controller) checkClusterHealth(ctx context.Context, cancelFun

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check

2021-12-10 Thread GitBox
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check

2021-12-10 Thread GitBox
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check

2021-12-10 Thread GitBox
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-dashboard] zaunist commented on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-10 Thread GitBox
zaunist commented on pull request #2238: URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-991214893 > I merged new commits from master. BTW, the ut is hard to run in local machine because of too many dependencies server, is there any plan to solve this? like mock serv

[GitHub] [apisix] bisakhmondal commented on pull request #5745: feat(vault): vault lua module, integration with jwt-auth authentication plugin

2021-12-10 Thread GitBox
bisakhmondal commented on pull request #5745: URL: https://github.com/apache/apisix/pull/5745#issuecomment-991138716 CI is flakey, failure is unrelated to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [apisix] bisakhmondal commented on pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
bisakhmondal commented on pull request #5768: URL: https://github.com/apache/apisix/pull/5768#issuecomment-991138270 > Could you add a test in https://github.com/apache/apisix/blob/master/t/cli/test_access_log.sh? Thanks. Done. Took a while to figure out how to set up mock upstream.

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
bisakhmondal commented on a change in pull request #5768: URL: https://github.com/apache/apisix/pull/5768#discussion_r766838032 ## File path: apisix/cli/ngx_tpl.lua ## @@ -84,6 +84,16 @@ stream { lua_ssl_trusted_certificate {* ssl.ssl_trusted_certificate *}; {% end %}

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
bisakhmondal commented on a change in pull request #5768: URL: https://github.com/apache/apisix/pull/5768#discussion_r766837786 ## File path: conf/config-default.yaml ## @@ -174,6 +174,11 @@ nginx_config: # config for render the template to generate n #

[GitHub] [apisix-go-plugin-runner] hwyzleo removed a comment on issue #52: request help: pkgHttp.Request can't handle body data?

2021-12-10 Thread GitBox
hwyzleo removed a comment on issue #52: URL: https://github.com/apache/apisix-go-plugin-runner/issues/52#issuecomment-991091748 > I'd like to try it out, but documentation for ext-plugin-proto HTTPReqCall seems pretty sparse, any documentation or best practices can be provide? --

[GitHub] [apisix-go-plugin-runner] hwyzleo commented on issue #52: request help: pkgHttp.Request can't handle body data?

2021-12-10 Thread GitBox
hwyzleo commented on issue #52: URL: https://github.com/apache/apisix-go-plugin-runner/issues/52#issuecomment-991092504 > @GhangZh Will you give it a try? I can provide some assistance. I'd like to try it out, but documentation for ext-plugin-proto HTTPReqCall seems pretty sparse, a

[GitHub] [apisix-go-plugin-runner] hwyzleo commented on issue #52: request help: pkgHttp.Request can't handle body data?

2021-12-10 Thread GitBox
hwyzleo commented on issue #52: URL: https://github.com/apache/apisix-go-plugin-runner/issues/52#issuecomment-991091748 > I'd like to try it out, but documentation for ext-plugin-proto HTTPReqCall seems pretty sparse, any documentation or best practices can be provide? -- This i

[apisix-website] branch master updated: docs: update blog contribution guidelines (#798)

2021-12-10 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new deb06ae docs: update blog contributi

[GitHub] [apisix-website] juzhiyuan merged pull request #798: docs: update blog contribution guidelines

2021-12-10 Thread GitBox
juzhiyuan merged pull request #798: URL: https://github.com/apache/apisix-website/pull/798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #798: docs: update blog contribution guidelines

2021-12-10 Thread GitBox
1502shivam-singh commented on a change in pull request #798: URL: https://github.com/apache/apisix-website/pull/798#discussion_r766689127 ## File path: website/docs/general/blog-contributing-guide.md ## @@ -48,6 +48,8 @@ To add a new blog, please perform the following steps:

[GitHub] [apisix] zsjinwei edited a comment on issue #4942: bug: upstreaam response http code 302,then we found it was be redirected to an new port 9080

2021-12-10 Thread GitBox
zsjinwei edited a comment on issue #4942: URL: https://github.com/apache/apisix/issues/4942#issuecomment-990975047 > @z-yuxie Try to use the `serverless-functions` plugins to rewrite headers in the `header_filter` phase, you can inject your own logics there. I have this issue too, co

[GitHub] [apisix] zsjinwei commented on issue #4942: bug: upstreaam response http code 302,then we found it was be redirected to an new port 9080

2021-12-10 Thread GitBox
zsjinwei commented on issue #4942: URL: https://github.com/apache/apisix/issues/4942#issuecomment-990975047 > @z-yuxie Try to use the `serverless-functions` plugins to rewrite headers in the `header_filter` phase, you can inject your own logics there. I encount this issue too, could

[GitHub] [apisix-java-plugin-runner] yunfhu opened a new issue #97: request help: apisix unable to start java-plugin-runner

2021-12-10 Thread GitBox
yunfhu opened a new issue #97: URL: https://github.com/apache/apisix-java-plugin-runner/issues/97 ### APISIX Config > ext-plugin: > cmd: ['java', '-jar','/usr/local/apisix/apisix-runner-bin/apisix-java-plugin-runner.jar'] ### the plugin files under /usr/local/apisix/apisix-ru

[GitHub] [apisix] kingmouse-yx commented on issue #5708: request help: go-plugin-runner error after starting in debug mode

2021-12-10 Thread GitBox
kingmouse-yx commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-990943941 Bro, I also met the general problem, can you tell me how to solve it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] moonming commented on issue #5755: [DISCUSS]: Improving the performance of the prometheus plugin

2021-12-10 Thread GitBox
moonming commented on issue #5755: URL: https://github.com/apache/apisix/issues/5755#issuecomment-990937830 Do we have other ways to switch out some CPU time? So many hard-coded `ngx_sleep(0)` do not look good enough. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
bisakhmondal commented on a change in pull request #5768: URL: https://github.com/apache/apisix/pull/5768#discussion_r766633672 ## File path: conf/config-default.yaml ## @@ -174,6 +174,11 @@ nginx_config: # config for render the template to generate n #

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5745: feat(vault): vault lua module, integration with jwt-auth authentication plugin

2021-12-10 Thread GitBox
bisakhmondal commented on a change in pull request #5745: URL: https://github.com/apache/apisix/pull/5745#discussion_r766629214 ## File path: t/plugin/jwt-auth-vault.t ## @@ -0,0 +1,369 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor l

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5745: feat(vault): vault lua module, integration with jwt-auth authentication plugin

2021-12-10 Thread GitBox
bisakhmondal commented on a change in pull request #5745: URL: https://github.com/apache/apisix/pull/5745#discussion_r766628743 ## File path: apisix/plugins/jwt-auth.lua ## @@ -28,7 +29,7 @@ local ngx_time = ngx.time local sub_str = string.sub local plugin_name = "jwt-auth"

[GitHub] [apisix-website] juzhiyuan merged pull request #802: docs: add cover pic for keycloak blog

2021-12-10 Thread GitBox
juzhiyuan merged pull request #802: URL: https://github.com/apache/apisix-website/pull/802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[apisix-website] branch master updated: docs: add cover pic for keycloak blog (#802)

2021-12-10 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new d1808f8 docs: add cover pic for keyc

[GitHub] [apisix-dashboard] github-actions[bot] closed issue #2141: bug: Demo site is built from the latest code

2021-12-10 Thread GitBox
github-actions[bot] closed issue #2141: URL: https://github.com/apache/apisix-dashboard/issues/2141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2140: test: unstable test case search-route

2021-12-10 Thread GitBox
github-actions[bot] commented on issue #2140: URL: https://github.com/apache/apisix-dashboard/issues/2140#issuecomment-990804120 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any tim

[GitHub] [apisix-dashboard] github-actions[bot] closed issue #2140: test: unstable test case search-route

2021-12-10 Thread GitBox
github-actions[bot] closed issue #2140: URL: https://github.com/apache/apisix-dashboard/issues/2140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [apisix-dashboard] github-actions[bot] commented on issue #2141: bug: Demo site is built from the latest code

2021-12-10 Thread GitBox
github-actions[bot] commented on issue #2141: URL: https://github.com/apache/apisix-dashboard/issues/2141#issuecomment-990804142 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any tim

[GitHub] [apisix] github-actions[bot] commented on issue #3115: 类似网关指定的路由或服务请求一个指定服务地址,根据地址定义的参数控制是否通过,并可以将部分参数传递下游?

2021-12-10 Thread GitBox
github-actions[bot] commented on issue #3115: URL: https://github.com/apache/apisix/issues/3115#issuecomment-990803132 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simp

[GitHub] [apisix] zuiyangqingzhou commented on pull request #5728: fix(ua-restriction): refine the ua-restriction plugin configuration checksum logic

2021-12-10 Thread GitBox
zuiyangqingzhou commented on pull request #5728: URL: https://github.com/apache/apisix/pull/5728#issuecomment-990795264 > Could you add a test in https://github.com/apache/apisix/blob/master/t/plugin/ua-restriction.t? OK -- This is an automated message from the Apache Git Service

[GitHub] [apisix-website] yzeng25 opened a new pull request #802: docs: add cover pic for keycloak blog

2021-12-10 Thread GitBox
yzeng25 opened a new pull request #802: URL: https://github.com/apache/apisix-website/pull/802 Changes: add cover pic for keycloak blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] qq54903099 commented on issue #5710: request help: Can the jwt plugin support custom authentication parameter names?

2021-12-10 Thread GitBox
qq54903099 commented on issue #5710: URL: https://github.com/apache/apisix/issues/5710#issuecomment-990780041 > just like hmac-plugin;global rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-website] branch master updated: chore(navbar): take Team & Helo from Resources navbar (#800)

2021-12-10 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 4a6b17c chore(navbar): take Team & H

[GitHub] [apisix-dashboard] kevinw66 commented on pull request #2238: feat: Support APISIX_PROFILE for env-specific configuration

2021-12-10 Thread GitBox
kevinw66 commented on pull request #2238: URL: https://github.com/apache/apisix-dashboard/pull/2238#issuecomment-99021 I merged new commits from master. BTW, the ut is hard to run in local machine because of too many dependencies server, is there any plan to solve this? like mock ser

[GitHub] [apisix-website] juzhiyuan merged pull request #801: docs: add APISIX 2.11.0 release blog

2021-12-10 Thread GitBox
juzhiyuan merged pull request #801: URL: https://github.com/apache/apisix-website/pull/801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[apisix-website] branch master updated: docs: add APISIX 2.11.0 release blog (#801)

2021-12-10 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new f36265c docs: add APISIX 2.11.0 rele

[GitHub] [apisix] hepyu commented on issue #5692: request help: etcd high load, etcd high cpu usage, and "put /data_plane/server_info" have lots of "apply request took too long" error

2021-12-10 Thread GitBox
hepyu commented on issue #5692: URL: https://github.com/apache/apisix/issues/5692#issuecomment-990766775 > I suspect the same direction as you, but I need to reproduce the problem. Or would you be willing to provide a flame graph, with the server_info plugin loaded and CPU and load high, t

[GitHub] [apisix] spacewander commented on a change in pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
spacewander commented on a change in pull request #5768: URL: https://github.com/apache/apisix/pull/5768#discussion_r766494278 ## File path: apisix/cli/ngx_tpl.lua ## @@ -84,6 +84,16 @@ stream { lua_ssl_trusted_certificate {* ssl.ssl_trusted_certificate *}; {% end %}

[GitHub] [apisix-go-plugin-runner] GhangZh commented on issue #53: request help: support http proxy

2021-12-10 Thread GitBox
GhangZh commented on issue #53: URL: https://github.com/apache/apisix-go-plugin-runner/issues/53#issuecomment-990758372 > > 1. you can get/set the header via Request.Header, see https://pkg.go.dev/github.com/apache/apisix-go-plugin-runner@v0.2.0/pkg/http#Header > 2. you

[GitHub] [apisix-go-plugin-runner] GhangZh removed a comment on issue #53: request help: support http proxy

2021-12-10 Thread GitBox
GhangZh removed a comment on issue #53: URL: https://github.com/apache/apisix-go-plugin-runner/issues/53#issuecomment-990757998 > I want to proxy all the responses. Is there any way to do that? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix-go-plugin-runner] GhangZh commented on issue #53: request help: support http proxy

2021-12-10 Thread GitBox
GhangZh commented on issue #53: URL: https://github.com/apache/apisix-go-plugin-runner/issues/53#issuecomment-990757998 > I want to proxy all the responses. Is there any way to do that? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-website] SylviaBABY commented on a change in pull request #801: docs: add APISIX 2.11.0 release blog

2021-12-10 Thread GitBox
SylviaBABY commented on a change in pull request #801: URL: https://github.com/apache/apisix-website/pull/801#discussion_r766491925 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/release-apache-apisix-2.11.md ## @@ -0,0 +1,176 @@ +--- +title: "Apache A

[GitHub] [apisix] spacewander commented on a change in pull request #5745: feat(vault): vault lua module, integration with jwt-auth authentication plugin

2021-12-10 Thread GitBox
spacewander commented on a change in pull request #5745: URL: https://github.com/apache/apisix/pull/5745#discussion_r766469765 ## File path: t/plugin/jwt-auth-vault.t ## @@ -0,0 +1,369 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor li

[GitHub] [apisix-go-plugin-runner] fifsky commented on issue #52: request help: pkgHttp.Request can't handle body data?

2021-12-10 Thread GitBox
fifsky commented on issue #52: URL: https://github.com/apache/apisix-go-plugin-runner/issues/52#issuecomment-990749287 I also really need this functionality. My case is to validate the signature of the API request, and without the Request Body, the signature value cannot be validate --

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #801: docs: add APISIX 2.11.0 release blog

2021-12-10 Thread GitBox
juzhiyuan commented on a change in pull request #801: URL: https://github.com/apache/apisix-website/pull/801#discussion_r766485447 ## File path: website/i18n/zh/docusaurus-plugin-content-blog/2021/12/01/release-apache-apisix-2.11.md ## @@ -0,0 +1,176 @@ +--- +title: "Apache AP

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #801: docs: add APISIX 2.11.0 release blog

2021-12-10 Thread GitBox
yzeng25 commented on a change in pull request #801: URL: https://github.com/apache/apisix-website/pull/801#discussion_r766479217 ## File path: website/blog/2021/12/01/release-apache-apisix-2.11.md ## @@ -0,0 +1,176 @@ +--- +title: "Apache APISIX 2.11.0 is officially released wi

[GitHub] [apisix] bisakhmondal commented on a change in pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
bisakhmondal commented on a change in pull request #5768: URL: https://github.com/apache/apisix/pull/5768#discussion_r766479073 ## File path: conf/config-default.yaml ## @@ -174,6 +174,11 @@ nginx_config: # config for render the template to generate n #

[GitHub] [apisix] bisakhmondal opened a new pull request #5768: feat: enable L4 stream logging

2021-12-10 Thread GitBox
bisakhmondal opened a new pull request #5768: URL: https://github.com/apache/apisix/pull/5768 ### What this PR does / why we need it: closes #5400 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have

[GitHub] [apisix-website] SylviaBABY opened a new pull request #801: docs: add APISIX 2.11.0 release blog

2021-12-10 Thread GitBox
SylviaBABY opened a new pull request #801: URL: https://github.com/apache/apisix-website/pull/801 Changes: add Apache APISIX 2.11.0 release blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-ingress-controller] neverCase opened a new pull request #792: feat: add ApisixPluginConfigs crd to v2beta3 (#746) (#638) (#791)

2021-12-10 Thread GitBox
neverCase opened a new pull request #792: URL: https://github.com/apache/apisix-ingress-controller/pull/792 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-10 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990718925 > > I think the current PR can be retained. > > You can create a new PR and only upgrade ApisixPluginConfig to v2beta3 > > You can

[GitHub] [apisix] bzp2010 commented on a change in pull request #5734: feat: support OPA plugin

2021-12-10 Thread GitBox
bzp2010 commented on a change in pull request #5734: URL: https://github.com/apache/apisix/pull/5734#discussion_r766456808 ## File path: t/plugin/opa.t ## @@ -0,0 +1,139 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #53: request help: support http proxy

2021-12-10 Thread GitBox
spacewander commented on issue #53: URL: https://github.com/apache/apisix-go-plugin-runner/issues/53#issuecomment-990716684 1. you can get/set the header via Request.Header, see https://pkg.go.dev/github.com/apache/apisix-go-plugin-runner@v0.2.0/pkg/http#Header 2. you can stop the reque

[GitHub] [apisix] bzp2010 commented on a change in pull request #5734: feat: support OPA plugin

2021-12-10 Thread GitBox
bzp2010 commented on a change in pull request #5734: URL: https://github.com/apache/apisix/pull/5734#discussion_r766455352 ## File path: apisix/plugins/opa.lua ## @@ -0,0 +1,103 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor licens

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-10 Thread GitBox
tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990716295 I think the current PR can be retained. You can create a new PR and only upgrade ApisixPluginConfig to v2beta3 You can update this PR after t

[GitHub] [apisix] bzp2010 commented on a change in pull request #5734: feat: support OPA plugin

2021-12-10 Thread GitBox
bzp2010 commented on a change in pull request #5734: URL: https://github.com/apache/apisix/pull/5734#discussion_r766454197 ## File path: t/plugin/opa.t ## @@ -0,0 +1,140 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-10 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990714164 > > But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in > > the v2beta2 directory > > Yes, a

[GitHub] [apisix-ingress-controller] neverCase removed a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-10 Thread GitBox
neverCase removed a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990713769 ping @tao12345666333 > > But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in > > th

[GitHub] [apisix-ingress-controller] neverCase closed pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-10 Thread GitBox
neverCase closed pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-10 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-990713769 ping @tao12345666333 > > But the changes about the v2beta3 make me confused, cause my previous pr about the ApisixPluginConfig was in > > the v2beta