[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000709894 > > > You can customize the `log_format`field in plugin metadata according to your needs. > > > > > > 试了下没生效,配置如下: > > ``` > > { > > "batch_max_size": 1, >

[GitHub] [apisix] xianshun163 commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-23 Thread GitBox
xianshun163 commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1000709543 yes, you only config a route, you can config a upstream ,and a services, use the discovery type of nacos. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix] spacewander commented on issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

2021-12-23 Thread GitBox
spacewander commented on issue #5900: URL: https://github.com/apache/apisix/issues/5900#issuecomment-1000708181 > useful, maybe *-auth plugins are all needed I don't think blindly applying this to other *-auth plugins is a good idea. Take jwt-auth as an example, the JWT token serves

[GitHub] [apisix] spacewander merged pull request #5881: feat(limit-count): allow sharing counter

2021-12-23 Thread GitBox
spacewander merged pull request #5881: URL: https://github.com/apache/apisix/pull/5881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] spacewander closed issue #5342: request help: share limit counter between routes

2021-12-23 Thread GitBox
spacewander closed issue #5342: URL: https://github.com/apache/apisix/issues/5342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[apisix] branch master updated (abbe266 -> 7a56580)

2021-12-23 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from abbe266 ci: the trailing whitespace check is already covered by editconfig (#5903) add 7a56580 feat(limi

[GitHub] [apisix] spacewander merged pull request #5903: ci: the trailing whitespace check is already covered by editconfig

2021-12-23 Thread GitBox
spacewander merged pull request #5903: URL: https://github.com/apache/apisix/pull/5903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: ci: the trailing whitespace check is already covered by editconfig (#5903)

2021-12-23 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new abbe266 ci: the trailing whitespace check

[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000706326 > > You can customize the `log_format`field in plugin metadata according to your needs. > > 试了下没生效,配置如下: > > ``` > { > "batch_max_size": 1, > "broker_lis

[GitHub] [apisix] spacewander opened a new pull request #5916: fix(mqtt): handle properties for MQTT 5

2021-12-23 Thread GitBox
spacewander opened a new pull request #5916: URL: https://github.com/apache/apisix/pull/5916 Fix #5909 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR

[GitHub] [apisix] jagerzhang edited a comment on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang edited a comment on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000699400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [apisix] jagerzhang edited a comment on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang edited a comment on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000699400 > You can customize the `log_format`field in plugin metadata according to your needs. 试了下没生效,配置如下: ··· { "batch_max_size": 1, "broker_list": {

[GitHub] [apisix] jagerzhang edited a comment on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang edited a comment on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000699400 > You can customize the `log_format`field in plugin metadata according to your needs. 试了下没生效,配置如下: ··· { "batch_max_size": 1, "broker_list": { "X.X

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997183430 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000699400 > You can customize the `log_format`field in plugin metadata according to your needs. 用log_format好像要把所有的字段都填写上才行吧? 并不是追加的逻辑。 -- This is an automated message from the Apac

[GitHub] [apisix] jagerzhang commented on issue #5915: request help: logger plugins supports limit size of request/response body

2021-12-23 Thread GitBox
jagerzhang commented on issue #5915: URL: https://github.com/apache/apisix/issues/5915#issuecomment-1000699042 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774909057 ## File path: t/plugin/opa2.t ## @@ -0,0 +1,206 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-23 Thread GitBox
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1000697148 I followed your way and could not reproduce. Here are the steps I took to reproduce it step 1 start Nacos 2.0.1 as satndalone(get from https://github.co

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #811: ingress-controller failed to list routes

2021-12-23 Thread GitBox
tao12345666333 commented on issue #811: URL: https://github.com/apache/apisix-ingress-controller/issues/811#issuecomment-1000696926 How did you install it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] leslie-tsang commented on pull request #5894: feat: support Nacos 2.x

2021-12-23 Thread GitBox
leslie-tsang commented on pull request #5894: URL: https://github.com/apache/apisix/pull/5894#issuecomment-1000692568 > > We need test cases. But previously we found that there were too many nacos instances in the CI and they were taking up too much memory. I wanted to find a way to reduce

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #774: fix: delete the cluster object when give up the leadership

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#issuecomment-979773656 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/774?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[apisix-ingress-controller] branch fix/connect-to-apisix updated (984cde1 -> cbcda7f)

2021-12-23 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a change to branch fix/connect-to-apisix in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from 984cde1 fix (#808) add cbcda7f chore: rm v1.17 build comment No new re

[GitHub] [apisix] panhow commented on issue #3537: bug: failed to run balancer_by_lua*: /usr/local/share/lua/5.1/resty/healthcheck.lua:247: attempt to index field 'targets' (a nil value)

2021-12-23 Thread GitBox
panhow commented on issue #3537: URL: https://github.com/apache/apisix/issues/3537#issuecomment-1000689996 @spacewander hello , wonder why #3240 can fix this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] zjzwjcbj commented on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm

2021-12-23 Thread GitBox
zjzwjcbj commented on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1000688055 How to install java plugin when apisix installed by helm. Seem the apisix pod has no java environment. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix-website] juzhiyuan closed issue #823: The apisix-website return 503 error

2021-12-23 Thread GitBox
juzhiyuan closed issue #823: URL: https://github.com/apache/apisix-website/issues/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notification

[GitHub] [apisix-website] juzhiyuan commented on issue #823: The apisix-website return 503 error

2021-12-23 Thread GitBox
juzhiyuan commented on issue #823: URL: https://github.com/apache/apisix-website/issues/823#issuecomment-1000686902 resolved by ASF Infra. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix-ingress-controller] xiongyunhua-star opened a new issue #811: ingress-controller failed to list routes

2021-12-23 Thread GitBox
xiongyunhua-star opened a new issue #811: URL: https://github.com/apache/apisix-ingress-controller/issues/811 ### Issue description logs: [root@k8smaster apisix]# kubectl logs -f apisix-ingress-controller-f68756d54-59vsk -n ingress-apisix 2021-12-24T13:37:57+08:00 info

[GitHub] [apisix] tzssangglass commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
tzssangglass commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774893148 ## File path: t/plugin/opa2.t ## @@ -0,0 +1,206 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agr

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
gxthrj merged pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] shoulda commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
shoulda commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000673600 > ### Issue description > 现在所有日志插件就只能上报 latency 字段,能否将后端耗时和APISIX本身的耗时也分开记录下,方便运营分析? > > ### Environment > APISIX version: 2.11.0 请教一个问题,我们这边准备用prometheus来上报日志的,但是如

[GitHub] [apisix] tokers commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
tokers commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1000669268 You can customize the `log_format`field in plugin metadata according to your needs. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix-website] juzhiyuan merged pull request #824: docs: add APISIX&OpenWhisk Blog

2021-12-23 Thread GitBox
juzhiyuan merged pull request #824: URL: https://github.com/apache/apisix-website/pull/824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[apisix-website] branch master updated: docs: add APISIX&OpenWhisk Blog (#824)

2021-12-23 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new ee50b20 docs: add APISIX&OpenWhisk B

[GitHub] [apisix] tokers edited a comment on issue #5902: Proposal: include performance test and flamegraphs in CI

2021-12-23 Thread GitBox
tokers edited a comment on issue #5902: URL: https://github.com/apache/apisix/issues/5902#issuecomment-1000668869 > Yes, so the flamegraphs is not generated when the test case is run. We need to add a performance test step, and generate flamegraphs during performance testing. Got it

[GitHub] [apisix] tokers commented on issue #5902: Proposal: include performance test and flamegraphs in CI

2021-12-23 Thread GitBox
tokers commented on issue #5902: URL: https://github.com/apache/apisix/issues/5902#issuecomment-1000668869 > Yes, so the flamegraphs is not generated when the test case is run. We need to add a performance test step, and generate flamegraphs during performance testing. Got it. --

[GitHub] [apisix] tzssangglass commented on issue #5902: Proposal: include performance test and flamegraphs in CI

2021-12-23 Thread GitBox
tzssangglass commented on issue #5902: URL: https://github.com/apache/apisix/issues/5902#issuecomment-1000668704 Yes, so the flamegraphs is not generated when the test case is run. We need to add a performance test step, and generate flamegraphs during performance testing. -- This is an

[GitHub] [apisix] tokers commented on issue #5902: Proposal: include performance test and flamegraphs in CI

2021-12-23 Thread GitBox
tokers commented on issue #5902: URL: https://github.com/apache/apisix/issues/5902#issuecomment-1000667640 > I want to generate flamegraphs during performance testing. As far I as know, APISIX will be started before a case and be shutdown after a case, so actually it's not running co

[GitHub] [apisix] tzssangglass commented on issue #5902: Proposal: include performance test and flamegraphs in CI

2021-12-23 Thread GitBox
tzssangglass commented on issue #5902: URL: https://github.com/apache/apisix/issues/5902#issuecomment-1000667301 I want to generate flamegraphs during performance testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [apisix] tzssangglass commented on issue #5915: request help: logger plugins supports limit size of request/response body

2021-12-23 Thread GitBox
tzssangglass commented on issue #5915: URL: https://github.com/apache/apisix/issues/5915#issuecomment-1000667097 we can truncate oversized request and response bodies based on limit size -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] tzssangglass opened a new issue #5915: request help: logger plugins supports limit size of request/response body

2021-12-23 Thread GitBox
tzssangglass opened a new issue #5915: URL: https://github.com/apache/apisix/issues/5915 ### Discussed in https://github.com/apache/apisix/discussions/5892 Originally posted by **lrfdehao** December 23, 2021 Suppose I have two fields, `include_resp_body` as the switch, `re

[GitHub] [apisix] leslie-tsang opened a new pull request #5914: fix(proxy-rewrite): make sure proxy-rewrite hit the core.request.header cache

2021-12-23 Thread GitBox
leslie-tsang opened a new pull request #5914: URL: https://github.com/apache/apisix/pull/5914 ### What this PR does / why we need it: Ref to #5858 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features h

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#issuecomment-989003366 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix] jagerzhang opened a new issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-23 Thread GitBox
jagerzhang opened a new issue #5910: URL: https://github.com/apache/apisix/issues/5910 ### Issue description 现在所有日志插件就只能上报 latency 字段,能否将后端耗时和APISIX本身的耗时也分开记录下,方便运营分析? ### Environment APISIX version: 2.11.0 -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#issuecomment-989003366 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
tao12345666333 commented on a change in pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#discussion_r774870937 ## File path: pkg/ingress/gateway.go ## @@ -0,0 +1,156 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
tao12345666333 commented on a change in pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#discussion_r774870882 ## File path: pkg/ingress/gateway.go ## @@ -0,0 +1,156 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#issuecomment-989003366 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-dashboard] lemonrains opened a new issue #2264: Docker Hub have not push the latest version yet

2021-12-23 Thread GitBox
lemonrains opened a new issue #2264: URL: https://github.com/apache/apisix-dashboard/issues/2264 # Feature request Docker Hub have not push the latest version yet . ## Describe the solution you'd like Recent version 2.10 and 2.10.1 was not push to the docker hub. http

[GitHub] [apisix-docker] bzp2010 commented on a change in pull request #259: feat: support CentOS image for dashboard

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #259: URL: https://github.com/apache/apisix-docker/pull/259#discussion_r774859689 ## File path: dashboard/Dockerfile.centos ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774857975 ## File path: t/plugin/opa2.t ## @@ -0,0 +1,217 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774857791 ## File path: t/plugin/opa2.t ## @@ -0,0 +1,217 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774857765 ## File path: t/plugin/opa2.t ## @@ -0,0 +1,217 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [apisix] hwy1782 closed pull request #5899: docs: update mqtt-proxy.md example

2021-12-23 Thread GitBox
hwy1782 closed pull request #5899: URL: https://github.com/apache/apisix/pull/5899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [apisix] leslie-tsang commented on issue #5858: bug: Using proxy-rewrite to overwrite the request header x-forwarded-proto failed

2021-12-23 Thread GitBox
leslie-tsang commented on issue #5858: URL: https://github.com/apache/apisix/issues/5858#issuecomment-1000629586 @juzhiyuan Plz, assign to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #824: docs: add APISIX&OpenWhisk Blog

2021-12-23 Thread GitBox
netlify[bot] edited a comment on pull request #824: URL: https://github.com/apache/apisix-website/pull/824#issuecomment-1000623458 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 88d89cd1fdd6f5d1c0cdc05d78e82b4919079716 🔍 Inspect the deploy log:

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0

2021-12-23 Thread GitBox
juzhiyuan commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-1000625465 🥰🥰 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-dashboard] nimohunter closed pull request #2247: update the kin-openapi to v0.86.0

2021-12-23 Thread GitBox
nimohunter closed pull request #2247: URL: https://github.com/apache/apisix-dashboard/pull/2247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: no

[GitHub] [apisix] hwy1782 opened a new issue #5909: request help: mqtt-proxy plugin cannot work

2021-12-23 Thread GitBox
hwy1782 opened a new issue #5909: URL: https://github.com/apache/apisix/issues/5909 ### Issue description my apixis verison is: 2.11.0 my os version is : CentOS Linux release 8.1.1911 (Core) I have turned on the stream_proxy function,as follow: ``` stream_proxy:

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #824: docs: add APISIX&OpenWhisk Blog

2021-12-23 Thread GitBox
netlify[bot] edited a comment on pull request #824: URL: https://github.com/apache/apisix-website/pull/824#issuecomment-1000623458 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 88d89cd1fdd6f5d1c0cdc05d78e82b4919079716 🔍 Inspect the deploy lo

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #824: docs: add APISIX&OpenWhisk Blog

2021-12-23 Thread GitBox
netlify[bot] edited a comment on pull request #824: URL: https://github.com/apache/apisix-website/pull/824#issuecomment-1000623458 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: c1b629f90a7f84123e93c244f6cd61bcae0eed1e 🔍 Inspect the deploy log:

[GitHub] [apisix] gxthrj closed issue #5908: request help: Judge that a certain header does not exist, can not pass nil

2021-12-23 Thread GitBox
gxthrj closed issue #5908: URL: https://github.com/apache/apisix/issues/5908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix] gxthrj commented on issue #5908: request help: Judge that a certain header does not exist, can not pass nil

2021-12-23 Thread GitBox
gxthrj commented on issue #5908: URL: https://github.com/apache/apisix/issues/5908#issuecomment-1000623984 Close this issue, json do not support`nil`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix-website] netlify[bot] commented on pull request #824: docs: add APISIX&OpenWhisk Blog

2021-12-23 Thread GitBox
netlify[bot] commented on pull request #824: URL: https://github.com/apache/apisix-website/pull/824#issuecomment-1000623458 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: c1b629f90a7f84123e93c244f6cd61bcae0eed1e 🔍 Inspect the deploy log: [ht

[GitHub] [apisix-website] SylviaBABY opened a new pull request #824: docs: add APISIX&OpenWhisk Blog

2021-12-23 Thread GitBox
SylviaBABY opened a new pull request #824: URL: https://github.com/apache/apisix-website/pull/824 Changes: add APISIX&OpenWhisk Blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] gxthrj opened a new issue #5908: request help: Judge that a certain header does not exist, can not pass nil

2021-12-23 Thread GitBox
gxthrj opened a new issue #5908: URL: https://github.com/apache/apisix/issues/5908 ### Issue description To determine that a header does not exist, you need to use `null`, it works like: ``` curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
tokers commented on a change in pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#discussion_r774849079 ## File path: pkg/ingress/gateway.go ## @@ -0,0 +1,156 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contr

[GitHub] [apisix-dashboard] nimohunter commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0

2021-12-23 Thread GitBox
nimohunter commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-1000621808 oh, > > > Of course that we may miss some route's parameter. > > > > > > And we could make sure all parameters that Apache APISIX needs are kept? 😄

[GitHub] [apisix] zjzwjcbj commented on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm

2021-12-23 Thread GitBox
zjzwjcbj commented on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1000611211 > > ### Issue description > > I installed apisix by helm .How can I add ext-plugin in config.yaml. like: ![image](https://user-images.githubusercontent.com/26433840/147234745-893

[GitHub] [apisix] shoulda opened a new issue #5904: request help: Request help about prometheus plugin

2021-12-23 Thread GitBox
shoulda opened a new issue #5904: URL: https://github.com/apache/apisix/issues/5904 ### Issue description Using the prometheus plugin collect logs, When the log volume is large, the size of lua_shared_dict prometheus-metrics will become a bottleneck? ### Environment

[GitHub] [apisix] tokers commented on issue #5902: Proposal: include performance test and flamegraphs in CI

2021-12-23 Thread GitBox
tokers commented on issue #5902: URL: https://github.com/apache/apisix/issues/5902#issuecomment-1000606052 That's good, do you mean sampling APISIX when the test cases run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] tokers commented on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm

2021-12-23 Thread GitBox
tokers commented on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1000605832 > ### Issue description > I installed apisix by helm .How can I add ext-plugin in config.yaml. like: ![image](https://user-images.githubusercontent.com/26433840/147234745-8934fc99-f

[GitHub] [apisix] tokers commented on a change in pull request #5897: feat(plugin): add degradation switch for ext-plugin

2021-12-23 Thread GitBox
tokers commented on a change in pull request #5897: URL: https://github.com/apache/apisix/pull/5897#discussion_r774836323 ## File path: apisix/plugins/ext-plugin/init.lua ## @@ -700,6 +701,9 @@ function _M.communicate(conf, ctx, plugin_name) if not core.string.find(e

[GitHub] [apisix] spacewander commented on a change in pull request #5881: feat(limit-count): allow sharing counter

2021-12-23 Thread GitBox
spacewander commented on a change in pull request #5881: URL: https://github.com/apache/apisix/pull/5881#discussion_r774835603 ## File path: apisix/plugins/limit-count.lua ## @@ -192,7 +248,12 @@ function _M.access(conf, ctx) key = ctx.var["remote_addr"] end -

[GitHub] [apisix] tokers commented on issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

2021-12-23 Thread GitBox
tokers commented on issue #5900: URL: https://github.com/apache/apisix/issues/5900#issuecomment-1000604082 > useful, maybe *-auth plugins are all needed Exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2247: update the kin-openapi to v0.86.0

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #2247: URL: https://github.com/apache/apisix-dashboard/pull/2247#issuecomment-995419398 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2247: update the kin-openapi to v0.86.0

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #2247: URL: https://github.com/apache/apisix-dashboard/pull/2247#issuecomment-995419398 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-website] zaunist opened a new issue #823: The apisix-website return 503 error

2021-12-23 Thread GitBox
zaunist opened a new issue #823: URL: https://github.com/apache/apisix-website/issues/823 **Actual Behaviour** When I visited `https://apisix.apache.org/zh/docs/apisix/next/getting-started`, get a 503 error. **Expected Behaviour** Return a normal html

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2247: update the kin-openapi to v0.86.0

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #2247: URL: https://github.com/apache/apisix-dashboard/pull/2247#issuecomment-995419398 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #774: fix: delete the cluster object when give up the leadership

2021-12-23 Thread GitBox
tao12345666333 commented on a change in pull request #774: URL: https://github.com/apache/apisix-ingress-controller/pull/774#discussion_r774833974 ## File path: tools.go ## @@ -1,3 +1,4 @@ +//go:build tools Review comment: Since this is a bug, I hope to merge it into v

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2262: Apisix dashboard service's health check does not take effect

2021-12-23 Thread GitBox
juzhiyuan commented on issue #2262: URL: https://github.com/apache/apisix-dashboard/issues/2262#issuecomment-1000602404 cc @Baoyuantop to have a check, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2204: chore: update setup script for e2e tests (ginkgo)

2021-12-23 Thread GitBox
juzhiyuan commented on pull request #2204: URL: https://github.com/apache/apisix-dashboard/pull/2204#issuecomment-1000601120 Hi @bisakhmondal, not sure why that CI failed, may rerun that CI? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix] xianshun163 commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-23 Thread GitBox
xianshun163 commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1000600962 I have find the relate nacos problem #5815 , and it is using spring cloud grpc port . I use the http port, -- This is an automated message from the Apache Git Servi

[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-23 Thread GitBox
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1000600864 You can see the problem by looking at the PR above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] xianshun163 commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-23 Thread GitBox
xianshun163 commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-1000599508 I am trying to use nacos too, and I use spring cloud http way. ApiSix cat use the port of the http service,have you find some problem with the http service? -- This is

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
tao12345666333 commented on pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#issuecomment-1000599133 ping @gxthrj @tokers for review, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix] spacewander commented on a change in pull request #5881: feat(limit-count): allow sharing counter

2021-12-23 Thread GitBox
spacewander commented on a change in pull request #5881: URL: https://github.com/apache/apisix/pull/5881#discussion_r774830359 ## File path: apisix/plugins/limit-count.lua ## @@ -192,7 +248,12 @@ function _M.access(conf, ctx) key = ctx.var["remote_addr"] end -

[GitHub] [apisix] xianshun163 commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-23 Thread GitBox
xianshun163 commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1000596304 can you tell me what is the problem with the nacos 2.x,except what I said above 。 May be I have to try to fix it, because I have use the nacos 2.x in the product,In

[GitHub] [apisix] spacewander opened a new pull request #5903: ci: the trailing whitespace check is already covered by editconfig

2021-12-23 Thread GitBox
spacewander opened a new pull request #5903: URL: https://github.com/apache/apisix/pull/5903 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what n

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774726629 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +52,136 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774726348 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +52,136 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774724527 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +52,136 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774717595 ## File path: ci/pod/docker-compose.yml ## @@ -402,11 +402,14 @@ services: restart: unless-stopped ports: - 8181:8181 -command: run -s

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774717192 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +52,136 @@ local function build_http_request(conf, ctx) end -function _M.build_opa_input(conf

[GitHub] [apisix-docker] bzp2010 commented on a change in pull request #259: feat: support CentOS image for dashboard

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #259: URL: https://github.com/apache/apisix-docker/pull/259#discussion_r774708974 ## File path: dashboard/Dockerfile.centos ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix-docker] bzp2010 commented on a change in pull request #259: feat: support CentOS image for dashboard

2021-12-23 Thread GitBox
bzp2010 commented on a change in pull request #259: URL: https://github.com/apache/apisix-docker/pull/259#discussion_r774691471 ## File path: dashboard/Dockerfile.centos ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix-docker] tao12345666333 commented on a change in pull request #259: feat: support CentOS image for dashboard

2021-12-23 Thread GitBox
tao12345666333 commented on a change in pull request #259: URL: https://github.com/apache/apisix-docker/pull/259#discussion_r774684371 ## File path: dashboard/Dockerfile.centos ## @@ -0,0 +1,70 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #807: Flaky test: Ingress LB Status Testing

2021-12-23 Thread GitBox
tao12345666333 commented on issue #807: URL: https://github.com/apache/apisix-ingress-controller/issues/807#issuecomment-1000415314 No, I cannot reproduce it locally. Occasionally appear in GitHub Action. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #810: bug: service not found,and then I edited it and it still kept reporting errors.

2021-12-23 Thread GitBox
tao12345666333 commented on issue #810: URL: https://github.com/apache/apisix-ingress-controller/issues/810#issuecomment-1000412270 Thanks for report. I will try to reproduce it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
tao12345666333 commented on a change in pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#discussion_r774674065 ## File path: pkg/ingress/gateway.go ## @@ -0,0 +1,156 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
tao12345666333 commented on a change in pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#discussion_r774671912 ## File path: go.mod ## @@ -1,31 +1,25 @@ module github.com/apache/apisix-ingress-controller -go 1.13 +go 1.16 require ( -

  1   2   >