[GitHub] [apisix] xianshun163 commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-28 Thread GitBox
xianshun163 commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002436577 ok, I will try it soon. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-ingress-controller] GhangZh commented on issue #810: bug: service not found,and then I edited it and it still kept reporting errors.

2021-12-28 Thread GitBox
GhangZh commented on issue #810: URL: https://github.com/apache/apisix-ingress-controller/issues/810#issuecomment-1002433033 > This is indeed a bug. When the `ApisixRoute` resource is updated, the old `ApisixRoute` resource object is indeed recorded, so this wrong object always exists.

[GitHub] [apisix-docker] spacewander commented on issue #264: issue: production docker image size doubled

2021-12-28 Thread GitBox
spacewander commented on issue #264: URL: https://github.com/apache/apisix-docker/issues/264#issuecomment-1002428261 The dockerfile of alpine version is https://github.com/apache/apisix-docker/blob/master/alpine/Dockerfile. From 2.10 to 2.11, we switch the base image to

[GitHub] [apisix-docker] donge opened a new issue #264: issue: production docker image size doubled

2021-12-28 Thread GitBox
donge opened a new issue #264: URL: https://github.com/apache/apisix-docker/issues/264 ### Issue description We use alpine image as default, in latest version 2.11. the size increased a lot. I would like to debug it, but I found the Dockerfile is not in this repo. ```

[GitHub] [apisix] spacewander commented on issue #5573: docs: dont found the usage of etcd in discovery.md

2021-12-28 Thread GitBox
spacewander commented on issue #5573: URL: https://github.com/apache/apisix/issues/5573#issuecomment-1002420024 We support etcd as the source of discovery in a different way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander closed issue #5573: docs: dont found the usage of etcd in discovery.md

2021-12-28 Thread GitBox
spacewander closed issue #5573: URL: https://github.com/apache/apisix/issues/5573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander closed issue #3237: feature request: public ECR repo on AWS

2021-12-28 Thread GitBox
spacewander closed issue #3237: URL: https://github.com/apache/apisix/issues/3237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander commented on issue #3237: feature request: public ECR repo on AWS

2021-12-28 Thread GitBox
spacewander commented on issue #3237: URL: https://github.com/apache/apisix/issues/3237#issuecomment-1002419823 It seems this issue hasn't been updated for a long time... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] gaobo0202 opened a new issue #5953: bug: /v1/healthcheck Sometimes no data is returned

2021-12-28 Thread GitBox
gaobo0202 opened a new issue #5953: URL: https://github.com/apache/apisix/issues/5953 ### Issue description we use the / V1 / healthcheck interface of apisix to monitor alarms online, and false alarms will occur. The reason is that the /v1/healthcheck interface sometimes returns no

[GitHub] [apisix-dashboard] dependabot[bot] opened a new pull request #2270: chore(deps): bump actions/setup-node from 2.5.0 to 2.5.1

2021-12-28 Thread GitBox
dependabot[bot] opened a new pull request #2270: URL: https://github.com/apache/apisix-dashboard/pull/2270 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.5.0 to 2.5.1. Release notes Sourced from

[apisix-dashboard] branch dependabot/github_actions/actions/setup-node-2.5.1 created (now bac469d)

2021-12-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-2.5.1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at bac469d chore(deps): bump actions/setup-node from 2.5.0

[GitHub] [apisix] dependabot[bot] opened a new pull request #5952: chore(deps): bump actions/setup-node from 2.5.0 to 2.5.1

2021-12-28 Thread GitBox
dependabot[bot] opened a new pull request #5952: URL: https://github.com/apache/apisix/pull/5952 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.5.0 to 2.5.1. Release notes Sourced from https://github.com/actions/setup-node/releases;>actions/setup-node's

[apisix] branch dependabot/github_actions/actions/setup-node-2.5.1 created (now 8677c5c)

2021-12-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-2.5.1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 8677c5c chore(deps): bump actions/setup-node from 2.5.0 to 2.5.1

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r776153295 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function

[GitHub] [apisix] donge opened a new issue #5951: issue: production docker image size doubled

2021-12-28 Thread GitBox
donge opened a new issue #5951: URL: https://github.com/apache/apisix/issues/5951 ### Issue description We use alpine image as default, in latest version 2.11. the size increased a lot. I would like to debug it, but I found the Dockerfile is not in this repo. ```

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #816: bug: namespace update event will be retried unconditionally even if it was deleted

2021-12-28 Thread GitBox
tao12345666333 commented on issue #816: URL: https://github.com/apache/apisix-ingress-controller/issues/816#issuecomment-1002395079 It is similar to #810 I will fix it in v1.5 version. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard

2021-12-28 Thread GitBox
juzhiyuan commented on issue #1595: URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-1002388618 > > Oh btw, we have a meeting today, welcome to join in if you have time  see [apache/apisix#5721](https://github.com/apache/apisix/discussions/5721) > > So

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2269: feat(route): show route id in list and edit views.

2021-12-28 Thread GitBox
juzhiyuan commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002388013 After checking the codes and screenshots, these tiny changes look good to me, too. (Just adding ID & disabled attribute), I think we can move forward with this PR

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #830: chore(deps): bump actions/setup-node from 2.5.0 to 2.5.1

2021-12-28 Thread GitBox
netlify[bot] edited a comment on pull request #830: URL: https://github.com/apache/apisix-website/pull/830#issuecomment-1002387797 ✔️ Deploy Preview for *apache-apisix* canceled.  Explore the source changes: 7b0d2040f4b2641aa3c144a8ab507278be821602  Inspect the deploy

[GitHub] [apisix-website] netlify[bot] commented on pull request #830: chore(deps): bump actions/setup-node from 2.5.0 to 2.5.1

2021-12-28 Thread GitBox
netlify[bot] commented on pull request #830: URL: https://github.com/apache/apisix-website/pull/830#issuecomment-1002387797  Deploy Preview for *apache-apisix* processing.  Explore the source changes: 7b0d2040f4b2641aa3c144a8ab507278be821602  Inspect the deploy log:

[GitHub] [apisix-website] dependabot[bot] opened a new pull request #830: chore(deps): bump actions/setup-node from 2.5.0 to 2.5.1

2021-12-28 Thread GitBox
dependabot[bot] opened a new pull request #830: URL: https://github.com/apache/apisix-website/pull/830 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.5.0 to 2.5.1. Release notes Sourced from

[apisix-website] branch dependabot/github_actions/actions/setup-node-2.5.1 created (now 7b0d204)

2021-12-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-2.5.1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 7b0d204 chore(deps): bump actions/setup-node from 2.5.0 to

[GitHub] [apisix] tzssangglass commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-28 Thread GitBox
tzssangglass commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002385983 Not sure, haven't tried (I think in log_format as an attribute is the smallest unit of the PATCH operation. It should not be possible to continue the PATCH in the value of

[GitHub] [apisix] leslie-tsang edited a comment on issue #5573: docs: dont found the usage of etcd in discovery.md

2021-12-28 Thread GitBox
leslie-tsang edited a comment on issue #5573: URL: https://github.com/apache/apisix/issues/5573#issuecomment-1002381789 > Just have a discussion with @bzp2010, we don't support ETCD as Service Discovery yet 樂 @leslie-tsang could you please have a confirmation?  ~~AFAIK, APISIX

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #87: release 0.2.0 task list

2021-12-28 Thread GitBox
tzssangglass commented on issue #87: URL: https://github.com/apache/apisix-java-plugin-runner/issues/87#issuecomment-1002385192 This week or next week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat(route): show route id in list and edit views.

2021-12-28 Thread GitBox
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002384301 > LGTM, Hi @mangoGoForward, as we don't have a preview environment at the moment, it would be nice if we could post a picture up ~ If you have any questions

[GitHub] [apisix] spacewander merged pull request #5941: feat: support registering custom variable

2021-12-28 Thread GitBox
spacewander merged pull request #5941: URL: https://github.com/apache/apisix/pull/5941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander closed issue #5634: request help: support get the key from function in limit-* plugins

2021-12-28 Thread GitBox
spacewander closed issue #5634: URL: https://github.com/apache/apisix/issues/5634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated (e9cea44 -> 0a8de20)

2021-12-28 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from e9cea44 feat: support to use path parameter with plugin's control api (#5934) add 0a8de20 feat: support

[GitHub] [apisix] leslie-tsang commented on issue #5573: docs: dont found the usage of etcd in discovery.md

2021-12-28 Thread GitBox
leslie-tsang commented on issue #5573: URL: https://github.com/apache/apisix/issues/5573#issuecomment-1002381789 > Just have a discussion with @bzp2010, we don't support ETCD as Service Discovery yet 樂 @leslie-tsang could you please have a confirmation?  AFAIK, APISIX don't support

[GitHub] [apisix-dashboard] zaunist commented on issue #2266: WebSocket 频繁自动刷新导致页面无法正常

2021-12-28 Thread GitBox
zaunist commented on issue #2266: URL: https://github.com/apache/apisix-dashboard/issues/2266#issuecomment-1002379835 It looks like the websocket connect is failed. cc @bzp2010 , do you have time to look at this issue ? -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix-java-plugin-runner] dingliang5218 commented on issue #87: release 0.2.0 task list

2021-12-28 Thread GitBox
dingliang5218 commented on issue #87: URL: https://github.com/apache/apisix-java-plugin-runner/issues/87#issuecomment-1002379614 Hi, when will release 0.2.0 done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] waringid edited a comment on issue #2266: WebSocket 频繁自动刷新导致页面无法正常

2021-12-28 Thread GitBox
waringid edited a comment on issue #2266: URL: https://github.com/apache/apisix-dashboard/issues/2266#issuecomment-1002375931 1、Route config: { "uri": "/*", "name": "route-nas-test", "methods": [ "GET", "POST", "PUT", "DELETE", "PATCH",

[GitHub] [apisix-dashboard] waringid commented on issue #2266: WebSocket 频繁自动刷新导致页面无法正常

2021-12-28 Thread GitBox
waringid commented on issue #2266: URL: https://github.com/apache/apisix-dashboard/issues/2266#issuecomment-1002375931 1、Route config: { "uri": "/*", "name": "route-nas-test", "methods": [ "GET", "POST", "PUT", "DELETE", "PATCH",

[GitHub] [apisix] leslie-tsang commented on issue #5946: request help: deploy apisix failed on K8s

2021-12-28 Thread GitBox
leslie-tsang commented on issue #5946: URL: https://github.com/apache/apisix/issues/5946#issuecomment-1002374522 Hello there, change `enable_ipv6: true` to `enable_ipv6: false` may help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] foreveryang321 closed issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.

2021-12-28 Thread GitBox
foreveryang321 closed issue #2268: URL: https://github.com/apache/apisix-dashboard/issues/2268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-dashboard] foreveryang321 commented on issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.

2021-12-28 Thread GitBox
foreveryang321 commented on issue #2268: URL: https://github.com/apache/apisix-dashboard/issues/2268#issuecomment-1002374066 thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] zaunist commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
zaunist commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002372404 /LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] zaunist commented on issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.

2021-12-28 Thread GitBox
zaunist commented on issue #2268: URL: https://github.com/apache/apisix-dashboard/issues/2268#issuecomment-1002371706 Hi, @foreveryang321. If you want rewrite `header`, you need configure `response-rewrite` like this: ``` "headers": { "Server": "baidu", }

[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002371228 The screenshot like below: List page ![image](https://user-images.githubusercontent.com/35127166/147623016-e1eef54d-77fd-4373-9403-b0cfaa4327fb.png)

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
guoqqqi commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002369992 LGTM, Hi @mangoGoForward, as we don't have a preview environment at the moment, it would be nice if we could post a picture up ~ If you have any questions about

[GitHub] [apisix] spacewander commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
spacewander commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r776132041 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function

[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002369416 > Hi @mangoGoForward, those changes LGTM, could you please add some test cases for this PR? Thanks for your suggestion. -- This is an automated

[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002369228 > just add the test cases as @juzhiyuan said, thanks @mangoGoForward Ok. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] zaunist commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
zaunist commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002368922 Hi,@mangoGoForward. Can you take some screenshoot for this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] spacewander commented on a change in pull request #5941: feat: support registering custom variable

2021-12-28 Thread GitBox
spacewander commented on a change in pull request #5941: URL: https://github.com/apache/apisix/pull/5941#discussion_r776131295 ## File path: apisix/core/ctx.lua ## @@ -215,11 +215,18 @@ do key = sub_str(key, 9) val = get_parsed_graphql()[key]

[GitHub] [apisix-dashboard] mangoGoForward commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard

2021-12-28 Thread GitBox
mangoGoForward commented on issue #1595: URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-1002367848 > Oh btw, we have a meeting today, welcome to join in if you have time  see [apache/apisix#5721](https://github.com/apache/apisix/discussions/5721) So

[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-28 Thread GitBox
jagerzhang commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002367080 > Yes, it's clearly now :) (Just like PATCH and PUT methods ) > > I found the default configuration here, see

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
juzhiyuan commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002366881 also cc @guoqqqi to have a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.

2021-12-28 Thread GitBox
juzhiyuan commented on issue #2268: URL: https://github.com/apache/apisix-dashboard/issues/2268#issuecomment-1002366605 cc @Baoyuantop to have a check  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-ingress-controller] tokers opened a new issue #816: bug: namespace update event will be retried unconditionally even if it was deleted

2021-12-28 Thread GitBox
tokers opened a new issue #816: URL: https://github.com/apache/apisix-ingress-controller/issues/816 ### Issue description Namespace events will be retried endlessly even if it's expired, for instance, an update event should be mark as expired if a new delete event is handled.

[GitHub] [apisix-dashboard] mangoGoForward commented on pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
mangoGoForward commented on pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269#issuecomment-1002366410 Please have a look. @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] juzhiyuan commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002366148 Yes, it's clearly now :) (Just like PATCH and PUT methods ) I found the default configuration here, see

[GitHub] [apisix-dashboard] mangoGoForward opened a new pull request #2269: feat: show route id in list and edit views.

2021-12-28 Thread GitBox
mangoGoForward opened a new pull request #2269: URL: https://github.com/apache/apisix-dashboard/pull/2269 Signed-off-by: mango Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ]

[apisix-docker] branch master updated: fix: rollback the docker image used in chaos test (#263)

2021-12-28 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new 5d3c4c6 fix: rollback the docker

[GitHub] [apisix-docker] spacewander merged pull request #263: fix: rollback the docker image used in chaos test

2021-12-28 Thread GitBox
spacewander merged pull request #263: URL: https://github.com/apache/apisix-docker/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander opened a new pull request #5948: docs: avoid newline in the middle of Chinese sentences

2021-12-28 Thread GitBox
spacewander opened a new pull request #5948: URL: https://github.com/apache/apisix/pull/5948 Fix #5842 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this

[GitHub] [apisix] juzhiyuan commented on issue #5573: docs: dont found the usage of etcd in discovery.md

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5573: URL: https://github.com/apache/apisix/issues/5573#issuecomment-1002364849 Just have a discussion with @bzp2010, we don't support ETCD as Service Discovery yet 樂 @leslie-tsang could you please have a confirmation?  -- This is an automated message from

[GitHub] [apisix] tzssangglass commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5947: URL: https://github.com/apache/apisix/pull/5947#discussion_r776128652 ## File path: apisix/plugins/jwt-auth.lua ## @@ -344,8 +341,8 @@ end function _M.rewrite(conf, ctx) local jwt_token, err = fetch_jwt_token(ctx)

[GitHub] [apisix] jagerzhang edited a comment on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-28 Thread GitBox
jagerzhang edited a comment on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002364234 > Hi @jagerzhang, AFAIK, you could follow this step to configure kafka-logger plugin: > > 1. (optional) `PUT /plugin_metedata` to use your custom `log_format`

[GitHub] [apisix] jagerzhang commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-28 Thread GitBox
jagerzhang commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002364234 > Hi @jagerzhang, AFAIK, you could follow this step to configure kafka-logger plugin: > > 1. (optional) `PUT /plugin_metedata` to use your custom `log_format`

[GitHub] [apisix] tzssangglass commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5947: URL: https://github.com/apache/apisix/pull/5947#discussion_r776128336 ## File path: apisix/plugins/jwt-auth.lua ## @@ -344,8 +341,8 @@ end function _M.rewrite(conf, ctx) local jwt_token, err = fetch_jwt_token(ctx)

[GitHub] [apisix] juzhiyuan commented on issue #5915: request help: logger plugins supports limit size of request/response body

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5915: URL: https://github.com/apache/apisix/issues/5915#issuecomment-1002363371 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] juzhiyuan commented on issue #5910: request help: can the log-plugins supports to logging upstream_latency and apisix_latency?

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5910: URL: https://github.com/apache/apisix/issues/5910#issuecomment-1002363080 Hi @jagerzhang, AFAIK, you could follow this step to configure kafka-logger plugin: 1. (optional) `PUT /plugin_metedata` to use your custom `log_format` configuration for

[GitHub] [apisix] spacewander closed issue #5882: feat: support to use path parameter with plugin's control api

2021-12-28 Thread GitBox
spacewander closed issue #5882: URL: https://github.com/apache/apisix/issues/5882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander merged pull request #5934: feat: support to use path parameter with plugin's control api

2021-12-28 Thread GitBox
spacewander merged pull request #5934: URL: https://github.com/apache/apisix/pull/5934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated (eb8362c -> e9cea44)

2021-12-28 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from eb8362c docs: improved `plugin-develop` doc (#5933) add e9cea44 feat: support to use path parameter with

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2262: Apisix dashboard service's health check does not take effect

2021-12-28 Thread GitBox
Baoyuantop commented on issue #2262: URL: https://github.com/apache/apisix-dashboard/issues/2262#issuecomment-1002362705 OK, I'll try to reproduce it locally and look forward to your results after using the Admin API. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] juzhiyuan edited a comment on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm

2021-12-28 Thread GitBox
juzhiyuan edited a comment on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1002362286 > Oops. If I am correct, our helm chart doesn't expose the ext-plugin field, we may enhance the helm chart. Hi @tokers, do we need to set this as Good first issue or

[GitHub] [apisix] juzhiyuan commented on issue #5901: request help: How to add ext-plugin in config.yaml ,since apisix installed by helm

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5901: URL: https://github.com/apache/apisix/issues/5901#issuecomment-1002362286 > Oops. If I am correct, our helm chart doesn't expose the ext-plugin field, we may enhance the helm chart. Hi @tokers, do we need to set this as Good first issue? --

[GitHub] [apisix-dashboard] foreveryang321 opened a new issue #2268: Configure response-rewrite using Apisix Dashboard does not take effect.

2021-12-28 Thread GitBox
foreveryang321 opened a new issue #2268: URL: https://github.com/apache/apisix-dashboard/issues/2268 ### Issue description Configure `response-rewrite` using `Apisix Dashboard` does not take effect. ### Expected behavior the response header is `Server: xx/x`, not

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
leslie-tsang commented on a change in pull request #5947: URL: https://github.com/apache/apisix/pull/5947#discussion_r776126818 ## File path: apisix/plugins/jwt-auth.lua ## @@ -344,8 +341,8 @@ end function _M.rewrite(conf, ctx) local jwt_token, err = fetch_jwt_token(ctx)

[GitHub] [apisix] tokers commented on a change in pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
tokers commented on a change in pull request #5947: URL: https://github.com/apache/apisix/pull/5947#discussion_r776125596 ## File path: apisix/plugins/jwt-auth.lua ## @@ -344,8 +341,8 @@ end function _M.rewrite(conf, ctx) local jwt_token, err = fetch_jwt_token(ctx)

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5941: feat: support registering custom variable

2021-12-28 Thread GitBox
leslie-tsang commented on a change in pull request #5941: URL: https://github.com/apache/apisix/pull/5941#discussion_r776125463 ## File path: apisix/core/ctx.lua ## @@ -215,11 +215,18 @@ do key = sub_str(key, 9) val = get_parsed_graphql()[key]

[GitHub] [apisix] tzssangglass edited a comment on pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
tzssangglass edited a comment on pull request #5947: URL: https://github.com/apache/apisix/pull/5947#issuecomment-1002354410 > @tzssangglass Could you describe the reason for this or add the corresponding issue link? ok, inspired by review this PR is the comments seen:

[GitHub] [apisix] tzssangglass commented on pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
tzssangglass commented on pull request #5947: URL: https://github.com/apache/apisix/pull/5947#issuecomment-1002354410 > @tzssangglass Could you describe the reason for this or add the corresponding issue link? ok, inspired by review this PR is the comments seen:

[GitHub] [apisix] juzhiyuan commented on issue #3237: feature request: public ECR repo on AWS

2021-12-28 Thread GitBox
juzhiyuan commented on issue #3237: URL: https://github.com/apache/apisix/issues/3237#issuecomment-1002352504 Hi @spacewander, do we need to support the ECR repo as Pahud suggests?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] juzhiyuan commented on pull request #5941: feat: support registering custom variable

2021-12-28 Thread GitBox
juzhiyuan commented on pull request #5941: URL: https://github.com/apache/apisix/pull/5941#issuecomment-1002351478 Hi @leslie-tsang, could you please have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] juzhiyuan commented on issue #5938: docs: How to understand the internal working mechanism of apisix in depth

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5938: URL: https://github.com/apache/apisix/issues/5938#issuecomment-1002351313 Maybe we could keep this issue open to tracking this improvement? @alex8224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] juzhiyuan commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002350865 @xianshun163 kindly let us know if you encounter problems when submitting PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] tokers commented on pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of resty.cookie

2021-12-28 Thread GitBox
tokers commented on pull request #5947: URL: https://github.com/apache/apisix/pull/5947#issuecomment-1002350164 @tzssangglass Could you describe the reason for this or add the corresponding issue link? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] juzhiyuan commented on pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
juzhiyuan commented on pull request #5874: URL: https://github.com/apache/apisix/pull/5874#issuecomment-1002350048 cc @Baoyuantop to have a review  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy

2021-12-28 Thread GitBox
juzhiyuan commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r776118185 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) --

[GitHub] [apisix] juzhiyuan commented on issue #5942: request help: How to build APISIX-OpenResty when I have deploy apisix by the source code way

2021-12-28 Thread GitBox
juzhiyuan commented on issue #5942: URL: https://github.com/apache/apisix/issues/5942#issuecomment-1002347452 ok, I'm going to close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] juzhiyuan closed issue #5942: request help: How to build APISIX-OpenResty when I have deploy apisix by the source code way

2021-12-28 Thread GitBox
juzhiyuan closed issue #5942: URL: https://github.com/apache/apisix/issues/5942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] tzssangglass commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775962466 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) --

[GitHub] [apisix] tzssangglass commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775960928 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function

[GitHub] [apisix-dashboard] vickychen2022 commented on issue #2262: Apisix dashboard service's health check does not take effect

2021-12-28 Thread GitBox
vickychen2022 commented on issue #2262: URL: https://github.com/apache/apisix-dashboard/issues/2262#issuecomment-1002159374 Hi @Baoyuantop , sorry for late reply! I haven't used admin api to create resources, I created the upstream and service by dashboard. Actually the bug is easy to

[GitHub] [apisix] tzssangglass commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r775959656 ## File path: apisix/plugins/csrf.lua ## @@ -0,0 +1,170 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] danielkocot commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy

2021-12-28 Thread GitBox
danielkocot commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r775958696 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) --

[GitHub] [apisix] tzssangglass commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r775946413 ## File path: apisix/plugins/csrf.lua ## @@ -0,0 +1,170 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] tzssangglass opened a new pull request #5947: chore(jwt-auth): get JWT by ctx.var.cookie_jwt instead of use resty.c…

2021-12-28 Thread GitBox
tzssangglass opened a new pull request #5947: URL: https://github.com/apache/apisix/pull/5947 …ookie Signed-off-by: tzssangglass ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #815: feat: refactor ApisixPluginConfig and add e2e cases

2021-12-28 Thread GitBox
codecov-commenter edited a comment on pull request #815: URL: https://github.com/apache/apisix-ingress-controller/pull/815#issuecomment-1001920990 #

[GitHub] [apisix] leslie-tsang commented on issue #5942: request help: How to build APISIX-OpenResty when I have deploy apisix by the source code way

2021-12-28 Thread GitBox
leslie-tsang commented on issue #5942: URL: https://github.com/apache/apisix/issues/5942#issuecomment-1002150477 @juzhiyuan Consider solved. Feel free to reopen it if need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] tzssangglass commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r775945667 ## File path: docs/zh/latest/plugins/csrf.md ## @@ -0,0 +1,127 @@ +--- +title: csrf +--- + + + +## 目录 + +- [**简介**](#简介) +- [**属性**](#属性) +-

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775929570 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function

[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-28 Thread GitBox
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-1002137600 here: https://apisix.apache.org/docs/general/contributor-guide/ If you have questions, you can call me in this issue. -- This is an automated message from the Apache

[GitHub] [apisix] tzssangglass commented on a change in pull request #5923: feat: support custom package, headers and body in openwhisk plugin

2021-12-28 Thread GitBox
tzssangglass commented on a change in pull request #5923: URL: https://github.com/apache/apisix/pull/5923#discussion_r775936726 ## File path: apisix/plugins/openwhisk.lua ## @@ -104,8 +108,31 @@ function _M.access(conf, ctx) return 503 end +-- parse

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775929570 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function

[GitHub] [apisix] bzp2010 commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-28 Thread GitBox
bzp2010 commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r775929570 ## File path: apisix/plugins/opa/helper.lua ## @@ -45,16 +48,68 @@ local function build_http_request(conf, ctx) end -function

  1   2   >