[GitHub] [apisix] hf400159 opened a new pull request #6284: docs: added cpanm installation commands and remove $ sign

2022-02-09 Thread GitBox
hf400159 opened a new pull request #6284: URL: https://github.com/apache/apisix/pull/6284 Modify the en and en docs. The last PR only modified the EN docs. Add the cpanm installation command. Modified etcd startup command to add log output parameters. Remove the "$" sign before

[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-09 Thread GitBox
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1034582381 we have `set_userinfo_header` attributes in openid-connect plugin, see: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/openid-connect.md#attributes

[GitHub] [apisix] zaunist commented on pull request #6202: feat: use keepalive in server-info plugin

2022-02-09 Thread GitBox
zaunist commented on pull request #6202: URL: https://github.com/apache/apisix/pull/6202#issuecomment-1034581327 @bisakhmondal @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] leslie-tsang commented on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
leslie-tsang commented on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034579729 Hello there, Please try the changes below to pass the schema check. ```patch - name: kafka-logger enable: true config: - broker_list:

[GitHub] [apisix] devops-utils-tools removed a comment on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools removed a comment on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034573312 ``` apiVersion: apisix.apache.org/v2beta2 kind: ApisixRoute metadata: name: method-route spec: http: - name: method backends:

[GitHub] [apisix] devops-utils-tools commented on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools commented on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034573312 ``` apiVersion: apisix.apache.org/v2beta2 kind: ApisixRoute metadata: name: method-route spec: http: - name: method backends: -

[GitHub] [apisix] devops-utils-tools removed a comment on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools removed a comment on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034573008 ` apiVersion: apisix.apache.org/v2beta2 kind: ApisixRoute metadata: name: method-route spec: http: - name: method backends:

[GitHub] [apisix] devops-utils-tools commented on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools commented on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034573008 ` apiVersion: apisix.apache.org/v2beta2 kind: ApisixRoute metadata: name: method-route spec: http: - name: method backends: -

[GitHub] [apisix] devops-utils-tools removed a comment on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools removed a comment on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034572823 ` apiVersion: apisix.apache.org/v2beta2 kind: ApisixRoute metadata: name: method-route spec: http: - name: method backends:

[GitHub] [apisix] devops-utils-tools commented on issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools commented on issue #6283: URL: https://github.com/apache/apisix/issues/6283#issuecomment-1034572823 ` apiVersion: apisix.apache.org/v2beta2 kind: ApisixRoute metadata: name: method-route spec: http: - name: method backends: -

[GitHub] [apisix] devops-utils-tools opened a new issue #6283: bug: plugin kafka-logger configuration error

2022-02-09 Thread GitBox
devops-utils-tools opened a new issue #6283: URL: https://github.com/apache/apisix/issues/6283 ### Issue description 2022-02-10T15:14:39+08:00error apisix/route.go:161 failed to create route: unexpected status code 400; error message: {"error_msg":"failed to check the

[GitHub] [apisix] tzssangglass opened a new pull request #6282: test: add test case for nacos service de-duplicate

2022-02-09 Thread GitBox
tzssangglass opened a new pull request #6282: URL: https://github.com/apache/apisix/pull/6282 the test cases of https://github.com/apache/apisix/pull/6247 Signed-off-by: tzssangglass ### What this PR does / why we need it: ### Pre-submission checklist:

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #813: request help: 采用CRD方式,如何通过ApisixRoute配置转发到三方ip:端口服务

2022-02-09 Thread GitBox
tao12345666333 commented on issue #813: URL: https://github.com/apache/apisix-ingress-controller/issues/813#issuecomment-1034570972 @purekeeper sorry for delay. I've been fixing other high priority bugs recently and haven't had time to check it yet. > @tao12345666333 I

[GitHub] [apisix-dashboard] zaunist commented on pull request #2308: chore : update to github.com/golang-jwt/jwt/v4

2022-02-09 Thread GitBox
zaunist commented on pull request #2308: URL: https://github.com/apache/apisix-dashboard/pull/2308#issuecomment-1034567450 cc @bzp2010. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] purekeeper commented on issue #813: request help: 采用CRD方式,如何通过ApisixRoute配置转发到三方ip:端口服务

2022-02-09 Thread GitBox
purekeeper commented on issue #813: URL: https://github.com/apache/apisix-ingress-controller/issues/813#issuecomment-1034557015 @tao12345666333I read your code and found ingress-controller does not support extenel name -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix-go-plugin-runner] Belyenochi commented on issue #34: request help: Introduce context to run plugin

2022-02-09 Thread GitBox
Belyenochi commented on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1034548435 > Thanks for your design. My original thought is simpler: we can add a method in the Request to return a Context. It works like the one from the standard library:

[GitHub] [apisix] zaunist commented on pull request #6202: feat: use keepalive in server-info plugin

2022-02-09 Thread GitBox
zaunist commented on pull request #6202: URL: https://github.com/apache/apisix/pull/6202#issuecomment-1034548032 cc @tzssangglass @shuaijinchao. Please take a look, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
zhendongcmss commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r80776 ## File path: apisix/plugins/clickhouse-logger.lua ## @@ -0,0 +1,179 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-dashboard] dependabot[bot] opened a new pull request #2311: chore(deps): bump actions/setup-go from 2.1.5 to 2.2.0

2022-02-09 Thread GitBox
dependabot[bot] opened a new pull request #2311: URL: https://github.com/apache/apisix-dashboard/pull/2311 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.5 to 2.2.0. Release notes Sourced from

[apisix-dashboard] branch dependabot/github_actions/actions/setup-go-2.2.0 created (now acdbf45)

2022-02-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-go-2.2.0 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at acdbf45 chore(deps): bump actions/setup-go from 2.1.5 to

[GitHub] [apisix] leslie-tsang opened a new pull request #6281: chore: compresses the redis lua script in limit-count

2022-02-09 Thread GitBox
leslie-tsang opened a new pull request #6281: URL: https://github.com/apache/apisix/pull/6281 ### What this PR does / why we need it: This PR compresses the `limit-count` plugin's redis lua script. This will cut the cost of network traffic by about 15%. ###

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
zhendongcmss commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r803322743 ## File path: t/plugin/clickhouse-logger.t ## @@ -0,0 +1,227 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
zhendongcmss commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r803322204 ## File path: t/plugin/clickhouse-logger.t ## @@ -0,0 +1,227 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
zhendongcmss commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r803321789 ## File path: t/plugin/clickhouse-logger.t ## @@ -0,0 +1,227 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] tao12345666333 commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034518899 Submitted a PR to fix this description #6280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
zhendongcmss commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r803320498 ## File path: docs/en/latest/plugins/clickhouse-logger.md ## @@ -0,0 +1,148 @@ +--- +title: clickhouse-logger +--- + + + +## Summary + +-

[GitHub] [apisix] tao12345666333 opened a new pull request #6280: docs: clearer description for Prometheus plugin

2022-02-09 Thread GitBox
tao12345666333 opened a new pull request #6280: URL: https://github.com/apache/apisix/pull/6280 Signed-off-by: Jintao Zhang ### What this PR does / why we need it: closes: https://github.com/apache/apisix/issues/6276 ### Pre-submission checklist: * [ ]

[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John edited a comment on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-103144 After discussion and review, it was found that the cause of this issue was that we did not support the application/json content type. I will mainly solve this issue in

[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John edited a comment on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-103144 After discussion and review, it was found that the cause of this issue was that we did not support the application/json content type. I will mainly solve this issue in

[GitHub] [apisix] bisakhmondal commented on a change in pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping

2022-02-09 Thread GitBox
bisakhmondal commented on a change in pull request #6228: URL: https://github.com/apache/apisix/pull/6228#discussion_r803310088 ## File path: apisix/plugins/loggly.lua ## @@ -85,6 +86,17 @@ local schema = { type = "boolean", default = true },

[GitHub] [apisix] dependabot[bot] opened a new pull request #6279: build(deps): bump actions/setup-go from 2.1.5 to 2.2.0

2022-02-09 Thread GitBox
dependabot[bot] opened a new pull request #6279: URL: https://github.com/apache/apisix/pull/6279 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.5 to 2.2.0. Release notes Sourced from https://github.com/actions/setup-go/releases;>actions/setup-go's

[apisix] branch dependabot/github_actions/actions/setup-go-2.2.0 created (now dc5c61d)

2022-02-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-go-2.2.0 in repository https://gitbox.apache.org/repos/asf/apisix.git. at dc5c61d build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 No

[GitHub] [apisix] spacewander commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
spacewander commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034495761 > They are a logical AND relationship. > > Need to configure both `enable_export_server: false` and `public_api` plugin. Yes > @spacewander thanks

[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John edited a comment on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-1034477830 In fact, these are the two new features (support 'json' & 'GET') that we're going to release next. As for the launch time, I personally expect it to be completed within

[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John edited a comment on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-1034477830 In fact, these are the two new features (support 'json' & 'GET') that we're going to release next. As for the launch time, I personally expect it to be completed within

[GitHub] [apisix] Chever-John edited a comment on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John edited a comment on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-1034477830 In fact, these are the two new features (support 'json' & 'GET') that we're going to introduce next. As for the launch time, I personally expect it to be completed

[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John commented on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-1034477830 In fact, these are the two new features (support 'json' & 'GET') that we're going to introduce next. As for the launch time, I personally expect it to be completed within a

[GitHub] [apisix] Gary-Airwallex commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Gary-Airwallex commented on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-1034473794 @Chever-John May I also suggest that the `parse_graphql` function should handle the case of GET requests? https://graphql.org/learn/serving-over-http/#get-request

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #227: feat(apisix): expose stream proxy tcp/udp ports

2022-02-09 Thread GitBox
tao12345666333 merged pull request #227: URL: https://github.com/apache/apisix-helm-chart/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[apisix-helm-chart] branch master updated: feat(apisix): expose stream proxy tcp/udp ports (#227)

2022-02-09 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 3d9afdd feat(apisix): expose

[GitHub] [apisix] tzssangglass commented on pull request #6247: Add the de duplication function of Nacos service discovery

2022-02-09 Thread GitBox
tzssangglass commented on pull request #6247: URL: https://github.com/apache/apisix/pull/6247#issuecomment-1034469886 hi @xianshun163 , I have another fix idea to discuss with you. Before adding a new service to services, we can do a de-duplication, we can add de_duplication

[GitHub] [apisix] SkyeYoung opened a new pull request #6278: docs: improve consul_kv.md

2022-02-09 Thread GitBox
SkyeYoung opened a new pull request #6278: URL: https://github.com/apache/apisix/pull/6278 ### What this PR does / why we need it: - Use the word "Consul KV" in the official document of Consul to replace "consul key value" - Adjust the expression of some text ###

[GitHub] [apisix] spacewander commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
spacewander commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r803271948 ## File path: t/plugin/clickhouse-logger.t ## @@ -0,0 +1,227 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] spacewander merged pull request #6277: ci: enforce request review on the final state

2022-02-09 Thread GitBox
spacewander merged pull request #6277: URL: https://github.com/apache/apisix/pull/6277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated: ci: enforce request review on the final state (#6277)

2022-02-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 06c5193 ci: enforce request review on the

[GitHub] [apisix] spacewander opened a new pull request #6277: ci: enforce request review on the final state

2022-02-09 Thread GitBox
spacewander opened a new pull request #6277: URL: https://github.com/apache/apisix/pull/6277 In https://github.com/apache/apisix/pull/5940#discussion_r802593858, during solving the merge conflict, a bug which is fixed in https://github.com/apache/apisix/pull/6204 is reintroduced.

[GitHub] [apisix] Chever-John commented on issue #6266: bug: ctx.lua#59 parse_graphql(ctx)

2022-02-09 Thread GitBox
Chever-John commented on issue #6266: URL: https://github.com/apache/apisix/issues/6266#issuecomment-103144 After discussion and review, it was found that the cause of this issue was that we did not use the application/json content type. I will mainly solve this issue in the next 3

[GitHub] [apisix] tao12345666333 commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034431045 I have tried three ways of configuration and they all work fine ``` { "count": 3, "node": { "dir": true, "nodes": [ {

[GitHub] [apisix-website] oil-oil opened a new issue #873: The 2.12.1 version source package is missing

2022-02-09 Thread GitBox
oil-oil opened a new issue #873: URL: https://github.com/apache/apisix-website/issues/873 Follow the operations in the documentation and find that the source package of version 2.12.1 is missing

[GitHub] [apisix] tao12345666333 commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034426253 They are a logical AND relationship. Need to configure both `enable_export_server: false` and `public_api` plugin. -- This is an automated message from the Apache Git

[GitHub] [apisix-website] zaunist commented on pull request #870: chore: add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
zaunist commented on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1034425318 It look like need to sync master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #870: chore: add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
Baoyuantop commented on a change in pull request #870: URL: https://github.com/apache/apisix-website/pull/870#discussion_r803246891 ## File path: website/config/downloads.js ## @@ -9,6 +9,7 @@ module.exports = [ githubBranch: "master", downloadPath:

[GitHub] [apisix] yaule commented on pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-09 Thread GitBox
yaule commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1034421680 > https://grafana.com/docs/grafana/latest/auth/auth-proxy/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
netlify[bot] edited a comment on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360 ✔️ Deploy Preview for *apache-apisix* ready!  Explore the source changes: 138685d28d83d0e3887efecbaf33f9df23378bc9  Inspect the deploy log:

[GitHub] [apisix] tao12345666333 commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034412793 let me try to use `public_api` plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] tao12345666333 edited a comment on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 edited a comment on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034411255 @spacewander thanks for your reply. Does that mean these descriptions in the documentation are wrong? `enable_export_server=false` no longer have any real value?

[GitHub] [apisix] spacewander commented on a change in pull request #6242: fix(redirect-plugin): redirection loop behind a proxy or lb

2022-02-09 Thread GitBox
spacewander commented on a change in pull request #6242: URL: https://github.com/apache/apisix/pull/6242#discussion_r803240917 ## File path: t/plugin/redirect.t ## @@ -1000,3 +1000,58 @@ Location: /hello?type=string=json --- error_code: 302 --- no_error_log [error] + + +

[GitHub] [apisix] tao12345666333 commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034411255 @spacewander thanks for your reply. Does that mean these descriptions in the documentation are wrong? ``` If you still want to expose the metrics via the data

[GitHub] [apisix] spacewander merged pull request #6275: docs: correct the 'article' to 'documentation' in Getting started.

2022-02-09 Thread GitBox
spacewander merged pull request #6275: URL: https://github.com/apache/apisix/pull/6275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-website] spacewander closed issue #866: Correct choice of words in Getting started.

2022-02-09 Thread GitBox
spacewander closed issue #866: URL: https://github.com/apache/apisix-website/issues/866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated (862c604 -> 92bbde9)

2022-02-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 862c604 docs: add forward-auth zh document (#6267) add 92bbde9 docs: correct the 'article' to

[apisix] branch master updated: docs: add forward-auth zh document (#6267)

2022-02-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 862c604 docs: add forward-auth zh

[GitHub] [apisix] spacewander merged pull request #6267: docs: add forward-auth zh document

2022-02-09 Thread GitBox
spacewander merged pull request #6267: URL: https://github.com/apache/apisix/pull/6267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #870: chore: add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
netlify[bot] edited a comment on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1032163360  Deploy Preview for *apache-apisix* processing.  Explore the source changes: 138685d28d83d0e3887efecbaf33f9df23378bc9  Inspect the deploy

[GitHub] [apisix] spacewander commented on a change in pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping

2022-02-09 Thread GitBox
spacewander commented on a change in pull request #6228: URL: https://github.com/apache/apisix/pull/6228#discussion_r803238364 ## File path: apisix/plugins/loggly.lua ## @@ -85,6 +86,17 @@ local schema = { type = "boolean", default = true },

[GitHub] [apisix] spacewander commented on a change in pull request #6228: feat(loggly): support HTTP response code to SYSLOG severity mapping

2022-02-09 Thread GitBox
spacewander commented on a change in pull request #6228: URL: https://github.com/apache/apisix/pull/6228#discussion_r803238141 ## File path: apisix/plugins/loggly.lua ## @@ -145,6 +157,18 @@ function _M.check_schema(conf, schema_type) if not ok then return nil,

[GitHub] [apisix] spacewander commented on a change in pull request #6267: docs: add forward-auth zh document

2022-02-09 Thread GitBox
spacewander commented on a change in pull request #6267: URL: https://github.com/apache/apisix/pull/6267#discussion_r803235618 ## File path: docs/zh/latest/plugins/forward-auth.md ## @@ -0,0 +1,140 @@ +--- +title: forward-auth +--- + + + +## 目录 + +- [**名字**](#名字) +-

[GitHub] [apisix] spacewander merged pull request #6269: docs: added installation mode for LTS version

2022-02-09 Thread GitBox
spacewander merged pull request #6269: URL: https://github.com/apache/apisix/pull/6269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[apisix] branch master updated: docs: added installation mode for LTS version (#6269)

2022-02-09 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 04a4cf1 docs: added installation mode for

[GitHub] [apisix] spacewander commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
spacewander commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034398011 This is caused by the break change: https://github.com/apache/apisix/pull/6196 The change is introduced to reduce attack vector. Let's add a new route with public-api

[GitHub] [apisix] tzssangglass commented on pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-09 Thread GitBox
tzssangglass commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1034395905 Can you show the relevant docs or issue, I don't understand its usefulness. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] tzssangglass commented on a change in pull request #6136: ci: support for generating flame graph

2022-02-09 Thread GitBox
tzssangglass commented on a change in pull request #6136: URL: https://github.com/apache/apisix/pull/6136#discussion_r803229254 ## File path: .github/workflows/performance.yml ## @@ -0,0 +1,56 @@ +name: Performance Test + +on: + pull_request: +branches: [master,

[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #34: request help: Introduce context to run plugin

2022-02-09 Thread GitBox
spacewander commented on issue #34: URL: https://github.com/apache/apisix-go-plugin-runner/issues/34#issuecomment-1034391781 Thanks for your design. My original thought is simpler: we can add a method in the Request to return a Context. It works like the one from the standard library:

[GitHub] [apisix-website] SkyeYoung commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-09 Thread GitBox
SkyeYoung commented on issue #871: URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1034389287 @1502shivam-singh Sorry, my English is very poor. Maybe my description misled you. I mean, first open the home page in a tab, and open the document navigation page in

[GitHub] [apisix-website] Baoyuantop commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-09 Thread GitBox
Baoyuantop commented on issue #871: URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1034382051 OK, I found the point @1502shivam-singh. Following exactly the steps in the gif provided by SkyeYoung, the site's homepage ended up in the dark mode. -- This is

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #845: fix: aviod create pluginconfig in the tranlsation of route (#836)

2022-02-09 Thread GitBox
tao12345666333 commented on pull request #845: URL: https://github.com/apache/apisix-ingress-controller/pull/845#issuecomment-1034350042 Wait for #859 to fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #859: fix: ApisixClusterConfig e2e test case

2022-02-09 Thread GitBox
tao12345666333 commented on a change in pull request #859: URL: https://github.com/apache/apisix-ingress-controller/pull/859#discussion_r803200015 ## File path: Makefile ## @@ -87,8 +87,8 @@ endif .PHONY: push-images-to-kind push-images-to-kind: kind-up ifeq

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #859: fix: ApisixClusterConfig e2e test case

2022-02-09 Thread GitBox
tao12345666333 opened a new pull request #859: URL: https://github.com/apache/apisix-ingress-controller/pull/859 * pin the image of APISIX to stable version * using the new plugin list API * fix ApisixClusterConfig status logic Signed-off-by: Jintao Zhang ###

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #857: e2e test: ApisixClusterConfig enable prometheus failed

2022-02-09 Thread GitBox
tao12345666333 commented on issue #857: URL: https://github.com/apache/apisix-ingress-controller/issues/857#issuecomment-1034330791 If we rollback the APISIX docker image used by the e2e test then it works fine. Created an issue https://github.com/apache/apisix/issues/6276 --

[GitHub] [apisix] tao12345666333 commented on issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 commented on issue #6276: URL: https://github.com/apache/apisix/issues/6276#issuecomment-1034329542 I see some test cases here https://github.com/apache/apisix/blob/defafb1e426c4ffe4aa740c9bb9ad26992fa2c2e/t/cli/test_prometheus.sh#L67-L105 -- This is an automated

[GitHub] [apisix] tao12345666333 opened a new issue #6276: bug: prometheus plugin `enable_export_server=false` not working as expected

2022-02-09 Thread GitBox
tao12345666333 opened a new issue #6276: URL: https://github.com/apache/apisix/issues/6276 ### Issue description In the recent Apache APISIX Ingress controller CI, we found that the Prometheus plugin does not take effect when set via global_rules. (we using apache/apisix:dev docker

[GitHub] [apisix] yaule commented on pull request #6270: feat(oidc): add set_userinfo_detail_header

2022-02-09 Thread GitBox
yaule commented on pull request #6270: URL: https://github.com/apache/apisix/pull/6270#issuecomment-1034309783 > hi @yaule , thanks for submitting the PR, can you explain the background of this PR? The service behind APISIX can directly obtain user information from the header,

[GitHub] [apisix] seanleblanc commented on issue #6260: request help: JWT Auth

2022-02-09 Thread GitBox
seanleblanc commented on issue #6260: URL: https://github.com/apache/apisix/issues/6260#issuecomment-1034182182 Sure, this is our most recent config, which kind of works. I see that adding the public key works, but without that, it seems to try to do something like POSTing to

[GitHub] [apisix-ingress-controller] MirtoBusico commented on issue #853: question: How to use Service IP as upstream instead of Pod IP

2022-02-09 Thread GitBox
MirtoBusico commented on issue #853: URL: https://github.com/apache/apisix-ingress-controller/issues/853#issuecomment-1034071790 Hi @tao12345666333 I don't know if it is related, but if you delete an apisixroute, it results deleted for kubernetes but is still alive in apisix-dashboard.

[GitHub] [apisix] zaunist commented on pull request #6202: feat: use keepalive in server-info plugin

2022-02-09 Thread GitBox
zaunist commented on pull request #6202: URL: https://github.com/apache/apisix/pull/6202#issuecomment-1033893890 > @zaunist any update? I have update the plugin code, still need to update test case. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-website] 1502shivam-singh commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-09 Thread GitBox
1502shivam-singh commented on issue #871: URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1033864478 > If you open the docs in another tab and switch to dark mode, when you return to the home page in the original tab, the home page will also switch to dark mode

[GitHub] [apisix-dashboard] hongbinhsu closed issue #2306: web build in node 16 rjsf/core version to lower

2022-02-09 Thread GitBox
hongbinhsu closed issue #2306: URL: https://github.com/apache/apisix-dashboard/issues/2306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #231: request help: Prometheus Apisix

2022-02-09 Thread GitBox
tao12345666333 commented on issue #231: URL: https://github.com/apache/apisix-helm-chart/issues/231#issuecomment-1033863858 Starting from https://github.com/apache/apisix-helm-chart/pull/192, we have provided ServiceMonitor, if you are using Prometheus operator you can use it directly.

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #231: request help: Prometheus Apisix

2022-02-09 Thread GitBox
tao12345666333 closed issue #231: URL: https://github.com/apache/apisix-helm-chart/issues/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-website] CP3cham commented on a change in pull request #870: chore:add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
CP3cham commented on a change in pull request #870: URL: https://github.com/apache/apisix-website/pull/870#discussion_r802757739 ## File path: website/src/pages/downloads/ProjectCard.js ## @@ -112,12 +156,47 @@ const ProjectCard = (props) => { Release Date ·{" "}

[GitHub] [apisix] moonming commented on pull request #6202: feat: use keepalive in server-info plugin

2022-02-09 Thread GitBox
moonming commented on pull request #6202: URL: https://github.com/apache/apisix/pull/6202#issuecomment-1033851864 @zaunist any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] 1502shivam-singh edited a comment on issue #667: feat: add Apache APISIX dashboard playground on website

2022-02-09 Thread GitBox
1502shivam-singh edited a comment on issue #667: URL: https://github.com/apache/apisix-website/issues/667#issuecomment-1033846171 > can I get an insight of the feature wanted? For now, I guess change `go to docs` to `preview`/`demo` and adjust the href to the dashboard demo URL.

[GitHub] [apisix-website] 1502shivam-singh commented on issue #667: feat: add Apache APISIX dashboard playground on website

2022-02-09 Thread GitBox
1502shivam-singh commented on issue #667: URL: https://github.com/apache/apisix-website/issues/667#issuecomment-1033846171 > can I get an insight of the feature wanted? For now, I guess change `go to docs` to `preview` and adjust the href to the dashboard demo URL. What say,

[GitHub] [apisix-website] 1502shivam-singh commented on issue #871: A strange problem caused by switching color modes in multiple tabs

2022-02-09 Thread GitBox
1502shivam-singh commented on issue #871: URL: https://github.com/apache/apisix-website/issues/871#issuecomment-1033837549 > I noticed that after switching to dark mode on other pages, it automatically changes back to the light mode when I return to the home page of the site. It is

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #858: bug: there are error logs for stream_routes

2022-02-09 Thread GitBox
tao12345666333 commented on issue #858: URL: https://github.com/apache/apisix-ingress-controller/issues/858#issuecomment-1033836626 Refer to https://github.com/apache/apisix-ingress-controller/issues/851#issuecomment-1026306420 -- This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #858: bug: there are error logs for stream_routes

2022-02-09 Thread GitBox
tao12345666333 commented on issue #858: URL: https://github.com/apache/apisix-ingress-controller/issues/858#issuecomment-1033835307 Thanks for your report. This is a known issue due to stream_route mode being disabled by default when using the APISIX v2.12.0 image. You can

[GitHub] [apisix-website] 1502shivam-singh commented on issue #872: UI problem of switching color mode in mobile browser

2022-02-09 Thread GitBox
1502shivam-singh commented on issue #872: URL: https://github.com/apache/apisix-website/issues/872#issuecomment-1033831539 For anyone who would want to work on this - - The intended working from my side was to keep the dark mode only for documentation section of the site, not the

[GitHub] [apisix] zhendongcmss commented on a change in pull request #6215: feat: clickhouse logger

2022-02-09 Thread GitBox
zhendongcmss commented on a change in pull request #6215: URL: https://github.com/apache/apisix/pull/6215#discussion_r802694478 ## File path: apisix/plugins/clickhouse-logger.lua ## @@ -0,0 +1,179 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-website] guoqqqi edited a comment on pull request #870: chore:add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
guoqqqi edited a comment on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1033784867 @CP3cham ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] guoqqqi commented on pull request #870: chore:add the LTS download button of 'apisix'

2022-02-09 Thread GitBox
guoqqqi commented on pull request #870: URL: https://github.com/apache/apisix-website/pull/870#issuecomment-1033784867 cc @CP3cham ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

  1   2   >