[GitHub] [apisix-dashboard] leslie-tsang commented on issue #2357: consumer can`t enable openid-connect plugin

2022-03-07 Thread GitBox
leslie-tsang commented on issue #2357: URL: https://github.com/apache/apisix-dashboard/issues/2357#issuecomment-1061498132 > I don't quite understand why need to use the `openid-connect` plugin with consumer, here are some articles that might help: https://apisix.apache.org/blog/blog/2021

[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #68: URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1060124276 # [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/68?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm

[GitHub] [apisix-dashboard] hb407033 closed issue #2357: consumer can`t enable openid-connect plugin

2022-03-07 Thread GitBox
hb407033 closed issue #2357: URL: https://github.com/apache/apisix-dashboard/issues/2357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [apisix] leslie-tsang commented on a change in pull request #6542: Add stream proxy config item

2022-03-07 Thread GitBox
leslie-tsang commented on a change in pull request #6542: URL: https://github.com/apache/apisix/pull/6542#discussion_r821393901 ## File path: conf/config-default.yaml ## @@ -111,6 +111,7 @@ apisix: # more details. ssl: radixtree_sni

[GitHub] [apisix] whioue commented on issue #6540: bug: health check Sometimes there is data, sometimes there is no data

2022-03-07 Thread GitBox
whioue commented on issue #6540: URL: https://github.com/apache/apisix/issues/6540#issuecomment-1061490824 > > > 似乎与#5953相同,您能否提供更多有关如何重现它的详细信息? > > > > > > 不知您说的更多如何重现它的详细信息指的是什么?没有特殊的配置,正常配置路由,在upstream上开启健康检查,并使用以上我所描述的方式访问就可复现。我当前是部署在18核32G的机器上测试使用,我猜测多worker下运行apisix可能更容易复现,

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
tao12345666333 commented on a change in pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#discussion_r821390135 ## File path: pkg/log/gin_logger.go ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +//

[GitHub] [apisix-website] yzeng25 commented on pull request #950: docs: update images for hyperchain blog

2022-03-07 Thread GitBox
yzeng25 commented on pull request #950: URL: https://github.com/apache/apisix-website/pull/950#issuecomment-1061487709 Preview: https://deploy-preview-950--apache-apisix.netlify.app/blog/2021/08/09/apache-apisix-in-quliankeji Compare: https://apisix.apache.org/blog/2021/08/09/apache-api

[GitHub] [apisix] leslie-tsang commented on issue #6540: bug: health check Sometimes there is data, sometimes there is no data

2022-03-07 Thread GitBox
leslie-tsang commented on issue #6540: URL: https://github.com/apache/apisix/issues/6540#issuecomment-1061487647 > > 似乎与#5953相同,您能否提供更多有关如何重现它的详细信息? > > 不知您说的更多如何重现它的详细信息指的是什么?没有特殊的配置,正常配置路由,在upstream上开启健康检查,并使用以上我所描述的方式访问就可复现。我当前是部署在18核32G的机器上测试使用,我猜测多worker下运行apisix可能更容易复现,您可以试一下,我

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #950: docs: update images for hyperchain blog

2022-03-07 Thread GitBox
netlify[bot] edited a comment on pull request #950: URL: https://github.com/apache/apisix-website/pull/950#issuecomment-1061482600 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 0504e8fc17603a72adfa69caab08e8f857be6825 🔍 Inspect the deploy log:

[GitHub] [apisix-go-plugin-runner] rampagecong commented on pull request #68: feat: add `rewrite:RespHeaders` and modify the upstream response ers via `request` implementation

2022-03-07 Thread GitBox
rampagecong commented on pull request #68: URL: https://github.com/apache/apisix-go-plugin-runner/pull/68#issuecomment-1061486284 Hello,Please run CI again. @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] avinal edited a comment on issue #6461: docs: New architecture/structure for the APISIX documentation

2022-03-07 Thread GitBox
avinal edited a comment on issue #6461: URL: https://github.com/apache/apisix/issues/6461#issuecomment-1061477443 Hello all, Thank you all for the review. here is the update for the proposal based on your suggestions. > Could the description of 'external plugins' more deliberated? I

[GitHub] [apisix] Gerrard-YNWA commented on issue #6536: request help: Is there any way to set timeout for proxy-mirror plugin

2022-03-07 Thread GitBox
Gerrard-YNWA commented on issue #6536: URL: https://github.com/apache/apisix/issues/6536#issuecomment-1061483747 > AFAIK, the responses to mirror subrequests are ignored. http://nginx.org/en/docs/http/ngx_http_mirror_module.html > > Are you saying that the response to mirror requests

[GitHub] [apisix] fatihbm edited a comment on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm edited a comment on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061482425 I added new lines to rediscluster.lua file for printed an extra error.log for a better understanding of this. You can see this on the screenshot. After doing this, when I op

[GitHub] [apisix-website] netlify[bot] commented on pull request #950: docs: update images for hyperchain blog

2022-03-07 Thread GitBox
netlify[bot] commented on pull request #950: URL: https://github.com/apache/apisix-website/pull/950#issuecomment-1061482600 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 0504e8fc17603a72adfa69caab08e8f857be6825 🔍 Inspect the deploy log: [ht

[GitHub] [apisix-website] yzeng25 opened a new pull request #950: docs: update images for hyperchain blog

2022-03-07 Thread GitBox
yzeng25 opened a new pull request #950: URL: https://github.com/apache/apisix-website/pull/950 Changes: Redo and replace the original images since they were explained in Chinese. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] fatihbm commented on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm commented on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061482425 I added new lines to rediscluster.lua file for printed an extra error.log for a better understanding of this. You can see this on the screenshot. After doing this, when I open the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #775: request help: sync crd labels to apisix

2022-03-07 Thread GitBox
tao12345666333 commented on issue #775: URL: https://github.com/apache/apisix-ingress-controller/issues/775#issuecomment-1061480719 Are your alerts log-based rather than metrics-based? Sounds like this would bring some convenience, but so far I haven't seen other similar feedback. --

[GitHub] [apisix] avinal commented on issue #6461: docs: New architecture/structure for the APISIX documentation

2022-03-07 Thread GitBox
avinal commented on issue #6461: URL: https://github.com/apache/apisix/issues/6461#issuecomment-1061477443 Hello all, Thank you all for the review. here is the update for the proposal based on your suggestions. > Could the description of 'external plugins' more deliberated? I think

[GitHub] [apisix] juzhiyuan commented on a change in pull request #6485: feat: authz-keycloak plugin support redirect not authorized user

2022-03-07 Thread GitBox
juzhiyuan commented on a change in pull request #6485: URL: https://github.com/apache/apisix/pull/6485#discussion_r821377757 ## File path: docs/en/latest/plugins/authz-keycloak.md ## @@ -63,6 +63,7 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](htt

[apisix] branch master updated (cbeb6eb -> 1853bc8)

2022-03-07 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from cbeb6eb feat: support for reading environment variables from yaml configuration files #5244 (#6505) add 1

[GitHub] [apisix] spacewander closed issue #3931: redirect plugins add curl test for `http_to_https`

2022-03-07 Thread GitBox
spacewander closed issue #3931: URL: https://github.com/apache/apisix/issues/3931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-ingress-controller] lingsamuel commented on a change in pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
lingsamuel commented on a change in pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#discussion_r821375089 ## File path: pkg/log/gin_logger.go ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// con

[GitHub] [apisix] spacewander merged pull request #6378: docs: add curl test for redirect plugin's `http_to_https`.

2022-03-07 Thread GitBox
spacewander merged pull request #6378: URL: https://github.com/apache/apisix/pull/6378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix-ingress-controller] lingsamuel commented on a change in pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
lingsamuel commented on a change in pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#discussion_r821375089 ## File path: pkg/log/gin_logger.go ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// con

[GitHub] [apisix-ingress-controller] lingsamuel commented on a change in pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
lingsamuel commented on a change in pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#discussion_r821375089 ## File path: pkg/log/gin_logger.go ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// con

[apisix-website] branch master updated: feat: support tag manager (#949)

2022-03-07 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new cbb13a4 feat: support tag manager (#

[GitHub] [apisix-website] juzhiyuan merged pull request #949: feat: support tag manager

2022-03-07 Thread GitBox
juzhiyuan merged pull request #949: URL: https://github.com/apache/apisix-website/pull/949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #321: Add e2e test cases for plugins

2022-03-07 Thread GitBox
tao12345666333 commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-1061468763 Kind reminder, is there anything I can help you @Belyenochi -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #949: feat: support tag manager

2022-03-07 Thread GitBox
netlify[bot] edited a comment on pull request #949: URL: https://github.com/apache/apisix-website/pull/949#issuecomment-1061463522 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: ff28a68cdff4f8979a70c81aed45e6e9105c51cc 🔍 Inspect the deploy log:

[GitHub] [apisix] fatihbm edited a comment on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm edited a comment on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061466414 > Yes, sure @tzssangglass root@ubuntu-bionic:/# redis-cli -p 7004 info # Server redis_version:6.9.241 redis_git_sha1:d2b5a579 redis_git_dirty:0 re

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
lingsamuel commented on pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#issuecomment-1061466527 It's a flaky test #869, just ignore it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] fatihbm commented on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm commented on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061466414 > Yes, sure root@ubuntu-bionic:/# redis-cli -p 7004 info # Server redis_version:6.9.241 redis_git_sha1:d2b5a579 redis_git_dirty:0 redis_build_id:91c71a9ef

[GitHub] [apisix] nfrankel commented on pull request #6529: fix(proxy-mirror): pattern validation

2022-03-07 Thread GitBox
nfrankel commented on pull request #6529: URL: https://github.com/apache/apisix/pull/6529#issuecomment-1061465742 It will be part of v. 2.13 released in March -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[apisix-website] branch feat-tag-manager created (now ff28a68c)

2022-03-07 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-tag-manager in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at ff28a68c feat: support tag manager No new revisions were added by this update.

[GitHub] [apisix-ingress-controller] lingsamuel commented on issue #906: docs: add pre-commit todo in the development guide

2022-03-07 Thread GitBox
lingsamuel commented on issue #906: URL: https://github.com/apache/apisix-ingress-controller/issues/906#issuecomment-1061465144 @jwrookie Assigned, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] Yullin opened a new pull request #6542: Add stream proxy config item

2022-03-07 Thread GitBox
Yullin opened a new pull request #6542: URL: https://github.com/apache/apisix/pull/6542 add "enabled: true" item to config-default.yaml, otherwise, we don't know the stream proxy mode is closed ### What this PR does / why we need it: ### Pre-submission checklist:

[GitHub] [apisix-website] netlify[bot] commented on pull request #949: feat: support tag manager

2022-03-07 Thread GitBox
netlify[bot] commented on pull request #949: URL: https://github.com/apache/apisix-website/pull/949#issuecomment-1061463522 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: ff28a68cdff4f8979a70c81aed45e6e9105c51cc 🔍 Inspect the deploy log: [ht

[GitHub] [apisix-website] juzhiyuan opened a new pull request #949: feat: support tag manager

2022-03-07 Thread GitBox
juzhiyuan opened a new pull request #949: URL: https://github.com/apache/apisix-website/pull/949 Changes: Use tag manager to maintain 3rd party codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix-website] juzhiyuan commented on pull request #945: docs: Optimize text descriptions and keywords.

2022-03-07 Thread GitBox
juzhiyuan commented on pull request #945: URL: https://github.com/apache/apisix-website/pull/945#issuecomment-1061462829 Hi, @moonming, there exist some conflicts that must be resolved locally. ![image](https://user-images.githubusercontent.com/2106987/157182448-91561f5c-599e-403b-90

[GitHub] [apisix] fatihbm commented on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm commented on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061462439 > > 12022/03/07 13:54:02 [error] 325#325: *958304 [lua] rediscluster.lua:119: try_hosts_slots(): unable to connect, attempt nr 1 : error: connection refused, client: 192.168.

[GitHub] [apisix] fatihbm removed a comment on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm removed a comment on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061462034 > > 12022/03/07 13:54:02 [error] 325#325: *958304 [lua] rediscluster.lua:119: try_hosts_slots(): unable to connect, attempt nr 1 : error: connection refused, client:

[GitHub] [apisix] fatihbm commented on issue #6530: bug: limit-count plugin does not work when I use redis cluster

2022-03-07 Thread GitBox
fatihbm commented on issue #6530: URL: https://github.com/apache/apisix/issues/6530#issuecomment-1061462034 > > 12022/03/07 13:54:02 [error] 325#325: *958304 [lua] rediscluster.lua:119: try_hosts_slots(): unable to connect, attempt nr 1 : error: connection refused, client: 192.168.

[GitHub] [apisix] spacewander closed issue #5244: Is it possible to read environment variables from yaml configuration files?

2022-03-07 Thread GitBox
spacewander closed issue #5244: URL: https://github.com/apache/apisix/issues/5244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[apisix] branch master updated: feat: support for reading environment variables from yaml configuration files #5244 (#6505)

2022-03-07 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new cbeb6eb feat: support for reading environm

[GitHub] [apisix] spacewander merged pull request #6505: feat: support for reading environment variables from yaml configuration files #5244

2022-03-07 Thread GitBox
spacewander merged pull request #6505: URL: https://github.com/apache/apisix/pull/6505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] wilson-1024 commented on issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard

2022-03-07 Thread GitBox
wilson-1024 commented on issue #6366: URL: https://github.com/apache/apisix/issues/6366#issuecomment-1061457269 can we modify the host in (apisix/apisix/balancer.lua lines 333-340)? ```java if pass_host == "node" and balancer.recreate_request then local host = se

[GitHub] [apisix-ingress-controller] Belyenochi commented on pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
Belyenochi commented on pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#issuecomment-1061453304 @lingsamuel, hi lingsamuel, I observed ci error, check the ingress lb status is updated, I don't know what to do to fix it. -- This is an automated messag

[GitHub] [apisix-dashboard] zaunist opened a new pull request #2366: docs: fix invalid link

2022-03-07 Thread GitBox
zaunist opened a new pull request #2366: URL: https://github.com/apache/apisix-dashboard/pull/2366 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided -

[GitHub] [apisix-ingress-controller] jwrookie commented on issue #906: docs: add pre-commit todo in the development guide

2022-03-07 Thread GitBox
jwrookie commented on issue #906: URL: https://github.com/apache/apisix-ingress-controller/issues/906#issuecomment-1061450346 Can you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] wilson-1024 commented on issue #6197: request help: How to current limit both in minutes and day by using plugin limit-count

2022-03-07 Thread GitBox
wilson-1024 commented on issue #6197: URL: https://github.com/apache/apisix/issues/6197#issuecomment-1061443999 I can try it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-ingress-controller] zlhgo commented on issue #775: request help: sync crd labels to apisix

2022-03-07 Thread GitBox
zlhgo commented on issue #775: URL: https://github.com/apache/apisix-ingress-controller/issues/775#issuecomment-1061443810 还是希望能加上这个功能。比如把标签同步到 apisix 后,可以在access_log里多加一些group,project相关的日志信息,这样更方便告警时通知对应项目的负责人。谢谢! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-ingress-controller] zlhgo opened a new issue #775: request help: sync crd labels to apisix

2022-03-07 Thread GitBox
zlhgo opened a new issue #775: URL: https://github.com/apache/apisix-ingress-controller/issues/775 ### Issue description i have some labels like group,project... in k8s crd, i want to get the labels in apisix plugins. ### Environment * your apisix-ingress-controller version (

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] tzssangglass edited a comment on issue #6528: docs: improve Chinese copywriting

2022-03-07 Thread GitBox
tzssangglass edited a comment on issue #6528: URL: https://github.com/apache/apisix/issues/6528#issuecomment-1061439283 @juzhiyuan PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-website] moonming commented on pull request #945: docs: Optimize text descriptions and keywords.

2022-03-07 Thread GitBox
moonming commented on pull request #945: URL: https://github.com/apache/apisix-website/pull/945#issuecomment-1061440213 @juzhiyuan please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] tzssangglass commented on issue #6528: docs: improve Chinese copywriting

2022-03-07 Thread GitBox
tzssangglass commented on issue #6528: URL: https://github.com/apache/apisix/issues/6528#issuecomment-1061439283 @juzhiyuan PLAT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] liangliang4ward commented on issue #5710: request help: Can the jwt plugin support custom authentication parameter names?

2022-03-07 Thread GitBox
liangliang4ward commented on issue #5710: URL: https://github.com/apache/apisix/issues/5710#issuecomment-1061434408 @spacewander hi, I wan't to know why this PR: https://github.com/apache/apisix/pull/5738 closed. It's something wrong? if not other question, I can create pr to solve this

[GitHub] [apisix] spacewander commented on issue #6536: request help: Is there any way to set timeout for proxy-mirror plugin

2022-03-07 Thread GitBox
spacewander commented on issue #6536: URL: https://github.com/apache/apisix/issues/6536#issuecomment-1061434176 > when mirroring traffic to a slow backend, the next coming http request on the reused connection will stuck This is the limitation of Nginx's mirror feature, as the main

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #945: docs: Optimize text descriptions and keywords.

2022-03-07 Thread GitBox
netlify[bot] edited a comment on pull request #945: URL: https://github.com/apache/apisix-website/pull/945#issuecomment-1060250333 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 30e547e29f789553fda9d75b812696fc4b7e6a36 🔍 Inspect the deploy log:

[GitHub] [apisix] spacewander commented on issue #6197: request help: How to current limit both in minutes and day by using plugin limit-count

2022-03-07 Thread GitBox
spacewander commented on issue #6197: URL: https://github.com/apache/apisix/issues/6197#issuecomment-1061433462 Can it be done in this plugin? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] moonming commented on pull request #945: docs: Optimize text descriptions and keywords.

2022-03-07 Thread GitBox
moonming commented on pull request #945: URL: https://github.com/apache/apisix-website/pull/945#issuecomment-1061432857 @SylviaBABY all fixed, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #945: docs: Optimize text descriptions and keywords.

2022-03-07 Thread GitBox
netlify[bot] edited a comment on pull request #945: URL: https://github.com/apache/apisix-website/pull/945#issuecomment-1060250333 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 30e547e29f789553fda9d75b812696fc4b7e6a36 🔍 Inspect the deploy lo

[GitHub] [apisix] spacewander merged pull request #6509: change: backport server-info to 2.10

2022-03-07 Thread GitBox
spacewander merged pull request #6509: URL: https://github.com/apache/apisix/pull/6509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch release/2.10 updated: change: backport server-info to 2.10 (#6509)

2022-03-07 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch release/2.10 in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/release/2.10 by this push: new 60987be change: backport serve

[GitHub] [apisix] spacewander commented on issue #6541: chore: As a Developer, I want to uniform code specification and style

2022-03-07 Thread GitBox
spacewander commented on issue #6541: URL: https://github.com/apache/apisix/issues/6541#issuecomment-1061431473 Please don't waste time doing this without any linter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] spacewander closed issue #6541: chore: As a Developer, I want to uniform code specification and style

2022-03-07 Thread GitBox
spacewander closed issue #6541: URL: https://github.com/apache/apisix/issues/6541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] zaunist commented on pull request #6509: change: backport server-info to 2.10

2022-03-07 Thread GitBox
zaunist commented on pull request #6509: URL: https://github.com/apache/apisix/pull/6509#issuecomment-1061430581 I have create an issue for uniform code style https://github.com/apache/apisix/issues/6541. So we can do it in other PRs. -- This is an automated message from the Apache Git S

[GitHub] [apisix-ingress-controller] jwrookie removed a comment on issue #906: docs: add pre-commit todo in the development guide

2022-03-07 Thread GitBox
jwrookie removed a comment on issue #906: URL: https://github.com/apache/apisix-ingress-controller/issues/906#issuecomment-1061427890 Can you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-ingress-controller] jwrookie commented on issue #906: docs: add pre-commit todo in the development guide

2022-03-07 Thread GitBox
jwrookie commented on issue #906: URL: https://github.com/apache/apisix-ingress-controller/issues/906#issuecomment-1061427890 Can you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] liangliang4ward commented on issue #6537: bug: The function of ip-restriction is contrary

2022-03-07 Thread GitBox
liangliang4ward commented on issue #6537: URL: https://github.com/apache/apisix/issues/6537#issuecomment-1061425323 > Perhaps you can restrict the IP and use the actual Linux IP -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] zaunist opened a new issue #6541: chore: As a Developer, I want to uniform code specification and style

2022-03-07 Thread GitBox
zaunist opened a new issue #6541: URL: https://github.com/apache/apisix/issues/6541 ### Issue description ref this comment https://github.com/apache/apisix/pull/6509#discussion_r820630797 when we write a code block like this: ``` return res, nil ``` The `,

[GitHub] [apisix] wilson-1024 commented on issue #6197: request help: How to current limit both in minutes and day by using plugin limit-count

2022-03-07 Thread GitBox
wilson-1024 commented on issue #6197: URL: https://github.com/apache/apisix/issues/6197#issuecomment-1061410386 I want to write a new plugin to implement this function. can it be assigned to me? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#issuecomment-1061370123 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/904?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix-ingress-controller] Belyenochi commented on pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
Belyenochi commented on pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#issuecomment-1061408607 > Please fix this: > > > Error: ../../pkg/log/gin_logger.go:26:2: missing go.sum entry for module providing package github.com/gin-gonic/gin (imported

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] zaunist commented on a change in pull request #6509: change: backport server-info to 2.10

2022-03-07 Thread GitBox
zaunist commented on a change in pull request #6509: URL: https://github.com/apache/apisix/pull/6509#discussion_r821322311 ## File path: apisix/core/etcd.lua ## @@ -360,4 +361,19 @@ function _M.server_version() end +function _M.keepalive(id) +local etcd_cli, _, err = n

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] whioue commented on issue #6540: bug: health check Sometimes there is data, sometimes there is no data

2022-03-07 Thread GitBox
whioue commented on issue #6540: URL: https://github.com/apache/apisix/issues/6540#issuecomment-1061403450 > 似乎与#5953相同,您能否提供更多有关如何重现它的详细信息? 不知您说的更多如何重现它的详细信息指的是什么?没有特殊的配置,正常配置路由,在upstream上开启健康检查,并使用以上我所描述的方式访问就可复现。我当前是部署在18核32G的机器上测试使用,我猜测多worker下运行apisix可能更容易复现,您可以试一下,我认为很容易重现这种情况。

[GitHub] [apisix] leslie-tsang commented on issue #6540: bug: health check Sometimes there is data, sometimes there is no data

2022-03-07 Thread GitBox
leslie-tsang commented on issue #6540: URL: https://github.com/apache/apisix/issues/6540#issuecomment-1061397668 It seems same with https://github.com/apache/apisix/issues/5953, can you provide more detail of how to reproduce it? -- This is an automated message from the Apache Git Servic

[GitHub] [apisix] membphis commented on a change in pull request #6509: change: backport server-info to 2.10

2022-03-07 Thread GitBox
membphis commented on a change in pull request #6509: URL: https://github.com/apache/apisix/pull/6509#discussion_r821313081 ## File path: apisix/core/etcd.lua ## @@ -360,4 +361,19 @@ function _M.server_version() end +function _M.keepalive(id) +local etcd_cli, _, err =

[GitHub] [apisix] tzssangglass commented on issue #6536: request help: Is there any way to set timeout for proxy-mirror plugin

2022-03-07 Thread GitBox
tzssangglass commented on issue #6536: URL: https://github.com/apache/apisix/issues/6536#issuecomment-1061396508 AFAIK, the responses to mirror subrequests are ignored. http://nginx.org/en/docs/http/ngx_http_mirror_module.html Are you saying that the response to mirror requests slows

[GitHub] [apisix] tzssangglass commented on issue #6528: docs: improve Chinese copywriting

2022-03-07 Thread GitBox
tzssangglass commented on issue #6528: URL: https://github.com/apache/apisix/issues/6528#issuecomment-1061395219 would you like to do it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [apisix] tzssangglass commented on issue #6528: docs: improve Chinese copywriting

2022-03-07 Thread GitBox
tzssangglass commented on issue #6528: URL: https://github.com/apache/apisix/issues/6528#issuecomment-1061394971 LGTM, let's check with the tool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] whioue opened a new issue #6540: bug: health check Sometimes there is data, sometimes there is no data

2022-03-07 Thread GitBox
whioue opened a new issue #6540: URL: https://github.com/apache/apisix/issues/6540 ### Issue description 1.当我配置了upstream的主动以及被动健康检查,关联route并成功转发请求后,使用curl频繁访问/v1/healthcheck,发现有时返回数据,有时不返回数据。 2.我还发现使用不同的终端(浏览器和postman)频繁访问/v1/healthcheck,发现postman能获取数据,浏览器却获取不到,如下: 浏览器: ![i

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-helm-chart] leshalv closed pull request #244: feat: upgrade ETCD to 6.13.5

2022-03-07 Thread GitBox
leshalv closed pull request #244: URL: https://github.com/apache/apisix-helm-chart/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [apisix] kingmouse-yx commented on issue #6537: bug: The function of ip-restriction is contrary

2022-03-07 Thread GitBox
kingmouse-yx commented on issue #6537: URL: https://github.com/apache/apisix/issues/6537#issuecomment-1061380537 > > > > > > > Do you access Apisix directly, or do you add a layer of proxies, such as Nginx or SLB > > > > > > > ref:#4712 > > > > > > > > > > > > > > > > > > I ac

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2341: feat: add security header

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2341: URL: https://github.com/apache/apisix-dashboard/pull/2341#issuecomment-1049536812 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2362: feat: storage grafana path in to etcd

2022-03-07 Thread GitBox
codecov-commenter edited a comment on pull request #2362: URL: https://github.com/apache/apisix-dashboard/pull/2362#issuecomment-1060212801 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[apisix] branch master updated: feat: rerun rewrite phase for newly added plugins in consumer (#6502)

2022-03-07 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 65cd5d0 feat: rerun rewrite phase for newl

[GitHub] [apisix] spacewander closed issue #6405: request help: The plugins that act on the specified consumer do not take effect

2022-03-07 Thread GitBox
spacewander closed issue #6405: URL: https://github.com/apache/apisix/issues/6405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] spacewander merged pull request #6502: feat: rerun rewrite phase for newly added plugins in consumer

2022-03-07 Thread GitBox
spacewander merged pull request #6502: URL: https://github.com/apache/apisix/pull/6502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #904: feat: format gin logger

2022-03-07 Thread GitBox
lingsamuel commented on pull request #904: URL: https://github.com/apache/apisix-ingress-controller/pull/904#issuecomment-1061374813 Please fix this: > Error: ../../pkg/log/gin_logger.go:26:2: missing go.sum entry for module providing package github.com/gin-gonic/gin (imported by githu

  1   2   3   4   >