[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
tao12345666333 commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079839482 You can use kind with v1.21 kubernetes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-ingress-controller] cmssczy commented on pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
cmssczy commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079832900 How do I test `extensions/v1beta1` ingress in my local environment? My local k8s cluster(v1.23.3) do not support this version. -- This is an automated messa

[GitHub] [apisix-dashboard] jwrookie commented on issue #2395: docs: How to reset the password of apisix dashboard?

2022-03-26 Thread GitBox
jwrookie commented on issue #2395: URL: https://github.com/apache/apisix-dashboard/issues/2395#issuecomment-1079827411 https://github.com/apache/apisix-dashboard/blob/162c5d7bcdfa36d76681b2a607267bcb76185cc5/api/conf/conf.yaml#L78-L82 The account and password store in conf.yaml, you

[GitHub] [apisix] soulbird opened a new issue #6729: feat: As a user, I hope apisix can make some restrictions on the custom functions in the serverless plugin, and the use of illegal code will not ca

2022-03-26 Thread GitBox
soulbird opened a new issue #6729: URL: https://github.com/apache/apisix/issues/6729 ### Description I noticed that the serverless plugin allows users to run custom functions, but it doesn't seem to have any restrictions. Some illegal code of the user may cause the apisix service to

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
codecov-commenter commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm

[GitHub] [apisix] tzssangglass commented on issue #6725: help request: 内存持续增涨OOM

2022-03-26 Thread GitBox
tzssangglass commented on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1079818811 Is the memory performance of instance `29zhg` normal? Is there any difference? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix-website] SkyeYoung commented on issue #920: [Docs]: Allow single-language blog without creating 404

2022-03-26 Thread GitBox
SkyeYoung commented on issue #920: URL: https://github.com/apache/apisix-website/issues/920#issuecomment-1079816446 > @SkyeYoung would you have time to fix this issue? Yes, I can give it a try. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
tao12345666333 commented on a change in pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r835836969 ## File path: pkg/kube/translation/annotations/forward_auth.go ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation

[GitHub] [apisix] membphis commented on pull request #6707: fix: hidding real message when password or username is error

2022-03-26 Thread GitBox
membphis commented on pull request #6707: URL: https://github.com/apache/apisix/pull/6707#issuecomment-1079815823 many thx @liangliang4ward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[apisix] branch master updated: fix: hidding real message when password or username is error (#6707)

2022-03-26 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new ee7771b fix: hidding real message when passwo

[GitHub] [apisix] membphis closed issue #6703: feat: As a user, when use basic-auth if password or username is error I don't want tell truth message

2022-03-26 Thread GitBox
membphis closed issue #6703: URL: https://github.com/apache/apisix/issues/6703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [apisix] membphis merged pull request #6707: fix: hidding real message when password or username is error

2022-03-26 Thread GitBox
membphis merged pull request #6707: URL: https://github.com/apache/apisix/pull/6707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [apisix-website] membphis commented on issue #920: [Docs]: Allow single-language blog without creating 404

2022-03-26 Thread GitBox
membphis commented on issue #920: URL: https://github.com/apache/apisix-website/issues/920#issuecomment-1079815639 @SkyeYoung would you have time to fix this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] cmssczy commented on a change in pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
cmssczy commented on a change in pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r835835940 ## File path: pkg/kube/translation/annotations/forward_auth.go ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #931: feat: delete app_namespaces parameter

2022-03-26 Thread GitBox
tao12345666333 commented on pull request #931: URL: https://github.com/apache/apisix-ingress-controller/pull/931#issuecomment-1079731279 Thanks for your contribution, I am thinking about the specific impact of users upgrading with these recent changes to namespaces. -- This is an automa

[GitHub] [apisix] Goxiaoy opened a new issue #6728: bug: Can not access opentelemetry header in ext-plugin-pre-req plugin

2022-03-26 Thread GitBox
Goxiaoy opened a new issue #6728: URL: https://github.com/apache/apisix/issues/6728 ### Current Behavior opentelemetry propagation header will be inject here by `carrier_new` https://github.com/apache/apisix/blob/38663991c189c3c0d00ab48bcc9664142fabb170/apisix/plugins

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #937: feat: support forward-auth plugin

2022-03-26 Thread GitBox
tao12345666333 commented on a change in pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r835783620 ## File path: test/e2e/annotations/forward_auth.go ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [apisix] tzssangglass commented on issue #5650: request help: etcd tls connect handshake failed

2022-03-26 Thread GitBox
tzssangglass commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1079717776 > 1. use api7/apisix-base:1.19.9.1.4 as base image to build,api7/apisix-base:1.19.9.1.4 image use `RESTY_OPENSSL_VERSION="1.1.1g"`; > 2. set etcd tls verify: false; If

[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-26 Thread GitBox
tzssangglass commented on issue #6709: URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079717169 good idea, we should make the file logger itself support log file rotation.. cc @spacewander -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix] tzssangglass commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage

2022-03-26 Thread GitBox
tzssangglass commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1079713346 I changed my mind and I think it's a meaningful enhancemen. Perhaps we can first monitor the nginx.shared.DICT that is used by APISIX, and next we allow users to monitor

[GitHub] [apisix] tzssangglass commented on issue #5246: bug: http request to upstream, roundrobin is imbalance when multi nginx worker process

2022-03-26 Thread GitBox
tzssangglass commented on issue #5246: URL: https://github.com/apache/apisix/issues/5246#issuecomment-1079712602 > Note it: the mentioned `RR` algorithm should be `WRR` or `SWRR`, [Smooth Weighted Round-Robin](https://github.com/phusion/nginx/commit/27e94984486058d73157038f7950a0a36ecc6e35

[GitHub] [apisix-ingress-controller] liujiabaoaa commented on issue #938: docs: the-hard-way doc is out of date.

2022-03-26 Thread GitBox
liujiabaoaa commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079706394 well. got it. Because I want to understand the process by manually installing yaml files for the first time. Although helm is simple, he didn't understand it ve

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: docs: the-hard-way doc is out of date.

2022-03-26 Thread GitBox
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079705779 > 是的。我后来也发现了。我有个问题想请教下。apisix和apisix ingress controller版本的对应关系 在哪里呢? In README Prerequisites > Apisix ingress controller requires Kuberne

[GitHub] [apisix-ingress-controller] liujiabaoaa commented on issue #938: docs: the-hard-way doc is out of date.

2022-03-26 Thread GitBox
liujiabaoaa commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079705344 I tried to modify the version of apifix ingress controller again. The version of the image is 1.4.0, which has been solved. What I want to know is whether the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: docs: the-hard-way doc is out of date.

2022-03-26 Thread GitBox
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079704512 The error is due to the fact that when we introduced the default configuration option default_cluster_base_url , all relevant content was modified globally,

[GitHub] [apisix-ingress-controller] liujiabaoaa commented on issue #938: apisix ingress controller 启动报错bad configuration: apisix base url is required

2022-03-26 Thread GitBox
liujiabaoaa commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079703660 是的。我后来也发现了。我有个问题想请教下。apisix和apisix ingress controller版本的对应关系 在哪里呢? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: apisix ingress controller 启动报错bad configuration: apisix base url is required

2022-03-26 Thread GitBox
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079703567 You can try to modify the image to the latest version, and submit a PR to update this document after the deployment is successful, thank you -- This is an

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: apisix ingress controller 启动报错bad configuration: apisix base url is required

2022-03-26 Thread GitBox
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079702236 This documentation is out of date. Please note that the current latest version is v1.4. The image used in your above configuration is 0.5. The

[GitHub] [apisix] zhixiongdu027 opened a new pull request #6727: ci: remove unnecessary step

2022-03-26 Thread GitBox
zhixiongdu027 opened a new pull request #6727: URL: https://github.com/apache/apisix/pull/6727 ### Description Fixes #6706 ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new fea

[GitHub] [apisix] zhixiongdu027 commented on issue #6706: help request: the "Extract branch name" step is unnecessary in some workflow

2022-03-26 Thread GitBox
zhixiongdu027 commented on issue #6706: URL: https://github.com/apache/apisix/issues/6706#issuecomment-1079689823 I will do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [apisix] liangliang4ward commented on a change in pull request #6707: fix: hidding real message when password or username is error

2022-03-26 Thread GitBox
liangliang4ward commented on a change in pull request #6707: URL: https://github.com/apache/apisix/pull/6707#discussion_r835761511 ## File path: apisix/plugins/basic-auth.lua ## @@ -167,14 +167,14 @@ function _M.rewrite(conf, ctx) -- 3. check user exists local cur_con

[GitHub] [apisix] liangliang4ward commented on a change in pull request #6707: fix: hidding real message when password or username is error

2022-03-26 Thread GitBox
liangliang4ward commented on a change in pull request #6707: URL: https://github.com/apache/apisix/pull/6707#discussion_r835761390 ## File path: apisix/plugins/basic-auth.lua ## @@ -167,14 +167,14 @@ function _M.rewrite(conf, ctx) -- 3. check user exists local cur_con

[GitHub] [apisix] liangliang4ward commented on a change in pull request #6707: fix: hidding real message when password or username is error

2022-03-26 Thread GitBox
liangliang4ward commented on a change in pull request #6707: URL: https://github.com/apache/apisix/pull/6707#discussion_r835761496 ## File path: apisix/plugins/ldap-auth.lua ## @@ -152,7 +152,7 @@ function _M.rewrite(conf, ctx) create_consumer_cache, consumer_conf)

[GitHub] [apisix-dashboard] mygrsun commented on issue #2391: does apisix-dashboard support deploy multiple node as loadbalance?

2022-03-26 Thread GitBox
mygrsun commented on issue #2391: URL: https://github.com/apache/apisix-dashboard/issues/2391#issuecomment-1079685216 > > > > > > > > > > yes ,the two dashboard use zhe same etcd。In fact,I use k8s deploy the node。Every nodes has dashboard-apisix and apisix。 >

[GitHub] [apisix] yzeng25 commented on pull request #6554: docs: added an Introductory section to the "Getting started"

2022-03-26 Thread GitBox
yzeng25 commented on pull request #6554: URL: https://github.com/apache/apisix/pull/6554#issuecomment-1079684553 LGTM cc @bisakhmondal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [apisix] hctech edited a comment on issue #5650: request help: etcd tls connect handshake failed

2022-03-26 Thread GitBox
hctech edited a comment on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1079672618 1. use api7/apisix-base:1.19.9.1.4 as base image to build,api7/apisix-base:1.19.9.1.4 image use `RESTY_OPENSSL_VERSION="1.1.1g"`; 2. set etcd tls verify: false; -- This i

[GitHub] [apisix] hctech commented on issue #5650: request help: etcd tls connect handshake failed

2022-03-26 Thread GitBox
hctech commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1079672618 use api7/apisix-base:1.19.9.1.4 as base image to build, set etcd tls verify: false -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] liangliang4ward commented on pull request #6707: fix: hidding real message when password or username is error

2022-03-26 Thread GitBox
liangliang4ward commented on pull request #6707: URL: https://github.com/apache/apisix/pull/6707#issuecomment-1079672090 > Hi @liangliang4ward, you need to use: > > ``` > Fixes #6703 > ``` > > but not > > ``` > Fixes # [(issue)](https://github.com/apache/apisix

[GitHub] [apisix] liangliang4ward commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-26 Thread GitBox
liangliang4ward commented on issue #6709: URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079671686 I mean ,the file-log-plugin write only one file. I think the file will be very large. we should split them -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] leslie-tsang commented on a change in pull request #6554: docs: added an Introductory section to the "Getting started"

2022-03-26 Thread GitBox
leslie-tsang commented on a change in pull request #6554: URL: https://github.com/apache/apisix/pull/6554#discussion_r835752431 ## File path: docs/en/latest/getting-started.md ## @@ -20,6 +20,46 @@ title: Getting Started # limitations under the License. # --> +## What is an

[GitHub] [apisix] leslie-tsang commented on a change in pull request #6554: docs: added an Introductory section to the "Getting started"

2022-03-26 Thread GitBox
leslie-tsang commented on a change in pull request #6554: URL: https://github.com/apache/apisix/pull/6554#discussion_r835751183 ## File path: docs/en/latest/getting-started.md ## @@ -19,7 +19,45 @@ title: Getting Started # See the License for the specific language governing pe

[GitHub] [apisix] leslie-tsang commented on a change in pull request #6554: docs: added an Introductory section to the "Getting started"

2022-03-26 Thread GitBox
leslie-tsang commented on a change in pull request #6554: URL: https://github.com/apache/apisix/pull/6554#discussion_r835751155 ## File path: docs/en/latest/getting-started.md ## @@ -19,7 +19,45 @@ title: Getting Started # See the License for the specific language governing pe

[GitHub] [apisix] kwanhur commented on issue #6725: help request: 内存持续增涨OOM

2022-03-26 Thread GitBox
kwanhur commented on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1079661060 If ok, suggest you disable all the plugins to eliminate their effects. Then enable plugin one by one. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] juzhiyuan commented on issue #5472: docs: apisix/docs/en/latest/how-to-build.md

2022-03-26 Thread GitBox
juzhiyuan commented on issue #5472: URL: https://github.com/apache/apisix/issues/5472#issuecomment-1079656884 > Tutorial videos had been posted, like email [Getting started with Apache APISIX @YouTube](https://www.mail-archive.com/dev@apisix.apache.org/msg04513.html). cc @Boburmirzo

[GitHub] [apisix] kwanhur commented on issue #6034: bug: problems caused by stream_proxy (tcp proxy)

2022-03-26 Thread GitBox
kwanhur commented on issue #6034: URL: https://github.com/apache/apisix/issues/6034#issuecomment-1079656214 I guess the key-point was on `vip`, please check the `arp_ignore` `arp_announce` and `rp_filter`. Under using `keepalived` aside with `IPVS`, focus on `ARP` first, see details

[GitHub] [apisix] kwanhur commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage

2022-03-26 Thread GitBox
kwanhur commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1079650787 Is it like [ngx_slab_stats](https://github.com/alibaba/tengine/tree/master/modules/ngx_slab_stat)? Which supports shared memory allocated from lua-nginx-module. -- This is an auto

[GitHub] [apisix] kwanhur commented on issue #5472: docs: apisix/docs/en/latest/how-to-build.md

2022-03-26 Thread GitBox
kwanhur commented on issue #5472: URL: https://github.com/apache/apisix/issues/5472#issuecomment-1079648559 Tutorial videos had been posted, like email [Getting started with Apache APISIX @YouTube](https://www.mail-archive.com/dev@apisix.apache.org/msg04513.html). -- This is an automate

[GitHub] [apisix] kwanhur commented on issue #5533: systemctl enable apisix is not avialiable

2022-03-26 Thread GitBox
kwanhur commented on issue #5533: URL: https://github.com/apache/apisix/issues/5533#issuecomment-1079646764 > @lifeblood It does not appear to cause a startup failure,just go to run `systemctl start apisix` start apisix or `systemctl stop apisix` stop apisix Automatically startup api

[GitHub] [apisix] kwanhur commented on issue #5533: systemctl enable apisix is not avialiable

2022-03-26 Thread GitBox
kwanhur commented on issue #5533: URL: https://github.com/apache/apisix/issues/5533#issuecomment-1079646068 I'm sure `systemctl enable apisix` works well on Centos7 with `apisix-2.12.0-0.el7.x86_64`. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] kwanhur commented on issue #5246: bug: http request to upstream, roundrobin is imbalance when multi nginx worker process

2022-03-26 Thread GitBox
kwanhur commented on issue #5246: URL: https://github.com/apache/apisix/issues/5246#issuecomment-1079643013 Note it: the mentioned `RR` algorithm should be `WRR` or `SWRR`, [Smooth Weighted Round-Robin](https://github.com/phusion/nginx/commit/27e94984486058d73157038f7950a0a36ecc6e35). -

[GitHub] [apisix] spacewander commented on issue #3289: feat: add a pre-commit framework

2022-03-26 Thread GitBox
spacewander commented on issue #3289: URL: https://github.com/apache/apisix/issues/3289#issuecomment-1079641151 We don't need it yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] spacewander closed issue #3289: feat: add a pre-commit framework

2022-03-26 Thread GitBox
spacewander closed issue #3289: URL: https://github.com/apache/apisix/issues/3289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-dashboard] alexchan10241 opened a new issue #2395: docs: How to reset the password of apisix dashboard?

2022-03-26 Thread GitBox
alexchan10241 opened a new issue #2395: URL: https://github.com/apache/apisix-dashboard/issues/2395 ### Current State I forgot my account password.Then I can not get access to reset it . Need somebody help,please!!! ### Desired State I forgot my account password.Then I

[apisix] branch master updated: docs: update FAQ docs (#6695)

2022-03-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3866399 docs: update FAQ docs (#6695) 3866

[GitHub] [apisix] spacewander merged pull request #6695: docs: update FAQ docs

2022-03-26 Thread GitBox
spacewander merged pull request #6695: URL: https://github.com/apache/apisix/pull/6695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] spacewander closed issue #6594: docs: Restructure the FAQ section

2022-03-26 Thread GitBox
spacewander closed issue #6594: URL: https://github.com/apache/apisix/issues/6594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un