[GitHub] [apisix] soulbird commented on issue #6719: bug: load opentelemetry so, curl /apisix/prometheus/metrics coredump

2022-03-27 Thread GitBox
soulbird commented on issue #6719: URL: https://github.com/apache/apisix/issues/6719#issuecomment-1079874368 hi, according to your error log, I found two problems, one is coredumps, related errorlog: ```bash [alert] 1#1: worker process 46 exited on signal 11 ``` I reproduced the

[GitHub] [apisix] soulbird removed a comment on issue #6719: bug: load opentelemetry so, curl /apisix/prometheus/metrics coredump

2022-03-27 Thread GitBox
soulbird removed a comment on issue #6719: URL: https://github.com/apache/apisix/issues/6719#issuecomment-1079874368 hi, according to your error log, I found two problems, one is coredumps, related errorlog: ```bash [alert] 1#1: worker process 46 exited on signal 11 ``` I reprod

[GitHub] [apisix] soulbird commented on issue #6719: bug: load opentelemetry so, curl /apisix/prometheus/metrics coredump

2022-03-27 Thread GitBox
soulbird commented on issue #6719: URL: https://github.com/apache/apisix/issues/6719#issuecomment-1079876137 hi, according to your error log, I found two problems, one is coredumps, related errorlog: ```bash [alert] 1#1: worker process 46 exited on signal 11 ``` I reproduced the

[apisix] branch master updated: docs: added an Introductory section to the "Getting started" (#6554)

2022-03-27 Thread singhsh
This is an automated email from the ASF dual-hosted git repository. singhsh pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new c46fe49 docs: added an Introductory section to

[GitHub] [apisix] 1502shivam-singh merged pull request #6554: docs: added an Introductory section to the "Getting started"

2022-03-27 Thread GitBox
1502shivam-singh merged pull request #6554: URL: https://github.com/apache/apisix/pull/6554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [apisix] domyway commented on issue #6719: bug: load opentelemetry so, curl /apisix/prometheus/metrics coredump

2022-03-27 Thread GitBox
domyway commented on issue #6719: URL: https://github.com/apache/apisix/issues/6719#issuecomment-1079908032 thanks , I check the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix] kwanhur opened a new pull request #6730: ci(lint): filter files by git-ls-files and remove subcommand grep

2022-03-27 Thread GitBox
kwanhur opened a new pull request #6730: URL: https://github.com/apache/apisix/pull/6730 ### Description Target: Improving script `git ls-files` functionality and redundancy. Changes: filter files with `git ls-files`, remove `grep`. ### Checklist - [x] I have

[GitHub] [apisix] spacewander commented on a change in pull request #6382: feat: add auth plugin for casdoor

2022-03-27 Thread GitBox
spacewander commented on a change in pull request #6382: URL: https://github.com/apache/apisix/pull/6382#discussion_r835896493 ## File path: apisix/plugins/authz-casdoor.lua ## @@ -0,0 +1,175 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- cont

[GitHub] [apisix] juzhiyuan commented on pull request #6554: docs: added an Introductory section to the "Getting started"

2022-03-27 Thread GitBox
juzhiyuan commented on pull request #6554: URL: https://github.com/apache/apisix/pull/6554#issuecomment-1079915969 Hi, @1502shivam-singh, thanks for your review and merge! Before merging, please remove unnecessary commit messages 😅 or it will make this happen. ![image](https://user-

[GitHub] [apisix] spacewander commented on issue #6728: bug: Can not access opentelemetry header in ext-plugin-pre-req plugin

2022-03-27 Thread GitBox
spacewander commented on issue #6728: URL: https://github.com/apache/apisix/issues/6728#issuecomment-1079916007 Interesting. It is expected has been fixed in https://github.com/apache/apisix/commit/210575cc08e8296083332caa17e259f83ef3beca. I will try to reproduce it tomorrow. -- This is

[GitHub] [apisix] spacewander commented on pull request #6713: fix(batch-requests): read trailers

2022-03-27 Thread GitBox
spacewander commented on pull request #6713: URL: https://github.com/apache/apisix/pull/6713#issuecomment-1079916990 You can refer to https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander closed issue #6706: help request: the "Extract branch name" step is unnecessary in some workflow

2022-03-27 Thread GitBox
spacewander closed issue #6706: URL: https://github.com/apache/apisix/issues/6706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] spacewander merged pull request #6727: ci: remove unnecessary step

2022-03-27 Thread GitBox
spacewander merged pull request #6727: URL: https://github.com/apache/apisix/pull/6727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated (c46fe49 -> f624fb0)

2022-03-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from c46fe49 docs: added an Introductory section to the "Getting started" (#6554) add f624fb0 ci: remove unne

[GitHub] [apisix] spacewander commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-27 Thread GitBox
spacewander commented on issue #6709: URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079920955 This is not easy to combine these two plugins. But we can make a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2290: feat: added form function to authz-casbin plugin

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #2290: URL: https://github.com/apache/apisix-dashboard/pull/2290#issuecomment-1046204454 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-go-plugin-runner] Goxiaoy commented on issue #69: request help: How to pass headers from plugin runner to upstream

2022-03-27 Thread GitBox
Goxiaoy commented on issue #69: URL: https://github.com/apache/apisix-go-plugin-runner/issues/69#issuecomment-1079931978 Works for me ``` w http.ResponseWriter, r pkgHTTP.Request r.Header().Set("x-team-info","abc") ``` -- This is an automated message from the Apache Git Servi

[GitHub] [apisix-go-plugin-runner] Goxiaoy opened a new issue #74: bug: pkgHTTP.Request RespHeader() Add override previous value

2022-03-27 Thread GitBox
Goxiaoy opened a new issue #74: URL: https://github.com/apache/apisix-go-plugin-runner/issues/74 ### Issue description ``` w http.ResponseWriter, r pkgHTTP.Request r.RespHeader().Add("Set-Cookie","a=a; Expires=Wed, 21 Oct 2023 07:28:00 GMT; Secure; HttpOnly") r.RespHeader().Add(

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix-ingress-controller] gxthrj closed issue #120: feat: Combine ApisixRoute, ApisixService, ApisixUpstream into one resource object

2022-03-27 Thread GitBox
gxthrj closed issue #120: URL: https://github.com/apache/apisix-ingress-controller/issues/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #120: feat: Combine ApisixRoute, ApisixService, ApisixUpstream into one resource object

2022-03-27 Thread GitBox
gxthrj commented on issue #120: URL: https://github.com/apache/apisix-ingress-controller/issues/120#issuecomment-1079947227 OK, let's close this stale discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[apisix-ingress-controller] branch master updated: doc: add doc about installing apisix ingress with kind (#933)

2022-03-27 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new cb45119 doc: add doc ab

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #933: doc: add doc about installing apisix ingress with kind

2022-03-27 Thread GitBox
tao12345666333 merged pull request #933: URL: https://github.com/apache/apisix-ingress-controller/pull/933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [apisix] ComradeProgrammer commented on a change in pull request #6382: feat: add auth plugin for casdoor

2022-03-27 Thread GitBox
ComradeProgrammer commented on a change in pull request #6382: URL: https://github.com/apache/apisix/pull/6382#discussion_r835926106 ## File path: apisix/plugins/authz-casdoor.lua ## @@ -0,0 +1,175 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-

[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor

2022-03-27 Thread GitBox
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1079957130 revisions have been made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix-go-plugin-runner] Goxiaoy commented on issue #74: bug: pkgHTTP.Request RespHeader() Add override previous value

2022-03-27 Thread GitBox
Goxiaoy commented on issue #74: URL: https://github.com/apache/apisix-go-plugin-runner/issues/74#issuecomment-1079964248 https://github.com/apache/apisix/blob/f624fb0a4d33e5aa674ec659e9d778da2ef9860f/apisix/plugins/ext-plugin/init.lua#L626-L635 ``` local len = rewrite

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #939: feat: introduce v2 apiversion

2022-03-27 Thread GitBox
tao12345666333 opened a new pull request #939: URL: https://github.com/apache/apisix-ingress-controller/pull/939 Signed-off-by: Jintao Zhang ### Type of change: - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #939: feat: introduce v2 apiversion

2022-03-27 Thread GitBox
codecov-commenter commented on pull request #939: URL: https://github.com/apache/apisix-ingress-controller/pull/939#issuecomment-1079986762 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #939: feat: introduce v2 apiversion

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #939: URL: https://github.com/apache/apisix-ingress-controller/pull/939#issuecomment-1079986762 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/939?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate

2022-03-27 Thread GitBox
tzssangglass commented on issue #6709: URL: https://github.com/apache/apisix/issues/6709#issuecomment-1080066439 > This is not easy to combine these two plugins. But we can make a try. Maybe we can make file-logger support log file rotation (without modifying the log-rotate plugin, o

[GitHub] [apisix] Chever-John commented on a change in pull request #6616: docs: add datadog document(zh)

2022-03-27 Thread GitBox
Chever-John commented on a change in pull request #6616: URL: https://github.com/apache/apisix/pull/6616#discussion_r835990861 ## File path: docs/zh/latest/plugins/datadog.md ## @@ -0,0 +1,147 @@ +--- +title: datadog +--- + + + +## 简介 + +`datadog` 是 Apache APISIX 内置的监控插件,可与 [D

[apisix-helm-chart] branch master updated: feat(apisix): add timezone and extraEnvVars (#232)

2022-03-27 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 6330350 feat(apisix): add timezone a

[GitHub] [apisix-helm-chart] tokers merged pull request #232: feat(apisix): add timezone and extraEnvVars

2022-03-27 Thread GitBox
tokers merged pull request #232: URL: https://github.com/apache/apisix-helm-chart/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #257: Daemonset

2022-03-27 Thread GitBox
tokers commented on a change in pull request #257: URL: https://github.com/apache/apisix-helm-chart/pull/257#discussion_r835991858 ## File path: .idea/workspace.xml ## @@ -0,0 +1,69 @@ + Review comment: It' still there, tracked by git. -- This is an automated messa

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #257: Daemonset

2022-03-27 Thread GitBox
tokers commented on a change in pull request #257: URL: https://github.com/apache/apisix-helm-chart/pull/257#discussion_r835993042 ## File path: charts/apisix/templates/daemonset.yaml ## @@ -0,0 +1,201 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix] tzssangglass commented on pull request #6721: feat(file-logger): cache & reopen file handler

2022-03-27 Thread GitBox
tzssangglass commented on pull request #6721: URL: https://github.com/apache/apisix/pull/6721#issuecomment-1080072787 Is this an enhancement to #6709? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix] tokers commented on issue #5650: request help: etcd tls connect handshake failed

2022-03-27 Thread GitBox
tokers commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1080073556 > @tokers It means I didn't provide the client certificate, when i use `-cert` and `-key` in openssl, it's ok. `Certificate host Mismatch` is an error reported by the client when tryi

[GitHub] [apisix] tokers commented on issue #6725: help request: 内存持续增涨OOM

2022-03-27 Thread GitBox
tokers commented on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1080074756 @pguokun What about other metrics like QPS, CPU? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #926: bug: we should create APISIX routes even if Service is created later

2022-03-27 Thread GitBox
tao12345666333 commented on issue #926: URL: https://github.com/apache/apisix-ingress-controller/issues/926#issuecomment-1080075001 > Or could we stop supporting `resolveGranularity`? This feature is useful and we will not stop supporting it -- This is an automated message from th

[GitHub] [apisix] leslie-tsang closed issue #6638: help request: Why has apisix added some strange routes?

2022-03-27 Thread GitBox
leslie-tsang closed issue #6638: URL: https://github.com/apache/apisix/issues/6638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [apisix] leslie-tsang commented on issue #6638: help request: Why has apisix added some strange routes?

2022-03-27 Thread GitBox
leslie-tsang commented on issue #6638: URL: https://github.com/apache/apisix/issues/6638#issuecomment-1080075029 Considered resolved due to lack of feedback. Feel free to reopen it if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix] zhantanfeng commented on issue #6700: help request: apisix在解析域名时失败,出现循环

2022-03-27 Thread GitBox
zhantanfeng commented on issue #6700: URL: https://github.com/apache/apisix/issues/6700#issuecomment-1080075694 > > > > > > > > > I will try with APISIX 2.12, but I tried with 2.13, it can not run. > > If 2.13 has the same problem, 2.12 also suffers from it. Let me see the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #926: bug: we should create APISIX routes even if Service is created later

2022-03-27 Thread GitBox
tao12345666333 commented on issue #926: URL: https://github.com/apache/apisix-ingress-controller/issues/926#issuecomment-1080077110 Maybe we can discuss it at the community meeting on Wednesday -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] jagerzhang commented on issue #6725: help request: 内存持续增涨OOM

2022-03-27 Thread GitBox
jagerzhang commented on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1080081313 @pguokun 我在腾讯云TKE(K8S)也发现有这个问题,内存增长趋于线性,我们这边用的插件如下: 全局插件: - request-id - resonset-rewrite - kafka-logger 路由插件: - proxy-rewrite (5%) - consumer-restricti

[GitHub] [apisix] jagerzhang edited a comment on issue #6725: help request: 内存持续增涨OOM

2022-03-27 Thread GitBox
jagerzhang edited a comment on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1080081313 @pguokun 我在腾讯云TKE(K8S)也发现有这个问题,内存增长趋于线性,内存缓缓增长到预设HPA之后会触发HPA弹性扩容,然后会一直扩再也不会缩回来了,得销毁重建才会回到最开始状态。 我们这边用的插件如下: 全局插件: - request-id - resonset-rewrite - ka

[GitHub] [apisix] jagerzhang edited a comment on issue #6725: help request: 内存持续增涨OOM

2022-03-27 Thread GitBox
jagerzhang edited a comment on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1080081313 @pguokun 我在腾讯云TKE(K8S)也发现有这个问题,内存增长趋于线性,内存缓缓增长到预设HPA之后会触发HPA弹性扩容,然后会一直扩再也不会缩回来了,得销毁重建才会回到最开始状态。 我们这边用的插件如下: 全局插件: - request-id - resonset-rewrite - ka

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2290: feat: added form function to authz-casbin plugin

2022-03-27 Thread GitBox
guoqqqi commented on a change in pull request #2290: URL: https://github.com/apache/apisix-dashboard/pull/2290#discussion_r835996913 ## File path: web/src/components/Plugin/UI/authz-casbin.tsx ## @@ -37,54 +38,122 @@ const FORM_ITEM_LAYOUT = { const AuthzCasbin: React.FC = ({

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2290: feat: added form function to authz-casbin plugin

2022-03-27 Thread GitBox
guoqqqi commented on pull request #2290: URL: https://github.com/apache/apisix-dashboard/pull/2290#issuecomment-1080084312 need to fix the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] spacewander commented on pull request #6721: feat(file-logger): cache & reopen file handler

2022-03-27 Thread GitBox
spacewander commented on pull request #6721: URL: https://github.com/apache/apisix/pull/6721#issuecomment-1080086976 > Is this an enhancement to #6709? Not yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] tokers commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage

2022-03-27 Thread GitBox
tokers commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1080087201 > I changed my mind and I think it's a meaningful enhancemen. > > Perhaps we can first monitor the nginx.shared.DICT that is used by APISIX, and next we allow users to monitor a

[apisix] branch master updated: ci: should check the `>>> master` too (#6717)

2022-03-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new c0e7954 ci: should check the `>>> master`

[GitHub] [apisix] spacewander merged pull request #6717: ci: should check the `>>> master` too

2022-03-27 Thread GitBox
spacewander merged pull request #6717: URL: https://github.com/apache/apisix/pull/6717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] tokers commented on issue #6729: feat: As a user, I hope apisix can make some restrictions on the custom functions in the serverless plugin, and the use of illegal code will not caus

2022-03-27 Thread GitBox
tokers commented on issue #6729: URL: https://github.com/apache/apisix/issues/6729#issuecomment-1080090130 We may introduce a simple sandbox mechanism firstly, such as make vital data read-only and only allow users to execute write operations in a specific space. -- This is an automated

[GitHub] [apisix] tokers commented on a change in pull request #6670: feat: Add the function of hiding header for key-auth plugin

2022-03-27 Thread GitBox
tokers commented on a change in pull request #6670: URL: https://github.com/apache/apisix/pull/6670#discussion_r835999872 ## File path: docs/en/latest/plugins/key-auth.md ## @@ -41,6 +41,7 @@ For route side: | | -- | --- | --- | - | --

[GitHub] [apisix-website] SkyeYoung edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
SkyeYoung edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1078853672 > I found a strange problem. My broswer is in Chinese mode. Page will be redirect to the `//` and show 404 not found. I have tried to solve this problem. Pl

[GitHub] [apisix] tzssangglass commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage

2022-03-27 Thread GitBox
tzssangglass commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1080100342 we can use `ngx.shared.DICT.capacity` and `ngx.shared.DICT.free_space` to monitor a `ngx.shared.DICT`? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] tzssangglass edited a comment on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage

2022-03-27 Thread GitBox
tzssangglass edited a comment on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1080100342 > @tzssangglass Could you share your proposal? we can use `ngx.shared.DICT.capacity` and `ngx.shared.DICT.free_space` to monitor a `ngx.shared.DICT`? -- This

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #939: feat: introduce v2 apiversion

2022-03-27 Thread GitBox
tao12345666333 merged pull request #939: URL: https://github.com/apache/apisix-ingress-controller/pull/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [apisix] spacewander merged pull request #6721: feat(file-logger): cache & reopen file handler

2022-03-27 Thread GitBox
spacewander merged pull request #6721: URL: https://github.com/apache/apisix/pull/6721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: feat(file-logger): cache & reopen file handler (#6721)

2022-03-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 55eb58a feat(file-logger): cache & reopen

[GitHub] [apisix] Hwting closed pull request #6690: docs: polishing openid-connect plugin docs(zh)

2022-03-27 Thread GitBox
Hwting closed pull request #6690: URL: https://github.com/apache/apisix/pull/6690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-go-plugin-runner] rampagecong commented on issue #74: bug: pkgHTTP.Request RespHeader() Add override previous value

2022-03-27 Thread GitBox
rampagecong commented on issue #74: URL: https://github.com/apache/apisix-go-plugin-runner/issues/74#issuecomment-1080118845 Very good idea. I'll give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #937: feat: support forward-auth plugin

2022-03-27 Thread GitBox
tao12345666333 commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1080122018 re-run CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] zhantanfeng commented on issue #6700: help request: apisix在解析域名时失败,出现循环

2022-03-27 Thread GitBox
zhantanfeng commented on issue #6700: URL: https://github.com/apache/apisix/issues/6700#issuecomment-1080124749 > > > > > > > > > I will try with APISIX 2.12, but I tried with 2.13, it can not run. > > If 2.13 has the same problem, 2.12 also suffers from it. Let me see the

[GitHub] [apisix] soulbird commented on issue #6729: feat: As a user, I hope apisix can make some restrictions on the custom functions in the serverless plugin, and the use of illegal code will not ca

2022-03-27 Thread GitBox
soulbird commented on issue #6729: URL: https://github.com/apache/apisix/issues/6729#issuecomment-1080125716 > We may introduce a simple sandbox mechanism firstly, such as make vital data read-only and only allow users to execute write operations in a specific space. LGTM! -- Thi

[GitHub] [apisix] zhantanfeng edited a comment on issue #6700: help request: apisix在解析域名时失败,出现循环

2022-03-27 Thread GitBox
zhantanfeng edited a comment on issue #6700: URL: https://github.com/apache/apisix/issues/6700#issuecomment-1080124749 > > > > > > > > > I will try with APISIX 2.12, but I tried with 2.13, it can not run. > > If 2.13 has the same problem, 2.12 also suffers from it. Let me

[GitHub] [apisix-ingress-controller] cmssczy commented on issue #926: bug: we should create APISIX routes even if Service is created later

2022-03-27 Thread GitBox
cmssczy commented on issue #926: URL: https://github.com/apache/apisix-ingress-controller/issues/926#issuecomment-1080131530 we should create an apisix `upstream` with an empty `nodes` when user creates a `ApisixRoute` with a non-existent `service`. I write a demo for this solution. PTA

[GitHub] [apisix] zhantanfeng edited a comment on issue #6700: help request: apisix在解析域名时失败,出现循环

2022-03-27 Thread GitBox
zhantanfeng edited a comment on issue #6700: URL: https://github.com/apache/apisix/issues/6700#issuecomment-1080124749 > > > > > > > > > I will try with APISIX 2.12, but I tried with 2.13, it can not run. > > If 2.13 has the same problem, 2.12 also suffers from it. Let me

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comm

[GitHub] [apisix-website] yzeng25 opened a new pull request #973: docs: add 2.13 Release Notes

2022-03-27 Thread GitBox
yzeng25 opened a new pull request #973: URL: https://github.com/apache/apisix-website/pull/973 Changes: Add 2.13 Release Notes TODO: Translation + Picture -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-website] netlify[bot] commented on pull request #973: docs: add 2.13 Release Notes

2022-03-27 Thread GitBox
netlify[bot] commented on pull request #973: URL: https://github.com/apache/apisix-website/pull/973#issuecomment-1080152671 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit |

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #973: docs: add 2.13 Release Notes

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #973: URL: https://github.com/apache/apisix-website/pull/973#issuecomment-1080152671 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #926: bug: we should create APISIX routes even if Service is created later

2022-03-27 Thread GitBox
tao12345666333 commented on issue #926: URL: https://github.com/apache/apisix-ingress-controller/issues/926#issuecomment-1080176721 Creating an empty Upstream sounds good. In this way, when the Service is actually created, we can update it again. WDYT @lingsamuel @gxthrj -- This i

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2377: feat: Remove request header data when health check is enabled

2022-03-27 Thread GitBox
codecov-commenter edited a comment on pull request #2377: URL: https://github.com/apache/apisix-dashboard/pull/2377#issuecomment-1075140566 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest co

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix-website] netlify[bot] commented on pull request #974: docs: Style guide for APISIX documentation

2022-03-27 Thread GitBox
netlify[bot] commented on pull request #974: URL: https://github.com/apache/apisix-website/pull/974#issuecomment-1080224965 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit |

[GitHub] [apisix-website] navendu-pottekkat opened a new pull request #974: docs: Style guide for APISIX documentation

2022-03-27 Thread GitBox
navendu-pottekkat opened a new pull request #974: URL: https://github.com/apache/apisix-website/pull/974 Fixes https://github.com/apache/apisix/issues/6672 Changes: - Adds a style guide for APISIX documentation. - Reorganises the Community tab by consolidating and organising

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest co

[GitHub] [apisix-website] navendu-pottekkat commented on pull request #974: docs: Style guide for APISIX documentation

2022-03-27 Thread GitBox
navendu-pottekkat commented on pull request #974: URL: https://github.com/apache/apisix-website/pull/974#issuecomment-1080226965 @juzhiyuan @yzeng25 @avinal @hf400159 Could you please review this PR? I will fix the lint errors. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #974: docs: Style guide for APISIX documentation

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #974: URL: https://github.com/apache/apisix-website/pull/974#issuecomment-1080224965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [apisix] spacewander commented on issue #6700: help request: apisix在解析域名时失败,出现循环

2022-03-27 Thread GitBox
spacewander commented on issue #6700: URL: https://github.com/apache/apisix/issues/6700#issuecomment-1080236505 You can attach the pcap file in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #974: docs: Style guide for APISIX documentation

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #974: URL: https://github.com/apache/apisix-website/pull/974#issuecomment-1080224965 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #973: docs: add 2.13 Release Notes

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #973: URL: https://github.com/apache/apisix-website/pull/973#issuecomment-1080152671 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest co

[GitHub] [apisix] ukanwat opened a new issue #6732: bug: dns service discovery upstreams are not working in GKE

2022-03-27 Thread GitBox
ukanwat opened a new issue #6732: URL: https://github.com/apache/apisix/issues/6732 ### Current Behavior APISIX is throwing an error related to port being 0 when upstream has discovery_type "dns". same exact setup works fine with clusters from other kubernetes providers. ##

[GitHub] [apisix] spacewander opened a new pull request #6733: fix: need to invalidate req hdr cache properly

2022-03-27 Thread GitBox
spacewander opened a new pull request #6733: URL: https://github.com/apache/apisix/pull/6733 Fix #6728 Signed-off-by: spacewander ### Description ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have explained

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #973: docs: add 2.13 Release Notes

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #973: URL: https://github.com/apache/apisix-website/pull/973#issuecomment-1080152671 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix] navendu-pottekkat opened a new issue #6734: docs: Update plugin documentation

2022-03-27 Thread GitBox
navendu-pottekkat opened a new issue #6734: URL: https://github.com/apache/apisix/issues/6734 ### Current State The plugin docs are inconsistent. ### Desired State The plugin docs should be made consistent to enhance readability and make it easy to navigate. It s

[GitHub] [apisix] navendu-pottekkat commented on issue #6734: docs: Update plugin documentation

2022-03-27 Thread GitBox
navendu-pottekkat commented on issue #6734: URL: https://github.com/apache/apisix/issues/6734#issuecomment-1080251879 I will open PRs for each section to fix this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-helm-chart] Gallardot commented on issue #258: [bug] apisix helm charts README.md some config params is wrong

2022-03-27 Thread GitBox
Gallardot commented on issue #258: URL: https://github.com/apache/apisix-helm-chart/issues/258#issuecomment-1080256601 I'd like to have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest co

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest co

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #970: feat: lang detection

2022-03-27 Thread GitBox
netlify[bot] edited a comment on pull request #970: URL: https://github.com/apache/apisix-website/pull/970#issuecomment-1077398855 ### ✅ Deploy Preview for *apache-apisix* ready! | Name | Link | |-|| |🔨 Latest commit

[GitHub] [apisix-website] bzp2010 merged pull request #972: chore: transform to monorepo

2022-03-27 Thread GitBox
bzp2010 merged pull request #972: URL: https://github.com/apache/apisix-website/pull/972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [apisix] zhantanfeng commented on issue #6700: help request: apisix在解析域名时失败,出现循环

2022-03-27 Thread GitBox
zhantanfeng commented on issue #6700: URL: https://github.com/apache/apisix/issues/6700#issuecomment-1080268996 > You can attach the pcap file in this issue. I have uploaded the pcap file. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

  1   2   >