[GitHub] [apisix-helm-chart] JohnnyQianP commented on issue #272: Request help: apisix-etcd Failed to bind volumes: timed out waiting for the condition

2022-04-22 Thread GitBox
JohnnyQianP commented on issue #272: URL: https://github.com/apache/apisix-helm-chart/issues/272#issuecomment-1107377784 ![image](https://user-images.githubusercontent.com/14548092/164879164-623ad939-3aa3-4490-84de-a6b3fb3dbd7a.png) In the pod, etcd has an error, what's the meaning๏ผŸ

[GitHub] [apisix] nic-6443 commented on pull request #6892: fix: upgrade lua-resty-etcd to 1.6.1

2022-04-22 Thread GitBox
nic-6443 commented on PR #6892: URL: https://github.com/apache/apisix/pull/6892#issuecomment-1107366051 @spacewander I got the reason why the `t/node/route-delete.t` test failed. When the last chunk in an event only has a newline, it will cause a delay in event processing. I have submit

[apisix-website] branch asf-site updated (7dc133ec3e6 -> 270eaf99dd4)

2022-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git discard 7dc133ec3e6 deploy: 0d46af8075cb69f455810d40147baef947077d56 new 270eaf99dd4 deploy: 0d46af8075cb69

[GitHub] [apisix] tzssangglass commented on issue #6890: bug: Some random api calls are taking 20 seconds to return from apisix

2022-04-22 Thread GitBox
tzssangglass commented on issue #6890: URL: https://github.com/apache/apisix/issues/6890#issuecomment-1107360550 You can refer to the author of this issue #6834, he provides great reproduction steps, I followed his reproduction steps to locate the problem very accurately and quickly. --

[GitHub] [apisix] tzssangglass commented on issue #6890: bug: Some random api calls are taking 20 seconds to return from apisix

2022-04-22 Thread GitBox
tzssangglass commented on issue #6890: URL: https://github.com/apache/apisix/issues/6890#issuecomment-1107359933 > I hope this helps to understand our use of case The architecture diagram is useful, but the reproduction steps need to be provided so that I can reproduce your problem lo

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #272: Request help: apisix-etcd Failed to bind volumes: timed out waiting for the condition

2022-04-22 Thread GitBox
tao12345666333 commented on issue #272: URL: https://github.com/apache/apisix-helm-chart/issues/272#issuecomment-1107353596 There is already a clear message Failed to bind volumes in the error log. You should check your environments, PV,PVC,SC -- This is

[GitHub] [apisix-helm-chart] JohnnyQianP commented on issue #272: Request help: apisix-etcd Failed to bind volumes: timed out waiting for the condition

2022-04-22 Thread GitBox
JohnnyQianP commented on issue #272: URL: https://github.com/apache/apisix-helm-chart/issues/272#issuecomment-1107349261 ![image](https://user-images.githubusercontent.com/14548092/164873501-d8810afd-c3bc-4f0f-a43b-4b399a57cb62.png) @tao12345666333 I check it below: ``` kubectl

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #271: help request: install apisix by helm in K8S

2022-04-22 Thread GitBox
tao12345666333 commented on issue #271: URL: https://github.com/apache/apisix-helm-chart/issues/271#issuecomment-1106707710 And you can just run `kubectl get sts -n default` , check if `apisix-etcd` exists. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix-helm-chart] JohnnyQianP opened a new issue, #272: Request help: apisix-etcd Failed to bind volumes: timed out waiting for the condition

2022-04-22 Thread GitBox
JohnnyQianP opened a new issue, #272: URL: https://github.com/apache/apisix-helm-chart/issues/272 ![image](https://user-images.githubusercontent.com/14548092/164751511-d7d1bc9f-1122-47a7-befd-abb443e404ab.png) ``` # kubectl get pods -n ingress-apisix NAME REA

[GitHub] [apisix-website] nfrankel commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
nfrankel commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106633824 >But as it turns out, I never got what I wanted.๐Ÿ˜‚ Indeed. So we need a list of requirements and check which ecosystem allows us to write the less code in the most comf

[GitHub] [apisix-website] SkyeYoung commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
SkyeYoung commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106631323 > Either it's close to instant or it's not. For static websites generator, I'm more interested in the richness of the ecosystem. I can understand that. The metrics wi

[GitHub] [apisix-website] nfrankel commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
nfrankel commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-110662 >Because, I don't know if I'll offend you, I still think it's a bit slow, I wish it had a build time of two minutes or less (Measured by the number of your posts). ๐Ÿ˜ณ

[GitHub] [apisix-website] SkyeYoung commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
SkyeYoung commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106620958 > You don't need to write code. It's like saying that you need to know PHP to use WordPress. In fact, this is the problem, IMO.๐Ÿ˜… I've used Wordpress, Ghost, He

[GitHub] [apisix-website] nfrankel commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
nfrankel commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106591828 >E, I think AsciiDoc is a format, and Asciidoctor is a tool chain. (I don't really know it ๐Ÿ˜…) Correct. >I was very concerned about whether using Ruby

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #271: help request: install apisix by helm in K8S

2022-04-22 Thread GitBox
tao12345666333 closed issue #271: help request: install apisix by helm in K8S URL: https://github.com/apache/apisix-helm-chart/issues/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #271: help request: install apisix by helm in K8S

2022-04-22 Thread GitBox
tao12345666333 commented on issue #271: URL: https://github.com/apache/apisix-helm-chart/issues/271#issuecomment-1106537203 You can run ``` helm list ``` Show all releases in current namespace. Then ``` helm delete apisix ``` And re-run h

[GitHub] [apisix] ignaciostellino commented on issue #6890: bug: Some random api calls are taking 20 seconds to return from apisix

2022-04-22 Thread GitBox
ignaciostellino commented on issue #6890: URL: https://github.com/apache/apisix/issues/6890#issuecomment-1106524305 > > > @ignaciostellino Could you describe the case in a more detailed way, we need at least the following information to help you: > > > > > > 1. What do the APIs look l

[GitHub] [apisix] JohnnyQianP opened a new issue, #6913: help request: install apisix by helm in K8S

2022-04-22 Thread GitBox
JohnnyQianP opened a new issue, #6913: URL: https://github.com/apache/apisix/issues/6913 ### Description helm3 install apisix apisix/apisix Error: rendered manifests contain a resource that already exists. Unable to continue with install: StatefulSet "apisix-etcd" in namespace "def

[GitHub] [apisix-website] SkyeYoung commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
SkyeYoung commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106447290 > One thing we have to make sure is that when we create a new site, we should make sure that the website looks same. Like it should not feel like the blogs are different si

[GitHub] [apisix] hf400159 opened a new issue, #6912: docs: Optimize the table structure in plugin documentation.

2022-04-22 Thread GitBox
hf400159 opened a new issue, #6912: URL: https://github.com/apache/apisix/issues/6912 ### Current State In fact, in each plug-in of APISIX, there is a property table, such as the following figure. But this has a problem, for example, the `Default` and `Valid values` columns are mostl

[GitHub] [apisix-website] SkyeYoung commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
SkyeYoung commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106440056 > > But as for the blog program to be used, we would like to get some suggestions. The options that are already under consideration are: > > > > * [Hexo](https://hexo

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #6911: docs: update "Security" docs

2022-04-22 Thread GitBox
navendu-pottekkat commented on code in PR #6911: URL: https://github.com/apache/apisix/pull/6911#discussion_r856153546 ## docs/en/latest/plugins/public-api.md: ## @@ -23,31 +29,28 @@ title: public-api ## Description -The `public-api` plugin is used to enhance the plugin pub

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #6911: docs: update "Security" docs

2022-04-22 Thread GitBox
navendu-pottekkat commented on code in PR #6911: URL: https://github.com/apache/apisix/pull/6911#discussion_r856153415 ## docs/en/latest/plugins/public-api.md: ## @@ -23,31 +29,28 @@ title: public-api ## Description -The `public-api` plugin is used to enhance the plugin pub

[apisix] branch master updated: docs: update "uri-blocker" Plugin docs (#6882)

2022-04-22 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 76623073c docs: update "uri-blocker" Plugin

[GitHub] [apisix] spacewander merged pull request #6882: docs: update "uri-blocker" Plugin docs

2022-04-22 Thread GitBox
spacewander merged PR #6882: URL: https://github.com/apache/apisix/pull/6882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

2022-04-22 Thread GitBox
spacewander commented on code in PR #6908: URL: https://github.com/apache/apisix/pull/6908#discussion_r856146635 ## t/plugin/referer-restriction.t: ## @@ -173,7 +173,6 @@ hello world local cases = { "x.*", "~y.xn", -

[apisix] branch master updated (612b2a6cb -> 72274b4da)

2022-04-22 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from 612b2a6cb docs: update "cors" docs (#6877) add 72274b4da docs: update "ua-restriction" Plugin docs (#6884)

[GitHub] [apisix] spacewander merged pull request #6884: docs: update "ua-restriction" Plugin docs

2022-04-22 Thread GitBox
spacewander merged PR #6884: URL: https://github.com/apache/apisix/pull/6884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated (bf5585a97 -> 612b2a6cb)

2022-04-22 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from bf5585a97 fix: the client verify flag might not be set (#6906) add 612b2a6cb docs: update "cors" docs (#6877

[GitHub] [apisix] spacewander merged pull request #6877: docs: update "cors" docs

2022-04-22 Thread GitBox
spacewander merged PR #6877: URL: https://github.com/apache/apisix/pull/6877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: fix: the client verify flag might not be set (#6906)

2022-04-22 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new bf5585a97 fix: the client verify flag might

[GitHub] [apisix] spacewander closed issue #6896: bug: mtls does not take effect

2022-04-22 Thread GitBox
spacewander closed issue #6896: bug: mtls does not take effect URL: https://github.com/apache/apisix/issues/6896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [apisix] spacewander merged pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
spacewander merged PR #6906: URL: https://github.com/apache/apisix/pull/6906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] tokers commented on pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
tokers commented on PR #6906: URL: https://github.com/apache/apisix/pull/6906#issuecomment-1106419057 > > Anyway to test the fix? > > > > Not so easy to do it. What about writing the case in shell? And use curl to send two requests. -- This is an automated message fro

[GitHub] [apisix] hf400159 closed issue #6833: docs: modify the Chinese version docs.

2022-04-22 Thread GitBox
hf400159 closed issue #6833: docs: modify the Chinese version docs. URL: https://github.com/apache/apisix/issues/6833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [apisix] hf400159 commented on a diff in pull request #6911: docs: update "Security" docs

2022-04-22 Thread GitBox
hf400159 commented on code in PR #6911: URL: https://github.com/apache/apisix/pull/6911#discussion_r856110494 ## docs/en/latest/plugins/public-api.md: ## @@ -23,31 +29,28 @@ title: public-api ## Description -The `public-api` plugin is used to enhance the plugin public API a

[GitHub] [apisix] spacewander commented on pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
spacewander commented on PR #6906: URL: https://github.com/apache/apisix/pull/6906#issuecomment-1106345443 > Anyway to test the fix? Not so easy to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] jwrookie commented on a diff in pull request #975: feat: update an redirect annotation for ingress resource

2022-04-22 Thread GitBox
jwrookie commented on code in PR #975: URL: https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r856064328 ## test/e2e/suite-annotations/redirect.go: ## @@ -119,4 +120,203 @@ spec: resp.Status(http.StatusMovedPermanently) resp

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #975: feat: update an redirect annotation for ingress resource

2022-04-22 Thread GitBox
tao12345666333 commented on code in PR #975: URL: https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r856062133 ## test/e2e/suite-annotations/redirect.go: ## @@ -119,4 +120,203 @@ spec: resp.Status(http.StatusMovedPermanently)

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #979: request help: crd resource does not display correctly

2022-04-22 Thread GitBox
tao12345666333 commented on issue #979: URL: https://github.com/apache/apisix-ingress-controller/issues/979#issuecomment-1106335034 We are in the process of releasing v1.4.1 #980 I will try to reproduce the issue after the release process is over -- This is an automated message from t

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #975: feat: update an redirect annotation for ingress resource

2022-04-22 Thread GitBox
AlinsRan commented on code in PR #975: URL: https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r856058039 ## test/e2e/suite-annotations/redirect.go: ## @@ -119,4 +120,203 @@ spec: resp.Status(http.StatusMovedPermanently) resp

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #974: bug: plugin config in APISIX but do not in declare yaml

2022-04-22 Thread GitBox
tao12345666333 closed issue #974: bug: plugin config in APISIX but do not in declare yaml URL: https://github.com/apache/apisix-ingress-controller/issues/974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #974: bug: plugin config in APISIX but do not in declare yaml

2022-04-22 Thread GitBox
tao12345666333 commented on issue #974: URL: https://github.com/apache/apisix-ingress-controller/issues/974#issuecomment-1106332279 After v1.4.1 is released, you can upgrade to fix this issue. I will close this issue, we will track it with #980 -- This is an automated message from the Ap

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #974: bug: plugin config in APISIX but do not in declare yaml

2022-04-22 Thread GitBox
tao12345666333 commented on issue #974: URL: https://github.com/apache/apisix-ingress-controller/issues/974#issuecomment-1106331315 @GhangZh After discussions we decided to release v1.4.1 #980 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] github-actions[bot] closed issue #4101: request help: How can I add passive health check to discovery register

2022-04-22 Thread GitBox
github-actions[bot] closed issue #4101: request help: How can I add passive health check to discovery register URL: https://github.com/apache/apisix/issues/4101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] github-actions[bot] commented on issue #4101: request help: How can I add passive health check to discovery register

2022-04-22 Thread GitBox
github-actions[bot] commented on issue #4101: URL: https://github.com/apache/apisix/issues/4101#issuecomment-1106329662 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- Th

[GitHub] [apisix-website] nfrankel commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
nfrankel commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106329631 >But as for the blog program to be used, we would like to get some suggestions. The options that are already under consideration are: > >* [Hexo](https://hexo.io/) >

[GitHub] [apisix-website] navendu-pottekkat commented on issue #1048: [Proposal]: refactor Blog module

2022-04-22 Thread GitBox
navendu-pottekkat commented on issue #1048: URL: https://github.com/apache/apisix-website/issues/1048#issuecomment-1106322972 I would suggest using Hugo. I may be biased because I am a Hugo user in my personal blogs and other projects. Hugo is fast and easy. There are even good themes. It

[GitHub] [apisix-ingress-controller] juzhiyuan commented on pull request #972: Doc: add 'enable authentication and restriction' document

2022-04-22 Thread GitBox
juzhiyuan commented on PR #972: URL: https://github.com/apache/apisix-ingress-controller/pull/972#issuecomment-1106282580 And @navendu-pottekkat, also this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] juzhiyuan commented on pull request #973: Doc: add an article on "how to access Apache APISIX Prometheus Metrics on k8s"

2022-04-22 Thread GitBox
juzhiyuan commented on PR #973: URL: https://github.com/apache/apisix-ingress-controller/pull/973#issuecomment-1106281807 Hi, @navendu-pottekkat, please have a review once more when you have time :) -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855999690 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855998506 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855997910 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855995354 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #6883: docs: update "ip-restriction" Plugin docs

2022-04-22 Thread GitBox
juzhiyuan commented on code in PR #6883: URL: https://github.com/apache/apisix/pull/6883#discussion_r855989001 ## docs/en/latest/plugins/ip-restriction.md: ## @@ -1,5 +1,11 @@ --- title: ip-restriction +keywords: + - APISIX + - Plugin + - IP restriction + - ip-restriction

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855986209 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855971043 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request, #981: Prepare v1.4.1

2022-04-22 Thread GitBox
tao12345666333 opened a new pull request, #981: URL: https://github.com/apache/apisix-ingress-controller/pull/981 ### Type of change: - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why we

[GitHub] [apisix-ingress-controller] jwrookie commented on a diff in pull request #975: feat: update an redirect annotation for ingress resource

2022-04-22 Thread GitBox
jwrookie commented on code in PR #975: URL: https://github.com/apache/apisix-ingress-controller/pull/975#discussion_r855952271 ## pkg/kube/translation/annotations/redirect.go: ## @@ -37,8 +41,13 @@ func (r *redirect) PluginName() string { func (r *redirect) Handle(e Extractor)

[GitHub] [apisix] tokers commented on pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
tokers commented on PR #6906: URL: https://github.com/apache/apisix/pull/6906#issuecomment-1106215081 Anyway to test the fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
Chever-John commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855948083 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allo

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #980: release v1.4.1

2022-04-22 Thread GitBox
tao12345666333 commented on issue #980: URL: https://github.com/apache/apisix-ingress-controller/issues/980#issuecomment-1106207774 - [ ] cherry-pick all bugfix - [ ] open PR - [ ] vote - [ ] release - [ ] push docker image - [ ] release Helm chart -- This is an automated m

[GitHub] [apisix-ingress-controller] jwrookie commented on a diff in pull request #976: feat: improve the e2e test of referer-restriction plugin

2022-04-22 Thread GitBox
jwrookie commented on code in PR #976: URL: https://github.com/apache/apisix-ingress-controller/pull/976#discussion_r855926002 ## test/e2e/suite-plugins/referer-restriction.go: ## @@ -101,6 +101,125 @@ spec: resp.Body().Contains("Your referer host is not allowed

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new issue, #980: release v1.4.1

2022-04-22 Thread GitBox
tao12345666333 opened a new issue, #980: URL: https://github.com/apache/apisix-ingress-controller/issues/980 After the release of 1.4.0, we received some feedback from the community and also made related fixes. We originally planned to release v1.5.0 this month, but we currently have

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #973: Doc: add an article on "how to access Apache APISIX Prometheus Metrics on k8s"

2022-04-22 Thread GitBox
Chever-John commented on code in PR #973: URL: https://github.com/apache/apisix-ingress-controller/pull/973#discussion_r855944320 ## docs/en/latest/practices/how-to-access-Apache-APISIX-Prometheus-Metrics-on-k8s.md: ## @@ -0,0 +1,97 @@ +--- +title: How to access Apache APISIX P

[GitHub] [apisix-helm-chart] Gallardot commented on issue #225: Proposal: APISIX can run as DaemonSet

2022-04-22 Thread GitBox
Gallardot commented on issue #225: URL: https://github.com/apache/apisix-helm-chart/issues/225#issuecomment-1106200353 #257 has been merged. I will close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-helm-chart] Gallardot closed issue #225: Proposal: APISIX can run as DaemonSet

2022-04-22 Thread GitBox
Gallardot closed issue #225: Proposal: APISIX can run as DaemonSet URL: https://github.com/apache/apisix-helm-chart/issues/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #973: Doc: add an article on "how to access Apache APISIX Prometheus Metrics on k8s"

2022-04-22 Thread GitBox
Chever-John commented on code in PR #973: URL: https://github.com/apache/apisix-ingress-controller/pull/973#discussion_r855935336 ## docs/en/latest/practices/how-to-access-Apache-APISIX-Prometheus-Metrics-on-k8s.md: ## @@ -0,0 +1,97 @@ +--- +title: How to access Apache APISIX P

[GitHub] [apisix] soulbird commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

2022-04-22 Thread GitBox
soulbird commented on code in PR #6908: URL: https://github.com/apache/apisix/pull/6908#discussion_r855930590 ## apisix/schema_def.lua: ## @@ -37,7 +37,7 @@ local id_schema = { } } -local host_def_pat = "^\\*?[0-9a-zA-Z-._]+$" +local host_def_pat = "^\\*?[0-9a-zA-Z-._\\[

[GitHub] [apisix] membphis commented on a diff in pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
membphis commented on code in PR #6906: URL: https://github.com/apache/apisix/pull/6906#discussion_r855895944 ## apisix/init.lua: ## @@ -870,15 +877,15 @@ function _M.stream_preread_phase() local ngx_ctx = ngx.ctx local api_ctx = ngx_ctx.api_ctx -if not verify_tl

[GitHub] [apisix] membphis commented on a diff in pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
membphis commented on code in PR #6906: URL: https://github.com/apache/apisix/pull/6906#discussion_r855894300 ## apisix/init.lua: ## @@ -350,14 +357,14 @@ end function _M.http_access_phase() local ngx_ctx = ngx.ctx -if not verify_tls_client(ngx_ctx.api_ctx) then -

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #973: Doc: add an article on "how to access Apache APISIX Prometheus Metrics on k8s"

2022-04-22 Thread GitBox
tao12345666333 commented on code in PR #973: URL: https://github.com/apache/apisix-ingress-controller/pull/973#discussion_r855876740 ## docs/en/latest/practices/how-to-access-Apache-APISIX-Prometheus-Metrics-on-k8s.md: ## @@ -0,0 +1,97 @@ +--- +title: How to access Apache APISI

[GitHub] [apisix] membphis commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

2022-04-22 Thread GitBox
membphis commented on code in PR #6908: URL: https://github.com/apache/apisix/pull/6908#discussion_r855870455 ## apisix/schema_def.lua: ## @@ -37,7 +37,7 @@ local id_schema = { } } -local host_def_pat = "^\\*?[0-9a-zA-Z-._]+$" +local host_def_pat = "^\\*?[0-9a-zA-Z-._\\[

[GitHub] [apisix] membphis commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

2022-04-22 Thread GitBox
membphis commented on code in PR #6908: URL: https://github.com/apache/apisix/pull/6908#discussion_r855870455 ## apisix/schema_def.lua: ## @@ -37,7 +37,7 @@ local id_schema = { } } -local host_def_pat = "^\\*?[0-9a-zA-Z-._]+$" +local host_def_pat = "^\\*?[0-9a-zA-Z-._\\[

[GitHub] [apisix] navendu-pottekkat opened a new pull request, #6911: docs: update "Security" docs

2022-04-22 Thread GitBox
navendu-pottekkat opened a new pull request, #6911: URL: https://github.com/apache/apisix/pull/6911 Signed-off-by: Navendu Pottekkat ### Description Updates the documentation of the "referer-restriction", "consumer-restriction", "csrf" and "public-api" Plugins. Child PR

[GitHub] [apisix] membphis commented on a diff in pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
membphis commented on code in PR #6906: URL: https://github.com/apache/apisix/pull/6906#discussion_r855866976 ## apisix/init.lua: ## @@ -313,7 +314,13 @@ end local function verify_tls_client(ctx) -if ctx and ctx.ssl_client_verified then +local matched = router.route

[apisix] branch master updated: feat(xRPC): support dynamic upstream (#6901)

2022-04-22 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 4a0e2903f feat(xRPC): support dynamic upstr

[GitHub] [apisix] spacewander merged pull request #6901: feat(xRPC): support dynamic upstream

2022-04-22 Thread GitBox
spacewander merged PR #6901: URL: https://github.com/apache/apisix/pull/6901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix-ingress-controller] Horus-K commented on issue #979: request help: crd resource does not display correctly

2022-04-22 Thread GitBox
Horus-K commented on issue #979: URL: https://github.com/apache/apisix-ingress-controller/issues/979#issuecomment-1106112987 ![image](https://user-images.githubusercontent.com/48319268/164630754-afebb7ab-c543-4995-ace1-8c8da207de42.png) tls can display correctly -- This is an automate

[GitHub] [apisix-ingress-controller] Horus-K commented on issue #979: request help: crd resource does not display correctly

2022-04-22 Thread GitBox
Horus-K commented on issue #979: URL: https://github.com/apache/apisix-ingress-controller/issues/979#issuecomment-1106098558 I can't display the apisixRoute crd resource correctly using lens and rancher, and the new cluster cannot be displayed properly. Can you use lens or rancher to view

[GitHub] [apisix] spacewander commented on a diff in pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
spacewander commented on code in PR #6906: URL: https://github.com/apache/apisix/pull/6906#discussion_r855844274 ## apisix/init.lua: ## @@ -313,7 +314,13 @@ end local function verify_tls_client(ctx) -if ctx and ctx.ssl_client_verified then +local matched = router.ro

[GitHub] [apisix] spacewander commented on a diff in pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
spacewander commented on code in PR #6906: URL: https://github.com/apache/apisix/pull/6906#discussion_r855843320 ## apisix/init.lua: ## @@ -313,7 +314,13 @@ end local function verify_tls_client(ctx) -if ctx and ctx.ssl_client_verified then +local matched = router.ro

[GitHub] [apisix] membphis commented on a diff in pull request #6906: fix: the client verify flag might not be set

2022-04-22 Thread GitBox
membphis commented on code in PR #6906: URL: https://github.com/apache/apisix/pull/6906#discussion_r855832832 ## apisix/init.lua: ## @@ -313,7 +314,13 @@ end local function verify_tls_client(ctx) -if ctx and ctx.ssl_client_verified then +local matched = router.route

[GitHub] [apisix] spacewander commented on a diff in pull request #6908: fix: upstream nodes cant't include ipv6 addr

2022-04-22 Thread GitBox
spacewander commented on code in PR #6908: URL: https://github.com/apache/apisix/pull/6908#discussion_r855824886 ## t/APISIX.pm: ## @@ -200,7 +200,7 @@ if ($version =~ m/\/apisix-nginx-module/) { $a6_ngx_directives = <<_EOC_; apisix_delay_client_max_body_check on;

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #972: Doc: add 'enable authentication and restriction' document

2022-04-22 Thread GitBox
AlinsRan commented on code in PR #972: URL: https://github.com/apache/apisix-ingress-controller/pull/972#discussion_r855826449 ## docs/en/latest/practices/enable-authentication-and-restriction.md: ## @@ -0,0 +1,385 @@ +--- +title: Enable authentication and restriction +--- + +

[GitHub] [apisix] spacewander opened a new pull request, #6910: chore: the second returned value of ngx.thread.wait is execution result but not err

2022-04-22 Thread GitBox
spacewander opened a new pull request, #6910: URL: https://github.com/apache/apisix/pull/6910 Signed-off-by: spacewander ### Description Fixes # (issue) ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have